GNU bug report logs - #60712
28.2; customize-set-variable won't let you change the type of a choice

Previous Next

Package: emacs;

Reported by: Omar Antolín Camarena <omar.antolin <at> gmail.com>

Date: Tue, 10 Jan 2023 17:37:02 UTC

Severity: normal

Found in version 28.2

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 60712 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 60712 <at> debbugs.gnu.org
Cc: Omar Antolín Camarena <omar.antolin <at> gmail.com>
Subject: Re: bug#60712: 28.2; customize-set-variable won't let you change the
 type of a choice
Date: Sun, 16 Jul 2023 10:27:39 -0300

[Message part 1 (text/plain, inline)]
Mauro Aranda <maurooaranda <at> gmail.com> writes:

> We have this condition in widget-choice-prompt-value:
> ((and (= (length args) 2)
>       (memq old args))
>  (if (eq old (nth 0 args))
>      (nth 1 args)
>    (nth 0 args)))
>
> ARGS holds the choices available in the choice widget and OLD has
> the choice that matches the current value of the choice widget, before
> the user enters a new one.  This branch has been in the code since like
> forever, but I can't explain why it's good to have it.

So, we should respect the value of widget-choice-toggle also when
prompting, of course.  I attach a patch to fix it.
[0001-Don-t-always-toggle-a-choice-when-prompting.patch (text/x-patch, attachment)]
This bug report was last modified 1 year and 303 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.