GNU bug report logs - #60703
Patches to xwidget code

Previous Next

Full log

View this message in rfc822 format

From: Andrew De Angelis <bobodeangelis <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: luangruo <at> yahoo.com, 60703-done <at> debbugs.gnu.org
Subject: bug#60703: Patches to xwidget code
Date: Sat, 4 Mar 2023 18:00:03 -0500

[Message part 1 (text/plain, inline)]

Awesome, thank you so much! Will keep all your suggestions in mind for my
future contributions.

Small question: what are the criteria to be added to `etc/AUTHORS`? Just
wondering if/how my contribution could be mentioned there.

On Thu, Mar 2, 2023 at 5:58 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Andrew De Angelis <bobodeangelis <at> gmail.com>
> > Date: Thu, 23 Feb 2023 22:47:41 -0500
> > Cc: luangruo <at> yahoo.com, 60703 <at> debbugs.gnu.org
> >
> > Let me know if this ChangeLog is fine or you'd like me to make any
> changes.
>
> Thanks, installed on the emacs-29 branch, and closing the bug.
>
> >  The first line of a doc string should be a single complete sentence.
> >
> > I'm not sure I follow: in this case, isn't  this the first line: "Get
> the estimated load progress of XWIDGET, a
> > WebKit widget."? It renders fine when I run `M-x apropos
> xwidget-webkit-estimated-load-progress`. But
> > happy to make any additional changes if needed.
>
> Please ignore that part: I was confused.
>
> Please in the future always accompany the changes with a
> ChangeLog-style commit log message, and mention the bug number there
> if you know it.  Also, use of "git format-patch" is encouraged.  These
> measures make the job of installing your changes much easier.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.