GNU bug report logs - #60703
Patches to xwidget code

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60703: closed (Patches to xwidget code)
Date: Thu, 02 Mar 2023 10:59:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 02 Mar 2023 12:57:54 +0200
with message-id <83fsane7yl.fsf <at> gnu.org>
and subject line Re: bug#60703: Patches to xwidget code
has caused the debbugs.gnu.org bug report #60703,
regarding Patches to xwidget code
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60703: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60703
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andrew De Angelis <bobodeangelis <at> gmail.com>
To: emacs-devel <at> gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Patches to xwidget code
Date: Tue, 10 Jan 2023 00:14:28 -0500

[Message part 3 (text/plain, inline)]

Hello everyone and thanks for all your work!

I have some fixes to the xwidget code that I'd like to contribute.

These should achieve three things
1) fix `xwidget-webkit-current-url' in xwidget.el so that it actually
displays the current URL
2) fix the Objective-C code in nsxwidget.m to eliminate memory leaks
3) implement the function `xwidget-webkit-estimated-load-progress' in
Objective-C, making this functionality available for macOS as well

Regarding 2), I have tested my changes with the Instruments app within the
XCode dev tools. I was able to test them on two different machines: a
MacBook Air M2 running macOS Ventura 13, and an Intel processor running
macOS Big Sur 11.6.7.
When testing with Instruments, it appears that Emacs isn't leaking memory
anymore. I am still seeing some leaks, but according to Instruments, the
responsible libraries are system libraries, and not Emacs itself.
If possible, I would appreciate it if other people can test/profile these
changes as well, and share their feedback.

Assuming the changes are correct and accepted, would it be possible to
include them in the upcoming Emacs 29.1 release?
Technically, none of these are new features; it's just fixes to existing
features.

I intend to keep working on xwidget support for macOS (fixing remaining
issues and implementing missing functionalities), but I'm not sure when
I'll be able to get to it; for now I'd like to start by contributing these
first major fixes.

Thanks in advance for your feedback; let me know if you need anything else
from me.

Best,
Andrew

[Message part 4 (text/html, inline)]

[xwidget-patches.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrew De Angelis <bobodeangelis <at> gmail.com>
Cc: luangruo <at> yahoo.com, 60703-done <at> debbugs.gnu.org
Subject: Re: bug#60703: Patches to xwidget code
Date: Thu, 02 Mar 2023 12:57:54 +0200

> From: Andrew De Angelis <bobodeangelis <at> gmail.com>
> Date: Thu, 23 Feb 2023 22:47:41 -0500
> Cc: luangruo <at> yahoo.com, 60703 <at> debbugs.gnu.org
> 
> Let me know if this ChangeLog is fine or you'd like me to make any changes.

Thanks, installed on the emacs-29 branch, and closing the bug.

>  The first line of a doc string should be a single complete sentence.
> 
> I'm not sure I follow: in this case, isn't  this the first line: "Get the estimated load progress of XWIDGET, a
> WebKit widget."? It renders fine when I run `M-x apropos xwidget-webkit-estimated-load-progress`. But
> happy to make any additional changes if needed.

Please ignore that part: I was confused.

Please in the future always accompany the changes with a
ChangeLog-style commit log message, and mention the bug number there
if you know it.  Also, use of "git format-patch" is encouraged.  These
measures make the job of installing your changes much easier.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.