GNU bug report logs - #60703
Patches to xwidget code

Previous Next

Full log

Message #20 received at 60703 <at> debbugs.gnu.org (full text, mbox):

From: Andrew De Angelis <bobodeangelis <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 60703 <at> debbugs.gnu.org
Subject: Re: bug#60703: Patches to xwidget code
Date: Sat, 21 Jan 2023 01:13:01 -0500

[Message part 1 (text/plain, inline)]

Thank you again for the feedback. Attached is the updated patch.
@Po Lu <luangruo <at> yahoo.com>, you were right about the dealloc method: I
removed it since it was unnecessary.
I think I fixed all the issues you pointed out, but let me know if there's
any other changes needed.

About the copyright assignment, I sent the attached email to assign <at> gnu.org
ten days ago, but haven't gotten a reply yet. Just want to make sure I'm
going about it the right way: do I need to do anything else to get this
done? It's my first contribution so I may be missing something.


On Tue, Jan 10, 2023 at 8:15 PM Po Lu <luangruo <at> yahoo.com> wrote:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> > I don't have an opinion, so if it's OK in your opinion, I'm fine with
> > adding this.  Are we sure this will not affect any important aspects
> > of the build, except where we already have problems?  (I don't see any
> > description of the problems and their solution in the commit log or
> > the comments.)
>
> Yes, these are fixes to a piece of code that is normally off by default,
> and did not work prior to those changes.
>
> > I don't see copyright assignment for Andrew, so this should be settled
> > before accepting the contribution of this magnitude.
>
> Right, thanks for bringing that up.
>

[Message part 2 (text/html, inline)]

[Andrew John De Angelis.eml (message/rfc822, attachment)]

[xwidget-patches-1.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.