From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 00:59:22 2023 Received: (at submit) by debbugs.gnu.org; 10 Jan 2023 05:59:22 +0000 Received: from localhost ([127.0.0.1]:38525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pF7fN-0000gj-H1 for submit@debbugs.gnu.org; Tue, 10 Jan 2023 00:59:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:55530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pF6yB-000816-II for submit@debbugs.gnu.org; Tue, 10 Jan 2023 00:14:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pF6yA-0000h9-VB; Tue, 10 Jan 2023 00:14:42 -0500 Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pF6y9-0001TN-ED; Tue, 10 Jan 2023 00:14:42 -0500 Received: by mail-vs1-xe34.google.com with SMTP id i188so11095115vsi.8; Mon, 09 Jan 2023 21:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=IsCFUsFhZ+LXwZIQMv1Qi3VT9+qP8SUf3Cm30uKUlpI=; b=hALx5oympoxzDfNwN10GqhmhUGJVusUwXbD7L6099xKfamOuWOoek5wV43my+qEbEo PQYY2sGAxXpfCnTxRt/05dOS/CwnDNz/q+BNEW+O/cGmegxMz1CUjmL7NLJNAFsCeQu6 ahi2/nIWu7fqz0PxQcx+EnCfLSbZhUhzxJKptDhovBI0pzZMPuZqHtQ91mhYuzrqv5Wv 7jCtkAfDeaUFoXbzX/B/DdO5WERqR/mhU4bKzo4ZIhvRQRK71vcvlFA4WpN7Rk+ygR0F IZcSqF4Ifs6OdIqQPlVCfu9ntncFwsWmy4zxqU9ef95hJ/EUhbkH6NnbrihHNeOoSaBI HytQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IsCFUsFhZ+LXwZIQMv1Qi3VT9+qP8SUf3Cm30uKUlpI=; b=fsa+6AAGclL1WsqaB69MWtAeUkyD3iTFxrBXj1fG54lfuKdcDkPhFUrfauIB1ITWf9 v+4AJOQ0PeK3gHy7wGOwaQEsZwqyoeEG1DU67pqPHeMgQCRhBXsy17AEESWfn7H3hF7f ptAwBed61vUdPtdLHa+vKS9l93B7EgOvZ3175tc3joM3XOgrSLkcQYVLoDn3qLBiQBEt Sjhwitqp/SNP+3J7pKWGFCmlBIqr6b0BSihF5JNAsLDkLBh1OPZEgnRdB0JwcECc88pz Dtx8k5v0Aix5FSgYFr3PpSJc94NYOP/j+iJtskH43/9OS5CN/WsAwHYNd687uSV7TPxH Z1rA== X-Gm-Message-State: AFqh2kq2mjCR0cM4Chx+t8zhB6GNnJZ212YD/CPPArtdCMXVn8miXlm8 owhZA19OOY3gF1Xv+++tYoyv0gwe4I1gKQUuR+hoKjIQu88= X-Google-Smtp-Source: AMrXdXtcybgdzD6cgBlpi68C0eUDbl2bE3YS0zlsD/u2PPO99WsgWiezNs9TTuDlhYqfmumenXTBxCXTYRdcnI0/FDc= X-Received: by 2002:a05:6102:374d:b0:3d0:af13:3b6 with SMTP id u13-20020a056102374d00b003d0af1303b6mr639055vst.65.1673327679366; Mon, 09 Jan 2023 21:14:39 -0800 (PST) MIME-Version: 1.0 From: Andrew De Angelis Date: Tue, 10 Jan 2023 00:14:28 -0500 Message-ID: Subject: Patches to xwidget code To: emacs-devel@gnu.org, bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000ec3e0a05f1e1f516" Received-SPF: pass client-ip=2607:f8b0:4864:20::e34; envelope-from=bobodeangelis@gmail.com; helo=mail-vs1-xe34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 10 Jan 2023 00:59:17 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000ec3e0a05f1e1f516 Content-Type: multipart/alternative; boundary="000000000000ec3e0705f1e1f514" --000000000000ec3e0705f1e1f514 Content-Type: text/plain; charset="UTF-8" Hello everyone and thanks for all your work! I have some fixes to the xwidget code that I'd like to contribute. These should achieve three things 1) fix `xwidget-webkit-current-url' in xwidget.el so that it actually displays the current URL 2) fix the Objective-C code in nsxwidget.m to eliminate memory leaks 3) implement the function `xwidget-webkit-estimated-load-progress' in Objective-C, making this functionality available for macOS as well Regarding 2), I have tested my changes with the Instruments app within the XCode dev tools. I was able to test them on two different machines: a MacBook Air M2 running macOS Ventura 13, and an Intel processor running macOS Big Sur 11.6.7. When testing with Instruments, it appears that Emacs isn't leaking memory anymore. I am still seeing some leaks, but according to Instruments, the responsible libraries are system libraries, and not Emacs itself. If possible, I would appreciate it if other people can test/profile these changes as well, and share their feedback. Assuming the changes are correct and accepted, would it be possible to include them in the upcoming Emacs 29.1 release? Technically, none of these are new features; it's just fixes to existing features. I intend to keep working on xwidget support for macOS (fixing remaining issues and implementing missing functionalities), but I'm not sure when I'll be able to get to it; for now I'd like to start by contributing these first major fixes. Thanks in advance for your feedback; let me know if you need anything else from me. Best, Andrew --000000000000ec3e0705f1e1f514 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello everyone and thanks for all your work!

I have some fixes to the xwidget code that I'd like to= contribute.

These should achieve three things
=
1) fix `xwidget-webkit-current-url' in xwidget.el so that it= actually displays the current URL
2) fix the Objective-C code in= nsxwidget.m to eliminate memory leaks
3) implement the function = `xwidget-webkit-estimated-load-progress' in Objective-C, making this fu= nctionality available for macOS as well

Regard= ing 2), I have tested my changes with the Instruments app within the XCode = dev tools. I was able to test them on two different machines: a MacBook Air= M2 running macOS Ventura 13, and an Intel processor running macOS Big Sur = 11.6.7.
When testing with Instruments, it appears that Emacs isn&= #39;t leaking memory anymore. I am still seeing some leaks, but according t= o Instruments, the responsible libraries are system libraries, and not Emac= s itself.
If possible, I would appreciate it if other people can = test/profile these changes as well, and share their feedback.
Assuming the changes are correct and accepted, would it be poss= ible to include them in the upcoming Emacs 29.1 release?
Technica= lly, none of these are new features; it's just fixes to existing featur= es.

I intend to keep working on xwidget support fo= r macOS (fixing remaining issues and implementing missing functionalities),= but I'm not sure when I'll be able to get to it; for now I'd l= ike to start by contributing these first major fixes.

<= div>Thanks in advance for your feedback; let me know if you need anything e= lse from me.

Best,
Andrew
--000000000000ec3e0705f1e1f514-- --000000000000ec3e0a05f1e1f516 Content-Type: application/octet-stream; name="xwidget-patches.patch" Content-Disposition: attachment; filename="xwidget-patches.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lcpr78lc0 ZGlmZiAtLWdpdCBhL2xpc3AveHdpZGdldC5lbCBiL2xpc3AveHdpZGdldC5lbAppbmRleCBhYmJk YTI5MDgxLi44MDk1ZmE5ZGI1IDEwMDY0NAotLS0gYS9saXNwL3h3aWRnZXQuZWwKKysrIGIvbGlz cC94d2lkZ2V0LmVsCkBAIC05MjQsOCArOTI0LDkgQEAgeHdpZGdldC13ZWJraXQtcmVsb2FkCiAo ZGVmdW4geHdpZGdldC13ZWJraXQtY3VycmVudC11cmwgKCkKICAgIkRpc3BsYXkgdGhlIGN1cnJl bnQgeHdpZGdldCB3ZWJraXQgVVJMIGFuZCBwbGFjZSBpdCBvbiB0aGUgYGtpbGwtcmluZycuIgog ICAoaW50ZXJhY3RpdmUgbmlsIHh3aWRnZXQtd2Via2l0LW1vZGUpCi0gIChsZXQgKCh1cmwgKHh3 aWRnZXQtd2Via2l0LXVyaSAoeHdpZGdldC13ZWJraXQtY3VycmVudC1zZXNzaW9uKSkpKQotICAg IChtZXNzYWdlICJVUkw6ICVzIiAoa2lsbC1uZXcgKG9yIHVybCAiIikpKSkpCisgIChsZXQgKCh1 cmwgKG9yICh4d2lkZ2V0LXdlYmtpdC11cmkgKHh3aWRnZXQtd2Via2l0LWN1cnJlbnQtc2Vzc2lv bikpICIiKSkpCisgICAgKGtpbGwtbmV3IHVybCkKKyAgICAobWVzc2FnZSAiVVJMOiAlcyIgdXJs KSkpCiAKIChkZWZ1biB4d2lkZ2V0LXdlYmtpdC1icm93c2UtaGlzdG9yeSAoKQogICAiRGlzcGxh eSBhIGJ1ZmZlciBjb250YWluaW5nIHRoZSBoaXN0b3J5IG9mIHBhZ2UgbG9hZHMuIgpkaWZmIC0t Z2l0IGEvc3JjL25zeHdpZGdldC5oIGIvc3JjL25zeHdpZGdldC5oCmluZGV4IDhkNTVmYWM1MzIu LjJiNTU5NmY5MDUgMTAwNjQ0Ci0tLSBhL3NyYy9uc3h3aWRnZXQuaAorKysgYi9zcmMvbnN4d2lk Z2V0LmgKQEAgLTM2LDYgKzM2LDggQEAgI2RlZmluZSBOU1hXSURHRVRfSF9JTkNMVURFRAogTGlz cF9PYmplY3QgbnN4d2lkZ2V0X3dlYmtpdF90aXRsZSAoc3RydWN0IHh3aWRnZXQgKnh3KTsKIHZv aWQgbnN4d2lkZ2V0X3dlYmtpdF9nb3RvX3VyaSAoc3RydWN0IHh3aWRnZXQgKnh3LCBjb25zdCBj aGFyICp1cmkpOwogdm9pZCBuc3h3aWRnZXRfd2Via2l0X2dvdG9faGlzdG9yeSAoc3RydWN0IHh3 aWRnZXQgKnh3LCBpbnQgcmVsX3Bvcyk7Citkb3VibGUgbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0 ZWRfbG9hZF9wcm9ncmVzcyhzdHJ1Y3QgeHdpZGdldCAqeHcpOwordm9pZCBuc3h3aWRnZXRfd2Vi a2l0X3N0b3BfbG9hZGluZyAoc3RydWN0IHh3aWRnZXQgKnh3KTsKIHZvaWQgbnN4d2lkZ2V0X3dl YmtpdF96b29tIChzdHJ1Y3QgeHdpZGdldCAqeHcsIGRvdWJsZSB6b29tX2NoYW5nZSk7CiB2b2lk IG5zeHdpZGdldF93ZWJraXRfZXhlY3V0ZV9zY3JpcHQgKHN0cnVjdCB4d2lkZ2V0ICp4dywgY29u c3QgY2hhciAqc2NyaXB0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBM aXNwX09iamVjdCBmdW4pOwpkaWZmIC0tZ2l0IGEvc3JjL25zeHdpZGdldC5tIGIvc3JjL25zeHdp ZGdldC5tCmluZGV4IGUxZmJkNzQ5YjYuLmFhZjg2N2JjZGQgMTAwNjQ0Ci0tLSBhL3NyYy9uc3h3 aWRnZXQubQorKysgYi9zcmMvbnN4d2lkZ2V0Lm0KQEAgLTU3LDEyICs1NywxOCBAQCBAaW50ZXJm YWNlIFh3V2ViVmlldyA6IFdLV2ViVmlldwogQGVuZAogQGltcGxlbWVudGF0aW9uIFh3V2ViVmll dyA6IFdLV2ViVmlldwogCistICh2b2lkKWRlYWxsb2MKK3sKKyAgW3N1cGVyIGRlYWxsb2NdOwor fQorCiAtIChpZClpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUKICAgICAgIGNvbmZpZ3VyYXRp b246KFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gKiljb25maWd1cmF0aW9uCiAgICAgICAgICAgICB4 d2lkZ2V0OihzdHJ1Y3QgeHdpZGdldCAqKXh3CiB7CiAgIC8qIFNjcmlwdCBjb250cm9sbGVyIHRv IGFkZCBzY3JpcHQgbWVzc2FnZSBoYW5kbGVyIGFuZCB1c2VyIHNjcmlwdC4gICovCi0gIFdLVXNl ckNvbnRlbnRDb250cm9sbGVyICpzY3JpcHRvciA9IFtbV0tVc2VyQ29udGVudENvbnRyb2xsZXIg YWxsb2NdIGluaXRdOworICBXS1VzZXJDb250ZW50Q29udHJvbGxlciAqc2NyaXB0b3IgPSBbW1tX S1VzZXJDb250ZW50Q29udHJvbGxlciBhbGxvY10gaW5pdF0KKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBhdXRvcmVsZWFzZV07CiAgIGNvbmZpZ3VyYXRpb24udXNlckNv bnRlbnRDb250cm9sbGVyID0gc2NyaXB0b3I7CiAKICAgLyogRW5hYmxlIGluc3BlY3QgZWxlbWVu dCBjb250ZXh0IG1lbnUgaXRlbSBmb3IgZGVidWdnaW5nLiAgKi8KQEAgLTgxLDcgKzg3LDggQEAg LSAoaWQpaW5pdFdpdGhGcmFtZTooQ0dSZWN0KWZyYW1lCiAgIGlmIChzZWxmKQogICAgIHsKICAg ICAgIHNlbGYueHcgPSB4dzsKLSAgICAgIHNlbGYudXJsU2NyaXB0QmxvY2tlZCA9IFtbTlNNdXRh YmxlRGljdGlvbmFyeSBhbGxvY10gaW5pdF07CisgICAgICBzZWxmLnVybFNjcmlwdEJsb2NrZWQg PSBbW1tOU011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBhdXRvcmVsZWFzZV07CiAgICAgICBzZWxmLm5hdmlnYXRpb25EZWxlZ2F0 ZSA9IHNlbGY7CiAgICAgICBzZWxmLlVJRGVsZWdhdGUgPSBzZWxmOwogICAgICAgc2VsZi5jdXN0 b21Vc2VyQWdlbnQgPQpAQCAtODksMTEgKzk2LDEzIEBAIC0gKGlkKWluaXRXaXRoRnJhbWU6KENH UmVjdClmcmFtZQogICAgICAgICBAIiBBcHBsZVdlYktpdC82MDMuMy44IChLSFRNTCwgbGlrZSBH ZWNrbykiCiAgICAgICAgIEAiIFZlcnNpb24vMTEuMC4xIFNhZmFyaS82MDMuMy44IjsKICAgICAg IFtzY3JpcHRvciBhZGRTY3JpcHRNZXNzYWdlSGFuZGxlcjpzZWxmIG5hbWU6QCJrZXlEb3duIl07 Ci0gICAgICBbc2NyaXB0b3IgYWRkVXNlclNjcmlwdDpbW1dLVXNlclNjcmlwdCBhbGxvY10KLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5pdFdpdGhTb3VyY2U6eHdTY3JpcHQKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluamVjdGlvblRpbWU6Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgV0tVc2VyU2NyaXB0SW5qZWN0aW9uVGltZUF0RG9jdW1l bnRTdGFydAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3JNYWluRnJhbWVPbmx5 Ok5PXV07CisgICAgICBXS1VzZXJTY3JpcHQgKnVzZXJTY3JpcHQgPSBbW1tXS1VzZXJTY3JpcHQg YWxsb2NdCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbml0V2l0aFNvdXJj ZTp4d1NjcmlwdAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluamVjdGlv blRpbWU6CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdLVXNlclNjcmlw dEluamVjdGlvblRpbWVBdERvY3VtZW50U3RhcnQKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZvck1haW5GcmFtZU9ubHk6Tk9dCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGF1dG9yZWxlYXNlXTsKKyAgICAgIFtzY3JpcHRvciBhZGRVc2VyU2NyaXB0OnVz ZXJTY3JpcHRdOwogICAgIH0KICAgcmV0dXJuIHNlbGY7CiB9CkBAIC0xMDIsNyArMTExLDI3IEBA IC0gKHZvaWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldwogZGlkRmluaXNoTmF2aWdhdGlv bjooV0tOYXZpZ2F0aW9uICopbmF2aWdhdGlvbgogewogICBpZiAoRVEgKEZidWZmZXJfbGl2ZV9w IChzZWxmLnh3LT5idWZmZXIpLCBRdCkpCi0gICAgc3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcg KHNlbGYueHcsICJsb2FkLWNoYW5nZWQiLCAiIik7CisgICAgc3RvcmVfeHdpZGdldF9ldmVudF9z dHJpbmcgKHNlbGYueHcsICJsb2FkLWNoYW5nZWQiLCAibG9hZC1maW5pc2hlZCIpOworfQorCist ICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgZGlkU3RhcnRQcm92aXNpb25hbE5h dmlnYXRpb246KFdLTmF2aWdhdGlvbiAqKW5hdmlnYXRpb24KK3sKKyAgaWYgKEVRIChGYnVmZmVy X2xpdmVfcCAoc2VsZi54dy0+YnVmZmVyKSwgUXQpKQorICAgIHN0b3JlX3h3aWRnZXRfZXZlbnRf c3RyaW5nIChzZWxmLnh3LCAibG9hZC1jaGFuZ2VkIiwgImxvYWQtc3RhcnRlZCIpOworfQorCist ICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKK2RpZFJlY2VpdmVTZXJ2ZXJSZWRp cmVjdEZvclByb3Zpc2lvbmFsTmF2aWdhdGlvbjooV0tOYXZpZ2F0aW9uICopbmF2aWdhdGlvbgor eworICBpZiAoRVEgKEZidWZmZXJfbGl2ZV9wIChzZWxmLnh3LT5idWZmZXIpLCBRdCkpCisgICAg c3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYueHcsICJsb2FkLWNoYW5nZWQiLCAibG9h ZC1yZWRpcmVjdGVkIik7Cit9CisKKy8vIFN0YXJ0IGxvYWRpbmcgV0tXZWJWaWV3CistICh2b2lk KXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgZGlkQ29tbWl0TmF2aWdhdGlvbjooV0tOYXZp Z2F0aW9uICopbmF2aWdhdGlvbgoreworICBpZiAoRVEgKEZidWZmZXJfbGl2ZV9wIChzZWxmLnh3 LT5idWZmZXIpLCBRdCkpIC8vIHdoYXQgZXhhY3RseSBpcyB0aGlzIHRlc3QgZm9yCisgICAgc3Rv cmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYueHcsICJsb2FkLWNoYW5nZWQiLCAibG9hZC1j b21taXR0ZWQiKTsKIH0KIAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CkBA IC0zNDMsNiArMzcyLDIwIEBAIC0gKHZvaWQpdXNlckNvbnRlbnRDb250cm9sbGVyOihXS1VzZXJD b250ZW50Q29udHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxlcgogICB9CiB9CiAKK2RvdWJs ZQorbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyhzdHJ1Y3QgeHdpZGdl dCAqeHcpCit7CisgIFh3V2ViVmlldyAqeHdXZWJWaWV3ID0gKFh3V2ViVmlldyAqKSB4dy0+eHdX aWRnZXQ7CisgIHJldHVybiB4d1dlYlZpZXcuZXN0aW1hdGVkUHJvZ3Jlc3M7Cit9CisKK3ZvaWQK K25zeHdpZGdldF93ZWJraXRfc3RvcF9sb2FkaW5nIChzdHJ1Y3QgeHdpZGdldCAqeHcpCit7Cisg IFh3V2ViVmlldyAqeHdXZWJWaWV3ID0gKFh3V2ViVmlldyAqKSB4dy0+eHdXaWRnZXQ7CisgIFt4 d1dlYlZpZXcgc3RvcExvYWRpbmddOworfQorCiB2b2lkCiBuc3h3aWRnZXRfd2Via2l0X3pvb20g KHN0cnVjdCB4d2lkZ2V0ICp4dywgZG91YmxlIHpvb21fY2hhbmdlKQogewpAQCAtNDUyLDcgKzQ5 NSw4IEBAIC0gKEJPT0wpaXNGbGlwcGVkIHsgcmV0dXJuIFlFUzsgfQogICBOU1JlY3QgcmVjdCA9 IE5TTWFrZVJlY3QgKDAsIDAsIHh3LT53aWR0aCwgeHctPmhlaWdodCk7CiAgIHh3LT54d1dpZGdl dCA9IFtbWHdXZWJWaWV3IGFsbG9jXQogICAgICAgICAgICAgICAgICAgIGluaXRXaXRoRnJhbWU6 cmVjdAotICAgICAgICAgICAgICAgICAgIGNvbmZpZ3VyYXRpb246W1tXS1dlYlZpZXdDb25maWd1 cmF0aW9uIGFsbG9jXSBpbml0XQorICAgICAgICAgICAgICAgICAgIGNvbmZpZ3VyYXRpb246W1tb V0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0KKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYXV0b3JlbGVhc2VdCiAgICAgICAgICAgICAgICAgICAgICAgICAgeHdp ZGdldDp4d107CiAgIHh3LT54d1dpbmRvdyA9IFtbWHdXaW5kb3cgYWxsb2NdCiAgICAgICAgICAg ICAgICAgICAgaW5pdFdpdGhGcmFtZTpyZWN0XTsKQEAgLTQ3MCwxNiArNTE0LDE4IEBAIC0gKEJP T0wpaXNGbGlwcGVkIHsgcmV0dXJuIFlFUzsgfQogICAgICAgICAoKFh3V2ViVmlldyAqKSB4dy0+ eHdXaWRnZXQpLmNvbmZpZ3VyYXRpb24udXNlckNvbnRlbnRDb250cm9sbGVyOwogICAgICAgW3Nj cmlwdG9yIHJlbW92ZUFsbFVzZXJTY3JpcHRzXTsKICAgICAgIFtzY3JpcHRvciByZW1vdmVTY3Jp cHRNZXNzYWdlSGFuZGxlckZvck5hbWU6QCJrZXlEb3duIl07Ci0gICAgICBbc2NyaXB0b3IgcmVs ZWFzZV07CisKICAgICAgIGlmICh4dy0+eHYpCiAgICAgICAgIHh3LT54di0+bW9kZWwgPSBRbmls OyAvKiBNYWtlIHN1cmUgcmVsYXRlZCB2aWV3IHN0YWxlLiAgKi8KIAogICAgICAgLyogVGhpcyBz dG9wcyBwbGF5aW5nIGF1ZGlvIHdoZW4gYSB4d2lkZ2V0LXdlYmtpdCBidWZmZXIgaXMKLSAgICAg ICAgIGtpbGxlZC4gIEkgY291bGQgbm90IGZpbmQgb3RoZXIgc29sdXRpb24uICAqLworICAgICAg ICAga2lsbGVkLiAgSSBjb3VsZCBub3QgZmluZCBvdGhlciBzb2x1dGlvbi4KKyAgICAgICAgIFRP RE86IGltcHJvdmUgdGhpcyAqLwogICAgICAgbnN4d2lkZ2V0X3dlYmtpdF9nb3RvX3VyaSAoeHcs ICJhYm91dDpibGFuayIpOwogCiAgICAgICBbKChYd1dlYlZpZXcgKikgeHctPnh3V2lkZ2V0KS51 cmxTY3JpcHRCbG9ja2VkIHJlbGVhc2VdOwogICAgICAgW3h3LT54d1dpZGdldCByZW1vdmVGcm9t U3VwZXJ2aWV3V2l0aG91dE5lZWRpbmdEaXNwbGF5XTsKKwogICAgICAgW3h3LT54d1dpZGdldCBy ZWxlYXNlXTsKICAgICAgIFt4dy0+eHdXaW5kb3cgcmVtb3ZlRnJvbVN1cGVydmlld1dpdGhvdXRO ZWVkaW5nRGlzcGxheV07CiAgICAgICBbeHctPnh3V2luZG93IHJlbGVhc2VdOwpkaWZmIC0tZ2l0 IGEvc3JjL3h3aWRnZXQuYyBiL3NyYy94d2lkZ2V0LmMKaW5kZXggZWZlMjcwNTU2Mi4uYjk1NTBk YTQ2MCAxMDA2NDQKLS0tIGEvc3JjL3h3aWRnZXQuYworKysgYi9zcmMveHdpZGdldC5jCkBAIC01 NCw2ICs1NCw3IEBAIENvcHlyaWdodCAoQykgMjAxMS0yMDIzIEZyZWUgU29mdHdhcmUgRm91bmRh dGlvbiwgSW5jLgogCiAjaW5jbHVkZSA8bWF0aC5oPgogCisKIHN0YXRpYyBMaXNwX09iamVjdCBp ZF90b194d2lkZ2V0X21hcDsKIHN0YXRpYyBMaXNwX09iamVjdCBpbnRlcm5hbF94d2lkZ2V0X3Zp ZXdfbGlzdDsKIHN0YXRpYyBMaXNwX09iamVjdCBpbnRlcm5hbF94d2lkZ2V0X2xpc3Q7CkBAIC00 OTAsMTAgKzQ5MSwxMCBAQCBERUZVTiAoInh3aWRnZXQtcGVyZm9ybS1saXNweS1ldmVudCIsCiB7 CiAgIHN0cnVjdCB4d2lkZ2V0ICp4dzsKICAgc3RydWN0IGZyYW1lICpmID0gTlVMTDsKLSAgaW50 IGNoYXJhY3RlciA9IC0xLCBrZXljb2RlID0gLTE7Ci0gIGludCBtb2RpZmllcnMgPSAwOwogCiAj aWZkZWYgVVNFX0dUSworICBpbnQgY2hhcmFjdGVyID0gLTEsIGtleWNvZGUgPSAtMTsKKyAgaW50 IG1vZGlmaWVycyA9IDA7CiAgIEdka0V2ZW50ICp4Z19ldmVudDsKICAgR3RrQ29udGFpbmVyQ2xh c3MgKmtsYXNzOwogICBHdGtXaWRnZXQgKndpZGdldDsKQEAgLTMwNjMsNiArMzA2NCwzNiBAQCBE RUZVTiAoInh3aWRnZXQtd2Via2l0LXRpdGxlIiwKICNlbmRpZgogfQogCitERUZVTiAoInh3aWRn ZXQtd2Via2l0LWVzdGltYXRlZC1sb2FkLXByb2dyZXNzIiwKKyAgICAgICBGeHdpZGdldF93ZWJr aXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MsIFN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9h ZF9wcm9ncmVzcywKKyAgICAgICAxLCAxLCAwLCBkb2M6IC8qIEdldCB0aGUgZXN0aW1hdGVkIGxv YWQgcHJvZ3Jlc3Mgb2YgWFdJREdFVCwgYSBXZWJLaXQgd2lkZ2V0LgorUmV0dXJuIGEgdmFsdWUg cmFuZ2luZyBmcm9tIDAuMCB0byAxLjAsIGJhc2VkIG9uIGhvdyBjbG9zZSBYV0lER0VUCitpcyB0 byBjb21wbGV0ZWx5IGxvYWRpbmcgaXRzIHBhZ2UuICAqLykKKyAgKExpc3BfT2JqZWN0IHh3aWRn ZXQpCit7CisgIHN0cnVjdCB4d2lkZ2V0ICp4dzsKKyNpZmRlZiBVU0VfR1RLCisgIFdlYktpdFdl YlZpZXcgKndlYnZpZXc7CisjZW5kaWYKKyAgZG91YmxlIHZhbHVlOworCisgIENIRUNLX0xJVkVf WFdJREdFVCAoeHdpZGdldCk7CisgIHh3ID0gWFhXSURHRVQgKHh3aWRnZXQpOworICBDSEVDS19X RUJLSVRfV0lER0VUICh4dyk7CisKKyAgYmxvY2tfaW5wdXQgKCk7CisjaWZkZWYgVVNFX0dUSwor ICB3ZWJ2aWV3ID0gV0VCS0lUX1dFQl9WSUVXICh4dy0+d2lkZ2V0X29zcik7CisgIHZhbHVlID0g d2Via2l0X3dlYl92aWV3X2dldF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyAod2Vidmlldyk7Cisj ZWxpZiBkZWZpbmVkIE5TX0lNUExfQ09DT0EKKyAgdmFsdWUgPSBuc3h3aWRnZXRfd2Via2l0X2Vz dGltYXRlZF9sb2FkX3Byb2dyZXNzICh4dyk7CisjZW5kaWYKKworICB1bmJsb2NrX2lucHV0ICgp OworCisgIHJldHVybiBtYWtlX2Zsb2F0ICh2YWx1ZSk7Cit9CisKIERFRlVOICgieHdpZGdldC13 ZWJraXQtZ290by11cmkiLAogICAgICAgIEZ4d2lkZ2V0X3dlYmtpdF9nb3RvX3VyaSwgU3h3aWRn ZXRfd2Via2l0X2dvdG9fdXJpLAogICAgICAgIDIsIDIsIDAsCkBAIC0zODEwLDI4ICszODQxLDYg QEAgREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC1iYWNrLWZvcndhcmQtbGlzdCIsIEZ4d2lkZ2V0X3dl YmtpdF9iYWNrX2ZvcndhcmRfbGlzdCwKICAgcmV0dXJuIGxpc3QzIChiYWNrLCBoZXJlLCBmb3J3 YXJkKTsKIH0KIAotREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC1lc3RpbWF0ZWQtbG9hZC1wcm9ncmVz cyIsCi0gICAgICAgRnh3aWRnZXRfd2Via2l0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzLCBTeHdp ZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MsCi0gICAgICAgMSwgMSwgMCwgZG9j OiAvKiBHZXQgdGhlIGVzdGltYXRlZCBsb2FkIHByb2dyZXNzIG9mIFhXSURHRVQsIGEgV2ViS2l0 IHdpZGdldC4KLVJldHVybiBhIHZhbHVlIHJhbmdpbmcgZnJvbSAwLjAgdG8gMS4wLCBiYXNlZCBv biBob3cgY2xvc2UgWFdJREdFVAotaXMgdG8gY29tcGxldGVseSBsb2FkaW5nIGl0cyBwYWdlLiAg Ki8pCi0gIChMaXNwX09iamVjdCB4d2lkZ2V0KQotewotICBzdHJ1Y3QgeHdpZGdldCAqeHc7Ci0g IFdlYktpdFdlYlZpZXcgKndlYnZpZXc7Ci0gIGRvdWJsZSB2YWx1ZTsKLQotICBDSEVDS19MSVZF X1hXSURHRVQgKHh3aWRnZXQpOwotICB4dyA9IFhYV0lER0VUICh4d2lkZ2V0KTsKLSAgQ0hFQ0tf V0VCS0lUX1dJREdFVCAoeHcpOwotCi0gIGJsb2NrX2lucHV0ICgpOwotICB3ZWJ2aWV3ID0gV0VC S0lUX1dFQl9WSUVXICh4dy0+d2lkZ2V0X29zcik7Ci0gIHZhbHVlID0gd2Via2l0X3dlYl92aWV3 X2dldF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyAod2Vidmlldyk7Ci0gIHVuYmxvY2tfaW5wdXQg KCk7Ci0KLSAgcmV0dXJuIG1ha2VfZmxvYXQgKHZhbHVlKTsKLX0KICNlbmRpZgogCiBERUZVTiAo Inh3aWRnZXQtd2Via2l0LXNldC1jb29raWUtc3RvcmFnZS1maWxlIiwKQEAgLTM4NzQsMTkgKzM4 ODMsMjMgQEAgREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC1zdG9wLWxvYWRpbmciLCBGeHdpZGdldF93 ZWJraXRfc3RvcF9sb2FkaW5nLAogWFdJREdFVCBhcyBwYXJ0IG9mIGxvYWRpbmcgYSBwYWdlLiAg Ki8pCiAgIChMaXNwX09iamVjdCB4d2lkZ2V0KQogewotI2lmZGVmIFVTRV9HVEsKICAgc3RydWN0 IHh3aWRnZXQgKnh3OworI2lmZGVmIFVTRV9HVEsKICAgV2ViS2l0V2ViVmlldyAqd2VidmlldzsK KyNlbmRpZgogCiAgIENIRUNLX0xJVkVfWFdJREdFVCAoeHdpZGdldCk7CiAgIHh3ID0gWFhXSURH RVQgKHh3aWRnZXQpOwogICBDSEVDS19XRUJLSVRfV0lER0VUICh4dyk7CiAKICAgYmxvY2tfaW5w dXQgKCk7CisjaWZkZWYgVVNFX0dUSwogICB3ZWJ2aWV3ID0gV0VCS0lUX1dFQl9WSUVXICh4dy0+ d2lkZ2V0X29zcik7CiAgIHdlYmtpdF93ZWJfdmlld19zdG9wX2xvYWRpbmcgKHdlYnZpZXcpOwot ICB1bmJsb2NrX2lucHV0ICgpOworI2VsaWYgZGVmaW5lZCBOU19JTVBMX0NPQ09BCisgIG5zeHdp ZGdldF93ZWJraXRfc3RvcF9sb2FkaW5nICh4dyk7CiAjZW5kaWYKKyAgdW5ibG9ja19pbnB1dCAo KTsKIAogICByZXR1cm4gUW5pbDsKIH0KQEAgLTM5MzYsOCArMzk0OSw5IEBAIHN5bXNfb2ZfeHdp ZGdldCAodm9pZCkKICNpZmRlZiBVU0VfR1RLCiAgIGRlZnN1YnIgKCZTeHdpZGdldF93ZWJraXRf bG9hZF9odG1sKTsKICAgZGVmc3ViciAoJlN4d2lkZ2V0X3dlYmtpdF9iYWNrX2ZvcndhcmRfbGlz dCk7Ci0gIGRlZnN1YnIgKCZTeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3Mp OwogI2VuZGlmCisKKyAgZGVmc3ViciAoJlN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9w cm9ncmVzcyk7CiAgIGRlZnN1YnIgKCZTa2lsbF94d2lkZ2V0KTsKIAogICBERUZTWU0gKFFDeHdp ZGdldCwgIjp4d2lkZ2V0Iik7Cg== --000000000000ec3e0a05f1e1f516-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 04:59:24 2023 Received: (at 60703) by debbugs.gnu.org; 10 Jan 2023 09:59:24 +0000 Received: from localhost ([127.0.0.1]:38839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFBPf-0003JN-Mh for submit@debbugs.gnu.org; Tue, 10 Jan 2023 04:59:24 -0500 Received: from sonic309-20.consmr.mail.ne1.yahoo.com ([66.163.184.146]:44256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFBPd-0003J9-OO for 60703@debbugs.gnu.org; Tue, 10 Jan 2023 04:59:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673344755; bh=PRLftjj6F/84YZmTnfHrGyEtBP/NEf6vEovSy73rlxk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=a/69RhujdT7F+JGriXlfgZVmSkvwfS8DaP7srwkjVTxZe+Qu0XmuRjpF7NZLQWpj77s8wpDpSMCRrgytfc4RTGygr/d1HzuZL6vripnFWC+yvYPDe+6p1IHbi10888OBNVaHDwQaxOwYRkZnKJ/AKQka8fqbhFsu7wpDqw6cCpy0ruqoR4tjtOEvoPu/CQFV38C9irlVxxXOvWj1I+1f9uJ3P8Rbr9jl1HG4jd7/wn9ejZzzSse8ui8wM/EoF5MMWTUPbhLGuTYSSIw7nY7YaLPBhaSt08dd9mcDFSWJihK5gvvqt30Gkos2f9Vdmt93+H+wI3/p+J1lKLRuEx9e2g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673344755; bh=UfNt/VqT4DX/SkNi0p/Ix5KtPsdf9kvPT4Svfa22DqO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=sc+T58JyDU0xHsVJRfVDmfim/b0LRpvDuUcIyjtNHP8YdqJ3cUJW2008XZ3EJWnkSCzASLQnXI7Rrel6GCTRyn7u0zN/g4LCRaGWlSavyPWJ805wIOlhrta8qljM8BLdr8CB8fhOwW7+DiXUbDrzeO7V/RMkOwMO+7X6indvKDyEFGf5MnYID13jHnkmwdkmr/V8Ksj3pib8NUdv+iGdbK4DMCdqzbdeG56M3MC6I/Ye0Y6jpJ6OnT6+Ah8VVWRz5BiDivBSCeW7FepoLUluR4X3Z4QHJkLgdR1IlOn+Rqw3rycKjq3rpIru62rgDJOkNuoIb31geASjxrsVWilWFA== X-YMail-OSG: M.ZeYjUVM1nzNMkoVWcQaHp8UqoTydRI1WcLi8vETWATj7PkG8sbZsAI5YrjCi1 087OAhx0tb31u3ky3RXNJtPiWahknCslZKqpj0SEhyMTLTduP11RLxkKZLsNdfOq5i.tslmTTn7F n3ya8vKvQfzdZoxmbPVC1eDcuOIlTudznqhOkyWvyHb65F0wsVsghfWvQZLmkknZXmDzpiCbsgs8 e8zw.rJDA7DJ.1Ncs4qCDX03_.72tM9bNFg6Odf89DUa9N9fL0TwpD0.QRwEflrgORQeAL4zHNvH qqwV1tYbyess1MFGmhnX3FGic25CcGtLuxkNs81AFMTssPJSCp1ylinMgK4soW6hJdv3a8qx.07J h2Rg3uGLbc9clNeTxFusBeLLOAxEQM9h6pFAiJ1KYydrKv7r2vKUuySZrlJPEcvhyHoXza59vM_. 2uzrxagx2tleJ22xg5dVSBh7aMgtRH.wqLdvn2Uo2oZuFG1AZ2IIsxc0AIjIBFlB4uAXBPL9t7Mp 7bUM9F8UV_iVdaxxpZ5IqzS4OM05b.PHUJ8OXak5Y3QEnjmh9RV9xW1yaAdFXDV8.Oxgvp0snD9i n20hB5JrFyh.p9aNhhNTivTMchcEQvQwu8Zn7xGR8JpCOpm4eUEiyRSAepA6MOj.ybS2UOW_AnNx poPtFLhcBQHp4GoVqOEQxk0GJ0MFMatR7GQBGLtC2SDey_vw9JWYlDa84Lum_.7ovUtvP5774Wrz A1d3abF3Qn91Eh3c.M3A_speNq3YdKkx7l8h1Rm_nJL.KXH.b25Okl5h6FYCIQupcEij3RvB7Azp f6vnhb3Ylvn2RzGzR3ZIUBPftAoQckNQ1FoYYOUYOmb9jpmg94EtvMD2v9WZBtuaNM91brwe015l xPmfiV6qpPeO0OYuf_cHkucGcPybW.asDZOY_Rw1_TFAn.P8H_4Yg1_LHZ9cirxZkZdn811y_Erx eYsYiIwVAMu31F7GJ0pr2onV1FRzjxQWuXUiZVD_rgvIsPRCVLauF74fWZRvMDkuCMmj0NU9o6PV DLa7nU4GSIqMbDibHAVOTocXf5poZT1M09CsPu.v1K7Wsfoc_cN.AY7A15IMUUZu2FBYCMRkngDJ bHdBlgNTNcImYZzXUOiNdbqsHnNwl6PYNW2fEv6EgSFCm45Fye039O17usoPSx_c.op_CN0pDqbG iGomNIjXUdK0j_.QlL2XwAFCY.xfLmSrSZebEOZqtgTx6v_6crF56n7R_exqxE_HRpkPd_VQFU7e APLHxs4E_MgNYiLCp5TFRlcch5tRPBalagxNW1ADopw8NXUAXvG490Oea.0XzIdzGG7Mn2PBT8MD ZT4ACOagcUpAhBGaL_0_uAXR29lw4c5GZPldv4ENHB6SOnVSOIRE.nO8JeCCI1_CuqJoQSQISKY6 4_7GMv72JLX0mvcGio.IVrsDiCKWFG0FcwDVRPfF59IR8oA.P9BFqMh2nSfvTttaluIlESRRR1hm VeQb05UEvH3cjduDcXuLG69piDFVlQ15CNHEA7t2.EJMFdMj.BbVSUbSniTKxgOnOiC0XHbH_Et2 K1bUT3KxFmZ0ui080weQvLmqNtYKNS1LElUAHrpOWFUeZ8z_vdaTchDt8ATr1kyipbs1Vf8BWs5. SQbDIQtHuLMxYkWF9VSOp2oRiXqeA2Wvkxv65UKWvpUEhZWbsST9hcsyK2uCggB1.pyXJYzTIZZ3 jXOQxYY7IidFaSF3C8UTN.LVu.PF4_UhGOmROdtgvO0gyiR1QEOwmchSHz2iTiOko4D.1Enb70ls dS1lUJ11ugvJXDoRKfkHf1JGf3X5I4zRugZvL6vpa9ncQqkPotQyZdkshrTGCk68pbUflB17QlAu opfqr2_7T3_TLh292bFCDtZLX_tlX5pwV.X6auauQJuOUYYYvXfq0ktXE1Zvmh9n62vQlR7V4HNU b0ATR2bO7XqcyYDhW94gZeieJeWqYj6APg0uqnpJD4r_qKn68IJFfrbwntXbvbIxrzp_.UGQV.bD pQXb.Nlp8ojQqYx83cxQYGXT7.KCCBnjOWKSn2jkBUexvDsu2zOz7Vrx3QNLhnt3qJlcoNLN.PoO g1Dg6iYeucVEWACug00t7AuuuF6iHlmjWbJEKNDkIEe7h4.77Ucp3seO23PndmI4pn34vyy5OAsx Pf8amMFfDSKBOQQrg.pzgRxXl3WamcKQlqBWAkBfXoQD0awmQpbQqT0AXAOruircMHZ.cRbURG3b Mztmst8laQwt5QlELbTVDFmTocyPQJMX5V.gpmtyrH4a42Tb6sUN6qqYg2EVjjebobQ-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Tue, 10 Jan 2023 09:59:15 +0000 Received: by hermes--production-sg3-b666c6484-8hzhs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d7f89d54bca6c9864e8d5dbf1c477e56; Tue, 10 Jan 2023 09:59:10 +0000 (UTC) From: Po Lu To: Andrew De Angelis Subject: Re: bug#60703: Patches to xwidget code In-Reply-To: (Andrew De Angelis's message of "Tue, 10 Jan 2023 00:14:28 -0500") References: Date: Tue, 10 Jan 2023 17:59:04 +0800 Message-ID: <87cz7mhfrr.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 12153 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: 60703@debbugs.gnu.org, emacs-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrew De Angelis writes: > Hello everyone and thanks for all your work! > > I have some fixes to the xwidget code that I'd like to contribute. > > These should achieve three things 1) fix `xwidget-webkit-current-url' > in xwidget.el so that it actually displays the current URL 2) fix the > Objective-C code in nsxwidget.m to eliminate memory leaks 3) implement > the function `xwidget-webkit-estimated-load-progress' in Objective-C, > making this functionality available for macOS as well > > Regarding 2), I have tested my changes with the Instruments app within > the XCode dev tools. I was able to test them on two different > machines: a MacBook Air M2 running macOS Ventura 13, and an Intel > processor running macOS Big Sur 11.6.7. When testing with > Instruments, it appears that Emacs isn't leaking memory anymore. I am > still seeing some leaks, but according to Instruments, the responsible > libraries are system libraries, and not Emacs itself. If possible, I > would appreciate it if other people can test/profile these changes as > well, and share their feedback. > > Assuming the changes are correct and accepted, would it be possible to > include them in the upcoming Emacs 29.1 release? Technically, none of > these are new features; it's just fixes to existing features. > > I intend to keep working on xwidget support for macOS (fixing > remaining issues and implementing missing functionalities), but I'm > not sure when I'll be able to get to it; for now I'd like to start by > contributing these first major fixes. > > Thanks in advance for your feedback; let me know if you need anything > else from me. Andrew, thanks for working on Emacs. > > diff --git a/lisp/xwidget.el b/lisp/xwidget.el > index abbda29081..8095fa9db5 100644 > --- a/lisp/xwidget.el > +++ b/lisp/xwidget.el > @@ -924,8 +924,9 @@ xwidget-webkit-reload > (defun xwidget-webkit-current-url () > "Display the current xwidget webkit URL and place it on the `kill-ring'." > (interactive nil xwidget-webkit-mode) > - (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) > - (message "URL: %s" (kill-new (or url ""))))) > + (let ((url (or (xwidget-webkit-uri (xwidget-webkit-current-session)) ""))) > + (kill-new url) > + (message "URL: %s" url))) > > (defun xwidget-webkit-browse-history () > "Display a buffer containing the history of page loads." This change is fine for Emacs 29.1. Eli, WDYT? > @implementation XwWebView : WKWebView > > +- (void)dealloc > +{ > + [super dealloc]; > +} Thanks. Please put a space between the part of the Objective-C method that looks like a cast (I don't know what it's called, sorry) and the name of the method. But, is this really necessary? Without this being defined, the runtime will just call the super method, correct? > - (id)initWithFrame:(CGRect)frame > configuration:(WKWebViewConfiguration *)configuration > xwidget:(struct xwidget *)xw > { > /* Script controller to add script message handler and user script. */ > - WKUserContentController *scriptor = [[WKUserContentController alloc] init]; > + WKUserContentController *scriptor = [[[WKUserContentController alloc] init] > + autorelease]; > configuration.userContentController = scriptor; > > /* Enable inspect element context menu item for debugging. */ > @@ -81,7 +87,8 @@ - (id)initWithFrame:(CGRect)frame > if (self) > { > self.xw = xw; > - self.urlScriptBlocked = [[NSMutableDictionary alloc] init]; > + self.urlScriptBlocked = [[[NSMutableDictionary alloc] init] > + autorelease]; > self.navigationDelegate = self; > self.UIDelegate = self; > self.customUserAgent = > @@ -89,11 +96,13 @@ - (id)initWithFrame:(CGRect)frame > @" AppleWebKit/603.3.8 (KHTML, like Gecko)" > @" Version/11.0.1 Safari/603.3.8"; > [scriptor addScriptMessageHandler:self name:@"keyDown"]; > - [scriptor addUserScript:[[WKUserScript alloc] > - initWithSource:xwScript > - injectionTime: > - WKUserScriptInjectionTimeAtDocumentStart > - forMainFrameOnly:NO]]; > + WKUserScript *userScript = [[[WKUserScript alloc] > + initWithSource:xwScript > + injectionTime: > + WKUserScriptInjectionTimeAtDocumentStart > + forMainFrameOnly:NO] > + autorelease]; > + [scriptor addUserScript:userScript]; > } > return self; > } > @@ -102,7 +111,27 @@ - (void)webView:(WKWebView *)webView > didFinishNavigation:(WKNavigation *)navigation > { > if (EQ (Fbuffer_live_p (self.xw->buffer), Qt)) > - store_xwidget_event_string (self.xw, "load-changed", ""); > + store_xwidget_event_string (self.xw, "load-changed", "load-finished"); > +} > + > +- (void)webView:(WKWebView *)webView didStartProvisionalNavigation:(WKNavigation *)navigation > +{ > + if (EQ (Fbuffer_live_p (self.xw->buffer), Qt)) > + store_xwidget_event_string (self.xw, "load-changed", "load-started"); > +} > + > +- (void)webView:(WKWebView *)webView > +didReceiveServerRedirectForProvisionalNavigation:(WKNavigation *)navigation > +{ > + if (EQ (Fbuffer_live_p (self.xw->buffer), Qt)) > + store_xwidget_event_string (self.xw, "load-changed", "load-redirected"); > +} > + > +// Start loading WKWebView > +- (void)webView:(WKWebView *)webView didCommitNavigation:(WKNavigation *)navigation > +{ > + if (EQ (Fbuffer_live_p (self.xw->buffer), Qt)) // what exactly is this test for > + store_xwidget_event_string (self.xw, "load-changed", "load-committed"); > } These are also fine for Emacs 29. However, please replace the C++-style comments with C style ones, add spaces after the cast-like parts in the method definition, and fill everything to column 80. I believe the test is that the xwidget's buffer has not been killed, and could easily be written: !NILP (Fbuffer_live_p (self.xw->buffer)) as well. > - (void)webView:(WKWebView *)webView > @@ -343,6 +372,20 @@ - (void)userContentController:(WKUserContentController *)userContentController > } > } > > +double > +nsxwidget_webkit_estimated_load_progress(struct xwidget *xw) > +{ > + XwWebView *xwWebView = (XwWebView *) xw->xwWidget; > + return xwWebView.estimatedProgress; > +} Please place a space between "nsxwidget_webkit_estimated_load_progress" and the parameter list. > +void > +nsxwidget_webkit_stop_loading (struct xwidget *xw) > +{ > + XwWebView *xwWebView = (XwWebView *) xw->xwWidget; > + [xwWebView stopLoading]; > +} > + > void > nsxwidget_webkit_zoom (struct xwidget *xw, double zoom_change) > { > @@ -452,7 +495,8 @@ - (BOOL)isFlipped { return YES; } > NSRect rect = NSMakeRect (0, 0, xw->width, xw->height); > xw->xwWidget = [[XwWebView alloc] > initWithFrame:rect > - configuration:[[WKWebViewConfiguration alloc] init] > + configuration:[[[WKWebViewConfiguration alloc] init] > + autorelease] > xwidget:xw]; > xw->xwWindow = [[XwWindow alloc] > initWithFrame:rect]; > @@ -470,16 +514,18 @@ - (BOOL)isFlipped { return YES; } > ((XwWebView *) xw->xwWidget).configuration.userContentController; > [scriptor removeAllUserScripts]; > [scriptor removeScriptMessageHandlerForName:@"keyDown"]; > - [scriptor release]; > + > if (xw->xv) > xw->xv->model = Qnil; /* Make sure related view stale. */ > > /* This stops playing audio when a xwidget-webkit buffer is > - killed. I could not find other solution. */ > + killed. I could not find other solution. > + TODO: improve this */ > nsxwidget_webkit_goto_uri (xw, "about:blank"); > > [((XwWebView *) xw->xwWidget).urlScriptBlocked release]; > [xw->xwWidget removeFromSuperviewWithoutNeedingDisplay]; > + > [xw->xwWidget release]; > [xw->xwWindow removeFromSuperviewWithoutNeedingDisplay]; > [xw->xwWindow release]; These changes are also fine for Emacs 29, but the TODO seems excessive. Eli, any comments here? > diff --git a/src/xwidget.c b/src/xwidget.c > index efe2705562..b9550da460 100644 > --- a/src/xwidget.c > +++ b/src/xwidget.c > @@ -54,6 +54,7 @@ Copyright (C) 2011-2023 Free Software Foundation, Inc. > > #include > > + Please undo this extraneous whitespace change. > > +DEFUN ("xwidget-webkit-estimated-load-progress", > + Fxwidget_webkit_estimated_load_progress, Sxwidget_webkit_estimated_load_progress, > + 1, 1, 0, doc: /* Get the estimated load progress of XWIDGET, a WebKit widget. > +Return a value ranging from 0.0 to 1.0, based on how close XWIDGET > +is to completely loading its page. */) > + (Lisp_Object xwidget) > +{ > + struct xwidget *xw; > +#ifdef USE_GTK > + WebKitWebView *webview; > +#endif > + double value; > + > + CHECK_LIVE_XWIDGET (xwidget); > + xw = XXWIDGET (xwidget); > + CHECK_WEBKIT_WIDGET (xw); > + > + block_input (); > +#ifdef USE_GTK > + webview = WEBKIT_WEB_VIEW (xw->widget_osr); > + value = webkit_web_view_get_estimated_load_progress (webview); > +#elif defined NS_IMPL_COCOA > + value = nsxwidget_webkit_estimated_load_progress (xw); > +#endif > + > + unblock_input (); > + > + return make_float (value); > +} > + > DEFUN ("xwidget-webkit-goto-uri", > Fxwidget_webkit_goto_uri, Sxwidget_webkit_goto_uri, > 2, 2, 0, > @@ -3810,28 +3841,6 @@ DEFUN ("xwidget-webkit-back-forward-list", Fxwidget_webkit_back_forward_list, > return list3 (back, here, forward); > } > > -DEFUN ("xwidget-webkit-estimated-load-progress", > - Fxwidget_webkit_estimated_load_progress, Sxwidget_webkit_estimated_load_progress, > - 1, 1, 0, doc: /* Get the estimated load progress of XWIDGET, a WebKit widget. > -Return a value ranging from 0.0 to 1.0, based on how close XWIDGET > -is to completely loading its page. */) > - (Lisp_Object xwidget) > -{ > - struct xwidget *xw; > - WebKitWebView *webview; > - double value; > - > - CHECK_LIVE_XWIDGET (xwidget); > - xw = XXWIDGET (xwidget); > - CHECK_WEBKIT_WIDGET (xw); > - > - block_input (); > - webview = WEBKIT_WEB_VIEW (xw->widget_osr); > - value = webkit_web_view_get_estimated_load_progress (webview); > - unblock_input (); > - > - return make_float (value); > -} > #endif > > DEFUN ("xwidget-webkit-set-cookie-storage-file", > @@ -3874,19 +3883,23 @@ DEFUN ("xwidget-webkit-stop-loading", Fxwidget_webkit_stop_loading, > XWIDGET as part of loading a page. */) > (Lisp_Object xwidget) > { > -#ifdef USE_GTK > struct xwidget *xw; > +#ifdef USE_GTK > WebKitWebView *webview; > +#endif > > CHECK_LIVE_XWIDGET (xwidget); > xw = XXWIDGET (xwidget); > CHECK_WEBKIT_WIDGET (xw); > > block_input (); > +#ifdef USE_GTK > webview = WEBKIT_WEB_VIEW (xw->widget_osr); > webkit_web_view_stop_loading (webview); > - unblock_input (); > +#elif defined NS_IMPL_COCOA > + nsxwidget_webkit_stop_loading (xw); > #endif > + unblock_input (); > > return Qnil; > } > @@ -3936,8 +3949,9 @@ syms_of_xwidget (void) > #ifdef USE_GTK > defsubr (&Sxwidget_webkit_load_html); > defsubr (&Sxwidget_webkit_back_forward_list); > - defsubr (&Sxwidget_webkit_estimated_load_progress); > #endif > + > + defsubr (&Sxwidget_webkit_estimated_load_progress); > defsubr (&Skill_xwidget); > > DEFSYM (QCxwidget, ":xwidget"); None of this seems to affect anything other than the NS build, so it's fine by me. All in all, all your changes are fine for Emacs 29 by me. What they need is a proper commit message. See the node "Style of Change Logs" in the GNU Coding Standards for examples of how to do this: https://www.gnu.org/prep/standards/standards.html#Style-of-Change-Logs Thanks again for working on Emacs. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 08:40:23 2023 Received: (at 60703) by debbugs.gnu.org; 10 Jan 2023 13:40:23 +0000 Received: from localhost ([127.0.0.1]:39146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFErX-0005n8-By for submit@debbugs.gnu.org; Tue, 10 Jan 2023 08:40:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFErW-0005mv-33 for 60703@debbugs.gnu.org; Tue, 10 Jan 2023 08:40:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFErQ-0006DV-Jl; Tue, 10 Jan 2023 08:40:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c8h86DZvUGcmXmxL4ERCIrpKk4JA1LCD3i7miYxQJXk=; b=rKfU1Q6Iga4t FH8bBLaZxwpM6TpDBFL+sKgSNNKCTGB3a3t+rb0iO2YVdrhoiXm5GEewqd8B3MmuAzIYKeZlThW7O 3FbwnajsMHMTrhAL0HwhtpRRjcNGAffDVs3QfJck49DWr/p5mOHxyTGaDpTWJ6P9KtVfLH6rCstYZ GxnDqBMde8SDNAv5urpGNdp4vqayu9UjdMrzCVcWdlhAHtBgCGHyeTgx2668ESN83BS+zORXKkN1b iXn8NnJCNX8RMMPJX8EynBmx3DxEEG9hMU/Xvh755x2/DYS45Figh07IrRYcrlwtm/zL+E6mzS8pK OAG0X/B/Cz+S2JiGnwYkuw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFErQ-0006jO-3L; Tue, 10 Jan 2023 08:40:16 -0500 Date: Tue, 10 Jan 2023 15:40:44 +0200 Message-Id: <837cxuo6cj.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87cz7mhfrr.fsf@yahoo.com> (message from Po Lu on Tue, 10 Jan 2023 17:59:04 +0800) Subject: Re: bug#60703: Patches to xwidget code References: <87cz7mhfrr.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60703 Cc: bobodeangelis@gmail.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: emacs-devel@gnu.org, 60703@debbugs.gnu.org > Date: Tue, 10 Jan 2023 17:59:04 +0800 > > > --- a/lisp/xwidget.el > > +++ b/lisp/xwidget.el > > @@ -924,8 +924,9 @@ xwidget-webkit-reload > > (defun xwidget-webkit-current-url () > > "Display the current xwidget webkit URL and place it on the `kill-ring'." > > (interactive nil xwidget-webkit-mode) > > - (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) > > - (message "URL: %s" (kill-new (or url ""))))) > > + (let ((url (or (xwidget-webkit-uri (xwidget-webkit-current-session)) ""))) > > + (kill-new url) > > + (message "URL: %s" url))) > > > > (defun xwidget-webkit-browse-history () > > "Display a buffer containing the history of page loads." > > This change is fine for Emacs 29.1. Eli, WDYT? Fine by me. > These changes are also fine for Emacs 29, but the TODO seems excessive. > Eli, any comments here? I don't have an opinion, so if it's OK in your opinion, I'm fine with adding this. Are we sure this will not affect any important aspects of the build, except where we already have problems? (I don't see any description of the problems and their solution in the commit log or the comments.) > All in all, all your changes are fine for Emacs 29 by me. What they > need is a proper commit message. See the node "Style of Change Logs" in > the GNU Coding Standards for examples of how to do this: > > https://www.gnu.org/prep/standards/standards.html#Style-of-Change-Logs I don't see copyright assignment for Andrew, so this should be settled before accepting the contribution of this magnitude. > Thanks again for working on Emacs. Seconded. P.S. Please don't cross-post to emacs-devel. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 18:33:45 2023 Received: (at 60703) by debbugs.gnu.org; 10 Jan 2023 23:33:45 +0000 Received: from localhost ([127.0.0.1]:41383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFO7k-00078i-LP for submit@debbugs.gnu.org; Tue, 10 Jan 2023 18:33:45 -0500 Received: from mail-vs1-f49.google.com ([209.85.217.49]:45681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFO7i-00078O-2u for 60703@debbugs.gnu.org; Tue, 10 Jan 2023 18:33:42 -0500 Received: by mail-vs1-f49.google.com with SMTP id v127so9615050vsb.12 for <60703@debbugs.gnu.org>; Tue, 10 Jan 2023 15:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NFqvjKsr1AQsaq+ZevwTXYiBLVSsemDPs06rnIRh7ug=; b=GXSRbAgqGFEayxaKemH1NBNYZgaS5E99oygqGzUHkm1h0P8HjkHQSaRXX93S4GFxV9 WyXpHms5/Hs7jiPUhMrh5VzFzEkqENS3+9qYN6I+OCxjCP4q0WWvT64WzRr80QZ2RHeV oOzgqDWFhDxcpvgAvjMrb6QszFLbYgHGbCxKIgDEg3/SRVrH1HK2NXnABi5oG4Qw9rOE 6XdX/XB4Cpwzn0vtA1EJB0leTtyYmJ487wX9nOLtcCnUpESNDh9dvjRac9Lp0RnXl2t0 +MN2Fva8AO3/vXetWcpdXfPdG/18AxgoLnUJIF4a2c80WY1ZErbk6VKUGHMk2W1m3/6T Asww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NFqvjKsr1AQsaq+ZevwTXYiBLVSsemDPs06rnIRh7ug=; b=B2MgAJTnhBZKdJQT3qb+vobdFitQZoxKGH06BmOSi+jCf4KUH5bmbiu/mC2nFU8pMu VSo4V9SFwlYCA/WoDnPs+C8aao/o+bHhBVKbrBzyeYiyyaFnwK371JYHJVwE7Vhhrcbb GRDalz+WSi+y9l78kQnI8eYYe5Udj0iB5to2qkedYX9EbQqOk55pMlbZBFJ+LbCFV3Ov mcGfytZTKlGyFzMrbTquDZbeYup63z2cAxDIviYufkE+S2ZNo1g6GpDiJHPLr6PVArJZ ZrF1Zy56HRSfdxhYbV3lKHU0WsVRPKAVdeK5thue6L7isBPIS5Otb0Ibbf5h4tmRp22e bl1A== X-Gm-Message-State: AFqh2kr8bjNP2fkjNIeorh7g4EudBPYciLQgeJzbRWN7rUZ2GEDO3Ntq NXsih2lOTRi3CNL8+Wt4H9qwZ6pUwZh+ydRwKNo= X-Google-Smtp-Source: AMrXdXtx2plZ/ahdXHux68qr20+u3fz32d7bGCUsebloFEPsbNFuatuqzxddQnHErm/z20ierdPW9cVU1EyLGKzLXTo= X-Received: by 2002:a05:6102:30b2:b0:3c8:f1ef:372f with SMTP id y18-20020a05610230b200b003c8f1ef372fmr8067634vsd.62.1673393616396; Tue, 10 Jan 2023 15:33:36 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> In-Reply-To: <837cxuo6cj.fsf@gnu.org> From: Andrew De Angelis Date: Tue, 10 Jan 2023 18:33:25 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000013253005f1f15053" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: Po Lu , 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000013253005f1f15053 Content-Type: text/plain; charset="UTF-8" Thank you both. @Po Lu , I will work on the changes you mentioned. Can you clarify the C++-style comments vs C style ones? When should we use "/* */" and when should we use "//"? I looked around the code and it doesn't seem very consistent, but I can help clean up the xwidget-related files. @Eli, > Are we sure this will not affect any important aspects > of the build, except where we already have problems? (I don't see any > description of the problems and their solution in the commit log or > the comments.) > This should only affect builds on Mac machines, and makes it so the xwidget feature doesn't leak memory anymore. Importantly, I do not have access to any Linux machine, so I can't be 100% sure they're not affected. But as far as I can tell, the changes are limited to Mac builds using the "-with-xwidgets" feature. I'll add a better explanation in the upcoming Change Log, but essentially, the problems were simply memory leaks. The leaked memory wasn't a lot, so it seldom caused noticeable issues (at least in my experience). I'm sending my answers to the copyright questionnaire to assign@gnu.org. This is my first contribution, so let me know if I'm missing anything. Best, Andrew On Tue, Jan 10, 2023 at 8:40 AM Eli Zaretskii wrote: > > From: Po Lu > > Cc: emacs-devel@gnu.org, 60703@debbugs.gnu.org > > Date: Tue, 10 Jan 2023 17:59:04 +0800 > > > > > --- a/lisp/xwidget.el > > > +++ b/lisp/xwidget.el > > > @@ -924,8 +924,9 @@ xwidget-webkit-reload > > > (defun xwidget-webkit-current-url () > > > "Display the current xwidget webkit URL and place it on the > `kill-ring'." > > > (interactive nil xwidget-webkit-mode) > > > - (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) > > > - (message "URL: %s" (kill-new (or url ""))))) > > > + (let ((url (or (xwidget-webkit-uri > (xwidget-webkit-current-session)) ""))) > > > + (kill-new url) > > > + (message "URL: %s" url))) > > > > > > (defun xwidget-webkit-browse-history () > > > "Display a buffer containing the history of page loads." > > > > This change is fine for Emacs 29.1. Eli, WDYT? > > Fine by me. > > > These changes are also fine for Emacs 29, but the TODO seems excessive. > > Eli, any comments here? > > I don't have an opinion, so if it's OK in your opinion, I'm fine with > adding this. Are we sure this will not affect any important aspects > of the build, except where we already have problems? (I don't see any > description of the problems and their solution in the commit log or > the comments.) > > > All in all, all your changes are fine for Emacs 29 by me. What they > > need is a proper commit message. See the node "Style of Change Logs" in > > the GNU Coding Standards for examples of how to do this: > > > > https://www.gnu.org/prep/standards/standards.html#Style-of-Change-Logs > > I don't see copyright assignment for Andrew, so this should be settled > before accepting the contribution of this magnitude. > > > Thanks again for working on Emacs. > > Seconded. > > P.S. Please don't cross-post to emacs-devel. > --00000000000013253005f1f15053 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you both.

@Po Lu, I will work on the changes you mentioned.
<= /div>
Can you clarify the C++-style comments vs C style ones? When shou= ld we use "/* */" and when should we use "//"?
I looked around the code and it doesn't seem very consistent, but I c= an help clean up the xwidget-related files.

=
@Eli,
This should only affect builds on= Mac machines, and makes it so the xwidget feature doesn't leak memory = anymore. Importantly, I do not have access to any Linux machine, so I can&#= 39;t be 100% sure they're not affected. But as far as I can tell, the c= hanges are limited to Mac builds using the "-with-xwidgets" featu= re.
I'll add a better explanation in the upcoming Change Log,= but essentially, the problems were simply memory leaks. The leaked memory = wasn't a lot, so it seldom caused noticeable issues (at least in my exp= erience).

I'm sending my answers to the copyri= ght questionnaire to assign@gnu.org. = This is my first contribution, so let me know if I'm missing anything.<= /div>

Best,
Andrew


On Tue, Jan 10, 2023 at 8:40 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-dev= el@gnu.org,=C2=A0 60703@debbugs.gnu.org
> Date: Tue, 10 Jan 2023 17:59:04 +0800
>
> > --- a/lisp/xwidget.el
> > +++ b/lisp/xwidget.el
> > @@ -924,8 +924,9 @@ xwidget-webkit-reload
> >=C2=A0 (defun xwidget-webkit-current-url ()
> >=C2=A0 =C2=A0 "Display the current xwidget webkit URL and pla= ce it on the `kill-ring'."
> >=C2=A0 =C2=A0 (interactive nil xwidget-webkit-mode)
> > -=C2=A0 (let ((url (xwidget-webkit-uri (xwidget-webkit-current-se= ssion))))
> > -=C2=A0 =C2=A0 (message "URL: %s" (kill-new (or url &qu= ot;")))))
> > +=C2=A0 (let ((url (or (xwidget-webkit-uri (xwidget-webkit-curren= t-session)) "")))
> > +=C2=A0 =C2=A0 (kill-new url)
> > +=C2=A0 =C2=A0 (message "URL: %s" url)))
> >=C2=A0
> >=C2=A0 (defun xwidget-webkit-browse-history ()
> >=C2=A0 =C2=A0 "Display a buffer containing the history of pag= e loads."
>
> This change is fine for Emacs 29.1.=C2=A0 Eli, WDYT?

Fine by me.

> These changes are also fine for Emacs 29, but the TODO seems excessive= .
> Eli, any comments here?

I don't have an opinion, so if it's OK in your opinion, I'm fin= e with
adding this.=C2=A0 Are we sure this will not affect any important aspects of the build, except where we already have problems?=C2=A0 (I don't see= any
description of the problems and their solution in the commit log or
the comments.)

> All in all, all your changes are fine for Emacs 29 by me.=C2=A0 What t= hey
> need is a proper commit message.=C2=A0 See the node "Style of Cha= nge Logs" in
> the GNU Coding Standards for examples of how to do this:
>
>=C2=A0 =C2=A0https://www.g= nu.org/prep/standards/standards.html#Style-of-Change-Logs

I don't see copyright assignment for Andrew, so this should be settled<= br> before accepting the contribution of this magnitude.

> Thanks again for working on Emacs.

Seconded.

P.S. Please don't cross-post to emacs-devel.
--00000000000013253005f1f15053-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 20:15:42 2023 Received: (at 60703) by debbugs.gnu.org; 11 Jan 2023 01:15:42 +0000 Received: from localhost ([127.0.0.1]:41465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFPiQ-0001Lr-6A for submit@debbugs.gnu.org; Tue, 10 Jan 2023 20:15:42 -0500 Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]:32915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFPiN-0001La-Fu for 60703@debbugs.gnu.org; Tue, 10 Jan 2023 20:15:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673399733; bh=APBne+1mmB6M9d8he4V3uDlZatHTOZZVsL4YPjCwmmY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=MSR7Lq8zD5U2KUWnr/D2JH04IqZW96+3e+dCYjcRaDSbrr/Grw02LP9BjMu/0Iw5w/4RXVa4cuPQ9o7qG7iyC+iTsANAu7g8ZCkzuQnJy2uhebro1876LmFa09qe8Vk2cGmXVT01sETkjOzQ+d+b0QPXHNWYOdftrdrXZlE2R++7MPkuysU+Enng4282EYSD/9MXzjRc3F6z+SI5F2vk0ynYGxqxNznZHx89VnBgY7yB8czNwgn/RgeyMKfEZrJ6pMmLbNbs+kl2LVCTg0QERqbOiNWCdbdlubhulPAb9cEaYK1juXISOUkFjUx9TI5/kYtsv64E0I1QLIZGa+uQQg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673399733; bh=ac2KKn1peuZlQvfdxrujvVcBINMVzHNhpG0rLcaPA+U=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=mRoMYNahD6LjCzC0T2K5Nsxx4lqQaiHem9pmVlBIrz0OLPNgcqX+26mxCoeaXX8+w2duaTWVGw5v+eEoW5BFt6SV0TYaA8zA8cj9MuL0AD6RyGYkFlUcnfCeKf/NqYPGs2YWRcOvA6PvVDrGvSDfplqaUxPRrBBA7Y2/GFuKby0Q3UPA3dN/NaBahq1cBI0+CMdG9A89gSEnzURSRsOpb+qThzIId1gNHGCpSS1IcUApeJRZbCtJshyuzUjCoy1bUTxt1bX0X0wZ8sX8GrPBnJpdNeSfYp6X/qXLXAfzyHkb9Biu/3XbG3Rv/wSRiyHkDte2bwE/ueAqWVwSkPdA3g== X-YMail-OSG: 4dX3IvQVM1lFyoAggD5pqQTYbb1UWYR_01elBr_LA9PHaELw6XyrT8aZVrw_iD0 Q2n8JiM6Z96yzTr_qH1tQwP7lo8_YLlgU6cR0XmAW2BlNXZ.1FpE4ORcwMyv8FAspkcFyl5CY.6S YEMfJ79OOJXVXs6B2Ns37e1vti7aWgnaHHjUI5fnek2H86ri8bpL5qQ17OJ9X3KljuwaBWVI4DY5 m5yUBm8ud2ZcllYIIKf075v1zVFQoLjRvYom8tZW0N4U7fu9gbthNZBLq8diLVwgxeYMD7OR012K x_Y6NV4miI9GgpBtBGBG2O5K_mgBqICE9t3DN_VIISBqeavigTHXV3Z1PdZyea7lyktIor5cEv.T SJq9E9zGpKEFhumLpWvkvyRj3saIRWouEc9qB5wfo8lURbwgt9md9R6emVEF0.kB..MowrP.6S2r tqwG0chJEt40rQMwaBpPh26cOc7kqTLN8Z8dizgiyQSjTXeQYMaalvZKs.8R7YVVAMcP46E0yHk6 GYVdGzfBMyylDk5wlWL3.6pBCqyLhiKn95Xy6FxAB41QKezKN06VD70Jw30gG22YWsuVwih1vem9 mgV2Wf6.VIKiKG0369JmDAtySTVQoRKW0hy4SCajRZ0KAd7DbhKlBB7YCEEpoEK1YamztWxTJ_Kh eJVt1z1trHWKeiBege.wdTytRC5FUIaLxtLgtI_tF2wXRfjRTUZyD0CFxnFLFdkO87Vmqj.q4Yls Kk0lC0YMhUxtzw99J6lJpzA9UsOM3DXP4HAmcrMtp1dR96qjeMpC.aE5z1fwqBE.QqK5lQg.wkzY yBxJVZC8Ry_PEet.PkvJRC1PvcFOe68nTidZa5eX2CZ0QO400vLbsESdhx3Qi_ILq7jtlyFLQBpX R3yF0Aq1eLuMmi7ae1WSqyYDtZwh35Lshy_ajOZ90qe28MzsNXqI_bcRCBYU7HrhhRCb8Er1q_Qe MJi8covC_XxNvozgtECx3NPdnwJyoxw3htfk.JnHoEexBz.iqIIVkBiYwrGOWTn6tNFZKcD.q1rU MmGMArMmu9E49jzpSLhJ9w_63MHEToogbwhXeb.hDuC47p8cVuuxcV5dwspsMfixDvYO.e7sKuwG hxPFdZnhZYLdtzGhfmbQkAodm2WfShUpBC3aLZPHGIXxNlwQPk9_bnkMpRUoyvv.aVRpScQc9gHG hL9InxMZAK6ppMWh8FG8jF1gEJYSwbKOOe82vgKq98dCtunjsydbxQAMKIMT5F_nak8W54QPo_fM MDi7qsTPeUHFlb737XevdAwQ9BcPP9QgNvywqte_xvH_q14sXwdEMwQD1aQrEpRzxMwOS9w55Xj3 WU3pg5ieToVncojpljETxd3uKjd0HvaNc3yeFzj6.1pn5E_ESFMQBjiA28ptcZvF.a6pFVOz06Vf 3px0tsiixEKRks2Wb0E9nrK7zSMQej4xc0dzQFqmwfq3IdrFDOyI9NjWWjxqqB3gMFwbgFQKT0yU vsUJI3s.RdPIMbadVqaxBbhyfWV_1ED17qIpqvlYiXx9ZfwJiAhmxMp9fKZDzPYUzmoBISg9Q.rD RayBh_offmETkIGoztEYgb4RP4hfUopfB70CoSNeQUjmf6SJyM0DWhy.79R2HgpoEua96G5K2ZXR vH0lq4jvFrLWZScDaYidigtJHWrtSbb8GI6A2ESfS5pw3AGCjgUIyc_mDI9YMzTfH5H2ljXDY2Rv DPR_Tioo3Ml30ur.xjc3xI7Fl2PbsjR5WGsIjRiCi56Gyi6uxlMHzGc_A8huscATTVyW8Jc.DtfH Zm_ybuGpQ7caM_fxb1ImdGHk1wQeZKQTu07PaxKhSbNcfA4zlyzQmhjJ8JuAhZr3g9tVd0KP8i8_ 5DajVtLN7Po3dNjO2qcsMvrMnJtpzKQf66Ky0SDUQWJnQF1MvmGh9Ssp4crDeF7O09l1fXqnG_MI 44IAyI3FmyuzSYsOD8z5c4833tlSCS1GJaIE3Kp_4li1dazHwA_d8MNtX6SuJPkxxCJT0LeOiIwB W40tkkEGl_SbVSEfdnKUyaF_z3fKREOUQVmRSowcCHJsYLTsdP_r7nmK1LFfjLXe3RcsfltHwftV EcnNwg1QSfnzUJ1Hjttr1VLrxjM0vl32x8aZD65LMTuV3N8gmeQjXIz3Uij.Mv78v79lnobyDsEE LUN.in.ojP.xwbPN8SCP3dPeNL_QcbLf9PlpZLTXZ..yA2Wv.AHVYtC0xOB5gtxSsKiAAFfAWyot hdF62M4N1TyHr0CPa950wPt7Dk_Ol6Uz5mHk6JdPMoM2rqaj2LAjEf0Djxfn3UkL28Z4- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Wed, 11 Jan 2023 01:15:33 +0000 Received: by hermes--production-sg3-5ff5bbd69d-9mm7d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5071fdd41652b0dc3ce6d80c34b50d5a; Wed, 11 Jan 2023 01:15:30 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#60703: Patches to xwidget code In-Reply-To: <837cxuo6cj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Jan 2023 15:40:44 +0200") References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> Date: Wed, 11 Jan 2023 09:15:25 +0800 Message-ID: <874jsxhnwy.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 622 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: bobodeangelis@gmail.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I don't have an opinion, so if it's OK in your opinion, I'm fine with > adding this. Are we sure this will not affect any important aspects > of the build, except where we already have problems? (I don't see any > description of the problems and their solution in the commit log or > the comments.) Yes, these are fixes to a piece of code that is normally off by default, and did not work prior to those changes. > I don't see copyright assignment for Andrew, so this should be settled > before accepting the contribution of this magnitude. Right, thanks for bringing that up. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 21 01:13:22 2023 Received: (at 60703) by debbugs.gnu.org; 21 Jan 2023 06:13:22 +0000 Received: from localhost ([127.0.0.1]:47773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ77x-0007eJ-QD for submit@debbugs.gnu.org; Sat, 21 Jan 2023 01:13:22 -0500 Received: from mail-vs1-f42.google.com ([209.85.217.42]:41552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ77v-0007e5-0q for 60703@debbugs.gnu.org; Sat, 21 Jan 2023 01:13:19 -0500 Received: by mail-vs1-f42.google.com with SMTP id i188so7860032vsi.8 for <60703@debbugs.gnu.org>; Fri, 20 Jan 2023 22:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jSj/m1G1wpdIWd/aMeQJQaDVIGpp+OqG92tXtrd2DpA=; b=a45ycWV/qdEcyvxQs7PrxmzojY3yJS+cZBzbxymkM+Sr+kTE+Sppc3jqhf315e8kJF iWEnYVBU+pBpHP18oy5JTkkrEHA5bMS6WgsNssBtOaIqUR/v7iy+F+UawByFL2IRFZ1T Y3drLpP0nyyZvDY1OVL6dd7DVLXpbcQXhGJ4IGpJkdoHrEqjyWgmH9CwGHDPlJzssPYn Xq5N2ft+GQCvUPzPgnyxtNEyCBH+H1grE2RzvSgkaqbH3/WiZ8PRrT3CnEN3LVWy/YZB frBe3aF9NUCN4PeeGzg2gP3eGFOin5zrww3hQfHDF3Y9ERS/Pfh35P+plBqkplVYpkU8 XHrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jSj/m1G1wpdIWd/aMeQJQaDVIGpp+OqG92tXtrd2DpA=; b=svBECzltbb+unKFKddshkI+h+pce9v1h0W1U3vlV6qABTh1bRH167TpUCIYqTW3Nbo YjxNQovgx7maXKMUi7kDny3Wpfo5GiXiOif2qNgY6WiG2TA9z3OlEiuI2XKEfTz1u8xQ 9BX/1EwR8B4sUlwucl+q/vFDolQA6HnKXPtxEhhz5lameaJ9kpV9FeivsBenhvHf4zOj b16FDhdM03965/ynwQLSl8nJ8rb3AJHx3pTP8dejkz3/UDrMdhtj8u4j7wUvP44zd5o2 gAS0K7LGCXiS7V3MgvgYRksfzvPNIRTw/BlmZ+7NeMu/NaajTGKRGaxH7L607vIGkELU YXUg== X-Gm-Message-State: AFqh2kr6ftUeUH0CXiDEK2/7Emof7om/GKVIn9l4yPy5uqB977kMY96j Pfp7tjRISnup0j3VAQaSGPM/4nIQFDdkY/dutR0= X-Google-Smtp-Source: AMrXdXs17+Zk10vgIHv1LYtR8Xi7TQn7tbQ5jAJA8ZStSCihjb0u2ES1jDzXudcZsUOWGQn8HrS8FhEYpmCeaTeLvk8= X-Received: by 2002:a67:b309:0:b0:3c8:f1ef:372f with SMTP id a9-20020a67b309000000b003c8f1ef372fmr2491959vsm.62.1674281593260; Fri, 20 Jan 2023 22:13:13 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> In-Reply-To: <874jsxhnwy.fsf@yahoo.com> From: Andrew De Angelis Date: Sat, 21 Jan 2023 01:13:01 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Po Lu Content-Type: multipart/mixed; boundary="0000000000009f08af05f2c00ff0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: Eli Zaretskii , 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009f08af05f2c00ff0 Content-Type: multipart/alternative; boundary="0000000000009f08ac05f2c00fee" --0000000000009f08ac05f2c00fee Content-Type: text/plain; charset="UTF-8" Thank you again for the feedback. Attached is the updated patch. @Po Lu , you were right about the dealloc method: I removed it since it was unnecessary. I think I fixed all the issues you pointed out, but let me know if there's any other changes needed. About the copyright assignment, I sent the attached email to assign@gnu.org ten days ago, but haven't gotten a reply yet. Just want to make sure I'm going about it the right way: do I need to do anything else to get this done? It's my first contribution so I may be missing something. On Tue, Jan 10, 2023 at 8:15 PM Po Lu wrote: > Eli Zaretskii writes: > > > I don't have an opinion, so if it's OK in your opinion, I'm fine with > > adding this. Are we sure this will not affect any important aspects > > of the build, except where we already have problems? (I don't see any > > description of the problems and their solution in the commit log or > > the comments.) > > Yes, these are fixes to a piece of code that is normally off by default, > and did not work prior to those changes. > > > I don't see copyright assignment for Andrew, so this should be settled > > before accepting the contribution of this magnitude. > > Right, thanks for bringing that up. > --0000000000009f08ac05f2c00fee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you again for the feedback. Attached is the updated = patch.
@Po Lu, you were right abou= t the dealloc method: I removed it since it was unnecessary.
I think I fixed all the issues you pointed out, but let me know if there&#= 39;s any other changes needed.

About the copyright= assignment, I sent the attached email to assign@gnu.org ten days ago, but haven&= #39;t gotten a reply yet. Just want to make sure I'm going about it the= right way: do I need to do anything else to get this done? It's my fir= st contribution so I may be missing something.


On Tue, Jan 10, 2023 at = 8:15 PM Po Lu <luangruo@yahoo.com<= /a>> wrote:
E= li Zaretskii <eliz@gnu= .org> writes:

> I don't have an opinion, so if it's OK in your opinion, I'= m fine with
> adding this.=C2=A0 Are we sure this will not affect any important aspe= cts
> of the build, except where we already have problems?=C2=A0 (I don'= t see any
> description of the problems and their solution in the commit log or > the comments.)

Yes, these are fixes to a piece of code that is normally off by default, and did not work prior to those changes.

> I don't see copyright assignment for Andrew, so this should be set= tled
> before accepting the contribution of this magnitude.

Right, thanks for bringing that up.
--0000000000009f08ac05f2c00fee-- --0000000000009f08af05f2c00ff0 Content-Type: message/rfc822; name="Andrew John De Angelis.eml" Content-Disposition: attachment; filename="Andrew John De Angelis.eml" Content-ID: X-Attachment-Id: f_ld5jz3y10 MIME-Version: 1.0 Date: Tue, 10 Jan 2023 18:33:13 -0500 Message-ID: Subject: Andrew John De Angelis From: Andrew De Angelis To: assign@gnu.org Content-Type: multipart/alternative; boundary="000000000000ba978a05f1f14ef6" --000000000000ba978a05f1f14ef6 Content-Type: text/plain; charset="UTF-8" ---------------------------------------------------------------------- REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] Emacs [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] No [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] No [For the copyright registration, what country are you a citizen of?] USA [What year were you born?] 1995 [Please write your email address here.] bobodeangelis@gmail.com [Please write your postal address here.] 1239 Pacific St, 1F, Brooklyn, NY 11216 [Which files have you changed so far, and which new files have you written so far?] lisp/xwidget.el src/nsxwidget.h src/nsxwidget.m src/xwidget.c --000000000000ba978a05f1f14ef6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------= -----------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?] Emacs

[Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.]
No

[Do you have an employer who might have a basis to claim to own
your changes?=C2=A0 Do you attend a school which might make such a claim?]<= br>
No

[For the copyright registration, what country are you a citizen of?]
USA

[What year were you born?]
1995

[Please write your email address here.]
bobodeangelis@gmail.com

[Please write your postal address here.]
1239 Pacific St, 1F,= Brooklyn, NY 11216





[Which files have you changed so far, and which new files have you written<= br> so far?]
lisp/xwidget.el
src/nsxwidget.h
src/nsxwidget.m
src/xwidget.c
--000000000000ba978a05f1f14ef6-- --0000000000009f08af05f2c00ff0 Content-Type: application/octet-stream; name="xwidget-patches-1.patch" Content-Disposition: attachment; filename="xwidget-patches-1.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ld5k0f5g1 ZGlmZiAtLWdpdCBhL2xpc3AveHdpZGdldC5lbCBiL2xpc3AveHdpZGdldC5lbAppbmRleCBhYmJk YTI5MDgxLi44MDk1ZmE5ZGI1IDEwMDY0NAotLS0gYS9saXNwL3h3aWRnZXQuZWwKKysrIGIvbGlz cC94d2lkZ2V0LmVsCkBAIC05MjQsOCArOTI0LDkgQEAgeHdpZGdldC13ZWJraXQtcmVsb2FkCiAo ZGVmdW4geHdpZGdldC13ZWJraXQtY3VycmVudC11cmwgKCkKICAgIkRpc3BsYXkgdGhlIGN1cnJl bnQgeHdpZGdldCB3ZWJraXQgVVJMIGFuZCBwbGFjZSBpdCBvbiB0aGUgYGtpbGwtcmluZycuIgog ICAoaW50ZXJhY3RpdmUgbmlsIHh3aWRnZXQtd2Via2l0LW1vZGUpCi0gIChsZXQgKCh1cmwgKHh3 aWRnZXQtd2Via2l0LXVyaSAoeHdpZGdldC13ZWJraXQtY3VycmVudC1zZXNzaW9uKSkpKQotICAg IChtZXNzYWdlICJVUkw6ICVzIiAoa2lsbC1uZXcgKG9yIHVybCAiIikpKSkpCisgIChsZXQgKCh1 cmwgKG9yICh4d2lkZ2V0LXdlYmtpdC11cmkgKHh3aWRnZXQtd2Via2l0LWN1cnJlbnQtc2Vzc2lv bikpICIiKSkpCisgICAgKGtpbGwtbmV3IHVybCkKKyAgICAobWVzc2FnZSAiVVJMOiAlcyIgdXJs KSkpCiAKIChkZWZ1biB4d2lkZ2V0LXdlYmtpdC1icm93c2UtaGlzdG9yeSAoKQogICAiRGlzcGxh eSBhIGJ1ZmZlciBjb250YWluaW5nIHRoZSBoaXN0b3J5IG9mIHBhZ2UgbG9hZHMuIgpkaWZmIC0t Z2l0IGEvc3JjL25zeHdpZGdldC5oIGIvc3JjL25zeHdpZGdldC5oCmluZGV4IDhkNTVmYWM1MzIu LjJiNTU5NmY5MDUgMTAwNjQ0Ci0tLSBhL3NyYy9uc3h3aWRnZXQuaAorKysgYi9zcmMvbnN4d2lk Z2V0LmgKQEAgLTM2LDYgKzM2LDggQEAgI2RlZmluZSBOU1hXSURHRVRfSF9JTkNMVURFRAogTGlz cF9PYmplY3QgbnN4d2lkZ2V0X3dlYmtpdF90aXRsZSAoc3RydWN0IHh3aWRnZXQgKnh3KTsKIHZv aWQgbnN4d2lkZ2V0X3dlYmtpdF9nb3RvX3VyaSAoc3RydWN0IHh3aWRnZXQgKnh3LCBjb25zdCBj aGFyICp1cmkpOwogdm9pZCBuc3h3aWRnZXRfd2Via2l0X2dvdG9faGlzdG9yeSAoc3RydWN0IHh3 aWRnZXQgKnh3LCBpbnQgcmVsX3Bvcyk7Citkb3VibGUgbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0 ZWRfbG9hZF9wcm9ncmVzcyhzdHJ1Y3QgeHdpZGdldCAqeHcpOwordm9pZCBuc3h3aWRnZXRfd2Vi a2l0X3N0b3BfbG9hZGluZyAoc3RydWN0IHh3aWRnZXQgKnh3KTsKIHZvaWQgbnN4d2lkZ2V0X3dl YmtpdF96b29tIChzdHJ1Y3QgeHdpZGdldCAqeHcsIGRvdWJsZSB6b29tX2NoYW5nZSk7CiB2b2lk IG5zeHdpZGdldF93ZWJraXRfZXhlY3V0ZV9zY3JpcHQgKHN0cnVjdCB4d2lkZ2V0ICp4dywgY29u c3QgY2hhciAqc2NyaXB0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBM aXNwX09iamVjdCBmdW4pOwpkaWZmIC0tZ2l0IGEvc3JjL25zeHdpZGdldC5tIGIvc3JjL25zeHdp ZGdldC5tCmluZGV4IGUxZmJkNzQ5YjYuLmE1MDVhZDBlMmMgMTAwNjQ0Ci0tLSBhL3NyYy9uc3h3 aWRnZXQubQorKysgYi9zcmMvbnN4d2lkZ2V0Lm0KQEAgLTU3LDEyICs1NywxMyBAQCBAaW50ZXJm YWNlIFh3V2ViVmlldyA6IFdLV2ViVmlldwogQGVuZAogQGltcGxlbWVudGF0aW9uIFh3V2ViVmll dyA6IFdLV2ViVmlldwogCi0tIChpZClpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUKKy0gKGlk KSBpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUKICAgICAgIGNvbmZpZ3VyYXRpb246KFdLV2Vi Vmlld0NvbmZpZ3VyYXRpb24gKiljb25maWd1cmF0aW9uCiAgICAgICAgICAgICB4d2lkZ2V0Oihz dHJ1Y3QgeHdpZGdldCAqKXh3CiB7CiAgIC8qIFNjcmlwdCBjb250cm9sbGVyIHRvIGFkZCBzY3Jp cHQgbWVzc2FnZSBoYW5kbGVyIGFuZCB1c2VyIHNjcmlwdC4gICovCi0gIFdLVXNlckNvbnRlbnRD b250cm9sbGVyICpzY3JpcHRvciA9IFtbV0tVc2VyQ29udGVudENvbnRyb2xsZXIgYWxsb2NdIGlu aXRdOworICBXS1VzZXJDb250ZW50Q29udHJvbGxlciAqc2NyaXB0b3IgPSBbW1tXS1VzZXJDb250 ZW50Q29udHJvbGxlciBhbGxvY10gaW5pdF0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBhdXRvcmVsZWFzZV07CiAgIGNvbmZpZ3VyYXRpb24udXNlckNvbnRlbnRDb250 cm9sbGVyID0gc2NyaXB0b3I7CiAKICAgLyogRW5hYmxlIGluc3BlY3QgZWxlbWVudCBjb250ZXh0 IG1lbnUgaXRlbSBmb3IgZGVidWdnaW5nLiAgKi8KQEAgLTgxLDcgKzgyLDggQEAgLSAoaWQpaW5p dFdpdGhGcmFtZTooQ0dSZWN0KWZyYW1lCiAgIGlmIChzZWxmKQogICAgIHsKICAgICAgIHNlbGYu eHcgPSB4dzsKLSAgICAgIHNlbGYudXJsU2NyaXB0QmxvY2tlZCA9IFtbTlNNdXRhYmxlRGljdGlv bmFyeSBhbGxvY10gaW5pdF07CisgICAgICBzZWxmLnVybFNjcmlwdEJsb2NrZWQgPSBbW1tOU011 dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBhdXRvcmVsZWFzZV07CiAgICAgICBzZWxmLm5hdmlnYXRpb25EZWxlZ2F0ZSA9IHNlbGY7 CiAgICAgICBzZWxmLlVJRGVsZWdhdGUgPSBzZWxmOwogICAgICAgc2VsZi5jdXN0b21Vc2VyQWdl bnQgPQpAQCAtODksMjMgKzkxLDQ1IEBAIC0gKGlkKWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFt ZQogICAgICAgICBAIiBBcHBsZVdlYktpdC82MDMuMy44IChLSFRNTCwgbGlrZSBHZWNrbykiCiAg ICAgICAgIEAiIFZlcnNpb24vMTEuMC4xIFNhZmFyaS82MDMuMy44IjsKICAgICAgIFtzY3JpcHRv ciBhZGRTY3JpcHRNZXNzYWdlSGFuZGxlcjpzZWxmIG5hbWU6QCJrZXlEb3duIl07Ci0gICAgICBb c2NyaXB0b3IgYWRkVXNlclNjcmlwdDpbW1dLVXNlclNjcmlwdCBhbGxvY10KLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaW5pdFdpdGhTb3VyY2U6eHdTY3JpcHQKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGluamVjdGlvblRpbWU6Ci0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgV0tVc2VyU2NyaXB0SW5qZWN0aW9uVGltZUF0RG9jdW1lbnRTdGFydAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3JNYWluRnJhbWVPbmx5Ok5PXV07Cisg ICAgICBXS1VzZXJTY3JpcHQgKnVzZXJTY3JpcHQgPSBbW1tXS1VzZXJTY3JpcHQgYWxsb2NdCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbml0V2l0aFNvdXJjZTp4d1Njcmlw dAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluamVjdGlvblRpbWU6Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdLVXNlclNjcmlwdEluamVjdGlv blRpbWVBdERvY3VtZW50U3RhcnQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGZvck1haW5GcmFtZU9ubHk6Tk9dIGF1dG9yZWxlYXNlXTsKKyAgICAgIFtzY3JpcHRvciBhZGRV c2VyU2NyaXB0OnVzZXJTY3JpcHRdOwogICAgIH0KICAgcmV0dXJuIHNlbGY7CiB9CiAKLS0gKHZv aWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldworLSAodm9pZCkgd2ViVmlldzooV0tXZWJW aWV3ICopd2ViVmlldwogZGlkRmluaXNoTmF2aWdhdGlvbjooV0tOYXZpZ2F0aW9uICopbmF2aWdh dGlvbgogewogICBpZiAoRVEgKEZidWZmZXJfbGl2ZV9wIChzZWxmLnh3LT5idWZmZXIpLCBRdCkp Ci0gICAgc3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYueHcsICJsb2FkLWNoYW5nZWQi LCAiIik7CisgICAgc3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYueHcsICJsb2FkLWNo YW5nZWQiLCAibG9hZC1maW5pc2hlZCIpOwogfQogCi0tICh2b2lkKXdlYlZpZXc6KFdLV2ViVmll dyAqKXdlYlZpZXcKKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgZGlkU3Rh cnRQcm92aXNpb25hbE5hdmlnYXRpb246KFdLTmF2aWdhdGlvbiAqKW5hdmlnYXRpb24KK3sKKyAg aWYgKEVRIChGYnVmZmVyX2xpdmVfcCAoc2VsZi54dy0+YnVmZmVyKSwgUXQpKQorICAgIHN0b3Jl X3h3aWRnZXRfZXZlbnRfc3RyaW5nIChzZWxmLnh3LCAibG9hZC1jaGFuZ2VkIiwgImxvYWQtc3Rh cnRlZCIpOworfQorCistICh2b2lkKSB3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CitkaWRS ZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25hbE5hdmlnYXRpb246KFdLTmF2aWdhdGlv biAqKW5hdmlnYXRpb24KK3sKKyAgaWYgKEVRIChGYnVmZmVyX2xpdmVfcCAoc2VsZi54dy0+YnVm ZmVyKSwgUXQpKQorICAgIHN0b3JlX3h3aWRnZXRfZXZlbnRfc3RyaW5nIChzZWxmLnh3LCAibG9h ZC1jaGFuZ2VkIiwgImxvYWQtcmVkaXJlY3RlZCIpOworfQorCisvKiBTdGFydCBsb2FkaW5nIFdL V2ViVmlldyAqLworLSAodm9pZCkgd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldworZGlkQ29t bWl0TmF2aWdhdGlvbjooV0tOYXZpZ2F0aW9uICopbmF2aWdhdGlvbgoreworICBpZiAoRVEgKEZi dWZmZXJfbGl2ZV9wIChzZWxmLnh3LT5idWZmZXIpLCBRdCkpCisgICAgc3RvcmVfeHdpZGdldF9l dmVudF9zdHJpbmcgKHNlbGYueHcsICJsb2FkLWNoYW5nZWQiLCAibG9hZC1jb21taXR0ZWQiKTsK K30KKworLSAodm9pZCkgd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldwogZGVjaWRlUG9saWN5 Rm9yTmF2aWdhdGlvbkFjdGlvbjooV0tOYXZpZ2F0aW9uQWN0aW9uICopbmF2aWdhdGlvbkFjdGlv bgogZGVjaXNpb25IYW5kbGVyOih2b2lkICheKShXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3kpKWRl Y2lzaW9uSGFuZGxlcgogewpAQCAtMTE0LDEzICsxMzgsMTMgQEAgLSAodm9pZCl3ZWJWaWV3OihX S1dlYlZpZXcgKil3ZWJWaWV3CiAgICAgZGVjaXNpb25IYW5kbGVyIChXS05hdmlnYXRpb25BY3Rp b25Qb2xpY3lBbGxvdyk7CiAgICAgYnJlYWs7CiAgIGRlZmF1bHQ6Ci0gICAgLy8gZGVjaXNpb25I YW5kbGVyIChXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3lDYW5jZWwpOworICAgIC8qIGRlY2lzaW9u SGFuZGxlciAoV0tOYXZpZ2F0aW9uQWN0aW9uUG9saWN5Q2FuY2VsKTsgKi8KICAgICBkZWNpc2lv bkhhbmRsZXIgKFdLTmF2aWdhdGlvbkFjdGlvblBvbGljeUFsbG93KTsKICAgICBicmVhazsKICAg fQogfQogCi0tICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKKy0gKHZvaWQpIHdl YlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25SZXNw b25zZTooV0tOYXZpZ2F0aW9uUmVzcG9uc2UgKiluYXZpZ2F0aW9uUmVzcG9uc2UKIGRlY2lzaW9u SGFuZGxlcjoodm9pZCAoXikoV0tOYXZpZ2F0aW9uUmVzcG9uc2VQb2xpY3kpKWRlY2lzaW9uSGFu ZGxlcgogewpAQCAtMTY2LDcgKzE5MCw3IEBAIC0gKHZvaWQpd2ViVmlldzooV0tXZWJWaWV3ICop d2ViVmlldwogCiAvKiBObyBhZGRpdGlvbmFsIG5ldyB3ZWJ2aWV3IG9yIGVtYWNzIHdpbmRvdyB3 aWxsIGJlIGNyZWF0ZWQKICAgIGZvciA8YSAuLi4gdGFyZ2V0PSJfYmxhbmsiPi4gICovCi0tIChX S1dlYlZpZXcgKil3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CistIChXS1dlYlZpZXcgKikg d2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldwogY3JlYXRlV2ViVmlld1dpdGhDb25maWd1cmF0 aW9uOihXS1dlYlZpZXdDb25maWd1cmF0aW9uICopY29uZmlndXJhdGlvbgogICAgZm9yTmF2aWdh dGlvbkFjdGlvbjooV0tOYXZpZ2F0aW9uQWN0aW9uICopbmF2aWdhdGlvbkFjdGlvbgogICAgICAg ICB3aW5kb3dGZWF0dXJlczooV0tXaW5kb3dGZWF0dXJlcyAqKXdpbmRvd0ZlYXR1cmVzCkBAIC0x NzcsNyArMjAxLDcgQEAgLSAoV0tXZWJWaWV3ICopd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmll dwogfQogCiAvKiBPcGVuIHBhbmVsIGZvciBmaWxlIHVwbG9hZC4gICovCi0tICh2b2lkKXdlYlZp ZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdl YlZpZXcKIHJ1bk9wZW5QYW5lbFdpdGhQYXJhbWV0ZXJzOihXS09wZW5QYW5lbFBhcmFtZXRlcnMg KilwYXJhbWV0ZXJzCiBpbml0aWF0ZWRCeUZyYW1lOihXS0ZyYW1lSW5mbyAqKWZyYW1lCiBjb21w bGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNBcnJheTxOU1VSTCAqPiAqVVJMcykpY29tcGxldGlv bkhhbmRsZXIKQEAgLTE5NywxMyArMjIxLDEzIEBAIC0gKHZvaWQpd2ViVmlldzooV0tXZWJWaWV3 ICopd2ViVmlldwogICAgLSBDb3JyZWN0IG1vdXNlIGhhbmQvYXJyb3cvSS1iZWFtIGlzIGRpc3Bs YXllZCAoVE9ETzogbm90IHBlcmZlY3QgeWV0KS4KICovCiAKLS0gKHZvaWQpbW91c2VEb3duOihO U0V2ZW50ICopZXZlbnQKKy0gKHZvaWQpIG1vdXNlRG93bjooTlNFdmVudCAqKWV2ZW50CiB7CiAg IFtzZWxmLnh3LT54di0+ZW1hY3N3aW5kb3cgbW91c2VEb3duOmV2ZW50XTsKICAgW3N1cGVyIG1v dXNlRG93bjpldmVudF07CiB9CiAKLS0gKHZvaWQpbW91c2VVcDooTlNFdmVudCAqKWV2ZW50Cist ICh2b2lkKSBtb3VzZVVwOihOU0V2ZW50ICopZXZlbnQKIHsKICAgW3NlbGYueHctPnh2LT5lbWFj c3dpbmRvdyBtb3VzZVVwOmV2ZW50XTsKICAgW3N1cGVyIG1vdXNlVXA6ZXZlbnRdOwpAQCAtMjE0 LDcgKzIzOCw3IEBAIC0gKHZvaWQpbW91c2VVcDooTlNFdmVudCAqKWV2ZW50CiAgICBlbWFjcyBh cyBmaXJzdCByZXNwb25kZXIgdG8gYXZvaWQgZm9jdXMgaGVsZCBpbiBhbiBpbnB1dCBlbGVtZW50 CiAgICB3aXRoIG1hdGNoaW5nIHRleHQuICAqLwogCi0tICh2b2lkKWtleURvd246KE5TRXZlbnQg KilldmVudAorLSAodm9pZCkga2V5RG93bjooTlNFdmVudCAqKWV2ZW50CiB7CiAgIExpc3BfT2Jq ZWN0IHZhciA9IEZpbnRlcm4gKGJ1aWxkX3N0cmluZyAoImlzZWFyY2gtbW9kZSIpLCBRbmlsKTsK ICAgTGlzcF9PYmplY3QgdmFsID0gYnVmZmVyX2xvY2FsX3ZhbHVlICh2YXIsIEZjdXJyZW50X2J1 ZmZlciAoKSk7CkBAIC0yNTAsNyArMjc0LDcgQEAgLSAodm9pZClrZXlEb3duOihOU0V2ZW50ICop ZXZlbnQKICAgICB9XTsKIH0KIAotLSAodm9pZClpbnRlcnByZXRLZXlFdmVudHM6KE5TQXJyYXk8 TlNFdmVudCAqPiAqKWV2ZW50QXJyYXkKKy0gKHZvaWQpIGludGVycHJldEtleUV2ZW50czooTlNB cnJheTxOU0V2ZW50ICo+ICopZXZlbnRBcnJheQogewogICAvKiBXZSBzaG91bGQgZG8gbm90aGlu ZyBhbmQgZG8gbm90IGZvcndhcmQgKGRlZmF1bHQgaW1wbGVtZW50YXRpb24KICAgICAgaWYgd2Ug bm90IG92ZXJyaWRlIGhlcmUpIHRvIGxldCBlbWFjcyBjb2xsZWN0IGtleSBldmVudHMgYW5kIGFz awpAQCAtMjU4LDcgKzI4Miw3IEBAIC0gKHZvaWQpaW50ZXJwcmV0S2V5RXZlbnRzOihOU0FycmF5 PE5TRXZlbnQgKj4gKilldmVudEFycmF5CiB9CiAKIHN0YXRpYyBOU1N0cmluZyAqeHdTY3JpcHQ7 Ci0rICh2b2lkKWluaXRpYWxpemUKKysgKHZvaWQpIGluaXRpYWxpemUKIHsKICAgLyogRmluZCBv dXQgaWYgYW4gaW5wdXQgZWxlbWVudCBoYXMgZm9jdXMuCiAgICAgIE1lc3NhZ2UgdG8gc2NyaXB0 IG1lc3NhZ2UgaGFuZGxlciB3aGVuICdDLWcnIGtleSBkb3duLiAgKi8KQEAgLTI4NCw3ICszMDgs NyBAQCArICh2b2lkKWluaXRpYWxpemUKIAogLyogQ29uZmlybWluZyB0byBXS1NjcmlwdE1lc3Nh Z2VIYW5kbGVyLCBsaXN0ZW5zIGNvbmNlcm5pbmcga2V5RG93biBpbgogICAgd2Via2l0LiBDdXJy ZW50bHkgJ0MtZycuICAqLwotLSAodm9pZCl1c2VyQ29udGVudENvbnRyb2xsZXI6KFdLVXNlckNv bnRlbnRDb250cm9sbGVyICopdXNlckNvbnRlbnRDb250cm9sbGVyCistICh2b2lkKSB1c2VyQ29u dGVudENvbnRyb2xsZXI6KFdLVXNlckNvbnRlbnRDb250cm9sbGVyICopdXNlckNvbnRlbnRDb250 cm9sbGVyCiAgICAgICBkaWRSZWNlaXZlU2NyaXB0TWVzc2FnZTooV0tTY3JpcHRNZXNzYWdlICop bWVzc2FnZQogewogICBpZiAoW21lc3NhZ2UuYm9keSBpc0VxdWFsVG9TdHJpbmc6QCJDLWciXSkK QEAgLTM0Myw2ICszNjcsMjAgQEAgLSAodm9pZCl1c2VyQ29udGVudENvbnRyb2xsZXI6KFdLVXNl ckNvbnRlbnRDb250cm9sbGVyICopdXNlckNvbnRlbnRDb250cm9sbGVyCiAgIH0KIH0KIAorZG91 YmxlCituc3h3aWRnZXRfd2Via2l0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzIChzdHJ1Y3QgeHdp ZGdldCAqeHcpCit7CisgIFh3V2ViVmlldyAqeHdXZWJWaWV3ID0gKFh3V2ViVmlldyAqKSB4dy0+ eHdXaWRnZXQ7CisgIHJldHVybiB4d1dlYlZpZXcuZXN0aW1hdGVkUHJvZ3Jlc3M7Cit9CisKK3Zv aWQKK25zeHdpZGdldF93ZWJraXRfc3RvcF9sb2FkaW5nIChzdHJ1Y3QgeHdpZGdldCAqeHcpCit7 CisgIFh3V2ViVmlldyAqeHdXZWJWaWV3ID0gKFh3V2ViVmlldyAqKSB4dy0+eHdXaWRnZXQ7Cisg IFt4d1dlYlZpZXcgc3RvcExvYWRpbmddOworfQorCiB2b2lkCiBuc3h3aWRnZXRfd2Via2l0X3pv b20gKHN0cnVjdCB4d2lkZ2V0ICp4dywgZG91YmxlIHpvb21fY2hhbmdlKQogewpAQCAtNDMwLDcg KzQ2OCw3IEBAIC0gKHZvaWQpdXNlckNvbnRlbnRDb250cm9sbGVyOihXS1VzZXJDb250ZW50Q29u dHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxlcgogICAgICAgICB9CiAgICAgICBlbHNlIGlm IChyZXN1bHQgJiYgRlVOQ1RJT05QIChmdW4pKQogICAgICAgICB7Ci0gICAgICAgICAgLy8gTlNM b2cgKEAicmVzdWx0PSVALCB0eXBlPSVAIiwgcmVzdWx0LCBbcmVzdWx0IGNsYXNzXSk7CisgICAg ICAgICAgLyogTlNMb2cgKEAicmVzdWx0PSVALCB0eXBlPSVAIiwgcmVzdWx0LCBbcmVzdWx0IGNs YXNzXSk7ICovCiAgICAgICAgICAgTGlzcF9PYmplY3QgbGlzcF92YWx1ZSA9IGpzX3RvX2xpc3Ag KHJlc3VsdCk7CiAgICAgICAgICAgc3RvcmVfeHdpZGdldF9qc19jYWxsYmFja19ldmVudCAoeHcs IGZ1biwgbGlzcF92YWx1ZSk7CiAgICAgICAgIH0KQEAgLTQ0MCwxOSArNDc4LDIwIEBAIC0gKHZv aWQpdXNlckNvbnRlbnRDb250cm9sbGVyOihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJD b250ZW50Q29udHJvbGxlcgogLyogV2luZG93IGNvbnRhaW5pbmcgYW4geHdpZGdldC4gICovCiAK IEBpbXBsZW1lbnRhdGlvbiBYd1dpbmRvdwotLSAoQk9PTClpc0ZsaXBwZWQgeyByZXR1cm4gWUVT OyB9CistIChCT09MKSBpc0ZsaXBwZWQgeyByZXR1cm4gWUVTOyB9CiBAZW5kCiAKIC8qIFh3aWRn ZXQgbW9kZWwsIG1hY09TIENvY29hIHBhcnQuICAqLwogCiB2b2lkCi1uc3h3aWRnZXRfaW5pdChz dHJ1Y3QgeHdpZGdldCAqeHcpCituc3h3aWRnZXRfaW5pdCAoc3RydWN0IHh3aWRnZXQgKnh3KQog ewogICBibG9ja19pbnB1dCAoKTsKICAgTlNSZWN0IHJlY3QgPSBOU01ha2VSZWN0ICgwLCAwLCB4 dy0+d2lkdGgsIHh3LT5oZWlnaHQpOwogICB4dy0+eHdXaWRnZXQgPSBbW1h3V2ViVmlldyBhbGxv Y10KICAgICAgICAgICAgICAgICAgICBpbml0V2l0aEZyYW1lOnJlY3QKLSAgICAgICAgICAgICAg ICAgICBjb25maWd1cmF0aW9uOltbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0K KyAgICAgICAgICAgICAgICAgICBjb25maWd1cmF0aW9uOltbW1dLV2ViVmlld0NvbmZpZ3VyYXRp b24gYWxsb2NdIGluaXRdCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGF1dG9y ZWxlYXNlXQogICAgICAgICAgICAgICAgICAgICAgICAgIHh3aWRnZXQ6eHddOwogICB4dy0+eHdX aW5kb3cgPSBbW1h3V2luZG93IGFsbG9jXQogICAgICAgICAgICAgICAgICAgIGluaXRXaXRoRnJh bWU6cmVjdF07CkBAIC00NzAsMTYgKzUwOSwxOCBAQCAtIChCT09MKWlzRmxpcHBlZCB7IHJldHVy biBZRVM7IH0KICAgICAgICAgKChYd1dlYlZpZXcgKikgeHctPnh3V2lkZ2V0KS5jb25maWd1cmF0 aW9uLnVzZXJDb250ZW50Q29udHJvbGxlcjsKICAgICAgIFtzY3JpcHRvciByZW1vdmVBbGxVc2Vy U2NyaXB0c107CiAgICAgICBbc2NyaXB0b3IgcmVtb3ZlU2NyaXB0TWVzc2FnZUhhbmRsZXJGb3JO YW1lOkAia2V5RG93biJdOwotICAgICAgW3NjcmlwdG9yIHJlbGVhc2VdOworCiAgICAgICBpZiAo eHctPnh2KQogICAgICAgICB4dy0+eHYtPm1vZGVsID0gUW5pbDsgLyogTWFrZSBzdXJlIHJlbGF0 ZWQgdmlldyBzdGFsZS4gICovCiAKICAgICAgIC8qIFRoaXMgc3RvcHMgcGxheWluZyBhdWRpbyB3 aGVuIGEgeHdpZGdldC13ZWJraXQgYnVmZmVyIGlzCi0gICAgICAgICBraWxsZWQuICBJIGNvdWxk IG5vdCBmaW5kIG90aGVyIHNvbHV0aW9uLiAgKi8KKyAgICAgICAgIGtpbGxlZC4gIEkgY291bGQg bm90IGZpbmQgb3RoZXIgc29sdXRpb24uCisgICAgICAgICBUT0RPOiBpbXByb3ZlIHRoaXMgKi8K ICAgICAgIG5zeHdpZGdldF93ZWJraXRfZ290b191cmkgKHh3LCAiYWJvdXQ6YmxhbmsiKTsKIAog ICAgICAgWygoWHdXZWJWaWV3ICopIHh3LT54d1dpZGdldCkudXJsU2NyaXB0QmxvY2tlZCByZWxl YXNlXTsKICAgICAgIFt4dy0+eHdXaWRnZXQgcmVtb3ZlRnJvbVN1cGVydmlld1dpdGhvdXROZWVk aW5nRGlzcGxheV07CisKICAgICAgIFt4dy0+eHdXaWRnZXQgcmVsZWFzZV07CiAgICAgICBbeHct Pnh3V2luZG93IHJlbW92ZUZyb21TdXBlcnZpZXdXaXRob3V0TmVlZGluZ0Rpc3BsYXldOwogICAg ICAgW3h3LT54d1dpbmRvdyByZWxlYXNlXTsKQEAgLTUwNyw3ICs1NDgsNyBAQCAtIChCT09MKWlz RmxpcHBlZCB7IHJldHVybiBZRVM7IH0KIC8qIFh3aWRnZXQgdmlldywgbWFjT1MgQ29jb2EgcGFy dC4gICovCiAKIEBpbXBsZW1lbnRhdGlvbiBYdldpbmRvdyA6IE5TVmlldwotLSAoQk9PTClpc0Zs aXBwZWQgeyByZXR1cm4gWUVTOyB9CistIChCT09MKSBpc0ZsaXBwZWQgeyByZXR1cm4gWUVTOyB9 CiBAZW5kCiAKIHZvaWQKZGlmZiAtLWdpdCBhL3NyYy94d2lkZ2V0LmMgYi9zcmMveHdpZGdldC5j CmluZGV4IGVmZTI3MDU1NjIuLmM4NzgwNjNlYjcgMTAwNjQ0Ci0tLSBhL3NyYy94d2lkZ2V0LmMK KysrIGIvc3JjL3h3aWRnZXQuYwpAQCAtNDkwLDEwICs0OTAsMTAgQEAgREVGVU4gKCJ4d2lkZ2V0 LXBlcmZvcm0tbGlzcHktZXZlbnQiLAogewogICBzdHJ1Y3QgeHdpZGdldCAqeHc7CiAgIHN0cnVj dCBmcmFtZSAqZiA9IE5VTEw7Ci0gIGludCBjaGFyYWN0ZXIgPSAtMSwga2V5Y29kZSA9IC0xOwot ICBpbnQgbW9kaWZpZXJzID0gMDsKIAogI2lmZGVmIFVTRV9HVEsKKyAgaW50IGNoYXJhY3RlciA9 IC0xLCBrZXljb2RlID0gLTE7CisgIGludCBtb2RpZmllcnMgPSAwOwogICBHZGtFdmVudCAqeGdf ZXZlbnQ7CiAgIEd0a0NvbnRhaW5lckNsYXNzICprbGFzczsKICAgR3RrV2lkZ2V0ICp3aWRnZXQ7 CkBAIC0zMDYzLDYgKzMwNjMsMzYgQEAgREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC10aXRsZSIsCiAj ZW5kaWYKIH0KIAorREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC1lc3RpbWF0ZWQtbG9hZC1wcm9ncmVz cyIsCisgICAgICAgRnh3aWRnZXRfd2Via2l0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzLCBTeHdp ZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MsCisgICAgICAgMSwgMSwgMCwgZG9j OiAvKiBHZXQgdGhlIGVzdGltYXRlZCBsb2FkIHByb2dyZXNzIG9mIFhXSURHRVQsIGEgV2ViS2l0 IHdpZGdldC4KK1JldHVybiBhIHZhbHVlIHJhbmdpbmcgZnJvbSAwLjAgdG8gMS4wLCBiYXNlZCBv biBob3cgY2xvc2UgWFdJREdFVAoraXMgdG8gY29tcGxldGVseSBsb2FkaW5nIGl0cyBwYWdlLiAg Ki8pCisgIChMaXNwX09iamVjdCB4d2lkZ2V0KQoreworICBzdHJ1Y3QgeHdpZGdldCAqeHc7Cisj aWZkZWYgVVNFX0dUSworICBXZWJLaXRXZWJWaWV3ICp3ZWJ2aWV3OworI2VuZGlmCisgIGRvdWJs ZSB2YWx1ZTsKKworICBDSEVDS19MSVZFX1hXSURHRVQgKHh3aWRnZXQpOworICB4dyA9IFhYV0lE R0VUICh4d2lkZ2V0KTsKKyAgQ0hFQ0tfV0VCS0lUX1dJREdFVCAoeHcpOworCisgIGJsb2NrX2lu cHV0ICgpOworI2lmZGVmIFVTRV9HVEsKKyAgd2VidmlldyA9IFdFQktJVF9XRUJfVklFVyAoeHct PndpZGdldF9vc3IpOworICB2YWx1ZSA9IHdlYmtpdF93ZWJfdmlld19nZXRfZXN0aW1hdGVkX2xv YWRfcHJvZ3Jlc3MgKHdlYnZpZXcpOworI2VsaWYgZGVmaW5lZCBOU19JTVBMX0NPQ09BCisgIHZh bHVlID0gbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyAoeHcpOworI2Vu ZGlmCisKKyAgdW5ibG9ja19pbnB1dCAoKTsKKworICByZXR1cm4gbWFrZV9mbG9hdCAodmFsdWUp OworfQorCiBERUZVTiAoInh3aWRnZXQtd2Via2l0LWdvdG8tdXJpIiwKICAgICAgICBGeHdpZGdl dF93ZWJraXRfZ290b191cmksIFN4d2lkZ2V0X3dlYmtpdF9nb3RvX3VyaSwKICAgICAgICAyLCAy LCAwLApAQCAtMzgxMCwyOCArMzg0MCw2IEBAIERFRlVOICgieHdpZGdldC13ZWJraXQtYmFjay1m b3J3YXJkLWxpc3QiLCBGeHdpZGdldF93ZWJraXRfYmFja19mb3J3YXJkX2xpc3QsCiAgIHJldHVy biBsaXN0MyAoYmFjaywgaGVyZSwgZm9yd2FyZCk7CiB9CiAKLURFRlVOICgieHdpZGdldC13ZWJr aXQtZXN0aW1hdGVkLWxvYWQtcHJvZ3Jlc3MiLAotICAgICAgIEZ4d2lkZ2V0X3dlYmtpdF9lc3Rp bWF0ZWRfbG9hZF9wcm9ncmVzcywgU3h3aWRnZXRfd2Via2l0X2VzdGltYXRlZF9sb2FkX3Byb2dy ZXNzLAotICAgICAgIDEsIDEsIDAsIGRvYzogLyogR2V0IHRoZSBlc3RpbWF0ZWQgbG9hZCBwcm9n cmVzcyBvZiBYV0lER0VULCBhIFdlYktpdCB3aWRnZXQuCi1SZXR1cm4gYSB2YWx1ZSByYW5naW5n IGZyb20gMC4wIHRvIDEuMCwgYmFzZWQgb24gaG93IGNsb3NlIFhXSURHRVQKLWlzIHRvIGNvbXBs ZXRlbHkgbG9hZGluZyBpdHMgcGFnZS4gICovKQotICAoTGlzcF9PYmplY3QgeHdpZGdldCkKLXsK LSAgc3RydWN0IHh3aWRnZXQgKnh3OwotICBXZWJLaXRXZWJWaWV3ICp3ZWJ2aWV3OwotICBkb3Vi bGUgdmFsdWU7Ci0KLSAgQ0hFQ0tfTElWRV9YV0lER0VUICh4d2lkZ2V0KTsKLSAgeHcgPSBYWFdJ REdFVCAoeHdpZGdldCk7Ci0gIENIRUNLX1dFQktJVF9XSURHRVQgKHh3KTsKLQotICBibG9ja19p bnB1dCAoKTsKLSAgd2VidmlldyA9IFdFQktJVF9XRUJfVklFVyAoeHctPndpZGdldF9vc3IpOwot ICB2YWx1ZSA9IHdlYmtpdF93ZWJfdmlld19nZXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MgKHdl YnZpZXcpOwotICB1bmJsb2NrX2lucHV0ICgpOwotCi0gIHJldHVybiBtYWtlX2Zsb2F0ICh2YWx1 ZSk7Ci19CiAjZW5kaWYKIAogREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC1zZXQtY29va2llLXN0b3Jh Z2UtZmlsZSIsCkBAIC0zODc0LDE5ICszODgyLDIzIEBAIERFRlVOICgieHdpZGdldC13ZWJraXQt c3RvcC1sb2FkaW5nIiwgRnh3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZywKIFhXSURHRVQgYXMg cGFydCBvZiBsb2FkaW5nIGEgcGFnZS4gICovKQogICAoTGlzcF9PYmplY3QgeHdpZGdldCkKIHsK LSNpZmRlZiBVU0VfR1RLCiAgIHN0cnVjdCB4d2lkZ2V0ICp4dzsKKyNpZmRlZiBVU0VfR1RLCiAg IFdlYktpdFdlYlZpZXcgKndlYnZpZXc7CisjZW5kaWYKIAogICBDSEVDS19MSVZFX1hXSURHRVQg KHh3aWRnZXQpOwogICB4dyA9IFhYV0lER0VUICh4d2lkZ2V0KTsKICAgQ0hFQ0tfV0VCS0lUX1dJ REdFVCAoeHcpOwogCiAgIGJsb2NrX2lucHV0ICgpOworI2lmZGVmIFVTRV9HVEsKICAgd2Vidmll dyA9IFdFQktJVF9XRUJfVklFVyAoeHctPndpZGdldF9vc3IpOwogICB3ZWJraXRfd2ViX3ZpZXdf c3RvcF9sb2FkaW5nICh3ZWJ2aWV3KTsKLSAgdW5ibG9ja19pbnB1dCAoKTsKKyNlbGlmIGRlZmlu ZWQgTlNfSU1QTF9DT0NPQQorICBuc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZyAoeHcpOwog I2VuZGlmCisgIHVuYmxvY2tfaW5wdXQgKCk7CiAKICAgcmV0dXJuIFFuaWw7CiB9CkBAIC0zOTM2 LDggKzM5NDgsOSBAQCBzeW1zX29mX3h3aWRnZXQgKHZvaWQpCiAjaWZkZWYgVVNFX0dUSwogICBk ZWZzdWJyICgmU3h3aWRnZXRfd2Via2l0X2xvYWRfaHRtbCk7CiAgIGRlZnN1YnIgKCZTeHdpZGdl dF93ZWJraXRfYmFja19mb3J3YXJkX2xpc3QpOwotICBkZWZzdWJyICgmU3h3aWRnZXRfd2Via2l0 X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzKTsKICNlbmRpZgorCisgIGRlZnN1YnIgKCZTeHdpZGdl dF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MpOwogICBkZWZzdWJyICgmU2tpbGxfeHdp ZGdldCk7CiAKICAgREVGU1lNIChRQ3h3aWRnZXQsICI6eHdpZGdldCIpOwo= --0000000000009f08af05f2c00ff0-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 21 02:16:44 2023 Received: (at 60703) by debbugs.gnu.org; 21 Jan 2023 07:16:45 +0000 Received: from localhost ([127.0.0.1]:47840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ87I-0000sO-LB for submit@debbugs.gnu.org; Sat, 21 Jan 2023 02:16:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ87H-0000sD-Ab for 60703@debbugs.gnu.org; Sat, 21 Jan 2023 02:16:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ87B-0004VJ-SN; Sat, 21 Jan 2023 02:16:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DBkQevM35BxvT/uVxW4GqST3JAc4RcchlyuqoXUOKOw=; b=Fr5Ty3j+uTKx fE3K5Djh1CSK9UkmjaI59Iu2D0efiaUJZX1QKSx5MOlOK1RGy4k+7QmCVSCXmI9kW2rA0g7CJyu+z Y3QdUWb6iRHKoRmRxQ31CHy0ZkUi4Br6m+hPwi3P9LpSnteFnRulnDXN4DnU0wCORvx8Bg/TdLMmd 1qrI0Mq5kGKKTrb6gw2TJNvu9UVQpiMgW0ECPOGJ/Jh210NdTWA5MFPjdkwmvWSN7tmPJs5NuOR8j pd/VKqiYiAaVDlisQh7+8dYvsgdk6cRGAjwQ0ZXb9YgeKn777CGiUpuc6szacbGY4iyCmQ2rL1/UA UkFlnD3j6tDXAOOzyz3DCQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ87B-00005T-5z; Sat, 21 Jan 2023 02:16:37 -0500 Date: Sat, 21 Jan 2023 09:16:39 +0200 Message-Id: <83bkmsmk6g.fsf@gnu.org> From: Eli Zaretskii To: Andrew De Angelis In-Reply-To: (message from Andrew De Angelis on Sat, 21 Jan 2023 01:13:01 -0500) Subject: Re: bug#60703: Patches to xwidget code References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew De Angelis > Date: Sat, 21 Jan 2023 01:13:01 -0500 > Cc: Eli Zaretskii , 60703@debbugs.gnu.org > > About the copyright assignment, I sent the attached email to assign@gnu.org ten days ago, but haven't > gotten a reply yet. Are you sure? I have in my email archives a response to your email from copyright-clerk@fsf.org that was sent on Dec 28, with the PDF of your assignment attached; you were supposed to sign it and email the scan of the signed form to them. Not sure why you sent another request on Jan 10. What am I missing here? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 21 10:32:38 2023 Received: (at 60703) by debbugs.gnu.org; 21 Jan 2023 15:32:38 +0000 Received: from localhost ([127.0.0.1]:49524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJFrB-0004Fh-Rk for submit@debbugs.gnu.org; Sat, 21 Jan 2023 10:32:38 -0500 Received: from mail-vs1-f51.google.com ([209.85.217.51]:45939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJFrA-0004FV-5u for 60703@debbugs.gnu.org; Sat, 21 Jan 2023 10:32:36 -0500 Received: by mail-vs1-f51.google.com with SMTP id v127so8670036vsb.12 for <60703@debbugs.gnu.org>; Sat, 21 Jan 2023 07:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6rRDnU53WLn+ASEav7Fi5NsgtY2+LMtJLanRtcuwsLM=; b=A3uejsnrtbNTZTMs/VFKufhkjxMEPC6d3z7zm0DDbc1M8LIe8895VJ4FbmdZv4MdYE Odl9tPvvAeFdgPqfilpnGRgrTXXbxWPIMw3xAjawzzgilgnKv5Ht4iJU4BfTrKlZoCSX El4e0++xYdpKZ931UTW9bG3VVQW6i2XDgso83Th9RuyFy1YBupdvebpeJ+6MS3qZRNfW dzHdpUxFYk25oljWl4AYpG1UhWa14LpiWmRkBlfVqXMnQq8MuvGbLJpyVhyEe5/MSfUx ST6iBNUtwiqScLIpoeZNUQhdXyXIMGvoaWGbxhjZhhqekveUwntj33N/zSyYY8R578LY FteQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6rRDnU53WLn+ASEav7Fi5NsgtY2+LMtJLanRtcuwsLM=; b=VmkmPbVfkL6R16MWYg9hNcWRBZt6FjITLMa1c/JrITse8L08w1K5UqlPv+jsvdfdui 936wdXS9NlQ4DPFRLQ51SmanfUhYRTi2nH92YVPn7EGyzfueHaRrtP8We1pEoRlF/Zb0 1JL07N17Jb6h2juGd7R9KUhWTE8H89xQ73SOwdfVKxf3lljBii+vI6VxZXnpPp36wZhy psTQwivG5rk/DYJ+4gjzJFceRb5GjSZfXH5+5yUsXWYrQnx3Qv4kgrIXEpTCyI5IjUjB r9E6FI8p15bq0WP49yjuE+TjhI2gkJhplEGROijxXeS/eOnTzKliCD0Z24SqNuKRUXT8 nshg== X-Gm-Message-State: AFqh2konW01eggExKSuJWppuJcqsUfvyN6wBJkwHXHmtfp02jfD4RMrF D1vMIY2lwnp7woFNthBRv5g+qMP5rPrF5L8XSEU= X-Google-Smtp-Source: AMrXdXu9lCmtYgkIWBoro4WWwWFnbwxah7kV9Il8cHFk2YiOgRNSdAhLqJ+eQe/2FQvcsieBSfrrVJosh42IJ1ZmKWY= X-Received: by 2002:a67:e109:0:b0:3d0:dcbb:2004 with SMTP id d9-20020a67e109000000b003d0dcbb2004mr2457499vsl.43.1674315150586; Sat, 21 Jan 2023 07:32:30 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> In-Reply-To: <83bkmsmk6g.fsf@gnu.org> From: Andrew De Angelis Date: Sat, 21 Jan 2023 10:32:19 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000caf82e05f2c7df97" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000caf82e05f2c7df97 Content-Type: text/plain; charset="UTF-8" Sorry about the confusion! Looks like I missed that reply. Some quick clarification though: the first assignment I sent out was for some modifications to shell.el (bug#60385; see also the thread "New Package: sticky-shell" in emacs-devel: I had a package idea and it was mentioned to add it as a feature instead). I then 1) missed the reply from copyright-clerk@fsf.org, 2) assumed I'd need an additional copyright assignment for the xwidget-patch, as it concerns different files. Is the first assignment good enough for all subsequent files I change? If that's the case I'll go ahead and sign it and send it back asap. Just wanted to make sure I'm following the correct procedure. Thanks for walking me through this. On Sat, Jan 21, 2023 at 2:16 AM Eli Zaretskii wrote: > > From: Andrew De Angelis > > Date: Sat, 21 Jan 2023 01:13:01 -0500 > > Cc: Eli Zaretskii , 60703@debbugs.gnu.org > > > > About the copyright assignment, I sent the attached email to > assign@gnu.org ten days ago, but haven't > > gotten a reply yet. > > Are you sure? I have in my email archives a response to your email > from copyright-clerk@fsf.org that was sent on Dec 28, with the PDF of > your assignment attached; you were supposed to sign it and email the > scan of the signed form to them. Not sure why you sent another > request on Jan 10. What am I missing here? > --000000000000caf82e05f2c7df97 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry about the confusion!
Looks like I mis= sed that reply.
Some quick clarification though: the first assign= ment I sent out was for some modifications to shell.el (bug#60385; see also= the thread "New Package: sticky-shell" in emacs-devel: I had a p= ackage idea and it was mentioned to add it as a feature instead). I then 1)= missed the reply from copyright-clerk@fsf.org, 2) assumed I'd need an additional= copyright assignment for the xwidget-patch, as it concerns different files= .
Is the first assignment good enough for all subsequent files I = change? If that's the case I'll go ahead and sign it and send it ba= ck asap. Just wanted to make sure I'm following the correct procedure.<= /div>

Thanks for walking me through this.

On Sa= t, Jan 21, 2023 at 2:16 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Andrew De Angelis <bobodeangelis@gmail.com>
> Date: Sat, 21 Jan 2023 01:13:01 -0500
> Cc: Eli Zaretskii <eliz@gnu.org>, 60703@debbugs.gnu.org
>
> About the copyright assignment, I sent the attached email to assign@gnu.org ten days ag= o, but haven't
> gotten a reply yet.

Are you sure?=C2=A0 I have in my email archives a response to your email from copyright= -clerk@fsf.org that was sent on Dec 28, with the PDF of
your assignment attached; you were supposed to sign it and email the
scan of the signed form to them.=C2=A0 Not sure why you sent another
request on Jan 10.=C2=A0 What am I missing here?
--000000000000caf82e05f2c7df97-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 21 10:41:20 2023 Received: (at 60703) by debbugs.gnu.org; 21 Jan 2023 15:41:20 +0000 Received: from localhost ([127.0.0.1]:49554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJFzc-0004UR-6Y for submit@debbugs.gnu.org; Sat, 21 Jan 2023 10:41:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJFza-0004UE-I7 for 60703@debbugs.gnu.org; Sat, 21 Jan 2023 10:41:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJFzU-00067t-2F; Sat, 21 Jan 2023 10:41:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7Lwi6MRK2oaHXSJOWUPSmiLqcEqLLvJ5aXVbAxJMxLE=; b=ppq88c1zRIsR /nkTB6vzjKYnz+yDA6tJG/j4mr8FvRg1ddIWTEoUnxh3+dcnrc5u2iPMyO9u5btXeUCbNp2IcgGad CAmn+8yz/L+aoYT1FjX8dl8k03APlj9S9l3lldbqUAVQlR7GMtraJx8Ep4/twQIoUeR1uWwyc0tK7 +QJng8GgzvtT0iBisshrlhAEh5bduNJmAgd53Hx8oh43nh/qJkx2bOvaKcFPwiuKBoGZBjPT6G7uh CkSwMGN/0uSoWQZTD6rzB4WGMFxx6W1hgQZIn4hNGI9uvETrUW9JpDr6u7jasPrQerkFXTGmAY+8N WcCnBhpn4vwBD2YZWxB/wQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJFzT-0002LU-Ht; Sat, 21 Jan 2023 10:41:11 -0500 Date: Sat, 21 Jan 2023 17:41:15 +0200 Message-Id: <83fsc3lwtg.fsf@gnu.org> From: Eli Zaretskii To: Andrew De Angelis In-Reply-To: (message from Andrew De Angelis on Sat, 21 Jan 2023 10:32:19 -0500) Subject: Re: bug#60703: Patches to xwidget code References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew De Angelis > Date: Sat, 21 Jan 2023 10:32:19 -0500 > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > Sorry about the confusion! > Looks like I missed that reply. > Some quick clarification though: the first assignment I sent out was for some modifications to shell.el > (bug#60385; see also the thread "New Package: sticky-shell" in emacs-devel: I had a package idea and it > was mentioned to add it as a feature instead). I then 1) missed the reply from copyright-clerk@fsf.org, 2) > assumed I'd need an additional copyright assignment for the xwidget-patch, as it concerns different files. > Is the first assignment good enough for all subsequent files I change? If that's the case I'll go ahead and sign > it and send it back asap. Just wanted to make sure I'm following the correct procedure. The assignment will be good for all your future contributions to Emacs, but first you need to do what the copyright clerk asked you to do: print the PDF form, sign it, scan it, and email it back. Then you'll get another email saying that your paperwork is complete, and then we can accept contributions from you. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 18:45:52 2023 Received: (at 60703) by debbugs.gnu.org; 26 Jan 2023 23:45:52 +0000 Received: from localhost ([127.0.0.1]:36419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLBwF-0001UZ-BD for submit@debbugs.gnu.org; Thu, 26 Jan 2023 18:45:51 -0500 Received: from mail-vs1-f41.google.com ([209.85.217.41]:46894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLBwE-0001UM-2P for 60703@debbugs.gnu.org; Thu, 26 Jan 2023 18:45:50 -0500 Received: by mail-vs1-f41.google.com with SMTP id h19so1887117vsv.13 for <60703@debbugs.gnu.org>; Thu, 26 Jan 2023 15:45:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aMdHDt1ANp/IqEp1wVDMb7tJ+peYbn/AodpaG+vZvcE=; b=WtFWtL68tdYxJcCCucS2kVyISgzXQSEIoVpwOQW+EqDRX7DRDNdb9hwNOFfxOF8tpx 5hhCDpS4/SiR0AtvaFobhTv5QZ2CpV6qPpE1GSn6rdp3pXafKAyGm2sKt3+8/8qc7IGo zahiozxoxKs9riNxc9zvNXY6ZE320GHKxek3dF+kLm8r1YAJKGEzS7+mao0IEFbJVge2 sy7XFxDHd0SKO01GcHn3/fRvCntX2hefcIwPvmFa2C0K4jddVZFU7klvx6dv9gX2EWJv MAPwb7MLA8IpjnzpPf8y+LpqaE690Eb3g572vKnULUhN+JFZYJ76TowQvNlztGovvG+S k9Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aMdHDt1ANp/IqEp1wVDMb7tJ+peYbn/AodpaG+vZvcE=; b=tsJVtt7tkjJ7Ta7WbdWJNqcse0dNpakD2NqNaZdpDgRlhz2yylTIZc53ut/tWrok7T FUitGQBYle6W76xna39m4qcQv11y9/OKyr++AX+I1nhIVFDPvtJYlezsgIlGX9NExxii X+GCZnaoNQVGfq6Dp/KzwiDHlO1WdaAkQbyFaIv2VFW2ste6WFDiIsbj2lIM/vKAgmCu /XhA1PtQVHr4sHioPtXA43yxZuSoKhXq5R5MfgbvwUoAtbvmlds0eF33sgq6liYmG0PK bUDEJuVrtO0qYezsXXCN6RnhPLnRZqNVwmYVdVaSLxmFehBrgQoDghAHSgOB/7qFOF1L hR2A== X-Gm-Message-State: AFqh2krUr/HapTaJguSDbs/MqZQysqG4gg93r3GAbNRIv6nlKbrky1QK e91zwRv0dvgLVY3VEc0sRyR0qrweZ11fBIBb5xw= X-Google-Smtp-Source: AMrXdXsSd9Q667Y3y8zbbbrv0pzjGIFcp2aUHniIpM52kAJrvPg2tB8u1CBSyQ9udfd/LILE9ymKY9742DtSUdQ/jKA= X-Received: by 2002:a05:6102:54ac:b0:3d0:af13:3b6 with SMTP id bk44-20020a05610254ac00b003d0af1303b6mr5105717vsb.65.1674776744325; Thu, 26 Jan 2023 15:45:44 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> In-Reply-To: <83fsc3lwtg.fsf@gnu.org> From: Andrew De Angelis Date: Thu, 26 Jan 2023 18:45:33 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000ece3ef05f333583b" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ece3ef05f333583b Content-Type: multipart/alternative; boundary="000000000000ece3ed05f3335839" --000000000000ece3ed05f3335839 Content-Type: text/plain; charset="UTF-8" Thanks for the explanation. I sent out the signed copy yesterday. I noticed a couple things about the previous patch, so I'm sending this one with a few updates: - `xwidget-webkit-current-url` in lisp/xwidget.el: check if the url variable is non-nil before calling `kill-new' on it. This avoids killing an empty string, which would be pointless. We still alert the user that something's wrong by messaging "URL: nil" (although getting a nil url seems very unlikely). - in src/nsxwidget.m: formatting (keep lines below 80 char), and a brief comment describing the purpose of some of the newly added functions I'm also attaching a draft of the ChangeLog. Let me know if you'd like me to make any changes there. I do have a question about the X11/GTK implementations for xwidget. I'm not sure I understand the relationship between the two: from the preprocessor macros it seems at times they are separate and at times that one is an addendum to the other. I'm asking because I want to make sure I'm using the preprocessor macros correctly: specifically, the function `xwidget-webkit-estimated-load-progress` within xwidget.c used to be inside a "#ifdef USE_GTK" block. I moved it outside of the block, and separated the GTK implementation from the NS_IMPL_COCOA implementation. Is this a problem for the X11 build? Should I instead put the whole function within a block along these lines: "#if defined USE_GTK || defined NS_IMPL_COCOA" ? On Sat, Jan 21, 2023 at 10:41 AM Eli Zaretskii wrote: > > From: Andrew De Angelis > > Date: Sat, 21 Jan 2023 10:32:19 -0500 > > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > > > Sorry about the confusion! > > Looks like I missed that reply. > > Some quick clarification though: the first assignment I sent out was for > some modifications to shell.el > > (bug#60385; see also the thread "New Package: sticky-shell" in > emacs-devel: I had a package idea and it > > was mentioned to add it as a feature instead). I then 1) missed the > reply from copyright-clerk@fsf.org, 2) > > assumed I'd need an additional copyright assignment for the > xwidget-patch, as it concerns different files. > > Is the first assignment good enough for all subsequent files I change? > If that's the case I'll go ahead and sign > > it and send it back asap. Just wanted to make sure I'm following the > correct procedure. > > The assignment will be good for all your future contributions to > Emacs, but first you need to do what the copyright clerk asked you to > do: print the PDF form, sign it, scan it, and email it back. Then > you'll get another email saying that your paperwork is complete, and > then we can accept contributions from you. > > Thanks. > --000000000000ece3ed05f3335839 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for the explanation. I sent out the signed cop= y yesterday.
I noticed a couple things about the previous pa= tch, so I'm sending this one with a few updates:
  • `xwi= dget-webkit-current-url` in lisp/xwidget.el: check if the url variable is n= on-nil before=20 calling `kill-new' on it. This avoids killing an empty string, which=20 would be pointless. We still alert the user that something's wrong by= =20 messaging "URL: nil" (although getting a nil url seems very unlik= ely).
  • in src/nsxwidget.m: formatting (keep lines below 80 char), an= d a brief comment describing the purpose of some of the newly added functio= ns

I'm also attaching a draft of the Chang= eLog. Let me know if you'd like me to make any changes there.

I do have a question about the X11/GTK implementations= for xwidget. I'm not sure I understand the relationship between the tw= o: from the preprocessor macros it seems at times they are separate and at = times that one is an addendum to the other.
I'm asking becaus= e I want to make sure I'm using the preprocessor macros correctly: spec= ifically, the function `xwidget-webkit-estimated-load-progress` within xwid= get.c used to be inside a "#ifdef USE_GTK" block. I moved it outs= ide of the block, and separated the GTK implementation from the NS_IMPL_COC= OA implementation. Is this a problem for the X11 build? Should I instead pu= t the whole function within a block along these lines: "#if defined US= E_GTK || defined NS_IMPL_COCOA" ?


=
On Sat, Ja= n 21, 2023 at 10:41 AM Eli Zaretskii <el= iz@gnu.org> wrote:
> From: Andrew De Angelis <bobodeangelis@gmail.com>
> Date: Sat, 21 Jan 2023 10:32:19 -0500
> Cc: luangruo@y= ahoo.com, 60= 703@debbugs.gnu.org
>
> Sorry about the confusion!
> Looks like I missed that reply.
> Some quick clarification though: the first assignment I sent out was f= or some modifications to shell.el
> (bug#60385; see also the thread "New Package: sticky-shell" = in emacs-devel: I had a package idea and it
> was mentioned to add it as a feature instead). I then 1) missed the re= ply from copyr= ight-clerk@fsf.org, 2)
> assumed I'd need an additional copyright assignment for the xwidge= t-patch, as it concerns different files.
> Is the first assignment good enough for all subsequent files I change?= If that's the case I'll go ahead and sign
> it and send it back asap. Just wanted to make sure I'm following t= he correct procedure.

The assignment will be good for all your future contributions to
Emacs, but first you need to do what the copyright clerk asked you to
do: print the PDF form, sign it, scan it, and email it back.=C2=A0 Then
you'll get another email saying that your paperwork is complete, and then we can accept contributions from you.

Thanks.
--000000000000ece3ed05f3335839-- --000000000000ece3ef05f333583b Content-Type: application/octet-stream; name="ChangeLog.andrewda" Content-Disposition: attachment; filename="ChangeLog.andrewda" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lddqnn6o0 MjAyMy0wMS0yNiAgQW5kcmV3IERlIEFuZ2VsaXMgIDxib2JvZGVhbmdlbGlzQGdtYWlsLmNvbT4K CSogc3JjL25zeHdpZGdldC5tICgpCgkoW1h3V2ViVmlldyBpbml0V2l0aEZyYW1lOmNvbmZpZ3Vy YXRpb246eHdpZGdldDpdKQoJKG5zeHdpZGdldF9pbml0KTogIEZpeGVkIG1lbW9yeSBsZWFrczog d2hlbiBzZW5kaW5nIGFuIGFsbG9jIG1lc3NhZ2UgdG8KCWFuIG9iamVjdCwgc2VuZCBhbiBhdXRv cmVsZWFzZSBtZXNzYWdlIHRvIGFueSBvYmplY3RzIHdlIHdvbid0CglleHBsaWN0bHkgcmVsZWFz ZQoJKFtYd1dlYlZpZXcgd2ViVmlldzpkaWRGaW5pc2hOYXZpZ2F0aW9uOl0pOiBTZWNvbmQgc3Ry aW5nIHRvIHN0b3JlIGluCglzdG9yZV94d2lkZ2V0X2V2ZW50X3N0cmluZyBpcyAibG9hZCBmaW5p c2hlZCIgcmF0aGVyIHRoYW4gZW1wdHkgc3RyaW5nCgkoW1h3V2ViVmlldyB3ZWJWaWV3OmRpZFN0 YXJ0UHJvdmlzaW9uYWxOYXZpZ2F0aW9uOl0pCgkoW1h3V2ViVmlldyB3ZWJWaWV3OmRpZFJlY2Vp dmVTZXJ2ZXJSZWRpcmVjdEZvclByb3Zpc2lvbmFsTmF2aWdhdGlvbjpdKQoJKFtYd1dlYlZpZXcg d2ViVmlldzpkaWRDb21taXROYXZpZ2F0aW9uOl0pOiBOZXcgZnVuY3Rpb25zCgkobnN4d2lkZ2V0 X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyk6IE5ldyBmdW5jdGlvbgoJKG5zeHdpZGdl dF93ZWJraXRfc3RvcF9sb2FkaW5nKTogTmV3IGZ1bmN0aW9uCgkqIHNyYy94d2lkZ2V0LmMgKEZ4 d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyk6IENhbGwKCW5zeHdpZGdldF93 ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MgaWYgd2UncmUgb24gTWFjT1MKCShGeHdpZGdl dF93ZWJraXRfc3RvcF9sb2FkaW5nKTogQ2FsbCBuc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGlu ZyBpZgoJd2UncmUgb24gTWFjT1MKCShzeW1zX29mX3h3aWRnZXQpOiBEZWZpbmUgc3ltYm9sIGZv ciBmdW5jdGlvbgoJeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MgaWYgd2Un cmUgb24gTWFjT1MKCSogc3JjL25zeHdpZGdldC5oOiBzaWduYXR1cmUgZm9yIGZ1bmN0aW9ucwoJ bnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyBhbmQKCW5zeHdpZGdldF93 ZWJraXRfc3RvcF9sb2FkaW5nCgkqIGxpc3AveHdpZGdldC5lbCAoeHdpZGdldC13ZWJraXQtY3Vy cmVudC11cmwpOiBNZXNzYWdlIFVSTCByYXRoZXIgdGhhbgoJcmV0dXJuIHZhbHVlIG9mIGtpbGwt bmV3ICh3aGljaCBpcyBhbHdheXMgbmlsKQo= --000000000000ece3ef05f333583b Content-Type: application/octet-stream; name="xwidget-patches-2.patch" Content-Disposition: attachment; filename="xwidget-patches-2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lddqo0pf1 ZGlmZiAtLWdpdCBhL2xpc3AveHdpZGdldC5lbCBiL2xpc3AveHdpZGdldC5lbAppbmRleCBhYmJk YTI5MDgxLi43ZGFjYTgxZjlmIDEwMDY0NAotLS0gYS9saXNwL3h3aWRnZXQuZWwKKysrIGIvbGlz cC94d2lkZ2V0LmVsCkBAIC05MjUsNyArOTI1LDggQEAgeHdpZGdldC13ZWJraXQtY3VycmVudC11 cmwKICAgIkRpc3BsYXkgdGhlIGN1cnJlbnQgeHdpZGdldCB3ZWJraXQgVVJMIGFuZCBwbGFjZSBp dCBvbiB0aGUgYGtpbGwtcmluZycuIgogICAoaW50ZXJhY3RpdmUgbmlsIHh3aWRnZXQtd2Via2l0 LW1vZGUpCiAgIChsZXQgKCh1cmwgKHh3aWRnZXQtd2Via2l0LXVyaSAoeHdpZGdldC13ZWJraXQt Y3VycmVudC1zZXNzaW9uKSkpKQotICAgIChtZXNzYWdlICJVUkw6ICVzIiAoa2lsbC1uZXcgKG9y IHVybCAiIikpKSkpCisgICAgKHdoZW4gdXJsIChraWxsLW5ldyB1cmwpKQorICAgIChtZXNzYWdl ICJVUkw6ICVzIiB1cmwpKSkKIAogKGRlZnVuIHh3aWRnZXQtd2Via2l0LWJyb3dzZS1oaXN0b3J5 ICgpCiAgICJEaXNwbGF5IGEgYnVmZmVyIGNvbnRhaW5pbmcgdGhlIGhpc3Rvcnkgb2YgcGFnZSBs b2Fkcy4iCmRpZmYgLS1naXQgYS9zcmMvbnN4d2lkZ2V0LmggYi9zcmMvbnN4d2lkZ2V0LmgKaW5k ZXggOGQ1NWZhYzUzMi4uMmI1NTk2ZjkwNSAxMDA2NDQKLS0tIGEvc3JjL25zeHdpZGdldC5oCisr KyBiL3NyYy9uc3h3aWRnZXQuaApAQCAtMzYsNiArMzYsOCBAQCAjZGVmaW5lIE5TWFdJREdFVF9I X0lOQ0xVREVECiBMaXNwX09iamVjdCBuc3h3aWRnZXRfd2Via2l0X3RpdGxlIChzdHJ1Y3QgeHdp ZGdldCAqeHcpOwogdm9pZCBuc3h3aWRnZXRfd2Via2l0X2dvdG9fdXJpIChzdHJ1Y3QgeHdpZGdl dCAqeHcsIGNvbnN0IGNoYXIgKnVyaSk7CiB2b2lkIG5zeHdpZGdldF93ZWJraXRfZ290b19oaXN0 b3J5IChzdHJ1Y3QgeHdpZGdldCAqeHcsIGludCByZWxfcG9zKTsKK2RvdWJsZSBuc3h3aWRnZXRf d2Via2l0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzKHN0cnVjdCB4d2lkZ2V0ICp4dyk7Cit2b2lk IG5zeHdpZGdldF93ZWJraXRfc3RvcF9sb2FkaW5nIChzdHJ1Y3QgeHdpZGdldCAqeHcpOwogdm9p ZCBuc3h3aWRnZXRfd2Via2l0X3pvb20gKHN0cnVjdCB4d2lkZ2V0ICp4dywgZG91YmxlIHpvb21f Y2hhbmdlKTsKIHZvaWQgbnN4d2lkZ2V0X3dlYmtpdF9leGVjdXRlX3NjcmlwdCAoc3RydWN0IHh3 aWRnZXQgKnh3LCBjb25zdCBjaGFyICpzY3JpcHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIExpc3BfT2JqZWN0IGZ1bik7CmRpZmYgLS1naXQgYS9zcmMvbnN4d2lkZ2V0 Lm0gYi9zcmMvbnN4d2lkZ2V0Lm0KaW5kZXggZTFmYmQ3NDliNi4uMGUwMDU4OWJiNyAxMDA2NDQK LS0tIGEvc3JjL25zeHdpZGdldC5tCisrKyBiL3NyYy9uc3h3aWRnZXQubQpAQCAtNTcsMTIgKzU3 LDEzIEBAIEBpbnRlcmZhY2UgWHdXZWJWaWV3IDogV0tXZWJWaWV3CiBAZW5kCiBAaW1wbGVtZW50 YXRpb24gWHdXZWJWaWV3IDogV0tXZWJWaWV3CiAKLS0gKGlkKWluaXRXaXRoRnJhbWU6KENHUmVj dClmcmFtZQorLSAoaWQpIGluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZQogICAgICAgY29uZmln dXJhdGlvbjooV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24KICAgICAgICAg ICAgIHh3aWRnZXQ6KHN0cnVjdCB4d2lkZ2V0ICopeHcKIHsKICAgLyogU2NyaXB0IGNvbnRyb2xs ZXIgdG8gYWRkIHNjcmlwdCBtZXNzYWdlIGhhbmRsZXIgYW5kIHVzZXIgc2NyaXB0LiAgKi8KLSAg V0tVc2VyQ29udGVudENvbnRyb2xsZXIgKnNjcmlwdG9yID0gW1tXS1VzZXJDb250ZW50Q29udHJv bGxlciBhbGxvY10gaW5pdF07CisgIFdLVXNlckNvbnRlbnRDb250cm9sbGVyICpzY3JpcHRvciA9 IFtbW1dLVXNlckNvbnRlbnRDb250cm9sbGVyIGFsbG9jXSBpbml0XQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGF1dG9yZWxlYXNlXTsKICAgY29uZmlndXJhdGlvbi51 c2VyQ29udGVudENvbnRyb2xsZXIgPSBzY3JpcHRvcjsKIAogICAvKiBFbmFibGUgaW5zcGVjdCBl bGVtZW50IGNvbnRleHQgbWVudSBpdGVtIGZvciBkZWJ1Z2dpbmcuICAqLwpAQCAtODEsNyArODIs OCBAQCAtIChpZClpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUKICAgaWYgKHNlbGYpCiAgICAg ewogICAgICAgc2VsZi54dyA9IHh3OwotICAgICAgc2VsZi51cmxTY3JpcHRCbG9ja2VkID0gW1tO U011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XTsKKyAgICAgIHNlbGYudXJsU2NyaXB0Qmxv Y2tlZCA9IFtbW05TTXV0YWJsZURpY3Rpb25hcnkgYWxsb2NdIGluaXRdCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGF1dG9yZWxlYXNlXTsKICAgICAgIHNlbGYubmF2aWdhdGlvbkRl bGVnYXRlID0gc2VsZjsKICAgICAgIHNlbGYuVUlEZWxlZ2F0ZSA9IHNlbGY7CiAgICAgICBzZWxm LmN1c3RvbVVzZXJBZ2VudCA9CkBAIC04OSwyMyArOTEsNDggQEAgLSAoaWQpaW5pdFdpdGhGcmFt ZTooQ0dSZWN0KWZyYW1lCiAgICAgICAgIEAiIEFwcGxlV2ViS2l0LzYwMy4zLjggKEtIVE1MLCBs aWtlIEdlY2tvKSIKICAgICAgICAgQCIgVmVyc2lvbi8xMS4wLjEgU2FmYXJpLzYwMy4zLjgiOwog ICAgICAgW3NjcmlwdG9yIGFkZFNjcmlwdE1lc3NhZ2VIYW5kbGVyOnNlbGYgbmFtZTpAImtleURv d24iXTsKLSAgICAgIFtzY3JpcHRvciBhZGRVc2VyU2NyaXB0OltbV0tVc2VyU2NyaXB0IGFsbG9j XQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbml0V2l0aFNvdXJjZTp4d1Njcmlw dAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5qZWN0aW9uVGltZToKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXS1VzZXJTY3JpcHRJbmplY3Rpb25UaW1lQXRE b2N1bWVudFN0YXJ0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvck1haW5GcmFt ZU9ubHk6Tk9dXTsKKyAgICAgIFdLVXNlclNjcmlwdCAqdXNlclNjcmlwdCA9IFtbW1dLVXNlclNj cmlwdCBhbGxvY10KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluaXRXaXRo U291cmNlOnh3U2NyaXB0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5q ZWN0aW9uVGltZToKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV0tVc2Vy U2NyaXB0SW5qZWN0aW9uVGltZUF0RG9jdW1lbnRTdGFydAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZm9yTWFpbkZyYW1lT25seTpOT10gYXV0b3JlbGVhc2VdOworICAgICAg W3NjcmlwdG9yIGFkZFVzZXJTY3JpcHQ6dXNlclNjcmlwdF07CiAgICAgfQogICByZXR1cm4gc2Vs ZjsKIH0KIAotLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CisvKiBUaGVzZSA0 IGZ1bmN0aW9ucyBlbXVsYXRlIHRoZSBiZWhhdmlvciBvZiB3ZWJraXRfdmlld19sb2FkX2NoYW5n ZWRfY2IKKyAgIGluIHRoZSBHVEsgaW1wbGVtZW50YXRpb24qLworLSAodm9pZCkgd2ViVmlldzoo V0tXZWJWaWV3ICopd2ViVmlldwogZGlkRmluaXNoTmF2aWdhdGlvbjooV0tOYXZpZ2F0aW9uICop bmF2aWdhdGlvbgogewogICBpZiAoRVEgKEZidWZmZXJfbGl2ZV9wIChzZWxmLnh3LT5idWZmZXIp LCBRdCkpCi0gICAgc3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYueHcsICJsb2FkLWNo YW5nZWQiLCAiIik7CisgICAgc3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYueHcsICJs b2FkLWNoYW5nZWQiLCAibG9hZC1maW5pc2hlZCIpOwogfQogCi0tICh2b2lkKXdlYlZpZXc6KFdL V2ViVmlldyAqKXdlYlZpZXcKKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcK K2RpZFN0YXJ0UHJvdmlzaW9uYWxOYXZpZ2F0aW9uOihXS05hdmlnYXRpb24gKiluYXZpZ2F0aW9u Cit7CisgIGlmIChFUSAoRmJ1ZmZlcl9saXZlX3AgKHNlbGYueHctPmJ1ZmZlciksIFF0KSkKKyAg ICBzdG9yZV94d2lkZ2V0X2V2ZW50X3N0cmluZyAoc2VsZi54dywgImxvYWQtY2hhbmdlZCIsICJs b2FkLXN0YXJ0ZWQiKTsKK30KKworLSAodm9pZCkgd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmll dworZGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9yUHJvdmlzaW9uYWxOYXZpZ2F0aW9uOihXS05h dmlnYXRpb24gKiluYXZpZ2F0aW9uCit7CisgIGlmIChFUSAoRmJ1ZmZlcl9saXZlX3AgKHNlbGYu eHctPmJ1ZmZlciksIFF0KSkKKyAgICBzdG9yZV94d2lkZ2V0X2V2ZW50X3N0cmluZyAoc2VsZi54 dywgImxvYWQtY2hhbmdlZCIsICJsb2FkLXJlZGlyZWN0ZWQiKTsKK30KKworLyogU3RhcnQgbG9h ZGluZyBXS1dlYlZpZXcgKi8KKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcK K2RpZENvbW1pdE5hdmlnYXRpb246KFdLTmF2aWdhdGlvbiAqKW5hdmlnYXRpb24KK3sKKyAgaWYg KEVRIChGYnVmZmVyX2xpdmVfcCAoc2VsZi54dy0+YnVmZmVyKSwgUXQpKQorICAgIHN0b3JlX3h3 aWRnZXRfZXZlbnRfc3RyaW5nIChzZWxmLnh3LCAibG9hZC1jaGFuZ2VkIiwgImxvYWQtY29tbWl0 dGVkIik7Cit9CisKKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKIGRlY2lk ZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246KFdLTmF2aWdhdGlvbkFjdGlvbiAqKW5hdmlnYXRp b25BY3Rpb24KIGRlY2lzaW9uSGFuZGxlcjoodm9pZCAoXikoV0tOYXZpZ2F0aW9uQWN0aW9uUG9s aWN5KSlkZWNpc2lvbkhhbmRsZXIKIHsKQEAgLTExNCwxMyArMTQxLDEzIEBAIC0gKHZvaWQpd2Vi VmlldzooV0tXZWJWaWV3ICopd2ViVmlldwogICAgIGRlY2lzaW9uSGFuZGxlciAoV0tOYXZpZ2F0 aW9uQWN0aW9uUG9saWN5QWxsb3cpOwogICAgIGJyZWFrOwogICBkZWZhdWx0OgotICAgIC8vIGRl Y2lzaW9uSGFuZGxlciAoV0tOYXZpZ2F0aW9uQWN0aW9uUG9saWN5Q2FuY2VsKTsKKyAgICAvKiBk ZWNpc2lvbkhhbmRsZXIgKFdLTmF2aWdhdGlvbkFjdGlvblBvbGljeUNhbmNlbCk7ICovCiAgICAg ZGVjaXNpb25IYW5kbGVyIChXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3lBbGxvdyk7CiAgICAgYnJl YWs7CiAgIH0KIH0KIAotLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CistICh2 b2lkKSB3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CiBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0 aW9uUmVzcG9uc2U6KFdLTmF2aWdhdGlvblJlc3BvbnNlICopbmF2aWdhdGlvblJlc3BvbnNlCiBk ZWNpc2lvbkhhbmRsZXI6KHZvaWQgKF4pKFdLTmF2aWdhdGlvblJlc3BvbnNlUG9saWN5KSlkZWNp c2lvbkhhbmRsZXIKIHsKQEAgLTE2Niw3ICsxOTMsNyBAQCAtICh2b2lkKXdlYlZpZXc6KFdLV2Vi VmlldyAqKXdlYlZpZXcKIAogLyogTm8gYWRkaXRpb25hbCBuZXcgd2VidmlldyBvciBlbWFjcyB3 aW5kb3cgd2lsbCBiZSBjcmVhdGVkCiAgICBmb3IgPGEgLi4uIHRhcmdldD0iX2JsYW5rIj4uICAq LwotLSAoV0tXZWJWaWV3ICopd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldworLSAoV0tXZWJW aWV3ICopIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKIGNyZWF0ZVdlYlZpZXdXaXRoQ29u ZmlndXJhdGlvbjooV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24KICAgIGZv ck5hdmlnYXRpb25BY3Rpb246KFdLTmF2aWdhdGlvbkFjdGlvbiAqKW5hdmlnYXRpb25BY3Rpb24K ICAgICAgICAgd2luZG93RmVhdHVyZXM6KFdLV2luZG93RmVhdHVyZXMgKil3aW5kb3dGZWF0dXJl cwpAQCAtMTc3LDcgKzIwNCw3IEBAIC0gKFdLV2ViVmlldyAqKXdlYlZpZXc6KFdLV2ViVmlldyAq KXdlYlZpZXcKIH0KIAogLyogT3BlbiBwYW5lbCBmb3IgZmlsZSB1cGxvYWQuICAqLwotLSAodm9p ZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CistICh2b2lkKSB3ZWJWaWV3OihXS1dlYlZp ZXcgKil3ZWJWaWV3CiBydW5PcGVuUGFuZWxXaXRoUGFyYW1ldGVyczooV0tPcGVuUGFuZWxQYXJh bWV0ZXJzICopcGFyYW1ldGVycwogaW5pdGlhdGVkQnlGcmFtZTooV0tGcmFtZUluZm8gKilmcmFt ZQogY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKE5TQXJyYXk8TlNVUkwgKj4gKlVSTHMpKWNv bXBsZXRpb25IYW5kbGVyCkBAIC0xOTcsMTMgKzIyNCwxMyBAQCAtICh2b2lkKXdlYlZpZXc6KFdL V2ViVmlldyAqKXdlYlZpZXcKICAgIC0gQ29ycmVjdCBtb3VzZSBoYW5kL2Fycm93L0ktYmVhbSBp cyBkaXNwbGF5ZWQgKFRPRE86IG5vdCBwZXJmZWN0IHlldCkuCiAqLwogCi0tICh2b2lkKW1vdXNl RG93bjooTlNFdmVudCAqKWV2ZW50CistICh2b2lkKSBtb3VzZURvd246KE5TRXZlbnQgKilldmVu dAogewogICBbc2VsZi54dy0+eHYtPmVtYWNzd2luZG93IG1vdXNlRG93bjpldmVudF07CiAgIFtz dXBlciBtb3VzZURvd246ZXZlbnRdOwogfQogCi0tICh2b2lkKW1vdXNlVXA6KE5TRXZlbnQgKill dmVudAorLSAodm9pZCkgbW91c2VVcDooTlNFdmVudCAqKWV2ZW50CiB7CiAgIFtzZWxmLnh3LT54 di0+ZW1hY3N3aW5kb3cgbW91c2VVcDpldmVudF07CiAgIFtzdXBlciBtb3VzZVVwOmV2ZW50XTsK QEAgLTIxNCw3ICsyNDEsNyBAQCAtICh2b2lkKW1vdXNlVXA6KE5TRXZlbnQgKilldmVudAogICAg ZW1hY3MgYXMgZmlyc3QgcmVzcG9uZGVyIHRvIGF2b2lkIGZvY3VzIGhlbGQgaW4gYW4gaW5wdXQg ZWxlbWVudAogICAgd2l0aCBtYXRjaGluZyB0ZXh0LiAgKi8KIAotLSAodm9pZClrZXlEb3duOihO U0V2ZW50ICopZXZlbnQKKy0gKHZvaWQpIGtleURvd246KE5TRXZlbnQgKilldmVudAogewogICBM aXNwX09iamVjdCB2YXIgPSBGaW50ZXJuIChidWlsZF9zdHJpbmcgKCJpc2VhcmNoLW1vZGUiKSwg UW5pbCk7CiAgIExpc3BfT2JqZWN0IHZhbCA9IGJ1ZmZlcl9sb2NhbF92YWx1ZSAodmFyLCBGY3Vy cmVudF9idWZmZXIgKCkpOwpAQCAtMjUwLDcgKzI3Nyw3IEBAIC0gKHZvaWQpa2V5RG93bjooTlNF dmVudCAqKWV2ZW50CiAgICAgfV07CiB9CiAKLS0gKHZvaWQpaW50ZXJwcmV0S2V5RXZlbnRzOihO U0FycmF5PE5TRXZlbnQgKj4gKilldmVudEFycmF5CistICh2b2lkKSBpbnRlcnByZXRLZXlFdmVu dHM6KE5TQXJyYXk8TlNFdmVudCAqPiAqKWV2ZW50QXJyYXkKIHsKICAgLyogV2Ugc2hvdWxkIGRv IG5vdGhpbmcgYW5kIGRvIG5vdCBmb3J3YXJkIChkZWZhdWx0IGltcGxlbWVudGF0aW9uCiAgICAg IGlmIHdlIG5vdCBvdmVycmlkZSBoZXJlKSB0byBsZXQgZW1hY3MgY29sbGVjdCBrZXkgZXZlbnRz IGFuZCBhc2sKQEAgLTI1OCw3ICsyODUsNyBAQCAtICh2b2lkKWludGVycHJldEtleUV2ZW50czoo TlNBcnJheTxOU0V2ZW50ICo+ICopZXZlbnRBcnJheQogfQogCiBzdGF0aWMgTlNTdHJpbmcgKnh3 U2NyaXB0OwotKyAodm9pZClpbml0aWFsaXplCisrICh2b2lkKSBpbml0aWFsaXplCiB7CiAgIC8q IEZpbmQgb3V0IGlmIGFuIGlucHV0IGVsZW1lbnQgaGFzIGZvY3VzLgogICAgICBNZXNzYWdlIHRv IHNjcmlwdCBtZXNzYWdlIGhhbmRsZXIgd2hlbiAnQy1nJyBrZXkgZG93bi4gICovCkBAIC0yODQs NyArMzExLDcgQEAgKyAodm9pZClpbml0aWFsaXplCiAKIC8qIENvbmZpcm1pbmcgdG8gV0tTY3Jp cHRNZXNzYWdlSGFuZGxlciwgbGlzdGVucyBjb25jZXJuaW5nIGtleURvd24gaW4KICAgIHdlYmtp dC4gQ3VycmVudGx5ICdDLWcnLiAgKi8KLS0gKHZvaWQpdXNlckNvbnRlbnRDb250cm9sbGVyOihX S1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxlcgorLSAodm9pZCkg dXNlckNvbnRlbnRDb250cm9sbGVyOihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJDb250 ZW50Q29udHJvbGxlcgogICAgICAgZGlkUmVjZWl2ZVNjcmlwdE1lc3NhZ2U6KFdLU2NyaXB0TWVz c2FnZSAqKW1lc3NhZ2UKIHsKICAgaWYgKFttZXNzYWdlLmJvZHkgaXNFcXVhbFRvU3RyaW5nOkAi Qy1nIl0pCkBAIC0zNDMsNiArMzcwLDIwIEBAIC0gKHZvaWQpdXNlckNvbnRlbnRDb250cm9sbGVy OihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxlcgogICB9CiB9 CiAKK2RvdWJsZQorbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyAoc3Ry dWN0IHh3aWRnZXQgKnh3KQoreworICBYd1dlYlZpZXcgKnh3V2ViVmlldyA9IChYd1dlYlZpZXcg KikgeHctPnh3V2lkZ2V0OworICByZXR1cm4geHdXZWJWaWV3LmVzdGltYXRlZFByb2dyZXNzOwor fQorCit2b2lkCituc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZyAoc3RydWN0IHh3aWRnZXQg Knh3KQoreworICBYd1dlYlZpZXcgKnh3V2ViVmlldyA9IChYd1dlYlZpZXcgKikgeHctPnh3V2lk Z2V0OworICBbeHdXZWJWaWV3IHN0b3BMb2FkaW5nXTsKK30KKwogdm9pZAogbnN4d2lkZ2V0X3dl YmtpdF96b29tIChzdHJ1Y3QgeHdpZGdldCAqeHcsIGRvdWJsZSB6b29tX2NoYW5nZSkKIHsKQEAg LTQzMCw3ICs0NzEsNyBAQCAtICh2b2lkKXVzZXJDb250ZW50Q29udHJvbGxlcjooV0tVc2VyQ29u dGVudENvbnRyb2xsZXIgKil1c2VyQ29udGVudENvbnRyb2xsZXIKICAgICAgICAgfQogICAgICAg ZWxzZSBpZiAocmVzdWx0ICYmIEZVTkNUSU9OUCAoZnVuKSkKICAgICAgICAgewotICAgICAgICAg IC8vIE5TTG9nIChAInJlc3VsdD0lQCwgdHlwZT0lQCIsIHJlc3VsdCwgW3Jlc3VsdCBjbGFzc10p OworICAgICAgICAgIC8qIE5TTG9nIChAInJlc3VsdD0lQCwgdHlwZT0lQCIsIHJlc3VsdCwgW3Jl c3VsdCBjbGFzc10pOyAqLwogICAgICAgICAgIExpc3BfT2JqZWN0IGxpc3BfdmFsdWUgPSBqc190 b19saXNwIChyZXN1bHQpOwogICAgICAgICAgIHN0b3JlX3h3aWRnZXRfanNfY2FsbGJhY2tfZXZl bnQgKHh3LCBmdW4sIGxpc3BfdmFsdWUpOwogICAgICAgICB9CkBAIC00NDAsMTkgKzQ4MSwyMCBA QCAtICh2b2lkKXVzZXJDb250ZW50Q29udHJvbGxlcjooV0tVc2VyQ29udGVudENvbnRyb2xsZXIg Kil1c2VyQ29udGVudENvbnRyb2xsZXIKIC8qIFdpbmRvdyBjb250YWluaW5nIGFuIHh3aWRnZXQu ICAqLwogCiBAaW1wbGVtZW50YXRpb24gWHdXaW5kb3cKLS0gKEJPT0wpaXNGbGlwcGVkIHsgcmV0 dXJuIFlFUzsgfQorLSAoQk9PTCkgaXNGbGlwcGVkIHsgcmV0dXJuIFlFUzsgfQogQGVuZAogCiAv KiBYd2lkZ2V0IG1vZGVsLCBtYWNPUyBDb2NvYSBwYXJ0LiAgKi8KIAogdm9pZAotbnN4d2lkZ2V0 X2luaXQoc3RydWN0IHh3aWRnZXQgKnh3KQorbnN4d2lkZ2V0X2luaXQgKHN0cnVjdCB4d2lkZ2V0 ICp4dykKIHsKICAgYmxvY2tfaW5wdXQgKCk7CiAgIE5TUmVjdCByZWN0ID0gTlNNYWtlUmVjdCAo MCwgMCwgeHctPndpZHRoLCB4dy0+aGVpZ2h0KTsKICAgeHctPnh3V2lkZ2V0ID0gW1tYd1dlYlZp ZXcgYWxsb2NdCiAgICAgICAgICAgICAgICAgICAgaW5pdFdpdGhGcmFtZTpyZWN0Ci0gICAgICAg ICAgICAgICAgICAgY29uZmlndXJhdGlvbjpbW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gYWxsb2Nd IGluaXRdCisgICAgICAgICAgICAgICAgICAgY29uZmlndXJhdGlvbjpbW1tXS1dlYlZpZXdDb25m aWd1cmF0aW9uIGFsbG9jXSBpbml0XQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBhdXRvcmVsZWFzZV0KICAgICAgICAgICAgICAgICAgICAgICAgICB4d2lkZ2V0Onh3XTsKICAg eHctPnh3V2luZG93ID0gW1tYd1dpbmRvdyBhbGxvY10KICAgICAgICAgICAgICAgICAgICBpbml0 V2l0aEZyYW1lOnJlY3RdOwpAQCAtNDcwLDE2ICs1MTIsMTggQEAgLSAoQk9PTClpc0ZsaXBwZWQg eyByZXR1cm4gWUVTOyB9CiAgICAgICAgICgoWHdXZWJWaWV3ICopIHh3LT54d1dpZGdldCkuY29u ZmlndXJhdGlvbi51c2VyQ29udGVudENvbnRyb2xsZXI7CiAgICAgICBbc2NyaXB0b3IgcmVtb3Zl QWxsVXNlclNjcmlwdHNdOwogICAgICAgW3NjcmlwdG9yIHJlbW92ZVNjcmlwdE1lc3NhZ2VIYW5k bGVyRm9yTmFtZTpAImtleURvd24iXTsKLSAgICAgIFtzY3JpcHRvciByZWxlYXNlXTsKKwogICAg ICAgaWYgKHh3LT54dikKICAgICAgICAgeHctPnh2LT5tb2RlbCA9IFFuaWw7IC8qIE1ha2Ugc3Vy ZSByZWxhdGVkIHZpZXcgc3RhbGUuICAqLwogCiAgICAgICAvKiBUaGlzIHN0b3BzIHBsYXlpbmcg YXVkaW8gd2hlbiBhIHh3aWRnZXQtd2Via2l0IGJ1ZmZlciBpcwotICAgICAgICAga2lsbGVkLiAg SSBjb3VsZCBub3QgZmluZCBvdGhlciBzb2x1dGlvbi4gICovCisgICAgICAgICBraWxsZWQuICBJ IGNvdWxkIG5vdCBmaW5kIG90aGVyIHNvbHV0aW9uLgorICAgICAgICAgVE9ETzogaW1wcm92ZSB0 aGlzICovCiAgICAgICBuc3h3aWRnZXRfd2Via2l0X2dvdG9fdXJpICh4dywgImFib3V0OmJsYW5r Iik7CiAKICAgICAgIFsoKFh3V2ViVmlldyAqKSB4dy0+eHdXaWRnZXQpLnVybFNjcmlwdEJsb2Nr ZWQgcmVsZWFzZV07CiAgICAgICBbeHctPnh3V2lkZ2V0IHJlbW92ZUZyb21TdXBlcnZpZXdXaXRo b3V0TmVlZGluZ0Rpc3BsYXldOworCiAgICAgICBbeHctPnh3V2lkZ2V0IHJlbGVhc2VdOwogICAg ICAgW3h3LT54d1dpbmRvdyByZW1vdmVGcm9tU3VwZXJ2aWV3V2l0aG91dE5lZWRpbmdEaXNwbGF5 XTsKICAgICAgIFt4dy0+eHdXaW5kb3cgcmVsZWFzZV07CkBAIC01MDcsNyArNTUxLDcgQEAgLSAo Qk9PTClpc0ZsaXBwZWQgeyByZXR1cm4gWUVTOyB9CiAvKiBYd2lkZ2V0IHZpZXcsIG1hY09TIENv Y29hIHBhcnQuICAqLwogCiBAaW1wbGVtZW50YXRpb24gWHZXaW5kb3cgOiBOU1ZpZXcKLS0gKEJP T0wpaXNGbGlwcGVkIHsgcmV0dXJuIFlFUzsgfQorLSAoQk9PTCkgaXNGbGlwcGVkIHsgcmV0dXJu IFlFUzsgfQogQGVuZAogCiB2b2lkCmRpZmYgLS1naXQgYS9zcmMveHdpZGdldC5jIGIvc3JjL3h3 aWRnZXQuYwppbmRleCBlZmUyNzA1NTYyLi43ZjMwZTQ4Yzk1IDEwMDY0NAotLS0gYS9zcmMveHdp ZGdldC5jCisrKyBiL3NyYy94d2lkZ2V0LmMKQEAgLTMwNjMsNiArMzA2MywzNiBAQCBERUZVTiAo Inh3aWRnZXQtd2Via2l0LXRpdGxlIiwKICNlbmRpZgogfQogCitERUZVTiAoInh3aWRnZXQtd2Vi a2l0LWVzdGltYXRlZC1sb2FkLXByb2dyZXNzIiwKKyAgICAgICBGeHdpZGdldF93ZWJraXRfZXN0 aW1hdGVkX2xvYWRfcHJvZ3Jlc3MsIFN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9n cmVzcywKKyAgICAgICAxLCAxLCAwLCBkb2M6IC8qIEdldCB0aGUgZXN0aW1hdGVkIGxvYWQgcHJv Z3Jlc3Mgb2YgWFdJREdFVCwgYSBXZWJLaXQgd2lkZ2V0LgorUmV0dXJuIGEgdmFsdWUgcmFuZ2lu ZyBmcm9tIDAuMCB0byAxLjAsIGJhc2VkIG9uIGhvdyBjbG9zZSBYV0lER0VUCitpcyB0byBjb21w bGV0ZWx5IGxvYWRpbmcgaXRzIHBhZ2UuICAqLykKKyAgKExpc3BfT2JqZWN0IHh3aWRnZXQpCit7 CisgIHN0cnVjdCB4d2lkZ2V0ICp4dzsKKyNpZmRlZiBVU0VfR1RLCisgIFdlYktpdFdlYlZpZXcg KndlYnZpZXc7CisjZW5kaWYKKyAgZG91YmxlIHZhbHVlOworCisgIENIRUNLX0xJVkVfWFdJREdF VCAoeHdpZGdldCk7CisgIHh3ID0gWFhXSURHRVQgKHh3aWRnZXQpOworICBDSEVDS19XRUJLSVRf V0lER0VUICh4dyk7CisKKyAgYmxvY2tfaW5wdXQgKCk7CisjaWZkZWYgVVNFX0dUSworICB3ZWJ2 aWV3ID0gV0VCS0lUX1dFQl9WSUVXICh4dy0+d2lkZ2V0X29zcik7CisgIHZhbHVlID0gd2Via2l0 X3dlYl92aWV3X2dldF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyAod2Vidmlldyk7CisjZWxpZiBk ZWZpbmVkIE5TX0lNUExfQ09DT0EKKyAgdmFsdWUgPSBuc3h3aWRnZXRfd2Via2l0X2VzdGltYXRl ZF9sb2FkX3Byb2dyZXNzICh4dyk7CisjZW5kaWYKKworICB1bmJsb2NrX2lucHV0ICgpOworCisg IHJldHVybiBtYWtlX2Zsb2F0ICh2YWx1ZSk7Cit9CisKIERFRlVOICgieHdpZGdldC13ZWJraXQt Z290by11cmkiLAogICAgICAgIEZ4d2lkZ2V0X3dlYmtpdF9nb3RvX3VyaSwgU3h3aWRnZXRfd2Vi a2l0X2dvdG9fdXJpLAogICAgICAgIDIsIDIsIDAsCkBAIC0zODEwLDI4ICszODQwLDYgQEAgREVG VU4gKCJ4d2lkZ2V0LXdlYmtpdC1iYWNrLWZvcndhcmQtbGlzdCIsIEZ4d2lkZ2V0X3dlYmtpdF9i YWNrX2ZvcndhcmRfbGlzdCwKICAgcmV0dXJuIGxpc3QzIChiYWNrLCBoZXJlLCBmb3J3YXJkKTsK IH0KIAotREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC1lc3RpbWF0ZWQtbG9hZC1wcm9ncmVzcyIsCi0g ICAgICAgRnh3aWRnZXRfd2Via2l0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzLCBTeHdpZGdldF93 ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MsCi0gICAgICAgMSwgMSwgMCwgZG9jOiAvKiBH ZXQgdGhlIGVzdGltYXRlZCBsb2FkIHByb2dyZXNzIG9mIFhXSURHRVQsIGEgV2ViS2l0IHdpZGdl dC4KLVJldHVybiBhIHZhbHVlIHJhbmdpbmcgZnJvbSAwLjAgdG8gMS4wLCBiYXNlZCBvbiBob3cg Y2xvc2UgWFdJREdFVAotaXMgdG8gY29tcGxldGVseSBsb2FkaW5nIGl0cyBwYWdlLiAgKi8pCi0g IChMaXNwX09iamVjdCB4d2lkZ2V0KQotewotICBzdHJ1Y3QgeHdpZGdldCAqeHc7Ci0gIFdlYktp dFdlYlZpZXcgKndlYnZpZXc7Ci0gIGRvdWJsZSB2YWx1ZTsKLQotICBDSEVDS19MSVZFX1hXSURH RVQgKHh3aWRnZXQpOwotICB4dyA9IFhYV0lER0VUICh4d2lkZ2V0KTsKLSAgQ0hFQ0tfV0VCS0lU X1dJREdFVCAoeHcpOwotCi0gIGJsb2NrX2lucHV0ICgpOwotICB3ZWJ2aWV3ID0gV0VCS0lUX1dF Ql9WSUVXICh4dy0+d2lkZ2V0X29zcik7Ci0gIHZhbHVlID0gd2Via2l0X3dlYl92aWV3X2dldF9l c3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyAod2Vidmlldyk7Ci0gIHVuYmxvY2tfaW5wdXQgKCk7Ci0K LSAgcmV0dXJuIG1ha2VfZmxvYXQgKHZhbHVlKTsKLX0KICNlbmRpZgogCiBERUZVTiAoInh3aWRn ZXQtd2Via2l0LXNldC1jb29raWUtc3RvcmFnZS1maWxlIiwKQEAgLTM4NzQsMTkgKzM4ODIsMjMg QEAgREVGVU4gKCJ4d2lkZ2V0LXdlYmtpdC1zdG9wLWxvYWRpbmciLCBGeHdpZGdldF93ZWJraXRf c3RvcF9sb2FkaW5nLAogWFdJREdFVCBhcyBwYXJ0IG9mIGxvYWRpbmcgYSBwYWdlLiAgKi8pCiAg IChMaXNwX09iamVjdCB4d2lkZ2V0KQogewotI2lmZGVmIFVTRV9HVEsKICAgc3RydWN0IHh3aWRn ZXQgKnh3OworI2lmZGVmIFVTRV9HVEsKICAgV2ViS2l0V2ViVmlldyAqd2VidmlldzsKKyNlbmRp ZgogCiAgIENIRUNLX0xJVkVfWFdJREdFVCAoeHdpZGdldCk7CiAgIHh3ID0gWFhXSURHRVQgKHh3 aWRnZXQpOwogICBDSEVDS19XRUJLSVRfV0lER0VUICh4dyk7CiAKICAgYmxvY2tfaW5wdXQgKCk7 CisjaWZkZWYgVVNFX0dUSwogICB3ZWJ2aWV3ID0gV0VCS0lUX1dFQl9WSUVXICh4dy0+d2lkZ2V0 X29zcik7CiAgIHdlYmtpdF93ZWJfdmlld19zdG9wX2xvYWRpbmcgKHdlYnZpZXcpOwotICB1bmJs b2NrX2lucHV0ICgpOworI2VsaWYgZGVmaW5lZCBOU19JTVBMX0NPQ09BCisgIG5zeHdpZGdldF93 ZWJraXRfc3RvcF9sb2FkaW5nICh4dyk7CiAjZW5kaWYKKyAgdW5ibG9ja19pbnB1dCAoKTsKIAog ICByZXR1cm4gUW5pbDsKIH0KQEAgLTM5MzYsOCArMzk0OCw5IEBAIHN5bXNfb2ZfeHdpZGdldCAo dm9pZCkKICNpZmRlZiBVU0VfR1RLCiAgIGRlZnN1YnIgKCZTeHdpZGdldF93ZWJraXRfbG9hZF9o dG1sKTsKICAgZGVmc3ViciAoJlN4d2lkZ2V0X3dlYmtpdF9iYWNrX2ZvcndhcmRfbGlzdCk7Ci0g IGRlZnN1YnIgKCZTeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MpOwogI2Vu ZGlmCisKKyAgZGVmc3ViciAoJlN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVz cyk7CiAgIGRlZnN1YnIgKCZTa2lsbF94d2lkZ2V0KTsKIAogICBERUZTWU0gKFFDeHdpZGdldCwg Ijp4d2lkZ2V0Iik7Cg== --000000000000ece3ef05f333583b-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 19:44:37 2023 Received: (at 60703) by debbugs.gnu.org; 27 Jan 2023 00:44:37 +0000 Received: from localhost ([127.0.0.1]:36442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLCr7-000351-E6 for submit@debbugs.gnu.org; Thu, 26 Jan 2023 19:44:37 -0500 Received: from sonic317-33.consmr.mail.ne1.yahoo.com ([66.163.184.44]:45142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLCr6-00034l-5B for 60703@debbugs.gnu.org; Thu, 26 Jan 2023 19:44:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1674780269; bh=VsJdiSZcDiFKX56XhSPvyJSM5lqq7FEWt2EiYbpXipQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=AYqAb0exbR69b1goI47J/eb4APCC+sEDz7eU4usZza7r491y3dypFukMuRXUzCTJZzwQIWgKPLsLP6L+0NNF96zZydy1zPGmafO/ngPeuPUeiNFvr1u1Dw8Tsg1sS82WZOctnEm9ZCzUgHgQo99ol6ZgDDHQ3XIpb/SjbmHnMhG2CB3PHcPHJe/FLHmDnCklXklUNNVBqD3A5yBgyMlgJKs/32MSs59psL20iyTGrFJtyof5J8wstgBu/VBa1aVLX/JNGtZGSRz7y6jfcsjsLlX6C/eq8dpkfrDWKUxbcDAeqluZv0mEgT6Us46CEJJHMNiflqzD+jJew1CPzIl78A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1674780269; bh=PiMnbFD0OENph097rU89SAodArMyzFONKhmUDzbQlUG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FP8xN/OFkpMQMH1prZCyvKe2U25FkMm6UqMEWRI0AUs/pU2AddzpQQLzgytEnA21ibedpem4Q4VNjrBQBh3oCOcpIGizZNc+bSbL/kyJ7v5RSCNtjh5TgGSG9Rj2l0SptrR0nHqswTF9Lkrlziaz2lfZ+kSzkdfoTFCT9fx/8YjWLqTwu82B2uLt467e3wO2ItCmKNAf92lADOhCrmMiniS9OGniV9ZCupXAJ0kbHuad1ZqbCUJlc7Rg3WGWahY/j8zUH4APqSznT0aoma/KnQ2jrZyxSIGYBKb6wbfKvo5XFC65i8dkiZK5urPVug1DwI3OZKFSJ/mgTLh/vyl4jw== X-YMail-OSG: E0iOPx4VM1n1LpNI7E1iwK1cWVUiT6M5rp_rkuwCGtkAryK_U6LkpyiOW5m0_Rr shLrRr0L7e8.HOGt5VNpf70A2czopU2ate7k55dmohzpEoji5YD0fWA_7ozaUEdP0nHyTo9bcw6R RRRdzZnFi8G9CQkZKWoSSalGFZ4OpPrXSlMpHKEvCrFx5x8jj45fMgsICs6A1NpAGxYppRYVQSsx rqbgRA_Im4uBlQwrDGg7QzQWcTvNDoF.DxNbAmkaT.e3X9tc6eSxhlwyNKgZHl0rzPnGbadynjvG 6NZKMbsytvRZw2k4GHxAM3nda6VvCX4jWU1Z5zOXSSEq.8LQQD9h7RHwBpMB0fbpJNJ3etHoOrEB I8zmxtxRkiXPqWtf3M.4uyj.Su.RkQdHTp1KY7u7rmE4eb5R7czJ5Zb7JL4S_wvdp9TPUiEVTijB aOoYKidZzKe5BqHGGu0Di7HrFmXjW5XRdAOrjhraxaTwNzk7UT2hqXtkVjB721P4yeVbYLhR6Nxs 3JnqbqOXboLNZMgHNzZ3pWhuvzdJQNoJcEJiTtn9XMU9hYnqRRNQejATihjpxWxhGLMyEuqgchTF R8_HLin1Gfmoa0FiFDjjJqUoSfAZx3k9s6AbXMVduSe9hqDr9qshldSzaLHp5DSFAj2BHA8MsdCh .UGOLCv9uAzOrHQGPVeKFtVtoU3.0oSZhs2m.xeJOmJMh53Zz3jbeyA3N5iYHvuxt.4gO1OLaUKs 4gpyts_A3ScsR5qFvrfFombFx5SZQd4grCVFPUPpOxnoiytivMPwYUI9VZsHFWl2lSGxevl_3r_M yE.J1FhAMUPCPepIAJw5FSPcJF5JPXetAF_YfDjWEzyi7XJzrNV.kCUSe12r3TH6ODT_XHP7FU.k vCnVm5Mora5Avt8EV0NkzusD7v_.rsQU9xdiY0CkDDapuGsz9OCi_1g3sWhbUx6g4597LiKz8czX rdEOkBow4I4QbDq6iMQapWO3RNhCj4HBnvV06lrHxFMekRPHrJ3mviJCPZGOuPtmoTwByqfB.CHy w8I.SAh1l4DexZQ_UXzeNH2jI77l_LgZCwS1kunI2ish12jasG1nMfa.0_53XWXMdRq7yNahZbDS 5iXATBHWZOOmJjluNblI.0WPOqoZOHj3jEO9vwrPL0PQ.QJGiKV2gxTNj05KSBKPhTWZTQZehcuq iD_veLMZkQBpHFuIg3CMwwSbEM4ejp1u74l7Gmj0_QsBRzWgoCwi7VeRio9YT5GxUoab247bNc8C od10JOEvUAdIVmPOx3zVMgKCFJvQJNJG3aUCERQKUP7UgrZrU226L37JIpz8.e_4hH_PJjbHmKFd s3jTtImncBVCylWFnFVVN0.2f4xPpYrTsIPETIYblgwY7eZZBcu58av9cKhghkameaw8izp5_NkV NDyyQyqRwm.y0JRr4yCTHt39U9kgpPX7_nj0pr9NRH81p_d1CNnrnmqXVjyXqi7nE5YHJ3i2n1QG wc3oY9mPz0OwfjYgsO2QXhtLfPgLDwJoD3yjehBuRv1VtqrwRep2bsHvGVgcal7kN99uTmG_4ZEo 936KH8usKnp2o.TRyEP9n1JeIJCoNtqaBxRxA_1mi4MhFaHEUsNIdW0tL6u3MIJulapvhPFQomdv jX3SYt3kev2tqKzCeQ9VhdSZ13UlPHnZ553Hd32MB4Z.Gn3ca9e4R5fbiIsKdsPBmuEvWAyJxZZE LAaIQ7qAU2vNwZSII0h_b_qK1NWKcRwijc._qfE4aY454Nr6LgIhx8DvI6mTAdBtxXNL0M7Vk_5U ZL18nXEtrstftRPrURn9tB937WTebUEfSH97Jfkp7X5FDlXuWXh136IMzksozLSp1oVlXgBTBw7Z pjoZHCVaOakEB0bfah3jegMsInsrN4uoLUSXr27eohgQxda6XAh918Kt4hLKcWbcu6VP6._h.XAn 9qZO05UlRFsQuv3D5Ajx5LyWXZc7bHHf6_oa_SzpNXGX6CZ1sjjNuPwHJi.cf_baffChc2LUMy1N QPV5.tw0ZlwEeSjbfI9fFADUS8yc0vICZXc3kBPKcWhFaUJ6RoR7OSF8BReGMWhGdtza_W0aA6G. RhPK.3AFWEbVkW3uUqX07q90HYva_cxIng4iUZ3_fzSD6WZGCq06T2XrZrLAEdXbGSd0JNf9p4fX wXQ0FNooKj7D4pQoDk_iFwO9cYlKRxbCj0x9c25Z9gN_4pb.u0qHDgY4emqLEX2bZFPQi3k7r.A1 hAhRDLtkGca0asb.eWb0D.P93Ujt5i1a9R_BZHtLPWEe75_zGjeCrpsFH.2lR0Lpjiw-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 27 Jan 2023 00:44:29 +0000 Received: by hermes--production-sg3-9fc5746c8-nc5k6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c5d5719550fb0c8bee66179615bc2d12; Fri, 27 Jan 2023 00:44:25 +0000 (UTC) From: Po Lu To: Andrew De Angelis Subject: Re: bug#60703: Patches to xwidget code In-Reply-To: (Andrew De Angelis's message of "Thu, 26 Jan 2023 18:45:33 -0500") References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> Date: Fri, 27 Jan 2023 08:44:20 +0800 Message-ID: <87pmb024d7.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21123 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1686 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: Eli Zaretskii , 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrew De Angelis writes: > Thanks for the explanation. I sent out the signed copy yesterday. > I noticed a couple things about the previous patch, so I'm sending this one with a few updates: > > * `xwidget-webkit-current-url` in lisp/xwidget.el: check if the url variable is non-nil before calling `kill-new' on it. This avoids killing an empty > string, which would be pointless. We still alert the user that something's wrong by messaging "URL: nil" (although getting a nil url seems > very unlikely). > * in src/nsxwidget.m: formatting (keep lines below 80 char), and a brief comment describing the purpose of some of the newly added > functions > > I'm also attaching a draft of the ChangeLog. Let me know if you'd like me to make any changes there. > > I do have a question about the X11/GTK implementations for xwidget. I'm not sure I understand the relationship between the two: from the > preprocessor macros it seems at times they are separate and at times that one is an addendum to the other. > I'm asking because I want to make sure I'm using the preprocessor macros correctly: specifically, the function > `xwidget-webkit-estimated-load-progress` within xwidget.c used to be inside a "#ifdef USE_GTK" block. I moved it outside of the block, and > separated the GTK implementation from the NS_IMPL_COCOA implementation. Is this a problem for the X11 build? Should I instead put the > whole function within a block along these lines: "#if defined USE_GTK || defined NS_IMPL_COCOA" ? No, that's not a problem. The X11 implementation shares most of the widget manipulation code with the PGTK one, so both are simply under ``#ifdef USE_GTK''. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 16:01:03 2023 Received: (at 60703) by debbugs.gnu.org; 19 Feb 2023 21:01:03 +0000 Received: from localhost ([127.0.0.1]:49791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTqnu-0008AZ-NT for submit@debbugs.gnu.org; Sun, 19 Feb 2023 16:01:03 -0500 Received: from mail-vk1-f169.google.com ([209.85.221.169]:44715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTqns-00089r-Kh for 60703@debbugs.gnu.org; Sun, 19 Feb 2023 16:01:01 -0500 Received: by mail-vk1-f169.google.com with SMTP id e10so260191vkm.11 for <60703@debbugs.gnu.org>; Sun, 19 Feb 2023 13:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oBsMUmQN/N5w/gd3GCgdP6SEKNpYOlKzVQRbrrCf1tI=; b=X5wnLyU+F+bJWcUHZrQ/1fUkB/rRHLlgy3ndAdD6nj+Ap/SVMuNYc0FzFVCd+gADjJ XYUni+XXwFPsi9lRavGPcRlt5YPodTR2HND/Vtk+VPTWjJN+z8Gj1soPSGa+ODybPx23 U9tFLcUxp/D1fWqJ+1dl3wG/w+adr1eanPBa+MJKRVFXJ3REMLzfuFtaUVw96yMdloxZ xmvl6Vr9x+HucWRnxuU2hznVK+72EvJJZb+foXlnz7rGja+dBHLHhkbxthS3ELx1p/ZU rihNi2keJGQYiL+1quuQT18vCj8YDSmf5YBM28NbArRlKG5XjekKLMwMa13hclQMn2er bz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oBsMUmQN/N5w/gd3GCgdP6SEKNpYOlKzVQRbrrCf1tI=; b=ujPvvgOPcvAymuHyPKPtTqgsA6/5v90x4F4t3ReEU0JOGvafIoe/MMp+GgGF30sQcH Y6wmjnQLZ7geJkNauTZhrlWYdFEB3rWVn71BD9TSY21lq55SCWR7IUADjuwdgbBP3yMI APzvFEHA208dTJpZn1phCQohx0OVHmModYXVRv5bSyLBwJ3A5FFEj7ScZqIuid3cTOUY KlVijnXdytWCDFL0C06gI+t+k6bWPbVxKjA6YV4yWq7if+PbIBd2kcagx2+LI4zUr9sI 9oYAQA+FftDEllz4A1Mh8qpB/8lReDE5kNTs5Qd4ZnNKLMHcpPqvPhnp4fgeQtsU//7h HZYg== X-Gm-Message-State: AO0yUKXm2kxbvYtUQTOtQe4B0sTtCYEi/y7FpUKR647Q5GsRRPCpeRQv UvpZUx8a4vc3xXLBOR0eFdIj9C5OZtV4GgA4EVA= X-Google-Smtp-Source: AK7set+kUld3BkqpAApEhABGdXbimueNE7ifaW0CbPtXtX02vlOVcZS7lnf/gB1qqlTU+q6eFeBw7ZJPvyOF6UvM7s8= X-Received: by 2002:a1f:9bd3:0:b0:401:b916:7b08 with SMTP id d202-20020a1f9bd3000000b00401b9167b08mr130267vke.13.1676840455047; Sun, 19 Feb 2023 13:00:55 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> In-Reply-To: <87pmb024d7.fsf@yahoo.com> From: Andrew De Angelis Date: Sun, 19 Feb 2023 16:00:44 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Po Lu Content-Type: multipart/alternative; boundary="000000000000ab0d4705f513d7cd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: Eli Zaretskii , 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ab0d4705f513d7cd Content-Type: text/plain; charset="UTF-8" Hi all, just wanted to check on this: will you be able to include my changes in Emacs-29? Don't mean to put pressure or anything, just wondering if there's any additional things you need from me, and if there's a timeline on when the changes will be in. Thanks! On Thu, Jan 26, 2023 at 7:44 PM Po Lu wrote: > Andrew De Angelis writes: > > > Thanks for the explanation. I sent out the signed copy yesterday. > > I noticed a couple things about the previous patch, so I'm sending this > one with a few updates: > > > > * `xwidget-webkit-current-url` in lisp/xwidget.el: check if the url > variable is non-nil before calling `kill-new' on it. This avoids killing an > empty > > string, which would be pointless. We still alert the user that > something's wrong by messaging "URL: nil" (although getting a nil url seems > > very unlikely). > > * in src/nsxwidget.m: formatting (keep lines below 80 char), and a brief > comment describing the purpose of some of the newly added > > functions > > > > I'm also attaching a draft of the ChangeLog. Let me know if you'd like > me to make any changes there. > > > > I do have a question about the X11/GTK implementations for xwidget. I'm > not sure I understand the relationship between the two: from the > > preprocessor macros it seems at times they are separate and at times > that one is an addendum to the other. > > I'm asking because I want to make sure I'm using the preprocessor macros > correctly: specifically, the function > > `xwidget-webkit-estimated-load-progress` within xwidget.c used to be > inside a "#ifdef USE_GTK" block. I moved it outside of the block, and > > separated the GTK implementation from the NS_IMPL_COCOA implementation. > Is this a problem for the X11 build? Should I instead put the > > whole function within a block along these lines: "#if defined USE_GTK || > defined NS_IMPL_COCOA" ? > > No, that's not a problem. The X11 implementation shares most of the > widget manipulation code with the PGTK one, so both are simply under > ``#ifdef USE_GTK''. > --000000000000ab0d4705f513d7cd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all, just wanted to check on this: will you be abl= e to include my changes in Emacs-29?
Don't mean to put pressu= re or anything, just wondering if there's any additional things you nee= d from me, and if there's a timeline on when the changes will be in.

Thanks!

On Thu, Jan 26, 2023 at 7:44 PM Po = Lu <luangruo@yahoo.com> wro= te:
Andrew De An= gelis <bobo= deangelis@gmail.com> writes:

> Thanks for the explanation. I sent out the signed copy yesterday.
> I noticed a couple things about the previous patch, so I'm sending= this one with a few updates:
>
> * `xwidget-webkit-current-url` in lisp/xwidget.el: check if the url va= riable is non-nil before calling `kill-new' on it. This avoids killing = an empty
>=C2=A0 string, which would be pointless. We still alert the user that s= omething's wrong by messaging "URL: nil" (although getting a = nil url seems
>=C2=A0 very unlikely).
> * in src/nsxwidget.m: formatting (keep lines below 80 char), and a bri= ef comment describing the purpose of some of the newly added
>=C2=A0 functions
>
> I'm also attaching a draft of the ChangeLog. Let me know if you= 9;d like me to make any changes there.
>
> I do have a question about the X11/GTK implementations for xwidget. I&= #39;m not sure I understand the relationship between the two: from the
> preprocessor macros it seems at times they are separate and at times t= hat one is an addendum to the other.
> I'm asking because I want to make sure I'm using the preproces= sor macros correctly: specifically, the function
> `xwidget-webkit-estimated-load-progress` within xwidget.c used to be i= nside a "#ifdef USE_GTK" block. I moved it outside of the block, = and
> separated the GTK implementation from the NS_IMPL_COCOA implementation= . Is this a problem for the X11 build? Should I instead put the
> whole function within a block along these lines: "#if defined USE= _GTK || defined NS_IMPL_COCOA" ?

No, that's not a problem.=C2=A0 The X11 implementation shares most of t= he
widget manipulation code with the PGTK one, so both are simply under
``#ifdef USE_GTK''.
--000000000000ab0d4705f513d7cd-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 21:44:04 2023 Received: (at 60703) by debbugs.gnu.org; 20 Feb 2023 02:44:04 +0000 Received: from localhost ([127.0.0.1]:50081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTw9s-0007nI-1k for submit@debbugs.gnu.org; Sun, 19 Feb 2023 21:44:04 -0500 Received: from sonic311-52.consmr.mail.ne1.yahoo.com ([66.163.188.233]:38741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTw9q-0007mg-AX for 60703@debbugs.gnu.org; Sun, 19 Feb 2023 21:44:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676861034; bh=qrKrr7CZ4M4NClZ3lVQ741qzT2rM3E2413WV+/tdIYk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=UqZdNTsfP0jswmwLSmDtfgzVLveGIGoAzWX1OzIM52MzIupSfPkprl2iGxDtsmfcFlT9+XiVipBRz5KSFy4Yxch+ta+72vz7DJ+7Hyws8iVRFRxbZgpdJqX5+cqViBNJfuGpUwOSGcVCt8Wd5c8ydv4SdZ9U7ntQImICrV6MW2YMZWH3bTzn+Clx89BbiD9Qa3qJ5opSLjbtaI9BmcBdR6w7JIgJQtq+XDSV01YQ+ca1qPnpSJ5wmAOk/x4K+gj74K5sRPk2tFqe8jYCRgMxFovQabU4yPcUsU8a71bRUDLGF1lVXNy4oOGmTB3yoXNhy9466CSzJFzYqx21XsTzEw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676861034; bh=QRKFvtXZkKcrxlVj9IxLW7LXc3SYNuCZkp+4XvY2udX=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ShjlWFkysU1O53vPxlLXq/I7G1FVfBaXqEZu24a8X2fPUGhR2sRomG5ioyqhAO9p6wULIHaNW8XnOLVvUTCd6sWE9CvGL5VV2o1BcP166dt6iMuGE0QQ/vaawQz+f4pbr60u5dgybjn9RWrbc2fTno0+RzMQ6022CG/52bGGAQx7WD8sxiOU9X2CF6u3624iKmzWtcYbx99USRuEgzgXDgVMLTajH2wxMcWaczURlLN7vTjMq+XFCfbMlyfgRe0HRAMZ6+Ll0KEplEhggW7y2e/QL+m7GxXfvYt7ez7DFP1Uh7G3tsh7gCeeFEOqQNuRyURDLHfYSGwuYe5GdCJIFg== X-YMail-OSG: _8jwhl0VM1nGuFwRjBCUClbYVm_O1KDGqZnqaO6MjTTYAIYjTpF51.ZhwedQX72 6TA97niHVMWjiUzTwFHOsLBZejuK_fsJucQYo5YoHEDeDrabX3PXKtBDpzu50jXeqX_lE1U28zRd IVr7V73Z_7SemfdRxsgg5sScM_T1djLAl8t_0Jlu179wJm1lUlYFiYJ.IqTZMRB0_VLMXG_Y6R.R foCwmnY8yfKnAzysuvOBMfKI.7c0tgfFUTOGxOtaJBCKNQsxifpatKJ_4gYtSgp_838kSsadDbzn 6xn8vIKp3xsaG3_RwlH48leOiaDh_Nx_AaFMXj.37iv9vriQImfRvOJ3_3BSgT4qm39djFnYqKCO QguKDHTLEVDklLgAU1hIkttyelmXJGBg8MuXiFZzE8dCG8mmCRt15ld_NQyjSZX7mwnbZpTFSmqx Us6uJ7dGvbeO..eS7BRpb6_GfXJ4xsLc0kXGhldQ2.NggzzEGyGTH.oc4AShISdiwMBlrva2Bkyb N9OLO8lbYgeHEvCrTczRYy1dCdTb.uYromUl6Jz9wLB1su.37jacMTmKcU_GVdZ1l9NnMoMHbeJR ds6kdWHJIdBenVcgq95HRAKHnHFP2Pc3Kt2cssRvmRApaZOBMHnjUscRH8XfC7qhaSGhEL4t1rbX HYGNri4fuD.U7t9GXeJIWusCpFe0qdc8XAfsvYVwP1EIW29dlO72oUywMALy2UHTTA3XFP9JfgsW rW2OeQ5qmZWPaRfWiN0t6qcGbXOpL51ZF45oOh8NhTDbcrxkhoQmuoDrkRGUCQtO9UGINz5uRLLh i7DR.r9xFCBmA_Gd1Kb.3_SSNnNjVHcnCXn6Q85_ci0uDozbxE3yCS_DxaedoF2nEDoQpIg3cZay s2uT3gKTTqhXW_6fhKLN_SPz9QrXNtR7oBreOkLjCQxwHSPlm2tqxRIomtsp7XkyEuEgYb2zbxVB FY0a62fJYc6h3VmE_m9IwDiWC82fV10aBgx_Q1egVN.lQ_B4I4hozEwsdrHgUOVuKzLGptdfyhVQ vBDyEE2L5JHarQF.1asg0Ko0e_E3e6Tq02V2a44GFpWuYwQYepKCN3Zbw65GW9Of.h54j3OC4y2n 6mbq8aFUQjG235HV.ssVbJ7yKUytXiy6QRAyPyUiQ3ZznxYPtfupsdSv9vLsZK.67LGYMsBJ2RO0 jX.w83WyCX0QV3Nbh_fb_hbt5ZcAUC1Lx6TV3Tj84DbiRn_ESJU3m3OFa2MkJxkUvG_pIWFq2SMX TxydXa2NDjbZ2xFXXzvOq43v8Wl4M0csS6J73kdVzJFh9FOHsiCC9LGbBmImoEL2Xh2EKnijttBH NzbdYME5Xo_mTB9mmRrMujE1TQvttzxhmslNLrPMQjBp5BmIVHvhkWS_OKDQpVSkPFqWWtMGJK8o jWT78zPh1WMAwBYjDkb7LLOVfGXxTWDkNmzBPm9kNl4az3lk8o0wroBKVVMNkI0pqbUqaoixQUeM f8hZGgwwiiQ7ynMHU9q7lbHo_os5Me_TVla.Q0MTj8Nl.6Y9jJHA57FCty2TuwP5D.TDIbPJiz1D ou6NuMAsFAs1y1GVFby3yDDqQqpjvUB0MlXOwVIK1ghwa.OjUymBMVw.KGXrlOCqorGrQF6.MTVL EM2JWFhVstF6oYAqVKMzhh4dwZOoxLPYcQ1G8Xd9592g5Q_BQ6nGzZ2NjiRWEsFbenGfeKhHEqlN SBJlPs691uOSrdT2GpIkC7w7gOrvkMBfaoS4SDjPV.WYfJ9TT8xAKmsk1rYm6ymKyAulVbv.m5YD sQpcIi.OrDwtVPH2NXnoFvDXjzIgR4xZzuW0y9GjQZtyczffTA61Hefgdys6ylYarMp9.ouN.IuF Vrhll5dY7Ey4MZ.8tCQKJTpp7jKJwOX2SCzbtSApiEOr0qgWTRVFrQFAZSjhB7vpXJ_lESPGpFqk d4olyVJjF4uh9o4BpgBnIL8kEtu4JktV1sQ0IXtw.3qSIooTyP2kFmAO79Bxvdeu5s_1OGQkUgne vWSDMKhj2bZaKkHE_Fk0.kNTLLNJgviHzUCA5oogJRbIA8fNwTpw9OGq78s7xIvs7JSUGhxUB0Ib RS7K0Gy9RnlAWUUR3bMew2qgfgMXVyeewT7E1qffQXLOjhC4atnz3YNJkENdts3OlhlwY4MjlAQ2 H0KD5qV34LsrJPlTD0PX_aMZsajAw247nuWf1G7zdCZGrF_KnZ9uTx0iOK_5L16mZAq7tv4l694Q 8xp027pEzhfHYigFCGnghT2f2EcLvSVYw1wmNxaD37CGTyxSYRcHYvfHiRSMOqyL0G6a0JqB_EQK Zc5Nw4O29vQs- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Mon, 20 Feb 2023 02:43:54 +0000 Received: by hermes--production-sg3-9fc5746c8-z7rbd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1b1afe2b603c0215dcc822af864556a3; Mon, 20 Feb 2023 02:41:52 +0000 (UTC) From: Po Lu To: Andrew De Angelis Subject: Re: bug#60703: Patches to xwidget code In-Reply-To: (Andrew De Angelis's message of "Sun, 19 Feb 2023 16:00:44 -0500") References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> Date: Mon, 20 Feb 2023 10:41:41 +0800 Message-ID: <87o7ppf47u.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 383 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: Eli Zaretskii , 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrew De Angelis writes: > Hi all, just wanted to check on this: will you be able to include my changes in Emacs-29? > Don't mean to put pressure or anything, just wondering if there's any additional things you need from me, and if there's a timeline on when > the changes will be in. I think this is up to Eli, but as I said earlier, your changes LGTM. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 06:47:39 2023 Received: (at 60703) by debbugs.gnu.org; 20 Feb 2023 11:47:39 +0000 Received: from localhost ([127.0.0.1]:50712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU4du-000609-R9 for submit@debbugs.gnu.org; Mon, 20 Feb 2023 06:47:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU4dt-0005zU-4I for 60703@debbugs.gnu.org; Mon, 20 Feb 2023 06:47:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU4dn-0004QI-HV; Mon, 20 Feb 2023 06:47:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ndz1eNQ0WrEhi6YjNCOc819TjddEJFpQ55PFWQp/fzo=; b=Y4496nGynBvc yUPQG/kdknhHQg0NQyWq2rPvlo+UQcEHEiTmEhJTVUh1rx4u0jlrNwCnSPoxbuRq5MZCJyVmmrOxn PxPeP0fp5e3iLvnefG4F8itkqSPAMw+6ti3DQPFZXGAdsGbOltK+6jyL138ORJNudTTbf8PYzsvBy i3eHYkuDHGVJShO/ThWErV17kpee6Ew7moZLOpQUT59EzAGgJGxZ8gMt8rZqdcMMxhN+Op6qrJ+Tt FweniIymzOW2JqTgPmGLTqjPhuafL9k3ekH25CxtxQDhxGdnvu+MFbonCUgruPPMsHnnUG82QywjS 9/c5FRB8MK+r8rajUCtJLA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU4dm-0001JQ-Vx; Mon, 20 Feb 2023 06:47:31 -0500 Date: Mon, 20 Feb 2023 13:47:37 +0200 Message-Id: <83bklowobq.fsf@gnu.org> From: Eli Zaretskii To: Andrew De Angelis In-Reply-To: (message from Andrew De Angelis on Sun, 19 Feb 2023 16:00:44 -0500) Subject: Re: bug#60703: Patches to xwidget code References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew De Angelis > Date: Sun, 19 Feb 2023 16:00:44 -0500 > Cc: Eli Zaretskii , 60703@debbugs.gnu.org > > Hi all, just wanted to check on this: will you be able to include my changes in Emacs-29? > Don't mean to put pressure or anything, just wondering if there's any additional things you need from me, > and if there's a timeline on when the changes will be in. Please post the patches rebased on the current emacs-29 branch. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 00:24:26 2023 Received: (at 60703) by debbugs.gnu.org; 21 Feb 2023 05:24:26 +0000 Received: from localhost ([127.0.0.1]:54270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUL8c-0002X1-46 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 00:24:26 -0500 Received: from mail-ua1-f52.google.com ([209.85.222.52]:36557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUL8Z-0002Wm-JG for 60703@debbugs.gnu.org; Tue, 21 Feb 2023 00:24:24 -0500 Received: by mail-ua1-f52.google.com with SMTP id f20so174026uam.3 for <60703@debbugs.gnu.org>; Mon, 20 Feb 2023 21:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VgX4aSs/4uCf0moF3spExHIU6AfuFMfhSNQwunjOdIw=; b=HDSAY1RzftkQ1EJ/6okjytC+EFsAzDFNePpfQ+UWfaWQtVQ4tqmdiWufJj2O0GrgEO qJLCEpU90Xzd0caM1aAb3ReqY+LDd3a0mssaaTgkGdDDUFB7w9UVvX8NLE7Ujp6mObY/ nVmOVOateTGzd+pftllAZseIKOcQoqJmH5iyJui6Et39pdRiWfMFTL4soROM0S9uNG7V Uggz6Jm35eP6Lob0cGh66iWQFLd8jOi/Bh1eQBkKTNj3PZzLqSUkDa1B+Y7/PZGWBX6b EbCIWwQLrgHgBSL9cFkJL/5R/iJB4LFCF/faVG5Sb4IWyPoJVvd7jCGqmNpTxnyX6Q6C aSUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VgX4aSs/4uCf0moF3spExHIU6AfuFMfhSNQwunjOdIw=; b=x0HimZay6QiSgzjeDCqdE1AqWuYoWPqAmRqNEXx/FBGa8kNogLMCQJtyYLBlR/ht5Z lBS7PBObhfM7fW/J2TNntsHOOnWGApMVJVGVYZxuOCistghOM1DielDR90qQuD4OsCf1 sPC9jY3cPDhhdSn92kj8J1XY5tRz2fWURtxkRzOYJ7wqBH2EKNeI6mpIQ3ZiXy1xK+Wi nwB/pBDTEzK9SrqFb4yXx1i8N8C/Cqd+Nrr0vmAbpemJR4rmUZcCbAiQJS4GSJWQ07Hs 7lABL2JdrlYguUi1ldRLSF31FR5May+phAyMFRgK5J/cFlk/YyQ1ovmvKG/gTDkp1+gs vtXw== X-Gm-Message-State: AO0yUKWYNmTr9bKXhRjKeKw4FIHVkBdG9ceeZlSmOrCBMSt9gKf/cCrv Z7EVPad08v8RNkU09BxkwO3Qvtr3PQQrOg8gqHw= X-Google-Smtp-Source: AK7set+A8rg/yToj4wJGvxBaDYaw/mRmGmV/FMvDCP5R8PUK092l7vPKuoYCgUHDYqAgdgkTu1deGhhrpAnfRUDiQRo= X-Received: by 2002:ab0:1014:0:b0:68b:90f4:1d8c with SMTP id f20-20020ab01014000000b0068b90f41d8cmr695519uab.1.1676957057882; Mon, 20 Feb 2023 21:24:17 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> In-Reply-To: <83bklowobq.fsf@gnu.org> From: Andrew De Angelis Date: Tue, 21 Feb 2023 00:24:06 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000bd747905f52efd81" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bd747905f52efd81 Content-Type: multipart/alternative; boundary="000000000000bd747605f52efd7f" --000000000000bd747605f52efd7f Content-Type: text/plain; charset="UTF-8" Done. (git diff forked/emacs-29 > emacs-29-xwidget-patches.patch) Let me know if there's anything I should do. Thanks! Best, Andrew On Mon, Feb 20, 2023 at 6:47 AM Eli Zaretskii wrote: > > From: Andrew De Angelis > > Date: Sun, 19 Feb 2023 16:00:44 -0500 > > Cc: Eli Zaretskii , 60703@debbugs.gnu.org > > > > Hi all, just wanted to check on this: will you be able to include my > changes in Emacs-29? > > Don't mean to put pressure or anything, just wondering if there's any > additional things you need from me, > > and if there's a timeline on when the changes will be in. > > Please post the patches rebased on the current emacs-29 branch. > --000000000000bd747605f52efd7f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Done. (git diff forked/emacs-29 > emacs-29-xwidget= -patches.patch)

Let me know if there's anythin= g I should do. Thanks!

Best,
Andrew
<= /div>

On Mon, Feb 20, 2023 at 6:47 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Andrew De Angelis <bobodeangelis@gmail.com><= br> > Date: Sun, 19 Feb 2023 16:00:44 -0500
> Cc: Eli Zaretskii <eliz@gnu.org>, 60703@debbugs.gnu.org
>
> Hi all, just wanted to check on this: will you be able to include my c= hanges in Emacs-29?
> Don't mean to put pressure or anything, just wondering if there= 9;s any additional things you need from me,
> and if there's a timeline on when the changes will be in.

Please post the patches rebased on the current emacs-29 branch.
--000000000000bd747605f52efd7f-- --000000000000bd747905f52efd81 Content-Type: application/octet-stream; name="emacs-29-xwidget-patches.patch" Content-Disposition: attachment; filename="emacs-29-xwidget-patches.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ledswaks0 ZGlmZiAtLWdpdCBhL2xpc3AveHdpZGdldC5lbCBiL2xpc3AveHdpZGdldC5lbAppbmRleCBhYmJk YTI5MDgxZS4uN2RhY2E4MWY5ZjcgMTAwNjQ0Ci0tLSBhL2xpc3AveHdpZGdldC5lbAorKysgYi9s aXNwL3h3aWRnZXQuZWwKQEAgLTkyNSw3ICs5MjUsOCBAQCB4d2lkZ2V0LXdlYmtpdC1jdXJyZW50 LXVybAogICAiRGlzcGxheSB0aGUgY3VycmVudCB4d2lkZ2V0IHdlYmtpdCBVUkwgYW5kIHBsYWNl IGl0IG9uIHRoZSBga2lsbC1yaW5nJy4iCiAgIChpbnRlcmFjdGl2ZSBuaWwgeHdpZGdldC13ZWJr aXQtbW9kZSkKICAgKGxldCAoKHVybCAoeHdpZGdldC13ZWJraXQtdXJpICh4d2lkZ2V0LXdlYmtp dC1jdXJyZW50LXNlc3Npb24pKSkpCi0gICAgKG1lc3NhZ2UgIlVSTDogJXMiIChraWxsLW5ldyAo b3IgdXJsICIiKSkpKSkKKyAgICAod2hlbiB1cmwgKGtpbGwtbmV3IHVybCkpCisgICAgKG1lc3Nh Z2UgIlVSTDogJXMiIHVybCkpKQogCiAoZGVmdW4geHdpZGdldC13ZWJraXQtYnJvd3NlLWhpc3Rv cnkgKCkKICAgIkRpc3BsYXkgYSBidWZmZXIgY29udGFpbmluZyB0aGUgaGlzdG9yeSBvZiBwYWdl IGxvYWRzLiIKZGlmZiAtLWdpdCBhL3NyYy9uc3h3aWRnZXQuaCBiL3NyYy9uc3h3aWRnZXQuaApp bmRleCA4ZDU1ZmFjNTMyNi4uMmI1NTk2ZjkwNWUgMTAwNjQ0Ci0tLSBhL3NyYy9uc3h3aWRnZXQu aAorKysgYi9zcmMvbnN4d2lkZ2V0LmgKQEAgLTM2LDYgKzM2LDggQEAgI2RlZmluZSBOU1hXSURH RVRfSF9JTkNMVURFRAogTGlzcF9PYmplY3QgbnN4d2lkZ2V0X3dlYmtpdF90aXRsZSAoc3RydWN0 IHh3aWRnZXQgKnh3KTsKIHZvaWQgbnN4d2lkZ2V0X3dlYmtpdF9nb3RvX3VyaSAoc3RydWN0IHh3 aWRnZXQgKnh3LCBjb25zdCBjaGFyICp1cmkpOwogdm9pZCBuc3h3aWRnZXRfd2Via2l0X2dvdG9f aGlzdG9yeSAoc3RydWN0IHh3aWRnZXQgKnh3LCBpbnQgcmVsX3Bvcyk7Citkb3VibGUgbnN4d2lk Z2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcyhzdHJ1Y3QgeHdpZGdldCAqeHcpOwor dm9pZCBuc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZyAoc3RydWN0IHh3aWRnZXQgKnh3KTsK IHZvaWQgbnN4d2lkZ2V0X3dlYmtpdF96b29tIChzdHJ1Y3QgeHdpZGdldCAqeHcsIGRvdWJsZSB6 b29tX2NoYW5nZSk7CiB2b2lkIG5zeHdpZGdldF93ZWJraXRfZXhlY3V0ZV9zY3JpcHQgKHN0cnVj dCB4d2lkZ2V0ICp4dywgY29uc3QgY2hhciAqc2NyaXB0LAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBMaXNwX09iamVjdCBmdW4pOwpkaWZmIC0tZ2l0IGEvc3JjL25zeHdp ZGdldC5tIGIvc3JjL25zeHdpZGdldC5tCmluZGV4IGUxZmJkNzQ5YjYyLi4wZTAwNTg5YmI3ZiAx MDA2NDQKLS0tIGEvc3JjL25zeHdpZGdldC5tCisrKyBiL3NyYy9uc3h3aWRnZXQubQpAQCAtNTcs MTIgKzU3LDEzIEBAIEBpbnRlcmZhY2UgWHdXZWJWaWV3IDogV0tXZWJWaWV3CiBAZW5kCiBAaW1w bGVtZW50YXRpb24gWHdXZWJWaWV3IDogV0tXZWJWaWV3CiAKLS0gKGlkKWluaXRXaXRoRnJhbWU6 KENHUmVjdClmcmFtZQorLSAoaWQpIGluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZQogICAgICAg Y29uZmlndXJhdGlvbjooV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24KICAg ICAgICAgICAgIHh3aWRnZXQ6KHN0cnVjdCB4d2lkZ2V0ICopeHcKIHsKICAgLyogU2NyaXB0IGNv bnRyb2xsZXIgdG8gYWRkIHNjcmlwdCBtZXNzYWdlIGhhbmRsZXIgYW5kIHVzZXIgc2NyaXB0LiAg Ki8KLSAgV0tVc2VyQ29udGVudENvbnRyb2xsZXIgKnNjcmlwdG9yID0gW1tXS1VzZXJDb250ZW50 Q29udHJvbGxlciBhbGxvY10gaW5pdF07CisgIFdLVXNlckNvbnRlbnRDb250cm9sbGVyICpzY3Jp cHRvciA9IFtbW1dLVXNlckNvbnRlbnRDb250cm9sbGVyIGFsbG9jXSBpbml0XQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGF1dG9yZWxlYXNlXTsKICAgY29uZmlndXJh dGlvbi51c2VyQ29udGVudENvbnRyb2xsZXIgPSBzY3JpcHRvcjsKIAogICAvKiBFbmFibGUgaW5z cGVjdCBlbGVtZW50IGNvbnRleHQgbWVudSBpdGVtIGZvciBkZWJ1Z2dpbmcuICAqLwpAQCAtODEs NyArODIsOCBAQCAtIChpZClpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUKICAgaWYgKHNlbGYp CiAgICAgewogICAgICAgc2VsZi54dyA9IHh3OwotICAgICAgc2VsZi51cmxTY3JpcHRCbG9ja2Vk ID0gW1tOU011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XTsKKyAgICAgIHNlbGYudXJsU2Ny aXB0QmxvY2tlZCA9IFtbW05TTXV0YWJsZURpY3Rpb25hcnkgYWxsb2NdIGluaXRdCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGF1dG9yZWxlYXNlXTsKICAgICAgIHNlbGYubmF2aWdh dGlvbkRlbGVnYXRlID0gc2VsZjsKICAgICAgIHNlbGYuVUlEZWxlZ2F0ZSA9IHNlbGY7CiAgICAg ICBzZWxmLmN1c3RvbVVzZXJBZ2VudCA9CkBAIC04OSwyMyArOTEsNDggQEAgLSAoaWQpaW5pdFdp dGhGcmFtZTooQ0dSZWN0KWZyYW1lCiAgICAgICAgIEAiIEFwcGxlV2ViS2l0LzYwMy4zLjggKEtI VE1MLCBsaWtlIEdlY2tvKSIKICAgICAgICAgQCIgVmVyc2lvbi8xMS4wLjEgU2FmYXJpLzYwMy4z LjgiOwogICAgICAgW3NjcmlwdG9yIGFkZFNjcmlwdE1lc3NhZ2VIYW5kbGVyOnNlbGYgbmFtZTpA ImtleURvd24iXTsKLSAgICAgIFtzY3JpcHRvciBhZGRVc2VyU2NyaXB0OltbV0tVc2VyU2NyaXB0 IGFsbG9jXQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbml0V2l0aFNvdXJjZTp4 d1NjcmlwdAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5qZWN0aW9uVGltZToK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXS1VzZXJTY3JpcHRJbmplY3Rpb25U aW1lQXREb2N1bWVudFN0YXJ0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvck1h aW5GcmFtZU9ubHk6Tk9dXTsKKyAgICAgIFdLVXNlclNjcmlwdCAqdXNlclNjcmlwdCA9IFtbW1dL VXNlclNjcmlwdCBhbGxvY10KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlu aXRXaXRoU291cmNlOnh3U2NyaXB0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaW5qZWN0aW9uVGltZToKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg V0tVc2VyU2NyaXB0SW5qZWN0aW9uVGltZUF0RG9jdW1lbnRTdGFydAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZm9yTWFpbkZyYW1lT25seTpOT10gYXV0b3JlbGVhc2VdOwor ICAgICAgW3NjcmlwdG9yIGFkZFVzZXJTY3JpcHQ6dXNlclNjcmlwdF07CiAgICAgfQogICByZXR1 cm4gc2VsZjsKIH0KIAotLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CisvKiBU aGVzZSA0IGZ1bmN0aW9ucyBlbXVsYXRlIHRoZSBiZWhhdmlvciBvZiB3ZWJraXRfdmlld19sb2Fk X2NoYW5nZWRfY2IKKyAgIGluIHRoZSBHVEsgaW1wbGVtZW50YXRpb24qLworLSAodm9pZCkgd2Vi VmlldzooV0tXZWJWaWV3ICopd2ViVmlldwogZGlkRmluaXNoTmF2aWdhdGlvbjooV0tOYXZpZ2F0 aW9uICopbmF2aWdhdGlvbgogewogICBpZiAoRVEgKEZidWZmZXJfbGl2ZV9wIChzZWxmLnh3LT5i dWZmZXIpLCBRdCkpCi0gICAgc3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYueHcsICJs b2FkLWNoYW5nZWQiLCAiIik7CisgICAgc3RvcmVfeHdpZGdldF9ldmVudF9zdHJpbmcgKHNlbGYu eHcsICJsb2FkLWNoYW5nZWQiLCAibG9hZC1maW5pc2hlZCIpOwogfQogCi0tICh2b2lkKXdlYlZp ZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdl YlZpZXcKK2RpZFN0YXJ0UHJvdmlzaW9uYWxOYXZpZ2F0aW9uOihXS05hdmlnYXRpb24gKiluYXZp Z2F0aW9uCit7CisgIGlmIChFUSAoRmJ1ZmZlcl9saXZlX3AgKHNlbGYueHctPmJ1ZmZlciksIFF0 KSkKKyAgICBzdG9yZV94d2lkZ2V0X2V2ZW50X3N0cmluZyAoc2VsZi54dywgImxvYWQtY2hhbmdl ZCIsICJsb2FkLXN0YXJ0ZWQiKTsKK30KKworLSAodm9pZCkgd2ViVmlldzooV0tXZWJWaWV3ICop d2ViVmlldworZGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9yUHJvdmlzaW9uYWxOYXZpZ2F0aW9u OihXS05hdmlnYXRpb24gKiluYXZpZ2F0aW9uCit7CisgIGlmIChFUSAoRmJ1ZmZlcl9saXZlX3Ag KHNlbGYueHctPmJ1ZmZlciksIFF0KSkKKyAgICBzdG9yZV94d2lkZ2V0X2V2ZW50X3N0cmluZyAo c2VsZi54dywgImxvYWQtY2hhbmdlZCIsICJsb2FkLXJlZGlyZWN0ZWQiKTsKK30KKworLyogU3Rh cnQgbG9hZGluZyBXS1dlYlZpZXcgKi8KKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdl YlZpZXcKK2RpZENvbW1pdE5hdmlnYXRpb246KFdLTmF2aWdhdGlvbiAqKW5hdmlnYXRpb24KK3sK KyAgaWYgKEVRIChGYnVmZmVyX2xpdmVfcCAoc2VsZi54dy0+YnVmZmVyKSwgUXQpKQorICAgIHN0 b3JlX3h3aWRnZXRfZXZlbnRfc3RyaW5nIChzZWxmLnh3LCAibG9hZC1jaGFuZ2VkIiwgImxvYWQt Y29tbWl0dGVkIik7Cit9CisKKy0gKHZvaWQpIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcK IGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246KFdLTmF2aWdhdGlvbkFjdGlvbiAqKW5h dmlnYXRpb25BY3Rpb24KIGRlY2lzaW9uSGFuZGxlcjoodm9pZCAoXikoV0tOYXZpZ2F0aW9uQWN0 aW9uUG9saWN5KSlkZWNpc2lvbkhhbmRsZXIKIHsKQEAgLTExNCwxMyArMTQxLDEzIEBAIC0gKHZv aWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldwogICAgIGRlY2lzaW9uSGFuZGxlciAoV0tO YXZpZ2F0aW9uQWN0aW9uUG9saWN5QWxsb3cpOwogICAgIGJyZWFrOwogICBkZWZhdWx0OgotICAg IC8vIGRlY2lzaW9uSGFuZGxlciAoV0tOYXZpZ2F0aW9uQWN0aW9uUG9saWN5Q2FuY2VsKTsKKyAg ICAvKiBkZWNpc2lvbkhhbmRsZXIgKFdLTmF2aWdhdGlvbkFjdGlvblBvbGljeUNhbmNlbCk7ICov CiAgICAgZGVjaXNpb25IYW5kbGVyIChXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3lBbGxvdyk7CiAg ICAgYnJlYWs7CiAgIH0KIH0KIAotLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3 CistICh2b2lkKSB3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CiBkZWNpZGVQb2xpY3lGb3JO YXZpZ2F0aW9uUmVzcG9uc2U6KFdLTmF2aWdhdGlvblJlc3BvbnNlICopbmF2aWdhdGlvblJlc3Bv bnNlCiBkZWNpc2lvbkhhbmRsZXI6KHZvaWQgKF4pKFdLTmF2aWdhdGlvblJlc3BvbnNlUG9saWN5 KSlkZWNpc2lvbkhhbmRsZXIKIHsKQEAgLTE2Niw3ICsxOTMsNyBAQCAtICh2b2lkKXdlYlZpZXc6 KFdLV2ViVmlldyAqKXdlYlZpZXcKIAogLyogTm8gYWRkaXRpb25hbCBuZXcgd2VidmlldyBvciBl bWFjcyB3aW5kb3cgd2lsbCBiZSBjcmVhdGVkCiAgICBmb3IgPGEgLi4uIHRhcmdldD0iX2JsYW5r Ij4uICAqLwotLSAoV0tXZWJWaWV3ICopd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldworLSAo V0tXZWJWaWV3ICopIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKIGNyZWF0ZVdlYlZpZXdX aXRoQ29uZmlndXJhdGlvbjooV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24K ICAgIGZvck5hdmlnYXRpb25BY3Rpb246KFdLTmF2aWdhdGlvbkFjdGlvbiAqKW5hdmlnYXRpb25B Y3Rpb24KICAgICAgICAgd2luZG93RmVhdHVyZXM6KFdLV2luZG93RmVhdHVyZXMgKil3aW5kb3dG ZWF0dXJlcwpAQCAtMTc3LDcgKzIwNCw3IEBAIC0gKFdLV2ViVmlldyAqKXdlYlZpZXc6KFdLV2Vi VmlldyAqKXdlYlZpZXcKIH0KIAogLyogT3BlbiBwYW5lbCBmb3IgZmlsZSB1cGxvYWQuICAqLwot LSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3CistICh2b2lkKSB3ZWJWaWV3OihX S1dlYlZpZXcgKil3ZWJWaWV3CiBydW5PcGVuUGFuZWxXaXRoUGFyYW1ldGVyczooV0tPcGVuUGFu ZWxQYXJhbWV0ZXJzICopcGFyYW1ldGVycwogaW5pdGlhdGVkQnlGcmFtZTooV0tGcmFtZUluZm8g KilmcmFtZQogY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKE5TQXJyYXk8TlNVUkwgKj4gKlVS THMpKWNvbXBsZXRpb25IYW5kbGVyCkBAIC0xOTcsMTMgKzIyNCwxMyBAQCAtICh2b2lkKXdlYlZp ZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKICAgIC0gQ29ycmVjdCBtb3VzZSBoYW5kL2Fycm93L0kt YmVhbSBpcyBkaXNwbGF5ZWQgKFRPRE86IG5vdCBwZXJmZWN0IHlldCkuCiAqLwogCi0tICh2b2lk KW1vdXNlRG93bjooTlNFdmVudCAqKWV2ZW50CistICh2b2lkKSBtb3VzZURvd246KE5TRXZlbnQg KilldmVudAogewogICBbc2VsZi54dy0+eHYtPmVtYWNzd2luZG93IG1vdXNlRG93bjpldmVudF07 CiAgIFtzdXBlciBtb3VzZURvd246ZXZlbnRdOwogfQogCi0tICh2b2lkKW1vdXNlVXA6KE5TRXZl bnQgKilldmVudAorLSAodm9pZCkgbW91c2VVcDooTlNFdmVudCAqKWV2ZW50CiB7CiAgIFtzZWxm Lnh3LT54di0+ZW1hY3N3aW5kb3cgbW91c2VVcDpldmVudF07CiAgIFtzdXBlciBtb3VzZVVwOmV2 ZW50XTsKQEAgLTIxNCw3ICsyNDEsNyBAQCAtICh2b2lkKW1vdXNlVXA6KE5TRXZlbnQgKilldmVu dAogICAgZW1hY3MgYXMgZmlyc3QgcmVzcG9uZGVyIHRvIGF2b2lkIGZvY3VzIGhlbGQgaW4gYW4g aW5wdXQgZWxlbWVudAogICAgd2l0aCBtYXRjaGluZyB0ZXh0LiAgKi8KIAotLSAodm9pZClrZXlE b3duOihOU0V2ZW50ICopZXZlbnQKKy0gKHZvaWQpIGtleURvd246KE5TRXZlbnQgKilldmVudAog ewogICBMaXNwX09iamVjdCB2YXIgPSBGaW50ZXJuIChidWlsZF9zdHJpbmcgKCJpc2VhcmNoLW1v ZGUiKSwgUW5pbCk7CiAgIExpc3BfT2JqZWN0IHZhbCA9IGJ1ZmZlcl9sb2NhbF92YWx1ZSAodmFy LCBGY3VycmVudF9idWZmZXIgKCkpOwpAQCAtMjUwLDcgKzI3Nyw3IEBAIC0gKHZvaWQpa2V5RG93 bjooTlNFdmVudCAqKWV2ZW50CiAgICAgfV07CiB9CiAKLS0gKHZvaWQpaW50ZXJwcmV0S2V5RXZl bnRzOihOU0FycmF5PE5TRXZlbnQgKj4gKilldmVudEFycmF5CistICh2b2lkKSBpbnRlcnByZXRL ZXlFdmVudHM6KE5TQXJyYXk8TlNFdmVudCAqPiAqKWV2ZW50QXJyYXkKIHsKICAgLyogV2Ugc2hv dWxkIGRvIG5vdGhpbmcgYW5kIGRvIG5vdCBmb3J3YXJkIChkZWZhdWx0IGltcGxlbWVudGF0aW9u CiAgICAgIGlmIHdlIG5vdCBvdmVycmlkZSBoZXJlKSB0byBsZXQgZW1hY3MgY29sbGVjdCBrZXkg ZXZlbnRzIGFuZCBhc2sKQEAgLTI1OCw3ICsyODUsNyBAQCAtICh2b2lkKWludGVycHJldEtleUV2 ZW50czooTlNBcnJheTxOU0V2ZW50ICo+ICopZXZlbnRBcnJheQogfQogCiBzdGF0aWMgTlNTdHJp bmcgKnh3U2NyaXB0OwotKyAodm9pZClpbml0aWFsaXplCisrICh2b2lkKSBpbml0aWFsaXplCiB7 CiAgIC8qIEZpbmQgb3V0IGlmIGFuIGlucHV0IGVsZW1lbnQgaGFzIGZvY3VzLgogICAgICBNZXNz YWdlIHRvIHNjcmlwdCBtZXNzYWdlIGhhbmRsZXIgd2hlbiAnQy1nJyBrZXkgZG93bi4gICovCkBA IC0yODQsNyArMzExLDcgQEAgKyAodm9pZClpbml0aWFsaXplCiAKIC8qIENvbmZpcm1pbmcgdG8g V0tTY3JpcHRNZXNzYWdlSGFuZGxlciwgbGlzdGVucyBjb25jZXJuaW5nIGtleURvd24gaW4KICAg IHdlYmtpdC4gQ3VycmVudGx5ICdDLWcnLiAgKi8KLS0gKHZvaWQpdXNlckNvbnRlbnRDb250cm9s bGVyOihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxlcgorLSAo dm9pZCkgdXNlckNvbnRlbnRDb250cm9sbGVyOihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVz ZXJDb250ZW50Q29udHJvbGxlcgogICAgICAgZGlkUmVjZWl2ZVNjcmlwdE1lc3NhZ2U6KFdLU2Ny aXB0TWVzc2FnZSAqKW1lc3NhZ2UKIHsKICAgaWYgKFttZXNzYWdlLmJvZHkgaXNFcXVhbFRvU3Ry aW5nOkAiQy1nIl0pCkBAIC0zNDMsNiArMzcwLDIwIEBAIC0gKHZvaWQpdXNlckNvbnRlbnRDb250 cm9sbGVyOihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxlcgog ICB9CiB9CiAKK2RvdWJsZQorbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVz cyAoc3RydWN0IHh3aWRnZXQgKnh3KQoreworICBYd1dlYlZpZXcgKnh3V2ViVmlldyA9IChYd1dl YlZpZXcgKikgeHctPnh3V2lkZ2V0OworICByZXR1cm4geHdXZWJWaWV3LmVzdGltYXRlZFByb2dy ZXNzOworfQorCit2b2lkCituc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZyAoc3RydWN0IHh3 aWRnZXQgKnh3KQoreworICBYd1dlYlZpZXcgKnh3V2ViVmlldyA9IChYd1dlYlZpZXcgKikgeHct Pnh3V2lkZ2V0OworICBbeHdXZWJWaWV3IHN0b3BMb2FkaW5nXTsKK30KKwogdm9pZAogbnN4d2lk Z2V0X3dlYmtpdF96b29tIChzdHJ1Y3QgeHdpZGdldCAqeHcsIGRvdWJsZSB6b29tX2NoYW5nZSkK IHsKQEAgLTQzMCw3ICs0NzEsNyBAQCAtICh2b2lkKXVzZXJDb250ZW50Q29udHJvbGxlcjooV0tV c2VyQ29udGVudENvbnRyb2xsZXIgKil1c2VyQ29udGVudENvbnRyb2xsZXIKICAgICAgICAgfQog ICAgICAgZWxzZSBpZiAocmVzdWx0ICYmIEZVTkNUSU9OUCAoZnVuKSkKICAgICAgICAgewotICAg ICAgICAgIC8vIE5TTG9nIChAInJlc3VsdD0lQCwgdHlwZT0lQCIsIHJlc3VsdCwgW3Jlc3VsdCBj bGFzc10pOworICAgICAgICAgIC8qIE5TTG9nIChAInJlc3VsdD0lQCwgdHlwZT0lQCIsIHJlc3Vs dCwgW3Jlc3VsdCBjbGFzc10pOyAqLwogICAgICAgICAgIExpc3BfT2JqZWN0IGxpc3BfdmFsdWUg PSBqc190b19saXNwIChyZXN1bHQpOwogICAgICAgICAgIHN0b3JlX3h3aWRnZXRfanNfY2FsbGJh Y2tfZXZlbnQgKHh3LCBmdW4sIGxpc3BfdmFsdWUpOwogICAgICAgICB9CkBAIC00NDAsMTkgKzQ4 MSwyMCBAQCAtICh2b2lkKXVzZXJDb250ZW50Q29udHJvbGxlcjooV0tVc2VyQ29udGVudENvbnRy b2xsZXIgKil1c2VyQ29udGVudENvbnRyb2xsZXIKIC8qIFdpbmRvdyBjb250YWluaW5nIGFuIHh3 aWRnZXQuICAqLwogCiBAaW1wbGVtZW50YXRpb24gWHdXaW5kb3cKLS0gKEJPT0wpaXNGbGlwcGVk IHsgcmV0dXJuIFlFUzsgfQorLSAoQk9PTCkgaXNGbGlwcGVkIHsgcmV0dXJuIFlFUzsgfQogQGVu ZAogCiAvKiBYd2lkZ2V0IG1vZGVsLCBtYWNPUyBDb2NvYSBwYXJ0LiAgKi8KIAogdm9pZAotbnN4 d2lkZ2V0X2luaXQoc3RydWN0IHh3aWRnZXQgKnh3KQorbnN4d2lkZ2V0X2luaXQgKHN0cnVjdCB4 d2lkZ2V0ICp4dykKIHsKICAgYmxvY2tfaW5wdXQgKCk7CiAgIE5TUmVjdCByZWN0ID0gTlNNYWtl UmVjdCAoMCwgMCwgeHctPndpZHRoLCB4dy0+aGVpZ2h0KTsKICAgeHctPnh3V2lkZ2V0ID0gW1tY d1dlYlZpZXcgYWxsb2NdCiAgICAgICAgICAgICAgICAgICAgaW5pdFdpdGhGcmFtZTpyZWN0Ci0g ICAgICAgICAgICAgICAgICAgY29uZmlndXJhdGlvbjpbW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24g YWxsb2NdIGluaXRdCisgICAgICAgICAgICAgICAgICAgY29uZmlndXJhdGlvbjpbW1tXS1dlYlZp ZXdDb25maWd1cmF0aW9uIGFsbG9jXSBpbml0XQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBhdXRvcmVsZWFzZV0KICAgICAgICAgICAgICAgICAgICAgICAgICB4d2lkZ2V0Onh3 XTsKICAgeHctPnh3V2luZG93ID0gW1tYd1dpbmRvdyBhbGxvY10KICAgICAgICAgICAgICAgICAg ICBpbml0V2l0aEZyYW1lOnJlY3RdOwpAQCAtNDcwLDE2ICs1MTIsMTggQEAgLSAoQk9PTClpc0Zs aXBwZWQgeyByZXR1cm4gWUVTOyB9CiAgICAgICAgICgoWHdXZWJWaWV3ICopIHh3LT54d1dpZGdl dCkuY29uZmlndXJhdGlvbi51c2VyQ29udGVudENvbnRyb2xsZXI7CiAgICAgICBbc2NyaXB0b3Ig cmVtb3ZlQWxsVXNlclNjcmlwdHNdOwogICAgICAgW3NjcmlwdG9yIHJlbW92ZVNjcmlwdE1lc3Nh Z2VIYW5kbGVyRm9yTmFtZTpAImtleURvd24iXTsKLSAgICAgIFtzY3JpcHRvciByZWxlYXNlXTsK KwogICAgICAgaWYgKHh3LT54dikKICAgICAgICAgeHctPnh2LT5tb2RlbCA9IFFuaWw7IC8qIE1h a2Ugc3VyZSByZWxhdGVkIHZpZXcgc3RhbGUuICAqLwogCiAgICAgICAvKiBUaGlzIHN0b3BzIHBs YXlpbmcgYXVkaW8gd2hlbiBhIHh3aWRnZXQtd2Via2l0IGJ1ZmZlciBpcwotICAgICAgICAga2ls bGVkLiAgSSBjb3VsZCBub3QgZmluZCBvdGhlciBzb2x1dGlvbi4gICovCisgICAgICAgICBraWxs ZWQuICBJIGNvdWxkIG5vdCBmaW5kIG90aGVyIHNvbHV0aW9uLgorICAgICAgICAgVE9ETzogaW1w cm92ZSB0aGlzICovCiAgICAgICBuc3h3aWRnZXRfd2Via2l0X2dvdG9fdXJpICh4dywgImFib3V0 OmJsYW5rIik7CiAKICAgICAgIFsoKFh3V2ViVmlldyAqKSB4dy0+eHdXaWRnZXQpLnVybFNjcmlw dEJsb2NrZWQgcmVsZWFzZV07CiAgICAgICBbeHctPnh3V2lkZ2V0IHJlbW92ZUZyb21TdXBlcnZp ZXdXaXRob3V0TmVlZGluZ0Rpc3BsYXldOworCiAgICAgICBbeHctPnh3V2lkZ2V0IHJlbGVhc2Vd OwogICAgICAgW3h3LT54d1dpbmRvdyByZW1vdmVGcm9tU3VwZXJ2aWV3V2l0aG91dE5lZWRpbmdE aXNwbGF5XTsKICAgICAgIFt4dy0+eHdXaW5kb3cgcmVsZWFzZV07CkBAIC01MDcsNyArNTUxLDcg QEAgLSAoQk9PTClpc0ZsaXBwZWQgeyByZXR1cm4gWUVTOyB9CiAvKiBYd2lkZ2V0IHZpZXcsIG1h Y09TIENvY29hIHBhcnQuICAqLwogCiBAaW1wbGVtZW50YXRpb24gWHZXaW5kb3cgOiBOU1ZpZXcK LS0gKEJPT0wpaXNGbGlwcGVkIHsgcmV0dXJuIFlFUzsgfQorLSAoQk9PTCkgaXNGbGlwcGVkIHsg cmV0dXJuIFlFUzsgfQogQGVuZAogCiB2b2lkCmRpZmYgLS1naXQgYS9zcmMveHdpZGdldC5jIGIv c3JjL3h3aWRnZXQuYwppbmRleCBlZmUyNzA1NTYyOS4uN2YzMGU0OGM5NTQgMTAwNjQ0Ci0tLSBh L3NyYy94d2lkZ2V0LmMKKysrIGIvc3JjL3h3aWRnZXQuYwpAQCAtMzA2Myw2ICszMDYzLDM2IEBA IERFRlVOICgieHdpZGdldC13ZWJraXQtdGl0bGUiLAogI2VuZGlmCiB9CiAKK0RFRlVOICgieHdp ZGdldC13ZWJraXQtZXN0aW1hdGVkLWxvYWQtcHJvZ3Jlc3MiLAorICAgICAgIEZ4d2lkZ2V0X3dl YmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcywgU3h3aWRnZXRfd2Via2l0X2VzdGltYXRlZF9s b2FkX3Byb2dyZXNzLAorICAgICAgIDEsIDEsIDAsIGRvYzogLyogR2V0IHRoZSBlc3RpbWF0ZWQg bG9hZCBwcm9ncmVzcyBvZiBYV0lER0VULCBhIFdlYktpdCB3aWRnZXQuCitSZXR1cm4gYSB2YWx1 ZSByYW5naW5nIGZyb20gMC4wIHRvIDEuMCwgYmFzZWQgb24gaG93IGNsb3NlIFhXSURHRVQKK2lz IHRvIGNvbXBsZXRlbHkgbG9hZGluZyBpdHMgcGFnZS4gICovKQorICAoTGlzcF9PYmplY3QgeHdp ZGdldCkKK3sKKyAgc3RydWN0IHh3aWRnZXQgKnh3OworI2lmZGVmIFVTRV9HVEsKKyAgV2ViS2l0 V2ViVmlldyAqd2VidmlldzsKKyNlbmRpZgorICBkb3VibGUgdmFsdWU7CisKKyAgQ0hFQ0tfTElW RV9YV0lER0VUICh4d2lkZ2V0KTsKKyAgeHcgPSBYWFdJREdFVCAoeHdpZGdldCk7CisgIENIRUNL X1dFQktJVF9XSURHRVQgKHh3KTsKKworICBibG9ja19pbnB1dCAoKTsKKyNpZmRlZiBVU0VfR1RL CisgIHdlYnZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcgKHh3LT53aWRnZXRfb3NyKTsKKyAgdmFsdWUg PSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzICh3ZWJ2aWV3KTsK KyNlbGlmIGRlZmluZWQgTlNfSU1QTF9DT0NPQQorICB2YWx1ZSA9IG5zeHdpZGdldF93ZWJraXRf ZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MgKHh3KTsKKyNlbmRpZgorCisgIHVuYmxvY2tfaW5wdXQg KCk7CisKKyAgcmV0dXJuIG1ha2VfZmxvYXQgKHZhbHVlKTsKK30KKwogREVGVU4gKCJ4d2lkZ2V0 LXdlYmtpdC1nb3RvLXVyaSIsCiAgICAgICAgRnh3aWRnZXRfd2Via2l0X2dvdG9fdXJpLCBTeHdp ZGdldF93ZWJraXRfZ290b191cmksCiAgICAgICAgMiwgMiwgMCwKQEAgLTM4MTAsMjggKzM4NDAs NiBAQCBERUZVTiAoInh3aWRnZXQtd2Via2l0LWJhY2stZm9yd2FyZC1saXN0IiwgRnh3aWRnZXRf d2Via2l0X2JhY2tfZm9yd2FyZF9saXN0LAogICByZXR1cm4gbGlzdDMgKGJhY2ssIGhlcmUsIGZv cndhcmQpOwogfQogCi1ERUZVTiAoInh3aWRnZXQtd2Via2l0LWVzdGltYXRlZC1sb2FkLXByb2dy ZXNzIiwKLSAgICAgICBGeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MsIFN4 d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVzcywKLSAgICAgICAxLCAxLCAwLCBk b2M6IC8qIEdldCB0aGUgZXN0aW1hdGVkIGxvYWQgcHJvZ3Jlc3Mgb2YgWFdJREdFVCwgYSBXZWJL aXQgd2lkZ2V0LgotUmV0dXJuIGEgdmFsdWUgcmFuZ2luZyBmcm9tIDAuMCB0byAxLjAsIGJhc2Vk IG9uIGhvdyBjbG9zZSBYV0lER0VUCi1pcyB0byBjb21wbGV0ZWx5IGxvYWRpbmcgaXRzIHBhZ2Uu ICAqLykKLSAgKExpc3BfT2JqZWN0IHh3aWRnZXQpCi17Ci0gIHN0cnVjdCB4d2lkZ2V0ICp4dzsK LSAgV2ViS2l0V2ViVmlldyAqd2VidmlldzsKLSAgZG91YmxlIHZhbHVlOwotCi0gIENIRUNLX0xJ VkVfWFdJREdFVCAoeHdpZGdldCk7Ci0gIHh3ID0gWFhXSURHRVQgKHh3aWRnZXQpOwotICBDSEVD S19XRUJLSVRfV0lER0VUICh4dyk7Ci0KLSAgYmxvY2tfaW5wdXQgKCk7Ci0gIHdlYnZpZXcgPSBX RUJLSVRfV0VCX1ZJRVcgKHh3LT53aWRnZXRfb3NyKTsKLSAgdmFsdWUgPSB3ZWJraXRfd2ViX3Zp ZXdfZ2V0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzICh3ZWJ2aWV3KTsKLSAgdW5ibG9ja19pbnB1 dCAoKTsKLQotICByZXR1cm4gbWFrZV9mbG9hdCAodmFsdWUpOwotfQogI2VuZGlmCiAKIERFRlVO ICgieHdpZGdldC13ZWJraXQtc2V0LWNvb2tpZS1zdG9yYWdlLWZpbGUiLApAQCAtMzg3NCwxOSAr Mzg4MiwyMyBAQCBERUZVTiAoInh3aWRnZXQtd2Via2l0LXN0b3AtbG9hZGluZyIsIEZ4d2lkZ2V0 X3dlYmtpdF9zdG9wX2xvYWRpbmcsCiBYV0lER0VUIGFzIHBhcnQgb2YgbG9hZGluZyBhIHBhZ2Uu ICAqLykKICAgKExpc3BfT2JqZWN0IHh3aWRnZXQpCiB7Ci0jaWZkZWYgVVNFX0dUSwogICBzdHJ1 Y3QgeHdpZGdldCAqeHc7CisjaWZkZWYgVVNFX0dUSwogICBXZWJLaXRXZWJWaWV3ICp3ZWJ2aWV3 OworI2VuZGlmCiAKICAgQ0hFQ0tfTElWRV9YV0lER0VUICh4d2lkZ2V0KTsKICAgeHcgPSBYWFdJ REdFVCAoeHdpZGdldCk7CiAgIENIRUNLX1dFQktJVF9XSURHRVQgKHh3KTsKIAogICBibG9ja19p bnB1dCAoKTsKKyNpZmRlZiBVU0VfR1RLCiAgIHdlYnZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcgKHh3 LT53aWRnZXRfb3NyKTsKICAgd2Via2l0X3dlYl92aWV3X3N0b3BfbG9hZGluZyAod2Vidmlldyk7 Ci0gIHVuYmxvY2tfaW5wdXQgKCk7CisjZWxpZiBkZWZpbmVkIE5TX0lNUExfQ09DT0EKKyAgbnN4 d2lkZ2V0X3dlYmtpdF9zdG9wX2xvYWRpbmcgKHh3KTsKICNlbmRpZgorICB1bmJsb2NrX2lucHV0 ICgpOwogCiAgIHJldHVybiBRbmlsOwogfQpAQCAtMzkzNiw4ICszOTQ4LDkgQEAgc3ltc19vZl94 d2lkZ2V0ICh2b2lkKQogI2lmZGVmIFVTRV9HVEsKICAgZGVmc3ViciAoJlN4d2lkZ2V0X3dlYmtp dF9sb2FkX2h0bWwpOwogICBkZWZzdWJyICgmU3h3aWRnZXRfd2Via2l0X2JhY2tfZm9yd2FyZF9s aXN0KTsKLSAgZGVmc3ViciAoJlN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVz cyk7CiAjZW5kaWYKKworICBkZWZzdWJyICgmU3h3aWRnZXRfd2Via2l0X2VzdGltYXRlZF9sb2Fk X3Byb2dyZXNzKTsKICAgZGVmc3ViciAoJlNraWxsX3h3aWRnZXQpOwogCiAgIERFRlNZTSAoUUN4 d2lkZ2V0LCAiOnh3aWRnZXQiKTsK --000000000000bd747905f52efd81-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:26:56 2023 Received: (at 60703) by debbugs.gnu.org; 22 Feb 2023 13:26:56 +0000 Received: from localhost ([127.0.0.1]:58310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp96-0002Qg-7n for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:26:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp94-0002QT-Uh for 60703@debbugs.gnu.org; Wed, 22 Feb 2023 08:26:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUp8z-0002rk-ON; Wed, 22 Feb 2023 08:26:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LwWo6bhVwwLIHsYu7iQ4eVihQj+h2rs4T+uodNwXDYc=; b=O0a5ieHU7lWF G84vxyzTIY3A+FMsDCCETzKvZ1wl7qV748VQZDrYTKRTPuZppwPsLRvFRbLhKarzy+eWctpHKxikc zbcN9USWnc+vb8FfLHfCSMAAcOvvmTFVosiKeBzuC5c5KtrztiExcZF4ZGerJGYG21v5v6ohOq4xD ykS0xmZvp5ZTjcuOqFBx4onJf4tAG9urA2FQKaXaiVQJHvB03rTz66l3l7IoHAxZXF4Q5HKDM0Npb lWoPxXAWzwDtuPDeTwxZegjEIjwQ8r/25MzY4/3El/d6CwCbqU3K4UGDfmjKh+LDjvs4VV80bEpgj XGCSVZJu6j7l2zHaZI8D6Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUp8w-0005xM-CQ; Wed, 22 Feb 2023 08:26:49 -0500 Date: Wed, 22 Feb 2023 15:27:00 +0200 Message-Id: <838rgpsue3.fsf@gnu.org> From: Eli Zaretskii To: Andrew De Angelis In-Reply-To: (message from Andrew De Angelis on Tue, 21 Feb 2023 00:24:06 -0500) Subject: Re: bug#60703: Patches to xwidget code References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew De Angelis > Date: Tue, 21 Feb 2023 00:24:06 -0500 > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > Done. (git diff forked/emacs-29 > emacs-29-xwidget-patches.patch) > > Let me know if there's anything I should do. Thanks! Thanks, what is missing now is the commit log message. Please see CONTRIBUTE and the examples in the Git repository, for how we format the log messages. One minor comment to the code: > +DEFUN ("xwidget-webkit-estimated-load-progress", > + Fxwidget_webkit_estimated_load_progress, Sxwidget_webkit_estimated_load_progress, > + 1, 1, 0, doc: /* Get the estimated load progress of XWIDGET, a WebKit widget. > +Return a value ranging from 0.0 to 1.0, based on how close XWIDGET > +is to completely loading its page. */) The first line of a doc string should be a single complete sentence. This is because commands like "M-x apropos" show only the first line. (Yes, I'm aware that you just moved existing code, but still: let's fix this while we are at that.) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 22:48:01 2023 Received: (at 60703) by debbugs.gnu.org; 24 Feb 2023 03:48:01 +0000 Received: from localhost ([127.0.0.1]:35745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVP3x-0005c9-3q for submit@debbugs.gnu.org; Thu, 23 Feb 2023 22:48:01 -0500 Received: from mail-vs1-f47.google.com ([209.85.217.47]:36467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVP3u-0005bK-R0 for 60703@debbugs.gnu.org; Thu, 23 Feb 2023 22:47:59 -0500 Received: by mail-vs1-f47.google.com with SMTP id j14so19504302vse.3 for <60703@debbugs.gnu.org>; Thu, 23 Feb 2023 19:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FZ/1Yiz9s1uHu6HDXY20F+HQN2LdVIYvtJTvcZJyNdg=; b=q4DJsT+gSdcpQP7ZKCRGXP6YeCcd+Kw3Pzhq9DfRoJ121cPPav5JFPI5eRC3h1jIQy U/OY+SqPLnWc329sXkJK3x6uxQx6ypmhiElKpT7SFxszlkIOjBUg7WN44HMnmB/KCOKi b4k/hoKar5jwyHukDW8lZro5Jq5SF8xj9Bee7eQQZ8zAjsfHEiUmKbCFl9eBZSvuIJAN 7hmMo7R8XZAIvPI0SpeQZ48NBwJTRQ2L8dcg+ZUwoZd50qZv/08CcuVqjX+pHtWcUN1X JUpTqI5Poa5ozSHr5J5hJlGhGbcrYslUxXusCqvfdnh1T0vgEXSBoPwrFt+AbeIjH99A 5YhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FZ/1Yiz9s1uHu6HDXY20F+HQN2LdVIYvtJTvcZJyNdg=; b=zXQHSPgXrI43+K6RlR0aigPZJXXvo8jQ/b4VbEa710yNNVT+g/O+t1zlC9k//nvmcS WV5EDaZAHl4HuUDxw5fdkTH3HBQRd+Xe0tH2m7aSUDycKJsmBqxtQmVjuKF6tM/xLTt/ aTQ97PksTwM0ajDD1ArZ2/Asy+UesupamPBeIcSLNLH8hBHfHiul25wiRZUroqO/bl23 zy5BgWtF4MxVIQXN7goSMvozy5z4178YMfA8R6Ypb9EJYa3yS/GWp0+mvB65XNViVKnR LCF4bJcrSGRAyPLLCzs65Bjtm8lQgJ0+9kqjgcu5qYtrMbPlpe3J2RX7DWx3Kv2tB732 mAQA== X-Gm-Message-State: AO0yUKXFwnj6TtBgB/YjND37EcfLGKnbTSqNT6tlRU0XnFqKKXFw/dvi 53GT2YLgZf4UDWDpVBqY6VC85VvazayItlXJ0ypP24cs0gc= X-Google-Smtp-Source: AK7set+iAmS1hEmfp1agz5ejW1AByu/atg6/HkdH6zrE7uU03V4TSKH1zDekixOluvEv/33fod2sbYMa4ZQFosfJFiE= X-Received: by 2002:a05:6102:30b3:b0:412:27f7:491b with SMTP id y19-20020a05610230b300b0041227f7491bmr1519671vsd.2.1677210472928; Thu, 23 Feb 2023 19:47:52 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> <838rgpsue3.fsf@gnu.org> In-Reply-To: <838rgpsue3.fsf@gnu.org> From: Andrew De Angelis Date: Thu, 23 Feb 2023 22:47:41 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Eli Zaretskii Content-Type: multipart/mixed; boundary="00000000000074573105f569fe23" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 60703 Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000074573105f569fe23 Content-Type: multipart/alternative; boundary="00000000000074573005f569fe21" --00000000000074573005f569fe21 Content-Type: text/plain; charset="UTF-8" Let me know if this ChangeLog is fine or you'd like me to make any changes. The first line of a doc string should be a single complete sentence. > I'm not sure I follow: in this case, isn't this the first line: "Get the estimated load progress of XWIDGET, a WebKit widget."? It renders fine when I run `M-x apropos xwidget-webkit-estimated-load-progress`. But happy to make any additional changes if needed. On Wed, Feb 22, 2023 at 8:26 AM Eli Zaretskii wrote: > > From: Andrew De Angelis > > Date: Tue, 21 Feb 2023 00:24:06 -0500 > > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > > > Done. (git diff forked/emacs-29 > emacs-29-xwidget-patches.patch) > > > > Let me know if there's anything I should do. Thanks! > > Thanks, what is missing now is the commit log message. Please see > CONTRIBUTE and the examples in the Git repository, for how we format > the log messages. > > One minor comment to the code: > > > +DEFUN ("xwidget-webkit-estimated-load-progress", > > + Fxwidget_webkit_estimated_load_progress, > Sxwidget_webkit_estimated_load_progress, > > + 1, 1, 0, doc: /* Get the estimated load progress of XWIDGET, a > WebKit widget. > > +Return a value ranging from 0.0 to 1.0, based on how close XWIDGET > > +is to completely loading its page. */) > > The first line of a doc string should be a single complete sentence. > This is because commands like "M-x apropos" show only the first line. > > (Yes, I'm aware that you just moved existing code, but still: let's > fix this while we are at that.) > --00000000000074573005f569fe21 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Let me know if this ChangeLog is fine or you'd li= ke me to make any changes.

The first line of a doc string should be a singl= e complete sentence.
I'm not sure I follow: in t= his case, isn't=C2=A0 this the first line: "Get the estimated load progress of XWIDGET, a WebKit widget."? It r= enders fine when I run `M-x apropos xwidget-webkit-estimated-load-progress`= . But happy to make any additional changes if needed.
=


On Wed, Feb 22, 2023 at 8:26 AM Eli Zaretskii <= eliz@gnu.org> wrote:
> From: Andrew De Angelis &l= t;bobodeangeli= s@gmail.com>
> Date: Tue, 21 Feb 2023 00:24:06 -0500
> Cc: luangruo@y= ahoo.com, 60= 703@debbugs.gnu.org
>
> Done. (git diff forked/emacs-29 > emacs-29-xwidget-patches.patch) >
> Let me know if there's anything I should do. Thanks!

Thanks, what is missing now is the commit log message.=C2=A0 Please see
CONTRIBUTE and the examples in the Git repository, for how we format
the log messages.

One minor comment to the code:

> +DEFUN ("xwidget-webkit-estimated-load-progress",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0Fxwidget_webkit_estimated_load_progress, S= xwidget_webkit_estimated_load_progress,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A01, 1, 0, doc: /* Get the estimated load pr= ogress of XWIDGET, a WebKit widget.
> +Return a value ranging from 0.0 to 1.0, based on how close XWIDGET > +is to completely loading its page.=C2=A0 */)

The first line of a doc string should be a single complete sentence.
This is because commands like "M-x apropos" show only the first l= ine.

(Yes, I'm aware that you just moved existing code, but still: let's=
fix this while we are at that.)
--00000000000074573005f569fe21-- --00000000000074573105f569fe23 Content-Type: application/octet-stream; name="ChangeLog.andrewda" Content-Disposition: attachment; filename="ChangeLog.andrewda" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lehzoe5q0 MjAyMy0wMi0yMyAgQW5kcmV3IERlIEFuZ2VsaXMgIDxib2JvZGVhbmdlbGlzQGdtYWlsLmNvbT4K CUltcHJvdmVtZW50cyB0byB4d2lkZ2V0CgoJKiBzcmMvbnN4d2lkZ2V0Lm0gKCkKCShbWHdXZWJW aWV3IGluaXRXaXRoRnJhbWU6Y29uZmlndXJhdGlvbjp4d2lkZ2V0Ol0pCgkobnN4d2lkZ2V0X2lu aXQpOiAgRml4ZWQgbWVtb3J5IGxlYWtzOiB3aGVuIHNlbmRpbmcgYW4gYWxsb2MgbWVzc2FnZSB0 bwoJYW4gb2JqZWN0LCBzZW5kIGFuIGF1dG9yZWxlYXNlIG1lc3NhZ2UgdG8gYW55IG9iamVjdHMg d2Ugd29uJ3QKCWV4cGxpY3RseSByZWxlYXNlCgkoW1h3V2ViVmlldyB3ZWJWaWV3OmRpZEZpbmlz aE5hdmlnYXRpb246XSk6IFNlY29uZCBzdHJpbmcgdG8gc3RvcmUgaW4KCSdzdG9yZV94d2lkZ2V0 X2V2ZW50X3N0cmluZycgaXMgImxvYWQgZmluaXNoZWQiIHJhdGhlciB0aGFuIGVtcHR5IHN0cmlu ZwoJKFtYd1dlYlZpZXcgd2ViVmlldzpkaWRTdGFydFByb3Zpc2lvbmFsTmF2aWdhdGlvbjpdKQoJ KFtYd1dlYlZpZXcgd2ViVmlldzpkaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92aXNpb25h bE5hdmlnYXRpb246XSkKCShbWHdXZWJWaWV3IHdlYlZpZXc6ZGlkQ29tbWl0TmF2aWdhdGlvbjpd KTogTmV3IGZ1bmN0aW9ucwoJKG5zeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jl c3MpOiBOZXcgZnVuY3Rpb24KCShuc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZyk6IE5ldyBm dW5jdGlvbgoJKiBzcmMveHdpZGdldC5jIChGeHdpZGdldF93ZWJraXRfZXN0aW1hdGVkX2xvYWRf cHJvZ3Jlc3MpOiBDYWxsCgknbnN4d2lkZ2V0X3dlYmtpdF9lc3RpbWF0ZWRfbG9hZF9wcm9ncmVz cycgaWYgd2UncmUgb24gTWFjT1MKCShGeHdpZGdldF93ZWJraXRfc3RvcF9sb2FkaW5nKTogQ2Fs bCAnbnN4d2lkZ2V0X3dlYmtpdF9zdG9wX2xvYWRpbmcnIGlmCgl3ZSdyZSBvbiBNYWNPUwoJKHN5 bXNfb2ZfeHdpZGdldCk6IERlZmluZSBzeW1ib2wgZm9yIGZ1bmN0aW9uCgkneHdpZGdldF93ZWJr aXRfZXN0aW1hdGVkX2xvYWRfcHJvZ3Jlc3MnIGlmIHdlJ3JlIG9uIE1hY09TCgkqIHNyYy9uc3h3 aWRnZXQuaDogc2lnbmF0dXJlIGZvciBmdW5jdGlvbnMKCSduc3h3aWRnZXRfd2Via2l0X2VzdGlt YXRlZF9sb2FkX3Byb2dyZXNzJyBhbmQKCSduc3h3aWRnZXRfd2Via2l0X3N0b3BfbG9hZGluZycK CSogbGlzcC94d2lkZ2V0LmVsICh4d2lkZ2V0LXdlYmtpdC1jdXJyZW50LXVybCk6IE1lc3NhZ2Ug VVJMIHJhdGhlciB0aGFuCglyZXR1cm4gdmFsdWUgb2YgJ2tpbGwtbmV3JyAod2hpY2ggaXMgYWx3 YXlzIG5pbCkK --00000000000074573105f569fe23-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 05:58:17 2023 Received: (at 60703-done) by debbugs.gnu.org; 2 Mar 2023 10:58:17 +0000 Received: from localhost ([127.0.0.1]:55947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXgdc-0001bK-Q6 for submit@debbugs.gnu.org; Thu, 02 Mar 2023 05:58:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXgdb-0001b6-3J for 60703-done@debbugs.gnu.org; Thu, 02 Mar 2023 05:58:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXgdV-0006rm-OX; Thu, 02 Mar 2023 05:58:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dH0TKwZ6L3M7qR5AJ8k8bMfZghlWSQpPc/HxAFblb5o=; b=X/laeEtwUQtC SajKrFgj4kKg5t5n5uNC7IT1yR2Xn2yfjyQeoEESu61CP2cv4+kqGdrRKdmKniDHCUV44GhiQIh8n A1OIngClLtjvgwe63DxkC5kcFYZddoeob+N76dALZMApadJnvlEJjsRD7Kxr3QS3MYJXc+dTefupM TIm7OIkPOOH5EjPpsVwVSZXsUkKhCZ2vTPEb0PoTpGb+plD4p4C6oxTJyC5cqjGgn7RypXHRXF9ZK VeADstUWvKje4QGaTogRkPUfPtFtcbA5tJ1E5LvBC0HzJ+DMXPIeFosVH3+dIGot4c3PrHJee/jhy ZwOvP143Zdch3RwP6MGckQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXgdJ-0008Fo-UI; Thu, 02 Mar 2023 05:58:08 -0500 Date: Thu, 02 Mar 2023 12:57:54 +0200 Message-Id: <83fsane7yl.fsf@gnu.org> From: Eli Zaretskii To: Andrew De Angelis In-Reply-To: (message from Andrew De Angelis on Thu, 23 Feb 2023 22:47:41 -0500) Subject: Re: bug#60703: Patches to xwidget code References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> <838rgpsue3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60703-done Cc: luangruo@yahoo.com, 60703-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew De Angelis > Date: Thu, 23 Feb 2023 22:47:41 -0500 > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > Let me know if this ChangeLog is fine or you'd like me to make any changes. Thanks, installed on the emacs-29 branch, and closing the bug. > The first line of a doc string should be a single complete sentence. > > I'm not sure I follow: in this case, isn't this the first line: "Get the estimated load progress of XWIDGET, a > WebKit widget."? It renders fine when I run `M-x apropos xwidget-webkit-estimated-load-progress`. But > happy to make any additional changes if needed. Please ignore that part: I was confused. Please in the future always accompany the changes with a ChangeLog-style commit log message, and mention the bug number there if you know it. Also, use of "git format-patch" is encouraged. These measures make the job of installing your changes much easier. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 18:00:23 2023 Received: (at 60703-done) by debbugs.gnu.org; 4 Mar 2023 23:00:23 +0000 Received: from localhost ([127.0.0.1]:37988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYarW-000898-R6 for submit@debbugs.gnu.org; Sat, 04 Mar 2023 18:00:23 -0500 Received: from mail-ua1-f45.google.com ([209.85.222.45]:34655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYarU-00088h-EF for 60703-done@debbugs.gnu.org; Sat, 04 Mar 2023 18:00:21 -0500 Received: by mail-ua1-f45.google.com with SMTP id p2so4089886uap.1 for <60703-done@debbugs.gnu.org>; Sat, 04 Mar 2023 15:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677970815; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+BrZl9ftj0aXq1nH39orxqGjIw8m0GP5lataLbgkuaw=; b=lq90WBmneiy927Ozk3hiCrY5ph6Nh18W/z38hkBNVjEf/zG+lRbxAFvEw25cLf3Dz3 9jBr2o1grxCjZkywbbGJnUtKJDERI2fvmBiL579Jnqp3URwf3OLm9sb2Sszihu2+zYvA 4YBLvNPW/SbxVd+muTG4RF2J1FwCUa7LbsP+V+cmg3r8gzm0Oe7qugC2fmDVpgdEwDm2 hngt22t4koBNsESUw/l8wu39vvA0euVXNAC0KoKkYYaOcbZDZ4vEwEtJR1ovJRIL4Tb7 SpjLNud68HDRTE2hzId6OQZ63lQe0uMyliDIv/cpeu90JmtzpzhFqHdsK0uUFp9Gp5Ul h6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677970815; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+BrZl9ftj0aXq1nH39orxqGjIw8m0GP5lataLbgkuaw=; b=Xb3s/OP8GZAWSm7wrkGuDpTItfQe0buIov4k0Bs+seBDZ4PnmEzOKjZg2TGIXV1qH8 HXTljrpzuxcZsapwYYs7cbnXrtKh7uK6o5YvR+mHTYhQBr9dDEX8b2KpHBedaBRbgnI7 q6kgistq4Y8iTdC6sp0m9MBidIucfqeb/Odwg0H7rMOwjuqzKUe+kLTZxTEkoWQkJ+T3 +Y7ZmCGCtvkE/2GHXg9W4xadHLniE1MmNqEhR7YY9BmIQIR/RR7kJXhq12xsoPcsKbax PiRiH4SgD77fPMtYwvvUIgmZ8ATbIr7OImgYPls+NI8zIP7s+ktpSoC5B8abg/DLR6JY GTTw== X-Gm-Message-State: AO0yUKWHFLJKQRxgiFq4pfddhv3eWU6sfUFcNNcawcSaj6E2ETbWla9d YvuseCUePug5kluBETrEPhG3UVhiRHCSsLY3ASY= X-Google-Smtp-Source: AK7set9HKQc0TfniPlRPWXPzvxu7YKflyEppjMzORGE20ubUCd27BZXVzAgY9hQnG8LXAR6gBrKCB7nrn8DfiLeJzQI= X-Received: by 2002:a1f:1752:0:b0:401:f65:99c2 with SMTP id 79-20020a1f1752000000b004010f6599c2mr4180790vkx.3.1677970814900; Sat, 04 Mar 2023 15:00:14 -0800 (PST) MIME-Version: 1.0 References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> <838rgpsue3.fsf@gnu.org> <83fsane7yl.fsf@gnu.org> In-Reply-To: <83fsane7yl.fsf@gnu.org> From: Andrew De Angelis Date: Sat, 4 Mar 2023 18:00:03 -0500 Message-ID: Subject: Re: bug#60703: Patches to xwidget code To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000005d9c9505f61b0681" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 60703-done Cc: luangruo@yahoo.com, 60703-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005d9c9505f61b0681 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Awesome, thank you so much! Will keep all your suggestions in mind for my future contributions. Small question: what are the criteria to be added to `etc/AUTHORS`? Just wondering if/how my contribution could be mentioned there. On Thu, Mar 2, 2023 at 5:58=E2=80=AFAM Eli Zaretskii wrote: > > From: Andrew De Angelis > > Date: Thu, 23 Feb 2023 22:47:41 -0500 > > Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org > > > > Let me know if this ChangeLog is fine or you'd like me to make any > changes. > > Thanks, installed on the emacs-29 branch, and closing the bug. > > > The first line of a doc string should be a single complete sentence. > > > > I'm not sure I follow: in this case, isn't this the first line: "Get > the estimated load progress of XWIDGET, a > > WebKit widget."? It renders fine when I run `M-x apropos > xwidget-webkit-estimated-load-progress`. But > > happy to make any additional changes if needed. > > Please ignore that part: I was confused. > > Please in the future always accompany the changes with a > ChangeLog-style commit log message, and mention the bug number there > if you know it. Also, use of "git format-patch" is encouraged. These > measures make the job of installing your changes much easier. > --0000000000005d9c9505f61b0681 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Awesome, thank you so much! Will keep all your sugges= tions in mind for my future contributions.

Small q= uestion: what are the criteria to be added to `etc/AUTHORS`? Just wondering= if/how my contribution could be mentioned there.

On Thu, Mar 2, 2= 023 at 5:58=E2=80=AFAM Eli Zaretskii <el= iz@gnu.org> wrote:
> From: Andrew De Angelis <bobodeangelis@gmail.com>
> Date: Thu, 23 Feb 2023 22:47:41 -0500
> Cc: luangruo@y= ahoo.com, 60= 703@debbugs.gnu.org
>
> Let me know if this ChangeLog is fine or you'd like me to make any= changes.

Thanks, installed on the emacs-29 branch, and closing the bug.

>=C2=A0 The first line of a doc string should be a single complete sente= nce.
>
> I'm not sure I follow: in this case, isn't=C2=A0 this the firs= t line: "Get the estimated load progress of XWIDGET, a
> WebKit widget."? It renders fine when I run `M-x apropos xwidget-= webkit-estimated-load-progress`. But
> happy to make any additional changes if needed.

Please ignore that part: I was confused.

Please in the future always accompany the changes with a
ChangeLog-style commit log message, and mention the bug number there
if you know it.=C2=A0 Also, use of "git format-patch" is encourag= ed.=C2=A0 These
measures make the job of installing your changes much easier.
--0000000000005d9c9505f61b0681-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 19:07:34 2023 Received: (at 60703-done) by debbugs.gnu.org; 5 Mar 2023 00:07:34 +0000 Received: from localhost ([127.0.0.1]:38060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYbuY-0001fw-Bn for submit@debbugs.gnu.org; Sat, 04 Mar 2023 19:07:34 -0500 Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]:40116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYbuW-0001fi-Sx for 60703-done@debbugs.gnu.org; Sat, 04 Mar 2023 19:07:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677974846; bh=n43619QT8OYC6hHORTJo4u+TsmGJlYqKXy4L3W/u17g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=oPc/HNIporDCQEZsvPOXxhQ2lNtqQ4OHf5EFtZw7itXXDvZcIzuUCDz7LS9sYIcLbfeoU3I/YtCFOVZKVMHPm7Sk1mpIssx+vIYkmbAca0TcOElIMYyMSqO54vjMMUePgyzK4WvQLui2KeN+pnp9CQI6aKEldMEsJHvqTEFiKFgsF1lJsIA+Q/tf+kIxJsYi6Bxpb9moVdT6BFUafIK3l9nZnXPvnI3b+/xYXeXSYw6FDGUmPLG6ziFryhLi8bmNU7rif6coGL+ou+8uZVZZrW5RWQ7QOcsI5opueae6W/2GLPKX/8npAG8uhvu8VfiY0244yi4iOYwv6CORqWcaMg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677974846; bh=bLop5DiypVrc6ZODC22qnkZQtt5iq4CQeK7j+PzNkS5=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rRIFbJxTVJC4SXI1OskrFQ1QOg1526I4vwKOKslfnxJpD6679snl5dA1w/DcSfWg6/TdCwK838Oi4s6EEZMeJ1P4C4FDH2dfgu+8ca5Sodr4fjDczR+SCVpb/i3a69AcI+FcAJjpyrm3Nu33OhbQ79A2D/VdDLOAr8nPy52LGUidhsrN6k4lKxPGXLPAcYA6dbnQpxApS00oKA/X0gtStytOH6QvNI4Vo+yO0t5ZLbwCOpPnoaxS2se9tO+coHDG87jHZLScIWz4ZPspGLQarBddNOcfL3Lz8lk9j2+mkgqeNq+53N/7OFRpwAMSlq+b5LD0yFEqD7qt76/0nq4pSg== X-YMail-OSG: AHPddnAVM1l8xBYTSOqI7XgPFVzyAESG1KeVNRI8PixvtK1FiLRk7nbK4A_PgEn BLCWc8JoR_.StaJmZIMmY.sw3sg_tLKoobKKBW8P1GeqFIqrseWuiG0o4yLUW4JYYPIhvuk.uZc0 Hk1pFJyAMpIFYju5ZhBXHGKbjYQgVN3bEa.jYLch8vKyEAgzRd9PvPRwLz6q3dIosCxGseZiM9m4 dDhgTTxMjE0Jv4dPkfEhsw_1a5xw_jenhNZNdSe_WKT39J2Z6ka62kxWi5LN4mkPgSrFU1HtZVKv zDXxQhyMgtzTzlVzFeH.ZfbHAkhffFGeB60vwVVpETIi2aDiy8vRj33BYTPD4dF4VYHzR7nDpaki kiPXO8NwjLb2N46ldMqWFIBdAa8jTC5AVUxA4UTzn22usEZ5Ph5P23bQG3Nu.9P0uLXOvVE0rmOM 61sEVH5kWWzXYkaEvXyLvlT1NSAvC3dsdIp8tLBwDw4BCeOptRmrCVPcDRGyJzU9rQfPovK.vF0r U00Ou8tdxVTHkhoWQPXt4wPgehF5Q08jjO1zWDMLrwdcmR.x8jZmDnyYPIHyMljQL7mPT_SoNoMG nAJY14Y13He20fFFEfXi84iKA4mjMPuhT2_MefO7YBZ5m4izxWwU3YTTuYAO1wojXs7LCPHkFXD4 nPLbGQaA_YH0uRzNjNu6.116QhlTXWZ2YO1vz7mD3Oeb2jiaFOJaUn.oTyW4tbnQ.BmWesNFswS2 tEGG7gErlNHxoWkak9Ohc8IR7p96hjaRFB3GoAwJMtV_FCe_4ZD1Wbd6mdH6Y4YyKpfneN72RZlN 8BuACxEF2IdR_Qk92zgVjbrajGtLdoxcTwxhjgsO9JJiktH4GFdINtSlLTfG.nYpJeps1QtJU14K gcrt5igBLuecNUu0Ullg4dhQE9Z34BLPhSiVTE8PShs4P3oSD5f.x_nS7bz_pLCluTGfcrknoN6N vHyHL3Xr.eMT5wI4eQS9ybVwWsA659elac2g5G1TVYaDt3QwovFpQDf5.UyUWCcD0LSGGGnxjmnH wIMvxDPCiDtcVNSrarB27Yl9Noet4lX3gAlBLrOAnfeSK5cXjrT.7z89NQFBYzpIMjZrISlKbUf. BZ9t7Vday.Od9.j2VktY5Kht3BUpeYyJ.lGRekySFZDPvWDOJKFKIF_wg1eZJqcLeZebgWANgId_ xT_FrPXTjpX90qFuoAQwFgGaH5afyBKrofOdD2rrmSV1wAxcHenEo7ikw51icluxzC5LF5Dt5x0X xOK2IukeDP3vi.YkLbXO2iGk4b2KGxCJMDFQqlyBveWJmRqU_fOwBnya0lsoqC_oTyBQm.4vBAcf .MFJgdDWkV4ibL2ZdLiU_cHJMuzgvxppEWyFxgaxqnKb28Q_pBDEMjbE1bWK8D13SWK81HRv9UY6 QOuLVcr3wbzIOIkjSRUn_k2p.yvuer1gChZUjacgy.33l6zyjHvPtR8iamJMIVKoOSYS3rqCDoG_ 3p1YAAGvI2hA4SZ01dyd._tlC.z9OhecG01cSaxs6AhZs5dQeF_LHbCjHbS_FxLgN7eUqY08rf2b w.osMXh1CxIII1Qee022RydS8Oqs5c.x4JgeDh93iaXv16gJfJa8zltWvZLGsZs_v9Ar3IcFKp9a sFwv7bUFk5Tgc0QhlSqRidL63Twmq0zyYMWJS5eC9CEGglziigamB2zxD3NtbMguEOoLoiPdJ6gD NYK9bH9jO1AUZuO4BOR_IScmJ_asJkpY3qKq1SCeWX3O9bHNoEJ8GKyCq.Vbe6RJUAJNtmdlMjna CB0VhxygN71kb9r1WJxSJZ8vWx6B19b_BQwxbrbL8u01WFdvjN5YuVUWvUiFibm5Nd2oZHCFGEkQ XyF.VJ5VxH6SlxPDYs3.zNsGTBoFarAYday54IXyUcCNOuav5RyGBZMWt8JCgDWOJvuaCdRTzIQL lMWSqubeIPirOU6M7PDaGgZ9dTuBAjEfKGKJzV1_AxIR2Y7qYM.e0lPkS83ui_wztKfzeJfdrwdQ uW9gkcwjEUw6E2UpjoRO73mAT7O9RVutYPAuSwe_M6FZuUJVFo8Qv00wIHw0Ud3BnN4RAcCk5mk. ukrKpv2dDz5ohGmFoeXqN_rAZS7MRheOtpiEni2M8bMwaQc8B0qVJdGDdnHysGJEHG5GUc9nCI2P v3FB6UuMIjIAjDw.yNdy_x1DRIBxM3KPoBS1Kh1r43T3UFlYn3qLBguyprTRyqLzwPCRVTrOwAaC qIGoFyysPGRHRrh46.qdOsuHRwRdYdai3lXEkQVSPrfh72i8mrJNrZrNqqJZNEUw- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sun, 5 Mar 2023 00:07:26 +0000 Received: by hermes--production-sg3-67c57bccff-b6t8r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 937d8c23983ce66d3d624d11b321d907; Sun, 05 Mar 2023 00:07:21 +0000 (UTC) From: Po Lu To: Andrew De Angelis Subject: Re: bug#60703: Patches to xwidget code In-Reply-To: (Andrew De Angelis's message of "Sat, 4 Mar 2023 18:00:03 -0500") References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> <83bklowobq.fsf@gnu.org> <838rgpsue3.fsf@gnu.org> <83fsane7yl.fsf@gnu.org> Date: Sun, 05 Mar 2023 08:07:17 +0800 Message-ID: <875ybguklm.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21221 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 447 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60703-done Cc: Eli Zaretskii , 60703-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrew De Angelis writes: > Awesome, thank you so much! Will keep all your suggestions in mind for my future contributions. > > Small question: what are the criteria to be added to `etc/AUTHORS`? Just wondering if/how my contribution could be mentioned there. AUTHORS is generated automatically prior to each release of Emacs, so you don't have to do anything aside from waiting for Emacs 29.1 to be released. Thanks. From unknown Sat Aug 16 18:47:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Apr 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator