GNU bug report logs - #60660
Support git-formatted patches in diff-mode

Previous Next

Full log

Message #21 received at 60660-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 60660-done <at> debbugs.gnu.org
Subject: Re: bug#60660: Support git-formatted patches in diff-mode
Date: Wed, 10 Jan 2024 14:37:52 -0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Juri Linkov <juri <at> linkov.net> writes:
>
>>>> This patch for emacs-29 fixes this bug, and the rest of fontification
>>>> could be implemented in master.
>>>
>>> OK for the emacs-29 branch
>>
>> Pushed to the emacs-29 branch.
>
> So is there more to do here, or should this bug be closed?  I'm not sure
> if it's still needed to track the below.
>
>>> (although I'm surprised that diff-beginning-of-hunk can return
>>> a position that is not before point).
>>
>> Indeed, strange to see this in 'diff-beginning-of-hunk':
>>
>>       (cond ...
>>         ((re-search-backward regexp nil t)) ; In the middle of a hunk.
>>         ((re-search-forward regexp nil t) ; At first hunk header.
>>                     =======
>>
>> Need to experiment more with this in master.

No further comments, so I'm closing this now.  Please reopen if it's
needed to track the above.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.