GNU bug report logs - #60654
30.0.50; tree-sitter: `transpose-sexps-function' uses a lambda in a defvar

Previous Next

Package: emacs;

Reported by: Mickey Petersen <mickey <at> masteringemacs.org>

Date: Sun, 8 Jan 2023 10:47:02 UTC

Severity: normal

Found in version 30.0.50

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60654 in the body.
You can then email your comments to 60654 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#60654; Package emacs. (Sun, 08 Jan 2023 10:47:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mickey Petersen <mickey <at> masteringemacs.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 08 Jan 2023 10:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mickey Petersen <mickey <at> masteringemacs.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; tree-sitter: `transpose-sexps-function' uses a lambda in a
 defvar
Date: Sun, 08 Jan 2023 10:46:03 +0000

The defvar `transpose-sexps-function' holds on to a lambda function. Would it be possible to make it an actual function? Its purpose is rather important as it is the default transposition function that was moved out of `transpose-sexps'. Being able to reliably access it when `transpose-sexps-function' is overriden is useful.


In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.20, cairo version 1.16.0) of 2023-01-02 built on mickey-work
Repository revision: c209802f7b3721a1b95113290934a23fee88f678
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Ubuntu 20.04.3 LTS

Configured using:
 'configure --with-native-compilation --with-json --with-mailutils
 --without-compress-install --with-imagemagick CC=gcc-10'
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60654; Package emacs. (Mon, 09 Jan 2023 03:40:02 GMT) Full text and rfc822 format available.

Message #8 received at 60654 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Mickey Petersen <mickey <at> masteringemacs.org>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 60654 <at> debbugs.gnu.org
Subject: Re: bug#60654: 30.0.50; tree-sitter: `transpose-sexps-function'  uses
 a lambda in a defvar
Date: Sun, 8 Jan 2023 19:39:34 -0800

Mickey Petersen <mickey <at> masteringemacs.org> writes:

> The defvar `transpose-sexps-function' holds on to a lambda function.
> Would it be possible to make it an actual function? Its purpose is
> rather important as it is the default transposition function that was
> moved out of `transpose-sexps'. Being able to reliably access it when
> `transpose-sexps-function' is overriden is useful.

CC’d Theo.

Yuan
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60654; Package emacs. (Mon, 09 Jan 2023 06:24:01 GMT) Full text and rfc822 format available.

Message #11 received at 60654 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>, Mickey Petersen <mickey <at> masteringemacs.org>
Cc: 60654 <at> debbugs.gnu.org
Subject: Re: bug#60654: 30.0.50; tree-sitter: `transpose-sexps-function'  uses a lambda in a defvar
Date: Mon, 09 Jan 2023 07:23:33 +0100


On 9 January 2023 04:39:34 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>
>Mickey Petersen <mickey <at> masteringemacs.org> writes:
>
>> The defvar `transpose-sexps-function' holds on to a lambda function.
>> Would it be possible to make it an actual function? Its purpose is
>> rather important as it is the default transposition function that was
>> moved out of `transpose-sexps'. Being able to reliably access it when
>> `transpose-sexps-function' is overriden is useful.
>
>CC’d Theo.
>
>Yuan

Thanks yuan.

Yeah I'll make this change and call the new function transpose-sexps-default-function.

Apologies for any inconvenience :)

Theo
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60654; Package emacs. (Mon, 09 Jan 2023 06:58:02 GMT) Full text and rfc822 format available.

Message #14 received at 60654 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>, Mickey Petersen <mickey <at> masteringemacs.org>
Cc: 60654 <at> debbugs.gnu.org
Subject: Re: bug#60654: 30.0.50; tree-sitter: `transpose-sexps-function'
 uses a lambda in a defvar
Date: Mon, 09 Jan 2023 07:57:11 +0100

[Message part 1 (text/plain, inline)]
Theodor Thornhill <theo <at> thornhill.no> writes:

> On 9 January 2023 04:39:34 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>>
>>Mickey Petersen <mickey <at> masteringemacs.org> writes:
>>
>>> The defvar `transpose-sexps-function' holds on to a lambda function.
>>> Would it be possible to make it an actual function? Its purpose is
>>> rather important as it is the default transposition function that was
>>> moved out of `transpose-sexps'. Being able to reliably access it when
>>> `transpose-sexps-function' is overriden is useful.
>>
>>CC’d Theo.
>>
>>Yuan
>
> Thanks yuan.
>
> Yeah I'll make this change and call the new function transpose-sexps-default-function.
>
> Apologies for any inconvenience :)
>
> Theo 


How about this, Mickey.  Is this something you can work with?

Theo


[0001-Add-named-defun-for-transpose-sexps-default-function.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60654; Package emacs. (Mon, 09 Jan 2023 08:49:02 GMT) Full text and rfc822 format available.

Message #17 received at 60654 <at> debbugs.gnu.org (full text, mbox):

From: Mickey Petersen <mickey <at> masteringemacs.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: Yuan Fu <casouri <at> gmail.com>, 60654 <at> debbugs.gnu.org
Subject: Re: bug#60654: 30.0.50; tree-sitter: `transpose-sexps-function'
 uses a lambda in a defvar
Date: Mon, 09 Jan 2023 08:47:32 +0000

Theodor Thornhill <theo <at> thornhill.no> writes:

> Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> On 9 January 2023 04:39:34 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>>>
>>>Mickey Petersen <mickey <at> masteringemacs.org> writes:
>>>
>>>> The defvar `transpose-sexps-function' holds on to a lambda function.
>>>> Would it be possible to make it an actual function? Its purpose is
>>>> rather important as it is the default transposition function that was
>>>> moved out of `transpose-sexps'. Being able to reliably access it when
>>>> `transpose-sexps-function' is overriden is useful.
>>>
>>>CC’d Theo.
>>>
>>>Yuan
>>
>> Thanks yuan.
>>
>> Yeah I'll make this change and call the new function transpose-sexps-default-function.
>>
>> Apologies for any inconvenience :)
>>
>> Theo
>
>
> How about this, Mickey.  Is this something you can work with?
>

Looks perfect. Nice one, Theo.

Kind regards,

Mickey.

> Theo
>
> [2. text/x-patch; 0001-Add-named-defun-for-transpose-sexps-default-function.patch]...
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#60654; Package emacs. (Mon, 09 Jan 2023 12:21:04 GMT) Full text and rfc822 format available.

Message #20 received at 60654 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Mickey Petersen <mickey <at> masteringemacs.org>
Cc: Yuan Fu <casouri <at> gmail.com>, 60654 <at> debbugs.gnu.org
Subject: Re: bug#60654: 30.0.50; tree-sitter: `transpose-sexps-function'
 uses a lambda in a defvar
Date: Mon, 09 Jan 2023 13:20:12 +0100

Mickey Petersen <mickey <at> masteringemacs.org> writes:

> Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> Theodor Thornhill <theo <at> thornhill.no> writes:
>>
>>> On 9 January 2023 04:39:34 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>>>>
>>>>Mickey Petersen <mickey <at> masteringemacs.org> writes:
>>>>
>>>>> The defvar `transpose-sexps-function' holds on to a lambda function.
>>>>> Would it be possible to make it an actual function? Its purpose is
>>>>> rather important as it is the default transposition function that was
>>>>> moved out of `transpose-sexps'. Being able to reliably access it when
>>>>> `transpose-sexps-function' is overriden is useful.
>>>>
>>>>CC’d Theo.
>>>>
>>>>Yuan
>>>
>>> Thanks yuan.
>>>
>>> Yeah I'll make this change and call the new function transpose-sexps-default-function.
>>>
>>> Apologies for any inconvenience :)
>>>
>>> Theo
>>
>>
>> How about this, Mickey.  Is this something you can work with?
>>
>
> Looks perfect. Nice one, Theo.
>
> Kind regards,
>
> Mickey.
>

Great! Yuan, can you install for me?

Theo
Reply sent to Yuan Fu <casouri <at> gmail.com>:
You have taken responsibility. (Mon, 09 Jan 2023 20:36:02 GMT) Full text and rfc822 format available.
Notification sent to Mickey Petersen <mickey <at> masteringemacs.org>:
bug acknowledged by developer. (Mon, 09 Jan 2023 20:36:02 GMT) Full text and rfc822 format available.

Message #25 received at 60654-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 60654-done <at> debbugs.gnu.org, Mickey Petersen <mickey <at> masteringemacs.org>
Subject: Re: bug#60654: 30.0.50; tree-sitter: `transpose-sexps-function'  uses
 a lambda in a defvar
Date: Mon, 9 Jan 2023 12:35:20 -0800

Theodor Thornhill <theo <at> thornhill.no> writes:

> Mickey Petersen <mickey <at> masteringemacs.org> writes:
>
>> Theodor Thornhill <theo <at> thornhill.no> writes:
>>
>>> Theodor Thornhill <theo <at> thornhill.no> writes:
>>>
>>>> On 9 January 2023 04:39:34 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>>>>>
>>>>>Mickey Petersen <mickey <at> masteringemacs.org> writes:
>>>>>
>>>>>> The defvar `transpose-sexps-function' holds on to a lambda function.
>>>>>> Would it be possible to make it an actual function? Its purpose is
>>>>>> rather important as it is the default transposition function that was
>>>>>> moved out of `transpose-sexps'. Being able to reliably access it when
>>>>>> `transpose-sexps-function' is overriden is useful.
>>>>>
>>>>>CC’d Theo.
>>>>>
>>>>>Yuan
>>>>
>>>> Thanks yuan.
>>>>
>>>> Yeah I'll make this change and call the new function transpose-sexps-default-function.
>>>>
>>>> Apologies for any inconvenience :)
>>>>
>>>> Theo
>>>
>>>
>>> How about this, Mickey.  Is this something you can work with?
>>>
>>
>> Looks perfect. Nice one, Theo.
>>
>> Kind regards,
>>
>> Mickey.
>>
>
> Great! Yuan, can you install for me?
>
> Theo

Sure, I applied it to trunk.

Yuan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 07 Feb 2023 12:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 190 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.