From unknown Sat Jun 21 03:22:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60640 <60640@debbugs.gnu.org> To: bug#60640 <60640@debbugs.gnu.org> Subject: Status: Gnu: Add gdcm Reply-To: bug#60640 <60640@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:22:52 +0000 retitle 60640 Gnu: Add gdcm reassign 60640 guix-patches submitter 60640 Tor-bj=C3=B6rn Claesson severity 60640 normal tag 60640 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 07 20:22:30 2023 Received: (at submit) by debbugs.gnu.org; 8 Jan 2023 01:22:31 +0000 Received: from localhost ([127.0.0.1]:59404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEKOM-0003NK-FG for submit@debbugs.gnu.org; Sat, 07 Jan 2023 20:22:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:46254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEF5L-0005zR-3f for submit@debbugs.gnu.org; Sat, 07 Jan 2023 14:42:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEF5K-0007Xg-V1 for guix-patches@gnu.org; Sat, 07 Jan 2023 14:42:30 -0500 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEF5J-0006dC-8v for guix-patches@gnu.org; Sat, 07 Jan 2023 14:42:30 -0500 Received: by mail-lf1-x12e.google.com with SMTP id bu8so6841193lfb.4 for ; Sat, 07 Jan 2023 11:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=WOflghYWxO2QAkOfDKFWzbK4LOLT2l/uVh3lZmbdUnI=; b=Zv/Ia/38fnwU8H1rIYs/Uya8sKTcOkoUBHW3ANn5cccOeA5vO/ZrRrmTKn4nWHGNfF F8zeSlOZoKWzhSFnil8xaDQtkv4O/3FLTJqp7z39FQen9J/eObRIHVacHG7l3Piqm1Sq 92YIs11JzCmavy3Y5XHsW2gvImez1/VKIih+VPy4cuxi3s0piZSnTDKYX/s0TE3oRIwl JH9T78z7mRKuDSrHlSCtBrPFVGidwz7yu1ILep6X6K/BPGOkJoDciTkHtWF4y7TscJQN OqDDDl69g4qtSuyPu64zJZ0w1Ytm90dY0drwJhD9yxq6hvkmARV2c1baL9oNR+8K+aXM a+zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WOflghYWxO2QAkOfDKFWzbK4LOLT2l/uVh3lZmbdUnI=; b=LG+fSM8zYUHZBhRTy9ND9dKYjvj9ZdtAxcFs/tFRy5FePxIoc381rVp03fcSsyvDDU fatdc+mx86yirhXxf6Mew2gg+NqUm/y6WSh0oTDqV1mhIyNmSeh8Msm/OgSlkzlD0xmb AeYIgP8Owdvr+jdiQSqKmHd1L9rxHjk7fb+pvJWUkgzR1Z3PvoFwLiUstRESqzvnbWJA Lzd4b0xCqhMac5j1UK0bl7Dpw8hzdwwMolcu2JdhgkqeAYPBgMnkswqCDGNm85BaB/tF XEtjvMRozg9NsimHp1q169KCv2ZjZbmhy/fgjQTJ4E91iOEuysVlKsgojHyvgkpCefQ7 Ay1w== X-Gm-Message-State: AFqh2kqRvsRxzJqu2yNTzRwZV/GDbTip2WRt6ZWXopQ+esQ6xOwBxTk6 /O3AtrHdHFyvyT0Tt3gx3Dj+/NJLpBI= X-Google-Smtp-Source: AMrXdXtPJsls9He0GH4aVit+pDXhkRA/5YKwJ9ryQ02Lm0Oa6cysPeF7XsvF2llghaNJsNycvFl5Xg== X-Received: by 2002:a05:6512:3b87:b0:4a4:68b7:d623 with SMTP id g7-20020a0565123b8700b004a468b7d623mr19607866lfv.10.1673120546284; Sat, 07 Jan 2023 11:42:26 -0800 (PST) Received: from barbar (212-90-81-204.bb.dnainternet.fi. [212.90.81.204]) by smtp.gmail.com with ESMTPSA id m3-20020a056512114300b004cb454bf010sm703864lfg.267.2023.01.07.11.42.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 11:42:25 -0800 (PST) User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: guix-patches@gnu.org Subject: Gnu: Add gdcm Date: Sat, 07 Jan 2023 21:40:42 +0200 Message-ID: <877cxyp1wf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=tclaesson@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 07 Jan 2023 20:22:26 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) gnu/packages/image-processing.scm | 72 +++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm index 70c820e76b..271593b5f9 100644 --- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -99,6 +99,7 @@ (define-module (gnu packages image-processing) #:use-module (gnu packages tls) #:use-module (gnu packages version-control) #:use-module (gnu packages video) + #:use-module (gnu packages web) #:use-module (gnu packages xiph) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) @@ -1776,3 +1777,74 @@ (define-public charls to have them encoded to JPEG-LS, or JPEG-LS streams, which CharLS will decode to images.") (license license:bsd-3))) + +(define-public gdcm + (package + (name "gdcm") + (version "3.0.20") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/malaterre/GDCM/") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) + (build-system cmake-build-system) + (outputs '("out" "doc")) + (arguments + (list #:tests? #f + #:phases #~(modify-phases %standard-phases + (add-before 'configure 'set-LDFLAGS + (lambda* (#:key inputs outputs #:allow-other-keys) + (setenv "LDFLAGS" + (string-append "-Wl,-rpath=" + #$output "/lib")))) + (add-before 'build 'patch-gdcm-charls.h + (lambda _ + (substitute* "../source/Utilities/gdcm_charls.h" + (("# include ") + "# include ")) #t))) + #:configure-flags #~(list "-DCMAKE_SKIP_RPATH:BOOL=YES" + "-DCMAKE_BUILD_TYPE:STRING=Release" + "-DCMAKE_C_FLAGS=-fvisibility=hidden" + "-DCMAKE_CXX_FLAGS=-fvisibility=hidden" + "-DGDCM_BUILD_SHARED_LIBS:BOOL=ON" + "-DGDCM_DOCUMENTATION:BOOL=ON" + "-DGDCM_USE_SYSTEM_EXPAT:BOOL=ON" + "-DGDCM_USE_SYSTEM_ZLIB:BOOL=ON" + "-DGDCM_USE_SYSTEM_CHARLS:BOOL=ON" + "-DGDCM_USE_SYSTEM_POPPLER:BOOL=ON" + "-DGDCM_USE_SYSTEM_LIBXML2:BOOL=ON" + "-DGDCM_USE_SYSTEM_JSON:BOOL=ON" + "-DGDCM_USE_SYSTEM_UUID:BOOL=ON" + "-DGDCM_USE_SYSTEM_OPENJPEG:BOOL=ON" + "-DGDCM_USE_SYSTEM_OPENSSL:BOOL=ON" + "-DGDCM_PDF_DOCUMENTATION:BOOL=OFF" + "-DGCM_BUILD_TESTING:BOOL=OFF" + "-DGDCM_BUILD_APPLICATIONS:BOOL=OFF" + "-DGDCM_USE_SYSTEM_PAPYRUS3:BOOL=OFF" + "-DGDCM_USE_SYSTEM_SOCKETXX:BOOL=OFF" + "-DGDCM_USE_SYSTEM_LJPEG:BOOL=OFF"))) + (inputs (list openssl + expat + charls + poppler + libxml2 + json-c + openjpeg + `(,util-linux "lib") + zlib)) + (native-inputs (list git pkg-config doxygen graphviz)) + (home-page "https://gdcm.sourceforge.net") + (synopsis + "C++ library dedicated to reading/parsing and writing DICOM medical files") + (description + "Grassroots DICOM (GDCM) is an implementation of the DICOM standard +designed to be open source so that researchers may access clinical data +directly. GDCM includes a file format definition and a network communications +protocol, both of which should be extended to provide a full set of tools for +a researcher or small medical imaging vendor to interface with an existing +medical database.") + (license license:bsd-3))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 03:00:24 2023 Received: (at 60640) by debbugs.gnu.org; 8 Jan 2023 08:00:24 +0000 Received: from localhost ([127.0.0.1]:59778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEQbP-0007xH-OB for submit@debbugs.gnu.org; Sun, 08 Jan 2023 03:00:23 -0500 Received: from mail-lf1-f52.google.com ([209.85.167.52]:35638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEQbN-0007wz-Q7 for 60640@debbugs.gnu.org; Sun, 08 Jan 2023 03:00:22 -0500 Received: by mail-lf1-f52.google.com with SMTP id b3so8392604lfv.2 for <60640@debbugs.gnu.org>; Sun, 08 Jan 2023 00:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=7mSHjw9ZSC/30jyZhhJGniKofGBedtW+mcpvWUPkm6I=; b=CDU/nK81XAQfchEHenIkydgWwVozkMRjdR+67Pms4C2yS61CeuQ2RXsCxU5xrSi6NT hqWN3ne2EVwBlMIgqsuN063cTTZXboN9mj5+tlteZZfdx7G2Dudc1jYD0uwnqwp8zMxg FwHri805I5sR4fAH3MOqF+s1+gBFywzK3p6q4+ASm5VcVkw6MkBJFbkFoJwvo5cG7R2C 5kj0tJO1/zs3wlfAmoSMLPOBuvzWq+cV7EWrWXecipUq1vwgfYRJZNuQZR2v4EqnbwTc 3ETTMXT1Mjn8rFRI3S+2jX8nXZjYnHUfME0SmETbDqn6L+xLsOWxV8Qnvx6+2lezmA5g 1RkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:to:from:user-agent:references:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7mSHjw9ZSC/30jyZhhJGniKofGBedtW+mcpvWUPkm6I=; b=4u3Uk0jSGqkMDM7sQbpEBTFiI0tZdePyGDZUXV8ukBgiFybGWwW0BIGWe11zww6dVi 6cJOo9o74fo2nP+xXMaofhMfoKBQY0aGX4edahbCZj/DuBZ2x86iIz78aLdWigx0RwL+ vZGyNP59lQcW8sIqVEUU3ljmX0Tsk9GTDp3hxfFAjyrMcb5fvJR7/xk97GjGDvCZ95SO HTwUGRliwwlp+dZB8oD1g+nDnaqbyHa1toyiN9/tOJDoBiwTO4+rZ9Vc7IOd8lXw/yt6 3ubvOcCdHkyAq4d63MYYClChCmjhCFtEQX5dsUmgcfPX7WBeFAyY8YbgkCk0/8GlVFQO JcCg== X-Gm-Message-State: AFqh2krqURgNr5GMCdrDpgRno1LxdAXbHT0jVT89MMn5Z1y26gLHlQZQ UpzYYvZzdThkJPRRoFLFzj0mFlEuhRs= X-Google-Smtp-Source: AMrXdXv1OlmizYpDWdUAJvhxCWflE6Au1Z1ctCOKNODPiWM5tGvfN6BqsU34Laov5iy+9ozsoFpygg== X-Received: by 2002:ac2:53a3:0:b0:4bc:4ad0:4142 with SMTP id j3-20020ac253a3000000b004bc4ad04142mr19150052lfh.58.1673164815280; Sun, 08 Jan 2023 00:00:15 -0800 (PST) Received: from barbar (212-90-81-204.bb.dnainternet.fi. [212.90.81.204]) by smtp.gmail.com with ESMTPSA id dt17-20020a0565122a9100b004cb061887b5sm943798lfb.126.2023.01.08.00.00.14 for <60640@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 00:00:14 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: 60640@debbugs.gnu.org Subject: Re: bug#60640: Acknowledgement (Gnu: Add gdcm) Date: Sun, 08 Jan 2023 09:59:40 +0200 In-reply-to: Message-ID: <87y1qdo3qq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! This patch adds GDCM (a nice C++ library for DICOM, as in medical imaging), with a few wharts: 1. I have not yet been able to build the bin output, which consists of utilities for manipulating DICOM data.=20 2. It does not build pdf-documentation, since that would require texlive as a native input. 3. It does not perform tests. 4. It uses socketxx, ljpeg and papyrus3 from the gdcm sources.=20 5. I'm not sure how to specify util-linux:bin as an input? Cheers, Tor-bj=C3=B6rn Claesson help-debbugs@gnu.org (GNU bug Tracking System) writes: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > guix-patches@gnu.org > > If you wish to submit further information on this problem, please > send it to 60640@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. --=20 Mvh, Tor-bj=C3=B6rn Claesson From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 03:05:00 2023 Received: (at 60640) by debbugs.gnu.org; 8 Jan 2023 08:05:00 +0000 Received: from localhost ([127.0.0.1]:59784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEQfs-000845-DD for submit@debbugs.gnu.org; Sun, 08 Jan 2023 03:05:00 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:34436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEQfq-00083r-DK for 60640@debbugs.gnu.org; Sun, 08 Jan 2023 03:04:58 -0500 Received: by mail-ed1-f48.google.com with SMTP id z11so8146365ede.1 for <60640@debbugs.gnu.org>; Sun, 08 Jan 2023 00:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=9htsSlwYTd+xqIFDMVWMmSvIRSdxlqs84rDd72pbkvg=; b=hl2Xq0I5QFAtJe61708awNgbhB1MWUjEKupKNH2YuZBEP9ISQW5bgBPLav5+WgHQTW exWxreObwAIxnUhjJTIs1NYd9VmX3VmbBpFkZrXnemQcjwYgCUq6yuj3Uy+19Y0t6Vkj RIqcpNHq8jYumbhOBvHXb8Ut5tM8REQ1EMu3rGrXar95K3MuR5nwjYJPxCpRZ65CY/1q eCUgQJsYP1NGLOCl1ba2oMu/kIfbx0VPrLNqGF7Zh0qF9Phdab7SqmaIvBgGd3vChHKC o4T9MvSyS7BjcIvHMSbx14wnykBp7iwcbzLoyB1hOIiL4feeE9Orhcvrtd22F6tJTIJv 2haw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9htsSlwYTd+xqIFDMVWMmSvIRSdxlqs84rDd72pbkvg=; b=NqrbH+F/w42krUDgNePghe0sQwy0IOsmG2M277MbvGFFflu9CNkD383Tb7QxMn9MOY U/wdW1QAfyqlYK8eXJR2KDjA1sqeNGjPRP+2y6O9QlnlOylqyefwc3ZdAonQa/bIB4E1 VVcreAMWt/Ed5RHts+iCwK3IXLdZAaXx6M3IpRNqgjDYmqyx4jIQ1duhzbYiML4JAuU/ V9N+8+bgONyUGwd61yH+A0OxxsDcOmzNPZBFpYpZ4x0Rg1plmMT8wPhHWg63KXCxtg8F 9RrY+Hn5iDjHfJ8O8C4rfbg4Q7HaoCHMftr9pnJbaCBVS/fCGIlyS812W18mo/IUYQKi XBmw== X-Gm-Message-State: AFqh2koZ+OAfa0xmoFPi2WM/il1jCPNEWlxLvI3d7jcj+K8uF6X8kBj3 5bH4l4w/+EsB4SduKWcBoVABgS157Fb/F1dSh8XugddQ X-Google-Smtp-Source: AMrXdXu1u05oDkPkmeB74jpEFe3PfQtcGj5W3eCnRu3U/N1fHYuNZFbL+F0tdY//RSU+FIOqb3tbnmxFgHm98FfjZJc= X-Received: by 2002:a50:8710:0:b0:47d:de33:4a6e with SMTP id i16-20020a508710000000b0047dde334a6emr5941381edb.101.1673165092164; Sun, 08 Jan 2023 00:04:52 -0800 (PST) MIME-Version: 1.0 References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> In-Reply-To: <87y1qdo3qq.fsf@gmail.com> From: =?UTF-8?Q?Tor=2Dbj=C3=B6rn_Claesson?= Date: Sun, 8 Jan 2023 10:04:40 +0200 Message-ID: Subject: Re: bug#60640: Acknowledgement (Gnu: Add gdcm) To: 60640@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000f8186d05f1bc1ad1" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f8186d05f1bc1ad1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Den s=C3=B6n 8 jan. 2023 kl 10:00 skrev Tor-bj=C3=B6rn Claesson : > > 5. I'm not sure how to specify util-linux:bin as an input? > I mean util-linux:lib... --000000000000f8186d05f1bc1ad1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
Den s=C3=B6n 8 jan. 2023 kl 10:00 skr= ev Tor-bj=C3=B6rn Claesson <tclae= sson@gmail.com>:

5. I'm not sure how to specify util-linux:bin as an input?
I mean util-linux:lib...
--000000000000f8186d05f1bc1ad1-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 03:28:38 2023 Received: (at submit) by debbugs.gnu.org; 9 Jan 2023 08:28:38 +0000 Received: from localhost ([127.0.0.1]:35714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEnWI-0005Dp-CU for submit@debbugs.gnu.org; Mon, 09 Jan 2023 03:28:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:34380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEnWF-0005Dg-8B for submit@debbugs.gnu.org; Mon, 09 Jan 2023 03:28:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEnWE-00034q-TR for guix-patches@gnu.org; Mon, 09 Jan 2023 03:28:34 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEnWC-00037r-OL for guix-patches@gnu.org; Mon, 09 Jan 2023 03:28:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=B1ZF9U+Nq4azf FkD6bgXOdySfIp6tRD6Sea5/g2qfkw=; h=references:in-reply-to:subject:to: from:date; d=tobias.gr; b=CnUMLte1pdiJaupN4Gsb1GDpoxEajaBxXf6UnVmbQPbi Ycf9W7FlssNbhtEc8qZ6mDnDDgi6uaGtwdDi9ukS1nlmFlx2unvgZbXwJS1JdB+eaGd8bE qcSX7zmKUj37vFWKl0ZPWFE+XJ+H/9z0U8c0gzck9V2rb6dUxEjTcEZP/4D9qHaa4TlfJY B3I+cXv7zfondWYKkCUZZv1XLSc4bZE3BRZGvrIVVREEP58oFBK9h6jOJ/+gJNwyX9MCl/ P2IF0V/XJQJaoIsLpmkrt+wmWlyrpLNDBQw6FI8cvcs84vEQ9fXYRyC2Zo2n2zoi83SmrD AfZWGv/LCdavrpyhKQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ec14ad08 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 9 Jan 2023 08:28:23 +0000 (UTC) Date: Mon, 09 Jan 2023 08:28:29 +0000 From: Tobias Geerinckx-Rice To: guix-patches@gnu.org, =?ISO-8859-1?Q?Tor-bj=F6rn_Claesson?= , 60640@debbugs.gnu.org Subject: Re: [bug#60640] Acknowledgement (Gnu: Add gdcm) In-Reply-To: References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> Message-ID: <604C2BA9-1D59-4560-BE33-285FB879C3AA@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=me@tobias.gr; prefer-encrypt=mutual; keydata= mQINBFVks2ABEACjGBPhWf/qx0L9OhEIrAFTimo5dHa1FLy0AHaHvxmwYSIdJmERYGiNle1rcOvw cFRtu8KJUsrs27Vgoso3qHJpghVitUUf0v3ZuXQT9kfuQLz1Y8pyMzHwVFMLiJVj4Z3y7CJk+xyZ cpSAMbyPINbFVEhsK+z+8ojVGuaiucZkib6b67ySG6Pp1bon8xVvosj71ZRjfXh1t4X8laWO7fQq itT9lmc6DxbE/4vIhR+Vb2MblaA+DyHoNHGGao89h4CO99lfzWzsux41DnEG9d317sJRQTig6Wja EKHXZRA9FbfogD4SDa2uQYCpTJpsVjAyZyu2fuJ+t0zJJ+Ai9qDY87P6hOyd+/n8Eh2Y4TbxJiDo XUT72XY/RfPH1qrMIP3EI/NNL4LQeGG1n+625k3OVWcRVXG2vRrB6qurLmGkLEmjXWCFD9cCRGfH LeajLm9sM+t/nZPZ3btetcmK9tM2EwivyLUNhrTk73UUnI4CSAzdO2cISqo9zSMtFgj2alqd2fOR s7CKfEn+5PquruDbp/Ej7dOOrjgWSCXLDDYXRrtaKrLz/dhqq5ftFYi9tUTTQecFotM08fPtu+Kw JMP2ySHCkUqp0GvrUCeSRPAJZsmJrd535y+LlRhnqb0mbG4dgMa8A6xhkFYugnqldy/q7kX1EmRI 686N7bA6fh1MCQARAQABtCRUb2JpYXMgR2VlcmluY2t4LVJpY2UgPG1lQHRvYmlhcy5ncj6JAlIE EwEKADwCHgECF4ACGQECGwMWIQT1vFU0w28Ah7OdNu8cncT+udt8SwUCXpe0rAYLCQgHCgQFFQoJ CAsFFgMCAQAACgkQHJ3E/rnbfEu5IhAAk+0BW/twLmx1xMmeXn+I7Ne6SG3++0TRBduEaGWV3n59 lX6XPZUQdAPpS4uy0H+c90Owkw+aWUEwfyOWphrxZRtR2cCOP/3Pxj3Vgtz5RkY4u27lMj15jqa/ p7l2l256ZKJOegr9TvOWtkhMp5lxeVHT6f/44Kv/r/8mMCgSnLXYrEWPE462xI+mIJOanHLJb6No f2xLRCvXoLLp7Yejjv1dwOO71R9PMRhtNy46pZM1ylQ++UTkeSocJw4aNtiu0DHOkX9AlNBkutIx x07RpO+MqJKlzzLeQiC/fE5+dR2itRONopwXAqN3MuT7MonQo5XifBn+VK8i9xZWTXZDkWItWtCC 8oIj4zwxwFWiTmMwwSbI3Wdd/11Zw3CLc4Gd0M6NVgvAnuErQXSgr4lrWhZcncvi4L6EJTc9AUSa 8UWPF+S9t+CHTukpJmcYnsccMkOBhT7OZlmWBsylrYK/JTRWqgWSHWdSKmOuLK+MGDneOZEHkEcf jeXRWvmG7MSU5tE/p7NDLIg9vkvhQV9b0q4OtY65uNWbRe2QRJaYMDcYUAeSZzivRa8VaoVen6tb FvH44zpCxubn23ABl9YIzwvJC++r+H2qLdLpy0cfITiZadZ74Ae0aosNw7XARS6OY+A03BfXyPiI 2oW0jf/PdH9sh2mQrQxIQJ5cZz6Z3X20MFRvYmlhcyBHZWVyaW5ja3gtUmljZSAodG9iaWFzLmdy KSA8bWVAdG9iaWFzLmdyPokCNgQwAQoAIBYhBPW8VTTDbwCHs5027xydxP6523xLBQJZUuJkAh0g AAoJEBydxP6523xLwEoP/iaVWdICefmaZ+bkdUg6hwTKxSPlYdLoaCxYI5V2NnZYXG0dy47E7WJP 4EmTDldcne4UG5NyCgXPSMZDNMqcddEMNbmlssTcLKyu6R/VvTcuL3pEhNoLzm9t2IHR/YGAHJIc pyfmJ3amGSlsbo6s6Vv+mbrJTRPIDpLUst/PDoGYihcSKTxoIw8RtNAy+FAliIdJ8ZuPA3BTxQei sQzgWJo68UInvnFp4juq0zupNDqKddemI8kZCRK/fFPBDD71nqiSJjx2tvbjkTiPU9gmTp7Nulgj ZATZIt0pUhn87w15ItzrsiEjTYCMTmHY5wnvyLarFKZLzQjgUJfsbv4WRJRnX0/EEJWMvMtSdtXL fjwTLrSGAr4vh13PMfE6uVkGkeCV/8BfGJqRE4zkI+QOVILw6VSAP6sdtGSGb52bcCuPj7p9zGIB IuKFudT+DzUb5uV2jbahSjJ8X4Ak/ruG2Hv3iICZawDpHV1JDNgY910KNi5T6gFrjFA2G6aiXDCO SlToLPnPBYH85UVOsp2VykE9AREKS7a7o76cibjwBNN+4xJqJRxhs9YH4JKzE3w/ptVnx49QFBGc pjPkzMTs7DtanD8iqL4J6afnycv9KqIlNJONaMHvzxeunV7QCsoF6DdusZJKFMexiDBaOFUmGFFS XfzK2oNjknx1QApyTPvh Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hi Tor-bj=C3=B6rn, On 8 January 2023 08:04:40 UTC, "Tor-bj=C3=B6rn Claesson" wrote: >Den s=C3=B6n 8 jan=2E 2023 kl 10:00 skrev Tor-bj=C3=B6rn Claesson : > >> >> 5=2E I'm not sure how to specify util-linux:bin as an input? >> >I mean util-linux:lib=2E=2E=2E Exactly like you did=2E Are you seeing util-linux-related failures? Kind regards, T G-R Sent on the go=2E Excuse or enjoy my brevity=2E From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 05:53:49 2023 Received: (at 60640) by debbugs.gnu.org; 9 Jan 2023 10:53:49 +0000 Received: from localhost ([127.0.0.1]:35862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEpmm-0002x5-UN for submit@debbugs.gnu.org; Mon, 09 Jan 2023 05:53:49 -0500 Received: from mail-lf1-f48.google.com ([209.85.167.48]:40659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEpmk-0002wo-7X for 60640@debbugs.gnu.org; Mon, 09 Jan 2023 05:53:47 -0500 Received: by mail-lf1-f48.google.com with SMTP id g13so12319147lfv.7 for <60640@debbugs.gnu.org>; Mon, 09 Jan 2023 02:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=S1VC3Gbglq/7BCECC95oUjBGruLTei1CLy9kYQEfORU=; b=NP6Ew0TXLOaLZsezUsInOhIbtNPBVBvCYWBIZVjfASF84eHPUQ24VAb4mDId1+igsn wIxfyBbOTWVvuGD2FDDO3lgYd1t657fn9CWMzG0+9J765oYbeMc8BKYmrbO6vg9KFoDG RdLTAUBZ2j31xmvr8GwbjCCPTSmF1nZZAVCUaCXVR7CQ3WYnjseEhw37+EIhzxlqosoO eHKI1gVaLq5jk2QZmZfvAbm7CO3KqvHt9uPu6bkA1RRuP/SsT2NCU1JSu08sF+7GScAl o3HUn+GsQyujdoyJaEQo/9wO5xOjO/dbGaIOwoOYajj+oXR16HHFDpsUF37fl4rTlp3t PDTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=S1VC3Gbglq/7BCECC95oUjBGruLTei1CLy9kYQEfORU=; b=8SDvDVG5Flg801H2PSYjlh837w075aJ9yCifsPNQr3Mq4h1o4m1iROvPyB1DbR/S+m K4/G5fkj9r0kIVkAsZM7myngFPuVruwe53vUCiBgAlWWlrL8ihb2abdWW+0lm0gvloqW 5QZUnrO15g9kM/z4o9gbTGiwMa5FDU9fpNtsIy6mYdZp/8xilMkDSH//2WId1CDBhEuN 2/FlxdsNdVEXNudMqJ1/mPJNAbPKBuVVKLbVG1lOsbpF2RoVqEYFtqF00zRHh5MB40sq st2KilStsrR3x0EHtCLyWUKvjlj2/tZjno0z5P+0VzMe6HjzEB5nX2zIlCjfOHsnOiJp ctlw== X-Gm-Message-State: AFqh2krFYoCVA+qlZT2uiCoorH66SqrlFlzgbJIbrEm4wroax8u4DFTZ pL1x0JEinP4tF5oWc21ZBB4q5ns/lwk= X-Google-Smtp-Source: AMrXdXttU85prRk4ExFiXL7WAa0naWAA2OX3A1JX8un7h0U6yIt0ei6wYT7guNBg6gwzK4BycC4uAg== X-Received: by 2002:ac2:4f13:0:b0:4b5:b22e:9653 with SMTP id k19-20020ac24f13000000b004b5b22e9653mr16357777lfr.18.1673261619685; Mon, 09 Jan 2023 02:53:39 -0800 (PST) Received: from barbar (212-90-81-204.bb.dnainternet.fi. [212.90.81.204]) by smtp.gmail.com with ESMTPSA id c21-20020ac244b5000000b004cb015794a8sm1558576lfm.109.2023.01.09.02.53.39 for <60640@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 02:53:39 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <604C2BA9-1D59-4560-BE33-285FB879C3AA@tobias.gr> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: 60640@debbugs.gnu.org Subject: Re: [bug#60640] Acknowledgement (Gnu: Add gdcm) Date: Mon, 09 Jan 2023 12:50:32 +0200 In-reply-to: <604C2BA9-1D59-4560-BE33-285FB879C3AA@tobias.gr> Message-ID: <87cz7oc72l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Tobias, thanks for taking the time to comment! Tobias Geerinckx-Rice writes: > Hi Tor-bj=C3=B6rn, > > On 8 January 2023 08:04:40 UTC, "Tor-bj=C3=B6rn Claesson" wrote: >>Den s=C3=B6n 8 jan. 2023 kl 10:00 skrev Tor-bj=C3=B6rn Claesson : >> >>> >>> 5. I'm not sure how to specify util-linux:bin as an input? >>> >>I mean util-linux:lib... > > Exactly like you did. Are you seeing util-linux-related failures? > > > Kind regards, > > T G-R > > Sent on the go. Excuse or enjoy my brevity. No failures, only guix lint tells me "gdcm@3.0.20: label 'util-linux' does not match package name 'util-linux:lib'", so I thought I might be doing something wrong. If not then all fine on that front. --=20 Cheers, Tor-bj=C3=B6rn Claesson From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 02:01:48 2023 Received: (at 60640) by debbugs.gnu.org; 10 Jan 2023 07:01:48 +0000 Received: from localhost ([127.0.0.1]:38600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pF8dn-0002VH-Nl for submit@debbugs.gnu.org; Tue, 10 Jan 2023 02:01:47 -0500 Received: from knopi.disroot.org ([178.21.23.139]:51818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pF8dl-0002V6-MH for 60640@debbugs.gnu.org; Tue, 10 Jan 2023 02:01:46 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 4B924409EE; Tue, 10 Jan 2023 08:01:44 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gFL0XzrCqYRr; Tue, 10 Jan 2023 08:01:43 +0100 (CET) Content-Type: multipart/signed; boundary=ed3932af558e7c8e83140b5f95bc497c3c8dfdf394716b5c117c3ea1159c; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1673334103; bh=jCrH2o3x00+DOTudI5EfOP8v081TnaYl5BSscpTe0A8=; h=Date:Subject:From:To:References:In-Reply-To; b=j9AwbPrPUy7b/oTaRPNCZFCiO0+lMR7jX89Ww1ILWBaZLT7H5o2MgXKmVccJ88SHq G9Nlo7rIobQYD3lrwOqehpTi0iFbQuUzu3vIk1DijjXzDR3GjRY4RnMJ3I8aALcdts 2wexOZre2FCC/8dNhHCI4EGWUTRkgfv5i6PZBWP+3WXsV19v+LPtpxq4u3VBOB/szg e3ZPstTXr0EswIjRDvzcB5QO8qyOSvHrOj3YL4AYbM1EjajlLlP7UgOjNfywEFC/Bm ub5VCX75ycZoyaeD8lctjjGpTVvw1UIN8ALUCSST62lbUipg46y9ODQCUDn3dexGc/ KVC/6WTaDRaAw== Date: Tue, 10 Jan 2023 07:01:42 +0000 Message-Id: Subject: Re: [bug#60640] Acknowledgement (Gnu: Add gdcm) From: "(" To: =?utf-8?q?Tor-bj=C3=B6rn_Claesson?= , <60640@debbugs.gnu.org> References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <604C2BA9-1D59-4560-BE33-285FB879C3AA@tobias.gr> <87cz7oc72l.fsf@gmail.com> In-Reply-To: <87cz7oc72l.fsf@gmail.com> X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 60640 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --ed3932af558e7c8e83140b5f95bc497c3c8dfdf394716b5c117c3ea1159c Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Jan 9, 2023 at 10:50 AM GMT, Tor-bj=C3=B6rn Claesson wrote: > No failures, only guix lint tells me "gdcm@3.0.20: label 'util-linux' > does not match package name 'util-linux:lib'", so I thought I might be > doing something wrong. If not then all fine on that front. Oh, that's fine. I don't think there's a way to fix that at the moment. -- ( --ed3932af558e7c8e83140b5f95bc497c3c8dfdf394716b5c117c3ea1159c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmO9DVcACgkQ7ImHg/nq I23RTwwAuwYIObEwRpWW6dd5eObVhWFru81e3OkPnR2vt7mWL7Rn08jUwzbRJdFG g0+JoSqJdF2H3kylQCN4YlaYu/AV9co/jrFwGWF8nYpSTWk60fXn2pFlbuvdgfzZ GsJ9ZQ4a7cBIcf4Xw0DnhP4tZ6iYHYAV/IhajQLb8u3Q5TZ9E+/Im3+JMl0duLdk qyAEw1L9kGkYJD0sbFIYmW4ZeeCxoB8Yqk1Z9/feNizgoPQcfyKv5UymeXCjxP8c KCGr2y4il6epY7D9rGyiBajKQ2tLZouMCQujZggioKqssbSH7L6+Z/O2Qz3nV3Rd yLdvybU1Pe7IH+XPxTlaKC882SnYb5mr6T03Si2pcuX4eJ2JIsCRlqtJwwRNzy/G ug5ylSft6FfVAQHrnBnQaDO/q8txIXrexIidD+gmzTj5Tl/zrLtPi4cnfNTtuqVG OdW1lnJjvV7SKJanaMmroJwDAa5OK6n0U02vLVnqfZO0+Oo/3U5Wj+uX5rLasLJd wJVVRFZi =KZEg -----END PGP SIGNATURE----- --ed3932af558e7c8e83140b5f95bc497c3c8dfdf394716b5c117c3ea1159c-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 09:42:34 2023 Received: (at submit) by debbugs.gnu.org; 10 Jan 2023 14:42:34 +0000 Received: from localhost ([127.0.0.1]:39209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFFpi-0007Rr-0g for submit@debbugs.gnu.org; Tue, 10 Jan 2023 09:42:34 -0500 Received: from lists.gnu.org ([209.51.188.17]:50756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFFpg-0007Rc-Gd for submit@debbugs.gnu.org; Tue, 10 Jan 2023 09:42:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFFpV-0003gu-Tp for guix-patches@gnu.org; Tue, 10 Jan 2023 09:42:21 -0500 Received: from tobias.gr ([80.241.217.52]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFFpU-00032x-En for guix-patches@gnu.org; Tue, 10 Jan 2023 09:42:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=/GmR/vfYpXtr4 NjqzIKCTgzubPi/P4Wy/0cxmeXUrpA=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=Stu7BMLIzUoEuXabGK+d0mDS76RF1a9IAvcnK/ FyMdr2a/ScdBq0PGto7waH+hqa4owFJslamE//IWwoKT5PpEGjvwgcAinZL/5z6uwqjxVk hE/3rLaT+PQAHV+E9WlU/UbHbLHcBFRN8MVi09qzXMngmscv+ZYKnKOvyed9iYzH+fxf+E RnxtYhQiHbIGoC5SmgEaF6bVgYmyhvlb+gnoqyWUIMgh2TIkfwt0Pq0QRssKKq8jg0f0Yi RLkhrW/pC/D5zTSeIDONuG0ipzH/Dyebsh5QeYu6ECnFstc8D0MW9YkLfSylQqBbDZvHfJ v/iwzz7XInPHXB0rRqXW23sQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 1c724d1c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 10 Jan 2023 14:42:10 +0000 (UTC) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> From: Tobias Geerinckx-Rice To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: [bug#60640] Acknowledgement (Gnu: Add gdcm) Date: Tue, 10 Jan 2023 15:40:50 +0100 In-reply-to: <87y1qdo3qq.fsf@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87a62q1mca.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=80.241.217.52; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 60640@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi again, Tor-bj=C3=B6rn Claesson =E5=86=99=E9=81=93=EF=BC=9A > This patch adds GDCM (a nice C++ library for DICOM, as in=20 > medical imaging), > with a few wharts: I'll answer your questions later, but have started the build=20 before I go out. The build appears to be running something like until fc-something; do :; done in an infinite loop, spamming the build log at best and slowing=20 down the build at worst. Did you notice that too? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY715pQ0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15gaQBAI8MpZ0upjkClTQxcOnUeGB6B6RADv70GT7BAjbl stdTAP9vG1MdAKL1lRJ9GhnrXLintk6Qt/TR9+1uJDER42a8BQ== =ZPxT -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 10:10:58 2023 Received: (at submit) by debbugs.gnu.org; 10 Jan 2023 15:10:58 +0000 Received: from localhost ([127.0.0.1]:40898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFGGx-0000BK-9b for submit@debbugs.gnu.org; Tue, 10 Jan 2023 10:10:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:37998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFGGv-0000B3-RP for submit@debbugs.gnu.org; Tue, 10 Jan 2023 10:10:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFGGk-0006zN-1m for guix-patches@gnu.org; Tue, 10 Jan 2023 10:10:31 -0500 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFGGi-0001rm-JH for guix-patches@gnu.org; Tue, 10 Jan 2023 10:10:29 -0500 Received: by mail-ej1-x62d.google.com with SMTP id fc4so29394306ejc.12 for ; Tue, 10 Jan 2023 07:10:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0XAcTwNAjs4laFoKvc5Fb9Z/bZOpbMEKQfuLjjQGHiQ=; b=GzLmQ7YWjjIK2Uw/ABtduYvXlTlTLUZQW94L/FTmFxO+L1tzA7ynOwULmOso8G8yj4 nQ7LnAaZ8NUBtNFtJNiS12H00zzvFcIhsh72FDlcikKDUIye1M/kAmgeO85vPiEKRGgF fp9gvghKSJniwc1MIcxR1xkGo9/RePrkWY18NTZKea3UrjQzFL7iHdfKFPL55RNqQoeJ E4bJu8EAYALn9MmCE3QqgT2ipgz3+BeVNKfGbyEJq29A0uM72pTZ6Ow357KRPCTEJisi KovUpLDvVRm8K8+x/vc/X804yLyiHmAZdo4MMOgLAc/n+hdvWd131GmtJ63gpAWtUfLW W8tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0XAcTwNAjs4laFoKvc5Fb9Z/bZOpbMEKQfuLjjQGHiQ=; b=nU3/DMYnb2LX0X1HDoHKxE0aIiVLwR2JuKQ7ejM7ndI3PMDXBY0EPgbN7bKrMrLk4y Oev2TtnhL+eVM+gESjXuWzVaDlqJvGbQmWPYikzLe38CSAwxsCH3gOV21x+7Bpf1LnWQ qkY87xpKyWVa+eCGKtXwYteruV1maG4qerKY4nGbFI1bwyWKWTjnw8EgyBjnkdVpW1pO f1vsS21bIwgTg4NihdEBSpCUs1OQJ/fFfMgjR8rIlBu+cgK+edA31Fz4H00+Hr3ZGske 4XwfcVIle/OrnwTxQy9/HKHBKJph/fwlS4kdUZgFZgN/8va/So7OrdKANWsVX6S1u1tX 3Yrw== X-Gm-Message-State: AFqh2kqa0S3hj75zy51m/SygH93ADUM3y5sdz9ko9/8TZKnhJ7YqqXvK wKofz6wrDBCbQwNV1kHIBfqbU+8r9xvTrmfbVQE= X-Google-Smtp-Source: AMrXdXvrW3f/fiZutF58NZUgB+oZQFw5jhM2P5tamEVvfLdENXTbi4yGkPFxTjc2iDomDebeg1hNq5RKNg8g05L9dGI= X-Received: by 2002:a17:907:9d0d:b0:84d:4d2d:1c5f with SMTP id kt13-20020a1709079d0d00b0084d4d2d1c5fmr478661ejc.114.1673363425688; Tue, 10 Jan 2023 07:10:25 -0800 (PST) MIME-Version: 1.0 References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87a62q1mca.fsf@nckx> In-Reply-To: <87a62q1mca.fsf@nckx> From: =?UTF-8?Q?Tor=2Dbj=C3=B6rn_Claesson?= Date: Tue, 10 Jan 2023 17:10:14 +0200 Message-ID: Subject: Re: [bug#60640] Acknowledgement (Gnu: Add gdcm) To: Tobias Geerinckx-Rice Content-Type: multipart/alternative; boundary="00000000000091800005f1ea48da" Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=tclaesson@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60640@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --00000000000091800005f1ea48da Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi! I'll answer your questions later, but have started the build > before I go out. > > The build appears to be running something like > > until fc-something; do :; done > > in an infinite loop, spamming the build log at best and slowing > down the build at worst. > > Did you notice that too? > I get a lot of "Fontconfig error: No writable cache directories" which appeared after adding graphviz as a native input for building documentation. Is this what you are meaning? Thanks=3D) Tor-bj=C3=B6rn --00000000000091800005f1ea48da Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!


I'll answer your questions later, but have started the build
before I go out.

The build appears to be running something like

=C2=A0 until fc-something; do :; done

in an infinite loop, spamming the build log at best and slowing
down the build at worst.

Did you notice that too?

I get a lot of= "Fontconfig error: No writable cache directories" which appeared= after adding graphviz as a native input for building documentation. Is thi= s what you are meaning?

Thanks=3D)
Tor-b= j=C3=B6rn
--00000000000091800005f1ea48da-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 15:26:36 2023 Received: (at submit) by debbugs.gnu.org; 10 Jan 2023 20:26:36 +0000 Received: from localhost ([127.0.0.1]:41217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFLCd-0002U5-Qs for submit@debbugs.gnu.org; Tue, 10 Jan 2023 15:26:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:40924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFLCb-0002Tx-FQ for submit@debbugs.gnu.org; Tue, 10 Jan 2023 15:26:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFLCa-0007wW-Dk for guix-patches@gnu.org; Tue, 10 Jan 2023 15:26:32 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFLCY-0003dX-53 for guix-patches@gnu.org; Tue, 10 Jan 2023 15:26:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=rhtGKdVtCXDUJ ruUh07HdRwx16+SzRH6DBMIfI+BCaQ=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=YsP5BxBxHfCwnePXxgCMd0XPCAESitDqBb5NLh SAs0xXsym3aAMgCNUBFnwAsvhS5Y3zM5kjjyUtMsYhdWaeM/dJWIOLTYc6Jut3dM7LgQd5 xxrNI6TpJL56/efzWgsA94fG10eiuB3RrvvL5yzhZk3QN0E3NJlf4UaMXzB3Y2KPZTR+V/ f29PHmB89eIw9ZA5fbbtk6ER3Rg/C30fPb3ukTHWwq+Z9Q7wmjwaQFK1/nec15HhoUK1Q7 NVyE0C0W09+lKWaWUIeoSUgzhSm53Kedi6o60XSqqaSrl8KB4W5ycu78YFD7Un8QjgpIcY OXAOS6knlNN68is8ko3ZifxA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 27214356 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 10 Jan 2023 20:26:18 +0000 (UTC) References: <877cxyp1wf.fsf@gmail.com> From: Tobias Geerinckx-Rice To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: [bug#60640] Gnu: Add gdcm Date: Tue, 10 Jan 2023 15:52:49 +0100 In-reply-to: <877cxyp1wf.fsf@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87y1qaxhh7.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit Cc: 60640@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tor-bj=C3=B6rn Claesson =E5=86=99=E9=81=93=EF=BC=9A > 1. I have not yet been able to build the bin output, > which consists of utilities for manipulating DICOM data.=20 OK, I'll take a look. > 2. It does not build pdf-documentation, since that would require > texlive as a native input. OK. You can add this sort of information as a comment by the=20 relevant line, so it doesn't get lost (even during review :-). > 3. It does not perform tests. OK, I'll take a look. If tests are disabled, the reason should always be noted in a=20 comment. Even if it's just =E2=80=98; no test suite=E2=80=99. > 4. It uses socketxx, ljpeg and papyrus3 from the gdcm sources. Here too I've punted on that by just adding a comment for now. > +(define-public gdcm It used to be common to unconditionally add packages to the end of=20 files, but this needlessly increased the risk of merge conflicts. Instead, just add them wherever they first fit alphabetically;=20 here, I put it above =E2=80=98mia=E2=80=99. > + (version "3.0.20") =E2=80=98guix lint=E2=80=99 says this can be updated to 3.1.0 but I didn't = try, as=20 I'd rather it be tested by an actual user =E2=80=94 i.e., you. > +=20 > "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) > + (build-system cmake-build-system) > + (outputs '("out" "doc")) /share/doc wasn't actually installed into "doc", but to "out", so=20 I set the GDCM_INSTALL_DOC_DIR configure flag. > + (arguments > + (list #:tests? #f > + #:phases #~(modify-phases %standard-phases > + (add-before 'configure 'set-LDFLAGS > + (lambda* (#:key inputs outputs=20 > #:allow-other-keys) > + (setenv "LDFLAGS" > + (string-append=20 > "-Wl,-rpath=3D" > + #$output=20 > "/lib")))) > + (add-before 'build 'patch-gdcm-charls.h > + (lambda _ > + (substitute*=20 > "../source/Utilities/gdcm_charls.h" > + (("# include ") Purely as a matter of taste I dropped the =E2=80=98# include =E2=80=99 from= both=20 strings and escaped the =E2=80=98.=E2=80=99 in the regexp. > + "# include "))=20 > #t))) =E2=80=98#t=E2=80=99 endings are also obsolete. Just drop them entirely. = Phases=20 can now safely return anything, including nothing or undefined. I added the following phase to work around log spam, since I=20 didn't find its source (nor did I look very hard) [edit: it was=20 indeed graphviz, thanks]. By default, $HOME is not writable in=20 the build environment. (add-before 'build 'set-HOME ;; The build spams =E2=80=98Fontconfig error: No writable cache ;; directories=E2=80=99 in a seemingly endless loop otherwise. (lambda _ (setenv "HOME" "/tmp"))) > + #:configure-flags #~(list=20 > "-DCMAKE_SKIP_RPATH:BOOL=3DYES" I, opinionated, added newlines after #:phases and=20 #:configure-flags. Some people like the =E2=80=98extreme indentation=E2=80=99 you get by throw= ing=20 away half of your screen width. I find it leads to cramped code=20 and noisy patches once the phases need to get actual work done or=20 an even longer CMAKE_ flag comes along. I also added some newlines and tried to group related flags. > +=20 > "-DCMAKE_C_FLAGS=3D-fvisibility=3Dhidden" > +=20 > "-DCMAKE_CXX_FLAGS=3D-fvisibility=3Dhidden" Should these be explained in a very brief comment? > +=20 > "-DGDCM_USE_SYSTEM_EXPAT:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_ZLIB:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_CHARLS:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_POPPLER:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_LIBXML2:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_JSON:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_UUID:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_OPENJPEG:BOOL=3DON" > +=20 > "-DGDCM_USE_SYSTEM_OPENSSL:BOOL=3DON" Thank you for building with system libraries! Also remove the=20 bundled copies when possible. I did so in a (rather strict)=20 source snippet. > +=20 > "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF" I cannot get the man pages to build, either. They need something=20 called =E2=80=98xsl-ns=E2=80=99. I've disabled GDCM_BUILD_DOCBOOK_MANPAGES= for=20 now. > +=20 > "-DGCM_BUILD_TESTING:BOOL=3DOFF" Why is this set? It's reported by CMake as having no effect, and=20 a diff of the output confirms that. > +=20 > "-DGDCM_BUILD_APPLICATIONS:BOOL=3DOFF" I added a =E2=80=98TODO=E2=80=99 comment above these bundled projects: > +=20 > "-DGDCM_USE_SYSTEM_PAPYRUS3:BOOL=3DOFF" > +=20 > "-DGDCM_USE_SYSTEM_SOCKETXX:BOOL=3DOFF" > +=20 > "-DGDCM_USE_SYSTEM_LJPEG:BOOL=3DOFF"))) > + (inputs (list openssl > + expat > + charls > + poppler > + libxml2 > + json-c > + openjpeg > + `(,util-linux "lib") > + zlib)) > + (native-inputs (list git pkg-config doxygen graphviz)) Sorted both. > + (home-page "https://gdcm.sourceforge.net") > + (synopsis > + "C++ library dedicated to reading/parsing and writing=20 > DICOM medical files") > + (description > + "Grassroots DICOM (GDCM) is an implementation of the DICOM=20 > standard > +designed to be open source so that researchers may access=20 > clinical data > +directly. GDCM includes a file format definition and a network=20 > communications > +protocol, both of which should be extended to provide a full=20 > set of tools for > +a researcher or small medical imaging vendor to interface with=20 > an existing > +medical database.") I rewrote this just a smidge. Mostly to remove the extra words,=20 and use pretty @acronym{} mark-up. > + (license license:bsd-3))) I still need to check this. I've attached my WIP V2 to this message, with a commit message=20 matching our conventions. Kind regards, T G-R --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=v2-0001-gnu-Add-gdcm.patch Content-Transfer-Encoding: quoted-printable From=20e2e2d9e220158aa2fd7dd0f4995c76d7d09ae79b Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D Date: Sat, 7 Jan 2023 21:40:42 +0200 Subject: [PATCH v2] gnu: Add gdcm. * gnu/packages/image-processing.scm (gdcm): New variable. Signed-off-by: Tobias Geerinckx-Rice =2D-- gnu/packages/image-processing.scm | 105 ++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+) diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-process= ing.scm index 70c820e76b..b95cb54964 100644 =2D-- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -99,6 +99,7 @@ (define-module (gnu packages image-processing) #:use-module (gnu packages tls) #:use-module (gnu packages version-control) #:use-module (gnu packages video) + #:use-module (gnu packages web) #:use-module (gnu packages xiph) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) @@ -196,6 +197,110 @@ (define-public dcmtk "A union of the Apache 2.0 licence and various non-copyleft licences similar to the Modified BSD licence.")))) =20 +(define-public gdcm + (package + (name "gdcm") + (version "3.0.20") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/malaterre/GDCM/") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")) + (modules '((guix build utils) + (ice-9 ftw))) + (snippet + '(begin + (define (unbundle? file) + (and (file-is-directory? file) + ;; Not all directories represent a bundled projec= t, + ;; and some projects can't yet be unbundled. + (not (member file '("." ".." + "doxygen" + "gdcmext" + "gdcmjpeg" ; TODO + "gdcmrle" + "socketxx"))))) ; TODO + (with-directory-excursion "Utilities" + (for-each (lambda (utility) + (delete-file-recursively utility) + (substitute* "CMakeLists.txt" + (((string-append ".*/" utility "/.*")) "= "))) + (scandir "." unbundle?))))))) + (build-system cmake-build-system) + (outputs '("out" "doc")) + (arguments + (list #:tests? #f ; XXX + #:phases + #~(modify-phases %standard-phases + (add-before 'configure 'set-LDFLAGS + (lambda* (#:key inputs outputs #:allow-other-keys) + (setenv "LDFLAGS" + (string-append "-Wl,-rpath=3D" + #$output "/lib")))) + (add-before 'build 'set-HOME + ;; The build spams =E2=80=98Fontconfig error: No writable= cache + ;; directories=E2=80=99 in a seemingly endless loop other= wise. + (lambda _ + (setenv "HOME" "/tmp"))) + (add-before 'build 'patch-gdcm-charls.h + (lambda _ + (substitute* "../source/Utilities/gdcm_charls.h" + (("") + ""))))) + #:configure-flags + #~(list "-DCMAKE_SKIP_RPATH:BOOL=3DYES" + "-DCMAKE_BUILD_TYPE:STRING=3DRelease" + "-DCMAKE_C_FLAGS=3D-fvisibility=3Dhidden" + "-DCMAKE_CXX_FLAGS=3D-fvisibility=3Dhidden" + "-DGDCM_BUILD_SHARED_LIBS:BOOL=3DON" + + "-DGDCM_DOCUMENTATION:BOOL=3DON" + "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF" ; TODO? need texl= ive + (string-append "-DGDCM_INSTALL_DOC_DIR=3D" + #$output:doc "/share/doc/" #$name) + "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF" ; TODO: need= =E2=80=98xsl-ns=E2=80=99 + + "-DGDCM_USE_SYSTEM_EXPAT:BOOL=3DON" + "-DGDCM_USE_SYSTEM_ZLIB:BOOL=3DON" + "-DGDCM_USE_SYSTEM_CHARLS:BOOL=3DON" + "-DGDCM_USE_SYSTEM_POPPLER:BOOL=3DON" + "-DGDCM_USE_SYSTEM_LIBXML2:BOOL=3DON" + "-DGDCM_USE_SYSTEM_JSON:BOOL=3DON" + "-DGDCM_USE_SYSTEM_UUID:BOOL=3DON" + "-DGDCM_USE_SYSTEM_OPENJPEG:BOOL=3DON" + "-DGDCM_USE_SYSTEM_OPENSSL:BOOL=3DON" + + "-DGDCM_BUILD_APPLICATIONS:BOOL=3DOFF" + + ;; TODO: Unbundle these if possible. + "-DGDCM_USE_SYSTEM_PAPYRUS3:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_SOCKETXX:BOOL=3DOFF" ; socketxx in s= nippet + "-DGDCM_USE_SYSTEM_LJPEG:BOOL=3DOFF"))) ; gdcmjpeg in s= nippet + (inputs (list charls + expat + json-c + libxml2 + openjpeg + openssl + poppler + `(,util-linux "lib") + zlib)) + (native-inputs (list doxygen git graphviz pkg-config)) + (home-page "https://gdcm.sourceforge.net") + (synopsis "C++ library to read, parse, and write DICOM medical files") + (description + "@acronym{GDCM, Grassroots DICOM} implements the @acronym{DICOM, Digi= tal +Imaging and Communications in Medicine} standard to let researchers access +clinical data directly. GDCM includes a file format definition and a netw= ork +communications protocol, both of which should be extended to provide a ful= l set +of tools for a researcher or small medical imaging vendor to interface wit= h an +existing medical database.") + (license license:bsd-3))) + (define-public mia (package (name "mia") base-commit: e0ed305f2f096e7048af1a117c72895433f4886a =2D-=20 2.38.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY73KRA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW150UYA/22EOgxYn3tza7SIMz5MYuv1uNdxvflK0t9gbdou EbDNAP99uQZ1Vr2RMUIEx6OEFAnbzwajjqpuSvqyBmfUoAmRBg== =vJGL -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 01:08:15 2023 Received: (at submit) by debbugs.gnu.org; 11 Jan 2023 06:08:15 +0000 Received: from localhost ([127.0.0.1]:41564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFUHW-00010S-Ur for submit@debbugs.gnu.org; Wed, 11 Jan 2023 01:08:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:35286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFUHV-00010J-4J for submit@debbugs.gnu.org; Wed, 11 Jan 2023 01:08:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFUHT-0008LJ-Q9 for guix-patches@gnu.org; Wed, 11 Jan 2023 01:08:12 -0500 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFUHQ-0006xw-3G for guix-patches@gnu.org; Wed, 11 Jan 2023 01:08:10 -0500 Received: by mail-lf1-x12b.google.com with SMTP id f34so21912206lfv.10 for ; Tue, 10 Jan 2023 22:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=9fRBxKg0pKOBeEGIuN5jpifQAcrj6EGG0clY0wKGkIw=; b=oBCHXHmG/G+VCaxYynrzleNc8PZ90IZWFbp7Z9njOEyrLatKJ9jPeJgVHh5IuAyB77 toK1OVrBFr3V5l7Y27FVakpAFdHftwRl2B5GeJeB0lIbjCXuOWNwKfw32dAEM3CpkmwV FFldXo/vkmivG8RkxUbsCseI5hCf9Qf5fjgG79ONkh+PiH4F3Q/+A1iwkVz2+XFG2l5c +04kfDF7ktT4C38+HimAiAWxxEzBrmYwf14EuiUTb1rD1ZPEY573fSrJPrBjobhub8iV i9D9b60zoQWEhJbIGPBEYXOLcJDABbtvNSSf7+9wt1m2IafEoP9GTPhw8DUYJCwHy9HM zqEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9fRBxKg0pKOBeEGIuN5jpifQAcrj6EGG0clY0wKGkIw=; b=eeQGaw1xU+2GOrck/RA9hpsT2Zdhlhznidl0ltx36RT+DiyhZOSIfu7q5Zruu3OaHo AVDgnK0OoCGrO7ximWT6t31s4ednP3ugDxrgzhHk+VGr7O/+3Au9Am6zjWWeRnYrU4kI YVU47SBPR8/HDmKUrr1ovKIbfE3Byl4/gMR+N7i3BXmWubBe3CDm6PuMvBCsAw6Dqrxd zwE1GVIcEAXatH5GuGMhumk5VRYNNksEPurhSDGiuZoVujw1oppUfr7JUOqXE+UWM5Ny 20g+VWa9stHygIsNTRxfsM47plQQ4OetqpeHPneoo1wpSRk8Jh98fyfKW+glEMcAyLNa rGGw== X-Gm-Message-State: AFqh2krx3fEa4owX7Zaa/2gdoLFeUzIhLIP+NsKiExAO7WOdHDcLjKsS Ti/2U9SHjRBeixKwUTF/PyVvdiXduQM= X-Google-Smtp-Source: AMrXdXubscC2nW8mlPEDVTehS5DR1kYxlmSksK0kWHMpfLNQL7gDrxBw1aqgkJWvsDKvMukn8hX7vg== X-Received: by 2002:a19:6b08:0:b0:4b6:edef:183b with SMTP id d8-20020a196b08000000b004b6edef183bmr18410538lfa.11.1673417285783; Tue, 10 Jan 2023 22:08:05 -0800 (PST) Received: from barbar (212-90-81-204.bb.dnainternet.fi. [212.90.81.204]) by smtp.gmail.com with ESMTPSA id i4-20020ac25d24000000b004b578e52d81sm2546288lfb.176.2023.01.10.22.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 22:08:05 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qaxhh7.fsf@nckx> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Tobias Geerinckx-Rice Subject: Re: [bug#60640] Gnu: Add gdcm Date: Wed, 11 Jan 2023 07:29:10 +0200 In-reply-to: <87y1qaxhh7.fsf@nckx> Message-ID: <87o7r5li2j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=tclaesson@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60640@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi! Tobias Geerinckx-Rice writes: > >> 3. It does not perform tests. > > OK, I'll take a look. > > If tests are disabled, the reason should always be noted in a comment. > Even if it's just =E2=80=98; no test suite=E2=80=99. > #:tests? #t makes the build fail with "make: *** No rule to make target 'test'. Stop." =20 GDCM has nightly regression tests (https://open.cdash.org/index.php?project=3DGDCM), should we try to run those when building? I have tried to find out how to do this but for now with no success. Maybe it is obvious to more experienced people? >> +(define-public gdcm > > It used to be common to unconditionally add packages to the end of > files, but this needlessly increased the risk of merge conflicts. > > Instead, just add them wherever they first fit alphabetically; here, I > put it above =E2=80=98mia=E2=80=99. > Ok, will do from now on! >> + (version "3.0.20") > > =E2=80=98guix lint=E2=80=99 says this can be updated to 3.1.0 but I didn'= t try, as I'd > rather it be tested by an actual user =E2=80=94 i.e., you. > I got that too, but the latest release in git is 3.0.20 >> + "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) >> + (build-system cmake-build-system) >> + (outputs '("out" "doc")) > > /share/doc wasn't actually installed into "doc", but to "out", so I > set the GDCM_INSTALL_DOC_DIR configure flag. > >> + (arguments >> + (list #:tests? #f >> + #:phases #~(modify-phases %standard-phases >> + (add-before 'configure 'set-LDFLAGS >> + (lambda* (#:key inputs outputs >> #:allow-other-keys) >> + (setenv "LDFLAGS" >> + (string-append "-Wl,-rpath=3D" >> + #$output >> "/lib")))) >> + (add-before 'build 'patch-gdcm-charls.h >> + (lambda _ >> + (substitute* >> "../source/Utilities/gdcm_charls.h" >> + (("# include ") Ah, good catch! > > Purely as a matter of taste I dropped the =E2=80=98# include =E2=80=99 fr= om both > strings and escaped the =E2=80=98.=E2=80=99 in the regexp. > >> + "# include ")) >> #t))) > > =E2=80=98#t=E2=80=99 endings are also obsolete. Just drop them entirely.= Phases can > now safely return anything, including nothing or undefined. > > I added the following phase to work around log spam, since I didn't > find its source (nor did I look very hard) [edit: it was indeed > graphviz, thanks]. By default, $HOME is not writable in the build > environment. > > (add-before 'build 'set-HOME > ;; The build spams =E2=80=98Fontconfig error: No writable cache > ;; directories=E2=80=99 in a seemingly endless loop otherwise. > (lambda _ > (setenv "HOME" "/tmp"))) > >> + #:configure-flags #~(list "-DCMAKE_SKIP_RPATH:BOOL=3DYES" Is this needed, btw? It came from gdcm:s packaging instructions. Removing it causes no verify-runpath issues. > > I, opinionated, added newlines after #:phases and #:configure-flags. > > Some people like the =E2=80=98extreme indentation=E2=80=99 you get by thr= owing away > half of your screen width. I find it leads to cramped code and noisy > patches once the phases need to get actual work done or an even longer > CMAKE_ flag comes along. > > I also added some newlines and tried to group related flags. > Thanks, I didn't know that would make the line fit better on screen. Much neater=3D) >> + "-DCMAKE_C_FLAGS=3D-fvisibility=3Dhidden" >> + "-DCMAKE_CXX_FLAGS=3D-fvisibility=3Dhidden" > > Should these be explained in a very brief comment? > They are from https://github.com/malaterre/GDCM/blob/master/PACKAGER, the explanation is: "This make sure that on UNIX, the API is actually identical at what is foun= d on Windows." > > Thank you for building with system libraries! Also remove the bundled > copies when possible. I did so in a (rather strict) source snippet. > Ok, neat=3D) >> + "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF" > > I cannot get the man pages to build, either. They need something > called =E2=80=98xsl-ns=E2=80=99. I've disabled GDCM_BUILD_DOCBOOK_MANPAG= ES for now. > >> + "-DGCM_BUILD_TESTING:BOOL=3DOFF" > > Why is this set? It's reported by CMake as having no effect, and a > diff of the output confirms that. > >From the old wiki: "This boolean is responsible for deciding whether or not to build/run the nightly regression test of gdcm. Warning when turning this option on, the size of the gdcm libraries will be bigger since some extra code are compiled in for the testing framework (see gdcm::Testing, and the md5 lib)." This seems to be incorrect then, maybe we can skip it. >> + (license license:bsd-3))) > > I still need to check this. > https://github.com/malaterre/GDCM/blob/master/Copyright.txt I'm not able to apply your new patch, but that is probably a fault on my pa= rt. Thanks a lot for sharing your time and knowledge, and for making this patch neater! I find this a lot of fun, but have no experience with scheme or packaging, so your explanations are very valuable to me. Cheers Tor-bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 12:37:44 2023 Received: (at control) by debbugs.gnu.org; 11 Jan 2023 17:37:44 +0000 Received: from localhost ([127.0.0.1]:43738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFf2m-0003sL-Fc for submit@debbugs.gnu.org; Wed, 11 Jan 2023 12:37:44 -0500 Received: from smtpmciv6.myservices.hosting ([185.26.106.201]:35610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFf2i-0003sA-5U for control@debbugs.gnu.org; Wed, 11 Jan 2023 12:37:43 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv6.myservices.hosting (Postfix) with ESMTP id D6BFB20CE0 for ; Wed, 11 Jan 2023 18:37:37 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 96DDC80096 for ; Wed, 11 Jan 2023 18:37:37 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7Tz7K3vXsTsV for ; Wed, 11 Jan 2023 18:37:37 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 52DDB80093 for ; Wed, 11 Jan 2023 18:37:37 +0100 (CET) Message-ID: Date: Wed, 11 Jan 2023 17:37:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: control From: Bruno Victal Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 60732 [PATCH] gnu: Add package python-scapy tags 60732 + patch tags 60658 + patch tags 60661 + patch tags 60539 + patch tags 60540 + patch tags 60640 + patch quit Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) retitle 60732 [PATCH] gnu: Add package python-scapy tags 60732 + patch tags 60658 + patch tags 60661 + patch tags 60539 + patch tags 60540 + patch tags 60640 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 06:21:55 2023 Received: (at 60640) by debbugs.gnu.org; 12 Jan 2023 11:21:55 +0000 Received: from localhost ([127.0.0.1]:44854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFvec-0003jr-HX for submit@debbugs.gnu.org; Thu, 12 Jan 2023 06:21:55 -0500 Received: from mail-ej1-f42.google.com ([209.85.218.42]:35510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFveZ-0003jf-SN for 60640@debbugs.gnu.org; Thu, 12 Jan 2023 06:21:53 -0500 Received: by mail-ej1-f42.google.com with SMTP id vm8so43945315ejc.2 for <60640@debbugs.gnu.org>; Thu, 12 Jan 2023 03:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DY7lg7sFHgdNRBIZpobFwvRYagZTwu7DDSo2lPBVmJE=; b=ZigLOcYqbk6uCYG6knvT0po+m/G7fACthORM4ALEiub4H3An35nDUiNWxPArkiKIej UN2p3xIn1U6RUd+viYbV9DS6FhujGgESWE+/2sbIKizhi87Po7LE1VtUBvhijkbPCfev Zaa9+yaINIHZ8HidErSZtxOGBzjACeIMNw4myYyu3iJhhqiwJd/jmrr85H2Zto9U1F02 /vf2ZhaO25azz3lVlkTqHXaKzk3PP0ASDL7SEFAgyQWraeOUFWE4Qlr5RuDFJOceQ8Th DkzF6Yaqu+dMm1AuiQj9dLXpS2BIN+i2Tj1FdX1PAeZYrclHHoM4nvEURM9QAj3YQfsP vp/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DY7lg7sFHgdNRBIZpobFwvRYagZTwu7DDSo2lPBVmJE=; b=PYLnmEDzR53L4V7sbqtKbQzN+9viguyGuqRIwLe898m4hoDdkRknsZvIkD/XTWqm1s lQPjghzp3N6kzTNs/7i2IKSIvIDX/8LQAbxOG/zWRLohjOBd2UfVvGUU46hwj0li1g4p LxsazC8dMbHiXMysG2LS/GbrNeF/zS8pyoINfZ4vOX7EuK2CDrx2gP138tR33/auMeMZ 8SkKmSwuXjp957sttouKCDwrtteTCWAqsq3twYMwrEA/YNHWIzvPfyRBIkhIqYV3ogxA DqexQ93nrXZOgAIe39X0Amqv5F+nOPkESxzJdN2HbWg4//2RegH+YGuYo/OWdVI72F7F 0Bxw== X-Gm-Message-State: AFqh2kocb5q3yNxXLUHzPR+wnqQtkVYlOEs/8FNoxOT7J+ph+JR3YjUY Q6mvUM+Y1UCEmV0x3GtTV9SK91eQgA+f9bWoTtI= X-Google-Smtp-Source: AMrXdXucpgDogkG1Lanr7LB8v0TQXTTBQOzQJJfSMkqAoKMNyXH+Lrc62KYV0xEeMghpowJLHuP5iHoVxua3oeAzet4= X-Received: by 2002:a17:906:d051:b0:7c0:fd1a:6792 with SMTP id bo17-20020a170906d05100b007c0fd1a6792mr4732971ejb.431.1673522505870; Thu, 12 Jan 2023 03:21:45 -0800 (PST) MIME-Version: 1.0 References: <877cxyp1wf.fsf@gmail.com> <87y1qaxhh7.fsf@nckx> <87o7r5li2j.fsf@gmail.com> In-Reply-To: <87o7r5li2j.fsf@gmail.com> From: =?UTF-8?Q?Tor=2Dbj=C3=B6rn_Claesson?= Date: Thu, 12 Jan 2023 13:21:34 +0200 Message-ID: Subject: Re: [bug#60640] Gnu: Add gdcm To: Tobias Geerinckx-Rice Content-Type: multipart/alternative; boundary="0000000000007c70fa05f20f52fe" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000007c70fa05f20f52fe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi again! Your patch applies perfectly, the error was on my side. Also, a gdcm package was added to the bioinformatics module 4 days ago=3D) = It packages an older version (2.8.9) but is much more concise than my attempt. Would it be worthwhile to continue work on this package as perhaps gdcm-3.0 and move it to bioinformatics? I put it in image-processing since dcmtk was already there. Best regards Den ons 11 jan. 2023 kl 08:08 skrev Tor-bj=C3=B6rn Claesson : > > Hi! > > Tobias Geerinckx-Rice writes: > > > >> 3. It does not perform tests. > > > > OK, I'll take a look. > > > > If tests are disabled, the reason should always be noted in a comment. > > Even if it's just =E2=80=98; no test suite=E2=80=99. > > > > #:tests? #t makes the build fail with "make: *** No rule to make target > 'test'. Stop." > > GDCM has nightly regression tests > (https://open.cdash.org/index.php?project=3DGDCM), should we try to run > those when building? I have tried to find out how to do this but for now > with no success. Maybe it is obvious to more experienced people? > > >> +(define-public gdcm > > > > It used to be common to unconditionally add packages to the end of > > files, but this needlessly increased the risk of merge conflicts. > > > > Instead, just add them wherever they first fit alphabetically; here, I > > put it above =E2=80=98mia=E2=80=99. > > > > Ok, will do from now on! > > >> + (version "3.0.20") > > > > =E2=80=98guix lint=E2=80=99 says this can be updated to 3.1.0 but I did= n't try, as I'd > > rather it be tested by an actual user =E2=80=94 i.e., you. > > > > I got that too, but the latest release in git is 3.0.20 > > >> + "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) > >> + (build-system cmake-build-system) > >> + (outputs '("out" "doc")) > > > > /share/doc wasn't actually installed into "doc", but to "out", so I > > set the GDCM_INSTALL_DOC_DIR configure flag. > > > >> + (arguments > >> + (list #:tests? #f > >> + #:phases #~(modify-phases %standard-phases > >> + (add-before 'configure 'set-LDFLAGS > >> + (lambda* (#:key inputs outputs > >> #:allow-other-keys) > >> + (setenv "LDFLAGS" > >> + (string-append "-Wl,-rpath=3D" > >> + #$output > >> "/lib")))) > >> + (add-before 'build 'patch-gdcm-charls.h > >> + (lambda _ > >> + (substitute* > >> "../source/Utilities/gdcm_charls.h" > >> + (("# include ") > > Ah, good catch! > > > > > Purely as a matter of taste I dropped the =E2=80=98# include =E2=80=99 = from both > > strings and escaped the =E2=80=98.=E2=80=99 in the regexp. > > > >> + "# include ")) > >> #t))) > > > > =E2=80=98#t=E2=80=99 endings are also obsolete. Just drop them entirel= y. Phases can > > now safely return anything, including nothing or undefined. > > > > I added the following phase to work around log spam, since I didn't > > find its source (nor did I look very hard) [edit: it was indeed > > graphviz, thanks]. By default, $HOME is not writable in the build > > environment. > > > > (add-before 'build 'set-HOME > > ;; The build spams =E2=80=98Fontconfig error: No writable cache > > ;; directories=E2=80=99 in a seemingly endless loop otherwise. > > (lambda _ > > (setenv "HOME" "/tmp"))) > > > >> + #:configure-flags #~(list "-DCMAKE_SKIP_RPATH:BOOL=3DYES" > > Is this needed, btw? It came from gdcm:s packaging > instructions. Removing it causes no verify-runpath issues. > > > > > I, opinionated, added newlines after #:phases and #:configure-flags. > > > > Some people like the =E2=80=98extreme indentation=E2=80=99 you get by t= hrowing away > > half of your screen width. I find it leads to cramped code and noisy > > patches once the phases need to get actual work done or an even longer > > CMAKE_ flag comes along. > > > > I also added some newlines and tried to group related flags. > > > > Thanks, I didn't know that would make the line fit better on > screen. Much neater=3D) > > >> + "-DCMAKE_C_FLAGS=3D-fvisibility=3Dhidden" > >> + "-DCMAKE_CXX_FLAGS=3D-fvisibility=3Dhidden" > > > > Should these be explained in a very brief comment? > > > > They are from https://github.com/malaterre/GDCM/blob/master/PACKAGER, > the explanation is: > "This make sure that on UNIX, the API is actually identical at what is > found on Windows." > > > > > Thank you for building with system libraries! Also remove the bundled > > copies when possible. I did so in a (rather strict) source snippet. > > > > Ok, neat=3D) > > >> + "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF" > > > > I cannot get the man pages to build, either. They need something > > called =E2=80=98xsl-ns=E2=80=99. I've disabled GDCM_BUILD_DOCBOOK_MANP= AGES for now. > > > >> + "-DGCM_BUILD_TESTING:BOOL=3DOFF" > > > > Why is this set? It's reported by CMake as having no effect, and a > > diff of the output confirms that. > > > > From the old wiki: > > "This boolean is responsible for deciding whether or not to build/run the > nightly regression test of gdcm. Warning when turning this option on, > the size of the gdcm libraries will be bigger since some extra code are > compiled in for the testing framework (see gdcm::Testing, and the md5 > lib)." > > This seems to be incorrect then, maybe we can skip it. > > >> + (license license:bsd-3))) > > > > I still need to check this. > > > > https://github.com/malaterre/GDCM/blob/master/Copyright.txt > > I'm not able to apply your new patch, but that is probably a fault on my > part. > > Thanks a lot for sharing your time and knowledge, and for making this > patch neater! I find this a lot of fun, but have no experience > with scheme or packaging, so your explanations are very valuable to me. > > Cheers > Tor-bj=C3=B6rn > --0000000000007c70fa05f20f52fe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi again!

Your patch applies= perfectly, the error was on my side.

Also, a gdcm= package was added to the bioinformatics module 4 days ago=3D) It packages = an older version (2.8.9) but is much more concise than my attempt. Would it= be worthwhile to continue work on this package as perhaps gdcm-3.0 and mov= e it to bioinformatics? I put it in image-processing since dcmtk was alread= y there.

Best regards

Den ons 11 jan. 202= 3 kl 08:08 skrev Tor-bj=C3=B6rn Claesson <tclaesson@gmail.com>:

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> writes:
>
>> 3. It does not perform tests.
>
> OK, I'll take a look.
>
> If tests are disabled, the reason should always be noted in a comment.=
> Even if it's just =E2=80=98; no test suite=E2=80=99.
>

#:tests? #t makes the build fail with "make: *** No rule to make targe= t
=C2=A0'test'.=C2=A0 Stop."

GDCM has nightly regression tests
(https://open.cdash.org/index.php?project=3DGDCM)= , should we try to run
those when building? I have tried to find out how to do this but for now with no success. Maybe it is obvious to more experienced people?

>> +(define-public gdcm
>
> It used to be common to unconditionally add packages to the end of
> files, but this needlessly increased the risk of merge conflicts.
>
> Instead, just add them wherever they first fit alphabetically; here, I=
> put it above =E2=80=98mia=E2=80=99.
>

Ok, will do from now on!

>> +=C2=A0 =C2=A0 (version "3.0.20")
>
> =E2=80=98guix lint=E2=80=99 says this can be updated to 3.1.0 but I di= dn't try, as I'd
> rather it be tested by an actual user =E2=80=94 i.e., you.
>

I got that too, but the latest release in git is 3.0.20

>> + "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i"= ))))
>> +=C2=A0 =C2=A0 (build-system cmake-build-system)
>> +=C2=A0 =C2=A0 (outputs '("out" "doc")) >
> /share/doc wasn't actually installed into "doc", but to = "out", so I
> set the GDCM_INSTALL_DOC_DIR configure flag.
>
>> +=C2=A0 =C2=A0 (arguments
>> +=C2=A0 =C2=A0 =C2=A0(list #:tests? #f
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases #~(modify-phase= s %standard-phases
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (add-before 'configure 'set-LDFLAGS
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda* (#:key inputs outputs
>> #:allow-other-keys)
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setenv "LDFLAGS"
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (string-appe= nd "-Wl,-rpath=3D"
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#$output
>> "/lib"))))
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (add-before 'build 'patch-gdcm-charls.h
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda _
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (substitute*
>> "../source/Utilities/gdcm_charls.h"
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (("# include <CharLS/char= ls.h>")

Ah, good catch!

>
> Purely as a matter of taste I dropped the =E2=80=98# include =E2=80=99= from both
> strings and escaped the =E2=80=98.=E2=80=99 in the regexp.
>
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"# include <charls/= charls.h>"))
>> #t)))
>
> =E2=80=98#t=E2=80=99 endings are also obsolete.=C2=A0 Just drop them e= ntirely.=C2=A0 Phases can
> now safely return anything, including nothing or undefined.
>
> I added the following phase to work around log spam, since I didn'= t
> find its source (nor did I look very hard) [edit: it was indeed
> graphviz, thanks].=C2=A0 By default, $HOME is not writable in the buil= d
> environment.
>
>=C2=A0 (add-before 'build 'set-HOME
>=C2=A0 =C2=A0 ;; The build spams =E2=80=98Fontconfig error: No writable= cache
>=C2=A0 =C2=A0 ;; directories=E2=80=99 in a seemingly endless loop other= wise.
>=C2=A0 =C2=A0 (lambda _
>=C2=A0 =C2=A0 =C2=A0 (setenv "HOME" "/tmp")))
>
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:configure-flags #~(lis= t "-DCMAKE_SKIP_RPATH:BOOL=3DYES"

Is this needed, btw? It came from gdcm:s packaging
instructions. Removing it causes no verify-runpath issues.

>
> I, opinionated, added newlines after #:phases and #:configure-flags. >
> Some people like the =E2=80=98extreme indentation=E2=80=99 you get by = throwing away
> half of your screen width.=C2=A0 I find it leads to cramped code and n= oisy
> patches once the phases need to get actual work done or an even longer=
> CMAKE_ flag comes along.
>
> I also added some newlines and tried to group related flags.
>

Thanks, I didn't know that would make the line fit better on
screen. Much neater=3D)

>> + "-DCMAKE_C_FLAGS=3D-fvisibility=3Dhidden"
>> + "-DCMAKE_CXX_FLAGS=3D-fvisibility=3Dhidden"
>
> Should these be explained in a very brief comment?
>

They are from https://github.com/malaterre/GDC= M/blob/master/PACKAGER,
the explanation is:
"This make sure that on UNIX, the API is actually identical at what is= found on Windows."

>
> Thank you for building with system libraries!=C2=A0 Also remove the bu= ndled
> copies when possible.=C2=A0 I did so in a (rather strict) source snipp= et.
>

Ok, neat=3D)

>> + "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF"
>
> I cannot get the man pages to build, either.=C2=A0 They need something=
> called =E2=80=98xsl-ns=E2=80=99.=C2=A0 I've disabled GDCM_BUILD_DO= CBOOK_MANPAGES for now.
>
>> + "-DGCM_BUILD_TESTING:BOOL=3DOFF"
>
> Why is this set?=C2=A0 It's reported by CMake as having no effect,= and a
> diff of the output confirms that.
>

>From the old wiki:

"This boolean is responsible for deciding whether or not to build/run = the
nightly regression test of gdcm. Warning when turning this option on,
the size of the gdcm libraries will be bigger since some extra code are
compiled in for the testing framework (see gdcm::Testing, and the md5
lib)."

This seems to be incorrect then, maybe we can skip it.

>> +=C2=A0 =C2=A0 (license license:bsd-3)))
>
> I still need to check this.
>

https://github.com/malaterre/GDCM/blob/ma= ster/Copyright.txt

I'm not able to apply your new patch, but that is probably a fault on m= y part.

Thanks a lot for sharing your time and knowledge, and for making this
patch neater! I find this a lot of fun, but have no experience
with scheme or packaging, so your explanations are very valuable to me.

Cheers
Tor-bj=C3=B6rn
--0000000000007c70fa05f20f52fe-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 17:17:56 2023 Received: (at 60640) by debbugs.gnu.org; 12 Jan 2023 22:17:56 +0000 Received: from localhost ([127.0.0.1]:48775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG5tU-0004KK-Ew for submit@debbugs.gnu.org; Thu, 12 Jan 2023 17:17:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG5tS-0004K5-Vl for 60640@debbugs.gnu.org; Thu, 12 Jan 2023 17:17:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG5tN-0005Is-LD; Thu, 12 Jan 2023 17:17:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=bVBjR38UDa5lyymMRYcGQJiImwwb71fuiun4O1ajt90=; b=Djj6WqK8UG6TPg/GfMby 3v6q9w1zJowi/JcP0KWg12d9L0tZLjUxFBuiS1LufyIJ9HI8rK04TJd1CczuQY1ECbQHuDyPh+b8g XQ3ww/uK2xccKms3tcjqHMQNGTVbh4vpEgHJWE+egFDoIvDmlWY9cjis+MAkgPb2pZgskzYHWGYzZ 7Iqu0uJWd6jzj7NyBBlvKI11iadxHXrSvVMIeXWYOg6MGedsn52CDPauG+zEbtyD2tNaovj22zDuP jxAfgpXmmSIUW45rptiQlLQtUJKvG/Zypr0+a9h85NDZ5TmBqeLYwPZp0tDxL0ZW29f14ilHOpuQJ mwOzcUEKI4yaSg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG5tN-0000pT-2T; Thu, 12 Jan 2023 17:17:49 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: bug#60640: Gnu: Add gdcm References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> Date: Thu, 12 Jan 2023 23:17:46 +0100 In-Reply-To: <87y1qdo3qq.fsf@gmail.com> (=?utf-8?Q?=22Tor-bj=C3=B6rn?= Claesson"'s message of "Sun, 08 Jan 2023 09:59:40 +0200") Message-ID: <87wn5rfldh.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Tor-bj=C3=B6rn Claesson skribis: > This patch adds GDCM (a nice C++ library for DICOM, as in medical imaging= ), > with a few wharts: Commit 15caeb745c5d77b69905d38d43b4d09742bc71b6, pushed a couple of days ago, adds GDCM (although the patch was much older). Could you check if anything=E2=80=99s missing compared to your version? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 05:48:35 2023 Received: (at 60640) by debbugs.gnu.org; 13 Jan 2023 10:48:35 +0000 Received: from localhost ([127.0.0.1]:49664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGHbu-0007MT-OV for submit@debbugs.gnu.org; Fri, 13 Jan 2023 05:48:35 -0500 Received: from mail-lf1-f50.google.com ([209.85.167.50]:40537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGHbt-0007MG-Am for 60640@debbugs.gnu.org; Fri, 13 Jan 2023 05:48:33 -0500 Received: by mail-lf1-f50.google.com with SMTP id g13so32565945lfv.7 for <60640@debbugs.gnu.org>; Fri, 13 Jan 2023 02:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=qIdoWZVQnR3lhaxNHCfzw7LL7lCumtLJ4mu2e7/AtXY=; b=kC9922GiaZn/jXS3wC642koMAYUe0u1i43fCVz2LjKfWbWSva25ArqTX+c6mIurp1T 3BRVWenPXYq42fwIx8y1rFqNQrzleuPFSH6H11PSosxj0Ue1xeiTIPrndtLQlRnYDs1m qnqhN6zAgzuqC140vCqAbwChZ9uEqLb+ITzqCS69Y0PVFzjduFafaKobPPA4tyqKo28E 9iz1I9vyZ8jzw1McB7XUfDxatA1BydHPwyZ1zrZXC/hKFQ1OU0WrzNWOEpWbRIpFSvBH EKNAfLhwpPslJbHs4OsgSwEOIcl5uXF+uEcHHRucZj63FgTwiXlFImL4U1gh9OqBUtXO RcSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qIdoWZVQnR3lhaxNHCfzw7LL7lCumtLJ4mu2e7/AtXY=; b=NX3MyAw+A8b3YiBynTC7Ua7zaoNkxhQdOG50+IiXYrxYq1ZWyMdzGGI4vqcipqwUXB LQ8/5BaO4LQpwDA5m4krL49JoRyPyZqHNKg+XR8umFAPyGW4nv6zNVq7YKHDwAfdsRSw RE5YP636pzYQnjARl+PPTvBoC2lfIBWioCOEDsoJJkbe+MhDiti0Ybna+G8VBMhqiZAr ep/FeOuTMOaj7Om1X5zBvdUvc6OzvFqYF+2fXCyKO8NlKL8HJn2YJvtV6b6KpUjG6OZz 90+lkGjBMjXyWliICvvxi8wjyH3k0/nkoQ+xR0sU5l+FvT5WD6CSTWM83e+ULm5Cw2HF DuOg== X-Gm-Message-State: AFqh2koHCWiKGhxQuGbfZNgDdPJQBb4jE8AWyUsZMKHMd4GoD78E433t GDIqDxLxwO9KE4JE/y+KdbQl644uRLY= X-Google-Smtp-Source: AMrXdXtuvkoJjSEMD2pzdDkrirb8t0tpIqbNH1aSkwdPMxNNlWhAQ7syk3xkX6NvftExsZmUwmzmaQ== X-Received: by 2002:a05:6512:21c6:b0:4af:e55a:dc69 with SMTP id d6-20020a05651221c600b004afe55adc69mr26298974lft.4.1673606906600; Fri, 13 Jan 2023 02:48:26 -0800 (PST) Received: from barbar (212-90-81-204.bb.dnainternet.fi. [212.90.81.204]) by smtp.gmail.com with ESMTPSA id x3-20020a0565123f8300b004949a8df775sm3773906lfa.33.2023.01.13.02.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 02:48:25 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Fri, 13 Jan 2023 12:45:10 +0200 In-reply-to: <87wn5rfldh.fsf_-_@gnu.org> Message-ID: <875ydau2vf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Ludovic Court=C3=A8s writes: > > Commit 15caeb745c5d77b69905d38d43b4d09742bc71b6, pushed a couple of days > ago, adds GDCM (although the patch was much older). > > Could you check if anything=E2=80=99s missing compared to your version? > > Thanks, > Ludo=E2=80=99. Yes, that was great! The pushed patch is version 2.8, whereas my patch is version 3.0. I was able to port my application to 2.8 in 3 minutes, so I don't notice big functional differences=3D) Also it does tests, which I did not get to work yet, but it does not specify system libraries. Cheers, Tor-bj=C3=B6rn Claesson From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 18:50:49 2023 Received: (at 60640) by debbugs.gnu.org; 13 Jan 2023 23:50:49 +0000 Received: from localhost ([127.0.0.1]:52748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTov-0000W7-4A for submit@debbugs.gnu.org; Fri, 13 Jan 2023 18:50:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTos-0000Vl-NW for 60640@debbugs.gnu.org; Fri, 13 Jan 2023 18:50:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGTon-00059p-Ds; Fri, 13 Jan 2023 18:50:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=GrN4oWCK8qfnryTOlOY3PfgHh+TKs9+/g5VxhdT+CaM=; b=hkV/RcJD40T1XP0WAe3y o3XNL2m8IFWviHsOASvZD4OdW8dIzJzirQqgcIhFu0bEQO7UXDtW41LW9CfHNfd2UHXsgSxAmwrAl 9PBUi0Zq1Uzpgdb6l+Owxxpk6Rru0jAmmRpOg/+JGFaDkOjoXcpCZpEjv+j4DJ7sbX5/2HPFvJfuR 6Ye/35h2VuJHJ439HkS/7jscQvBNgCqJLIhZkI8SBVjl0/0FDbP0Ej/LvnCEavoOfivdX0om1tfB4 5sDM8gQMkqI2T9LJcXY7H7u0O+FzYkDJpzaw0auDFj+wdXD0IFoy+0JjnWCfkgi4DkM8RvCugDkOd BVU4feATaSx+Ng==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGTom-0001VV-Uh; Fri, 13 Jan 2023 18:50:41 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: bug#60640: Gnu: Add gdcm References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 25 =?utf-8?Q?Niv=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Chat X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 14 Jan 2023 00:50:39 +0100 In-Reply-To: <875ydau2vf.fsf@gmail.com> (=?utf-8?Q?=22Tor-bj=C3=B6rn?= Claesson"'s message of "Fri, 13 Jan 2023 12:45:10 +0200") Message-ID: <87wn5q9epc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Tor-bj=C3=B6rn Claesson skribis: > The pushed patch is version 2.8, whereas my patch is version 3.0. I was > able to port my application to 2.8 in 3 minutes, so I don't notice big > functional differences=3D) > > Also it does tests, which I did not get to work yet, but it does not > specify system libraries. Could you send (in this issue) one patch that updates to 3.0, and another one to use system libraries? That=E2=80=99d be perfect! Thanks in advance, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 03:20:11 2023 Received: (at 60640) by debbugs.gnu.org; 14 Jan 2023 08:20:11 +0000 Received: from localhost ([127.0.0.1]:53256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGblq-0003Ug-TR for submit@debbugs.gnu.org; Sat, 14 Jan 2023 03:20:11 -0500 Received: from mail-ej1-f44.google.com ([209.85.218.44]:35809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGblp-0003US-7Z for 60640@debbugs.gnu.org; Sat, 14 Jan 2023 03:20:09 -0500 Received: by mail-ej1-f44.google.com with SMTP id vm8so57263360ejc.2 for <60640@debbugs.gnu.org>; Sat, 14 Jan 2023 00:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Pm+Ps21Mox8yMylLTt3ifDQKFQff2IOamBL6U8skl2o=; b=SGQ3ws2UHIvBIzaoeZOiVkHCrzKi4YXdKDkW3NLQ1YEgtONsEhbWVg4I8uMCJRiQmn 0aipD4OrUkKLrwRSaaIec8B3JSEJ7NrA6hRF+xeDFiDP/aG5HbARwZ2LIeCCsGVehR0j jrRmqGRhYDHETD3w57jKLYKKIyht+PEkTiyQlqDvOo5ulqmTIUXGfHgknHMlDUcKDTpu qYIxxYtUFD0noPMRq8dep+ymfues+yXCIYU7LK4RIkEovrX9x841I/NSXtgSyBOfk1HN M3ghMt4ndIOSILNekcbZRWLfAFcohf3yRRhYCgtopsNvzCILcd51eWnIyHuss7Fau8it rmrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pm+Ps21Mox8yMylLTt3ifDQKFQff2IOamBL6U8skl2o=; b=sHlRcAcuW0yKgh69VFs9PabwAX0Q0gTaM0y4T0CFiIwyNN0N90ShgvTqRHfyBYN3L3 oVMeqfPTuDHBDeUU07tGD+BkJ6MsaB2a2iZRQqLRgjKPhNyxgMIereeBH9REjlC67Xlr u3b/IaiTtku0qRcowQUMH6RD7k9Y6ZTM4sL6Xsbx2/omSMutZK5Z6/h8MM34Z0zzeZtI 32AAhvJp+It6DXR4atUZ6e6tVXLhtRKJcBrnhTx1Vn/ybSPAjLx8dFKK92dtTHYwFruR 0Ibc3dYoxOCZylzBpH+1kScsHIEpvEbvUhOEzC+XgHpsd3PqgdIo/3SFbJdUxLuzl93f axOw== X-Gm-Message-State: AFqh2kqT0zzHafW3yCNGuccM/ejklRwlGLiTtQwH7VR7+2XjNZoKpcy7 KDl/MkHKEWG8h8E8Cb8EnoenQhejdAWfBhn258+ycQL6 X-Google-Smtp-Source: AMrXdXsrPfJPM3nP0vPYr+Yi4SG9DUuXUZZ7aITAylCAQJQlhH4P/SoQbUXyKzln66I6quVT07Uc0aV2iw5t6/a/BkA= X-Received: by 2002:a17:906:aecf:b0:7c0:f7b0:9ad8 with SMTP id me15-20020a170906aecf00b007c0f7b09ad8mr6375745ejb.680.1673684402890; Sat, 14 Jan 2023 00:20:02 -0800 (PST) MIME-Version: 1.0 References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> In-Reply-To: <87wn5q9epc.fsf@gnu.org> From: =?UTF-8?Q?Tor=2Dbj=C3=B6rn_Claesson?= Date: Sat, 14 Jan 2023 10:19:51 +0200 Message-ID: Subject: Re: bug#60640: Gnu: Add gdcm To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="0000000000004cee1305f23504e4" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004cee1305f23504e4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Den l=C3=B6r 14 jan. 2023 kl 01:50 skrev Ludovic Court=C3=A8s : > > Could you send (in this issue) one patch that updates to 3.0, and > another one to use system libraries? > I have a working update to 3.0.20. Except for other possible differences, GDCM changes the name of the include directory between versions; I have to e.g. #include vs. . How should we deal with this? Would it make sense to leave a gdcm-2.8 package, to cater for users of the older version, or should we expect people to follow along? Best regards! Tor-bj=C3=B6rn --0000000000004cee1305f23504e4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
Den l=C3=B6r 14 jan. 2023 kl 01:50 skrev Ludovic Court= =C3=A8s <ludo@gnu.org>:

Could you send (in this issue) one patch that updates to 3.0, and
another one to use system libraries?
=C2=A0
= I have a working update to 3.0.20. Except for other possible differences, G= DCM changes the name of the include directory between versions; I have to e= .g. #include <gdcm-2.8/gdcmImage.h> vs. <gdcm-3.0/gdcmImage.h>.= How should we deal with this? Would it make sense to leave a gdcm-2.8 pack= age, to cater for users of the older version, or should we expect people to= follow along?

Best regards!
Tor-bj=C3= =B6rn
--0000000000004cee1305f23504e4-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 04:32:11 2023 Received: (at 60640) by debbugs.gnu.org; 14 Jan 2023 09:32:11 +0000 Received: from localhost ([127.0.0.1]:53386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGctW-0005PN-Ru for submit@debbugs.gnu.org; Sat, 14 Jan 2023 04:32:11 -0500 Received: from mail-lf1-f54.google.com ([209.85.167.54]:35640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGctV-0005P9-8i for 60640@debbugs.gnu.org; Sat, 14 Jan 2023 04:32:09 -0500 Received: by mail-lf1-f54.google.com with SMTP id b3so36340073lfv.2 for <60640@debbugs.gnu.org>; Sat, 14 Jan 2023 01:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=T1File3jIuc1SwM5pHYcalYZARj1wO46h7I5zmBrvNc=; b=nycyshHzRbNK4ubrHa2AlRc+3qfvPZvh8nW1guUuVSyM+ajpeyRTAf+ZBRFYR7HaJ/ ZwjVI+42tPHZrBX9rsROut7L1iEtAKkzkuXvDd3tE+LqtCekf8GSf3B5m0UIpllnW3pQ cVVWPE7HvcW9kcZyJvNRtwpRoNgaDMi0mHDSAZc2aS3VK8hMSDGlhDW+wlgZkro1nUdt nv9raFGYrhyRkR95M8CnciVNofW6LzbaWDgE9wy9t96caePyWgehW4+SpAsZMG3aHVTa 7WC1nWncrc9iduLv4M8VtIcPT7IkAF1qM/NvC3mwmHgUC+nLMc0b6ZnFf6uOndU8brWi NQtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T1File3jIuc1SwM5pHYcalYZARj1wO46h7I5zmBrvNc=; b=Y3vz5EAEgo/E34X5SPUiuBI9OV8DdcwVM0Q+Kjj0lXfOB77x2+pnnOaNYEzyzUzRIK KJYIIC3UFTrYEfaUGmlhCzLy/cYsJ3VdZbWKFJH01wGQylEkMGvZbuYVQuCxGStYIJvK W6ZjMBQW+gaEqfl0UNTtNEC5CgJV5HN5kmfP040o8YA/eosUtaqjcGP14PzpXpNfoKOV YDXYjOTeaP0ZKj295ayTtfIbkq87wlxFq3Z1XZgogjoyX3uFSS9H0r+sf8zBFfURQ5cb k/lAJAOfyvaEhqisxkYsLGEyNuYgAsHpLUi7ccswpULr0WOZfuJkt3bixzz11pwwn1VN nfDg== X-Gm-Message-State: AFqh2kqnAtIxW66kyEmrAcpVd5YyIRChhZ4RE1Rxlq6NhHj9gn82YQ6b HUeHyBzyev2uXyH0ph79CX1Ltn6vbZ0= X-Google-Smtp-Source: AMrXdXtJ0x+l3nUKEEJfc2lDizCnXUZpW8GO6CSsOonBYCz0BWAi3xCMJw2r+V5GAp+0WxRLQi33Wg== X-Received: by 2002:ac2:5479:0:b0:4a4:68b9:66f3 with SMTP id e25-20020ac25479000000b004a468b966f3mr20383087lfn.62.1673688722467; Sat, 14 Jan 2023 01:32:02 -0800 (PST) Received: from barbar ([193.64.204.56]) by smtp.gmail.com with ESMTPSA id q10-20020a0565123a8a00b004d10a494d72sm664343lfu.254.2023.01.14.01.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 01:32:01 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Sat, 14 Jan 2023 11:30:29 +0200 In-reply-to: <87wn5q9epc.fsf@gnu.org> Message-ID: <87fscdmpgu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Here is the first patch, which updates gdcm to 3.0.20. From f4cd5077a762f25a9fa271329a798f324e4db685 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= Date: Sat, 14 Jan 2023 11:23:58 +0200 Subject: [PATCH] gnu: gdcm: Update to 3.0.20. Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.54 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.54 listed in list.dnswl.org] X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Here is the first patch, which updates gdcm to 3.0.20. From f4cd5077a762f25a9fa271329a798f324e4db685 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= Date: Sat, 14 Jan 2023 11:23:58 +0200 Subject: [PATCH] gnu: gdcm: Update to 3.0.20. Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.54 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.54 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Here is the first patch, which updates gdcm to 3.0.20. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-gdcm-Update-to-3.0.20.patch >From f4cd5077a762f25a9fa271329a798f324e4db685 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= Date: Sat, 14 Jan 2023 11:23:58 +0200 Subject: [PATCH] gnu: gdcm: Update to 3.0.20. --- gnu/packages/bioinformatics.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index 6dd2e8250c..5b886526ad 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -17842,7 +17842,7 @@ (define-public wfmash (define-public gdcm (package (name "gdcm") - (version "2.8.9") + (version "3.0.20") (source (origin (method git-fetch) (uri (git-reference @@ -17852,7 +17852,7 @@ (define-public gdcm (file-name (git-file-name name version)) (sha256 (base32 - "1j8mjnxcwn2xvzhf25lv4dbawxbgc4im1crh8081li7i4mbwswaj")))) + "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) (build-system cmake-build-system) (arguments (list @@ -17864,7 +17864,7 @@ (define-public gdcm "|TestSCUValidation" "|TestEcho" "|TestFind'")))) - (home-page "http://gdcm.sourceforge.net/wiki/index.php/Main_Page") + (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") (synopsis "Grassroots DICOM library") (description "Grassroots DICOM (GDCM) is an implementation of the DICOM standard @@ -17873,7 +17873,7 @@ (define-public gdcm protocol, both of which should be extended to provide a full set of tools for a researcher or small medical imaging vendor to interface with an existing medical database.") - (license license:bsd-2))) + (license license:bsd-3))) (define-public wiggletools (package -- 2.38.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Documentation is also missing, will add this as well. Cheers, Tor-bj=C3=B6rn --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 12:07:48 2023 Received: (at 60640) by debbugs.gnu.org; 14 Jan 2023 17:07:48 +0000 Received: from localhost ([127.0.0.1]:55467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGk0S-0003Qi-6a for submit@debbugs.gnu.org; Sat, 14 Jan 2023 12:07:48 -0500 Received: from mail-lj1-f171.google.com ([209.85.208.171]:35658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGk0N-0003QS-VB for 60640@debbugs.gnu.org; Sat, 14 Jan 2023 12:07:47 -0500 Received: by mail-lj1-f171.google.com with SMTP id s25so25648332lji.2 for <60640@debbugs.gnu.org>; Sat, 14 Jan 2023 09:07:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=FRrsr2VS1sKrA6ErzZ9qVMNcOBPew2tb94bsVoSzJug=; b=R4da8+0lrBy2ZnL1sLZsTGt+8jcPF3QJTY984EdP64ZHrlYkmr9hSzOMfDc9E9qj5c AFfC3Bs2TPa5pCL6L0PZqHi9UzwantuSv5utNloaoevMw0PVTUF5JkrE4LMjQJJ40eIZ AIA3UO/FoN+zZTOxmbJS4I5oRLztx0fIBuMVPB8Xqksu8/22+YpjPOpvww+CEBZJJOPb Ul+FXyebdcoA+GqhokWPEmsECcSQ0gYmKty3E4gMSD4uQ7Q5nkbsxBOPXX3dxjBxERQV rkdI6+GZ56ieBK1GkkwOzIU3nbKFaSejujchAT9UCj+EWwV2ST8H3GYEZ+IN+IjT3BLX +gJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FRrsr2VS1sKrA6ErzZ9qVMNcOBPew2tb94bsVoSzJug=; b=lRHcUPeRP1fdyBvjReVyfJ3qRMSWIu1jaYP6+9jakZwTXpG480umrNLB8dIXCQrzZF QYHJQlZmcmEO9x6kk6/C3eXtDub1VSO9zZttzQpXvwSXudpp8XDqR4+z4Lp7ZQiYGu0t L5G56H4r7eRisk/SHp48Sm9g1dqKfrtfXdE0Y2C2LTZsADnoCEnYx7gVQo1xo1oWzlWt bQ1a+bjywWb1E4wS5C8iUgBqgOzvz7MRkqvpjfz0p9CMXJz8OUQs6H4wyoFsieHNVcAL tGvIElzdlZwzt+dhmTUyqIHUd8GZY6KqncSZnqaPnzHSBAciySscDBzIrSs4DAe6eYkQ nuWg== X-Gm-Message-State: AFqh2krxItfgRbJvxZBE6kksA7QA/YZkoKFGzldoDjS4RvgYPSpXbhQa lWW9uIcJuH1WLDB8b3URTNxn4QQArGw= X-Google-Smtp-Source: AMrXdXtCrh0j8nqMl51XArDEgEPrIpxebiTVAHB0ZNqKYGWbZ6/T90ATdEffgN6ke2obHkG8W1OmyA== X-Received: by 2002:a2e:6a03:0:b0:284:b253:e2c with SMTP id f3-20020a2e6a03000000b00284b2530e2cmr6336187ljc.49.1673716057508; Sat, 14 Jan 2023 09:07:37 -0800 (PST) Received: from barbar ([193.64.204.56]) by smtp.gmail.com with ESMTPSA id bi19-20020a05651c231300b0027fb7d64775sm2893364ljb.62.2023.01.14.09.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 09:07:36 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Sat, 14 Jan 2023 19:06:29 +0200 In-reply-to: <87wn5q9epc.fsf@gnu.org> Message-ID: <87bkn1m4dj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: And here is a second patch adding documentation to gdcm 3.0.20 From 9ec1adbf72f3b122a484fe449e3b950fcee4b221 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= Date: Sat, 14 Jan 20 [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.171 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.171 listed in list.dnswl.org] X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: And here is a second patch adding documentation to gdcm 3.0.20 From 9ec1adbf72f3b122a484fe449e3b950fcee4b221 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= Date: Sat, 14 Jan 20 [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.171 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.171 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain And here is a second patch adding documentation to gdcm 3.0.20 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-gdcm-Add-documentation.patch Content-Transfer-Encoding: quoted-printable >From 9ec1adbf72f3b122a484fe449e3b950fcee4b221 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D Date: Sat, 14 Jan 2023 19:03:39 +0200 Subject: [PATCH] gnu: gdcm: Add documentation. --- gnu/packages/bioinformatics.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.= scm index 5b886526ad..aa54ec7ff7 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -93,6 +93,7 @@ (define-module (gnu packages bioinformatics) #:use-module (gnu packages gawk) #:use-module (gnu packages gcc) #:use-module (gnu packages gd) + #:use-module (gnu packages ghostscript) #:use-module (gnu packages golang) #:use-module (gnu packages glib) #:use-module (gnu packages graph) @@ -17854,8 +17855,16 @@ (define-public gdcm (base32 "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) (build-system cmake-build-system) + (outputs '("out" "doc")) (arguments (list + #:phases + #~(modify-phases %standard-phases + (add-before 'build 'set-HOME + ;; The build spams =E2=80=98Fontconfig error: No writable= cache + ;; directories=E2=80=99 in a seemingly endless loop other= wise. + (lambda _ + (setenv "HOME" "/tmp")))) #:configure-flags #~(list "-DGDCM_BUILD_TESTING=3Dtrue" (string-append "-DCMAKE_CTEST_ARGUMENTS=3D-E;" @@ -17863,7 +17872,13 @@ (define-public gdcm "|TestElement2" "|TestSCUValidation" "|TestEcho" - "|TestFind'")))) + "|TestFind'") + "-DGDCM_DOCUMENTATION:BOOL=3DON" + "-DGDCM_PDF_DOCUMENTATION:BOOL=3DON" + (string-append "-DGDCM_INSTALL_DOC_DIR=3D" + #$output:doc "/share/doc/" #$name) + "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF"))) ; TODO: need = =E2=80=98xsl-ns=E2=80=99 + (native-inputs (list doxygen ghostscript graphviz texlive)) (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") (synopsis "Grassroots DICOM library") (description --=20 2.38.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cheers, Tor-bj=C3=B6rn Claesson --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 14:38:13 2023 Received: (at 60640) by debbugs.gnu.org; 14 Jan 2023 19:38:13 +0000 Received: from localhost ([127.0.0.1]:55610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGmM1-0007J2-DP for submit@debbugs.gnu.org; Sat, 14 Jan 2023 14:38:13 -0500 Received: from mail-lf1-f46.google.com ([209.85.167.46]:43849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGmLz-0007Ij-P2 for 60640@debbugs.gnu.org; Sat, 14 Jan 2023 14:38:12 -0500 Received: by mail-lf1-f46.google.com with SMTP id f34so37547013lfv.10 for <60640@debbugs.gnu.org>; Sat, 14 Jan 2023 11:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=H40FKu0OpkYCEUGHrzEcRMhsAgCoIHfjWJdvaU+A3+k=; b=I51+TJrcdWr0qveNwv5rHgKLqexIfR2B1YL1ZY6G6YOGToE0UInhJCiksxdu0zzw6o J61pKzQnHrtu5qw/LASNua6jsu0y69h92GKI1AcS8FZl2d6caPsk4y5SJ1e+BBc4VkyL VGM487V1Rb7W2vNtfreeePdfbOrF329BMKPgYra8+EzKUbBte04gJeWwwvoowxuRkXOF qRsmzI5zVr2I4WPiYvb5VKl6mtD+sG4GFjCuTNYDuJmlgD/m5VGpYCKr1GLsxZEY83gJ qoywA2mNygG+bTu/LJ66dGsrh7SwMkGooxKi5cTFnytrgkO+yiZNT2WouGT/nSmbxXgI uLKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H40FKu0OpkYCEUGHrzEcRMhsAgCoIHfjWJdvaU+A3+k=; b=irB4JRUR0wnFJn3EU/IPVAjI3sd3bg5tJlG6KoBnvs6AxlHuaY/kB5R3gBVfinvfVy TcpJhjbKdtIyoeglIJeyb2/iZZ5XrKrveh5c6QVFr1dIAwibONv5G5vEvmsm5efMN1I7 J08dS/dRTllXCTmkpT8b/7EiX0kmaZHuRBe53qEW0xhtow03IrI6JfDXjqdaxM0HXG6d uAaTrLfg9SJ2xIXdkrez2454TIy46UIU9yuwXP7B+uRxaPbKLr5n/KLQ4yujQ6KtJSn0 TD1aUqUIP4197Os+6DPXASGW26hyU6kWXmNfIK31DCqdRs/IKGq58nt49tL7jVJXz4vp YHsQ== X-Gm-Message-State: AFqh2kpx6X4c0xPT5PA4UbW6fziKU/TXX+UBXXSa3JvGYU6JuDIV5+TS Tm/pBISOvR1E0RiwTO99JFmrVAQI1wo= X-Google-Smtp-Source: AMrXdXvInbt1jeUf+WYO02AfgVM78x9Kb2Elybrb8bbuSIlJ1x38LUqXluK40qRgppwMhrs6U+vBqQ== X-Received: by 2002:a19:a40b:0:b0:4b5:9183:5ad0 with SMTP id q11-20020a19a40b000000b004b591835ad0mr1367055lfc.63.1673725085244; Sat, 14 Jan 2023 11:38:05 -0800 (PST) Received: from barbar ([193.64.204.56]) by smtp.gmail.com with ESMTPSA id b21-20020a056512305500b004cf07a0051csm1082847lfb.228.2023.01.14.11.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 11:38:04 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Sat, 14 Jan 2023 21:34:44 +0200 In-reply-to: <87wn5q9epc.fsf@gnu.org> Message-ID: <877cxonbz7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: And here is a patch which adds a "bin" output containing various utility-programs. Sorry for some slight spamming, but things suddenly started working=) With this I think the package is functionally c [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.46 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.46 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: And here is a patch which adds a "bin" output containing various utility-programs. Sorry for some slight spamming, but things suddenly started working=) With this I think the package is functionally c [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.46 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.46 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable And here is a patch which adds a "bin" output containing various utility-programs. Sorry for some slight spamming, but things suddenly start= ed working=3D) With this I think the package is functionally complete and I will move on to using system libraries. Cheers, Tor-bj=C3=B6rn Claesson --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-gdcm-Add-output-bin.patch Content-Transfer-Encoding: quoted-printable >From 1b680bf73c6a62efd40d608c25e9b7815f03d786 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D Date: Sat, 14 Jan 2023 21:17:23 +0200 Subject: [PATCH] gnu: gdcm: Add output "bin" --- gnu/packages/bioinformatics.scm | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.= scm index aa54ec7ff7..e45d33ec2b 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -17855,29 +17855,41 @@ (define-public gdcm (base32 "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) (build-system cmake-build-system) - (outputs '("out" "doc")) + (outputs '("out" "bin" "doc")) (arguments (list #:phases #~(modify-phases %standard-phases (add-before 'build 'set-HOME - ;; The build spams =E2=80=98Fontconfig error: No writable= cache - ;; directories=E2=80=99 in a seemingly endless loop other= wise. - (lambda _ - (setenv "HOME" "/tmp")))) + ;; The build spams =E2=80=98Fontconfig error: No writable cache + ;; directories=E2=80=99 in a seemingly endless loop otherwise. + (lambda _ + (setenv "HOME" "/tmp"))) + (add-after 'install 'move-files + ;; Move utilities to bin output. + (lambda _ + (mkdir-p (string-append #$output:bin "/bin")) + (rename-file + (string-append #$output "/bin") + (string-append #$output:bin "/bin"))))) #:configure-flags #~(list "-DGDCM_BUILD_TESTING=3Dtrue" (string-append "-DCMAKE_CTEST_ARGUMENTS=3D-E;" "'TestFileMetaInformation" "|TestElement2" "|TestSCUValidation" + "|gdcmscu-echo-dicomserver" + "|gdcmscu-find-dicomserver" "|TestEcho" "|TestFind'") + ;; Documentation "-DGDCM_DOCUMENTATION:BOOL=3DON" "-DGDCM_PDF_DOCUMENTATION:BOOL=3DON" (string-append "-DGDCM_INSTALL_DOC_DIR=3D" #$output:doc "/share/doc/" #$name) - "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF"))) ; TODO: need = =E2=80=98xsl-ns=E2=80=99 + "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF" ;; TODO: need =E2= =80=98xsl-ns=E2=80=99 + ;; Utilities + "-DGDCM_BUILD_APPLICATIONS:BOOL=3DON"))) (native-inputs (list doxygen ghostscript graphviz texlive)) (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") (synopsis "Grassroots DICOM library") --=20 2.38.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 17:00:32 2023 Received: (at 60640) by debbugs.gnu.org; 14 Jan 2023 22:00:32 +0000 Received: from localhost ([127.0.0.1]:55696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGoZk-0002cq-30 for submit@debbugs.gnu.org; Sat, 14 Jan 2023 17:00:32 -0500 Received: from mail-lf1-f41.google.com ([209.85.167.41]:39763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGoZg-0002cZ-0V for 60640@debbugs.gnu.org; Sat, 14 Jan 2023 17:00:30 -0500 Received: by mail-lf1-f41.google.com with SMTP id bf43so37870792lfb.6 for <60640@debbugs.gnu.org>; Sat, 14 Jan 2023 14:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=zQnpxs6UKO5mVKO6eyCvUA4P0dxcC/I7nsO0P9G3mMg=; b=J75PtHscN65ndA8KER+0mPEuJzt9eVC5CrjKd9ybAZ7/Px/wjsO5ialYQF9rwFvnsk J6z/wDsB7SivwPJ8/n3JRhrA4vb9bk0AOcNneI0cqRlpeo+4rdcVUzFy1/aGGGoQ2rs5 E3w2Qa1UvoNfeUr2s3mHgAeZ9yRVZ7jx5SEwMAhUz6bLXsiQ1rf3HmYgBcdSW14Avw+W mzqXryyiJ7JMu1CoxThmS8p4WqthBsnMHPPgBPaBCi/jVn4kg6L3HkcJw+3HGWdTOs9O RabzcXdGHr95cX7jX9uXDihvY+PgkRwmL4HMMRSwnLTKfJZmhVs/kvHerGdU4/YtfxiX HJ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zQnpxs6UKO5mVKO6eyCvUA4P0dxcC/I7nsO0P9G3mMg=; b=gSv0VEjOaFb9ANsT2p5ypJH0NpvW0q/ORckIv++OzRuVXptxDcPLybfUnIiWLSFxPR NOX6YyIJV0vLgXQ2Loal+DlFQHvim9EDJxGq6//zbDUk1d7N48A4Z0kn0zt2ImLZgPPK e8y0WZ/HiFhyPfsLBXsjotbmAraX1oxc0mo2CycttT+IeWzB02tFaanka93253AHbqjS m19E5gF2SlYAPfoCs4a4Krnoexc4gVVai5+oUzviTTk4BR745YieYSLvtqnL6NhClrKp Dcb1e1HMoMjGbAW0pxG5y/IMIa0Jf6e1CARzqqwlr6aukXSTgxcefzVbSmAHnHMdJl3n qekA== X-Gm-Message-State: AFqh2kpz4Ci7uFJ1afBh82bDB+ALwGJoO9JbVeWc6H6B9HUlrkqx28+8 2PebJ7hmCKMEp7XqKeESc6XEPbbCtz4= X-Google-Smtp-Source: AMrXdXvODNhGWzGc2HBfXR3+PGsU29ttDaxYuLwO9W9x2LJu0LezKJm9kfYqJN8gEg2ZSSlc9RMUZQ== X-Received: by 2002:ac2:446b:0:b0:4b5:8504:feea with SMTP id y11-20020ac2446b000000b004b58504feeamr20702473lfl.24.1673733621619; Sat, 14 Jan 2023 14:00:21 -0800 (PST) Received: from barbar (mobile-access-d98cd1-67.dhcp.inet.fi. [217.140.209.67]) by smtp.gmail.com with ESMTPSA id h21-20020a0565123c9500b004d468ed2ce3sm432205lfv.173.2023.01.14.14.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 14:00:20 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Sat, 14 Jan 2023 23:58:43 +0200 In-reply-to: <87wn5q9epc.fsf@gnu.org> Message-ID: <87358cn5e4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable And here is the last patch, which uses system packages where possible. All nice things in these patches are thanks to the help of Tobias, any screwups are mine. Thanks! Tor-bj=C3=B6rn --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-gdcm-Use-system-packages-where-possible.patch Content-Transfer-Encoding: quoted-printable >From 77a7609eb727c53028846d0bf54204cdf9f58f9c Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D Date: Sat, 14 Jan 2023 23:56:43 +0200 Subject: [PATCH] gnu: gdcm: Use system packages where possible. --- gnu/packages/bioinformatics.scm | 47 +++++++++++++++++++++++++++++++-- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.= scm index e45d33ec2b..41709fd9ed 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -17853,7 +17853,29 @@ (define-public gdcm (file-name (git-file-name name version)) (sha256 (base32 - "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) + "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")) + (modules '((guix build utils) + (ice-9 ftw))) + (snippet + '(begin + (define (unbundle? file) + (member file '("dicom3tools" + "gdcmexpat" + "gdcmutfcpp" + "gdcmuuid" + "gdcmzlib" + "getopt" + "KWStyle" + "pvrg" + "Release" + "Release" + "VTK"))) + (with-directory-excursion "Utilities" + (for-each (lambda (utility) + (delete-file-recursively utility) + (substitute* "CMakeLists.txt" + (((string-append ".*/" utility "/.*")) "= "))) + (scandir "." unbundle?))))))) (build-system cmake-build-system) (outputs '("out" "bin" "doc")) (arguments @@ -17882,6 +17904,20 @@ (define-public gdcm "|gdcmscu-find-dicomserver" "|TestEcho" "|TestFind'") + ;; Libraries + "-DGDCM_USE_SYSTEM_EXPAT:BOOL=3DON" + "-DGDCM_USE_SYSTEM_JSON:BOOL=3DON" + "-DGDCM_USE_SYSTEM_LIBXML2:BOOL=3DON" + "-DGDCM_USE_SYSTEM_OPENSSL:BOOL=3DON" + "-DGDCM_USE_SYSTEM_POPPLER:BOOL=3DON" + "-DGDCM_USE_SYSTEM_UUID:BOOL=3DON" + "-DGDCM_USE_SYSTEM_ZLIB:BOOL=3DON" + ;; TODO: Unbundle these if possible. + "-DGDCM_USE_SYSTEM_CHARLS:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_LJPEG:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_OPENJPEG:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_PAPYRUS3:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_SOCKETXX:BOOL=3DOFF" ;; Documentation "-DGDCM_DOCUMENTATION:BOOL=3DON" "-DGDCM_PDF_DOCUMENTATION:BOOL=3DON" @@ -17890,7 +17926,14 @@ (define-public gdcm "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF" ;; TODO: need =E2= =80=98xsl-ns=E2=80=99 ;; Utilities "-DGDCM_BUILD_APPLICATIONS:BOOL=3DON"))) - (native-inputs (list doxygen ghostscript graphviz texlive)) + (inputs (list expat + json-c + libxml2 + openssl + poppler + `(,util-linux "lib") + zlib)) + (native-inputs (list doxygen ghostscript graphviz pkg-config texlive)) (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") (synopsis "Grassroots DICOM library") (description --=20 2.38.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 09:36:22 2023 Received: (at 60640) by debbugs.gnu.org; 17 Jan 2023 14:36:22 +0000 Received: from localhost ([127.0.0.1]:36200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHn4X-0001C9-VZ for submit@debbugs.gnu.org; Tue, 17 Jan 2023 09:36:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHn4W-0001Bw-Dg for 60640@debbugs.gnu.org; Tue, 17 Jan 2023 09:36:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHn4N-0004WQ-GU; Tue, 17 Jan 2023 09:36:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AtwN1kqdT//amsHJGBPauvrSSRsuVcZPSkc1eJqlris=; b=N+sZPhHGfJrvzDEcLgI2 rsX9NpSrLpyDwbHnyTiQYpv7csqrvILOXlImMVmPZ09qnVhoaGyId3dl3p5kLJejG+WoevbDTkMKm VGe8kPD596hgqwM0MRLYJG5xhmR2AMqpmVbQB60G1WETUWXL9tiSWcag5tRrfUa5zuRYNeJHEw04U pgg1QkZ0ptygmTc56WmdZN3qIBlRFXq6junLdBTh0aH3h/HapEOTzshIE2GTwmuZNzIJmmoT4UpxX e+s72lb/SBP7ugUUG5viY7sRorPuVA6j8b5qeHjm4bbQNdv7E/m8244+PLiTIvvdgqJdagZJCFlqR U5UVDyYoA3oVUg==; Received: from [193.50.110.246] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHn4M-0004WA-OE; Tue, 17 Jan 2023 09:36:11 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: bug#60640: Gnu: Add gdcm References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87fscdmpgu.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 =?utf-8?Q?Niv=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Zinc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Jan 2023 15:36:03 +0100 In-Reply-To: <87fscdmpgu.fsf@gmail.com> (=?utf-8?Q?=22Tor-bj=C3=B6rn?= Claesson"'s message of "Sat, 14 Jan 2023 11:30:29 +0200") Message-ID: <87a62hi5yk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Tor-bj=C3=B6rn Claesson skribis: > From f4cd5077a762f25a9fa271329a798f324e4db685 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D > Date: Sat, 14 Jan 2023 11:23:58 +0200 > Subject: [PATCH] gnu: gdcm: Update to 3.0.20. > > --- > gnu/packages/bioinformatics.scm | 8 ++++---- Applied with a commit log following our conventions. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 09:38:16 2023 Received: (at 60640) by debbugs.gnu.org; 17 Jan 2023 14:38:16 +0000 Received: from localhost ([127.0.0.1]:36222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHn6K-0001Fk-UM for submit@debbugs.gnu.org; Tue, 17 Jan 2023 09:38:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHn6J-0001FX-7y for 60640@debbugs.gnu.org; Tue, 17 Jan 2023 09:38:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHn6D-0004r2-VW; Tue, 17 Jan 2023 09:38:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=VdNcqwZ26c5H0pSpjtP+bvm2+Ns9N8HX0WgPhJyEBgA=; b=pfFeqGCbZL8oNXl+0fO9 /9XFp1FM8JaEh67lY/+9JF9Q8QHodz8HqVswlmW/P3eIPnDjZWYilm1k+SDEnyspszNgrQeqi1cBu 1IPR4r9P98dwpqOsaEMYEvt+7j61ITbdvh28unCl5aAle/TqGASuc2mxPptzCOCG3APyPfH11eWEy xoIGazIXEJ7wINHZNyYKOHxQwtZRWbER+qJI5U4MP/Sq9HPZO+9/D603LPLTehlHqwNwqPeqz4lXG Rr8l+kXIruNQbOuW/GFEMhT7FcqCqS7x8QFNMLUhjNqwFlVXbF2DseM3UBDjsvgKxf0gpYB1/0ET0 FLkKxZSUWEmKkw==; Received: from [193.50.110.246] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHn6D-0004qk-9w; Tue, 17 Jan 2023 09:38:05 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: bug#60640: Gnu: Add gdcm References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 =?utf-8?Q?Niv=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Zinc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Jan 2023 15:38:03 +0100 In-Reply-To: <87bkn1m4dj.fsf@gmail.com> (=?utf-8?Q?=22Tor-bj=C3=B6rn?= Claesson"'s message of "Sat, 14 Jan 2023 19:06:29 +0200") Message-ID: <875yd5i5v8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tor-bj=C3=B6rn Claesson skribis: > From 9ec1adbf72f3b122a484fe449e3b950fcee4b221 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D > Date: Sat, 14 Jan 2023 19:03:39 +0200 > Subject: [PATCH] gnu: gdcm: Add documentation. > > --- > gnu/packages/bioinformatics.scm | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) [...] > + "-DGDCM_DOCUMENTATION:BOOL=3DON" > + "-DGDCM_PDF_DOCUMENTATION:BOOL=3DON" > + (string-append "-DGDCM_INSTALL_DOC_DIR=3D" > + #$output:doc "/share/doc/" #$name) > + "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF"))) ; TODO: need= =E2=80=98xsl-ns=E2=80=99 > + (native-inputs (list doxygen ghostscript graphviz texlive)) In general, we don=E2=80=99t install documentation as PDF/PS, unless there= =E2=80=99s no other choice (preferred formats are Info, man pages, and HTML). Is there such an option? Furthermore, we shouldn=E2=80=99t depend on =E2=80=98texlive=E2=80=99, whic= h is the big monolithic package: https://guix.gnu.org/manual/devel/en/html_node/Using-TeX-and-LaTeX.html Could you send an updated patch? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 14:22:27 2023 Received: (at 60640) by debbugs.gnu.org; 17 Jan 2023 19:22:27 +0000 Received: from localhost ([127.0.0.1]:38306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHrXO-0001Ug-Uw for submit@debbugs.gnu.org; Tue, 17 Jan 2023 14:22:27 -0500 Received: from mail-il1-f176.google.com ([209.85.166.176]:44719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHrXL-0001US-8l for 60640@debbugs.gnu.org; Tue, 17 Jan 2023 14:22:25 -0500 Received: by mail-il1-f176.google.com with SMTP id h26so15875458ila.11 for <60640@debbugs.gnu.org>; Tue, 17 Jan 2023 11:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=c98GIKaGjJQMiTIRB3zwBdgJ8MmoqC+u/Ksg3bDX13E=; b=H7gdSgqtJ4h6BrdaXjuc+01C/VXsPObTtQedNcmW2M6XuGtqGDLqg8P/h2SKi86PR/ L0faUH6SzhIz6aVkCY140BoRgGapMdbuw8MzyarTJFVNAwAbmYB5UiiBLnkbVn2YLQe7 gaohH8AXEG5IprXj1JrbwiodDj1hBy1XAPqEBCu5YP0zrY8A0m5sH/YpNIZxEQEzniQI IbVi+xIqf0iQ5xaskABt3B48e3TWGDrGzrBAZ9Wa1ILtWZFHXBmgBxlNFWapMXhYASmX hJ0ZYCOO7bheFWPrtQSxFScPgZx+KVboFSv5ys6sHNnN3rrPz92QgdfGCatiTnpuECBV ORXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c98GIKaGjJQMiTIRB3zwBdgJ8MmoqC+u/Ksg3bDX13E=; b=BDyiSdvdZWEwyJjcyrqJXNCxCG5x4NqVAm6cFLd7On0GMr3bNolRw+O5mb1vRkcLhk oTKermVOZBl5WeCh5yFwUqLimNbOGLR7eCYHXQZcUdv3AL7yyLZZ5/aK94MogYbZZFLL 0+pxZGfELXXp6ZPyEqK14UJBO9jBlXqII8EJ12Ap45OSWiP2PXcaQbt15by1bLqBFegR eh9cZB8e4nCPbc/Zf1eGZ02jsnWihfLpQxVlj1kTiIdDLoSseJgSW9erST8EdfkXYCwq J3bFRBk/cBSflzGPgogjPb4zbSwqrM9hq6MQWFmFgYd0apprjCFFRoTkTRD87X5dxJqX w8JA== X-Gm-Message-State: AFqh2kpj1FrN57u2Jtref0igUIf4xbSlIP/PLELPWV1GZcMgPxOCL3q5 PGdePqpt3HhKZEvrMb42BEDCDpdjIy8= X-Google-Smtp-Source: AMrXdXtNueyF0G3nLtsfWvq947m/de98cw9OWjlsT1QQJnkgekF4lcS2WtEFT5p2e6fX90UheXXuLA== X-Received: by 2002:a05:6e02:5c6:b0:30c:2bb4:a2dc with SMTP id l6-20020a056e0205c600b0030c2bb4a2dcmr3506638ils.22.1673983336989; Tue, 17 Jan 2023 11:22:16 -0800 (PST) Received: from barbar (212-90-81-204.bb.dnainternet.fi. [212.90.81.204]) by smtp.gmail.com with ESMTPSA id q12-20020a05663810cc00b003a36ce2cd5asm2680589jad.160.2023.01.17.11.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 11:22:16 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Tue, 17 Jan 2023 21:21:17 +0200 In-reply-to: <875yd5i5v8.fsf@gnu.org> Message-ID: <878ri1rmor.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Ludovic Court=C3=A8s writes: > In general, we don=E2=80=99t install documentation as PDF/PS, unless ther= e=E2=80=99s no > other choice (preferred formats are Info, man pages, and HTML). > > Is there such an option? > > Furthermore, we shouldn=E2=80=99t depend on =E2=80=98texlive=E2=80=99, wh= ich is the big > monolithic package: > > https://guix.gnu.org/manual/devel/en/html_node/Using-TeX-and-LaTeX.html > Thanks for the feedback! Here is an updated patch. --=20 Cheers, Tor-bj=C3=B6rn Claesson --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-gdcm-Add-documentation.patch Content-Transfer-Encoding: quoted-printable >From 4cab625e857c3a63dcfce10b7c03f06b173014a9 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D Date: Sat, 14 Jan 2023 19:03:39 +0200 Subject: [PATCH] gnu: gdcm: Add documentation. --- gnu/packages/bioinformatics.scm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.= scm index e60dffc21e..d534734cb2 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -17853,8 +17853,16 @@ (define-public gdcm (base32 "1w78cmm9q7aavs7svdkl4dgilcqk4yazci9m6x7icrssb7cj991i")))) (build-system cmake-build-system) + (outputs '("out" "doc")) (arguments (list + #:phases + #~(modify-phases %standard-phases + (add-before 'build 'set-HOME + ;; The build spams =E2=80=98Fontconfig error: No writable= cache + ;; directories=E2=80=99 in a seemingly endless loop other= wise. + (lambda _ + (setenv "HOME" "/tmp")))) #:configure-flags #~(list "-DGDCM_BUILD_TESTING=3Dtrue" (string-append "-DCMAKE_CTEST_ARGUMENTS=3D-E;" @@ -17862,7 +17870,13 @@ (define-public gdcm "|TestElement2" "|TestSCUValidation" "|TestEcho" - "|TestFind'")))) + "|TestFind'") + "-DGDCM_DOCUMENTATION:BOOL=3DON" + "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF" + (string-append "-DGDCM_INSTALL_DOC_DIR=3D" + #$output:doc "/share/doc/" #$name) + "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF"))) ; TODO: need = =E2=80=98xsl-ns=E2=80=99 + (native-inputs (list doxygen graphviz)) (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") (synopsis "Grassroots DICOM library") (description --=20 2.38.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 20 06:31:10 2023 Received: (at 60640) by debbugs.gnu.org; 20 Jan 2023 11:31:10 +0000 Received: from localhost ([127.0.0.1]:45745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIpby-00031f-5c for submit@debbugs.gnu.org; Fri, 20 Jan 2023 06:31:10 -0500 Received: from mail-ej1-f43.google.com ([209.85.218.43]:34473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIpbu-000318-3L for 60640@debbugs.gnu.org; Fri, 20 Jan 2023 06:31:08 -0500 Received: by mail-ej1-f43.google.com with SMTP id az20so13224309ejc.1 for <60640@debbugs.gnu.org>; Fri, 20 Jan 2023 03:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vkmHYMvc5s/RhObAt0Vdl1sdvViGqHjvPnTHYMBbWvU=; b=pzOkVzXgpTnE4c24kBzgJUN9DaJAnb0Pi/nTMZ6uhnLvU4htFGK0Ta+Mp1jJcW+Oau WDbpBpbSiwCJIjX8Ni9sUCJXvnB4YmXewgQZo0w9VQErz8NZmlBhLn2mhilhByaiiv0P xgZvP20dvVmrgplAcq50x8XkJmItXXQA/VKlUB1dF9u+n4MGExYmy6QYsSjS2+G0yKGW mw+w23oLoFaRUtMzU/MFZNLWFqkrd3URIAgyyA6FrYqqH/ZZ9yjxi9t17Ily7CrYB4Qp /U4U1rDd3E7RPr9Ucolw9d1l4NUFPGH08+3QJPFB66P5QeO23qdEQMWksqwbk/c8DMwK LD4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vkmHYMvc5s/RhObAt0Vdl1sdvViGqHjvPnTHYMBbWvU=; b=Xty/Z1uI49EjcTu6238nfvxF06PpSf2nQueTWQjrZ9p2vPcBM+dQToj6XcVnpxYNGe 6gscKN1v32tususSstRzGicNROcdDnjp/dga4gqPZZbFmGxx+Etnrtd7zn5ZSTwpLRQD 4mbozsbgBoNWeSipQaWc7q2Z8VI162MkHqIg3oXjLXQ3gnvKn36dbvg4VauCDp4Wo1N/ ck6TrxjwUD/guYgQRIwh27siL/1JsA3RGNgGbvUqgzGyr1mA9ifcdaLtBS9VSThs6jP9 2YoNCAEND9UwxQlUclChDDLdZkM1NuDO1HCxfaYpqcXCxR72cCoSXPmccYz5iA2p5xtI e/pw== X-Gm-Message-State: AFqh2kr0KlMj+a0URyumUaPAEMprWU6E7JDEA6Uo15HEaf4971ygb8tn UlznSi6Z0I4J1WlV7di0nzlonvKqez9W73AP8omcI9KB X-Google-Smtp-Source: AMrXdXsfOGEXxIyrX2C2D5JrPaCWj3tlRu6oKL1VJD493nN86F830utXfXpoZrIhTZObIH1OCI54iO+6obfIsraL6Pg= X-Received: by 2002:a17:906:c315:b0:84d:3fa0:ee4f with SMTP id s21-20020a170906c31500b0084d3fa0ee4fmr1106384ejz.71.1674214259713; Fri, 20 Jan 2023 03:30:59 -0800 (PST) MIME-Version: 1.0 References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> In-Reply-To: <875yd5i5v8.fsf@gnu.org> From: =?UTF-8?Q?Tor=2Dbj=C3=B6rn_Claesson?= Date: Fri, 20 Jan 2023 13:30:48 +0200 Message-ID: Subject: Re: bug#60640: Gnu: Add gdcm To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="0000000000003a6d3405f2b06282" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003a6d3405f2b06282 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Den tis 17 jan. 2023 kl 16:38 skrev Ludovic Court=C3=A8s : > > In general, we don=E2=80=99t install documentation as PDF/PS, unless ther= e=E2=80=99s no > other choice (preferred formats are Info, man pages, and HTML). > > Is there such an option? > The new version of the patch builds HTML documentation, but not man-pages (because of a xsl-requirement and including libxslt as a native input causes the build to fail.) I wrote the previous answer in a rush, and failed to properly address this question. For this I apologize, it was not meant to be disrespectful. Tor-bj=C3=B6rn --0000000000003a6d3405f2b06282 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Den ti= s 17 jan. 2023 kl 16:38 skrev Ludovic Court=C3=A8s <ludo@gnu.org>:

In general, we don=E2=80=99t install documentation as PDF/PS, unless there= =E2=80=99s no
other choice (preferred formats are Info, man pages, and HTML).

Is there such an option?
The new version of the patch = builds HTML documentation, but not man-pages (because of a xsl-requirement = and including libxslt as a native input causes the build to fail.)

I wrote the previous answer in a rush, and failed to p= roperly address this question. For this I apologize, it was not meant to be= disrespectful.

Tor-bj=C3=B6rn
--0000000000003a6d3405f2b06282-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 20 07:44:22 2023 Received: (at 60640) by debbugs.gnu.org; 20 Jan 2023 12:44:22 +0000 Received: from localhost ([127.0.0.1]:45799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIqko-0007Cu-D0 for submit@debbugs.gnu.org; Fri, 20 Jan 2023 07:44:22 -0500 Received: from mail-ed1-f51.google.com ([209.85.208.51]:43965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIqkm-0007Cg-K5 for 60640@debbugs.gnu.org; Fri, 20 Jan 2023 07:44:21 -0500 Received: by mail-ed1-f51.google.com with SMTP id x10so6598132edd.10 for <60640@debbugs.gnu.org>; Fri, 20 Jan 2023 04:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YgEp3a4QAH84hNWysu4sA/YbCTCsqUhH9zMyaJUxh58=; b=hPf71scYCcDk3qQ4gm4GB3/YKYxbpVeSAj4RDF7QJvBGsByKA2E79LaTXF79XGA6wQ G60z23uX0qzkqIVDWCU3ZSYEmjBOXGrTLzLFpF/xk0X98Tp6QHlU5Jx17Obk+PhY628z dg1IKXNJi1gvyUgH97uQBudR0wnOc3PssJFbIBE7sx4hSWxYMYhAswxpV0JUcOtdSvBN PGbbCCK04Ij3HcRq40CQi5QwlxAVRZxa5A5RfcIwqSfSh8z8/dYd7n1e0lT+ABbPL81L S1boFuZm0tiz4BfTyOwmwmpCb62gZikIPRr29gWOUKdgciV78rAuSnhmjeBtllnKlr2Q CPWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YgEp3a4QAH84hNWysu4sA/YbCTCsqUhH9zMyaJUxh58=; b=1qMtmtEcJhXETc5p1ihT4bVOJJjA40rHOwiLs2cPhT59yBnrCHwyqBS/AXkWUXrgCJ loaUbLYDUFG1Mgrejtqd0BTrudDuRtS/n/czVSiD3LSZ7jqecJBBNMwkLGteLPhgZYUz nFrucKQmfVqshyW58YlARef9o9UWhXLa9nxfxwUEbK4VfH4LkWdkv3ea78XPcgUFUwzg Os/EkelBrx6zUGPxTAreaDIKB60jkQ90Zvpqp0nvxziSoLd6jn+aQDxN80K10n83w0pS gFMbhhcokLEr1QztQlC6/Bw1v2Zlc+41pUHTAfboS/BdJT9WKwYkqMJPSjeonxvZdE9p Wbrg== X-Gm-Message-State: AFqh2kpRg4R4f1ex3uptDsCWV3rT9zVOguhZ2DIvco9HVq8TD5VqTq4g Xu9rXj2UN1sfLEOnovBPsrzVfUVqdS7k7hSBhOY= X-Google-Smtp-Source: AMrXdXtYHP+vd+gjEU1QGqLSuLWvM0JO+S9/P6xL6Fl/Pk/x0uGaLUKGaKYWTNLkSi70Cca3+XB1Xm9YREr+o0tQPzM= X-Received: by 2002:a05:6402:22f7:b0:49b:651d:7930 with SMTP id dn23-20020a05640222f700b0049b651d7930mr1691084edb.79.1674218654291; Fri, 20 Jan 2023 04:44:14 -0800 (PST) MIME-Version: 1.0 References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> In-Reply-To: From: =?UTF-8?Q?Tor=2Dbj=C3=B6rn_Claesson?= Date: Fri, 20 Jan 2023 14:44:02 +0200 Message-ID: Subject: Re: bug#60640: Gnu: Add gdcm To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/mixed; boundary="0000000000002a86f105f2b16820" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002a86f105f2b16820 Content-Type: multipart/alternative; boundary="0000000000002a86ee05f2b1681e" --0000000000002a86ee05f2b1681e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Also, I can't build gdcm from the main guix repo although it builds perfectly fine in my local checkout. The cause is three failing tests. Attached is a patch to ignore them. I'm really sorry about this. Is there something else I could have done to catch this before submitting? Tor-bj=C3=B6rn Claesson Den fre 20 jan. 2023 kl 13:30 skrev Tor-bj=C3=B6rn Claesson : > Hi, > > Den tis 17 jan. 2023 kl 16:38 skrev Ludovic Court=C3=A8s : > >> >> In general, we don=E2=80=99t install documentation as PDF/PS, unless the= re=E2=80=99s no >> other choice (preferred formats are Info, man pages, and HTML). >> >> Is there such an option? >> > The new version of the patch builds HTML documentation, but not man-pages > (because of a xsl-requirement and including libxslt as a native input > causes the build to fail.) > > I wrote the previous answer in a rush, and failed to properly address thi= s > question. For this I apologize, it was not meant to be disrespectful. > > Tor-bj=C3=B6rn > --0000000000002a86ee05f2b1681e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Also, I can't build gdcm from the main guix repo = although it builds perfectly fine in my local checkout. The cause is three = failing tests. Attached is a patch to ignore them.

I'm really sorry about this.
Is there something el= se I could have done to catch this before submitting?

<= div>Tor-bj=C3=B6rn Claesson

<= div dir=3D"ltr" class=3D"gmail_attr">Den fre 20 jan. 2023 kl 13:30 skrev To= r-bj=C3=B6rn Claesson <tclaesson@= gmail.com>:
Hi,

Den= tis 17 jan. 2023 kl 16:38 skrev Ludovic Court=C3=A8s <ludo@gnu.org>:

In general, we don=E2=80=99t install documentation as PDF/PS, unless there= =E2=80=99s no
other choice (preferred formats are Info, man pages, and HTML).

Is there such an option?
The new version of the patch = builds HTML documentation, but not man-pages (because of a xsl-requirement = and including libxslt as a native input causes the build to fail.)

I wrote the previous answer in a rush, and failed to p= roperly address this question. For this I apologize, it was not meant to be= disrespectful.

Tor-bj=C3=B6rn
--0000000000002a86ee05f2b1681e-- --0000000000002a86f105f2b16820 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-gdcm-Ignore-3-failing-tests.patch" Content-Disposition: attachment; filename="0001-gnu-gdcm-Ignore-3-failing-tests.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ld4ijd250 RnJvbSBlMWU4ZDE4YzRkYjlkZTRjOGY0NjM1NGJhM2ZjOTEyZjIzZWJlOWQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/VG9yLWJqPUMzPUI2cm49MjBDbGFlc3Nvbj89 IDx0Y2xhZXNzb25AZ21haWwuY29tPgpEYXRlOiBGcmksIDIwIEphbiAyMDIzIDE0OjM4OjM5ICsw MjAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBnZGNtOiBJZ25vcmUgMyBmYWlsaW5nIHRlc3RzLgoK LS0tCiBnbnUvcGFja2FnZXMvYmlvaW5mb3JtYXRpY3Muc2NtIHwgMyArKysKIDEgZmlsZSBjaGFu Z2VkLCAzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvYmlvaW5mb3Jt YXRpY3Muc2NtIGIvZ251L3BhY2thZ2VzL2Jpb2luZm9ybWF0aWNzLnNjbQppbmRleCBlNjBkZmZj MjFlLi5jMjNmNzMxNjg3IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvYmlvaW5mb3JtYXRpY3Mu c2NtCisrKyBiL2dudS9wYWNrYWdlcy9iaW9pbmZvcm1hdGljcy5zY20KQEAgLTE3ODYxLDYgKzE3 ODYxLDkgQEAgKGRlZmluZS1wdWJsaWMgZ2RjbQogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiJ1Rlc3RGaWxlTWV0YUluZm9ybWF0aW9uIgogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAifFRlc3RFbGVtZW50MiIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInxUZXN0U0NV VmFsaWRhdGlvbiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInxUZXN0V3JpdGVyIgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAifFRlc3RBbm9ueW1pemVyNCIKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgInxUZXN0UHJpbnRlcjEiCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJ8VGVzdEVjaG8iCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ8VGVz dEZpbmQnIikpKSkKICAgICAoaG9tZS1wYWdlICJodHRwczovL2dkY20uc291cmNlZm9yZ2UubmV0 L3dpa2kvaW5kZXgucGhwL01haW5fUGFnZSIpCi0tIAoyLjM4LjEKCg== --0000000000002a86f105f2b16820-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 17:01:49 2023 Received: (at 60640) by debbugs.gnu.org; 25 Jan 2023 22:01:49 +0000 Received: from localhost ([127.0.0.1]:60118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKnq0-0007Ax-SW for submit@debbugs.gnu.org; Wed, 25 Jan 2023 17:01:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKnpy-0007Ai-FQ for 60640@debbugs.gnu.org; Wed, 25 Jan 2023 17:01:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKnpt-0001Ue-1N; Wed, 25 Jan 2023 17:01:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=1NSHhijcw3EByP8WFXxw5vZGaw2qhPDseYjol8nAY8M=; b=EDwOhLmcO3/8v1+EglZ0 xnkC49O8jAbL7zJp18fMhYlnwzUDfUmb646i4ISXWTUwQnfkGygAWeGUgEmkwZ1gaChJ5YJqQ92ta IuCtmdQfGZMyNCFjDX2FzkgGWrSbpvqVWyki9owlOqcL2nOWNC17Nwf87Wu5UcElYLRpRuK71B67Q MP7SZn58S7wW/+j/lcu7e5iB+RXq+0C1BkzTtrOxTcO+4L3GOeLCxnH0T3Ia8GLopDnzhyXFVi7UW 8FNF7+hK/T4pmDtMoa01e33EkHABY223eupVJW1aHKLsNkWjl5BYOMuJouDnvcXbDnIhGmL25q+H4 X6OnjGTSvjfg6w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKnps-0007cC-JD; Wed, 25 Jan 2023 17:01:40 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: bug#60640: Gnu: Add gdcm References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 =?utf-8?Q?Pluvi=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Laurier-thym X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 25 Jan 2023 23:01:38 +0100 In-Reply-To: (=?utf-8?Q?=22Tor-bj=C3=B6rn?= Claesson"'s message of "Fri, 20 Jan 2023 14:44:02 +0200") Message-ID: <87tu0es27x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Tor-bj=C3=B6rn Claesson skribis: > From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D > Date: Fri, 20 Jan 2023 14:38:39 +0200 > Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. > > --- > gnu/packages/bioinformatics.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatic= s.scm > index e60dffc21e..c23f731687 100644 > --- a/gnu/packages/bioinformatics.scm > +++ b/gnu/packages/bioinformatics.scm > @@ -17861,6 +17861,9 @@ (define-public gdcm > "'TestFileMetaInformation" > "|TestElement2" > "|TestSCUValidation" > + "|TestWriter" > + "|TestAnonymizer4" > + "|TestPrinter1" > "|TestEcho" Applied, thanks! It would be nice if you could investigate the test failures: they might reveal that something=E2=80=99s wrong with our packaging. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 17:23:09 2023 Received: (at 60640) by debbugs.gnu.org; 25 Jan 2023 22:23:09 +0000 Received: from localhost ([127.0.0.1]:60150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKoAf-0007hJ-6O for submit@debbugs.gnu.org; Wed, 25 Jan 2023 17:23:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKoAd-0007h7-FQ for 60640@debbugs.gnu.org; Wed, 25 Jan 2023 17:23:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKoAY-0006rT-6u; Wed, 25 Jan 2023 17:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=M/j/419Lu74SUmjZy2TVit5rkn04LQ0d2E9JMGrpbUw=; b=S8I9gjGMrKz6Qe5qivjY tTjUp8TlG700r7yYEZkRvMdX0A5L9cAMW21nttTnXLjJw6m6JBesTXEjD6mmx0O/Zqyn+2fZGw8Wa a+DjIsFwAloQYHOawQU8S9lRcVmx3x9NiZHk8sF1fG6/1woUlC82FO7KGeB+uKJdg6Mrtrh4tJ2tx AbtZLgieYs6+6xQYU28jC2Fd9xNTyBqynLUkaHBl4Y5AHuJeSQQ9NHA63YSLyXAO1gzZGp5Vkt9vy uT6A6uW55vfD3BqgwlE6agqSuzPqDwMPvLOedAdH3IbmEG7K3rdp4OLhptkgDpeB/24SD1jgabcj8 zodMHpbVQpZslw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKoAW-0006HU-FQ; Wed, 25 Jan 2023 17:23:01 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: bug#60640: Gnu: Add gdcm References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> <878ri1rmor.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 =?utf-8?Q?Pluvi=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Laurier-thym X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 25 Jan 2023 23:22:58 +0100 In-Reply-To: <878ri1rmor.fsf@gmail.com> (=?utf-8?Q?=22Tor-bj=C3=B6rn?= Claesson"'s message of "Tue, 17 Jan 2023 21:21:17 +0200") Message-ID: <87edris18d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tor-bj=C3=B6rn Claesson skribis: > From 4cab625e857c3a63dcfce10b7c03f06b173014a9 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D > Date: Sat, 14 Jan 2023 19:03:39 +0200 > Subject: [PATCH] gnu: gdcm: Add documentation. > > --- > gnu/packages/bioinformatics.scm | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) I added a commit log that follows our conventions and applied it, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 17:49:53 2023 Received: (at 60640) by debbugs.gnu.org; 25 Jan 2023 22:49:53 +0000 Received: from localhost ([127.0.0.1]:60169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKoaX-0008Rh-2e for submit@debbugs.gnu.org; Wed, 25 Jan 2023 17:49:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKoaU-0008RQ-Ag for 60640@debbugs.gnu.org; Wed, 25 Jan 2023 17:49:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKoaO-00072y-PP; Wed, 25 Jan 2023 17:49:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=8FSZC3pE9sgM8tGNwz9ZD093fxbHPZ5ylXx/ipFR24M=; b=EAz++kyql1a/6lWiVmp6 0HpOMBBiZ4NFcv0GfVLGdkf81Smbl6k3MRP7wg5lQsAYQjPaKSmAYERvRiIIN9PsjZas4lPPoXbu0 RSoc92dxlzmZ7mbipGEtLC8OC4VrhCCQ1Cy4iNRif/U0a3z/n41GguGVkfPeqDE8mwWGM/Jpl4ceH G/CMUCYe6uv4KvjN2fDpbh3as+Cf1+l8umt00DNZgADRoxNGoVKfT53FNpNu4nko5zndMMXgHw6Xm T4mWicI5JSVLd+yIEgS2oK/AaRfHIjy+ctIgXY71rWIV7yVbN/mIsJRv4poh5dm4bpbB0jl8/20pK KmNTY8cHamxXNw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKoaO-0005Xy-43; Wed, 25 Jan 2023 17:49:44 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson Subject: Re: bug#60640: Gnu: Add gdcm References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 =?utf-8?Q?Pluvi=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Laurier-thym X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 25 Jan 2023 23:49:40 +0100 In-Reply-To: (=?utf-8?Q?=22Tor-bj=C3=B6rn?= Claesson"'s message of "Fri, 20 Jan 2023 14:44:02 +0200") Message-ID: <878rhqrzzv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tor-bj=C3=B6rn Claesson skribis: > From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D > Date: Fri, 20 Jan 2023 14:38:39 +0200 > Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. Actually I=E2=80=99m seeing more test failures in a -c24 build: --8<---------------cut here---------------start------------->8--- 195/217 Test #195: TestStrictScanner1 .....................***Failed 0.0= 1 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporar= y/TestWriter Start 196: TestStrictScanner2_1 196/217 Test #196: TestStrictScanner2_1 ...................***Failed 0.0= 1 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporar= y/TestWriter Start 197: TestStrictScanner2 197/217 Test #197: TestStrictScanner2 .....................***Failed 0.0= 2 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporar= y/TestWriter Start 198: TestStrictScanner2_2 198/217 Test #198: TestStrictScanner2_2 ...................***Failed 0.0= 2 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporar= y/TestWriter [=E2=80=A6] 98% tests passed, 4 tests failed out of 217 Total Test time (real) =3D 596.45 sec The following tests FAILED: 195 - TestStrictScanner1 (Failed) 196 - TestStrictScanner2_1 (Failed) 197 - TestStrictScanner2 (Failed) 198 - TestStrictScanner2_2 (Failed) Errors while running CTest --8<---------------cut here---------------end--------------->8--- Passing #:parallel-tests? #f doesn=E2=80=99t help. Could you take a look? TIA, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 10:14:02 2023 Received: (at 60640) by debbugs.gnu.org; 27 Jan 2023 15:14:02 +0000 Received: from localhost ([127.0.0.1]:38256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLQQU-0006Ex-9O for submit@debbugs.gnu.org; Fri, 27 Jan 2023 10:14:02 -0500 Received: from mail-ej1-f48.google.com ([209.85.218.48]:46746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLQQP-0006EI-2I for 60640@debbugs.gnu.org; Fri, 27 Jan 2023 10:14:00 -0500 Received: by mail-ej1-f48.google.com with SMTP id p26so3307571ejx.13 for <60640@debbugs.gnu.org>; Fri, 27 Jan 2023 07:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=K6FODux5SAPSRqhuJkUcYfXRKj1GqUOc0xodbZZ9jV4=; b=KHNqJZ9HNWbVHmSvXj0lt78V/ZA3ts2a3BSmYvYgcDnqVB09xbzILLP4491xJQq6TR v1JMno5OX3zK9SuTUL6iUT6L+aq0XTmq2CgwOTAfWPdVYAmpTlWijAnjjLAPGYEzsVlV m7P+ExZWfoprAdpbGfMbVVAcoctYxfJOvpgrphauyA1OEfUus7Cs1PhYIG8fNPs0DH37 FLsW7T/uP18tMe5gSgltJbFp6VsCGaki5PQ2SpiiHjettzQi+3IC0cb438OUD/zAjcI0 E/IuUv8QkjQv8Ekj+0VMBF1daOwztffMWs0kMAtQCLAX/C9X6D0lCpL54+3xXyPZ71Ru xTuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K6FODux5SAPSRqhuJkUcYfXRKj1GqUOc0xodbZZ9jV4=; b=HD84JSNTjcU4Rxpf/oMODkoLo1gjVfjaCQxu6AJ+IJWMLzffzQLnh1wZxPXuhlBqmM UKzZqKnp2Qz7T4O4eKdOBg5GQJ7zOVH8FPen0C8Rm2uzpM7rtmNSr8QtOm1iw74O2mKi Rweqr+J+49XFQHXDok2onb1yj//NKZlB92PI1FIaLwhsBfbo0qsdgqu8FGGUvFKQ60Sz Z+2UIhMzMDL93L4lQx6uPzv1rkGsYNNkOs37YHntw/SjVUICPmjRzKnkEQzk1kAJgQJR V81DETKtOAaurKInurIOh9p/PG42V7GfTNVJkqv6TUbJYRcedukFz56AXG/HjTSYt1A3 cnaw== X-Gm-Message-State: AFqh2kpdVsfXQhU9f0GnxhyBxqj2LT0GN5LUKmsw9QAuyd21RWrwF5bD gq6z1kKvoJpRP0hh2mkWDOXhMVf8i0E= X-Google-Smtp-Source: AMrXdXuK9H/8D7gw74kBqMkUhxTauSSrodsjZeAGBiBJedaZ4d30lwFjV3QSmYBPtOUqYX9ZE00Y8g== X-Received: by 2002:a17:906:1485:b0:7d3:c516:6ef4 with SMTP id x5-20020a170906148500b007d3c5166ef4mr42753926ejc.20.1674832429687; Fri, 27 Jan 2023 07:13:49 -0800 (PST) Received: from barbar ([193.64.204.56]) by smtp.gmail.com with ESMTPSA id l23-20020a50d6d7000000b004a0b1d7e39csm2467266edj.51.2023.01.27.07.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 07:13:48 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> <878rhqrzzv.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Fri, 27 Jan 2023 17:06:37 +0200 In-reply-to: <878rhqrzzv.fsf@gnu.org> Message-ID: <878rhoxb6c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi! Ludovic Courtès writes: > > The following tests FAILED: > 195 - TestStrictScanner1 (Failed) > 196 - TestStrictScanner2_1 (Failed) > 197 - TestStrictScanner2 (Failed) > 198 - TestStrictScanner2_2 (F [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.218.48 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.48 listed in list.dnswl.org] X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi! Ludovic Courtès writes: > > The following tests FAILED: > 195 - TestStrictScanner1 (Failed) > 196 - TestStrictScanner2_1 (Failed) > 197 - TestStrictScanner2 (Failed) > 198 - TestStrictScanner2_2 (F [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.218.48 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [193.64.204.56 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.48 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tclaesson[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Ludovic Court=C3=A8s writes: > > The following tests FAILED: > 195 - TestStrictScanner1 (Failed) > 196 - TestStrictScanner2_1 (Failed) > 197 - TestStrictScanner2 (Failed) > 198 - TestStrictScanner2_2 (Failed) > Errors while running CTest > > Passing #:parallel-tests? #f doesn=E2=80=99t help. > > Could you take a look? The TestStrictScanner tests fail because they expect TestWriter to have run, but we disabled it. TestWriter, TestAnonymizer4, and TestPrinter1 are also reported as failing in the GDCM ctest dashboard (https://open.cdash.org/index.php?project=3DGDCM). It is strange that they passed previously in my local checkout (they fail now, some change in the toolchain?) I will try to look into this. For now, here is a patch to ignore the remaining failures, giving us an installable package, and also updated patches to add a bin output and use more system libraries. Investigating the remaining failing tests and using more system libraries feels like a fairly big, if fun, task possibly involving work on GDCM as well as this package. Should we close this bug report if we have a working package when the attached patches are applied? --=20 Mvh, Tor-bj=C3=B6rn Claesson --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-gdcm-Ignore-remaining-failing-tests.patch >From 7aaae11c7efc38222bfbf503e52cdb15bfccc33c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= Date: Fri, 27 Jan 2023 13:26:02 +0200 Subject: [PATCH 1/3] gnu: gdcm: Ignore remaining failing tests. gnu: gdcm: Ignore remaining failing tests. --- gnu/packages/bioinformatics.scm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index 8c75607a65..0fa7bb3746 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -18097,12 +18097,15 @@ (define-public gdcm #:configure-flags #~(list "-DGDCM_BUILD_TESTING=true" (string-append "-DCMAKE_CTEST_ARGUMENTS=-E;" - "'TestFileMetaInformation" - "|TestElement2" - "|TestSCUValidation" - "|TestWriter" + "'TestWriter" + "|TestStrictScanner1" + "|TestStrictScanner2" + "|TestStrictScanner2_1" + "|TestStrictScanner2_2" "|TestAnonymizer4" "|TestPrinter1" + ;; Disable tests that download data from the internet. + "|TestSCUValidation" "|TestEcho" "|TestFind'") "-DGDCM_DOCUMENTATION:BOOL=ON" -- 2.39.1 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0002-gnu-gdcm-Add-bin-output.patch Content-Transfer-Encoding: quoted-printable >From 2bc5c46ca2fee406a7108e5d43ef66af2d392889 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D Date: Fri, 27 Jan 2023 14:43:32 +0200 Subject: [PATCH 2/3] gnu: gdcm: Add bin output. gnu: gdcm: Add bin output. --- gnu/packages/bioinformatics.scm | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.= scm index 0fa7bb3746..9a3c0f7d42 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -18084,7 +18084,7 @@ (define-public gdcm (base32 "1rf0p7dnakjry0fa6ax1h762bn0l5n6ibfdxn077mjvwgpqan51l")))) (build-system cmake-build-system) - (outputs '("out" "doc")) + (outputs '("out" "bin" "doc")) (arguments (list #:phases @@ -18093,7 +18093,14 @@ (define-public gdcm ;; The build spams =E2=80=98Fontconfig error: No writable cache ;; directories=E2=80=99 in a seemingly endless loop otherwise. (lambda _ - (setenv "HOME" "/tmp")))) + (setenv "HOME" "/tmp"))) + (add-after 'install 'move-files + ;; Move utilities to bin output. + (lambda _ + (mkdir-p (string-append #$output:bin "/bin")) + (rename-file + (string-append #$output "/bin") + (string-append #$output:bin "/bin"))))) #:configure-flags #~(list "-DGDCM_BUILD_TESTING=3Dtrue" (string-append "-DCMAKE_CTEST_ARGUMENTS=3D-E;" @@ -18105,9 +18112,13 @@ (define-public gdcm "|TestAnonymizer4" "|TestPrinter1" ;; Disable tests that download data from the = internet. + "|gdcmscu-echo-dicomserver" + "|gdcmscu-store-dicomserver" + "|gdcmscu-find-dicomserver" "|TestSCUValidation" "|TestEcho" "|TestFind'") + "-DGDCM_BUILD_APPLICATIONS:BOOL=3DON" "-DGDCM_DOCUMENTATION:BOOL=3DON" "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF" (string-append "-DGDCM_INSTALL_DOC_DIR=3D" --=20 2.39.1 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0003-gnu-gdcm-Use-more-system-libraries.patch Content-Transfer-Encoding: quoted-printable >From 467a7b614ccafa2de51a8e56a6ecf384fb6fa07b Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tor-bj=3DC3=3DB6rn=3D20Claesson?=3D Date: Fri, 27 Jan 2023 17:03:36 +0200 Subject: [PATCH 3/3] gnu: gdcm: Use more system libraries. gnu: gdcm: Use more system libraries. --- gnu/packages/bioinformatics.scm | 48 ++++++++++++++++++++++++++++++--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.= scm index 9a3c0f7d42..77b3388f2e 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -18082,7 +18082,28 @@ (define-public gdcm (file-name (git-file-name name version)) (sha256 (base32 - "1rf0p7dnakjry0fa6ax1h762bn0l5n6ibfdxn077mjvwgpqan51l")))) + "1rf0p7dnakjry0fa6ax1h762bn0l5n6ibfdxn077mjvwgpqan51l")) + (modules '((guix build utils) + (ice-9 ftw))) + (snippet + '(begin + (define (unbundle? file) + (member file '("dicom3tools" + "gdcmexpat" + "gdcmutfcpp" + "gdcmuuid" + "gdcmzlib" + "getopt" + "KWStyle" + "pvrg" + "Release" + "VTK"))) + (with-directory-excursion "Utilities" + (for-each (lambda (utility) + (delete-file-recursively utility) + (substitute* "CMakeLists.txt" + (((string-append ".*/" utility "/.*")) "= "))) + (scandir "." unbundle?))))))) (build-system cmake-build-system) (outputs '("out" "bin" "doc")) (arguments @@ -18123,8 +18144,29 @@ (define-public gdcm "-DGDCM_PDF_DOCUMENTATION:BOOL=3DOFF" (string-append "-DGDCM_INSTALL_DOC_DIR=3D" #$output:doc "/share/doc/" #$name) - "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF"))) ; TODO: need = =E2=80=98xsl-ns=E2=80=99 - (native-inputs (list doxygen graphviz)) + "-DGDCM_BUILD_DOCBOOK_MANPAGES:BOOL=3DOFF" ; TODO: need =E2= =80=98xsl-ns=E2=80=99 + ;; Libraries + "-DGDCM_USE_SYSTEM_EXPAT:BOOL=3DON" + "-DGDCM_USE_SYSTEM_LIBXML2:BOOL=3DON" + "-DGDCM_USE_SYSTEM_OPENSSL:BOOL=3DON" + "-DGDCM_USE_SYSTEM_POPPLER:BOOL=3DON" + "-DGDCM_USE_SYSTEM_UUID:BOOL=3DON" + "-DGDCM_USE_SYSTEM_ZLIB:BOOL=3DON" + ;; TODO: Unbundle these if possible. + "-DGDCM_USE_SYSTEM_CHARLS:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_JSON:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_LJPEG:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_OPENJPEG:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_PAPYRUS3:BOOL=3DOFF" + "-DGDCM_USE_SYSTEM_SOCKETXX:BOOL=3DOFF"))) + (inputs (list + expat + libxml2 + openssl + poppler + `(,util-linux "lib") + zlib)) + (native-inputs (list doxygen graphviz pkg-config)) (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") (synopsis "Grassroots DICOM library") (description --=20 2.39.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 17:21:15 2023 Received: (at 60640) by debbugs.gnu.org; 31 Jan 2023 22:21:15 +0000 Received: from localhost ([127.0.0.1]:55230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMz06-0007j5-Sf for submit@debbugs.gnu.org; Tue, 31 Jan 2023 17:21:15 -0500 Received: from mail-qt1-f171.google.com ([209.85.160.171]:34365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMz02-0007io-LO for 60640@debbugs.gnu.org; Tue, 31 Jan 2023 17:21:13 -0500 Received: by mail-qt1-f171.google.com with SMTP id f10so1396968qtv.1 for <60640@debbugs.gnu.org>; Tue, 31 Jan 2023 14:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=MgbG4zXrCQlh/aR0p8/N5HNimbhduQD8C7EaOIg0oB8=; b=nsX1wwwDBXWh6NHdeAZlD1k5752OF8c2imNtqOP0TfHpPjt6Bwe1Yq+SC17dUfgwvx MwLiOGgT2hKUyerpMGMK3wiR+K7NG2YGyTmEmcFTN1UOaxvG+Tae0ZwfwGOxetT+KLr1 Ef8ZGdp6WUBK7B5WBFpR5mk/00HMSWmz8aB2NCIyCKbMWzTriyGHFF0PHyWNLTbquvVW tMg9g+V49FkLvHRZNqghGrqs06z0xhSu+2lh+EEuHI5U1uSjjo413TnkxaWNO3rmKbML 3HSLB6iXrwZQDyQnLFjRkgbidSbAizw5Jtso8VL6UJ1VJC9rCLK9yCE0vJ3r96H3xOrx hnaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MgbG4zXrCQlh/aR0p8/N5HNimbhduQD8C7EaOIg0oB8=; b=M100k0VAS4iaD5W0vnfccLpJHFS24Y0tLOm+yxQAKx3dYKUfUeAFVUfU8hsrrj3lH+ garWWe7a/ewaPU86ZH+FgwAlyNgx9TULTmPFrwjRqI3o9ANkGrfD1cQ/3lP8Zsq+vXZz OiC7wOhCSUecvwu1aZd6g7EMK5iHq3rcUMHMIQOjylmlei3HTRgfBkKtcmrv3N4B2fgK 1M7gFVU6DKQXHzDfq0q3KnjORHi02pqGdksjUwG0oWayHv80/c0YsLU3xnVmzjE2rioK BhyRCDPCiErYLHnk2eGHoyHG/M9ZXG5InknQJqLKZU4WJyy/JODfCGfLVhlbOJfieAsq pWOg== X-Gm-Message-State: AO0yUKUCcVKFDKlfkgL5VUvVp5GOfqCBAhvHhw+hmN3NyN54TJE476rA Qu6XuLfP8qMzlzKcwC1jY4SaBuOAU208Rg== X-Google-Smtp-Source: AK7set91bJ5Fq9inmklsZbzKQUmip4pYWf4PTfhuPqcBNU0H/17o2BPCjUwjpimIXwFA27H3U6/5pQ== X-Received: by 2002:ac8:57c5:0:b0:3b8:6d74:234a with SMTP id w5-20020ac857c5000000b003b86d74234amr753766qta.2.1675203664419; Tue, 31 Jan 2023 14:21:04 -0800 (PST) Received: from barbar (78-72-71-212-no31.tbcn.telia.com. [78.72.71.212]) by smtp.gmail.com with ESMTPSA id a26-20020ac8001a000000b003b68ea3d5c8sm2965940qtg.41.2023.01.31.14.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 14:21:03 -0800 (PST) References: <877cxyp1wf.fsf@gmail.com> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> <87tu0es27x.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: =?utf-8?Q?Tor-bj=C3=B6rn?= Claesson To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60640: Gnu: Add gdcm Date: Tue, 31 Jan 2023 23:42:29 +0200 In-reply-to: <87tu0es27x.fsf@gnu.org> Message-ID: <87mt5yjqgi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60640 Cc: 60640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi again! Ludovic Court=C3=A8s writes: > It would be nice if you could investigate the test failures: they might > reveal that something=E2=80=99s wrong with our packaging. Maybe the following is of any help, I was confused by the TestWriter etc. passing in my local checkout, but not when I later tried to build gdcm from the real guix repository. This can be reproduced as follows: 1. Check out and build the original commit to add gdcm 2.8.9 (15caeb745c) 2. Check out and build the "upgrade to 3.0.20" commit (2bdbd962e3) Now the tests suddenly pass. What does the build of 2.8.9 leave behind? I'm still really confused by this! --=20 Mvh, Tor-bj=C3=B6rn Claesson From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 17:43:33 2024 Received: (at 60640-done) by debbugs.gnu.org; 19 Feb 2024 22:43:34 +0000 Received: from localhost ([127.0.0.1]:43710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcCMH-0007Im-Hw for submit@debbugs.gnu.org; Mon, 19 Feb 2024 17:43:33 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:60843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcCMF-0007IS-9d for 60640-done@debbugs.gnu.org; Mon, 19 Feb 2024 17:43:32 -0500 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33d44d78e5fso670673f8f.1 for <60640-done@debbugs.gnu.org>; Mon, 19 Feb 2024 14:43:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708382524; x=1708987324; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ZT/zHPeJU4Y7GJ3CVSJTY99mHessIU/sYsHau0p5NuI=; b=PnS/Ad/z5qPWgELAWAYuUfXK2u1T4VOahiYdNpoiOnZIJhsUXjODodNFPBIaQ+ugkY d32MLx8fHnQAhf2KlyQLGuZz5tJdY20ZNJ1dQAA1zDfFrSrKQV3n6WGsjfWgpFwt7MTP jupj2PzHT46RnufA+1odHWqqyKsLX6T1Zomx6ohYK+7hK0OrF3kT+yIDqMcZic/JroZ+ CQl76FTO0UDeDsEbYURjztqD7AynlcnxqsGnULsnFInANZA4xoRX2iflpYoTK9OE/lQy k/ktMyHpqgsnF7EOOHKUE/rgQjIzjwXJnwDeuWLeYitOJPhf4OwzkS1HnNMJe1FXV92d vvSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708382524; x=1708987324; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZT/zHPeJU4Y7GJ3CVSJTY99mHessIU/sYsHau0p5NuI=; b=U6nHkuX3KG/hY0zmwz2DCHQWaiTAyErlr+g3PilRBItABDqC4z9BnFT60llbixHEgJ abw82QN1GAWhIy2egDWjbnOA1dCOJQZUQAxiF8hBRNndRUm0STDFkPyXZhUyOF1xErM3 ne/pg3YPC+lAU+QUvKbOd7tDwHwYCD5vzS6UmGmooZYIH3VUz5N6y74L/ISuESrYRCGU 2TVJfFNGPruP+6Fisr8ksuIdWd+YSwAU91yPkrNBahc2n8AvWf9QU7Ol1BzjxyWa0yly +Yxbe3bGddWkqT2is+awcZS5IEQABAJQq38iIwCg2W6Jn+YTUytLqqn6rKC053VudFlQ bx1Q== X-Gm-Message-State: AOJu0YyIwb+HICAqVd4TLNPk5INBf5XGdw1eRPaBBCsRgfwkLKj30SHU WVSBdfEUb32gHYftMTYkwcg2o19AAH6ZG28IM0GVlO4QazOfFwNbbsQ1QhBIiHo= X-Google-Smtp-Source: AGHT+IFAhKymVST6TD6sf2m4lfPdl8fKYl0Cg1R4zkKIT2gNPxr5YN0Sa6JWYJ8/kt+dODKWqXQewg== X-Received: by 2002:a5d:5591:0:b0:33b:8785:3420 with SMTP id i17-20020a5d5591000000b0033b87853420mr9163239wrv.51.1708382523360; Mon, 19 Feb 2024 14:42:03 -0800 (PST) Received: from guxtil (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id e2-20020a056000120200b0033cf80ad6f5sm11446269wrx.60.2024.02.19.14.42.02 for <60640-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 14:42:02 -0800 (PST) From: Sharlatan Hellseher To: 60640-done@debbugs.gnu.org Subject: Gnu: Add gdcm Date: Mon, 19 Feb 2024 22:41:54 +0000 Message-ID: <87h6i4jcul.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 60640-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, GDCM was added back in 2022 by the commit 15caeb745c5d77b69905d38d43b4d0974= 2bc71b6. =2D-8<---------------cut here---------------start------------->8--- 15caeb745c5d77b69905d38d43b4d09742bc71b6 Author: Antero Mejr AuthorDate: Wed Jun 15 15:39:53 2022 +0000 Commit: Ludovic Court=C3=A8s CommitDate: Sun Jan 8 16:11:45 2023 +0100 gnu: Add gdcm. * gnu/packages/bioinformatics.scm (gdcm): New variable. =2D-8<---------------cut here---------------end--------------->8--- And it's on the 3.0.20. Closing as already availale. Thanks, Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmXT2TIACgkQdtcnv/Ys 0rVdoBAArmkRUHb5LDnGX+L3YckQUbHlNzhWzuCXVFwcEFi50avc+bsJvpTmbCau TbKXcJfe20g8E4RjDha+EWpqDxE2Hrd+TzdM2crFXRJECmg+MaifsaM+cPtDOzV3 2lt4ktKw/LvwyEtEXSW574380ZqgL41B0zgBFjIT9HbEl+rsO1u56QOSjG86A6K8 UDLT/yxCUgMa/HUv5gpIG9Xr2StDPAYL5rvXIIP4/4RGzjDA0TfRftRW1WvzDSye 7GcWh8Av6umtUJB09yrxOfPEZP+gGsHS7TPgWBrbhGP6UctpE+/gauW/9nqpLFe+ TjcW8H2Fh0OgSEnWF5gRRXmykQpEqQleFwkJ5xSGgcECuPvtgZTSxsVCAV2PLA6/ wqV3ZY3Qe9zAODPcOvdjmx1oFrFTK4czkgzPNNWf7v9B4q6j11mei8yC3rz8xw1p Nm8PJ4a2nVJknXkAPh4CO/cZPIUsIH0maOVtKzH/EyuoyhdMCAeWdqnsnlApFfwG ufk3f3QlFAqTRNF1hGfOf9O8gf3EIm0tB8hE9q+SLd8dXxZm2Ozi68A4dXwnAAm7 VKXPIaRVUwufLcc/ej1ApUwaixDFkRFSNuzonf0qth1gBkdbb9eFj/vljiZPaqMb kjm+3SvYMFTm5UGoAqwXW6jZNTm3h6rGoMSc8LcLawdbVhH2uCw= =/lxf -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 03:22:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Mar 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator