GNU bug report logs - #60636
[PATCH] Add 'manifest.scm'

Previous Next

To reply to this bug, email your comments to 60636 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Cully <bjc <at> spork.org>
To: guix-patches <at> gnu.org
Cc: Brian Cully <bjc <at> spork.org>
Subject: [PATCH] Add 'manifest.scm'
Date: Sat,  7 Jan 2023 19:27:19 -0500

---
 manifest.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 manifest.scm

diff --git a/manifest.scm b/manifest.scm
new file mode 100644
index 0000000..bdd4e64
--- /dev/null
+++ b/manifest.scm
@@ -0,0 +1,29 @@
+;; This is the complete list of Guix packages necessary for building Shepherd.
+;;
+;; For example the following shell command will run the built-in tests:
+;;
+;;  % guix shell -m manifest.scm --pure -- make check
+
+(specifications->manifest
+ '("autoconf"
+   "automake"
+   "binutils"
+   "coreutils"
+   "diffutils"
+   "findutils"
+   "gawk"
+   "gcc"
+   "gettext"
+   "glibc"
+   "grep"
+   "guile"
+   "guile-fibers"
+   "guile-readline"
+   "help2man"
+   "libtool"
+   "make"
+   "pkg-config"
+   "sed"
+   "tar"
+   "texinfo"
+   "xz"))
-- 
2.38.1

Message #8 received at 60636 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Brian Cully <bjc <at> spork.org>
Cc: 60636 <at> debbugs.gnu.org
Subject: Re: bug#60636: [PATCH] Add 'manifest.scm'
Date: Wed, 11 Jan 2023 14:15:04 -0500

Hi,

Brian Cully <bjc <at> spork.org> writes:

> ---
>  manifest.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 manifest.scm
>
> diff --git a/manifest.scm b/manifest.scm
> new file mode 100644
> index 0000000..bdd4e64
> --- /dev/null
> +++ b/manifest.scm
> @@ -0,0 +1,29 @@
> +;; This is the complete list of Guix packages necessary for building Shepherd.

This is intended for the Shepherd repository, right?

> +;; For example the following shell command will run the built-in tests:
> +;;
> +;;  % guix shell -m manifest.scm --pure -- make check
> +
> +(specifications->manifest
> + '("autoconf"
> +   "automake"
> +   "binutils"
> +   "coreutils"
> +   "diffutils"
> +   "findutils"
> +   "gawk"
> +   "gcc"
> +   "gettext"
> +   "glibc"
> +   "grep"
> +   "guile"
> +   "guile-fibers"
> +   "guile-readline"
> +   "help2man"
> +   "libtool"
> +   "make"
> +   "pkg-config"
> +   "sed"
> +   "tar"
> +   "texinfo"
> +   "xz"))

The value this provides above 'guix shell -D shepherd' is that it
includes the build system bootstrapping packages too (autoconf,
automake, etc.), right?  Are all these items really needed?  Why do we
need GCC, or glibc or gettext for example?

Thanks for this contribution,

-- 
Maxim

Message #11 received at 60636 <at> debbugs.gnu.org (full text, mbox):

From: Brian Cully <bjc <at> spork.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 60636 <at> debbugs.gnu.org
Subject: Re: bug#60636: [PATCH] Add 'manifest.scm'
Date: Thu, 12 Jan 2023 09:18:18 -0500

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> This is intended for the Shepherd repository, right?

Yes. The shepherd documentation pointed me to the Guix ML and 
bugtracker. If there’s somewhere better, I can re-submit.

> The value this provides above 'guix shell -D shepherd' is that 
> it
> includes the build system bootstrapping packages too (autoconf,
> automake, etc.), right?

That’s correct. Shepherd can’t be built from a checkout using 
‘guix shell -D shepherd’ because (according to Ludo) Guix uses the 
tarball as a source, not the git repository. Ludo did mention on 
IRC that shepherd could probably use a manifest.scm when I asked 
him about it, but I don’t want to speak for him more than that.

> Are all these items really needed?  Why do we
> need GCC, or glibc or gettext for example?

I added every item in response to one of the build steps 
failing. GCC is needed, for instance, because configure tests for 
the existence of a working C compiler (probably because of 
etc/crash-handler.c, but I couldn’t say for sure), glibc is needed 
because we’ve got a C compiler in the mix, and gettext is needed 
for ‘autoconf-point’.

-bjc

Message #14 received at 60636 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Brian Cully <bjc <at> spork.org>
Cc: 60636 <at> debbugs.gnu.org, ludo <at> gnu.org
Subject: Re: bug#60636: [PATCH] Add 'manifest.scm'
Date: Thu, 12 Jan 2023 17:31:04 -0500

+CC Ludovic

Hello,

Brian Cully <bjc <at> spork.org> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> This is intended for the Shepherd repository, right?
>
> Yes. The shepherd documentation pointed me to the Guix ML and
> bugtracker. If there’s somewhere better, I can re-submit.
>
>> The value this provides above 'guix shell -D shepherd' is that it
>> includes the build system bootstrapping packages too (autoconf,
>> automake, etc.), right?
>
> That’s correct. Shepherd can’t be built from a checkout using ‘guix
> shell -D shepherd’ because (according to Ludo) Guix uses the tarball
> as a source, not the git repository. Ludo did mention on IRC that
> shepherd could probably use a manifest.scm when I asked him about it,
> but I don’t want to speak for him more than that.
>
>> Are all these items really needed?  Why do we
>> need GCC, or glibc or gettext for example?
>
> I added every item in response to one of the build steps failing. GCC
> is needed, for instance, because configure tests for the existence of
> a working C compiler (probably because of etc/crash-handler.c, but I
> couldn’t say for sure), glibc is needed because we’ve got a C compiler
> in the mix, and gettext is needed for ‘autoconf-point’.

Adding gcc-toolchain would probably be better than the separate gcc and
glibc.

Other than that, LGTM.  Could you send a v2 with the above change?
Thanks for explaining!

-- 
Thanks,
Maxim

Message #17 received at 60636 <at> debbugs.gnu.org (full text, mbox):

From: Brian Cully <bjc <at> spork.org>
To: 60636 <at> debbugs.gnu.org
Cc: Brian Cully <bjc <at> spork.org>
Subject: [PATCH v2] Add 'manifest.scm'
Date: Thu, 12 Jan 2023 21:01:49 -0500

---
 manifest.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 manifest.scm

diff --git a/manifest.scm b/manifest.scm
new file mode 100644
index 0000000..12508c3
--- /dev/null
+++ b/manifest.scm
@@ -0,0 +1,27 @@
+;; This is the complete list of Guix packages necessary for building Shepherd.
+;;
+;; For example the following shell command will run the built-in tests:
+;;
+;;  % guix shell -m manifest.scm --pure -- make check
+
+(specifications->manifest
+ '("autoconf"
+   "automake"
+   "coreutils"
+   "diffutils"
+   "findutils"
+   "gawk"
+   "gcc-toolchain"
+   "gettext"
+   "grep"
+   "guile"
+   "guile-fibers"
+   "guile-readline"
+   "help2man"
+   "libtool"
+   "make"
+   "pkg-config"
+   "sed"
+   "tar"
+   "texinfo"
+   "xz"))
-- 
2.38.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.