GNU bug report logs - #60620
[PATCH] copy.c: replace set_acl() with chmod_or_fchmod()

Previous Next

Package: coreutils;

Reported by: Ondrej Valousek <ondrej.valousek.xm <at> renesas.com>

Date: Sat, 7 Jan 2023 07:38:02 UTC

Severity: normal

Tags: patch

Full log

View this message in rfc822 format

From: Ondrej Valousek <ondrej.valousek.xm <at> renesas.com>
To: Pádraig Brady <P <at> draigBrady.com>, "60620 <at> debbugs.gnu.org" <60620 <at> debbugs.gnu.org>
Subject: bug#60620: [PATCH] copy.c: replace set_acl() with chmod_or_fchmod()
Date: Tue, 24 Jan 2023 08:14:37 +0000

> The "at least in Linux" qualification worries me.
> Having a very quick look at the qset_acl() code suggests it clears ACLs on some platforms at least, which chmod_or_fchmod() does not.
> Am I reading that wrong?

You are right.
The question is - why do we need to clear ACLs?
The only real example the code in question used is via "cp --no-preserve=mode" where I can't think of a reason why we intentionally clear ACLs
This bug report was last modified 2 years and 200 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.