From unknown Wed Jun 18 23:12:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60582 <60582@debbugs.gnu.org> To: bug#60582 <60582@debbugs.gnu.org> Subject: Status: [PATCH] Properly format list of packages & sync lightdm documentation. Reply-To: bug#60582 <60582@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:12:41 +0000 retitle 60582 [PATCH] Properly format list of packages & sync lightdm docum= entation. reassign 60582 guix-patches submitter 60582 Bruno Victal severity 60582 normal tag 60582 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 16:02:17 2023 Received: (at submit) by debbugs.gnu.org; 5 Jan 2023 21:02:17 +0000 Received: from localhost ([127.0.0.1]:53074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXNR-0004vW-2I for submit@debbugs.gnu.org; Thu, 05 Jan 2023 16:02:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:32966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXNP-0004vP-Bz for submit@debbugs.gnu.org; Thu, 05 Jan 2023 16:02:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDXNB-0006FC-9Y for guix-patches@gnu.org; Thu, 05 Jan 2023 16:02:09 -0500 Received: from smtpm5.myservices.hosting ([185.26.105.236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDXN9-0003mU-Ft for guix-patches@gnu.org; Thu, 05 Jan 2023 16:02:01 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpm5.myservices.hosting (Postfix) with ESMTP id 7F5E120CDC for ; Thu, 5 Jan 2023 22:01:52 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id F0F038009C; Thu, 5 Jan 2023 22:01:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dINVj-vKVI-U; Thu, 5 Jan 2023 22:01:51 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 7128E8009A; Thu, 5 Jan 2023 22:01:51 +0100 (CET) From: Bruno Victal To: guix-patches@gnu.org Subject: [PATCH] Properly format list of packages & sync lightdm documentation. Date: Thu, 5 Jan 2023 21:01:42 +0000 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.105.236; envelope-from=mirai@makinata.eu; helo=smtpm5.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The first patch allows generate-documentation to properly format a list of packages. Previously these had to be cleaned up by hand which was error-prone. Sample snippets: Before: --8<---------------cut here---------------start------------->8--- @item @code{assets} (default: @code{(# # #)}) (type: list-of-file-likes) --8<---------------cut here---------------end--------------->8--- After: --8<---------------cut here---------------start------------->8--- @item @code{assets} (default: @code{(adwaita-icon-theme gnome-themes-extra hicolor-icon-theme)}) (type: list-of-file-likes) --8<---------------cut here---------------end--------------->8--- The second patch syncs the documentation with the source code and fixes some mistakes. Bruno Victal (2): services: configuration: Format a list of packages by their names. services: lightdm: Sync documentation with source. doc/guix.texi | 4 ++-- gnu/services/configuration.scm | 3 +++ gnu/services/lightdm.scm | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) base-commit: 80902fc210d8dc28e14d63d68f398aef796b5838 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 16:06:30 2023 Received: (at 60582) by debbugs.gnu.org; 5 Jan 2023 21:06:30 +0000 Received: from localhost ([127.0.0.1]:53088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXRW-00052U-Ck for submit@debbugs.gnu.org; Thu, 05 Jan 2023 16:06:30 -0500 Received: from smtpmciv8.myservices.hosting ([185.26.106.203]:52130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXRM-00052D-0K for 60582@debbugs.gnu.org; Thu, 05 Jan 2023 16:06:29 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv8.myservices.hosting (Postfix) with ESMTP id CE68F20C83 for <60582@debbugs.gnu.org>; Thu, 5 Jan 2023 22:06:18 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id E0A0E8009F; Thu, 5 Jan 2023 22:06:17 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HPplM3aRDbGS; Thu, 5 Jan 2023 22:06:17 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id BB6EE80096; Thu, 5 Jan 2023 22:06:16 +0100 (CET) From: Bruno Victal To: 60582@debbugs.gnu.org Subject: [PATCH 2/2] services: lightdm: Sync documentation with source. Date: Thu, 5 Jan 2023 21:06:11 +0000 Message-Id: <65322281b6ea09ee3df48d624f06cb9a9bb86b75.1672951913.git.mirai@makinata.eu> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/lightdm.scm (lightdm-gtk-greeter-configuration): Fix cursor-theme-size description. * doc/guix.texi (lightdm-service-type): Sync with source. --- doc/guix.texi | 4 ++-- gnu/services/lightdm.scm | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 32e34b7d52..bb0d276b32 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -21733,7 +21733,7 @@ disable security: @end lisp Or to set a PasswordFile for the classic (unsecure) VncAuth -mecanism: +mechanism: @lisp (vnc-server-command (file-append tigervnc-server "/bin/Xvnc" @@ -21770,7 +21770,7 @@ Available @code{lightdm-gtk-greeter-configuration} fields are: The lightdm-gtk-greeter package to use. @item @code{assets} @ -(default: @code{(adwaita-icon-theme gnome-themes-extrahicolor-icon-theme)}) @ +(default: @code{(adwaita-icon-theme gnome-themes-extra hicolor-icon-theme)}) @ (type: list-of-file-likes) The list of packages complementing the greeter, such as package providing icon themes. diff --git a/gnu/services/lightdm.scm b/gnu/services/lightdm.scm index 7e3864fec2..0b9094cda1 100644 --- a/gnu/services/lightdm.scm +++ b/gnu/services/lightdm.scm @@ -151,7 +151,7 @@ (define-configuration lightdm-gtk-greeter-configuration "The name of the cursor theme to use.") (cursor-theme-size (number 16) - "The size to use for the the cursor theme.") + "The size to use for the cursor theme.") (allow-debugging? maybe-boolean "Set to #t to enable debug log level.") -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 16:14:41 2023 Received: (at 60582) by debbugs.gnu.org; 5 Jan 2023 21:14:41 +0000 Received: from localhost ([127.0.0.1]:53108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXZR-0005Fj-27 for submit@debbugs.gnu.org; Thu, 05 Jan 2023 16:14:41 -0500 Received: from smtpmciv6.myservices.hosting ([185.26.106.201]:33556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXZP-0005Fa-Eo for 60582@debbugs.gnu.org; Thu, 05 Jan 2023 16:14:39 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv6.myservices.hosting (Postfix) with ESMTP id 745D720CE2 for <60582@debbugs.gnu.org>; Thu, 5 Jan 2023 22:14:38 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 92DE480098; Thu, 5 Jan 2023 22:06:14 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JdaVGLSQ5m0N; Thu, 5 Jan 2023 22:06:14 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 2575480096; Thu, 5 Jan 2023 22:06:14 +0100 (CET) From: Bruno Victal To: 60582@debbugs.gnu.org Subject: [PATCH 1/2] services: configuration: Format a list of packages by their names. Date: Thu, 5 Jan 2023 21:06:10 +0000 Message-Id: <11414ae2650cde429b82aa168041e3989cf7d84c.1672951913.git.mirai@makinata.eu> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/configuration.scm (generate-documentation): Format a list of packages by their names. --- gnu/services/configuration.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm index 6b0291dc00..16e2380709 100644 --- a/gnu/services/configuration.scm +++ b/gnu/services/configuration.scm @@ -370,6 +370,9 @@ (define (show-default val) (cond ((package? val) (symbol->string (package->symbol val))) + ((and ((list-of package?) val) (not (null? val))) + (format #f "(~{~a~^ ~})" + (map package->symbol val))) (else (str val)))) `(entry (% (heading -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 09:10:50 2023 Received: (at 60582) by debbugs.gnu.org; 6 Jan 2023 14:10:50 +0000 Received: from localhost ([127.0.0.1]:54122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDnQo-00049v-G0 for submit@debbugs.gnu.org; Fri, 06 Jan 2023 09:10:50 -0500 Received: from smtpm8.myservices.hosting ([185.26.105.209]:40496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDnQn-00049i-5e for 60582@debbugs.gnu.org; Fri, 06 Jan 2023 09:10:49 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpm8.myservices.hosting (Postfix) with ESMTP id D15AF20BE9 for <60582@debbugs.gnu.org>; Fri, 6 Jan 2023 15:10:46 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 75962800A3; Fri, 6 Jan 2023 15:10:46 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id phb855vIaxFU; Fri, 6 Jan 2023 15:10:46 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id F2AA1800A2; Fri, 6 Jan 2023 15:10:45 +0100 (CET) From: Bruno Victal To: 60582@debbugs.gnu.org Subject: [PATCH v2 2/2] services: lightdm: Sync documentation with source. Date: Fri, 6 Jan 2023 14:10:35 +0000 Message-Id: <62932aa5e591b7dc479ea0cb1c92282b19936a5f.1673014203.git.mirai@makinata.eu> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Table entry @item nodes cannot span multiple lines. * gnu/services/lightdm.scm (lightdm-gtk-greeter-configuration): Fix cursor-theme-size description. * doc/guix.texi (lightdm-service-type): Sync with source. --- doc/guix.texi | 12 ++++-------- gnu/services/lightdm.scm | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 293c3016aa..8fc4ec5640 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -21798,7 +21798,7 @@ disable security: @end lisp Or to set a PasswordFile for the classic (unsecure) VncAuth -mecanism: +mechanism: @lisp (vnc-server-command (file-append tigervnc-server "/bin/Xvnc" @@ -21834,9 +21834,7 @@ Available @code{lightdm-gtk-greeter-configuration} fields are: @item @code{lightdm-gtk-greeter} (default: @code{lightdm-gtk-greeter}) (type: file-like) The lightdm-gtk-greeter package to use. -@item @code{assets} @ -(default: @code{(adwaita-icon-theme gnome-themes-extrahicolor-icon-theme)}) @ -(type: list-of-file-likes) +@item @code{assets} (default: @code{(adwaita-icon-theme gnome-themes-extra hicolor-icon-theme)}) (type: list-of-file-likes) The list of packages complementing the greeter, such as package providing icon themes. @@ -21862,8 +21860,7 @@ The background image to use. Enable accessibility support through the Assistive Technology Service Provider Interface (AT-SPI). -@item @code{a11y-states} @ -(default: @code{(contrast font keyboard reader)}) (type: list-of-a11y-states) +@item @code{a11y-states} (default: @code{(contrast font keyboard reader)}) (type: list-of-a11y-states) The accessibility features to enable, given as list of symbols. @item @code{reader} (type: maybe-file-like) @@ -21897,8 +21894,7 @@ The type of the seat, either the @code{local} or @code{xremote} symbol. @item @code{autologin-user} (type: maybe-string) The username to automatically log in with by default. -@item @code{greeter-session} @ -(default: @code{lightdm-gtk-greeter}) (type: greeter-session) +@item @code{greeter-session} (default: @code{lightdm-gtk-greeter}) (type: greeter-session) The greeter session to use, specified as a symbol. Currently, only @code{lightdm-gtk-greeter} is supported. diff --git a/gnu/services/lightdm.scm b/gnu/services/lightdm.scm index 7e3864fec2..0b9094cda1 100644 --- a/gnu/services/lightdm.scm +++ b/gnu/services/lightdm.scm @@ -151,7 +151,7 @@ (define-configuration lightdm-gtk-greeter-configuration "The name of the cursor theme to use.") (cursor-theme-size (number 16) - "The size to use for the the cursor theme.") + "The size to use for the cursor theme.") (allow-debugging? maybe-boolean "Set to #t to enable debug log level.") -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 09:10:51 2023 Received: (at 60582) by debbugs.gnu.org; 6 Jan 2023 14:10:51 +0000 Received: from localhost ([127.0.0.1]:54124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDnQo-00049y-SL for submit@debbugs.gnu.org; Fri, 06 Jan 2023 09:10:51 -0500 Received: from smtpm5.myservices.hosting ([185.26.105.236]:57068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDnQn-00049h-2P for 60582@debbugs.gnu.org; Fri, 06 Jan 2023 09:10:49 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpm5.myservices.hosting (Postfix) with ESMTP id 8F9A320C04 for <60582@debbugs.gnu.org>; Fri, 6 Jan 2023 15:10:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 43CC8800A2; Fri, 6 Jan 2023 15:10:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id H-hRcKOv_ZN6; Fri, 6 Jan 2023 15:10:44 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id C66318009A; Fri, 6 Jan 2023 15:10:43 +0100 (CET) From: Bruno Victal To: 60582@debbugs.gnu.org Subject: [PATCH v2 1/2] services: configuration: Format a list of packages by their names. Date: Fri, 6 Jan 2023 14:10:34 +0000 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/configuration.scm (generate-documentation): Format a list of packages by their names. --- gnu/services/configuration.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm index 6b0291dc00..482b49aae4 100644 --- a/gnu/services/configuration.scm +++ b/gnu/services/configuration.scm @@ -35,6 +35,7 @@ (define-module (gnu services configuration) #:autoload (texinfo serialize) (stexi->texi) #:use-module (ice-9 curried-definitions) #:use-module (ice-9 match) + #:use-module (ice-9 format) #:use-module (srfi srfi-1) #:use-module (srfi srfi-34) #:use-module (srfi srfi-35) @@ -370,6 +371,9 @@ (define (show-default val) (cond ((package? val) (symbol->string (package->symbol val))) + ((and ((list-of package?) val) (not (null? val))) + (format #f "(~{~a~^ ~})" + (map package->symbol val))) (else (str val)))) `(entry (% (heading base-commit: a768b0433e0b79c5a32910ce5515086b92725e84 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 15:29:39 2023 Received: (at 60582) by debbugs.gnu.org; 13 Jan 2023 20:29:39 +0000 Received: from localhost ([127.0.0.1]:52496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGQgE-0001LH-VZ for submit@debbugs.gnu.org; Fri, 13 Jan 2023 15:29:39 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:41777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGQgD-0001Ky-Ow for 60582@debbugs.gnu.org; Fri, 13 Jan 2023 15:29:38 -0500 Received: by mail-qt1-f172.google.com with SMTP id d16so7074322qtw.8 for <60582@debbugs.gnu.org>; Fri, 13 Jan 2023 12:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=LjyYAedbBVdP2JfYGVXx3juNYScgWYVzmvFxuXxjc2E=; b=c56ovdKKOfsyLSXtm6/AIF9t4glQXCj0JX0NziQaRwq3n15Y98TNAfmAPny8txJbjT Pl5VLcH26tGhY9rSpXF7M3hBCZQ3TrThLT496n7Mddu1MpoVQLV6GL2t1TQJ90cOB0mY R004Qfk+JDFPrPLiqhenkcczho6y3NDTeiuuEXfo0qwh6s3feuuOAMmuKUhLO1ojwMVL +EX+4Ly/tr4FeFQeYuyCaLwt4xfL/YQVbxkBO3vm4NQ8uznE4oKZtq0g7Sn6ZTtdKxQJ r5TAuQ3TrQNOC6Lv661CyKY3St3PPulI3HrwRj8XRTopF00XNEkNnhWJ2wMG1Jmp2xVk kFgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LjyYAedbBVdP2JfYGVXx3juNYScgWYVzmvFxuXxjc2E=; b=fqZ9daVfC88S4rwP84G1OBHfty0Pgmt2/sk9qUo+4jONA0S3/SCfKNUQIYHWkLYrE4 OVqdlbJGK87hLCNtFyKdldfbSmH2wXtO3ztB+u8JA+uuG0eBcO8sqWnpyW7oQIK6Bsuc B0h1y3Ae0OdCsIfztKWwN+D+p0jfE+/6fl9gaLRocxp2HSwbIpg/chSBKx2EacxY5qQy SvUrqSuvv2ES39b+fdmUaz349xmzuGpG87lwf29mPGdXl+ShYWUUh6Qx2nL8cWAAnsTr tTBjcAOydzDBDWE4bkpPcJ1DBlMAbrTbdcZ1MvvhdCppmmixCpiyst1BCzPHsM3cgZmg LPvg== X-Gm-Message-State: AFqh2krbzVFJyHUCPRVGeNsa/rfBGKE0jA7jWIN1J4Y9HyQCzCwKp9MS 123wFOPjcvh3Vu0p7yskzSWQO+Mr6NwWOczy X-Google-Smtp-Source: AMrXdXtMZp5dBc6rYPsE0gi2CJ/tdC7NiOCxcU9cJ9qmLQMjcL8IIMN1rrU8SEqjqK3pOFxpVjve9Q== X-Received: by 2002:ac8:4e44:0:b0:3a9:8842:5854 with SMTP id e4-20020ac84e44000000b003a988425854mr149979113qtw.52.1673641772115; Fri, 13 Jan 2023 12:29:32 -0800 (PST) Received: from hurd (dsl-10-149-10.b2b2c.ca. [72.10.149.10]) by smtp.gmail.com with ESMTPSA id x14-20020a05620a258e00b006e07228ed53sm13173242qko.18.2023.01.13.12.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 12:29:31 -0800 (PST) From: Maxim Cournoyer To: Bruno Victal Subject: Re: bug#60582: [PATCH] Properly format list of packages & sync lightdm documentation. References: <11414ae2650cde429b82aa168041e3989cf7d84c.1672951913.git.mirai@makinata.eu> Date: Fri, 13 Jan 2023 15:29:30 -0500 In-Reply-To: <11414ae2650cde429b82aa168041e3989cf7d84c.1672951913.git.mirai@makinata.eu> (Bruno Victal's message of "Thu, 5 Jan 2023 21:06:10 +0000") Message-ID: <87cz7ifaad.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: 60582@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Bruno Victal writes: > * gnu/services/configuration.scm > (generate-documentation): Format a list of packages by their names. > --- > gnu/services/configuration.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm > index 6b0291dc00..16e2380709 100644 > --- a/gnu/services/configuration.scm > +++ b/gnu/services/configuration.scm > @@ -370,6 +370,9 @@ (define (show-default val) > (cond > ((package? val) > (symbol->string (package->symbol val))) > + ((and ((list-of package?) val) (not (null? val))) > + (format #f "(~{~a~^ ~})" > + (map package->symbol val))) The 'and' and (not (null? val)) don't seem to be necessary as in the empty list of packages, it'd produce the same as the else clause below: --8<---------------cut here---------------start------------->8--- scheme@(gnu services configuration)> (format #f "(~{~a~^ ~})" '()) $1 = "()" scheme@(gnu services configuration)> (str '()) $2 = "()" --8<---------------cut here---------------end--------------->8--- > (else (str val)))) > > `(entry (% (heading -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 15:34:22 2023 Received: (at 60582) by debbugs.gnu.org; 13 Jan 2023 20:34:23 +0000 Received: from localhost ([127.0.0.1]:52500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGQko-0001Tb-K4 for submit@debbugs.gnu.org; Fri, 13 Jan 2023 15:34:22 -0500 Received: from smtpmciv3.myservices.hosting ([185.26.107.239]:44528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGQkm-0001TR-Pd for 60582@debbugs.gnu.org; Fri, 13 Jan 2023 15:34:21 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv3.myservices.hosting (Postfix) with ESMTP id 189AB20286; Fri, 13 Jan 2023 21:34:15 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id C6D2080096; Fri, 13 Jan 2023 21:34:15 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GjG10IrNOYW3; Fri, 13 Jan 2023 21:34:15 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 700AE80093; Fri, 13 Jan 2023 21:34:15 +0100 (CET) Message-ID: <62b2b844-5024-f66b-7c48-a3ac5ff114c8@makinata.eu> Date: Fri, 13 Jan 2023 20:34:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60582: [PATCH] Properly format list of packages & sync lightdm documentation. To: Maxim Cournoyer References: <11414ae2650cde429b82aa168041e3989cf7d84c.1672951913.git.mirai@makinata.eu> <87cz7ifaad.fsf_-_@gmail.com> Content-Language: en-US From: Bruno Victal In-Reply-To: <87cz7ifaad.fsf_-_@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 60582 Cc: 60582@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2023-01-13 20:29, Maxim Cournoyer wrote: > Hi, > > Bruno Victal writes: > >> * gnu/services/configuration.scm >> (generate-documentation): Format a list of packages by their names. >> --- >> gnu/services/configuration.scm | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm >> index 6b0291dc00..16e2380709 100644 >> --- a/gnu/services/configuration.scm >> +++ b/gnu/services/configuration.scm >> @@ -370,6 +370,9 @@ (define (show-default val) >> (cond >> ((package? val) >> (symbol->string (package->symbol val))) >> + ((and ((list-of package?) val) (not (null? val))) >> + (format #f "(~{~a~^ ~})" >> + (map package->symbol val))) > > The 'and' and (not (null? val)) don't seem to be necessary as in the > empty list of packages, it'd produce the same as the else clause below: > > --8<---------------cut here---------------start------------->8--- > scheme@(gnu services configuration)> (format #f "(~{~a~^ ~})" '()) > $1 = "()" > scheme@(gnu services configuration)> (str '()) > $2 = "()" > --8<---------------cut here---------------end--------------->8--- > >> (else (str val)))) >> >> `(entry (% (heading > It is necessary for non file-like fields whose default value is '(). Otherwise configuration->documentation will show blank spaces when it should show an empty list. Cheers, Bruno From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 16:38:06 2023 Received: (at 60582) by debbugs.gnu.org; 13 Jan 2023 21:38:06 +0000 Received: from localhost ([127.0.0.1]:52540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGRkU-0005Ra-JG for submit@debbugs.gnu.org; Fri, 13 Jan 2023 16:38:06 -0500 Received: from smtpmciv4.myservices.hosting ([185.26.107.240]:49428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGRkS-0005RQ-NH for 60582@debbugs.gnu.org; Fri, 13 Jan 2023 16:38:05 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv4.myservices.hosting (Postfix) with ESMTP id 34790202DC for <60582@debbugs.gnu.org>; Fri, 13 Jan 2023 22:37:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id D458880096; Fri, 13 Jan 2023 22:37:59 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Y3y1t4UPlcDI; Fri, 13 Jan 2023 22:37:59 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 616A280093; Fri, 13 Jan 2023 22:37:59 +0100 (CET) From: Bruno Victal To: 60582@debbugs.gnu.org Subject: [PATCH v3 1/2] services: configuration: Format a list of packages by their names. Date: Fri, 13 Jan 2023 21:34:57 +0000 Message-Id: <0e6cbfdffea195d739ef180031dc2d6726203e0f.1673645697.git.mirai@makinata.eu> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/configuration.scm (generate-documentation): Format a list of packages by their names. --- Simplified condition. I can't reproduce the issue that was supposed to be resolved by that conditional. I'm guessing I used to have a different format string back then. gnu/services/configuration.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm index 6b0291dc00..4017cd0fa8 100644 --- a/gnu/services/configuration.scm +++ b/gnu/services/configuration.scm @@ -35,6 +35,7 @@ (define-module (gnu services configuration) #:autoload (texinfo serialize) (stexi->texi) #:use-module (ice-9 curried-definitions) #:use-module (ice-9 match) + #:use-module (ice-9 format) #:use-module (srfi srfi-1) #:use-module (srfi srfi-34) #:use-module (srfi srfi-35) @@ -370,6 +371,8 @@ (define (generate-documentation documentation documentation-name) (cond ((package? val) (symbol->string (package->symbol val))) + (((list-of package?) val) + (format #f "(~{~a~^ ~})" (map package->symbol val))) (else (str val)))) `(entry (% (heading base-commit: 0f85081ed1d99be57d3544e0307e7fa9ca043be9 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 16:38:09 2023 Received: (at 60582) by debbugs.gnu.org; 13 Jan 2023 21:38:09 +0000 Received: from localhost ([127.0.0.1]:52543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGRkW-0005Rp-Su for submit@debbugs.gnu.org; Fri, 13 Jan 2023 16:38:09 -0500 Received: from smtpmciv5.myservices.hosting ([185.26.107.241]:57362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGRkV-0005Rg-Bz for 60582@debbugs.gnu.org; Fri, 13 Jan 2023 16:38:07 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv5.myservices.hosting (Postfix) with ESMTP id C46022092E for <60582@debbugs.gnu.org>; Fri, 13 Jan 2023 22:38:06 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 6F62C80096; Fri, 13 Jan 2023 22:38:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XGaUV83hFe_A; Fri, 13 Jan 2023 22:38:06 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id D9BC780093; Fri, 13 Jan 2023 22:38:05 +0100 (CET) From: Bruno Victal To: 60582@debbugs.gnu.org Subject: [PATCH v3 2/2] services: lightdm: Sync documentation with source. Date: Fri, 13 Jan 2023 21:34:58 +0000 Message-Id: <6a46a643dbd361fd188a67f3d5f59feeead08cfe.1673645697.git.mirai@makinata.eu> X-Mailer: git-send-email 2.38.1 In-Reply-To: <0e6cbfdffea195d739ef180031dc2d6726203e0f.1673645697.git.mirai@makinata.eu> References: <0e6cbfdffea195d739ef180031dc2d6726203e0f.1673645697.git.mirai@makinata.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Table entry @item nodes cannot span multiple lines. * gnu/services/lightdm.scm (lightdm-gtk-greeter-configuration): Fix cursor-theme-size description. * doc/guix.texi (lightdm-service-type): Sync with source. --- doc/guix.texi | 12 ++++-------- gnu/services/lightdm.scm | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 751d0957d8..9c369bd881 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -21818,7 +21818,7 @@ X Window @end lisp Or to set a PasswordFile for the classic (unsecure) VncAuth -mecanism: +mechanism: @lisp (vnc-server-command (file-append tigervnc-server "/bin/Xvnc" @@ -21854,9 +21854,7 @@ X Window @item @code{lightdm-gtk-greeter} (default: @code{lightdm-gtk-greeter}) (type: file-like) The lightdm-gtk-greeter package to use. -@item @code{assets} @ -(default: @code{(adwaita-icon-theme gnome-themes-extrahicolor-icon-theme)}) @ -(type: list-of-file-likes) +@item @code{assets} (default: @code{(adwaita-icon-theme gnome-themes-extra hicolor-icon-theme)}) (type: list-of-file-likes) The list of packages complementing the greeter, such as package providing icon themes. @@ -21882,8 +21880,7 @@ X Window Enable accessibility support through the Assistive Technology Service Provider Interface (AT-SPI). -@item @code{a11y-states} @ -(default: @code{(contrast font keyboard reader)}) (type: list-of-a11y-states) +@item @code{a11y-states} (default: @code{(contrast font keyboard reader)}) (type: list-of-a11y-states) The accessibility features to enable, given as list of symbols. @item @code{reader} (type: maybe-file-like) @@ -21917,8 +21914,7 @@ X Window @item @code{autologin-user} (type: maybe-string) The username to automatically log in with by default. -@item @code{greeter-session} @ -(default: @code{lightdm-gtk-greeter}) (type: greeter-session) +@item @code{greeter-session} (default: @code{lightdm-gtk-greeter}) (type: greeter-session) The greeter session to use, specified as a symbol. Currently, only @code{lightdm-gtk-greeter} is supported. diff --git a/gnu/services/lightdm.scm b/gnu/services/lightdm.scm index 7e3864fec2..0b9094cda1 100644 --- a/gnu/services/lightdm.scm +++ b/gnu/services/lightdm.scm @@ -151,7 +151,7 @@ (define-configuration lightdm-gtk-greeter-configuration "The name of the cursor theme to use.") (cursor-theme-size (number 16) - "The size to use for the the cursor theme.") + "The size to use for the cursor theme.") (allow-debugging? maybe-boolean "Set to #t to enable debug log level.") -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 22:39:42 2023 Received: (at 60582) by debbugs.gnu.org; 9 Feb 2023 03:39:42 +0000 Received: from localhost ([127.0.0.1]:57126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxmg-00068k-JN for submit@debbugs.gnu.org; Wed, 08 Feb 2023 22:39:42 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:45768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxme-00068W-0B for 60582@debbugs.gnu.org; Wed, 08 Feb 2023 22:39:41 -0500 Received: by mail-qt1-f172.google.com with SMTP id h24so647066qta.12 for <60582@debbugs.gnu.org>; Wed, 08 Feb 2023 19:39:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/XhCvghwgqQCvv4h/I6EQjQDr2/seD0+IfCVJ5DKPac=; b=ALf0rr+GzEu23eG1VOPDuLnaO82U9x6UcuT5wlcxeW2FnKiWY3ZurTyHUpDoGVCm3Z q6e5E8AZj0eEw1sikJlE1QAjwk/5oWUPXTyH9RiP/pmfBMACVZ/W/jSn7TW3TNqLQffQ WDAywQHubmPwhQ3HRz6hci1mymbf0tM8AGeulPUzQg6vUNB0FKTVm1UtAj9a50cYcyOK suI6QcasP909xrbdjZcBCcESQcc3TR3rOuSt2j3jzfA59U14u7mmjZg2DkHTh08wYbGN GcM6QNjBbRc+N2wHfcGJbDsa2UKYLZIoasC4t5cLvGkKJa+jldCabaYhzKvOJo0C/n8j AShQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/XhCvghwgqQCvv4h/I6EQjQDr2/seD0+IfCVJ5DKPac=; b=hbQuSBhNnb4+aLbsbQWmzTWv2FYwlxscS4l67Xlov5lbFpwhXKbChHGJZ5IMWALb84 5wQLmNJbsjEE9DTdwnxNTJy2JCDK1NINAB6RFHGd+ZPjSctUTZuu/q6p5o1IYi9GrYNZ r2KxPVuD6+X06ukjyyTeMsMdoYA+Ud+9p+Wpeb/XjYu1mdAZEQyhDLHmH81y9VYdkMXS Yam07I1hzJsqH6AtolpBZi1zeClXN2rr7AqZ2zN5xzrJ/tUAWYpS8i23wQUCxRT+MpRJ XmFA4vJw1OZ9sdiG161Ucik5xdvX8PepXMpHZdIo+9KTIQDIrmahGXu4UaM2k3hjo5K4 jp3w== X-Gm-Message-State: AO0yUKX6qDQIYgMsn2vS2wTD5ULAmn83k9SgiWdTXL0si11cyQW63P2z R1LOH7ogRYoTOdYjAe/TEWi0hgWX6B7wWg== X-Google-Smtp-Source: AK7set/J++jEZHpYaPi1RHGZykuYo9Vv+x4jen/G6DRRQ9U4LB7LchtunbXxGSVV6iflNuZZ69eB9g== X-Received: by 2002:ac8:7e87:0:b0:3b9:b619:42c1 with SMTP id w7-20020ac87e87000000b003b9b61942c1mr17675859qtj.27.1675913974101; Wed, 08 Feb 2023 19:39:34 -0800 (PST) Received: from hurd (dsl-151-105.b2b2c.ca. [66.158.151.105]) by smtp.gmail.com with ESMTPSA id c17-20020ac81e91000000b003b6382f66b1sm512417qtm.29.2023.02.08.19.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 19:39:33 -0800 (PST) From: Maxim Cournoyer To: Bruno Victal Subject: Re: bug#60582: [PATCH] Properly format list of packages & sync lightdm documentation. References: <0e6cbfdffea195d739ef180031dc2d6726203e0f.1673645697.git.mirai@makinata.eu> <6a46a643dbd361fd188a67f3d5f59feeead08cfe.1673645697.git.mirai@makinata.eu> Date: Wed, 08 Feb 2023 22:39:32 -0500 In-Reply-To: <6a46a643dbd361fd188a67f3d5f59feeead08cfe.1673645697.git.mirai@makinata.eu> (Bruno Victal's message of "Fri, 13 Jan 2023 21:34:58 +0000") Message-ID: <87y1p7ik23.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: 60582@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Bruno Victal writes: > Table entry @item nodes cannot span multiple lines. So it needed some manual fix-up? Good to know; working toward automating the expansion of the auto-generated parts in the manual, we'll have to figure that. Future work! LGTM. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 23:00:29 2023 Received: (at 60582-done) by debbugs.gnu.org; 9 Feb 2023 04:00:29 +0000 Received: from localhost ([127.0.0.1]:57134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPy6m-0006n5-HD for submit@debbugs.gnu.org; Wed, 08 Feb 2023 23:00:29 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:37754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPy6g-0006mk-DA for 60582-done@debbugs.gnu.org; Wed, 08 Feb 2023 23:00:28 -0500 Received: by mail-qt1-f169.google.com with SMTP id m12so727963qth.4 for <60582-done@debbugs.gnu.org>; Wed, 08 Feb 2023 20:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=w0a+ChwMiXlrneEkQ6yEUemrYI6vF0yOozK03J49I/M=; b=mRdoOLY30qJNbDgi+6g46N3BGBM6PAD8FGuso+RDOq/ReEVaQa7IbXpXCM/pNQKbAK hrWFyyXrfRe4WEGhdupFf3M0HQNeEYGa1RXAjRrxLiTLgIjJSerwiAHfQcb1r1XfNwAP 4gNcV8kz6z/b/U8daGIbU5608iy5eXh0Oq+Bkkrjvj6YPdfdSlE7/g6E+qs0PnilCd4/ F2fxBz2VRbT4r0dj0ADv23oyQg6Qv/IYnBRIKG1ipflEG6oGsC/8NjVfKMS0njGMPCQg SfmYCWkXH43Di1e702UkQ/MwBwhL1AQkpK4pDcNFEG0PfkrdvOsEVqi5xRsjr72TGrfu nzag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w0a+ChwMiXlrneEkQ6yEUemrYI6vF0yOozK03J49I/M=; b=HBxlrlUrJRqIi9qQD8NsHdYp01rRlzmjGLaXMEo/bzTORRxO8aLH+LqZBcm+8YQFQ/ I4HHpq9W6Ymzrewm+GAaHmLASgkGX+7a1QT6bCv4X1Y3UphgvSFNRXmMaHnOMZkwSpt1 xpMenBMHZ1ciPf/urZ51xIpUfKb9eAXAYiA9/Ad/WQlHniOV3M9w9Tvj8qaJuoCMeFpx aXle7lipXk+elPv71TkVVPaGjvWuKnLUBe/jj2o58VSJTDECQMiC/OcQ5eRqmucP/eRg QKfhbl0WtWME92vL0e5t5lxkRGTZj2AGfFf7yh7Ce0ebzujAzOqUEUNdz3XjaaHhPFzp BPqQ== X-Gm-Message-State: AO0yUKWW/coT0D7oM2Au9b4b0p9gTjDvjCVc5FXeBPzI/P4CTa4WkLE1 SKdJs/XH99iwwwLMAAun5Jw+c7iGkGlpZQ== X-Google-Smtp-Source: AK7set83O2gCtwJAO8d+aVb492qf1GiPORkmQqMiYANnTIFKXg3RIkqTYa/zzOqu06/Md+f4yvV+Uw== X-Received: by 2002:a05:622a:1812:b0:3b8:5dfe:ef3 with SMTP id t18-20020a05622a181200b003b85dfe0ef3mr16180363qtc.68.1675915216575; Wed, 08 Feb 2023 20:00:16 -0800 (PST) Received: from hurd (dsl-151-105.b2b2c.ca. [66.158.151.105]) by smtp.gmail.com with ESMTPSA id 136-20020a370c8e000000b00706aeebe71csm511449qkm.108.2023.02.08.20.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 20:00:16 -0800 (PST) From: Maxim Cournoyer To: Bruno Victal Subject: Re: bug#60582: [PATCH] Properly format list of packages & sync lightdm documentation. References: <0e6cbfdffea195d739ef180031dc2d6726203e0f.1673645697.git.mirai@makinata.eu> <6a46a643dbd361fd188a67f3d5f59feeead08cfe.1673645697.git.mirai@makinata.eu> Date: Wed, 08 Feb 2023 23:00:03 -0500 In-Reply-To: <6a46a643dbd361fd188a67f3d5f59feeead08cfe.1673645697.git.mirai@makinata.eu> (Bruno Victal's message of "Fri, 13 Jan 2023 21:34:58 +0000") Message-ID: <87r0uzij3w.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582-done Cc: 60582-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! I merged this series as 8a2c2eaa90. Thank you! -- Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 11:17:30 2023 Received: (at 60582) by debbugs.gnu.org; 9 Feb 2023 16:17:30 +0000 Received: from localhost ([127.0.0.1]:33453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ9c1-0001Nd-RZ for submit@debbugs.gnu.org; Thu, 09 Feb 2023 11:17:30 -0500 Received: from smtpmciv1.myservices.hosting ([185.26.107.237]:39424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ9bz-0001NT-TZ for 60582@debbugs.gnu.org; Thu, 09 Feb 2023 11:17:28 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv1.myservices.hosting (Postfix) with ESMTP id 2AC1A20C3A; Thu, 9 Feb 2023 17:17:22 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id C0F768009A; Thu, 9 Feb 2023 17:17:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QWd6E3RN0Ife; Thu, 9 Feb 2023 17:17:22 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 2DDB780097; Thu, 9 Feb 2023 17:17:22 +0100 (CET) Message-ID: Date: Thu, 9 Feb 2023 16:17:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: bug#60582: [PATCH] Properly format list of packages & sync lightdm documentation. Content-Language: en-US To: Maxim Cournoyer References: <0e6cbfdffea195d739ef180031dc2d6726203e0f.1673645697.git.mirai@makinata.eu> <6a46a643dbd361fd188a67f3d5f59feeead08cfe.1673645697.git.mirai@makinata.eu> <87y1p7ik23.fsf_-_@gmail.com> From: Bruno Victal In-Reply-To: <87y1p7ik23.fsf_-_@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 60582 Cc: 60582@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2023-02-09 03:39, Maxim Cournoyer wrote: > Bruno Victal writes: > >> Table entry @item nodes cannot span multiple lines. > > So it needed some manual fix-up? Good to know; working toward > automating the expansion of the auto-generated parts in the manual, > we'll have to figure that. Future work! The automatic expansion works correctly, this was an error from manually fixing up the previous entries when `generate-documentation' couldn't handle lists of package objects. Cheers, Bruno From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 11:42:39 2023 Received: (at 60582) by debbugs.gnu.org; 9 Feb 2023 16:42:39 +0000 Received: from localhost ([127.0.0.1]:33512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQA0N-0004Ul-4p for submit@debbugs.gnu.org; Thu, 09 Feb 2023 11:42:39 -0500 Received: from mail-qt1-f170.google.com ([209.85.160.170]:35371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQA0M-0004UX-1m for 60582@debbugs.gnu.org; Thu, 09 Feb 2023 11:42:38 -0500 Received: by mail-qt1-f170.google.com with SMTP id q13so2618434qtx.2 for <60582@debbugs.gnu.org>; Thu, 09 Feb 2023 08:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=YJP4obpkJnHzTPQftn81aSwNHggIk+xeh/35Kakc8bw=; b=USYCAHCErlOpfGEAOLY/TKJnJ/pspYhRXMm9NhujjfOPem25iEFiipSYVQjLRgJBJ+ pxlcaaFS/D7KqAS15TrLrMetR9UNAoB7gIRMmnXaypzDutbx8sjP3upK2xgH33JQ7m0z oPyzwbKQq4k8pV7OyKIW1oRPdIeodW2oKLC6FFDqWqLIh0ibTvbTIvamF4cdP6EMWWqB SR5KYRErbAUwq2V744WMsKJXEMLM13U90NfVk5TMATMq1K1EX7C7XgX/6zvWSUh3VZ+q D/VR/HOkFjrE7npuGdOKsXoFWNrUJ1Xc7T7Lq1zsXD4Iwez3YJcoCyPuIBNPqAqeEdHC U7rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YJP4obpkJnHzTPQftn81aSwNHggIk+xeh/35Kakc8bw=; b=3uF/aNUkBhnglw2ab2vd8vRglInQQTMGCr4ZeeO97vN94Ye04awYQ3yWSLDBD/uo01 KqwSenRNpabmF9DTBGwQJYmghC/zKm6XFzrUDrRiYWZh3TbrZTYNFVy7lNGhelkYSyqL d8y7+rYXWpIoFIRgoa94aMVe+7dgTzOBpKvRo7gGOVPn5Lqej0avhe7YPK3NdoB0FSuc EB2S2FPb4yXy0IGf3jSWgcs0Nedu/U6yqNxRtjPkrWVzr/HPVecTlCMQTGbRXrqlpPoF bVLCLb7wt9r0Cdv4Muqn88g/g6H94+l/1s1in3t2T5FUT4aUREMFWos/dxmMMHRmINjR i20w== X-Gm-Message-State: AO0yUKUQSnYyOxhU/UPmjFoZCIzdxVVCsorpxgNY1Frdjc+W8HabqtBb FrkqUdZLwsslDOeByvZx13TdU9oGjweLvHnH X-Google-Smtp-Source: AK7set+f1PLmCYJQ7FehWgLfqDVENBeTGRiCvn5ijxktOXuXIs/IFKYVfNWRwmqyUTg0EsknS9b7HQ== X-Received: by 2002:ac8:5881:0:b0:3b7:faaf:f6da with SMTP id t1-20020ac85881000000b003b7faaff6damr22329546qta.50.1675960952380; Thu, 09 Feb 2023 08:42:32 -0800 (PST) Received: from hurd (dsl-151-105.b2b2c.ca. [66.158.151.105]) by smtp.gmail.com with ESMTPSA id r204-20020a3744d5000000b00706bc44fda8sm1672346qka.79.2023.02.09.08.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 08:42:31 -0800 (PST) From: Maxim Cournoyer To: Bruno Victal Subject: Re: bug#60582: [PATCH] Properly format list of packages & sync lightdm documentation. References: <0e6cbfdffea195d739ef180031dc2d6726203e0f.1673645697.git.mirai@makinata.eu> <6a46a643dbd361fd188a67f3d5f59feeead08cfe.1673645697.git.mirai@makinata.eu> <87y1p7ik23.fsf_-_@gmail.com> Date: Thu, 09 Feb 2023 11:42:30 -0500 In-Reply-To: (Bruno Victal's message of "Thu, 9 Feb 2023 16:17:21 +0000") Message-ID: <875ycahjt5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60582 Cc: 60582@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) hi, Bruno Victal writes: > On 2023-02-09 03:39, Maxim Cournoyer wrote: >> Bruno Victal writes: >> >>> Table entry @item nodes cannot span multiple lines. >> >> So it needed some manual fix-up? Good to know; working toward >> automating the expansion of the auto-generated parts in the manual, >> we'll have to figure that. Future work! > > The automatic expansion works correctly, this was an error from > manually fixing up the previous entries when > `generate-documentation' couldn't handle lists of package objects. I see, thanks for the explanation! -- Thanks, Maxim From unknown Wed Jun 18 23:12:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 10 Mar 2023 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator