GNU bug report logs - #60571
activating tests for skia 2D graphics library

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 60571 <at> debbugs.gnu.org
Subject: [bug#60571] [PATCH v2 3/4] gnu: Add icu4c-for-skia.
Date: Tue, 29 Aug 2023 10:46:05 -0400

Hi Nicolas,

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> On 2023-08-28 11:48, Maxim Cournoyer wrote:
>
>> Hello!
>>
>> Nicolas Graves <ngraves <at> ngraves.fr> writes:
>>
>>
>> The comments are a bit terse; I'd expound them to complete sentences
>> with a tad more context.
>
> Will try to expand a bit, but that will be hard, the commits are very
> old and my memory of this mostly faded.
>
>>
>> I'm confused here; we re-run the configure script post installation?
>> How does that work?  If that's really needed it needs a proper
>> explanatory comment.
>
> IIRC, since we use this version of icu4c to run tests, we needed to
> also build some "data". It's rather a reconfiguration to build data
> rather than a re-run of the configuration script post-installation.

That would perfect in an explanatory comment :-).

>>
>> The rest looks good!  It's seems a tricky package, well done!  Could you
>> please send a v2 with the above suggestions/comments taken into account?
>
> Doing so 

Super!  Thanks for seeing it through.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.