GNU bug report logs - #60567
[PATCH] gnu: Add ftxui

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60567 in the body.
You can then email your comments to 60567 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add ftxui
Date: Thu, 05 Jan 2023 08:42:06 +0300

[Message part 1 (text/plain, inline)]

Hello,

this patch adds FXTUI[1], a simple C++ library for terminal based user
interfaces.

[0001-gnu-Add-ftxui.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

I decided to place this package in a separate module called "tui.scm" as
there are other libraries for building text-based user interfaces that
can be added in the future (like [2], for example.)

Also to check if the library installed right I tried to build "tiles"
game[3] that is using FXTUI:

--8<---------------cut here---------------start------------->8---
git clone https://github.com/tusharpm/tiles.git
cd tiles
guix shell binutils gcc
mkdir build
cd build
cmake ..
make -j$(nproc)
--8<---------------cut here---------------end--------------->8---

Which worked out flawlessly.

Thanks,
- avp

References:
1. https://github.com/ArthurSonzogni/FTXUI
2. https://github.com/gansm/finalcut
3. https://github.com/tusharpm/tiles

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 60567 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 60567 <at> debbugs.gnu.org
Subject: Re: bug#60567: [PATCH] gnu: Add ftxui
Date: Sun, 08 Jan 2023 18:06:00 +0100

Hello Artyom,

> +++ b/gnu/packages/tui.scm

I'm not sure about the new tui module because a lot of packages could
fall into that category, all ncurses based programs for instance.

> +    (arguments
> +     (list #:tests? #f)) ;Tests require gtest

Providing googletest as a native-inputs doesn't help here?

Thanks,

Mathieu

Message #11 received at 60567 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 60567 <at> debbugs.gnu.org
Subject: Re: bug#60567: [PATCH] gnu: Add ftxui
Date: Sun, 08 Jan 2023 20:49:50 +0300

[Message part 1 (text/plain, inline)]

Hello Mathieu!

Thank you for the patch review.

I fixed the patch, please find the updated version attached.

[0001-gnu-Add-ftxui.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 60567 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 60567 <at> debbugs.gnu.org
Subject: Re: bug#60567: [PATCH] gnu: Add ftxui
Date: Sun, 08 Jan 2023 20:52:59 +0300

[Message part 1 (text/plain, inline)]

> I'm not sure about the new tui module because a lot of packages could
> fall into that category, all ncurses based programs for instance.

I'm not sure about the new module either, but where would you put this
package?

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 60567 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 60567 <at> debbugs.gnu.org
Subject: Re: bug#60567: [PATCH] gnu: Add ftxui
Date: Mon, 09 Jan 2023 22:55:48 +0300

[Message part 1 (text/plain, inline)]

Hello,

I decided to move the FTXUI package to "cpp.scm" module as the library
provides API mainly for C++ programs.

[0001-gnu-Add-ftxui.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 60567-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 60567-done <at> debbugs.gnu.org
Subject: Re: bug#60567: [PATCH] gnu: Add ftxui
Date: Tue, 10 Jan 2023 09:16:48 +0100

Hell Artyom,

> I decided to move the FTXUI package to "cpp.scm" module as the library
> provides API mainly for C++ programs.

OK, thanks for the v2!

Applied.

Mathieu

Message #25 received at 60567 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 60567 <at> debbugs.gnu.org
Subject: Re: bug#60567: [PATCH] gnu: Add ftxui
Date: Tue, 10 Jan 2023 10:55:58 +0100

Hey Artyom,

I noticed that the package is failing on non-x86_64 architectures:
https://ci.guix.gnu.org/eval/104402?status=failed.

Could you please have a look?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.