GNU bug report logs - #60562
[PATCH] Fix split-string error if there is a space in the filename.

Previous Next

Package: emacs;

Reported by: lux <lx <at> shellcodes.org>

Date: Wed, 4 Jan 2023 22:58:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #55 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Moreton <andrewjmoreton <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#60562: [PATCH] Fix split-string error if there is a space in
 the filename.
Date: Sun, 15 Jan 2023 12:33:49 +0000
On Sat 07 Jan 2023, Eli Zaretskii wrote:

>> Cc: 60562 <at> debbugs.gnu.org
>> Date: Sat, 7 Jan 2023 17:42:35 +0800
>> From: lux <lx <at> shellcodes.org>
>> 
>> On Fri, 06 Jan 2023 10:48:43 +0100
>> Robert Pluim <rpluim <at> gmail.com> wrote:
>> 
>> > You can avoid the issue (and improve portability) by using
>> > `directory-files-recursively' instead of `find'
>> 
>> But `hfy-find-cmd' is a configurable variable:
>> 
>> (defcustom hfy-find-cmd
>>   "find . -type f \\! -name \\*~ \\! -name \\*.flc \\! -path
>> \\*/CVS/\\*" "Find command used to harvest a list of files to attempt
>> to fontify." :tag   "find-command"
>>   :type  '(string))
>
> We can convert that to a customizable regexp, and maybe to a predicate
> function if a simple regexp won't do.
>
>> I don't know if using `directory-files-recursively' has other effects.
>
> Why would that bother us?  This is used to find the files under a
> given directory, avoiding some files which we know will not be wanted.

The fixes for this problem now cause bootstrap to fail, due to the
defcustom for hfy-exclude-file-rules containing a version tag that is
not a string.

    AndyM





This bug report was last modified 2 years and 186 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.