GNU bug report logs - #60562
[PATCH] Fix split-string error if there is a space in the filename.

Previous Next

Full log

Message #47 received at 60562 <at> debbugs.gnu.org (full text, mbox):

From: lux <lx <at> shellcodes.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Ruijie Yu <ruijie <at> netyu.xyz>, 60562 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#60562: [PATCH] Fix split-string error if there is a space
 in the filename.
Date: Mon, 09 Jan 2023 22:55:58 +0800

Robert Pluim <rpluim <at> gmail.com> writes:

>     >>
>     >> Also, in this change, we are dropping the requirement that the found
>     >> file are actually files, whereas we used to say "-type f".  Is this
>     >> change fine?
>     >>
>
> `directory-files-recursively' by default only returns files (and the
> latest patch explicitly passes `nil' for INCLUDE-DIRECTORIES anyway)
>

"-type f" will return all regular files, `directory-files-recursively'
contains all types of files (socket, block, etc..), so I latest patch
added `file-regular-p' to check the file type.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.