GNU bug report logs - #60557
[PATCH] Fix eglot prompt when connection already exists

Previous Next

Package: emacs;

Reported by: Evgeni Kolev <evgeni.d.kolev <at> gmail.com>

Date: Wed, 4 Jan 2023 15:46:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: evgeni.d.kolev <at> gmail.com, 60557 <at> debbugs.gnu.org
Subject: bug#60557: [PATCH] Fix eglot prompt when connection already exists
Date: Mon, 16 Jan 2023 16:15:28 +0200
> From: João Távora <joaotavora <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  60557 <at> debbugs.gnu.org
> Date: Mon, 16 Jan 2023 11:53:14 +0000
> 
> [ Eli, I pushed this change to emacs-29 as this in effect a bugfix and
> Eglot is a new package anyway.  Let me know if you'd rather I push this
> to master instead (it doesn't make much of a difference in practice
> since eglot.el is a GNU ELPA packge) ]

The release branch is OK for this kind of changes, thanks.

However, note that this change now causes

  In eglot:
  progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive'

because the INTERACTIVE argument is now unused.  Should it be renamed
to _interactive?




This bug report was last modified 2 years and 125 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.