From unknown Fri Jun 20 07:13:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60557 <60557@debbugs.gnu.org> To: bug#60557 <60557@debbugs.gnu.org> Subject: Status: [PATCH] Fix eglot prompt when connection already exists Reply-To: bug#60557 <60557@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:13:01 +0000 retitle 60557 [PATCH] Fix eglot prompt when connection already exists reassign 60557 emacs submitter 60557 Evgeni Kolev severity 60557 normal tag 60557 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 04 10:45:04 2023 Received: (at submit) by debbugs.gnu.org; 4 Jan 2023 15:45:05 +0000 Received: from localhost ([127.0.0.1]:49367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD5wu-0007i3-HN for submit@debbugs.gnu.org; Wed, 04 Jan 2023 10:45:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:35744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pD5ws-0007hr-6o for submit@debbugs.gnu.org; Wed, 04 Jan 2023 10:45:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD5wq-0003II-9H for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 10:45:00 -0500 Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pD5wm-0003EI-Qp for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 10:44:58 -0500 Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-46198b81e5eso481751317b3.4 for ; Wed, 04 Jan 2023 07:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jhYUibNUy6Gan+aNGz+/5VCOg1Y0TwIvuEkbO6H9b0c=; b=pV80v2cJJXBYxOrbHEH0XYtY4/F+8vYaA3Ci3WeatNB1aZRyhyWjeNxDguhfEuT0+H Pi6wlEo6ruNuWenAJ3I1BzKJm91egZ2Fb9Yn0f0znZJe0ILn8SZQGwLa5u7TIi6/mAkd 6mgwIkWXewsGaU7q0SjwdGIEWbOWQIL26jrbCKJL61LcM7xZJOdyi7A+qtZB9YjBDhj4 1ErG4M/HzFeXIzFi3qVFk/iM6pLT1lOrlgWkmnywazOGX4mVTLtLdjbubKZpRZAFFoPd P8cdLyW0jC+7KW/LZ3Zciwaz3fRy152H4NVw+pjCrCGIeY3fP2yNT+NP0TZtcTrMCPEr AQow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jhYUibNUy6Gan+aNGz+/5VCOg1Y0TwIvuEkbO6H9b0c=; b=F2Ub3e/1HeS32rHytr3UGEt1GWtPT2KkbJA/XCRYFhaUm2xmSflAQlGxQwf7cuwvuu U35bUg2/8qK3a9XEhGJfHNfWhBFdf0EcOlAs6bAZq2alqI00Z0HtQHLFvBQDRbqW6Jat +etyXf6vbrDmorXUs4JgkXrxprifBmNx5lUK0/T08VOrjtEjtq4xpUchwB8/3qLAH5Q1 me+dTlR86AJa24LoPl7pGcv69jA4KZB7auowcwIsfzHMVEEPAD8LYacZu3SFAMWlXffb DbAe+MnU5p4a581f8chjudB8nvscz7Zq56y7VarW4p/V8SMa54+73fCk4w2JyCiHrmxP 6Ygg== X-Gm-Message-State: AFqh2kqd5ZcOFXVkhErDsS4vZLMfA4NWa6tX141edSpZlNL8gjkV+P3K WSBWVHDrQHV3Fv9XJw27O48Fdabt1XVuTr1bsDkY4siWNQ0flOQe X-Google-Smtp-Source: AMrXdXuiXsSSCh1oI79FRJk3BvKyEjdWAo5K4TfRRMufsv2+4YOJL3P1sPOf4WyweQ5DUrPVMYAOY5fTMcJRawyyJpQ= X-Received: by 2002:a05:690c:80c:b0:46d:89d7:498f with SMTP id bx12-20020a05690c080c00b0046d89d7498fmr4049342ywb.461.1672847093821; Wed, 04 Jan 2023 07:44:53 -0800 (PST) MIME-Version: 1.0 From: Evgeni Kolev Date: Wed, 4 Jan 2023 17:44:27 +0200 Message-ID: Subject: [PATCH] Fix eglot prompt when connection already exists To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::1130; envelope-from=evgenysw@gmail.com; helo=mail-yw1-x1130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) [CC-ing Jo=C3=A3o T=C3=A1vora, author of eglot] This patch fixes an incorrect behavior of eglot. To reproduce: - run M-x eglot - run M-x eglot (again) - eglot now prompts whether to reconnect to the existing LSP - enter "n" (for no) - now eglot shuts down the LSP process and reconnects - this is not correct, the expected behavior is to not reconnect The patch is below. commit f7626c070d4bd63fab1df33153ab9deaec0a3f7b (HEAD -> master) Author: Evgeni Kolev Date: Wed Jan 4 17:36:30 2023 +0200 Fix eglot prompt when connection already exists When M-x eglot is executed twice, the second time it prompts whether to reconnect. Answering "no" was not working correctly - the existing LSP process was still reconnected. This behavior is fixed, answering "no" results in keeping the existing connection. diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 6d192d9b333..7ac123f3c09 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1116,10 +1116,9 @@ eglot (setq managed-major-mode (eglot--ensure-list managed-major-mode)) (let* ((current-server (eglot-current-server)) (live-p (and current-server (jsonrpc-running-p current-server)))) - (if (and live-p - interactive - (y-or-n-p "[eglot] Live process found, reconnect instead? ")) - (eglot-reconnect current-server interactive) + (if (and live-p interactive) + (when (y-or-n-p "[eglot] Live process found, reconnect instead? ") + (eglot-reconnect current-server interactive)) (when live-p (ignore-errors (eglot-shutdown current-server))) (eglot--connect managed-major-mode project class contact language-id= )))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 04:35:11 2023 Received: (at 60557) by debbugs.gnu.org; 12 Jan 2023 09:35:11 +0000 Received: from localhost ([127.0.0.1]:44696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtzK-00072w-Ok for submit@debbugs.gnu.org; Thu, 12 Jan 2023 04:35:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtzJ-00072j-9X for 60557@debbugs.gnu.org; Thu, 12 Jan 2023 04:35:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtzD-0007sC-VE; Thu, 12 Jan 2023 04:35:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=PeFbIUNIUP9oB205sz1QeDgiBFonzD37PMsB56foIeM=; b=rJ7jP/2oTD077MnIIta/ X8lBOxK9Tc45QwQb21iQwmPafDA7oJxcLzyeHVy3sfAObv/ZYicFj7nZ2vykIrV/e8duxlsfT/nZH q51yPSzD1M7c2tGAtkjAU3BvFSwd+uMkZTA523k5s38MTqbE5TeGgdFHQHCLnuJR8HhGfRIBisjht k9klLv+P2WIsXycc46IoLHg5+PEPk8mPkVig60TjVGxMusGwFPw+UrIDJXsuoRMqsIxvldf3HJMUj 7FF3GpTr3czqJSd/WtCHuJJxecA4N0WHgL7a6zOBIZTyAbzH0XSlGDJVkzTAqNxLJoYIHWQMOzUaX heQh//+7Su7gjg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtzC-0004nZ-UK; Thu, 12 Jan 2023 04:35:03 -0500 Date: Thu, 12 Jan 2023 11:35:37 +0200 Message-Id: <83cz7kksd2.fsf@gnu.org> From: Eli Zaretskii To: Evgeni Kolev In-Reply-To: (message from Evgeni Kolev on Wed, 4 Jan 2023 17:44:27 +0200) Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60557 Cc: 60557@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: joaotavora@gmail.com > From: Evgeni Kolev > Date: Wed, 4 Jan 2023 17:44:27 +0200 > > [CC-ing João Távora, author of eglot] > > This patch fixes an incorrect behavior of eglot. To reproduce: > - run M-x eglot > - run M-x eglot (again) > - eglot now prompts whether to reconnect to the existing LSP > - enter "n" (for no) > - now eglot shuts down the LSP process and reconnects - this is not > correct, the expected behavior is to not reconnect > > The patch is below. João, any comments? From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 05:52:11 2023 Received: (at 60557) by debbugs.gnu.org; 12 Jan 2023 10:52:11 +0000 Received: from localhost ([127.0.0.1]:44785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFvBr-0000cP-Dq for submit@debbugs.gnu.org; Thu, 12 Jan 2023 05:52:11 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:50742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFvBm-0000bp-Kr for 60557@debbugs.gnu.org; Thu, 12 Jan 2023 05:52:10 -0500 Received: by mail-wm1-f42.google.com with SMTP id m3so12905562wmq.0 for <60557@debbugs.gnu.org>; Thu, 12 Jan 2023 02:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=an0w+T5vHW9BB7wODVMiOm654Rzn0OqK/IeCaRQIYK8=; b=cnZjSTRqiODxpVg6OYORLPHKJXC8hP3r5Q6UwGIv5QT/FdqLJZioKBwhDE2Rvhigy/ GlkC30tzLmqcETP+eN602j+QYWtBa2dP8HEy3YV7ettehqMuzcCoQ5CYExgp+m/8dZNJ 06xY5uYA88Rsxbny7vADZYxAdjnjSgSyxFyDrGEdgFv76TPpbyCHtbnNrbGr5zDn82hx w3B0Do6u58L3GRWXaYIYlZVdmJkYkm3BsqmguNTIZyNOXI/OxJziT37T5HDDh5jtp/4g mdyxrRzq3l1iEf9Y6O8VkxutTROQ2HGq8DSTqtlqkKAiuIZrFYhfNSS6FFSS6xk3PMep yNIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=an0w+T5vHW9BB7wODVMiOm654Rzn0OqK/IeCaRQIYK8=; b=6Fx0WycvPF96/s0e9Hl2xBWC8sUjE0IuOp8XpzEku6BZxn2QznfoWT5P3vtaWbflwG WCz4XOSezGfkStl+qJTwfCDuajIMaidcNPTEci+R/sK3tqsGKTPRmpxkTrrFUjnYhksm KEY/NE9nlrAGKHFiYVr84p/N9IBy1tiR3KY2gNobYBjkIG2ye/xDK07Z49MdpTtvwxVD hYfg8mPJFtfEsf9ptSZZ0yJffIQSvagzNo0jfE0KBmRWQPpPxwwWqwpfea0NiW/cqiNh X8wDy0RB0l0dWVmofSySEqOqj8g2iFvWB9161s1Y6y9ebLqduMDv7ikMWfjtQN3/kFya LrqA== X-Gm-Message-State: AFqh2kqvnSBIVUOn/iAjhpoXNlEEZwHYHke8bMoJfKc+k/xZXvDTQGlL anyI8wT+xinB2/MR6+l7sXGH62oSY34= X-Google-Smtp-Source: AMrXdXsVRhA2SRHKRzqo8PdUEYIL7qqj5UxREzY6tOUaFwWhiSrQmzVCrYeghvaZsgxRjpuvuCsy0w== X-Received: by 2002:a05:600c:601e:b0:3d0:7fee:8a70 with SMTP id az30-20020a05600c601e00b003d07fee8a70mr57468340wmb.19.1673520720160; Thu, 12 Jan 2023 02:52:00 -0800 (PST) Received: from krug (87-196-72-225.net.novis.pt. [87.196.72.225]) by smtp.gmail.com with ESMTPSA id v10-20020a05600c444a00b003d998412db6sm28006940wmn.28.2023.01.12.02.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 02:51:59 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Eli Zaretskii Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists In-Reply-To: <83cz7kksd2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 12 Jan 2023 11:35:37 +0200") References: <83cz7kksd2.fsf@gnu.org> Date: Thu, 12 Jan 2023 10:53:35 +0000 Message-ID: <87sfggrplc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60557 Cc: Evgeni Kolev , 60557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: joaotavora@gmail.com >> From: Evgeni Kolev >> Date: Wed, 4 Jan 2023 17:44:27 +0200 >>=20 >> [CC-ing Jo=C3=A3o T=C3=A1vora, author of eglot] >>=20 >> This patch fixes an incorrect behavior of eglot. To reproduce: >> - run M-x eglot >> - run M-x eglot (again) >> - eglot now prompts whether to reconnect to the existing LSP >> - enter "n" (for no) >> - now eglot shuts down the LSP process and reconnects - this is not >> correct, the expected behavior is to not reconnect >>=20 >> The patch is below. > > Jo=C3=A3o, any comments? Yes, sorry for the delay. Evgeni Kolev writes: > This patch fixes an incorrect behavior of eglot. To reproduce: > - run M-x eglot > - run M-x eglot (again) > - eglot now prompts whether to reconnect to the existing LSP > - enter "n" (for no) > - now eglot shuts down the LSP process and reconnects - this is not > correct, the expected behavior is to not reconnect Well you _are_ seing the expected behaviour! To "disconnect and connect again" is different from "reconnect". Thought often not much in practice, the former means you can use different command arguments to the server, like when doing C-u M-x eglot or when M-x eglot can't guess a command and lets you type one in. So in a way, it's like the message should be: "Do you want to reconnect to same language server or do you want to disconnect and connect again with whatever new things you've passed to M-x eglot?" However, I agree 100% with you that this message is very confusing. I've been baffled by it before. So we should attempt a fix. Unfortunately, your patch introduces a problem, so I don't think it should be merged. If we install it, it means that a user doing: M-x eglot RET /path/to/some/server-that-works-but/not-very-well RET M-x eglot RET /this/one/is/much-better RET will never have an interactive chance to actually try the 'much-better' server. For this user, it's either reconnect to 'not-very-well' or don't do anything at all. And that's probably not what the user meant, and she has wasted the effort of typing "/this/one/is/much-better". Do you understand? Going forward, we must ask: do we want to keep the "do you want to reconnect instead" possibility? 1) if yes, then there probably has to be a three-way query somewhere offering options a) reconnect, b) disconnect-then-connect, and c) do nothing. This is a bit akward, but it is doable. This query should happen sooner than it does not, probably in 'eglot--guess-contact', _before_ asking the user about any interactive arguments to 'M-x eglot' 2) if no, then we are saying that an interactive 'M-x eglot' is either going to tear down any current connection or do anything at all. That's fine by me. A simple reconnect is still just an 'M-x eglot-reconnect' away. If we 2.1) don't touch 'eglot--guess-contact' it'll still be a bit akward to be given the possiblity to answer "no" after typing in the new server path. If we 2.2) adjust 'eglot--guess-contact', that quirk could be solved. I think 2.1 and 2.2 are the best solutions here, 2.2 being clearly better. But 2.1 is less disruptive and easier to code than 2.2. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 01:03:36 2023 Received: (at 60557) by debbugs.gnu.org; 14 Jan 2023 06:03:36 +0000 Received: from localhost ([127.0.0.1]:53032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGZdd-0005az-Ci for submit@debbugs.gnu.org; Sat, 14 Jan 2023 01:03:35 -0500 Received: from mail-yb1-f178.google.com ([209.85.219.178]:43890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGZdb-0005ai-Kc for 60557@debbugs.gnu.org; Sat, 14 Jan 2023 01:03:32 -0500 Received: by mail-yb1-f178.google.com with SMTP id 203so24761733yby.10 for <60557@debbugs.gnu.org>; Fri, 13 Jan 2023 22:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gq6iMsy5AqFowMfiUpssILLVB4U7A80VjXNaoVHsFng=; b=Y5rFOR4mIhL+Y1dL8oiXCcv3CCp0EXptDO6DycXRacwFwZ8bDExVpc+eaosOLW6/Pg QxpPtZbNL3hc/vMXkO3lvdqk3MkwekY/ryJRS3XNLnl9okKSzQS7zZxSiMqkioGc7v/p 6FsdCHwUMxIy+giTkSNnM6X2DUJz4zb6yEKFFDJFcEjwqC046rYwT/8e6R4fzxLisi3B bRlHuT8pie5KnP8E1EaS+4twRYUMBfKOO5kUI55IaIv4MaVDRsCF4OgkWXo2aOEMgpHu PWuLbMj3WywV+NCo9eSnkkWBMxauO6jk0BrX03TGnlU7MITJhMQkMxRrqEGkBSbvBqXk InMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gq6iMsy5AqFowMfiUpssILLVB4U7A80VjXNaoVHsFng=; b=TZh1ZbCCDFwwvajX4lWFazlcJ2BqT/S2XF/UxEgeurq2TvvulIAvtZElT7B1dAc9AM ICYdfbbT1gsfCn46WksocdDnyaAPRrtJxlD7T0bftrfmcUz9W9KFKhqa66WIB+tzPwZT fmXwrEJNHdpNSDsoResx+s2L5Y6wXrHnSUAsfkYDjYHpPCLwhM27DlTF6R2aQnHwjMs4 SF43dhuPNuyLTYgsWbwG0diOXvXNaMUzQ4054GfFw3YNsChS3YpGW0hVSNRTIdhfvVi7 lPy/tFCIOTQWs12U7XD9WOx7+/3bro0qs1xUlZ0Vm7SBkRvXiSFU2a9bZba+POtvqDcr knvA== X-Gm-Message-State: AFqh2kpcyEylOhHLdnxFto10lT4OsvHFHCg2fYzsARkmUvy4cw1DbZNg 4ARvSnR/cvxnKH4STKsXrpx0Vx+At6yuKgztfJHhOns9gzjByqlf X-Google-Smtp-Source: AMrXdXv9Gu9IARqTq8DlwQ91gAaMnPbr2SegrewMKlNGsZfiu6dxMYHGY+woBicG/VYkuov64x/+T/cLCRWBZnIiOZI= X-Received: by 2002:a25:23ce:0:b0:7d2:f850:6e96 with SMTP id j197-20020a2523ce000000b007d2f8506e96mr244050ybj.243.1673676205782; Fri, 13 Jan 2023 22:03:25 -0800 (PST) MIME-Version: 1.0 References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> In-Reply-To: <87sfggrplc.fsf@gmail.com> From: Evgeni Kolev Date: Sat, 14 Jan 2023 08:02:59 +0200 Message-ID: Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 60557 Cc: Eli Zaretskii , 60557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jo=C3=A3o, thank you for the detailed reply. Could you confirm I correctly understand proposal 2.1)? Example interaction= s: - M-x eglot RET ;; eglot guesses correctly the CONTACT - live connection exists? - no - new connection - yes - disconnect + new connection - M-x eglot /some/path RET ;; eglot can't guess so prompts the user - live connection exists? - no - new connection - yes - disconnect + new connection If I understand correctly, 2.1) always disconnects + reconnects. Regarding 2.2), I don't fully understand it - could you clarify how 2.2) is different from the _user's_ perspective? I'm also thinking about option 3) making M-x eglot able to detect a change in CONTACT: - M-x eglot RET - live connection exists? - no - new connection - yes - new CONTACT provided? - no - reconnect to old CONTACT - yes - disconnect + new connection to new CONTACT However, I couldn't find a way to detect a change in CONTACT because it's not preserved as-is (for example '(gopls)) but changed to a complex structure and stored to (eglot--saved-initargs server). It's also possible to check current-prefix-arg - if nil, then M-x eglot can deduce the CONTACT hasn't changed and can re-connect. If non-nil, then disconnect + connect. Still, I'm not sure 3) is worth it because the code will become complex, but from the user's perspective nothing will change - for the user reconnect is the same as disconnect + connect. On Thu, Jan 12, 2023 at 12:53 PM Jo=C3=A3o T=C3=A1vora wrote: > > Eli Zaretskii writes: > > >> Cc: joaotavora@gmail.com > >> From: Evgeni Kolev > >> Date: Wed, 4 Jan 2023 17:44:27 +0200 > >> > >> [CC-ing Jo=C3=A3o T=C3=A1vora, author of eglot] > >> > >> This patch fixes an incorrect behavior of eglot. To reproduce: > >> - run M-x eglot > >> - run M-x eglot (again) > >> - eglot now prompts whether to reconnect to the existing LSP > >> - enter "n" (for no) > >> - now eglot shuts down the LSP process and reconnects - this is not > >> correct, the expected behavior is to not reconnect > >> > >> The patch is below. > > > > Jo=C3=A3o, any comments? > > Yes, sorry for the delay. > > Evgeni Kolev writes: > > > This patch fixes an incorrect behavior of eglot. To reproduce: > > - run M-x eglot > > - run M-x eglot (again) > > - eglot now prompts whether to reconnect to the existing LSP > > - enter "n" (for no) > > - now eglot shuts down the LSP process and reconnects - this is not > > correct, the expected behavior is to not reconnect > > Well you _are_ seing the expected behaviour! To "disconnect and connect > again" is different from "reconnect". Thought often not much in > practice, the former means you can use different command arguments to > the server, like when doing C-u M-x eglot or when M-x eglot can't guess > a command and lets you type one in. > > So in a way, it's like the message should be: > > "Do you want to reconnect to same language server or do you want to > disconnect and connect again with whatever new things you've passed > to M-x eglot?" > > However, I agree 100% with you that this message is very confusing. > I've been baffled by it before. So we should attempt a fix. > > Unfortunately, your patch introduces a problem, so I don't think it > should be merged. If we install it, it means that a user doing: > > M-x eglot RET /path/to/some/server-that-works-but/not-very-well RET > M-x eglot RET /this/one/is/much-better RET > > will never have an interactive chance to actually try the 'much-better' > server. For this user, it's either reconnect to 'not-very-well' or > don't do anything at all. And that's probably not what the user meant, > and she has wasted the effort of typing "/this/one/is/much-better". Do > you understand? > > Going forward, we must ask: do we want to keep the "do you want to > reconnect instead" possibility? > > 1) if yes, then there probably has to be a three-way query somewhere > offering options a) reconnect, b) disconnect-then-connect, and c) do > nothing. This is a bit akward, but it is doable. This query should > happen sooner than it does not, probably in 'eglot--guess-contact', > _before_ asking the user about any interactive arguments to 'M-x > eglot' > > 2) if no, then we are saying that an interactive 'M-x eglot' is either > going to tear down any current connection or do anything at all. > That's fine by me. A simple reconnect is still just an 'M-x > eglot-reconnect' away. If we 2.1) don't touch 'eglot--guess-contact' > it'll still be a bit akward to be given the possiblity to answer "no" > after typing in the new server path. If we 2.2) adjust > 'eglot--guess-contact', that quirk could be solved. > > I think 2.1 and 2.2 are the best solutions here, 2.2 being clearly > better. But 2.1 is less disruptive and easier to code than 2.2. > > Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 12:22:56 2023 Received: (at 60557) by debbugs.gnu.org; 14 Jan 2023 17:22:56 +0000 Received: from localhost ([127.0.0.1]:55477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGkF6-0003mf-8Q for submit@debbugs.gnu.org; Sat, 14 Jan 2023 12:22:56 -0500 Received: from mail-oa1-f50.google.com ([209.85.160.50]:40685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGkF4-0003mO-JH for 60557@debbugs.gnu.org; Sat, 14 Jan 2023 12:22:55 -0500 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-15ee27bb0a8so5037709fac.7 for <60557@debbugs.gnu.org>; Sat, 14 Jan 2023 09:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/Idc6qXTZ6hlXWxoD4Eih/KCjk8gd67wFMMcIbrtCxk=; b=TisL549UBeu1dmZh5ffuSNWyxVfvUR6ZkqAOfi9HVF6CjtqVZIg1VLUTsbl75bJbUk liNkUVSz6bwWMNHUP+ex3pd0jaDfffgMfvn5BGOiIh1tWo4jeHeRdb13oC+8LVYPyqJh BaFRJVLCjxfw9MmOg/Yo2obdbSUjyjsVesg46pj3Bf4cWOrio6U9r9jL8lIPSzg/2cqP v+THeHG5aYWOO5eakyc+f/H8C+8dp0/7ASuuB4qusfIYqqr0NWPm1wDBCizfXDv2Y9f9 0N+oaTr2DBk6wR7BccMukAZMNgyLfgiL/H/SoMfuJAYpYP0lEHdtjbaYwupoXD4Rq7mB VkyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/Idc6qXTZ6hlXWxoD4Eih/KCjk8gd67wFMMcIbrtCxk=; b=Vz4hfwjRG3XJUJDFGd49ggIk8xyZckIkuAf5wsxbnJHli7SiBclTD7gziaKy0mNpXC VfY/bAVip0GEbr/qPFI0KVAARQKJcpic9MoDcfhXjYbb+CDxUAcdjF3E0jy8AfblRL3d fxt1myKJWW2ay6d1Xe+YSZjDyMEy4Hcjfxz3MNB8h958hgzI1Sd5uq7hV4ac8BGZSoaC iNjZ+J39WyB2S7MHjvLGk4uSlTfq8GecuyiFMcbWsuuEGpjBWfsuEdVKljFI2IL9lC8J PM95AgvryLkNaNcZCwsVcKeVbFUmVQdVbzSNYKusHyIUrZfabM/pPJX1O3cQZYhBUXl+ EBDg== X-Gm-Message-State: AFqh2kpQVsMqm+gbJZMsFnMBow9y89GZdsI4FtR2ujtDumE3s0oV9ifk vM2Z6DMG3YAtZJMzG7wQm7K3q7ha/CQi+Em59n0= X-Google-Smtp-Source: AMrXdXtarFmFTkNSLa48UNcotxbyw7LaXE03dE234zv9Qn+afIbyaefzvGnELJx2BNCxGI4HD6GrwEPIcnuYJ39366U= X-Received: by 2002:a05:6870:d99a:b0:143:7889:c525 with SMTP id gn26-20020a056870d99a00b001437889c525mr4992248oab.171.1673716968904; Sat, 14 Jan 2023 09:22:48 -0800 (PST) MIME-Version: 1.0 References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 14 Jan 2023 17:22:38 +0000 Message-ID: Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists To: Evgeni Kolev Content-Type: multipart/alternative; boundary="00000000000062dc5305f23c9955" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60557 Cc: Eli Zaretskii , 60557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000062dc5305f23c9955 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jan 14, 2023 at 6:03 AM Evgeni Kolev wrote: > > Hi Jo=C3=A3o, thank you for the detailed reply. > > Could you confirm I correctly understand proposal 2.1)? Example interactions: > > - M-x eglot RET ;; eglot guesses correctly the CONTACT > - live connection exists? > - no - new connection > - yes - disconnect + new connection Correct. > - M-x eglot /some/path RET ;; eglot can't guess so prompts the user > - live connection exists? > - no - new connection > - yes - disconnect + new connection Correct, according to 2.1. > If I understand correctly, 2.1) always disconnects + reconnects. Yes, that is correct. > Regarding 2.2), I don't fully understand it - could you clarify how > 2.2) is different from the _user's_ perspective? In 2.2, the user is *first* prompted yes/no to make a new connection. Only then is the user potentially asked to enter new contact information. In 2.1, this order is reversed. If the user answers "no", the order in 2.1 does not make much sense because the work that the user has put in to enter a new contact is mostly wasted. This is why 2.2 is preferrable, even if its implementation is probably slightly more complicated. > I'm also thinking about option 3) making M-x eglot able to detect a > change in CONTACT: > > - M-x eglot RET > - live connection exists? > - no - new connection > - yes - new CONTACT provided? > - no - reconnect to old CONTACT > - yes - disconnect + new connection to new CONTACT I think this is too complicated. Jo=C3=A3o --00000000000062dc5305f23c9955 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Jan 14, 2023 at 6:03 AM Evgeni Kolev <evgeni.d.kolev@gmail.com> wrote= :
>
> Hi Jo=C3=A3o, thank you for the detailed reply.
>> Could you confirm I correctly understand proposal 2.1)? Example inte= ractions:
>
> - M-x eglot RET ;; eglot guesses correctly the CO= NTACT
> - live connection exists?
> =C2=A0 =C2=A0 - no - new co= nnection
> =C2=A0 =C2=A0 - yes - disconnect + new connection

=
Correct.

> - M-x eglot /some/path RET ;; eglot can'= ;t guess so prompts the user
> - live connection exists?
> =C2= =A0 =C2=A0 - no - new connection
> =C2=A0 =C2=A0 - yes - disconnect += new connection

Correct, according to 2.1.=C2=A0

> If I understand correctly, 2.1) always disconnects + reco= nnects.

Yes, that is correct.

> Regardin= g 2.2), I don't fully understand it - could you clarify how
> 2.2= ) is different from the _user's_ perspective?

= In 2.2, the user is *first* prompted yes/no to make a new connection.
=
Only then is the user potentially asked to enter new contact
information.=C2=A0 In 2.1, this order is reversed.

If the user answers "no", the order in 2.1 does not make much
=C2=A0sense because the work that the user has put in to enter a n= ew=C2=A0
contact is mostly wasted.=C2=A0 This is why 2.2 is prefe= rrable, even if=C2=A0
its implementation is probably slightly mor= e complicated.

> I'm also thinking about option 3) mak= ing M-x eglot able to detect a
> change in CONTACT:
>
> -= M-x eglot RET
> - live connection exists?
> =C2=A0 =C2=A0 - no= - new connection
> =C2=A0 =C2=A0 - yes - new CONTACT provided?
&g= t; =C2=A0 =C2=A0 =C2=A0 =C2=A0 - no - reconnect to old CONTACT
> =C2= =A0 =C2=A0 =C2=A0 =C2=A0 - yes - disconnect + new connection to new CONTACT=

I think this is too complicated.

Jo=C3=A3o
--00000000000062dc5305f23c9955-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 06:51:46 2023 Received: (at 60557) by debbugs.gnu.org; 16 Jan 2023 11:51:46 +0000 Received: from localhost ([127.0.0.1]:60620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHO1i-0005j2-JK for submit@debbugs.gnu.org; Mon, 16 Jan 2023 06:51:46 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:44689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHO1h-0005ip-1r for 60557@debbugs.gnu.org; Mon, 16 Jan 2023 06:51:45 -0500 Received: by mail-wm1-f42.google.com with SMTP id l41-20020a05600c1d2900b003daf986faaeso2051447wms.3 for <60557@debbugs.gnu.org>; Mon, 16 Jan 2023 03:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zHRUcCMJZaJRbJR++ssck4YZZgE59Io0lf4AlK20TEM=; b=eTMEN/FNz9B0NQfYGWUgXkY/ICv1qOHQ6P09xcCnnGDyEVmrZ5XMxcCKg8xtpmU64S +4/VnT3RNXulKnoPge/pxJwgH8jjl2it+mJtjUyRZpq7bovgTTzzNXo/nxgmBLsuxOsS bHc/5mlcZGM+3K8BB5k+UEn/2uvPylESgOF8USRmZY48ztJaScu3LYDfKPG3zgH1R5ai Ye/pei6g+L0QRsLbRdNpkShMQaIgkE+RzCQEJrEyr9cemIjwzHMFzYivz3slLtPLjVt3 MCgJcj1KrSe2x3KHnAqU+6+l3YTpuiCDZEPr6KKv/L1YfgXnsO4Ox5M39N/RnBkKdMyB JjUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zHRUcCMJZaJRbJR++ssck4YZZgE59Io0lf4AlK20TEM=; b=hM0ax4hhHK5X7jLMs5NTbYcAWgPLbEdNo1oM5z4LFhnsLnkZnZK90CozbFxV8JbXus l9+hA9IGrsU4Bk2aMIRt5+OurjiXYhJAaOrPijH2PveLGw6MkvmVCvPNNIQSMz4gBmVZ VZZ13UUgkEgt7Kihz3pZxv63atblqSJAOnUVU55m/p7cO2u1BbUNn0NHdPBeSuw/KtYv bj4wSfeEzlE/L6pcTO+ZR9krq9dbsB46ZXp5Nid5d8eLdAX/dVGONEHVdb8d2FfJdMmR BbzVaMHq4vxE3gOGcLUyD56QiFgmXUJIH1OfnzGhc/dtdioAtu6/23QT1qzMOc4ymGFC 4jJA== X-Gm-Message-State: AFqh2kq7ZihzeleOPwIDaOwPxU+pfmVd+D0TiamF7CqR9X8CHjTW8HrZ kMBkzlkBXt2kNWIasr78t2Y2CJdsK24= X-Google-Smtp-Source: AMrXdXulXr4NlBl2FW4GaCmjO3XcLfzAylg54R+NrtBU5yN0SINXB/n2vopUV700iFdXpUNbi2i/2w== X-Received: by 2002:a05:600c:c06:b0:3da:fd1d:98d8 with SMTP id fm6-20020a05600c0c0600b003dafd1d98d8mr1857892wmb.22.1673869898949; Mon, 16 Jan 2023 03:51:38 -0800 (PST) Received: from krug (87-196-72-81.net.novis.pt. [87.196.72.81]) by smtp.gmail.com with ESMTPSA id u13-20020a05600c19cd00b003c6f1732f65sm41380745wmq.38.2023.01.16.03.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 03:51:38 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Evgeni Kolev Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists In-Reply-To: (Evgeni Kolev's message of "Sat, 14 Jan 2023 08:02:59 +0200") References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> Date: Mon, 16 Jan 2023 11:53:14 +0000 Message-ID: <87y1q24rx1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60557 Cc: Eli Zaretskii , 60557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Evgeni Kolev writes: > Hi Jo=C3=A3o, thank you for the detailed reply. > > Regarding 2.2), I don't fully understand it - could you clarify how > 2.2) is different from the _user's_ perspective? Hi Evgeni, Because I think you've found an important flaw in Eglot, and in the interest of speeding up this discussion I've just pushed a change to progmodes/eglot.el that effects the alternative 2.2 I describe earlier. I hope you have a chance to test it. If you agree with the new behaviour, this ticket can be closed. [ Eli, I pushed this change to emacs-29 as this in effect a bugfix and Eglot is a new package anyway. Let me know if you'd rather I push this to master instead (it doesn't make much of a difference in practice since eglot.el is a GNU ELPA packge) ] Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 09:08:16 2023 Received: (at 60557) by debbugs.gnu.org; 16 Jan 2023 14:08:16 +0000 Received: from localhost ([127.0.0.1]:60950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQ9o-0005kW-C3 for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:08:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQ9m-0005kI-HE for 60557@debbugs.gnu.org; Mon, 16 Jan 2023 09:08:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQ9h-0001al-3I; Mon, 16 Jan 2023 09:08:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=95iVlRifYLgpkOEdZ0/ksUtKm/wOPiXvIlG2gAY0XFI=; b=sW5TmhJbSlOyhJ0BfCtm bgRl66N5p9D+whHsazETEGs0cx4chcpk8YifvgIqVydxYCkVm/iUu6VgaCGhQ5bLPt1oOGp2SIdta gGR5I7tDOEKHbNYzZ2JsNnO18aDuGJGMaCCs/HneeOoRaray+RCf3veddQxyqeO9ERjkXcEocv7iU nFGqpT6e+g3hrVVfPTiemSqxxQaEJeqxeh7+NL5smbF2CB2KRxZ1xh/+aGCUxz+C0fI9E6tReu1Xz 8Gj99Ha1X9JW+Uvf+j6cck5yk/qyv6Eoo5lTl3qjVBmrWnqt2hTaAtqsf3daBpDfrZYWLuhX1w1dK JsUoPwNYwbWuDQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQ9g-0000cM-6F; Mon, 16 Jan 2023 09:08:08 -0500 Date: Mon, 16 Jan 2023 16:08:15 +0200 Message-Id: <83r0vu4lo0.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: <87y1q24rx1.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Mon, 16 Jan 2023 11:53:14 +0000) Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> <87y1q24rx1.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60557 Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Cc: Eli Zaretskii , 60557@debbugs.gnu.org > Date: Mon, 16 Jan 2023 11:53:14 +0000 > > [ Eli, I pushed this change to emacs-29 as this in effect a bugfix and > Eglot is a new package anyway. Let me know if you'd rather I push this > to master instead (it doesn't make much of a difference in practice > since eglot.el is a GNU ELPA packge) ] The release branch is OK for this kind of changes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 09:15:29 2023 Received: (at 60557) by debbugs.gnu.org; 16 Jan 2023 14:15:29 +0000 Received: from localhost ([127.0.0.1]:60959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQGm-0005x5-Pp for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:15:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQGl-0005wq-Il for 60557@debbugs.gnu.org; Mon, 16 Jan 2023 09:15:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQGf-0002wt-UR; Mon, 16 Jan 2023 09:15:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=0lNfRapkbk5UNKN32o/NHOEPXO42aneyAukWjwl6nzU=; b=Iul0J8RM/7lqv4/M8iCK wcTKWm0cJ8DOlMK4CS1jmYdbGg6u+9Oynwod8BNj0Rs5m4LdvpswGwHmRyxadZhC7yZtSqG/9ykDY k3BEESIsOggyTn0bbWnpfF45xvvUcDXdm8fNz/zsxtsKinoaH6YeDU/doEUQFUV1z3l6erBnStiBq gEo7VGADK5aZMNMb+9i2SKIL+n0yDAhzP3m7kBEjW9GkHvOMpwJBmuhvT684ZNEsFpVvuWACU21s6 N1ZWb2xw2pBQRyTV0kcHUqFh6yKYk8zdIgm+gjdDBat1swTsmww6hjbPRlWHwnyQQegrdAycF7wR+ BGXR/vAGqyxKSg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQGe-0001ky-VG; Mon, 16 Jan 2023 09:15:21 -0500 Date: Mon, 16 Jan 2023 16:15:28 +0200 Message-Id: <83pmbe4lbz.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: <87y1q24rx1.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Mon, 16 Jan 2023 11:53:14 +0000) Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> <87y1q24rx1.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60557 Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Cc: Eli Zaretskii , 60557@debbugs.gnu.org > Date: Mon, 16 Jan 2023 11:53:14 +0000 > > [ Eli, I pushed this change to emacs-29 as this in effect a bugfix and > Eglot is a new package anyway. Let me know if you'd rather I push this > to master instead (it doesn't make much of a difference in practice > since eglot.el is a GNU ELPA packge) ] The release branch is OK for this kind of changes, thanks. However, note that this change now causes In eglot: progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive' because the INTERACTIVE argument is now unused. Should it be renamed to _interactive? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 09:41:08 2023 Received: (at 60557) by debbugs.gnu.org; 16 Jan 2023 14:41:08 +0000 Received: from localhost ([127.0.0.1]:32780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQfb-0006fj-Ur for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:41:08 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:36545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQfY-0006eo-SU for 60557@debbugs.gnu.org; Mon, 16 Jan 2023 09:41:06 -0500 Received: by mail-ot1-f43.google.com with SMTP id x25-20020a056830115900b00670932eff32so16206258otq.3 for <60557@debbugs.gnu.org>; Mon, 16 Jan 2023 06:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XNWWB+9W7W+q3PIdlm2P2NQeSAsfvSMjbKeTjEaGXEM=; b=bt9MemOkQy3xQaDmxjvS23J0b/TaA2mU08L2gZhAgyEDQsAUQqPComxc1XISjRSyrI XP3Ri2td53RkYM0/+G0NIoHN+fJv5dLvUIskxchYTJza2dF7mjEG6jQRiG9rn6Ib2nJl LSOaR8wvvsYjNvO5KHQx/IhmD0xmUL16S+PbhshUtE+U6OUvhP+TLvf1hBZAcMZQ7xwg dmFSWnsnZnx5V+3Khs739X3bEC23FskhnXfMoA8J21hcU3ZMArVdAJUSqn89OYuj07Nf ckbCkmZV+xLQ1smWdWHh19xx/TD3heDZBFOaaVWeLNOxyJMhU/bB2DYmj2WJhpkMdeYF CBfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XNWWB+9W7W+q3PIdlm2P2NQeSAsfvSMjbKeTjEaGXEM=; b=yzT1b71HmKuZSv/zIUl6TkHgFVExxkhSJuW8ExvEQ1b65kkK0uj4hRuXR7Sm2hd0w3 XyyJk984qz/OpUFJVT21TVkPpZyxxOFaZSJ6/YCz+hfQZ3ohGPTjWAktAGKbQUvxNGgb TxAX71S7hfVBrfV1FuqN6gh5p2A60ucE6AMQrP4v5+vJpdP3lNNjPJ7lu9SHt//I3cOi INZVpqwgnvcW4H3sFI3eKP65tZnrK99zDrZoAWeMZBSM+yS9Vnrq19QLk3I7U9PrN5X4 P1/8gMETvAECZOUO7aFNGzU6NTdQDaA/BbsxxpvJKZ64wUQKnO3gfqaJzf0zkZdJKfkY Yq3A== X-Gm-Message-State: AFqh2kpCxOUqJFx94uBwmssrPw+lU0msktUxujN+9Re25BJ2cwxfXecH 2gqnz9WuEzKkJHFkCjPLrpFzHhp9iKQl91i/n/o= X-Google-Smtp-Source: AMrXdXu0S/bpjkVKRV7BYlbqUyGpZhf6fFrRqzWoGQf/hVMrJNhd90IKUrwWmBukAikuR4NehvIBO+WMLIeWWiQDnYY= X-Received: by 2002:a05:6830:6481:b0:684:9f72:3fe3 with SMTP id ck1-20020a056830648100b006849f723fe3mr1453724otb.201.1673880059276; Mon, 16 Jan 2023 06:40:59 -0800 (PST) MIME-Version: 1.0 References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> <87y1q24rx1.fsf@gmail.com> <83pmbe4lbz.fsf@gnu.org> In-Reply-To: <83pmbe4lbz.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 16 Jan 2023 14:42:25 +0000 Message-ID: Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000054704b05f26292d6" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60557 Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000054704b05f26292d6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 16, 2023 at 2:15 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Cc: Eli Zaretskii , 60557@debbugs.gnu.org > > Date: Mon, 16 Jan 2023 11:53:14 +0000 > > > > [ Eli, I pushed this change to emacs-29 as this in effect a bugfix and > > Eglot is a new package anyway. Let me know if you'd rather I push this > > to master instead (it doesn't make much of a difference in practice > > since eglot.el is a GNU ELPA packge) ] > > The release branch is OK for this kind of changes, thanks. > > However, note that this change now causes > > In eglot: > progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive' > > because the INTERACTIVE argument is now unused. You're right, I missed that. Sorry. > Should it be renamed to _interactive? Yes, that would be fine. As would removing the argument entirely. M-x eglot is _not_ meant to be called from Lisp at at all, but some time ago I found at least one user on emacs-devel was doing so. So removing it may break some code (that is probably already broken anyway, but still...). Jo=C3=A3o --00000000000054704b05f26292d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Jan 16, 2023 at 2:15 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> &g= t; From: Jo=C3=A3o T=C3=A1vora <= joaotavora@gmail.com>
> > Cc: Eli Zaretskii <eliz@gnu.org>, =C2=A060557@debbugs.gnu.org
> > Date: Mon, 16 Jan 202= 3 11:53:14 +0000
> >
> > [ Eli, I pushed this change to e= macs-29 as this in effect a bugfix and
> > Eglot is a new package = anyway.=C2=A0 Let me know if you'd rather I push this
> > to m= aster instead (it doesn't make much of a difference in practice
>= > since eglot.el is a GNU ELPA packge) ]
>
> The release br= anch is OK for this kind of changes, thanks.
>
> However, note = that this change now causes
>
> =C2=A0 In eglot:
> =C2=A0= progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive&= #39;
>
> because the INTERACTIVE argument is now unused.
You're right, I missed that. Sorry.
=C2=A0
> Shou= ld it be renamed to _interactive?

Yes, that would be fine.=C2=A0 As = would removing=C2=A0 the argument entirely.

M= -x eglot is _not_ meant=C2=A0 to be called from Lisp at at all, but some ti= me
ago I found at least one user on emacs-devel was doing so= .=C2=A0 So removing
it may break some code (that is probably= already broken anyway, but still...).

Jo=C3=A3o
--00000000000054704b05f26292d6-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 09:54:14 2023 Received: (at 60557-done) by debbugs.gnu.org; 16 Jan 2023 14:54:14 +0000 Received: from localhost ([127.0.0.1]:32824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQsH-0000yx-TB for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:54:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQsG-0000yb-9h for 60557-done@debbugs.gnu.org; Mon, 16 Jan 2023 09:54:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQsA-0001yU-W2; Mon, 16 Jan 2023 09:54:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hpw3O/E+chDxCVh7sFr5NYwyh8I3+j3YwZyAl+24SOc=; b=EOn4GYut+VEE4j8Q1MA2 A4K5yHvwtwbFB4HA5MA5VY51iTAvq2R7TH2l0JXtsfjXV43hk9o6gGPeH2Ja/cQXlvMWjrpbkE//O ei/Z7mc2ibAwH+7Fq+scNFue3/0mrVsrTAIVKdXJpk3tEvJ6ulXFwrvJu0zcDv3Sn7rWEboptrcKI ISRvBsfNPxj/WE4S3DmfzReot5Ns7Mvr/9oNi/TiOQ1KY8sEzdyFwoQBUw6GPZATpr+PIvtKCSAkb 6JSwBYez5CMnHAkK5LhmuNuw9l/H0iDBUoCekXD0oCXzHdr/ooYL1zSBm7u/5ZHBNfOjtsYclOWwC buKOrWzza7z41A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQsA-0001fD-8X; Mon, 16 Jan 2023 09:54:06 -0500 Date: Mon, 16 Jan 2023 16:54:14 +0200 Message-Id: <83h6wq4jjd.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Mon, 16 Jan 2023 14:42:25 +0000) Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> <87y1q24rx1.fsf@gmail.com> <83pmbe4lbz.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60557-done Cc: evgeni.d.kolev@gmail.com, 60557-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Mon, 16 Jan 2023 14:42:25 +0000 > Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org > > > In eglot: > > progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive' > > > > because the INTERACTIVE argument is now unused. > > You're right, I missed that. Sorry. > > > Should it be renamed to _interactive? > > Yes, that would be fine. As would removing the argument entirely. > > M-x eglot is _not_ meant to be called from Lisp at at all, but some time > ago I found at least one user on emacs-devel was doing so. So removing > it may break some code (that is probably already broken anyway, but still...). I renamed it and updated the doc string to that effect. Closing. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 00:59:02 2023 Received: (at 60557-done) by debbugs.gnu.org; 18 Jan 2023 05:59:02 +0000 Received: from localhost ([127.0.0.1]:38862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI1TR-0005w9-VZ for submit@debbugs.gnu.org; Wed, 18 Jan 2023 00:59:02 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:36646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI1TN-0005vY-Oa for 60557-done@debbugs.gnu.org; Wed, 18 Jan 2023 00:59:01 -0500 Received: by mail-qk1-f175.google.com with SMTP id pj1so17362015qkn.3 for <60557-done@debbugs.gnu.org>; Tue, 17 Jan 2023 21:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=95AzTdaFykTaFikWPOJbRp0o+fwPPcuyzRhLqrcSCs4=; b=XSFJBCy8yBAK8+o88AzZolQYmfMa4jM0sWVqmSPI/cCjS3ZVdoBoWADfRanMrM6JHZ aQ71ToI9UhSRIoQ806xZ4u12pSSh/EWz4gQ/Z1IN+GXt9Nni4LJ6v/Ck6Z7KwozKVPy6 agkyYhKDvQPR3ZJHdy2qOgRVi2faJ5HAi11kWRHw7snMtIoopXnqrv79HLrFjiqgmUmU GBEP4ysWwLGvzrGxdpCRWeQ0K4svAnrr/B7LPkkhAs+XdCBMYRUdwXst4jPB2dr8bE/W Koxlwna5k626iqmo9qhxttqzJtPuPE7EurG3Nwel3xnGYR35gE7gXxi/Bp2FvlNiOn0/ S9uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=95AzTdaFykTaFikWPOJbRp0o+fwPPcuyzRhLqrcSCs4=; b=kJKaGxYngaUxVVSjOyIbhEAW5nGkLVlxmBM3Wicgx8qXazZTkYmtR8WENhx6EUgcvA CZ3qszdxD1uB3bciqaMGacFopns47UPIy5awcKelU9Snk6lFoLHTIcqHwBXUegWC53+R PRZqqIGzvsnLNTpSqpmoWRJ2q0elPlGn42wIh2VTtah5BQRwagOP1QQDMDrXuKhcDeQ3 +r4NzTgcOzJBX/DSbenaM2myII47T4cmsp+TJHLmhUDzoBLG2Jdane/O+/ZpKMAqf65B hxPSBeRPkdEFlRGPgFjLmfSmpBTiUZTo1U0EgY+3a+yMaAj2qSL4rMTSgU0ulUINYoFw RByQ== X-Gm-Message-State: AFqh2kprUa3E1xaRdv/tmJOPs1b3JyHVyuJAP4ksZhFUgPZXZJGAkryG 2Rt02ddOaZpGZZAk6hAP/m6z65de/O7qyI+drIY= X-Google-Smtp-Source: AMrXdXveRgFC2ZR9q1eboA2BU3fJ4accsykgpJnAtB2FbkH3cVVMKaxwmwg6fatjEl914aqF/2wzQDIY7Kyc8lftUrQ= X-Received: by 2002:a37:8287:0:b0:706:4643:b6fb with SMTP id e129-20020a378287000000b007064643b6fbmr158152qkd.135.1674021532035; Tue, 17 Jan 2023 21:58:52 -0800 (PST) MIME-Version: 1.0 References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> <87y1q24rx1.fsf@gmail.com> <83pmbe4lbz.fsf@gnu.org> <83h6wq4jjd.fsf@gnu.org> In-Reply-To: <83h6wq4jjd.fsf@gnu.org> From: Evgeni Kolev Date: Wed, 18 Jan 2023 07:58:26 +0200 Message-ID: Subject: Re: bug#60557: [PATCH] Fix eglot prompt when connection already exists To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60557-done Cc: Eli Zaretskii , 60557-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jo=C3=A3o, thank you for addressing this quickly! Sorry for the delay on my side - I've been dealing with the flu the last few days. On Mon, Jan 16, 2023 at 4:54 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Mon, 16 Jan 2023 14:42:25 +0000 > > Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org > > > > > In eglot: > > > progmodes/eglot.el:1078:44: Warning: Unused lexical argument `inter= active' > > > > > > because the INTERACTIVE argument is now unused. > > > > You're right, I missed that. Sorry. > > > > > Should it be renamed to _interactive? > > > > Yes, that would be fine. As would removing the argument entirely. > > > > M-x eglot is _not_ meant to be called from Lisp at at all, but some ti= me > > ago I found at least one user on emacs-devel was doing so. So removing > > it may break some code (that is probably already broken anyway, but sti= ll...). > > I renamed it and updated the doc string to that effect. > > Closing. From unknown Fri Jun 20 07:13:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 15 Feb 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator