GNU bug report logs - #60536
[PATCH] depend: trim spurious leading tab

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60536 in the body.
You can then email your comments to 60536 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] depend: trim spurious leading tab
Date: Tue,  3 Jan 2023 21:40:13 -0500

These vars are replaced with a list of remove commands that are joined
with a \n and each line always has a leading \t inserted.  That means
the literal tab here before the var leads to 2 tabs included in the
output.  While not functionally a problem, it can be a bit confusing
when reading the output as it implies something is amiss.  Trimming
the tab also aligns with the other .am files which don't include it.

* lib/am/depend.am: Delete tab before %DISTRMS%.
---
 lib/am/depend.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/am/depend.am b/lib/am/depend.am
index ecea1fcaa9bc..da8cc6c80f17 100644
--- a/lib/am/depend.am
+++ b/lib/am/depend.am
@@ -31,7 +31,7 @@ am--depfiles: $(am__depfiles_remade)
 ## recursive).
 if %?DISTRMS%
 distclean:
-	%DISTRMS%
+%DISTRMS%
 maintainer-clean:
-	%DISTRMS%
+%DISTRMS%
 endif
-- 
2.39.0

Message #8 received at 60536 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60536 <at> debbugs.gnu.org
Subject: Re: [bug#60536] [PATCH] depend: trim spurious leading tab
Date: Wed, 4 Jan 2023 16:54:32 -0700

     distclean:
    -	%DISTRMS%
    +%DISTRMS%
     maintainer-clean:
    -	%DISTRMS%
    +%DISTRMS%

Sure, looks good. Please commit. Thanks Mike. -k

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.