GNU bug report logs - #60529
[PATCH] Fontify C++ function definitions in c++-ts-mode

Previous Next

Full log

Message #10 received at 60529-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: 60529-done <at> debbugs.gnu.org
Subject: Re: bug#60529: [PATCH] Fontify C++ function definitions in c++-ts-mode
Date: Tue, 3 Jan 2023 23:50:08 -0700

Daniel Martín <mardani29 <at> yahoo.es> writes:

> Tags: patch
>
>
> Given the following valid C++ code:
>
> void Foo::bar() {
>
> }
>
> c++-ts-mode should fontify bar with the font-lock-function-name-face
> face.  The attached patch adds support for fontifying function
> declarations whose identifier is "buried" inside qualified_identifier
> nodes.
>
> I've checked that the patch also fontifies bar in
>
> void Foo::Bar::bar() {
>
> }
>
> but fontifies bar with font-lock-variable-name-face face in the
> following cases:
>
> Foo::Bar::Bar2 bar;
> Foo::Bar bar;
>
> I don't check for C++ mode in the code, as I think the impact of this
> new check should be negligible for C code, but I'm open to feedback.
>
> Thanks.

Makes sense. I applied the patch. Thanks!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.