From unknown Tue Jun 17 22:27:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jan 2023 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 60526@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167276968819842 (code B ref -1); Tue, 03 Jan 2023 18:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2023 18:14:48 +0000 Received: from localhost ([127.0.0.1]:46687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCloG-00059x-GX for submit@debbugs.gnu.org; Tue, 03 Jan 2023 13:14:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:50424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCloE-00059p-CF for submit@debbugs.gnu.org; Tue, 03 Jan 2023 13:14:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCloE-0007RR-4y for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 13:14:46 -0500 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCloC-0004Qz-2m for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 13:14:45 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 797E81C000A for ; Tue, 3 Jan 2023 18:14:39 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET Date: Tue, 03 Jan 2023 20:12:38 +0200 Message-ID: <86fscrwkq1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain It looks wrong to require from users to add mappings for both `js-mode' and its alias `javascript-mode' to `major-mode-remap-alist': (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) (add-to-list 'major-mode-remap-alist '(javascript-mode . js-ts-mode)) Either `major-mode-remap-alist' could support aliases, or simpler would be just to replace the alias in `auto-mode-alist': --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=javascript-ts-mode.patch diff --git a/lisp/files.el b/lisp/files.el index c45c3d40a5d..2acc1d1df4a 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -2952,9 +2952,9 @@ auto-mode-alist ("\\.dbk\\'" . xml-mode) ("\\.dtd\\'" . sgml-mode) ("\\.ds\\(ss\\)?l\\'" . dsssl-mode) - ("\\.js[mx]?\\'" . javascript-mode) + ("\\.js[mx]?\\'" . js-mode) ;; https://en.wikipedia.org/wiki/.har - ("\\.har\\'" . javascript-mode) + ("\\.har\\'" . js-mode) ("\\.json\\'" . js-json-mode) ("\\.[ds]?va?h?\\'" . verilog-mode) ("\\.by\\'" . bovine-grammar-mode) --=-=-=-- From unknown Tue Jun 17 22:27:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jan 2023 20:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 60526@debbugs.gnu.org Received: via spool by 60526-submit@debbugs.gnu.org id=B60526.167277726232734 (code B ref 60526); Tue, 03 Jan 2023 20:22:01 +0000 Received: (at 60526) by debbugs.gnu.org; 3 Jan 2023 20:21:02 +0000 Received: from localhost ([127.0.0.1]:46759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCnmQ-0008Vu-Aa for submit@debbugs.gnu.org; Tue, 03 Jan 2023 15:21:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCnmO-0008V3-65 for 60526@debbugs.gnu.org; Tue, 03 Jan 2023 15:21:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCnmI-0001hZ-Jo; Tue, 03 Jan 2023 15:20:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=0WCs4UKR/UIO/cphKM9cl9gRwunP9tc16qsUuO906t0=; b=KvN/OaAF1PjA0fJgKtbf +3W8ab2rjo0jIQX6I7GT+8UyElV/CWkdOKYeV4OM7UphhFswGVQ3Pt+PxjLGnmZXqh3PSPGiTW4A5 MeHoPqEc64Y7jBEhpiIF7nmdaFv1T02OZ9hwANEFUw6vpgU9heJFrmWMSQvPJnXGwxJiOdlrvVvTp WQ8NBOU/L/iZa9tXQaL5oQ/2o5IhVOVzX/EJz40fMPxcFXmqeeDCWnZmK9D9MDgtijrU+SnXyr0Vl CLAfcIbDuR2RX1zpU/fzbSXB0Zo0+j2ceSmA903aVAblF51RTIzsnDobA01UTviZ5fXGYSDUXEULX LHDaldjXcKD7QA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCnmI-00068J-3J; Tue, 03 Jan 2023 15:20:54 -0500 Date: Tue, 03 Jan 2023 22:21:05 +0200 Message-Id: <83sfgrz7wu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86fscrwkq1.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 03 Jan 2023 20:12:38 +0200) References: <86fscrwkq1.fsf@mail.linkov.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Tue, 03 Jan 2023 20:12:38 +0200 > > > It looks wrong to require from users to add mappings for both `js-mode' > and its alias `javascript-mode' to `major-mode-remap-alist': > > (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) > (add-to-list 'major-mode-remap-alist '(javascript-mode . js-ts-mode)) > > Either `major-mode-remap-alist' could support aliases, or simpler > would be just to replace the alias in `auto-mode-alist': > > diff --git a/lisp/files.el b/lisp/files.el > index c45c3d40a5d..2acc1d1df4a 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -2952,9 +2952,9 @@ auto-mode-alist > ("\\.dbk\\'" . xml-mode) > ("\\.dtd\\'" . sgml-mode) > ("\\.ds\\(ss\\)?l\\'" . dsssl-mode) > - ("\\.js[mx]?\\'" . javascript-mode) > + ("\\.js[mx]?\\'" . js-mode) > ;; https://en.wikipedia.org/wiki/.har > - ("\\.har\\'" . javascript-mode) > + ("\\.har\\'" . js-mode) > ("\\.json\\'" . js-json-mode) > ("\\.[ds]?va?h?\\'" . verilog-mode) > ("\\.by\\'" . bovine-grammar-mode) This is basically a no-brainer, but we had javascript-mode there for quite some time, and it's too late to change that for Emacs 29. Please install on master. From unknown Tue Jun 17 22:27:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 06:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 60526@debbugs.gnu.org, Stefan Monnier , Juri Linkov Received: via spool by 60526-submit@debbugs.gnu.org id=B60526.167281446011066 (code B ref 60526); Wed, 04 Jan 2023 06:41:01 +0000 Received: (at 60526) by debbugs.gnu.org; 4 Jan 2023 06:41:00 +0000 Received: from localhost ([127.0.0.1]:47381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCxSN-0002sP-Lk for submit@debbugs.gnu.org; Wed, 04 Jan 2023 01:40:59 -0500 Received: from mail-pj1-f51.google.com ([209.85.216.51]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCxSJ-0002s8-Bs for 60526@debbugs.gnu.org; Wed, 04 Jan 2023 01:40:57 -0500 Received: by mail-pj1-f51.google.com with SMTP id z9-20020a17090a468900b00226b6e7aeeaso555767pjf.1 for <60526@debbugs.gnu.org>; Tue, 03 Jan 2023 22:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tGrliAjc1KC/MkeEKuomh/mvEsC4CK96oQn/MqWSx74=; b=HVjnn0xT5tMHRvDrhTUF7LHovSjtI6lWzAp9eS2sjwdp+6ocGUTYhrrb30W/NZVYle x5hniRxd+bvW7yhQazIFuvqifAhQdWvai2XqfnTEGYHBSPw+sCi99ZrqTDFpaw7ugDbB U1tDRLU4y/HMWJ2wLMRTpL8MFcKj7RY9yiaUdMolan9UnqNCmU4QefYobW4Z6zwSy2Nm nl+xd+C22wXAKb3Eez6/yV1S+EJC72KurKOLE39p8w/LWCioBGdzaAwp3AGVPM1gVGcU KXpuMzKA+ItB2UyNpefrq3iUGwdBUB/A9geTpEmAtwe9/LjK4qyaX/z2HaXobTi2sErY lfHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tGrliAjc1KC/MkeEKuomh/mvEsC4CK96oQn/MqWSx74=; b=I5uDufCXl/f/Qgj4W38C0i948Ht+t5EsI5jB/wQL1ly48ZdXlNPprRYP/QevTfqlV+ Vbmkw0L8OinArO858S65EzFqUJ5hXojvbt1NJT4+5ZuU2O0znJuCb+xRP7d0aQdPZTFc vO8z+MCvUd5SdRpsqrBkmmKX5Axz6TFL7j2Xdx5PjqQQLGPmhPlEc/H8OakfBgV+gFrt iDuQ687dx0WSOxbw3QhQx7BbPO17GwShPvCWSQ6nuK7KkOvYeodb17I6yyY6A2d+6aZM 8u7bbyltozYB/BVbGF/FaOvn5fz4EKcIcIFCLtNlW34ee6CE/CwzOPjn8TVcPBrsWsFa uP2w== X-Gm-Message-State: AFqh2kqYcEMITa+zLY8hIQaRGTGT+tt5dPBv2TE1Sh6lLOCkSVg8bUcg Q65edtjwm63vSj8Iv4ZstGM= X-Google-Smtp-Source: AMrXdXtyv/FMsdY1bNZQU1DqM1Ds5ipwmjsdw+YTJNu6KE5xIeAR0gWN4jOO72H5KGj4UPfRlBPvtw== X-Received: by 2002:a17:902:aa96:b0:18e:8223:6447 with SMTP id d22-20020a170902aa9600b0018e82236447mr46916384plr.22.1672814449232; Tue, 03 Jan 2023 22:40:49 -0800 (PST) Received: from smtpclient.apple (ip68-3-33-122.ph.ph.cox.net. [68.3.33.122]) by smtp.gmail.com with ESMTPSA id n15-20020a170902e54f00b00189348ab156sm2059790plf.283.2023.01.03.22.40.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2023 22:40:48 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) From: Yuan Fu In-Reply-To: <83sfgrz7wu.fsf@gnu.org> Date: Tue, 3 Jan 2023 23:40:47 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <3E20C72B-F725-4EDC-A2E2-F0BEA7B563B6@gmail.com> References: <86fscrwkq1.fsf@mail.linkov.net> <83sfgrz7wu.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 3, 2023, at 1:21 PM, Eli Zaretskii wrote: >=20 >> From: Juri Linkov >> Date: Tue, 03 Jan 2023 20:12:38 +0200 >>=20 >>=20 >> It looks wrong to require from users to add mappings for both = `js-mode' >> and its alias `javascript-mode' to `major-mode-remap-alist': >>=20 >> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) >> (add-to-list 'major-mode-remap-alist '(javascript-mode . = js-ts-mode)) >>=20 >> Either `major-mode-remap-alist' could support aliases, or simpler >> would be just to replace the alias in `auto-mode-alist': >>=20 >> diff --git a/lisp/files.el b/lisp/files.el >> index c45c3d40a5d..2acc1d1df4a 100644 >> --- a/lisp/files.el >> +++ b/lisp/files.el >> @@ -2952,9 +2952,9 @@ auto-mode-alist >> ("\\.dbk\\'" . xml-mode) >> ("\\.dtd\\'" . sgml-mode) >> ("\\.ds\\(ss\\)?l\\'" . dsssl-mode) >> - ("\\.js[mx]?\\'" . javascript-mode) >> + ("\\.js[mx]?\\'" . js-mode) >> ;; https://en.wikipedia.org/wiki/.har >> - ("\\.har\\'" . javascript-mode) >> + ("\\.har\\'" . js-mode) >> ("\\.json\\'" . js-json-mode) >> ("\\.[ds]?va?h?\\'" . verilog-mode) >> ("\\.by\\'" . bovine-grammar-mode) >=20 > This is basically a no-brainer, but we had javascript-mode there for > quite some time, and it's too late to change that for Emacs 29. > Please install on master. I thought auto-mode-alist should use the canonical name and = major-mode-remap-alist maps the canonical name to the actual mode. Why = do we need=20 >> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) if auto-mode-alist uses javascript-mode? Yuan= From unknown Tue Jun 17 22:27:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 07:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: 60526@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier Received: via spool by 60526-submit@debbugs.gnu.org id=B60526.167281857327660 (code B ref 60526); Wed, 04 Jan 2023 07:50:03 +0000 Received: (at 60526) by debbugs.gnu.org; 4 Jan 2023 07:49:33 +0000 Received: from localhost ([127.0.0.1]:47558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCyWi-0007C3-IG for submit@debbugs.gnu.org; Wed, 04 Jan 2023 02:49:32 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:44373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCyWg-0007Bd-Dg for 60526@debbugs.gnu.org; Wed, 04 Jan 2023 02:49:30 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id EE2B720009; Wed, 4 Jan 2023 07:49:22 +0000 (UTC) From: Juri Linkov In-Reply-To: <3E20C72B-F725-4EDC-A2E2-F0BEA7B563B6@gmail.com> (Yuan Fu's message of "Tue, 3 Jan 2023 23:40:47 -0700") Organization: LINKOV.NET References: <86fscrwkq1.fsf@mail.linkov.net> <83sfgrz7wu.fsf@gnu.org> <3E20C72B-F725-4EDC-A2E2-F0BEA7B563B6@gmail.com> Date: Wed, 04 Jan 2023 09:45:44 +0200 Message-ID: <86a62y4uaf.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> - ("\\.js[mx]?\\'" . javascript-mode) >>> + ("\\.js[mx]?\\'" . js-mode) >>> ;; https://en.wikipedia.org/wiki/.har >>> - ("\\.har\\'" . javascript-mode) >>> + ("\\.har\\'" . js-mode) >>> ("\\.json\\'" . js-json-mode) >>> ("\\.[ds]?va?h?\\'" . verilog-mode) >>> ("\\.by\\'" . bovine-grammar-mode) >> >> This is basically a no-brainer, but we had javascript-mode there for >> quite some time, and it's too late to change that for Emacs 29. >> Please install on master. > > I thought auto-mode-alist should use the canonical name and > major-mode-remap-alist maps the canonical name to the actual mode. But the canonical name is js-mode, because javascript-mode is an alias to js-mode. > Why do we need > >>> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) > > if auto-mode-alist uses javascript-mode? This is needed for the case when users or packages customized auto-mode-alist to use the name js-mode. From unknown Tue Jun 17 22:27:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode References: <86fscrwkq1.fsf@mail.linkov.net> In-Reply-To: <86fscrwkq1.fsf@mail.linkov.net> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 01:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 60526@debbugs.gnu.org, Eli Zaretskii , monnier@iro.umontreal.ca Received: via spool by 60526-submit@debbugs.gnu.org id=B60526.167314198514629 (code B ref 60526); Sun, 08 Jan 2023 01:40:02 +0000 Received: (at 60526) by debbugs.gnu.org; 8 Jan 2023 01:39:45 +0000 Received: from localhost ([127.0.0.1]:59428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEKf3-0003ns-1F for submit@debbugs.gnu.org; Sat, 07 Jan 2023 20:39:45 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:35469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEKez-0003nZ-S9 for 60526@debbugs.gnu.org; Sat, 07 Jan 2023 20:39:42 -0500 Received: by mail-pj1-f52.google.com with SMTP id w4-20020a17090ac98400b002186f5d7a4cso9258266pjt.0 for <60526@debbugs.gnu.org>; Sat, 07 Jan 2023 17:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=3dQRS1YwKptiZpu4eXwWl6vyBA7XsAgWFVvx0v5is+k=; b=DDXBesl+cY7qBQ0mbAJqgScgqyjKmXnnb3U6UsqRdaXXPQwQSI3JOIYbkwXXDZL9pu TlZ+nGQzngbKfvH7bWMYgfNBPdHn37TYZKfav+7p44vir12eP0EMyN4ntlCIkbCMolZa U9GLQ2IVn4xLChYl6e38me7RI2GELyYQo9ZaEInkTv7s5BaG7DZIy+/NzjxVaEtdyEEn AAx7FYrAvlaBqMxThD0UI0gs9h4/idZ/DyWSDTRU5Pt/iECraOpOSVjIsdu/RDP/JPL8 n7QwL5kj5NGfp6ZpyhO3556KCkE7A4ldJEIVMfbVm87IaC1WOHdF4JnVYUbxO2gxdP7u XpPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3dQRS1YwKptiZpu4eXwWl6vyBA7XsAgWFVvx0v5is+k=; b=n8M5yLbc1bKI3jKSDltm18CYBDObJw4I1gxVVh1dgKXjyFuh0ekPhCzr43OBPRob0B ibztn4O+INhjekrQ0tU4w29UZrWddJKNpmIj7KyXSis3A4Tl7hYQ1MOzdEfa3QNR15L6 niYIbFIvEr1I6M/frXO5N7FLS/RthP+3LaawQrxirtA+Sr18imstPQEn8KurG150boW8 Vh4NpRjSf14GCkvPx6V0u96F5kwN5/gdWgkDuWKkUgcXOmTWNnBH17E/LPi4F7HYzfHw ZdyjeFJEEnuFF6eDS+i7HyODfUthDGpxu8cFvStS3V7w6Yj0C2UE0kBYi8pw+TbjDB5i yPKg== X-Gm-Message-State: AFqh2kofoRksjOZYZ8uitkdEi2iEgOgQisE3whbpBMTjs/Bi88W8rDY5 ZW6Qg4dxAnlXyquXP2M9L3c= X-Google-Smtp-Source: AMrXdXumYSqA6bPV9nWtSKtGQML74XnRvIDqxomUKTfwL6Pn3wMRqQwO1cIhfaH3H19YCyuUKqlsEg== X-Received: by 2002:a17:902:f7ce:b0:192:a51d:e29f with SMTP id h14-20020a170902f7ce00b00192a51de29fmr37223393plw.62.1673141976010; Sat, 07 Jan 2023 17:39:36 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a13-20020a1709027e4d00b0019312dd3f99sm3063029pln.176.2023.01.07.17.39.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jan 2023 17:39:35 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Message-Id: Date: Sat, 7 Jan 2023 17:39:34 -0800 X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >>>> - ("\\.js[mx]?\\'" . javascript-mode) >>>> + ("\\.js[mx]?\\'" . js-mode) >>>> ;; https://en.wikipedia.org/wiki/.har >>>> - ("\\.har\\'" . javascript-mode) >>>> + ("\\.har\\'" . js-mode) >>>> ("\\.json\\'" . js-json-mode) >>>> ("\\.[ds]?va?h?\\'" . verilog-mode) >>>> ("\\.by\\'" . bovine-grammar-mode) >>> >>> This is basically a no-brainer, but we had javascript-mode there for >>> quite some time, and it's too late to change that for Emacs 29. >>> Please install on master. >> >> I thought auto-mode-alist should use the canonical name and >> major-mode-remap-alist maps the canonical name to the actual mode. > > But the canonical name is js-mode, because javascript-mode is > an alias to js-mode. js-mode feels more like "implementation name" to me. After all, the name of the language is Javascript, not js. I think javascript-mode best represents "major mode for javascript", not js-mode, if you get what I mean. >> Why do we need >> >>>> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) >> >> if auto-mode-alist uses javascript-mode? > > This is needed for the case when users or packages customized > auto-mode-alist to use the name js-mode. If they customize auto-mode-alist to js-mode, I expect them to expect Emacs to use js-mode by default, not the tree-sitter mode. Yuan From unknown Tue Jun 17 22:27:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#60526: closed (Re: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode) Message-ID: References: <86sfglwhs3.fsf@mail.linkov.net> <86fscrwkq1.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 60526 X-Gnu-PR-Package: emacs Reply-To: 60526@debbugs.gnu.org Date: Sun, 08 Jan 2023 08:50:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1673167804-3303-1" This is a multi-part message in MIME format... ------------=_1673167804-3303-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60526: 29.0.60; javascript-mode =E2=86=92 js-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60526@debbugs.gnu.org. --=20 60526: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60526 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1673167804-3303-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60526-done) by debbugs.gnu.org; 8 Jan 2023 08:49:30 +0000 Received: from localhost ([127.0.0.1]:59814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pERMv-0000pJ-RY for submit@debbugs.gnu.org; Sun, 08 Jan 2023 03:49:30 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pERMt-0000p1-Fq for 60526-done@debbugs.gnu.org; Sun, 08 Jan 2023 03:49:28 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 15B60FF802; Sun, 8 Jan 2023 08:49:19 +0000 (UTC) From: Juri Linkov To: Yuan Fu Subject: Re: bug#60526: 29.0.60; javascript-mode =?utf-8?Q?=E2=86=92?= js-mode In-Reply-To: (Yuan Fu's message of "Sat, 7 Jan 2023 17:39:34 -0800") Organization: LINKOV.NET References: Date: Sun, 08 Jan 2023 10:26:13 +0200 Message-ID: <86sfglwhs3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60526-done Cc: 60526-done@debbugs.gnu.org, Eli Zaretskii , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > js-mode feels more like "implementation name" to me. After all, the name > of the language is Javascript, not js. I think javascript-mode best > represents "major mode for javascript", not js-mode, if you get what I > mean. Indeed, and the treesit module is named tree-sitter-javascript, not js. So closing this report now. ------------=_1673167804-3303-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Jan 2023 18:14:48 +0000 Received: from localhost ([127.0.0.1]:46687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCloG-00059x-GX for submit@debbugs.gnu.org; Tue, 03 Jan 2023 13:14:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:50424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCloE-00059p-CF for submit@debbugs.gnu.org; Tue, 03 Jan 2023 13:14:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCloE-0007RR-4y for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 13:14:46 -0500 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCloC-0004Qz-2m for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 13:14:45 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 797E81C000A for ; Tue, 3 Jan 2023 18:14:39 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 29.0.60; javascript-mode =?utf-8?Q?=E2=86=92?= js-mode Organization: LINKOV.NET Date: Tue, 03 Jan 2023 20:12:38 +0200 Message-ID: <86fscrwkq1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain It looks wrong to require from users to add mappings for both `js-mode' and its alias `javascript-mode' to `major-mode-remap-alist': (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) (add-to-list 'major-mode-remap-alist '(javascript-mode . js-ts-mode)) Either `major-mode-remap-alist' could support aliases, or simpler would be just to replace the alias in `auto-mode-alist': --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=javascript-ts-mode.patch diff --git a/lisp/files.el b/lisp/files.el index c45c3d40a5d..2acc1d1df4a 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -2952,9 +2952,9 @@ auto-mode-alist ("\\.dbk\\'" . xml-mode) ("\\.dtd\\'" . sgml-mode) ("\\.ds\\(ss\\)?l\\'" . dsssl-mode) - ("\\.js[mx]?\\'" . javascript-mode) + ("\\.js[mx]?\\'" . js-mode) ;; https://en.wikipedia.org/wiki/.har - ("\\.har\\'" . javascript-mode) + ("\\.har\\'" . js-mode) ("\\.json\\'" . js-json-mode) ("\\.[ds]?va?h?\\'" . verilog-mode) ("\\.by\\'" . bovine-grammar-mode) --=-=-=-- ------------=_1673167804-3303-1-- From unknown Tue Jun 17 22:27:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 11:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu , Juri Linkov Cc: 60526@debbugs.gnu.org, Eli Zaretskii , monnier@iro.umontreal.ca Received: via spool by 60526-submit@debbugs.gnu.org id=B60526.167317607916943 (code B ref 60526); Sun, 08 Jan 2023 11:08:01 +0000 Received: (at 60526) by debbugs.gnu.org; 8 Jan 2023 11:07:59 +0000 Received: from localhost ([127.0.0.1]:60015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pETWt-0004P8-Td for submit@debbugs.gnu.org; Sun, 08 Jan 2023 06:07:59 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:47083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pETWo-0004Or-9j for 60526@debbugs.gnu.org; Sun, 08 Jan 2023 06:07:54 -0500 Received: by mail-wm1-f48.google.com with SMTP id m26-20020a05600c3b1a00b003d9811fcaafso4390440wms.5 for <60526@debbugs.gnu.org>; Sun, 08 Jan 2023 03:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=8rmK5Si0wv/MNWcg0Kccn0kNfHVLrMy/cYZtiuS84J0=; b=A/0XzD15hu7sdWSl/HqqaD1DiPYgWtfLFiI+Yw/+R25TeloZLLG097PTLiD8dw9Sb8 01/C1AzwQTzpHucjOndEcKqup17HiHi+n//jFvc53qdHunfnsDQa0BCsldydBbc2nTc2 nG2MRtyxOO8+HJY5tkvidSYSYfxPVz2Wf4nPqiRP3BrXosRl/F3lhivXFOf6dQM6TeQg Xqi5OfNuv9MH2+i1Qh3njkwiY3DqEqUv3sfppCA+qPIeZGoJ7DraLDqQko80Rw5CMpOd qPZLE3aZK/jBjtz1sLZzr8n1RqbvXfen8HdqmQ9tN8LBrmszsQVEkKXEsoq4ep2MAm3k TjDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8rmK5Si0wv/MNWcg0Kccn0kNfHVLrMy/cYZtiuS84J0=; b=GHhihHQHIIENIqf4MqwHvLae5IjpG168rBdcCQZzqcftleZRzc6+kvYMJk+GP68Uio Pcj5nL9PwCb/Lz/4zp5dmfiPFiuharLHCx9THFcVd/zXbYCUpcKQY8EBd4aXkIBLhnzU xDY2+uMjDnbUmMUDyKZK4j3o8l6q5EARm+nriOYcsxmp5BLoPfKdluC8leoBcJmfhstL GDIxTzQnrph+2KwEhDuBpxC5ROsBzgqN2bx+wh36fxseR+oQCKH19dshUluK0eqxBQwj 9cBd4AFZCFlyhG+gfd6Xoxmd0JgATIL0lrB0g7pKHiuNJQvo6tYRyYHZB6NtQfBO/axs 6oLw== X-Gm-Message-State: AFqh2kqS00LzNXILSdhHIIBaY7QmNOTPPe1XfgdQELShBkOhxLSVM862 j8cYU2VU8yGzQSiQfkkpRDc= X-Google-Smtp-Source: AMrXdXsLFa/H55RcL5CWxHUggwHR+I7dDMGwbfkwmtAKG8v9Gw3x58LB8jzZfAf7f5RUlQxQHDMSSQ== X-Received: by 2002:a05:600c:6003:b0:3d6:10e:68a8 with SMTP id az3-20020a05600c600300b003d6010e68a8mr44707878wmb.0.1673176064235; Sun, 08 Jan 2023 03:07:44 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id iv14-20020a05600c548e00b003b47b80cec3sm13935703wmb.42.2023.01.08.03.07.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Jan 2023 03:07:43 -0800 (PST) Message-ID: Date: Sun, 8 Jan 2023 13:07:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86fscrwkq1.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 08/01/2023 03:39, Yuan Fu wrote: > Juri Linkov writes: > >>>>> - ("\\.js[mx]?\\'" . javascript-mode) >>>>> + ("\\.js[mx]?\\'" . js-mode) >>>>> ;;https://en.wikipedia.org/wiki/.har >>>>> - ("\\.har\\'" . javascript-mode) >>>>> + ("\\.har\\'" . js-mode) >>>>> ("\\.json\\'" . js-json-mode) >>>>> ("\\.[ds]?va?h?\\'" . verilog-mode) >>>>> ("\\.by\\'" . bovine-grammar-mode) >>>> This is basically a no-brainer, but we had javascript-mode there for >>>> quite some time, and it's too late to change that for Emacs 29. >>>> Please install on master. >>> I thought auto-mode-alist should use the canonical name and >>> major-mode-remap-alist maps the canonical name to the actual mode. >> But the canonical name is js-mode, because javascript-mode is >> an alias to js-mode. > js-mode feels more like "implementation name" to me. After all, the name > of the language is Javascript, not js. I think javascript-mode best > represents "major mode for javascript", not js-mode, if you get what I > mean. > javascript-mode was the name of a different mode. js-mode was a later rewrite of it.