GNU bug report logs - #60525
29.0.60; tree-sitter support in semantic-symref

Previous Next

Full log

Message #23 received at 60525 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 60525 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#60525: 29.0.60; tree-sitter support in semantic-symref
Date: Wed, 04 Jan 2023 16:34:10 +0200

> Cc: 60525 <at> debbugs.gnu.org
> From: Juri Linkov <juri <at> linkov.net>
> Date: Wed, 04 Jan 2023 09:43:12 +0200
> 
> > diff --git a/lisp/cedet/semantic/symref/grep.el
> > ...
> > -	 (pat (cdr (assoc mode semantic-symref-filepattern-alist))))
> > +	 (pat
> > +          (or (assoc-default mode semantic-symref-filepattern-alist)
> > +              (assoc-default (car (rassoc mode major-mode-remap-alist))
> > +                             semantic-symref-filepattern-alist))))
> 
> I'm fine with this change if Eli agrees to install it
> on the emacs-29 branch.

No, it's too much for the release branch, and as I wrote elsewhere,
doesn't sound justified to me.

> But also note that such duplication is unavoidable in many other places.
> For example, to support abbreviations there is the need to manually
> rename
> 
>   (define-abbrev-table 'ruby-mode-abbrev-table
> 
> to
> 
>   (define-abbrev-table 'ruby-base-mode-abbrev-table
> 
> in ~/.emacs.d/abbrev_defs.  But on exiting Emacs it insists
> on saving duplicate abbrevs to 
> 
>   (define-abbrev-table 'ruby-ts-mode-abbrev-table

There's no way around that: people who want use both modes will have
to live with duplication for now.  There's a limit to what we can do
so close to the release.  Sorry.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.