Subject: Re: bug#60518: [PATCH] gnu: spirv-cross: Activate tests.

From: Ludovic Courtès <[email-masked]>
Date: Tue, 31 Jan 2023 23:57:03 +0100

Hi,

Nicolas Graves <[email-masked]> skribis:

> * gnu/packages/vulkan.scm (spirv-cross):
>    [arguments]: Add phase update-reference-shaders.
>    [arguments]: Activate tests.

Applied, thanks!

Liliana Marie Prikler <[email-masked]> skribis:

> Am Dienstag, dem 03.01.2023 um 16:48 +0100 schrieb Nicolas Graves:
>> * gnu/packages/vulkan.scm (spirv-cross):
>>    [arguments]: Add phase update-reference-shaders.
>>    [arguments]: Activate tests.
> Should be 
>   
>   * gnu/packages/vulkan.scm (spirv-cross)[arguments]: Remove #:tests?.
>   <#:phases>: Add ‘update-reference-shaders’.

I did that on their behalf (in general I think that’s what we should do,
it’s just more efficient and less frustrating for everyone).

>> +           (lambda _
>> +             (with-directory-excursion "../source"
>> +               (invoke "./update_test_shaders.sh")))))))
> Instead of updating all the shaders, should we perhaps only update 
>
> the three that are mentioned as failing?

Apparently the script is designed for this purpose.

Thanks,
Ludo’.