From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 09:08:14 2023 Received: (at submit) by debbugs.gnu.org; 3 Jan 2023 14:08:14 +0000 Received: from localhost ([127.0.0.1]:44984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pChxe-0006e4-1i for submit@debbugs.gnu.org; Tue, 03 Jan 2023 09:08:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:60246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pChxb-0006dv-PZ for submit@debbugs.gnu.org; Tue, 03 Jan 2023 09:08:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pChxX-0001xb-TA for guix-patches@gnu.org; Tue, 03 Jan 2023 09:08:11 -0500 Received: from smtpmciv1.myservices.hosting ([185.26.107.237]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pChxU-0003n5-0v for guix-patches@gnu.org; Tue, 03 Jan 2023 09:08:07 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv1.myservices.hosting (Postfix) with ESMTP id 3FDE020612 for ; Tue, 3 Jan 2023 15:07:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 03CC180096; Tue, 3 Jan 2023 15:07:59 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PCBmaoBm6l_Z; Tue, 3 Jan 2023 15:07:58 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-118-236.dsl.telepac.pt [85.242.118.236]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 63B9A80093; Tue, 3 Jan 2023 15:07:58 +0100 (CET) From: mirai@makinata.eu To: guix-patches@gnu.org Subject: [PATCH] services: git-daemon: Deprecate 'git-daemon-service' procedure. Date: Tue, 3 Jan 2023 14:07:49 +0000 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Debbugs-CC: me@tobias.gr Tags: patch Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.107.237; envelope-from=mirai@makinata.eu; helo=smtpmciv1.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Bruno Victal * gnu/services/version-control.scm (git-daemon-service): Define with 'define-deprecated' * doc/guix.texi (Version Control Services): Replace with 'git-daemon-service-type' --- doc/guix.texi | 25 +++++++++++-------------- gnu/services/version-control.scm | 4 +++- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 5c85680831..552a403bcb 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -34838,27 +34838,24 @@ How often to run the node cleaning job. The default is once per day, at The @code{(gnu services version-control)} module provides a service to allow remote access to local Git repositories. There are three options: -the @code{git-daemon-service}, which provides access to repositories via +the @code{git-daemon-service-type}, which provides access to repositories via the @code{git://} unsecured TCP-based protocol, extending the @code{nginx} web server to proxy some requests to @code{git-http-backend}, or providing a web interface with @code{cgit-service-type}. -@deffn {Scheme Procedure} git-daemon-service [#:config (git-daemon-configuration)] - -Return a service that runs @command{git daemon}, a simple TCP server to +@defvar git-daemon-service-type +Type for a service that runs @command{git daemon}, a simple TCP server to expose repositories over the Git protocol for anonymous access. -The optional @var{config} argument should be a -@code{} object, by default it allows read-only -access to exported@footnote{By creating the magic file -@file{git-daemon-export-ok} in the repository directory.} repositories under -@file{/srv/git}. - -@end deffn +The value for this service type is a @code{} +record, by default it allows read-only access to exported@footnote{By +creating the magic file @file{git-daemon-export-ok} in the repository +directory.} repositories under @file{/srv/git}. +@end defvar @deftp {Data Type} git-daemon-configuration -Data type representing the configuration for @code{git-daemon-service}. +Data type representing the configuration for @code{git-daemon-service-type}. @table @asis @item @code{package} (default: @code{git}) @@ -34895,8 +34892,8 @@ Whether to listen on an alternative port, which defaults to 9418. If not empty, only allow access to this list of directories. @item @code{extra-options} (default: @code{'()}) -Extra options will be passed to @command{git daemon}, please run -@command{man git-daemon} for more information. +Extra options that will be passed to @command{git daemon}.@footnote{Run +@command{man git-daemon} for more information.} @end table @end deftp diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm index 86d40bdbe3..14ff0a59a6 100644 --- a/gnu/services/version-control.scm +++ b/gnu/services/version-control.scm @@ -29,6 +29,7 @@ (define-module (gnu services version-control) #:use-module (gnu system shadow) #:use-module (gnu packages version-control) #:use-module (gnu packages admin) + #:use-module (guix deprecation) #:use-module (guix records) #:use-module (guix gexp) #:use-module (guix store) @@ -178,7 +179,8 @@ (define git-daemon-service-type protocol.") (default-value (git-daemon-configuration)))) -(define* (git-daemon-service #:key (config (git-daemon-configuration))) +(define-deprecated (git-daemon-service #:key (config (git-daemon-configuration))) + git-daemon-service-type "Return a service that runs @command{git daemon}, a simple TCP server to expose repositories over the Git protocol for anonymous access. base-commit: 473692b812b4ab4267d9bddad0fb27787d2112ff -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 04:57:52 2023 Received: (at 60516-done) by debbugs.gnu.org; 10 Jan 2023 09:57:52 +0000 Received: from localhost ([127.0.0.1]:38829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFBOC-0003G1-72 for submit@debbugs.gnu.org; Tue, 10 Jan 2023 04:57:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFBOA-0003Fn-08 for 60516-done@debbugs.gnu.org; Tue, 10 Jan 2023 04:57:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFBO3-0004b3-Fb; Tue, 10 Jan 2023 04:57:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DIdjrLn1glM9FhMwGEYPrc4X5qoKPtRuR0ZBBafJ2zc=; b=Jk2j4FNDXBY9ldlFu27J fcUzWgqmL1yKq2r+fluNNzFMZQbvn8csWB0/cUYw3nEYWySo5AixI8CtZ1bDfz6B1FnXPkXKYHRjq qiZY0YgScdvMvbm1dkoyfjiZAezzHBsIemOmmMyRzkdidUsMyWinQH4ZzTwCejbzmdQJu+wI/sTuT Wpev1YDt5tNrQxGYuA6AvYE7yoXQQaE86sx8r+VcTRHcnU/lMsuaGUSiBdvXS0OtclWRDP5ayja8l 4L9pESoZZdmjQUxh0736cNUYUfSpJ2B6GaH+5xZru1sKBfgQBRfvnmnNZODKByhoF6Th9uK38G2Cy 2/oVAyPJEmsvcQ==; Received: from [193.50.110.246] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFBO2-00070j-T8; Tue, 10 Jan 2023 04:57:43 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: mirai@makinata.eu Subject: Re: bug#60516: [PATCH] services: git-daemon: Deprecate 'git-daemon-service' procedure. References: Date: Tue, 10 Jan 2023 10:57:41 +0100 In-Reply-To: (mirai@makinata.eu's message of "Tue, 3 Jan 2023 14:07:49 +0000") Message-ID: <87v8leogoa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60516-done Cc: me@tobias.gr, 60516-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, mirai@makinata.eu skribis: > From: Bruno Victal > > * gnu/services/version-control.scm > (git-daemon-service): Define with 'define-deprecated' > * doc/guix.texi (Version Control Services): Replace with > 'git-daemon-service-type' Applied, thanks! Ludo=E2=80=99. From unknown Sun Jun 22 04:33:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Feb 2023 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator