GNU bug report logs - #60503
29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes

Previous Next

Full log

Message #15 received at 60503-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 60503-done <at> debbugs.gnu.org, dancol <at> dancol.org, jostein <at> kjonigsen.net
Subject: Re: bug#60503: 29.0.60; js-ts-mode has inconsistent 
 features/fontification wrt other ts major-modes
Date: Mon, 2 Jan 2023 14:20:33 -0800

Theodor Thornhill <theo <at> thornhill.no> writes:

> Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> writes:
>
>> js-ts-mode does not adhere to the "standardized" features and 
>> fontification levels requested in emacs-devel.
>>
>> It's overall pretty good, but I did find one minor inconsistency which 
>> annoyed me enough to (IMO) warrant an update:
>>
>> js-ts-mode does not highlight incoming parameters in 
>> functions/methods/arrow-expressions as variables.
>>
>> Attached is a patch which fixes this issue and makes it much more 
>> consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode.
>>
>
> Looks good to me :-)
>
> Theo

Great! I applied the patch.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.