From unknown Sat Jun 21 03:12:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60503 <60503@debbugs.gnu.org> To: bug#60503 <60503@debbugs.gnu.org> Subject: Status: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes Reply-To: bug#60503 <60503@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:12:37 +0000 retitle 60503 29.0.60; js-ts-mode has inconsistent features/fontification w= rt other ts major-modes reassign 60503 emacs submitter 60503 jostein@kjonigsen.net severity 60503 normal tag 60503 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 15:29:23 2023 Received: (at submit) by debbugs.gnu.org; 2 Jan 2023 20:29:24 +0000 Received: from localhost ([127.0.0.1]:44161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRQw-0000Tt-MU for submit@debbugs.gnu.org; Mon, 02 Jan 2023 15:29:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:33704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRQr-0000Te-Cx for submit@debbugs.gnu.org; Mon, 02 Jan 2023 15:29:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCRQk-0006rT-1o for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:29:14 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCRQa-00049U-8D for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:29:09 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E33D43200645; Mon, 2 Jan 2023 15:28:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 02 Jan 2023 15:28:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1672691325; x=1672777725; bh=CA pnrEiyIgEPpNH7sUP1SN59PJpVxCD5yFwlKEcVQ/g=; b=b4mY20erf30tFXU256 UYx7EHHpVm08gRR5RcP/Lu7vkvOjehF9i2wYPI5+RIj8wcZ/dr+UDDOrh1knD/jZ utMp7LbsK9/gIqjjI4PdTveJWeDiDg04f7lAWpWpVrWtAApRvweNvqGQdHh3tjXp bhkvPe9duKUD6DKh2k8kvF8BwVbafJqlZtrdyU2Yu8YqXb5K46arFRJ02WDWk7Kk p3bvVE7cw9XkhIjWR1L1un4p7BbQXTTjkEcELGbGphXz6gDCM0c62zlODEjkELXA aUpxp9y1cVGr9Pue3rcu+QoaX5e5pquf18yebUxE9jfuiv/UFpyHbF1CysizyVVx S/Ig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672691325; x=1672777725; bh=CApnrEiyIgEPpNH7sUP1SN59PJpVxCD5yFw lKEcVQ/g=; b=w/maz3PvUFx/eGXRqbaT7ZFBuoKaBp5zsRLQ1QIGe3NqbckdlbB XEWLrcGhD/XSzbobfw0Lntced5ulLLpCIAFn/BGutoXiyFZ0ch4nn779At/TYUZy Wiw3xQVqAQrU+n6CnsPxRAxlEF56RXNLNP11hs01ua5mmNJmqOydJJNa00r0i42E QiK4w2pnC6y1I/t/LnxocU77VDdBUOxsrwWbiL8/+I5XkntyDZ8GJtnlkusnj1ZI pqDxIdfGkKVNpB0w4lOqEOnsxUpzayKxCRRsF/mcNH0m/q6ECQYDWotNxIpTop4G PXXZt5ejMsFm7ejtRWlHlEQtTYs1D53sA6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghrvffhufesmhdtreertdefjeenucfhrhhomheplfhoshhtvghi nhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgsh gvnhdrnhgvtheqnecuggftrfgrthhtvghrnhephedtffelgfegtdeggfduvdehveegudej veevteetvedttedtfeehtdfhtdduvdevnecuffhomhgrihhnpehkjhhnihhgshgvnhdrnh honecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhho shhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Jan 2023 15:28:44 -0500 (EST) Content-Type: multipart/mixed; boundary="------------qaIq8lAHWAW8XhldsXvo4xm9" Message-ID: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net> Date: Mon, 2 Jan 2023 21:28:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO To: "bug-gnu-emacs@gnu.org" , Yuan Fu , Daniel Colascione , Theodor Thornhill From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes Received-SPF: pass client-ip=64.147.123.20; envelope-from=jostein@secure.kjonigsen.net; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------qaIq8lAHWAW8XhldsXvo4xm9 Content-Type: multipart/alternative; boundary="------------oelgbbQcoVrEQoPq003g1X19" --------------oelgbbQcoVrEQoPq003g1X19 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit js-ts-mode does not adhere to the "standardized" features and fontification levels requested in emacs-devel. It's overall pretty good, but I did find one minor inconsistency which annoyed me enough to (IMO) warrant an update: js-ts-mode does not highlight incoming parameters in functions/methods/arrow-expressions as variables. Attached is a patch which fixes this issue and makes it much more consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode. -- In GNU Emacs 29.0.60 (build 7, x86_64-pc-linux-gnu, GTK+ Version  3.24.34, cairo version 1.16.0) of 2023-01-01 built on ThinkPad-T14s Repository revision: f12f72b0e09c7a45098955c1304499963a5eb9a7 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Ubuntu 22.10 Configured using:  'configure --with-json --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: nb_NO.UTF-8   value of $LC_NUMERIC: nb_NO.UTF-8   value of $LC_TIME: nb_NO.UTF-8   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: Magit Minor modes in effect:   global-undo-tree-mode: t   undo-tree-mode: t   global-git-commit-mode: t   magit-auto-revert-mode: t   editorconfig-mode: t   which-function-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   shell-dirtrack-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   yas-global-mode: t   yas-minor-mode: t   global-nlinum-mode: t   ido-yes-or-no-mode: t   override-global-mode: t   server-mode: t   global-hl-line-mode: t   pixel-scroll-precision-mode: t   doom-modeline-mode: t   tooltip-mode: t   global-eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   buffer-read-only: t   column-number-mode: t   line-number-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221202.1727/transient hides /home/jostein/build/emacs/lisp/transient Features: (shadow sort emacsbug git-rebase helm-bookmark helm-net helm-adaptive magit-bookmark bookmark mail-extr typescript-ts-mode js magit-extras flyspell ispell undo-tree queue magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm compat-27 compat-26 executable helm-command helm-elisp helm-eval edebug helm-info misearch multi-isearch bug-reference face-remap disp-table elec-pair csharp-mode c-ts-mode treesit cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs vc-git diff-mode vc-dispatcher vc-svn winner ffap tramp-archive tramp-gvfs tramp-cache time-stamp zeroconf dbus add-log ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit highlight-symbol flycheck editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company eglot external-completion array jsonrpc ert ewoc debug backtrace flymake-proc flymake warnings which-func hideshow eww url-queue thingatpt shr pixel-fill kinsoku url-file svg xml dom puny mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr helm-imenu pcase imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load icons wid-edit files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel autorevert filenotify yasnippet derived nlinum linum ido-yes-or-no advice ido edmacro kmacro use-package-bind-key bind-key easy-mmode xref project server hl-line pixel-scroll cua-base compile-eslint compile comint ansi-osc ansi-color ring doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path rx f f-shortdoc shortdoc text-property-search s dash compat compat-macs dracula-theme cl-extra help-mode use-package-ensure use-package-core finder-inf flycheck-autoloads helm-autoloads helm-core-autoloads expand-region-autoloads all-the-icons-autoloads bmx-mode-autoloads doom-modeline-autoloads async-autoloads dracula-theme-autoloads highlight-symbol-autoloads multiple-cursors-autoloads projectile-autoloads nlinum-autoloads pkg-info-autoloads epl-autoloads undo-tree-autoloads rust-mode-autoloads editorconfig-autoloads magit-autoloads yasnippet-autoloads elisp-slime-nav-autoloads crontab-mode-autoloads ido-yes-or-no-autoloads magit-section-autoloads cargo-autoloads ido-completing-read+-autoloads memoize-autoloads paredit-autoloads company-autoloads yaml-mode-autoloads powershell-autoloads dap-mode-autoloads lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads bui-autoloads lsp-mode-autoloads lv-autoloads markdown-mode-autoloads spinner-autoloads ht-autoloads git-commit-autoloads transient-autoloads compat-autoloads cmake-mode-autoloads shrink-path-autoloads f-autoloads info dash-autoloads s-autoloads popup-autoloads queue-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 1404910 128978)  (symbols 48 47016 24)  (strings 32 203095 12541)  (string-bytes 1 6450958)  (vectors 16 95226)  (vector-slots 8 1840465 212702)  (floats 8 890 1003)  (intervals 56 86732 4097)  (buffers 984 44)) -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------oelgbbQcoVrEQoPq003g1X19 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

js-ts-mode does not adhere to the "standardized" features and fontification levels requested in emacs-devel.

It's overall pretty good, but I did find one minor inconsistency which annoyed me enough to (IMO) warrant an update:

js-ts-mode does not highlight incoming parameters in functions/methods/arrow-expressions as variables.

Attached is a patch which fixes this issue and makes it much more consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode.

--


In GNU Emacs 29.0.60 (build 7, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2023-01-01 built on ThinkPad-T14s
Repository revision: f12f72b0e09c7a45098955c1304499963a5eb9a7
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12201003
System Description: Ubuntu 22.10

Configured using:
 'configure --with-json --with-tree-sitter'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: nb_NO.UTF-8
  value of $LC_NUMERIC: nb_NO.UTF-8
  value of $LC_TIME: nb_NO.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Magit

Minor modes in effect:
  global-undo-tree-mode: t
  undo-tree-mode: t
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  editorconfig-mode: t
  which-function-mode: t
  helm-mode: t
  helm-minibuffer-history-mode: t
  shell-dirtrack-mode: t
  helm--remap-mouse-mode: t
  async-bytecomp-package-mode: t
  delete-selection-mode: t
  global-auto-revert-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-nlinum-mode: t
  ido-yes-or-no-mode: t
  override-global-mode: t
  server-mode: t
  global-hl-line-mode: t
  pixel-scroll-precision-mode: t
  doom-modeline-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/jostein/.emacs.d/elpa/transient-20221202.1727/transient hides /home/jostein/build/emacs/lisp/transient

Features:
(shadow sort emacsbug git-rebase helm-bookmark helm-net helm-adaptive
magit-bookmark bookmark mail-extr typescript-ts-mode js magit-extras
flyspell ispell undo-tree queue magit-submodule magit-obsolete
magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull
magit-fetch magit-clone magit-remote magit-commit magit-sequence
magit-notes magit-worktree magit-tag magit-merge magit-branch
magit-reset magit-files magit-refs magit-status magit magit-repos
magit-apply magit-wip magit-log magit-diff smerge-mode diff git-commit
log-edit message sendmail yank-media rfc822 mml mml-sec epa epg rfc6068
epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047
rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core
magit-autorevert magit-margin magit-transient magit-process with-editor
magit-mode transient magit-git magit-base magit-section crm compat-27
compat-26 executable helm-command helm-elisp helm-eval edebug helm-info
misearch multi-isearch bug-reference face-remap disp-table elec-pair
csharp-mode c-ts-mode treesit cc-langs cc-mode cc-fonts cc-guess
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs vc-git
diff-mode vc-dispatcher vc-svn winner ffap tramp-archive tramp-gvfs
tramp-cache time-stamp zeroconf dbus add-log ido-completing-read+
memoize minibuf-eldef elisp-slime-nav paredit highlight-symbol flycheck
editorconfig editorconfig-core editorconfig-core-handle
editorconfig-fnmatch company-oddmuse company-keywords company-etags
etags fileloop generator company-gtags company-dabbrev-code
company-dabbrev company-files company-clang company-capf company-cmake
company-semantic company-template company-bbdb company eglot
external-completion array jsonrpc ert ewoc debug backtrace flymake-proc
flymake warnings which-func hideshow eww url-queue thingatpt shr
pixel-fill kinsoku url-file svg xml dom puny mm-url gnus nnheader
gnus-util mail-utils range mm-util mail-prsvr helm-imenu pcase imenu
ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-src ob-comint org-pcomplete org-list org-footnote org-faces
org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle
org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func
cal-menu calendar cal-loaddefs org-version org-compat org-macs helm-mode
helm-misc helm-files image-dired image-dired-tags image-dired-external
image-dired-util xdg image-mode dired dired-loaddefs exif tramp
tramp-loaddefs trampver tramp-integration cus-edit pp cus-load icons
wid-edit files-x tramp-compat shell pcomplete parse-time iso8601
time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate
helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm
helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source
helm-multi-match helm-lib async helm-config delsel autorevert filenotify
yasnippet derived nlinum linum ido-yes-or-no advice ido edmacro kmacro
use-package-bind-key bind-key easy-mmode xref project server hl-line
pixel-scroll cua-base compile-eslint compile comint ansi-osc ansi-color
ring doom-modeline doom-modeline-segments doom-modeline-env
doom-modeline-core all-the-icons all-the-icons-faces data-material
data-weathericons data-octicons data-fileicons data-faicons
data-alltheicons shrink-path rx f f-shortdoc shortdoc
text-property-search s dash compat compat-macs dracula-theme cl-extra
help-mode use-package-ensure use-package-core finder-inf
flycheck-autoloads helm-autoloads helm-core-autoloads
expand-region-autoloads all-the-icons-autoloads bmx-mode-autoloads
doom-modeline-autoloads async-autoloads dracula-theme-autoloads
highlight-symbol-autoloads multiple-cursors-autoloads
projectile-autoloads nlinum-autoloads pkg-info-autoloads epl-autoloads
undo-tree-autoloads rust-mode-autoloads editorconfig-autoloads
magit-autoloads yasnippet-autoloads elisp-slime-nav-autoloads
crontab-mode-autoloads ido-yes-or-no-autoloads magit-section-autoloads
cargo-autoloads ido-completing-read+-autoloads memoize-autoloads
paredit-autoloads company-autoloads yaml-mode-autoloads
powershell-autoloads dap-mode-autoloads lsp-docker-autoloads
yaml-autoloads lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads
posframe-autoloads hydra-autoloads pfuture-autoloads
ace-window-autoloads avy-autoloads bui-autoloads lsp-mode-autoloads
lv-autoloads markdown-mode-autoloads spinner-autoloads ht-autoloads
git-commit-autoloads transient-autoloads compat-autoloads
cmake-mode-autoloads shrink-path-autoloads f-autoloads info
dash-autoloads s-autoloads popup-autoloads queue-autoloads package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache
json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs
cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process emacs)

Memory information:
((conses 16 1404910 128978)
 (symbols 48 47016 24)
 (strings 32 203095 12541)
 (string-bytes 1 6450958)
 (vectors 16 95226)
 (vector-slots 8 1840465 212702)
 (floats 8 890 1003)
 (intervals 56 86732 4097)
 (buffers 984 44))

--
Vennlig hilsen
 Jostein Kjønigsen
jostein@kjonigsen.net 🍵 jostein@gmail.com
 https://jostein.kjønigsen.no
--------------oelgbbQcoVrEQoPq003g1X19-- --------------qaIq8lAHWAW8XhldsXvo4xm9 Content-Type: text/x-patch; charset=UTF-8; name="0003-lisp-progmodes-js.el-Improve-fontification-consisten.patch" Content-Disposition: attachment; filename*0="0003-lisp-progmodes-js.el-Improve-fontification-consisten.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0ZjM5OTZiYmUxNWRhZTA0OWEwNTYwYTFlN2ZmZTM1NjBhN2UwZWFlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCAyIEphbiAyMDIzIDIx OjI2OjM2ICswMTAwClN1YmplY3Q6IFtQQVRDSCAzLzNdIGxpc3AvcHJvZ21vZGVzL2pzLmVs OiBJbXByb3ZlIGZvbnRpZmljYXRpb24gY29uc2lzdGVuY3kKCi0gSGlnaGxpZ2h0IGRlY2xh cmVkIHBhcmFtZXRlcnMgaW4gZnVuY3Rpb25zLCBtZXRob2RzIGFuZAogIGFycm93LWV4cHJl c3Npb25zIGFzIHZhcmlhYmxlcy4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9qcy5lbCB8IDkgKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv bGlzcC9wcm9nbW9kZXMvanMuZWwgYi9saXNwL3Byb2dtb2Rlcy9qcy5lbAppbmRleCBjNWZk ZWNhZTcxYi4uMDUwNDcyMDAyYmIgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2pzLmVs CisrKyBiL2xpc3AvcHJvZ21vZGVzL2pzLmVsCkBAIC0zNTIxLDYgKzM1MjEsMTUgQEAganMt LXRyZWVzaXQtZm9udC1sb2NrLXNldHRpbmdzCiAgICAgIChtZXRob2RfZGVmaW5pdGlvbgog ICAgICAgbmFtZTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24t bmFtZS1mYWNlKQogCisgICAgIChtZXRob2RfZGVmaW5pdGlvbgorICAgICAgcGFyYW1ldGVy czogKGZvcm1hbF9wYXJhbWV0ZXJzIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxl LW5hbWUtZmFjZSkpCisKKyAgICAgKGFycm93X2Z1bmN0aW9uCisgICAgICBwYXJhbWV0ZXJz OiAoZm9ybWFsX3BhcmFtZXRlcnMgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUt bmFtZS1mYWNlKSkKKworICAgICAoZnVuY3Rpb25fZGVjbGFyYXRpb24KKyAgICAgIHBhcmFt ZXRlcnM6IChmb3JtYWxfcGFyYW1ldGVycyAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJp YWJsZS1uYW1lLWZhY2UpKQorCiAgICAgICh2YXJpYWJsZV9kZWNsYXJhdG9yCiAgICAgICBu YW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCiAKLS0g CjIuMzcuMgoK --------------qaIq8lAHWAW8XhldsXvo4xm9-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 15:34:17 2023 Received: (at control) by debbugs.gnu.org; 2 Jan 2023 20:34:17 +0000 Received: from localhost ([127.0.0.1]:44182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRVh-0000eA-3B for submit@debbugs.gnu.org; Mon, 02 Jan 2023 15:34:17 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:35585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRVf-0000dv-8o for control@debbugs.gnu.org; Mon, 02 Jan 2023 15:34:15 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 7E2DF320005D for ; Mon, 2 Jan 2023 15:34:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 02 Jan 2023 15:34:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:to:to; s=fm1; t=1672691649; x=1672778049; bh=pUA/ObiidV 1smbRSZK4pjbE/cwyBTDaC8N8scxJUDMw=; b=URNOFy2Y81YfUIRQdBgJA6BcCb IVmHAFDakvYwvcvbrwJftf/SlHOsi0sj8Ga4yzeEQ23p9vjqJpuBA06Tlmo4q8J9 yc0INegI6V/ZgmCGcJLseXTl/Gsjgg5nLoK9pIuvuAtkIm4E60gun/JpOsDAMXi6 tWknRtmJVBizOGHMo3Q+mpN0n3aEIJj7huh4yR6Jz1TD/DYEnu6AUCoc/AXIC1Z4 uhsagYZgC7G9SzrvqusyiSYTQnZLGM+hh45kh9Y5ut64fCqkIMIBPT5mtnrIEjAQ nR6lVTEN2mKmKvvdgrelLVOc9vFJl47T7RAJHUOxZuz+92bsIBWfpEEmY1kQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672691649; x= 1672778049; bh=pUA/ObiidV1smbRSZK4pjbE/cwyBTDaC8N8scxJUDMw=; b=T KuZDVVqT/kXBkbtcpezKgpHRLCEmUD0C2Le0iuSckYfGT4rVEdNPfcGy2kD84qIZ TEJAaO7hqcQ/wYa/Hr+W0s5gqQGWBNEtIn3vZFU/WmVoKEaDhTr0sGlT0civTTjj sHbckmVziLkQEhae6iXGjXCQpR0b9+V0Dj7ycu9GFKOUPTImH4K7voDZB5Xxwpw7 EKDpJK1ZnhZGD1cx5dKHc3VZ7g7HzWcHYdN8f8dbb8TShvLlPJHNJOfHeLcMT2k6 jxCu0Uy0pGwzNNsoz2y1Pbw7KLsxRVd8rYT5NMUxngKg6rmeAR3LepEfjwHRb+Hz Nqvu8g33SCkCEtaAQD97Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenuc fjughrpegtkfffgggfrhfvhfesrgdtreertdefjeenucfhrhhomheplfhoshhtvghinhcu mfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnh drnhgvtheqnecuggftrfgrthhtvghrnhepudevffduffeuheettefgleehudeiuedvveet veefledujeffgffhlefgtedukeefnecuffhomhgrihhnpehkjhhnihhgshgvnhdrnhhone cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshht vghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 2 Jan 2023 15:34:08 -0500 (EST) Content-Type: multipart/alternative; boundary="------------q4q8yQ50FIBeX1HHDFJhlx53" Message-ID: <07c4a259-52ee-f35f-8697-3a850e0da77d@secure.kjonigsen.net> Date: Mon, 2 Jan 2023 21:34:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO To: "control@debbugs.gnu.org" From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tag 60500 patch tag 60503 patch -- Vennlig hilsen *Jostein Kjønigsen* Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.19 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) This is a multi-part message in MIME format. --------------q4q8yQ50FIBeX1HHDFJhlx53 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit tag 60500 patch tag 60503 patch -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------q4q8yQ50FIBeX1HHDFJhlx53 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

tag 60500 patch

tag 60503 patch


--
Vennlig hilsen
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------q4q8yQ50FIBeX1HHDFJhlx53-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 15:57:59 2023 Received: (at submit) by debbugs.gnu.org; 2 Jan 2023 20:57:59 +0000 Received: from localhost ([127.0.0.1]:44210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRsc-0003b5-TH for submit@debbugs.gnu.org; Mon, 02 Jan 2023 15:57:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:35604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCRsb-0003aw-FS for submit@debbugs.gnu.org; Mon, 02 Jan 2023 15:57:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCRsb-0002kh-9o for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:57:57 -0500 Received: from out2.migadu.com ([188.165.223.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCRsZ-0008EF-6G for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 15:57:57 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672693069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iO1It+un+2ji8ZhHfJczzIslyy4KytbIBdi/t0oI9kk=; b=Q1+ePJqXDnnpdR56+z+iDRp2tfmNX8fHTkku4WBm3yWxsNfC4eCBRrq9vEVRPVRlI1jBwd 3qMiuuKMkqonPMvwYYJry6MdSIkZbjuchXMWkF8LDZf2jNA+ClT2yuRG4E/D6WQiqGtp0v edIUwUKCXxmkWE35eENGtQcte3J6Ut2S3Px3Ery3IC6/Yoeon8Ay9bjv8z4EfwDRDiEtG0 /yGJdyYe74M/6J5ludFzIRJ9HLthi1QLJGcaHfGiybHIMNn9n4Oiy4KAe2iwP3ivO+Ua5R Dx7eOl6+X2T/Wh7U/bqdOc3Ph3XEpUS34MBDQpaDSusit0El1emEQ5q+Gd8+YQ== From: Theodor Thornhill To: jostein@kjonigsen.net, "bug-gnu-emacs@gnu.org" , Yuan Fu , Daniel Colascione Subject: Re: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes In-Reply-To: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net> References: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net> Date: Mon, 02 Jan 2023 21:57:47 +0100 Message-ID: <87bkng7iyc.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=188.165.223.204; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Jostein Kj=C3=B8nigsen writes: > js-ts-mode does not adhere to the "standardized" features and=20 > fontification levels requested in emacs-devel. > > It's overall pretty good, but I did find one minor inconsistency which=20 > annoyed me enough to (IMO) warrant an update: > > js-ts-mode does not highlight incoming parameters in=20 > functions/methods/arrow-expressions as variables. > > Attached is a patch which fixes this issue and makes it much more=20 > consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode. > Looks good to me :-) Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 17:20:46 2023 Received: (at 60503-done) by debbugs.gnu.org; 2 Jan 2023 22:20:46 +0000 Received: from localhost ([127.0.0.1]:44255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCTAj-0005mw-Re for submit@debbugs.gnu.org; Mon, 02 Jan 2023 17:20:46 -0500 Received: from mail-pj1-f54.google.com ([209.85.216.54]:35516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCTAf-0005ma-Oi for 60503-done@debbugs.gnu.org; Mon, 02 Jan 2023 17:20:44 -0500 Received: by mail-pj1-f54.google.com with SMTP id w4-20020a17090ac98400b002186f5d7a4cso34162699pjt.0 for <60503-done@debbugs.gnu.org>; Mon, 02 Jan 2023 14:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=bmXWu1e3S0ne8VhZ+t/FCSpa0+uZd8vDkh+Ml/fdNZ0=; b=lmAhYK0tfFiLN63fTbDhDMea5PN+iFPLnqGL9ZTVxzA0IbbByJior2jQXD9eYxXU0k WFfVHWwjWFGXNy8xy/kKhRd033TAm0h51mAnL3+9V07dq6j+J3iCT41HRG54Us6LkK5+ GS8TCuAkITt5HFdRKjHXNr/dG7yzbMyDF8/98xjde71iTfItVqLto3lIDKR5c+NWrcSH 5rCyA2FOdbGrH+a9zIQeJTWgmM55IdiVR09v0aJMSwBgLvRt8PVd6IBa2rUfRTFdNLIG btLUJi/T73kmJ0hdI+jajUVCpCdw3sDpi/vNzl4AZJzl6LuOKNn2LRH1pO4gKqr6+SOt qpFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmXWu1e3S0ne8VhZ+t/FCSpa0+uZd8vDkh+Ml/fdNZ0=; b=KS0DlSBQFH83EY7e9JjxMDKu3L7UG7Nw2iFtxaEF7oI3PIzILA7sgk5qglQ3lvZstf uQX8TzOS4krjPaHj0qxEncdGagVcGlzpMpDkKaVyV5ZTM5aquJ4StiOtiXJ/5DFfrh1v NRujvs8JaU3udorrdNujqLjRABQFyi912wfQG6MIpw/Ikj8fHnMwLAzACDaLmhIfyhGp FzshUcE3gMErVm+aUTHiu8AA3i3uThn1GtbGop010jJmFhz8JWm2pmS9yFQPqWbkY6Gh Prx3UjvKkJFcq3ny5QG1ZtEumjYf1UpqhMoI3XGBEYC6UxXcYRkYPYzmmS2Rx+rPlpK4 1UKw== X-Gm-Message-State: AFqh2kqwL90grTQuFJ+vvkIiG9EVoiNQ/wimHo7u88a5ZTgH9/4hh0zF lmFH18/sE2zNPMynruhgBJM= X-Google-Smtp-Source: AMrXdXv2q+jBq6/AAgzVvomtd8/Y/4rs66nQmspDgcXCFruRMBDj04m5AoUi1X9xuPDl9FN2OOXxzQ== X-Received: by 2002:a17:903:3111:b0:192:5c3e:894e with SMTP id w17-20020a170903311100b001925c3e894emr31784688plc.16.1672698035817; Mon, 02 Jan 2023 14:20:35 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b14-20020a170902650e00b001868d4600b8sm20712517plk.158.2023.01.02.14.20.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2023 14:20:35 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60503: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes Message-Id: <745379A6-A947-49E3-B03F-59BAC8BA726E@gmail.com> Date: Mon, 2 Jan 2023 14:20:33 -0800 To: Theodor Thornhill X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60503-done Cc: 60503-done@debbugs.gnu.org, dancol@dancol.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Jostein Kj=C3=B8nigsen writes: > >> js-ts-mode does not adhere to the "standardized" features and=20 >> fontification levels requested in emacs-devel. >> >> It's overall pretty good, but I did find one minor inconsistency = which=20 >> annoyed me enough to (IMO) warrant an update: >> >> js-ts-mode does not highlight incoming parameters in=20 >> functions/methods/arrow-expressions as variables. >> >> Attached is a patch which fixes this issue and makes it much more=20 >> consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode. >> > > Looks good to me :-) > > Theo Great! I applied the patch. Yuan From unknown Sat Jun 21 03:12:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 31 Jan 2023 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator