GNU bug report logs - #60489
Programs should exit after EIO from FICLONE or copy_file_range()

Previous Next

Full log

Message #14 received at 60489 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 60489 <at> debbugs.gnu.org, Noah Misch <noah <at> leadboat.com>
Subject: Re: bug#60489: Programs should exit after EIO from FICLONE or
 copy_file_range()
Date: Mon, 2 Jan 2023 16:22:03 +0000

[Message part 1 (text/plain, inline)]

On 02/01/2023 13:28, Andreas Schwab wrote:
> On Jan 02 2023, Pádraig Brady wrote:
> 
>> +          /* Note error set is consistent with copy_file_range().  */
>> +          bool no_clone_attempted = errno == ENOSYS || is_ENOTSUP (errno)
>> +                                    || errno == EINVAL || errno == EBADF
>> +                                    || errno == EXDEV || errno == ETXTBSY;
> 
> Should this be refactored to avoid duplication?

Yes good call.
We should also refactor the handling of clone failure
to also apply to the usage of fclonefileat() on macOS.

Updated patch attached.

cheers,
Pádraig

[copy-clone-fail.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.