GNU bug report logs - #60467
30.0.50; primitive-undo: Changes to be undone by function different from announced

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 60467 <at> debbugs.gnu.org, frederic.giquel <at> laposte.net, yantar92 <at> posteo.net, monnier <at> iro.umontreal.ca, acm <at> muc.de
Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced
Date: Sat, 01 Jul 2023 17:27:52 +0300

> Date: Sat, 01 Jul 2023 14:14:11 +0000
> From: Gregory Heytings <gregory <at> heytings.org>
> cc: 60467 <at> debbugs.gnu.org, frederic.giquel <at> laposte.net, yantar92 <at> posteo.net, 
>     monnier <at> iro.umontreal.ca, acm <at> muc.de
> 
> 
> >> Well, that bug was already discussed at length six months ago, and the 
> >> minimal change that was in the end installed (59c3c53efa) introduced a 
> >> new bug.  Should we design another minimal change, at the risk of 
> >> introducing another bug?  ISTM that the safe thing to do is the 
> >> refactoring that was suggested.
> >
> > If there's no safer way than the refactoring suggested back then, we 
> > will have to stay with this regression in Emacs 29.1 and install a 
> > better fix only on master.  After all, the fact that buffer-modified-p 
> > is not undone is a minor inconvenience at best.
> >
> 
> Indeed.  A safer way probably exists, but I would not dare writing that 
> patch.  I believe Stefan is in a better position to write it.

How about installing your patch, which you proposed back then, on
master, then?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.