GNU bug report logs - #60467
30.0.50; primitive-undo: Changes to be undone by function different from announced

Previous Next

Package: emacs;

Reported by: Ihor Radchenko <yantar92 <at> posteo.net>

Date: Sun, 1 Jan 2023 13:40:01 UTC

Severity: normal

Found in version 30.0.50

Done: Gregory Heytings <gregory <at> heytings.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Frédéric Giquel <frederic.giquel <at> laposte.net>
To: 60467 <at> debbugs.gnu.org
Subject: bug#60467: New problem introduced
Date: Thu, 22 Jun 2023 21:28:44 +0200
Hi all,

I'm reopening this bug because the fix has introduced a new problem.

This can be highlighted with the following procedure (verified with
Emacs 29.0.92) :
1. Open a file: emacs -Q <file>
2. Move point to a line you can comment
3. M-x comment-line
4. M-x undo
5. Check buffer modification status in modeline or use (buffer-
modified-p)

Without the patched version of combine-change-calls-1, the buffer
status is "not modified since last save". Same result if you use
another command, for example kill-line,  at step 2.
With new version of combine-change-calls-1, the buffer is seen as
modified.

I'm not sure but I imagine it has something to do with the lack of
timestamp in buffer-undo-list created by combine-change-calls-1.




This bug report was last modified 1 year and 334 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.