GNU bug report logs - #60464
29.0.60; Regression - pcomplete-arg fails with argument 'last

Previous Next

Full log

Message #98 received at 60464 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jporterbugs <at> gmail.com, gregory <at> heytings.org, 60464 <at> debbugs.gnu.org,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#60464: 29.0.60; Regression - pcomplete-arg fails with
 argument 'last
Date: Wed, 4 Jan 2023 16:22:53 +0100

On 1/4/23 16:18, Eli Zaretskii wrote:
>> Date: Wed, 4 Jan 2023 16:14:14 +0100
>> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,
>>  Jim Porter <jporterbugs <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
>>  60464 <at> debbugs.gnu.org
>> From: Daniel Mendler <mail <at> daniel-mendler.de>
>>
>> Your implementation with the 'last condition doesn't make sense.
> 
> "Doesn't make sense" is a harsh judgment of someone's code, and I have
> hard time believing Gregory's deserves that.  Please try to be kinder
> in how you express your disagreements with someone else's code.

I try to formulate it more fairly. In my opinion Gregory's patches so
far did not fix the issue in a way which is future-proof. The first
prematurely installed patch was obviously broken. The current proposal
introduces an unexpected special casing, where it would be better if the
function behaves uniformly for all arguments.

Daniel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.