GNU bug report logs - #60463
29.0.60; c-ts-mode: M-x align doesn't work

Previous Next

Package: emacs;

Reported by: Mohammed Sadiq <sadiq <at> sadiqpk.org>

Date: Sun, 1 Jan 2023 10:21:02 UTC

Severity: normal

Found in version 29.0.60

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60463: closed (29.0.60; c-ts-mode: M-x align doesn't work)
Date: Sun, 08 Jan 2023 00:57:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 7 Jan 2023 16:55:59 -0800
with message-id <1FD625C8-5EAD-4A3F-93AD-6D63C6771F39 <at> gmail.com>
and subject line Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work
has caused the debbugs.gnu.org bug report #60463,
regarding 29.0.60; c-ts-mode: M-x align doesn't work
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60463: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60463
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; c-ts-mode: M-x align doesn't work
Date: Sun, 01 Jan 2023 15:50:48 +0530
M-x align doesn't align function arguments or struct members, which
works fine in c-mode.

Say for example, if I mark the region around '(' and ')' and do M-x
align for the following code:

int
main (int argc,
      char *argv[])
{
}


I should get the following (see the change of spacing between 'int' and 
'argc'):

int
main (int   argc,
      char *argv[])
{
}


Modifying align-c++-modes to include c-ts-mode should be enough to fix 
this.


[Message part 3 (message/rfc822, inline)]
From: Yuan Fu <casouri <at> gmail.com>
To: Mohammed Sadiq <sadiq <at> sadiqpk.org>
Cc: 60463-done <at> debbugs.gnu.org, 60463 <at> debbugs.gnu.org
Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work
Date: Sat, 7 Jan 2023 16:55:59 -0800
Mohammed Sadiq <sadiq <at> sadiqpk.org> writes:

>>> Modifying align-c++-modes to include c-ts-mode should be enough to
>>> fix
>>> this.
>> Could you go me a favor and look up where is align-c++-modes
>> defined? Or
>> just paste the value of it, if it is programmatically defined. Thanks
>> :-)
>
>
> It's defined in lisp/align.el
>
> Hint: You can do: git grep "align-c++-modes"
>
> There might be other files too where adding c-ts-mode might be helpful.
> A rough match would be something like 'git grep "[( ]c-mode[) ]"' (the
> noise is too high, but files like lisp/progmodes/gud.el looks like a
> positive candidate)

Thanks, no wonder why I can’t find it in cc-xxx.el files :-)

I added ts- modes to both align and gud.

Yuan


This bug report was last modified 2 years and 118 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.