From unknown Tue Jun 17 01:27:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60463 <60463@debbugs.gnu.org> To: bug#60463 <60463@debbugs.gnu.org> Subject: Status: 29.0.60; c-ts-mode: M-x align doesn't work Reply-To: bug#60463 <60463@debbugs.gnu.org> Date: Tue, 17 Jun 2025 08:27:33 +0000 retitle 60463 29.0.60; c-ts-mode: M-x align doesn't work reassign 60463 emacs submitter 60463 Mohammed Sadiq severity 60463 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 05:20:57 2023 Received: (at submit) by debbugs.gnu.org; 1 Jan 2023 10:20:58 +0000 Received: from localhost ([127.0.0.1]:40310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBvSb-0003qI-LD for submit@debbugs.gnu.org; Sun, 01 Jan 2023 05:20:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:60324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBvSa-0003qA-2a for submit@debbugs.gnu.org; Sun, 01 Jan 2023 05:20:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBvSZ-0004vd-RK for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 05:20:55 -0500 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBvSX-00065V-NN for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 05:20:55 -0500 Received: (Authenticated sender: sadiq@sadiqpk.org) by mail.gandi.net (Postfix) with ESMTPA id 018F7100002 for ; Sun, 1 Jan 2023 10:20:48 +0000 (UTC) MIME-Version: 1.0 Date: Sun, 01 Jan 2023 15:50:48 +0530 From: Mohammed Sadiq To: bug-gnu-emacs@gnu.org Subject: 29.0.60; c-ts-mode: M-x align doesn't work Message-ID: <21fcfd1a6555e9bcbb03707b9bc7fba2@sadiqpk.org> X-Sender: sadiq@sadiqpk.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2001:4b98:dc4:8::231; envelope-from=sadiq@sadiqpk.org; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) M-x align doesn't align function arguments or struct members, which works fine in c-mode. Say for example, if I mark the region around '(' and ')' and do M-x align for the following code: int main (int argc, char *argv[]) { } I should get the following (see the change of spacing between 'int' and 'argc'): int main (int argc, char *argv[]) { } Modifying align-c++-modes to include c-ts-mode should be enough to fix this. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 17:44:54 2023 Received: (at 60463) by debbugs.gnu.org; 2 Jan 2023 22:44:54 +0000 Received: from localhost ([127.0.0.1]:44300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCTY6-0006Rd-4z for submit@debbugs.gnu.org; Mon, 02 Jan 2023 17:44:54 -0500 Received: from mail-pl1-f180.google.com ([209.85.214.180]:37451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCTY4-0006RM-Gp for 60463@debbugs.gnu.org; Mon, 02 Jan 2023 17:44:53 -0500 Received: by mail-pl1-f180.google.com with SMTP id m4so30821996pls.4 for <60463@debbugs.gnu.org>; Mon, 02 Jan 2023 14:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=23qSWw4op5TacqKAwLG+cL8laTbV7XpkzPpVY/AfR7A=; b=AEMtz8VIOZOc6A/Rr31Mm8gDJ4/dSPEiPAnCejqsVC8Z5xVkfVSk3TIfarOeYbqUrA 1fHfJjupLCNmv7ZeTTQ3qXETEoymrDa6cZpQI9tWjwfIo586y2IhXf3oLMbE8lGBEPGk VIcza06jCsD6PNH1Kpv5GpudSHvYAN0q84ssqRZ7KJI/diRH8vJ396Q4HwpfjF0npMKZ YwfR9E7wxq88srpC9ckx0Ln+w5UZzJuI7wZhZ7rhyoDcuFriL00bLGXrzo7xufC9oclr e/Ad4iMegR3G9HQ6qjrxMDkvfeTGgg6ZH77TFRCN8Q0WcuURBYW7420Y3cQ1AYUX1yQR SdYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=23qSWw4op5TacqKAwLG+cL8laTbV7XpkzPpVY/AfR7A=; b=vuh4UfDWQ+tITWDTw5X5u5d6bgbvEuuz9PX6fWBp9l2Nwe1AXUnWSc2kpnwFAKKxvi dd7xJJWppL3h1Oh+jgJHzoZlk+bMSxlCuKfm7RMy5/2VS4Xd4rDoc9OjZFc9ph2DhKIf A2UstY3b1jPAi984UodRWjuA4pwuN8z3yhxE/TcYh8Wi/y8UtlszA+/zKFBaZ4hIEe9i jYnjCcI4qy1r+O5lTQ7/b0VRHCapgdgCSz6WYGNXuFio4EwESUM1Gwt7qock6oDnBRRG Gxk3gMyOzYrtfLar6sEA4MhZXWEbUyU2aApIypqPUxuvlUb2FbsQDlh7C+Z4PQ2F5N+l d6jw== X-Gm-Message-State: AFqh2krFeUtK6URxF3GPKIzgekjRqbza9PKl8Zh67MDYF0KxDOwEPoRh lw03ECF/Kdro2gPBpBYTTBKY+VaVZrDRjA== X-Google-Smtp-Source: AMrXdXuLlm/Wt6pp8iuxIkIoMKz90jcpZBhKAPGkWPmgzJfvvFpxXZ6VzyOdG/ZRGvvo036MR3lH7w== X-Received: by 2002:a17:902:c386:b0:192:709b:9a6a with SMTP id g6-20020a170902c38600b00192709b9a6amr30323994plg.65.1672699486788; Mon, 02 Jan 2023 14:44:46 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a14-20020a170902ecce00b0018982bf03b4sm5512096plh.117.2023.01.02.14.44.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2023 14:44:46 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work Message-Id: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> Date: Mon, 2 Jan 2023 14:44:45 -0800 To: Mohammed Sadiq X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60463 Cc: 60463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mohammed Sadiq writes: > M-x align doesn't align function arguments or struct members, which > works fine in c-mode. > > Say for example, if I mark the region around '(' and ')' and do M-x > align for the following code: > > int > main (int argc, > char *argv[]) > { > } > > > I should get the following (see the change of spacing between 'int' > and 'argc'): > > int > main (int argc, > char *argv[]) > { > } > > > Modifying align-c++-modes to include c-ts-mode should be enough to fix > this. Could you go me a favor and look up where is align-c++-modes defined? Or just paste the value of it, if it is programmatically defined. Thanks :-) Yuan From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 04:05:25 2023 Received: (at 60463) by debbugs.gnu.org; 3 Jan 2023 09:05:25 +0000 Received: from localhost ([127.0.0.1]:44713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCdEb-0002GV-3w for submit@debbugs.gnu.org; Tue, 03 Jan 2023 04:05:25 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:52951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCdEY-0002GC-FE for 60463@debbugs.gnu.org; Tue, 03 Jan 2023 04:05:23 -0500 Received: (Authenticated sender: sadiq@sadiqpk.org) by mail.gandi.net (Postfix) with ESMTPA id 16E021BF208; Tue, 3 Jan 2023 09:05:15 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 03 Jan 2023 14:35:15 +0530 From: Mohammed Sadiq To: Yuan Fu Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work In-Reply-To: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> References: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> Message-ID: X-Sender: sadiq@sadiqpk.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60463 Cc: 60463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> >> Modifying align-c++-modes to include c-ts-mode should be enough to fix >> this. > > Could you go me a favor and look up where is align-c++-modes defined? > Or > just paste the value of it, if it is programmatically defined. Thanks > :-) It's defined in lisp/align.el Hint: You can do: git grep "align-c++-modes" There might be other files too where adding c-ts-mode might be helpful. A rough match would be something like 'git grep "[( ]c-mode[) ]"' (the noise is too high, but files like lisp/progmodes/gud.el looks like a positive candidate) cheers, Mohammed Sadiq From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 06:19:19 2023 Received: (at 60463) by debbugs.gnu.org; 3 Jan 2023 11:19:19 +0000 Received: from localhost ([127.0.0.1]:44796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCfKB-0005ar-0a for submit@debbugs.gnu.org; Tue, 03 Jan 2023 06:19:19 -0500 Received: from mail-oa1-f48.google.com ([209.85.160.48]:36861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCfK9-0005af-LK for 60463@debbugs.gnu.org; Tue, 03 Jan 2023 06:19:18 -0500 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-14ffd3c5b15so24876274fac.3 for <60463@debbugs.gnu.org>; Tue, 03 Jan 2023 03:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=kfb1uy0q9wWiB2abXL3xmRceDY2Si7WH4mAdj+Q9ufs=; b=dfSNzaAEGsaAK1HGnmMDutBDD3EzJEumvNkqgczMEbG0sn3XqOTC0mwc2dsUpRlhYY DY4apoX5scshg+tjs+fij6kjj9BvCkgrcHagIGAOxJEcttkKL6fTVmhOsQgcyb82Qy6O IFdXZ1obKwcLSGd07pgtDQh5YlKmwoEdk85NLQKJSKJxCUa3loaudx0tC0+wCZEIpu5Y zfsCsIlPwN1owbTPM7Nd4WfEF25ScF1+1gyF6EGgmmKd+/FWh7GBw3W2nIG7yURXdXX6 aWpG1ujpgGR/s0bUNXEyhD0xQS2tMVkF3JzakgUTyuNOPkcwo3pKjJPG0bNAxLrScbW5 GonQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kfb1uy0q9wWiB2abXL3xmRceDY2Si7WH4mAdj+Q9ufs=; b=xkfoUF+gohoriYSa6rcXtBVyeEVCCnZh0EE+Inn1pDMOPWrOpSel/oMrxi6arkQ07E DuKUjkaQNDUtN2OXOkmF+oZR/ANYRYtOjnzgDLBY62hHsRaq8kBq9OJevyam9hMH58G3 MPgPVX9WsAhnMXYJ9vNfLXt95LekJAnsCjJw5AaQtpxqgGAh6V3rLjSWzy33v6K3hs9S ZGpvNKK3uY8snorPMLDiOYl+HT7RXOc3ETS6x6qdBoZv8XGjUMtiqrFMITou9qhXccvy KoxeGJiVZukYuvwswnND/RopTqxS8wIW7YIPNV8d1ZVBBlSeJEe9gTbYldg3p2qDqvR+ XFdQ== X-Gm-Message-State: AFqh2koSXGcluwVd3kG56LoYKIBnmZMJWnxwz1BuQP6O8S7Wxi5/c6xd TtQta7QquApslD9kTxbBnOQcEaHN06Ibj5W9ck8= X-Google-Smtp-Source: AMrXdXsEXGdt4Aajp+JLoSWrCK4TWvPadrnQANZ+SVTTYdN9nt6lY+Ka/8uAPYdR+VOFMROX3U5ZuD0m+DWxUOpZeIA= X-Received: by 2002:a05:6870:9f86:b0:14c:667e:4620 with SMTP id xm6-20020a0568709f8600b0014c667e4620mr1965726oab.92.1672744750576; Tue, 03 Jan 2023 03:19:10 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 3 Jan 2023 11:19:10 +0000 From: Stefan Kangas In-Reply-To: References: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> X-Hashcash: 1:20:230103:60463@debbugs.gnu.org::xM85cZbzTuG+H/aB:BDfj MIME-Version: 1.0 Date: Tue, 3 Jan 2023 11:19:09 +0000 Message-ID: Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work To: Mohammed Sadiq , Yuan Fu Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60463 Cc: 60463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mohammed Sadiq writes: > Hint: You can do: git grep "align-c++-modes" I like `C-x p g' or `M-x rgrep'. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 07:53:37 2023 Received: (at 60463) by debbugs.gnu.org; 3 Jan 2023 12:53:37 +0000 Received: from localhost ([127.0.0.1]:44913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCgnQ-0004XW-N5 for submit@debbugs.gnu.org; Tue, 03 Jan 2023 07:53:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCgnO-0004X2-CU for 60463@debbugs.gnu.org; Tue, 03 Jan 2023 07:53:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCgnI-0006Uy-Fh; Tue, 03 Jan 2023 07:53:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QRLcuFfSsznSgflODPwpXAl0ozRHux4WiD+iujSJFuc=; b=oKwnWP+UcOOQ JElMDwNppyGH1K8gdm4OzmsWunZQQWvWIIhnsfrGN5U5zSbsvFgCP98q5dm4J2Fj77nJXbcKyRSng GYcBYk66musoKlWKuqYQh02dC9qa4N44TsR6HRrCCGbCDy7DvT3FeLVarn98FrJXR2fmt7SIgJL+w uzJcGYiUOuvMI5p4yi1fvRRPqNQAOIXLJDRy/H6l9E06OSCw/bbRvvSq0bXtrhWxjEb6u0tR/QOGo DyNkpWS0BZDQ3cmjX4a3O6wGSQGYgIOSecPG9Syy+xjLBfTNmGc/Kt33hsbLpuDAUGfCUOnUAPeIt 1S33Atr9sIHlLDDuFbCTZw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCgnH-0006hS-V2; Tue, 03 Jan 2023 07:53:28 -0500 Date: Tue, 03 Jan 2023 14:53:38 +0200 Message-Id: <835ydn22zx.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 3 Jan 2023 11:19:09 +0000) Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work References: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60463 Cc: sadiq@sadiqpk.org, 60463@debbugs.gnu.org, casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 60463@debbugs.gnu.org > From: Stefan Kangas > Date: Tue, 3 Jan 2023 11:19:09 +0000 > > Mohammed Sadiq writes: > > > Hint: You can do: git grep "align-c++-modes" > > I like `C-x p g' or `M-x rgrep'. You are kidding, right? I expected to hear you like M-. instead (after "M-x xref-etags-mode RET"). That's the right tool in Emacs to look for an identifier's definition. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 10:53:56 2023 Received: (at 60463) by debbugs.gnu.org; 3 Jan 2023 15:53:56 +0000 Received: from localhost ([127.0.0.1]:46527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCjbw-0001Mw-6o for submit@debbugs.gnu.org; Tue, 03 Jan 2023 10:53:56 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:37377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCjbu-0001Mj-Ey for 60463@debbugs.gnu.org; Tue, 03 Jan 2023 10:53:54 -0500 Received: by mail-ot1-f43.google.com with SMTP id y18-20020a0568301d9200b0067082cd4679so19315949oti.4 for <60463@debbugs.gnu.org>; Tue, 03 Jan 2023 07:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=71bxtFg0yddVL1Bym/kMSP+pbeu8UwrIaHQG8CXeo8w=; b=iX+ZgKK/IEMKYse3iaBO5NccvXCCKs7wfn02wBp2S8kxfSFhYt7dxNhOmaBCaiYsOL +GPVOwo/q5GkUS6LUO2dTDAQezb6QIjND1IJFox62lUciLHpve/WQBDnpE//c3MgGMXJ Q0aSyAHKGtvF4iHCCqORAMoSv3NBJzx1aXW5lJyAMJd+BWvRPm/+wxXtiKSysQitbXyS oPvCIwf2nG3FzepwbEm2/SOFVdDk4zU1dl8xNVssGtBgCgF95Go/ZrcwYvyyWxhRdEAc 19RSH2ZKdpGf0ewNq67hZuiqZtmBofsME6Xjl+UNnjJfFU+N9cbiC8TVrZXtXRMjXzww QL8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=71bxtFg0yddVL1Bym/kMSP+pbeu8UwrIaHQG8CXeo8w=; b=MLlEh1+PEfcrGBLNg63ZVX5HpjCcI8KtgDrEWmyLcu8c5kEUy+1e3fIsZOiyCrsVr7 CUMOqZuTnOx+sQKS0bxVXHSXIgMVTXaim3VVBRZzVu3CPQMLh9tWxP6M1RKvQili/20i 9IcCA/zyCzgLiKYkJ3U6pylI6sH8UJ7N9Nxtz7fKQqwQlKqONl0omdeOaJBY5tW+FRSm c0J1gwreoVgburkhgifOqj8NkMnJvDrm7fVjEOgweQoUHy0LO5rcNv+oqkhO2GCBpvP4 qQDsVx/zlY1oOCg9z9BSVPoA8LpZ3Iq163WwLDEpViyes3Tg3p6jsp+2fd+iXaxdGNbx giVw== X-Gm-Message-State: AFqh2kq6jBpiNUZtt/oL4FhX0+Pl+69T20I2c8y7Z2Fh0RAOAeiey7U1 MmpUzv39H+LRv0HYE41dOe07iD0vCtQj52UpaQs= X-Google-Smtp-Source: AMrXdXs8P/F0575nGJcNe/YkydneHRg+uVsfC/r5HigypENi4x0rOQ8/tHhZIj6nFYPlfkxOSZVDPyK4dllr2oi9qtY= X-Received: by 2002:a05:6830:144e:b0:66e:f6cb:cb4e with SMTP id w14-20020a056830144e00b0066ef6cbcb4emr2801061otp.105.1672761228772; Tue, 03 Jan 2023 07:53:48 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 3 Jan 2023 15:53:48 +0000 From: Stefan Kangas In-Reply-To: <835ydn22zx.fsf@gnu.org> References: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> <835ydn22zx.fsf@gnu.org> X-Hashcash: 1:20:230103:60463@debbugs.gnu.org::3dgLbff45dlg6bs+:B6n2 MIME-Version: 1.0 Date: Tue, 3 Jan 2023 15:53:48 +0000 Message-ID: Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60463 Cc: sadiq@sadiqpk.org, 60463@debbugs.gnu.org, casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I expected to hear you like M-. instead (after "M-x xref-etags-mode > RET"). That's the right tool in Emacs to look for an identifier's > definition. I use that too, of course. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 07 19:56:08 2023 Received: (at 60463) by debbugs.gnu.org; 8 Jan 2023 00:56:08 +0000 Received: from localhost ([127.0.0.1]:59371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEJyp-0002jH-SC for submit@debbugs.gnu.org; Sat, 07 Jan 2023 19:56:08 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:39835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEJyo-0002iq-NZ; Sat, 07 Jan 2023 19:56:07 -0500 Received: by mail-pj1-f52.google.com with SMTP id o8-20020a17090a9f8800b00223de0364beso9123102pjp.4; Sat, 07 Jan 2023 16:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=RVQfAflSeV0jLvp3nC8v+VI54+jYUX9ZZQiArh/pigw=; b=MtaZ5p2CaXlMKclZlUUOPRPpM9Mwz+qs5VRKg+gK5IIAWefFbx4fgdZznxk+FtFQTv aoYivGjHKu7/4yr1KEliLfaieySH9sWuPFxVwju5kkHauHsY6584eeDUUxXg3lXCoPnv oiAWF62YJ6of95auEn/VwoaRVIA5hCxqdkkU4FLYzuFwHXYZCc85EwnKt3maFc2kDIXR bOWly5LAH8ds7tYi5tpIQO1fgafj38R86FOOCLNssS0I6vdFkI3x4pN0NqV8Y1qzGRdp V+t8RJe95ScNloP2iSCACIDBtIhl2SycHcqDNCwd93kUJwsKDYzByBg0y/+hUcTj1DB+ ao2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RVQfAflSeV0jLvp3nC8v+VI54+jYUX9ZZQiArh/pigw=; b=RYY2XhgYaxNM6FN6Yg82BEqzwnfG6VHWrUzHuxKq9WTfnKL/z0Nx9Yt2blCAU+4tsQ HTC2tn3LffdbPWTB7BTFrj/BMzO9p1voNb8AC4b4WDjmxud0KH1BoRQNEWsu7aEdzcsj 0iURsLbL2O3uWAYpszOPSgnB2Sg5A6uRXfwy3CyFk8MxO/EYNb1SArOJivbK8wrkn3h0 kpOXO5jrGdumLPpghGaUFJXukQcCM/OuYFJoDsdvAryQppvBi8mj/6gO+VXNCgwScnYn lZcgIMyzHaQSPqM+B6WeqSm02do0o05tXFm3xbbWr9rWACs6BgoDP+xO8whX9kmOXJyJ yV8A== X-Gm-Message-State: AFqh2kpqIBDuY8Tev1WIFjKY0pzn1+ZBxibr6jyAUiM1eFyrG9Oq4Tku 2IQdgtV05FCkNCo8czHXmEk= X-Google-Smtp-Source: AMrXdXvtb411uP9xADDze3PI3UCAxBCKXkR2UwXmpwbtFrswkdS/uGYGNv8bub6VBpno0bdLPFKl6g== X-Received: by 2002:a17:902:7c90:b0:189:e91b:c18 with SMTP id y16-20020a1709027c9000b00189e91b0c18mr60312597pll.32.1673139360968; Sat, 07 Jan 2023 16:56:00 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o3-20020a170902d4c300b001886ff822ffsm3292752plg.186.2023.01.07.16.56.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jan 2023 16:56:00 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work Message-Id: <1FD625C8-5EAD-4A3F-93AD-6D63C6771F39@gmail.com> Date: Sat, 7 Jan 2023 16:55:59 -0800 To: Mohammed Sadiq X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60463 Cc: 60463-done@debbugs.gnu.org, 60463@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mohammed Sadiq writes: >>> Modifying align-c++-modes to include c-ts-mode should be enough to >>> fix >>> this. >> Could you go me a favor and look up where is align-c++-modes >> defined? Or >> just paste the value of it, if it is programmatically defined. Thanks >> :-) > > > It's defined in lisp/align.el > > Hint: You can do: git grep "align-c++-modes" > > There might be other files too where adding c-ts-mode might be = helpful. > A rough match would be something like 'git grep "[( ]c-mode[) ]"' (the > noise is too high, but files like lisp/progmodes/gud.el looks like a > positive candidate) Thanks, no wonder why I can=E2=80=99t find it in cc-xxx.el files :-) I added ts- modes to both align and gud. Yuan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 04:22:43 2023 Received: (at 60463) by debbugs.gnu.org; 19 Jan 2023 09:22:43 +0000 Received: from localhost ([127.0.0.1]:42610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIR87-0001Qz-51 for submit@debbugs.gnu.org; Thu, 19 Jan 2023 04:22:43 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:39325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIR84-0001Qj-AC for 60463@debbugs.gnu.org; Thu, 19 Jan 2023 04:22:41 -0500 Received: (Authenticated sender: sadiq@sadiqpk.org) by mail.gandi.net (Postfix) with ESMTPA id 022A020005 for <60463@debbugs.gnu.org>; Thu, 19 Jan 2023 09:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sadiqpk.org; s=gm1; t=1674120154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZVrkZlcYk6uNxN6swzzyiPr+2zNGwuDsEuJd9QBh+fQ=; b=InqJLcTx1p5fWRO0DhEx2gCFet8EE0EqBIhFWmdpH9BZFo+2JZ59TnJRIZ92q7LoUe4+w6 ojHl5LWRTZUqvnIkllu2QVXewCCKrJY/ZvJqplw25S5GFXJe7erURgz515tvHw4lGlD4Gd FbPOXb0pD5zOMPx9Z8iiZvUnrVtvoV7RvIRm7SRKa2rGKLPD6UllqWIjLDG/fic70a+13r Bzeg6VQihPkg9NaJiWVFh4DPau95u8Wg9qFO+tVKxGd7rwRL6WFiF+Nd6TjOIF8pojAK7h yXDAA7Opt1F1E0QoiZLmRaGhsP7QHKStHCilbMlIIqi6bV4qe5TKOlgGGbVAsg== MIME-Version: 1.0 Date: Thu, 19 Jan 2023 14:52:33 +0530 From: Mohammed Sadiq To: 60463@debbugs.gnu.org Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work In-Reply-To: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> References: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> Message-ID: X-Sender: sadiq@sadiqpk.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60463 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This now seems to work perfectly in interactive use. Though align.el has a defun call `(c-guess-basic-syntax)` which seems to break elisp scripts, it may have to be adapted to work with c-ts-mode. Since we don't have to guess the syntax of the buffer, may be we can hardcode the syntax for the buffer depending on the ts-mode used. I hope it won't be hard to do so cheers, Mohammed Sadiq From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 22 03:46:43 2023 Received: (at 60463) by debbugs.gnu.org; 22 Jan 2023 08:46:43 +0000 Received: from localhost ([127.0.0.1]:50653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJVzv-0004UD-7q for submit@debbugs.gnu.org; Sun, 22 Jan 2023 03:46:43 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJVzs-0004Tv-Kz for 60463@debbugs.gnu.org; Sun, 22 Jan 2023 03:46:41 -0500 Received: (Authenticated sender: sadiq@sadiqpk.org) by mail.gandi.net (Postfix) with ESMTPA id E3B90E0003 for <60463@debbugs.gnu.org>; Sun, 22 Jan 2023 08:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sadiqpk.org; s=gm1; t=1674377194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4/vIqAWSX6vYEED+Z9t2nukGDKMy+Iug/xmpATMeDtY=; b=DVEhkB+phnHKTxDBk4chErNN/KsOauvkEBaemO4At3mo4kjDUWPlwHrn6aexiSjy1uHEvc mkjZX9sEtodyzX65TtSDeOPtZYIYsm20IkGPQ7p0dq8EZiXxGU4wIgvK18bdlIpxPLbmsa Cp/92tgrQ0zGmZYZItGYEmAOoRFsRF/aJ4JwAz984CfXTfXAQ7H72+Ie4p/J579Y8idY8j vvom5kQEiZ9zx4rG/FPjWCoN/5Nf7B1o7Z7Cgf4LHqHVUiRUeryjrlxiG6rtmZk7TqMTom Tm/DjviqgqS9PC+UWItA+FmMd2bM5wS6sozNvLK5ybVlDGWaNTZOnq1CD4DY3g== MIME-Version: 1.0 Date: Sun, 22 Jan 2023 14:16:31 +0530 From: Mohammed Sadiq To: 60463@debbugs.gnu.org Subject: Re: bug#60463: 29.0.60; c-ts-mode: M-x align doesn't work In-Reply-To: References: <9ECF22EB-D2FB-4697-A1DB-15F0AF3BF3B2@gmail.com> Message-ID: <78fa4e9486dc13bd542ed8fcb9a624e0@sadiqpk.org> X-Sender: sadiq@sadiqpk.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60463 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Minimal example to reproduce the said issue (save to test.el): (let ((buffer (generate-new-buffer "temp.c"))) (with-current-buffer buffer (c-ts-mode) (insert "int main (int argc,\nchar *argv[])") (align (point-min) (point-max)))) Execute the file with: emacs -Q -batch -l test.el Error log: Error: wrong-type-argument (stringp nil) mapbacktrace(#f(compiled-function (evald func args flags) #)) debug-early-backtrace() debug-early(error (wrong-type-argument stringp nil)) looking-at(nil) c-guess-basic-syntax() #f(compiled-function () #)() align-region(1 34 "^\\s-*[{}]?\\s-*$" ((lisp-second-arg (regexp . "\\(^\\s-+[^( \11\n]\\|(\\(\\S-+\\)\\s-+\\)\\S-+\\(\\s-+\\)") (group . 3) (modes . align-lisp-modes) (run-if . #f(compiled-function () #))) (lisp-alist-dot (regexp . "\\(\\s-*\\)\\.\\(\\s-*\\)") (group 1 2) (modes . align-lisp-modes)) (open-comment (regexp . #f(compiled-function (end reverse) #)) (modes . align-open-comment-modes)) (c-macro-definition (regexp . "^\\s-*#\\s-*define\\s-+\\S-+\\(\\s-+\\)") (modes . align-c++-modes)) (c-variable-declaration (regexp . "[*&0-9A-Za-z_]>?[][&*]*\\(\\s-+[*&]*\\)[A-Za-z_][][0-9A-Za-z:_]*\\s-*\\(\\()\\|=[^=\n].*\\|(.*)\\|\\(\\[.*\\]\\)*\\)\\s-*[;,]\\|)\\s-*$\\)") (group . 1) (modes . align-c++-modes) (justify . t) (valid . #f(compiled-function () #))) (c-assignment (regexp . "[^-=!^&*+<>/| \11\n]\\(\\s-*[-=!^&*+<>/|]*\\)=\\(\\s-*\\)\\([^= \11\n]\\|$\\)") (group 1 2) (modes . align-c++-modes) (justify . t) (tab-stop)) (perl-assignment (regexp . "[^=!^&*+<>/| \11\n-]\\(\\s-*\\)=[~>]?\\(\\s-*\\)\\([^>= \11\n]\\|$\\)") (group 1 2) (modes . align-perl-modes) (tab-stop)) (python-assignment (regexp . "[^=!<> \11\n]\\(\\s-*\\)=\\(\\s-*\\)\\([^>= \11\n]\\|$\\)") (group 1 2) (modes quote (python-mode)) (tab-stop)) (make-assignment (regexp . "^\\s-*\\w+\\(\\s-*\\):?=\\(\\s-*\\)\\([^\11\n \\]\\|$\\)") (group 1 2) (modes quote (makefile-mode)) (tab-stop)) (c-comma-delimiter (regexp . ",\\(\\s-*\\)[^/ \11\n]") (repeat . t) (modes . align-c++-modes) (run-if . #f(compiled-function () #))) (basic-comma-delimiter (regexp . ",\\(\\s-*\\)[^# \11\n]") (repeat . t) (modes append align-perl-modes '(python-mode)) (run-if . #f(compiled-function () #))) (c++-comment (regexp . "\\(\\s-*\\)\\(//.*\\|/\\*.*\\*/\\s-*\\)$") (modes . align-c++-modes) (column . comment-column) (valid . #f(compiled-function () #))) (c-chain-logic (regexp . "\\(\\s-*\\)\\(&&\\|||\\|\\\\|\\\\)") (modes . align-c++-modes) (valid . #f(compiled-function () #))) (perl-chain-logic (regexp . "\\(\\s-*\\)\\(&&\\|||\\|\\\\|\\\\)") (modes . align-perl-modes) (valid . #f(compiled-function () #))) (python-chain-logic (regexp . "\\(\\s-*\\)\\(\\\\|\\\\)") (modes quote (python-mode)) (valid . #f(compiled-function () #))) (c-macro-line-continuation (regexp . "\\(\\s-*\\)\\\\$") (modes . align-c++-modes) (column . c-backslash-column)) (basic-line-continuation (regexp . "\\(\\s-*\\)\\\\$") (modes quote (python-mode makefile-mode))) (tex-record-separator (regexp . #f(compiled-function (end reverse) #)) (group 1 2) (modes . align-tex-modes) (repeat . t)) (tex-tabbing-separator (regexp . #f(compiled-function (end reverse) #)) (group 1 2) (modes . align-tex-modes) (repeat . t) (run-if . #f(compiled-function () #))) (tex-record-break (regexp . "\\(\\s-*\\)\\\\\\\\") (modes . align-tex-modes)) (text-column (regexp . "\\(^\\|\\S-\\)\\([ \11]+\\)\\(\\S-\\|$\\)") (group . 2) (modes . align-text-modes) (repeat . t) (run-if . #f(compiled-function () #))) (text-dollar-figure (regexp . "\\$?\\(\\s-+[0-9]+\\)\\.") (modes . align-text-modes) (justify . t) (run-if . #f(compiled-function () #))) (css-declaration (regexp . "^\\s-*\\(?:\\w-?\\)+:\\(\\s-*\\).*;") (group 1) (modes quote (css-mode html-mode)))) ((exc-dq-string (regexp . "\"\\([^\"\n]+\\)\"") (repeat . t) (modes . align-dq-string-modes)) (exc-sq-string (regexp . "'\\([^'\n]+\\)'") (repeat . t) (modes . align-sq-string-modes)) (exc-open-comment (regexp . #f(compiled-function (end reverse) #)) (modes . align-open-comment-modes)) (exc-c-comment (regexp . "/\\*\\(.+\\)\\*/") (repeat . t) (modes . align-c++-modes)) (exc-c-func-params (regexp . "(\\([^)\n]+\\))") (repeat . t) (modes . align-c++-modes)) (exc-c-macro (regexp . "^\\s-*#\\s-*\\(if\\w*\\|endif\\)\\(.*\\)$") (group . 2) (modes . align-c++-modes)))) align(1 34) (save-current-buffer (set-buffer buffer) (c-ts-mode) (insert "int main (int argc,\nchar *argv[])") (align (point-min) (point-max))) (let ((buffer (generate-new-buffer "temp.c"))) (save-current-buffer (set-buffer buffer) (c-ts-mode) (insert "int main (int argc,\nchar *argv[])") (align (point-min) (point-max)))) eval-buffer(# nil "/home/sadiq/test.el" nil t) load-with-code-conversion("/home/sadiq/test.el" "/home/sadiq/test.el" nil t) load("/home/sadiq/test.el" nil t) command-line-1(("-l" "test.el")) command-line() normal-top-level() Wrong type argument: stringp, nil From unknown Tue Jun 17 01:27:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Feb 2023 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator