GNU bug report logs - #60441
[PATCH] Fontification of function declarators with reference return types is incorrect in c++-ts-mode

Previous Next

Package: emacs;

Reported by: Daniel Martín <mardani29 <at> yahoo.es>

Date: Sat, 31 Dec 2022 00:52:02 UTC

Severity: normal

Tags: patch

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60441 in the body.
You can then email your comments to 60441 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#60441; Package emacs. (Sat, 31 Dec 2022 00:52:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Daniel Martín <mardani29 <at> yahoo.es>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 31 Dec 2022 00:52:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fontification of function declarators with reference return
 types is incorrect in c++-ts-mode
Date: Sat, 31 Dec 2022 01:51:02 +0100
[Message part 1 (text/plain, inline)]
Given the following valid C++ code:

class Foo {
public:
        Bar& getBar();
};

c++-ts-mode does not fontify getBar with the
font-lock-function-name-face face.

I've attached a fix to treat reference declarators in
c-ts-mode--declarator-identifier similarly to pointer_declarators.

[0001-Fix-fontification-of-C-functions-with-reference-retu.patch (text/x-patch, attachment)]

Reply sent to Yuan Fu <casouri <at> gmail.com>:
You have taken responsibility. (Mon, 02 Jan 2023 00:27:01 GMT) Full text and rfc822 format available.

Notification sent to Daniel Martín <mardani29 <at> yahoo.es>:
bug acknowledged by developer. (Mon, 02 Jan 2023 00:27:01 GMT) Full text and rfc822 format available.

Message #10 received at 60441-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: 60441-done <at> debbugs.gnu.org
Subject: Re: bug#60441: [PATCH] Fontification of function declarators with 
 reference return types is incorrect in c++-ts-mode
Date: Sun, 1 Jan 2023 16:26:14 -0800
Daniel Martín <mardani29 <at> yahoo.es> writes:

> Given the following valid C++ code:
>
> class Foo {
> public:
>         Bar& getBar();
> };
>
> c++-ts-mode does not fontify getBar with the
> font-lock-function-name-face face.
>
> I've attached a fix to treat reference declarators in
> c-ts-mode--declarator-identifier similarly to pointer_declarators.

Applied, thanks!

Yuan




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 30 Jan 2023 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 136 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.