From unknown Sun Jun 22 07:56:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60430] [PATCH] gnu: icu4c: Update packaging style. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Dec 2022 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60430 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60430@debbugs.gnu.org Cc: ngraves@ngraves.fr X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16724165732913 (code B ref -1); Fri, 30 Dec 2022 16:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Dec 2022 16:09:33 +0000 Received: from localhost ([127.0.0.1]:35984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBHwn-0000ks-GE for submit@debbugs.gnu.org; Fri, 30 Dec 2022 11:09:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:34322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBHwl-0000kj-Cc for submit@debbugs.gnu.org; Fri, 30 Dec 2022 11:09:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHwl-0002UO-3Y for guix-patches@gnu.org; Fri, 30 Dec 2022 11:09:27 -0500 Received: from 8.mo550.mail-out.ovh.net ([178.33.110.239]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHwi-0007Sj-Qw for guix-patches@gnu.org; Fri, 30 Dec 2022 11:09:26 -0500 Received: from director10.ghost.mail-out.ovh.net (unknown [10.109.146.19]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 250AC238D2 for ; Fri, 30 Dec 2022 16:09:10 +0000 (UTC) Received: from ghost-submission-747dc469fd-pvbcd (unknown [10.110.208.248]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 4E6E81FEAD; Fri, 30 Dec 2022 16:09:09 +0000 (UTC) Received: from ngraves.fr ([37.59.142.102]) by ghost-submission-747dc469fd-pvbcd with ESMTPSA id 8Kg7FCUNr2N7JwEAUY42lw (envelope-from ); Fri, 30 Dec 2022 16:09:09 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-102R0045a4d7a7b-0cb2-4fee-96cf-953fb0eac1c5, D6AF47B0F5163561D05A5CA4A1CFB5D3A7562A97) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 80.215.85.90 From: Nicolas Graves Date: Fri, 30 Dec 2022 17:09:00 +0100 Message-Id: <20221230160900.28075-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 947444775557849826 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrieeigdekgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeekffegteffgfffjeegjedvfffgtddvueeutefgfeeuvdejgedvgeejjeevueeuveenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth Received-SPF: pass client-ip=178.33.110.239; envelope-from=ngraves@ngraves.fr; helo=8.mo550.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/icu4c.scm (icu4c): Update packaging style. --- gnu/packages/icu4c.scm | 66 ++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm index 1e4f66d956..1338c8f525 100644 --- a/gnu/packages/icu4c.scm +++ b/gnu/packages/icu4c.scm @@ -63,41 +63,39 @@ (define-public icu4c (inputs (list perl)) (arguments - `(#:configure-flags - (list + (list + #:configure-flags + `(list "--enable-rpath" - ,@(if (%current-target-system) - '((string-append "--with-cross-build=" - (assoc-ref %build-inputs "icu4c-build-root"))) - '())) - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'chdir-to-source - (lambda _ (chdir "source") #t)) - (add-after 'chdir-to-source 'update-LDFLAGS - (lambda _ - ;; Do not create a "data-only" libicudata.so because it causes - ;; problems on some architectures (notably armhf and MIPS). - (substitute* "config/mh-linux" - (("LDFLAGSICUDT=-nodefaultlibs -nostdlib") - "LDFLAGSICUDT=")) - #t)) - ,@(if (target-riscv64?) - `((add-after 'unpack 'disable-failing-test - ;; It is unknown why this test is failing. - (lambda _ - (substitute* "source/test/intltest/numbertest_api.cpp" - (("(TESTCASE_AUTO\\(unitUsage\\));" all) - (string-append "//" all)))))) - '()) - (add-after 'install 'avoid-coreutils-reference - ;; Don't keep a reference to the build tools. - (lambda* (#:key outputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out"))) - (substitute* (find-files (string-append out "/lib/icu") - "\\.inc$") - (("INSTALL_CMD=.*/bin/install") "INSTALL_CMD=install")) - #t)))))) + ,@(if (%current-target-system) + '((string-append "--with-cross-build=" + (assoc-ref %build-inputs "icu4c-build-root"))) + '())) + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'chdir-to-source + (lambda _ (chdir "source"))) + (add-after 'chdir-to-source 'update-LDFLAGS + (lambda _ + ;; Do not create a "data-only" libicudata.so because it causes + ;; problems on some architectures (notably armhf and MIPS). + (substitute* "config/mh-linux" + (("LDFLAGSICUDT=-nodefaultlibs -nostdlib") + "LDFLAGSICUDT=")))) + #$@(if (target-riscv64?) + `((add-after 'unpack 'disable-failing-test + ;; It is unknown why this test is failing. + (lambda _ + (substitute* "source/test/intltest/numbertest_api.cpp" + (("(TESTCASE_AUTO\\(unitUsage\\));" all) + (string-append "//" all)))))) + '()) + (add-after 'install 'avoid-coreutils-reference + ;; Don't keep a reference to the build tools. + (lambda _ + (substitute* (find-files (string-append #$output "/lib/icu") + "\\.inc$") + (("INSTALL_CMD=.*/bin/install") "INSTALL_CMD=install"))))))) (synopsis "International Components for Unicode") (description "ICU is a set of C/C++ and Java libraries providing Unicode and -- 2.38.1 From unknown Sun Jun 22 07:56:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60430] [PATCH] gnu: icu4c: Update packaging style. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Mar 2023 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60430 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 60430@debbugs.gnu.org, GNU Debbugs Received: via spool by 60430-submit@debbugs.gnu.org id=B60430.16794119922929 (code B ref 60430); Tue, 21 Mar 2023 15:20:02 +0000 Received: (at 60430) by debbugs.gnu.org; 21 Mar 2023 15:19:52 +0000 Received: from localhost ([127.0.0.1]:60235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pedmB-0000l6-Q2 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 11:19:52 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:36403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pedm9-0000kn-Ai; Tue, 21 Mar 2023 11:19:49 -0400 Received: by mail-qt1-f179.google.com with SMTP id hf2so14091181qtb.3; Tue, 21 Mar 2023 08:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679411983; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=IekRyNqwlDCUFbVg4Tacs1CaKQge9qJWHGAgNOpIrYc=; b=IWSS4v0u4+60MxbSIaR42KvohqPJvqvmPpyvn2lcEW0Ft5JkwveWdOOQbN1d+wQVpq xrqBa7Ddluav9l9qEZ+cqDdr1kvVliZ6WJFd8Rn7m9KKgNW9f44ODRB2b6elTVmTDMqR VfuISEIYHT9L0OvS4KicLgAW9/OiknmZuOCPpARSTwZcKITjImRz5x8LLxe5tLwjAGs7 oulZidKkJYS/w6W7QNfKhQW2tbnkOPqxHEoQeV6Jcq7HsEld4H5XH4WTv21qSDmpTWEj jtyqVHcHrzJJeM5kM49Abue3FpGoQhxQkukkjN8R6z71JJ1Q482tOn9+AlEUD3W+8Ogn RSyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679411983; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IekRyNqwlDCUFbVg4Tacs1CaKQge9qJWHGAgNOpIrYc=; b=gecak14SJh5TVRsOd/fLcbdqzivly4yhIzJYjP2JurEK6tee+fU+0wXFXzo/vjgSBK UiA6yJBlOmWP4RFp75Y4GP6MSdGovxa0u5sy7Xkv1aCBKLErKB7YbJZksTB6BaIPqrRk MuxHoxYhTpwoxLSou1uXvVefdPtA4dr21bEt5g6bzQHOiKMdnrFIf+YUN/TPUXj15NSW 32O/wxX6IZryRkZq4BjSc8m6+Yq+O6xNfKZhI+WWH2agCWLhg7Q1KmsmeMRXESA75VhB LNxbIamksUOkf2HKS0gVT7WTgQHQwU/9k4+1VMlvBcv/c61r9VlK+pggB4qsnGPJYRCt dZJQ== X-Gm-Message-State: AO0yUKW4uo/hRqCqpjwWkSqEnjQDuW69NAq+8vy8VxP0/IgNaNjApMYt Cmf9I4KYzhYJ9RVK2kmS/AzMpVt19UwWMw== X-Google-Smtp-Source: AK7set+opxSPuvBlgmTsYYPESTCbjZp4gjNRkr3mAneUJnw1NGhASXTLzd2a4bkLEo1pUMUY/DMvBQ== X-Received: by 2002:a05:622a:452:b0:3e3:8727:174f with SMTP id o18-20020a05622a045200b003e38727174fmr250424qtx.41.1679411983341; Tue, 21 Mar 2023 08:19:43 -0700 (PDT) Received: from hurd ([2607:fad8:4:3::1004]) by smtp.gmail.com with ESMTPSA id d18-20020ac86692000000b003e386bb1566sm548590qtp.31.2023.03.21.08.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 08:19:43 -0700 (PDT) From: Maxim Cournoyer References: <20221230160900.28075-1-ngraves@ngraves.fr> Date: Tue, 21 Mar 2023 11:19:41 -0400 In-Reply-To: <20221230160900.28075-1-ngraves@ngraves.fr> (Nicolas Graves's message of "Fri, 30 Dec 2022 17:09:00 +0100") Message-ID: <87jzzap1wy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 60430 [PATCH core-updates] gnu: icu4c: Update packaging style. quit Hello! Nicolas Graves writes: > * gnu/packages/icu4c.scm (icu4c): Update packaging style. > --- > gnu/packages/icu4c.scm | 66 ++++++++++++++++++++---------------------- > 1 file changed, 32 insertions(+), 34 deletions(-) > > diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm > index 1e4f66d956..1338c8f525 100644 > --- a/gnu/packages/icu4c.scm > +++ b/gnu/packages/icu4c.scm > @@ -63,41 +63,39 @@ (define-public icu4c > (inputs > (list perl)) > (arguments > - `(#:configure-flags > - (list > + (list > + #:configure-flags > + `(list > "--enable-rpath" > - ,@(if (%current-target-system) > - '((string-append "--with-cross-build=" > - (assoc-ref %build-inputs "icu4c-build-root"))) > - '())) > - #:phases > - (modify-phases %standard-phases > - (add-after 'unpack 'chdir-to-source > - (lambda _ (chdir "source") #t)) > - (add-after 'chdir-to-source 'update-LDFLAGS > - (lambda _ > - ;; Do not create a "data-only" libicudata.so because it causes > - ;; problems on some architectures (notably armhf and MIPS). > - (substitute* "config/mh-linux" > - (("LDFLAGSICUDT=-nodefaultlibs -nostdlib") > - "LDFLAGSICUDT=")) > - #t)) > - ,@(if (target-riscv64?) > - `((add-after 'unpack 'disable-failing-test > - ;; It is unknown why this test is failing. > - (lambda _ > - (substitute* "source/test/intltest/numbertest_api.cpp" > - (("(TESTCASE_AUTO\\(unitUsage\\));" all) > - (string-append "//" all)))))) > - '()) > - (add-after 'install 'avoid-coreutils-reference > - ;; Don't keep a reference to the build tools. > - (lambda* (#:key outputs #:allow-other-keys) > - (let ((out (assoc-ref outputs "out"))) > - (substitute* (find-files (string-append out "/lib/icu") > - "\\.inc$") > - (("INSTALL_CMD=.*/bin/install") "INSTALL_CMD=install")) > - #t)))))) > + ,@(if (%current-target-system) > + '((string-append "--with-cross-build=" > + (assoc-ref %build-inputs "icu4c-build-root"))) > + '())) > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'chdir-to-source > + (lambda _ (chdir "source"))) > + (add-after 'chdir-to-source 'update-LDFLAGS > + (lambda _ > + ;; Do not create a "data-only" libicudata.so because it causes > + ;; problems on some architectures (notably armhf and MIPS). > + (substitute* "config/mh-linux" > + (("LDFLAGSICUDT=-nodefaultlibs -nostdlib") > + "LDFLAGSICUDT=")))) > + #$@(if (target-riscv64?) > + `((add-after 'unpack 'disable-failing-test > + ;; It is unknown why this test is failing. > + (lambda _ > + (substitute* "source/test/intltest/numbertest_api.cpp" > + (("(TESTCASE_AUTO\\(unitUsage\\));" all) > + (string-append "//" all)))))) > + '()) > + (add-after 'install 'avoid-coreutils-reference > + ;; Don't keep a reference to the build tools. > + (lambda _ > + (substitute* (find-files (string-append #$output "/lib/icu") > + "\\.inc$") > + (("INSTALL_CMD=.*/bin/install") "INSTALL_CMD=install"))))))) > (synopsis "International Components for Unicode") > (description > "ICU is a set of C/C++ and Java libraries providing Unicode and This looks good, but it's a core-updates change: guix refresh -l icu4c@69 says 12433 packages would be rebuilt. Also, you should update all the variants which inherits this one to also use gexp expressions, as it may cause problems otherwise. I'm adding 'core-updates' to the title to avoid merge mistakes. Thanks for working on it! -- Maxim From unknown Sun Jun 22 07:56:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#60430: closed (Re: bug#60430: [PATCH core-updates] gnu: icu4c: Update packaging style.) Message-ID: References: <8734urg4a0.fsf@gmail.com> <20221230160900.28075-1-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 60430 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 60430@debbugs.gnu.org Date: Sat, 20 Jan 2024 20:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1705781102-11698-1" This is a multi-part message in MIME format... ------------=_1705781102-11698-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60430: [PATCH core-updates] gnu: icu4c: Update packaging style. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60430@debbugs.gnu.org. --=20 60430: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60430 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1705781102-11698-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60430-done) by debbugs.gnu.org; 20 Jan 2024 20:04:55 +0000 Received: from localhost ([127.0.0.1]:35845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRHaJ-00032H-BG for submit@debbugs.gnu.org; Sat, 20 Jan 2024 15:04:55 -0500 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:48608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRHaE-00031v-9f for 60430-done@debbugs.gnu.org; Sat, 20 Jan 2024 15:04:53 -0500 Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-42a032cf012so16784171cf.1 for <60430-done@debbugs.gnu.org>; Sat, 20 Jan 2024 12:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705781081; x=1706385881; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vl+8+trO8aYCayQP7uIvY4Z5k2m9ygxIbcA619FFxX0=; b=mj1uU6W55mAax6uDWv73XqBSbrqbszGiAVZU2BYiWJGp140XL5bMTYyCG1IL+3KSlV id9C0HYi1HR4YZ9fuv+oRWJgB5zsLeAGLW5FKlljlNE/xyf1zZZJ2mXlJh8owwJHAaRl qW1mEevCoOnRfnq9XkUxbuEiYWccMQkj5SrAx32/RGzcah3/F75cm3tnb2IxQN4zxQNl VRz0eR5TRHlfwxpx5w8T0xGFzGxcsE3mzDX671tsAWeE3GZXk5mukUCiZHXqO67OCkyA I4MQHYx6CqbM1GntbAmxxa1lO8u+cOSGnoJ85zWgak6SHdHDG6TCprToSq+k76901Gpi Czhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705781081; x=1706385881; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vl+8+trO8aYCayQP7uIvY4Z5k2m9ygxIbcA619FFxX0=; b=MYXgOdhGC9QWV9FlJLbIXkDSi7kFiGgghaMDmIOY8v+/f6Sx+kU7p9ojfyZ6yVMVTj IvaH6Ordw3l6cY5AABU9yTveJsU3aqWPtIbJTSMJfBCN/VF9Cp1b3eTkxCji06Jv6cLg 3rdTMouDvMIr3MdGBB4tr+Qs9gIgU1L8cSREHFjwzF0ZhnIusNdsTjJhBlkNX0zNEVtE uazZkDnbh9ntDClcGNNZbRZTXoPojbXM1d9YFEFlXJTAAajWYf7GzFhhj1VEf58ZLbQe p8KAQSFzta5JpPUjsf1PZ5ZW/1iNuUnexy1H+HE8GJGv1uYOro0z9MR5ENCtXMnx7D4X 5uiA== X-Gm-Message-State: AOJu0YzHzO3xKwAjVemst61Ro81nFNVdeXxZOb0XYEodhsjO/RJidMbv efulBYUE26SFkOd809eXP88pa/MfS2KkrA3d6Xup7lJPQjIE+l/CyXlIG6uJyso= X-Google-Smtp-Source: AGHT+IEy7HnmbUB7Jl6yL1hpn34nP6OVYaMIGunUZk3Yae79+ZvBKaynRVFUBdyhIRjRZ3HLs3QIww== X-Received: by 2002:a05:622a:215:b0:42a:35ac:157b with SMTP id b21-20020a05622a021500b0042a35ac157bmr865714qtx.43.1705781081220; Sat, 20 Jan 2024 12:04:41 -0800 (PST) Received: from hurd (dsl-10-128-232.b2b2c.ca. [72.10.128.232]) by smtp.gmail.com with ESMTPSA id pj17-20020a05620a1d9100b00781587ab3dfsm784265qkn.74.2024.01.20.12.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jan 2024 12:04:40 -0800 (PST) From: Maxim Cournoyer To: Nicolas Graves Subject: Re: bug#60430: [PATCH core-updates] gnu: icu4c: Update packaging style. In-Reply-To: <20221230160900.28075-1-ngraves@ngraves.fr> (Nicolas Graves's message of "Fri, 30 Dec 2022 17:09:00 +0100") References: <20221230160900.28075-1-ngraves@ngraves.fr> Date: Sat, 20 Jan 2024 15:04:39 -0500 Message-ID: <8734urg4a0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60430-done Cc: 60430-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Nicolas Graves writes: > * gnu/packages/icu4c.scm (icu4c): Update packaging style. That's now already been done on core-updates. -- Thanks, Maxim ------------=_1705781102-11698-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Dec 2022 16:09:33 +0000 Received: from localhost ([127.0.0.1]:35984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBHwn-0000ks-GE for submit@debbugs.gnu.org; Fri, 30 Dec 2022 11:09:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:34322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBHwl-0000kj-Cc for submit@debbugs.gnu.org; Fri, 30 Dec 2022 11:09:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHwl-0002UO-3Y for guix-patches@gnu.org; Fri, 30 Dec 2022 11:09:27 -0500 Received: from 8.mo550.mail-out.ovh.net ([178.33.110.239]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHwi-0007Sj-Qw for guix-patches@gnu.org; Fri, 30 Dec 2022 11:09:26 -0500 Received: from director10.ghost.mail-out.ovh.net (unknown [10.109.146.19]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 250AC238D2 for ; Fri, 30 Dec 2022 16:09:10 +0000 (UTC) Received: from ghost-submission-747dc469fd-pvbcd (unknown [10.110.208.248]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 4E6E81FEAD; Fri, 30 Dec 2022 16:09:09 +0000 (UTC) Received: from ngraves.fr ([37.59.142.102]) by ghost-submission-747dc469fd-pvbcd with ESMTPSA id 8Kg7FCUNr2N7JwEAUY42lw (envelope-from ); Fri, 30 Dec 2022 16:09:09 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-102R0045a4d7a7b-0cb2-4fee-96cf-953fb0eac1c5, D6AF47B0F5163561D05A5CA4A1CFB5D3A7562A97) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 80.215.85.90 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH] gnu: icu4c: Update packaging style. Date: Fri, 30 Dec 2022 17:09:00 +0100 Message-Id: <20221230160900.28075-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 947444775557849826 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrieeigdekgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeekffegteffgfffjeegjedvfffgtddvueeutefgfeeuvdejgedvgeejjeevueeuveenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth Received-SPF: pass client-ip=178.33.110.239; envelope-from=ngraves@ngraves.fr; helo=8.mo550.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/icu4c.scm (icu4c): Update packaging style. --- gnu/packages/icu4c.scm | 66 ++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm index 1e4f66d956..1338c8f525 100644 --- a/gnu/packages/icu4c.scm +++ b/gnu/packages/icu4c.scm @@ -63,41 +63,39 @@ (define-public icu4c (inputs (list perl)) (arguments - `(#:configure-flags - (list + (list + #:configure-flags + `(list "--enable-rpath" - ,@(if (%current-target-system) - '((string-append "--with-cross-build=" - (assoc-ref %build-inputs "icu4c-build-root"))) - '())) - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'chdir-to-source - (lambda _ (chdir "source") #t)) - (add-after 'chdir-to-source 'update-LDFLAGS - (lambda _ - ;; Do not create a "data-only" libicudata.so because it causes - ;; problems on some architectures (notably armhf and MIPS). - (substitute* "config/mh-linux" - (("LDFLAGSICUDT=-nodefaultlibs -nostdlib") - "LDFLAGSICUDT=")) - #t)) - ,@(if (target-riscv64?) - `((add-after 'unpack 'disable-failing-test - ;; It is unknown why this test is failing. - (lambda _ - (substitute* "source/test/intltest/numbertest_api.cpp" - (("(TESTCASE_AUTO\\(unitUsage\\));" all) - (string-append "//" all)))))) - '()) - (add-after 'install 'avoid-coreutils-reference - ;; Don't keep a reference to the build tools. - (lambda* (#:key outputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out"))) - (substitute* (find-files (string-append out "/lib/icu") - "\\.inc$") - (("INSTALL_CMD=.*/bin/install") "INSTALL_CMD=install")) - #t)))))) + ,@(if (%current-target-system) + '((string-append "--with-cross-build=" + (assoc-ref %build-inputs "icu4c-build-root"))) + '())) + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'chdir-to-source + (lambda _ (chdir "source"))) + (add-after 'chdir-to-source 'update-LDFLAGS + (lambda _ + ;; Do not create a "data-only" libicudata.so because it causes + ;; problems on some architectures (notably armhf and MIPS). + (substitute* "config/mh-linux" + (("LDFLAGSICUDT=-nodefaultlibs -nostdlib") + "LDFLAGSICUDT=")))) + #$@(if (target-riscv64?) + `((add-after 'unpack 'disable-failing-test + ;; It is unknown why this test is failing. + (lambda _ + (substitute* "source/test/intltest/numbertest_api.cpp" + (("(TESTCASE_AUTO\\(unitUsage\\));" all) + (string-append "//" all)))))) + '()) + (add-after 'install 'avoid-coreutils-reference + ;; Don't keep a reference to the build tools. + (lambda _ + (substitute* (find-files (string-append #$output "/lib/icu") + "\\.inc$") + (("INSTALL_CMD=.*/bin/install") "INSTALL_CMD=install"))))))) (synopsis "International Components for Unicode") (description "ICU is a set of C/C++ and Java libraries providing Unicode and -- 2.38.1 ------------=_1705781102-11698-1--