GNU bug report logs - #60423
29.0.60; goto-address and shr/textsec don't play nicely together

Previous Next

Full log

View this message in rfc822 format

From: Mike Kupfer <kupfer <at> rawbw.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60423 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>, stefankangas <at> gmail.com
Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together
Date: Thu, 10 Oct 2024 16:46:16 -0700

Eli Zaretskii wrote:

> > From: Mike Kupfer <kupfer <at> rawbw.com>
[...]
> > So I lean towards having goto-address leave text alone (don't set an
> > overlay) if it finds text properties set for the text.
> 
> Not just any properties: only 'face' properties, right?

Hmm.  shr-tag-a sets these properties, with shr-urlify doing most of the
work:

- face ('shr-link')
- shr-url
- button
- category
- help-echo
- follow-link
- mouse-face

If the URL is suspicious, shr-tag-a also inserts a triangular warning
symbol with a 'help-echo' property.

So if I just care about conflicts between goto-address and shr, I guess
I could just check for the 'shr-link' face.  I'd prefer to have a more
general test, so I think I want to check for any of

- face
- help-echo
- mouse-face

and maybe

- button
- follow-link

as well.  What do you think?

thanks,
mike

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.