GNU bug report logs - #60418
[PATCH] Add :vc keyword to use-package

Previous Next

Full log

Message #52 received at 60418 <at> debbugs.gnu.org (full text, mbox):

From: Ruijie Yu <ruijie <at> netyu.xyz>
To: Tony Zorman <soliditsallgood <at> mailbox.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>,
 Felician Nemeth <felician.nemeth <at> gmail.com>, 60418 <at> debbugs.gnu.org,
 bug-gnu-emacs <at> gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#60418: [PATCH] Add :vc keyword to use-package
Date: Mon, 17 Apr 2023 00:18:48 +0800

Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> writes:
> --- a/test/lisp/use-package/use-package-tests.el
> +++ b/test/lisp/use-package/use-package-tests.el
> @@ -1951,6 +1951,55 @@ bind-key/845
>      (should (eq (nth 1 binding) 'ignore))
>      (should (eq (nth 2 binding) nil))))
>  
> +(ert-deftest use-package-test/:vc-1 ()
> +  (match-expansion
> +   (use-package foo :vc (:url "bar"))
> +   '(use-package-vc-install '(foo (:url "bar") :last-release) nil)))
> +
> +(ert-deftest use-package-test/:vc-2 ()
> +  (match-expansion
> +   (use-package foo
> +     :vc (baz . (:url "baz" :vc-backend "Git"
> +                 :main-file qux.el :rev "rev-string")))
> +   `(use-package-vc-install '(baz
> +                              (:url "baz" :vc-backend Git :main-file "qux.el")
> +                              "rev-string")
> +                            nil)))

I'm curious, what is the significance to using quote versus quasiquote?
I noticed that there is no unquote inside the quasiquote at all, and am
wondering whether it is simply a typo or some sort of peculiarity in
`match-expansion'.

Admittedly I didn't look into the definition of `match-expansion' since
"git fetch" is taking its time on my end for some reason.

-- 
Best,


RY

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.