GNU bug report logs - #60418
[PATCH] Add :vc keyword to use-package

Previous Next

Package: emacs;

Reported by: Tony Zorman <soliditsallgood <at> mailbox.org>

Date: Fri, 30 Dec 2022 07:04:03 UTC

Severity: normal

Tags: patch

Merged with 61937

Found in version 29.0.60

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#61937: closed (29.0.60; [FR] use-package :ensure to allow vc
 sources)
Date: Tue, 16 May 2023 19:31:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 16 May 2023 19:30:48 +0000
with message-id <87zg649iqf.fsf <at> posteo.net>
and subject line Re: bug#60418: [PATCH] Add :vc keyword to use-package
has caused the debbugs.gnu.org bug report #60418,
regarding 29.0.60; [FR] use-package :ensure to allow vc sources
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60418: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60418
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ruijie Yu <ruijie <at> netyu.xyz>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; [FR] use-package :ensure to allow vc sources
Date: Fri, 03 Mar 2023 22:57:36 +0800
I have been using straight.el [1] before `use-package' was taken into
emacs.git, as I needed to use some packages not from any elpa source but
from vc sources.  I recently noticed the function `package-vc-install'
has been introduced into 29, and would like to have `use-package' use it
in its :ensure form.

An analogous version from straight.el has already been made available,
which looks like the following:

    (use-package foo
      :straight (foo :repo "https://path.to/foo.el" :type git))

My hope is to extend :ensure form so that a similar specification can be
supplied to install packages directly from vc sources.

[1]: https://github.com/radian-software/straight.el

--
Best,


RY


[Message part 3 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: Tony Zorman <soliditsallgood <at> mailbox.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, felician.nemeth <at> gmail.com,
 60418-done <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#60418: [PATCH] Add :vc keyword to use-package
Date: Tue, 16 May 2023 19:30:48 +0000
Philip Kaludercic <philipk <at> posteo.net> writes:

> Tony Zorman <soliditsallgood <at> mailbox.org> writes:
>
>> On Sat, May 06 2023 18:50, Philip Kaludercic wrote:
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>>                                       I understand that in most cases
>>>> users will want to install the latest, 
>>>
>>> I don't know if that is the case.  I might be wrong that the revision of
>>> the latest release is a good default?  Tony, do you think we should add
>>> a user-option to regulate this behaviour.
>>
>> It's certainly my default to install the latest commit of a package
>> instead of the latest release. I don't know how general this desire is
>> among other people, but an option for controlling the specific behaviour
>> sounds great in either case.
>
> OK, so it might make sense to address this at a later point with a
> another patch.
>
> For now, what issues remain to be resolved before these patches can be
> applied?

Reviewing the thread, I think everything was ready (aside from a few
things that I promised to take care of), so I've pushed the change to
master.  Thank you for your contribution!


This bug report was last modified 2 years and 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.