GNU bug report logs - #60418
[PATCH] Add :vc keyword to use-package

Previous Next

Full log

Message #142 received at 60418 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: soliditsallgood <at> mailbox.org, felician.nemeth <at> gmail.com,
 60418 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#60418: [PATCH] Add :vc keyword to use-package
Date: Sat, 06 May 2023 22:13:42 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: soliditsallgood <at> mailbox.org,  60418 <at> debbugs.gnu.org,
>   felician.nemeth <at> gmail.com,  stefankangas <at> gmail.com
> Date: Sat, 06 May 2023 18:50:02 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> This is true, for package-vc-install, but the idea was not do this for
> >> the :vc keyword to use-package.
> >
> > But I wrote the above as a comment to a patch to package-vc.el, not to
> > use-package.  So why use-package is relevant here?
> 
> Because this patch is related to use-package, and a keyword that would
> allow for use-package to invoke package-vc-install?

Yes, but the doc string in package-vc-install should describe
everything that package-vc supports, not just the subset we think will
be useful in use-package via :rev.

Anyway, I think we are in agreement, as your last doc string is
comprehensive enough to make me happy.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.