GNU bug report logs - #60416
Be more liberal using copy_file_range() with NFS mounted filesystems

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60416: closed (Be more liberal using copy_file_range() with
 NFS mounted filesystems)
Date: Sat, 31 Dec 2022 00:24:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 31 Dec 2022 00:23:30 +0000
with message-id <637162a7-d215-ac74-b422-a5539c09bff4 <at> draigBrady.com>
and subject line Re: bug#60416: [PATCH] copy: attempt copy offload with sparse files
has caused the debbugs.gnu.org bug report #60416,
regarding Be more liberal using copy_file_range() with NFS mounted filesystems
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60416: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60416
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Braiam <braiamp <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: Be more liberal using copy_file_range() with NFS mounted filesystems
Date: Thu, 29 Dec 2022 12:04:38 -0400

When using a nfs export, cp seems to not try hard enough using
copy_file_range(). This was
the conclusion we arrived in this forum thread[1] at Truenas forums.
It was found a way to force
cp to use it, but it should not be necessary, since there are supposed
to be fallbacks.

I'm unsure if we found something that triggered the undesired behavior.

[1]: https://www.truenas.com/community/threads/nfs-does-not-support-server-side-copy-with-zfs.103309/post-712071

-- 
Braiam

[Message part 3 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>, Braiam <braiamp <at> gmail.com>,
 60416-done <at> debbugs.gnu.org
Subject: Re: bug#60416: [PATCH] copy: attempt copy offload with sparse files
Date: Sat, 31 Dec 2022 00:23:30 +0000

On 30/12/2022 22:32, Paul Eggert wrote:
> Thanks, looks good, please install.

Thanks for the review.
OP also posted good results.
Pushed with NEWS entry.
Marking this as done.

I may follow up with a related patch to
ensure we _don't_ use copy_file_range with --sparse=never.

cheers,
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.