GNU bug report logs - #60382
FYI: two syntax-check nits, preparing for a snapshot

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60382: closed (FYI: two syntax-check nits, preparing for a
 snapshot)
Date: Wed, 28 Dec 2022 20:08:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 28 Dec 2022 12:06:45 -0800
with message-id <CA+8g5KH9JG1sHV-CdbV9wuh2CTRuM0mGjQ3iGJ=LUz4YJ9UXgQ <at> mail.gmail.com>
and subject line Re: bug#60382: Acknowledgement (FYI: two syntax-check nits, preparing for a snapshot)
has caused the debbugs.gnu.org bug report #60382,
regarding FYI: two syntax-check nits, preparing for a snapshot
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60382: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60382
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: bug-gzip <at> gnu.org
Subject: FYI: two syntax-check nits, preparing for a snapshot
Date: Wed, 28 Dec 2022 09:04:36 -0800

[Message part 3 (text/plain, inline)]

FYI: I've just pushed these:

[gzip-nits.diff (text/x-patch, inline)]

From 00f4ade0914a1d27897db3686d0cbe7284f6bea9 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> fb.com>
Date: Wed, 28 Dec 2022 08:36:27 -0800
Subject: [PATCH 1/2] maint: SPC-indent inflate.c

* inflate.c: Indent with spaces, not TABs.
---
 inflate.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/inflate.c b/inflate.c
index 083d286..91fa3d8 100644
--- a/inflate.c
+++ b/inflate.c
@@ -314,13 +314,13 @@ int *m                  /* maximum lookup bits, returns actual */
 #ifdef DEBUG
     if (1 < verbose && *p)
       {
-	if (' ' <= n - i && n - i <= '~')
-	  {
-	    char ch = n - i;
-	    fprintf (stderr, "%c %u\n", ch, *p);
-	  }
-	else
-	  fprintf (stderr, "0x%x %u\n", n - i, *p);
+        if (' ' <= n - i && n - i <= '~')
+          {
+            char ch = n - i;
+            fprintf (stderr, "%c %u\n", ch, *p);
+          }
+        else
+          fprintf (stderr, "0x%x %u\n", n - i, *p);
       }
 #endif
     c[*p]++;                    /* assume all entries <= BMAX */
@@ -584,7 +584,7 @@ inflate_codes(struct huft *tl, struct huft *td, int bl, int bd)
       d = w - t->v.n - ((unsigned)b & mask_bits[e]);
       DUMPBITS(e)
       if (fresh && w <= d)
-	return 1;
+        return 1;
       Tracevv ((stderr, "\\[%u,%u]", w - d, n));

       /* do the copy */
-- 
2.39.0.132.g8a4e8f6a67


From 7553200068763f99b148572c338bbbd46201fa45 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> fb.com>
Date: Wed, 28 Dec 2022 08:48:01 -0800
Subject: [PATCH 2/2] maint: avoid new sc_tight_scope syntax-check failure

* cfg.mk (_gl_TS_extern): Allow a leading '_Noreturn ' on
declarations like that of abort_gzip.
---
 cfg.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index 2f00e77..3676661 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -101,3 +101,5 @@ export _gl_TS_dir = .
 export _gl_TS_unmarked_extern_vars = \
   block_start d_buf inbuf outbuf prev read_buf strstart window \
   match_start prev_length max_chain_length good_match nice_match
+
+_gl_TS_extern = (?:_Noreturn )?extern
-- 
2.39.0.132.g8a4e8f6a67

[Message part 5 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: 60382-done <at> debbugs.gnu.org
Subject: Re: bug#60382: Acknowledgement (FYI: two syntax-check nits, preparing
 for a snapshot)
Date: Wed, 28 Dec 2022 12:06:45 -0800

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.