From unknown Fri Aug 15 20:50:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60382: FYI: two syntax-check nits, preparing for a snapshot Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Wed, 28 Dec 2022 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60382 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: To: 60382@debbugs.gnu.org X-Debbugs-Original-To: bug-gzip@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16722470931081 (code B ref -1); Wed, 28 Dec 2022 17:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Dec 2022 17:04:53 +0000 Received: from localhost ([127.0.0.1]:58507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAZrI-0000HM-Ng for submit@debbugs.gnu.org; Wed, 28 Dec 2022 12:04:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:57426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAZrG-0000HB-Tl for submit@debbugs.gnu.org; Wed, 28 Dec 2022 12:04:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAZrG-0005EC-6l for bug-gzip@gnu.org; Wed, 28 Dec 2022 12:04:50 -0500 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAZrE-00070A-BN for bug-gzip@gnu.org; Wed, 28 Dec 2022 12:04:49 -0500 Received: by mail-pj1-x1030.google.com with SMTP id o1-20020a17090a678100b00219cf69e5f0so20569259pjj.2 for ; Wed, 28 Dec 2022 09:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=QygY9wvGQdYVAl4RhpuDdkDTzZ94bVAVz4aEV0AXhqk=; b=aqsfPIH/aVFrU3w+Nmq2mbUz+aGeaW3rEktyrcYV0GsrthKnVaZZcAFI8ai12LzdmF fPwSZAaCNol/gbRk2ipnSCLbHkERGT/DCz/xIfwgIyQNL8apHqh6+/ycay+Oqzrchy9y Ee52PCaE49PdXRK2PIBka0ksdsvJPkhuWevALTpmpkiUh2ZP5dBv7ZC95gh6v0EcAH7A lEBJNy/OyDBARj5qCUT4+hDlJPZRkxQkNHL4usg8xUDL5SgT2izUtGsKjl5AR+KUFYue wjFVIrsYEPckRwhvd5RNROc4WK6YyCIRuHr7OTP8Tle5QII9LQ9tql8Hr+Ds+rXgGA2Z JSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QygY9wvGQdYVAl4RhpuDdkDTzZ94bVAVz4aEV0AXhqk=; b=l6gtq/3p5y1qneB0C4VdmmCKKsSrKdcVwPkp08WOdcmK04tQSmrLROcg/xifFQUSGz IMjIZPzj+wSpPDrj286cxh3BqTV/+udX6CEOuu2uHLPk8JpEwhkiaHwCSO6t39aHX1rX m5ucA5N3l9iIrOFM3gNmUY7vSnI6Js6BIcadluaNnZMUET1bCZudn+6LlnTi9Mjv4YMY jNiDyKEQwB2FrgWWBKr90meGnOVfO+6UpTEucvDkkk0fjjQvpwvtwPAeNWOVjlOscpmg 65akMcCGnuI6cXuw513wUKkWk7ob40DqIAK+DiTEpBhDZKp1zMUr51uE+WBqaZGbGHlU k36A== X-Gm-Message-State: AFqh2kqfkU+h/EuEQKbxlVDcabdCQX3W950+jy33b2F6QviEIAHRBl1A 2I8aefY+yfL6FlYuWUVBE11bgXsLRPE= X-Google-Smtp-Source: AMrXdXvh1eoWZCNagRwS3OOO/FUKtLyZfSYLjLzaNRftN/By0wmUv/bCWSt4PeKhe5pXM5hUXw24GQ== X-Received: by 2002:a17:90a:9709:b0:219:756c:e09 with SMTP id x9-20020a17090a970900b00219756c0e09mr28134705pjo.29.1672247085381; Wed, 28 Dec 2022 09:04:45 -0800 (PST) Received: from meyering-mbp ([2620:10d:c090:400::5:5330]) by smtp.gmail.com with ESMTPSA id v2-20020a17090a00c200b0021900ba8eeesm12472354pjd.2.2022.12.28.09.04.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 09:04:44 -0800 (PST) From: Jim Meyering Date: Wed, 28 Dec 2022 09:04:36 -0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=meyering@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain FYI: I've just pushed these: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gzip-nits.diff >From 00f4ade0914a1d27897db3686d0cbe7284f6bea9 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 28 Dec 2022 08:36:27 -0800 Subject: [PATCH 1/2] maint: SPC-indent inflate.c * inflate.c: Indent with spaces, not TABs. --- inflate.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/inflate.c b/inflate.c index 083d286..91fa3d8 100644 --- a/inflate.c +++ b/inflate.c @@ -314,13 +314,13 @@ int *m /* maximum lookup bits, returns actual */ #ifdef DEBUG if (1 < verbose && *p) { - if (' ' <= n - i && n - i <= '~') - { - char ch = n - i; - fprintf (stderr, "%c %u\n", ch, *p); - } - else - fprintf (stderr, "0x%x %u\n", n - i, *p); + if (' ' <= n - i && n - i <= '~') + { + char ch = n - i; + fprintf (stderr, "%c %u\n", ch, *p); + } + else + fprintf (stderr, "0x%x %u\n", n - i, *p); } #endif c[*p]++; /* assume all entries <= BMAX */ @@ -584,7 +584,7 @@ inflate_codes(struct huft *tl, struct huft *td, int bl, int bd) d = w - t->v.n - ((unsigned)b & mask_bits[e]); DUMPBITS(e) if (fresh && w <= d) - return 1; + return 1; Tracevv ((stderr, "\\[%u,%u]", w - d, n)); /* do the copy */ -- 2.39.0.132.g8a4e8f6a67 >From 7553200068763f99b148572c338bbbd46201fa45 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 28 Dec 2022 08:48:01 -0800 Subject: [PATCH 2/2] maint: avoid new sc_tight_scope syntax-check failure * cfg.mk (_gl_TS_extern): Allow a leading '_Noreturn ' on declarations like that of abort_gzip. --- cfg.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cfg.mk b/cfg.mk index 2f00e77..3676661 100644 --- a/cfg.mk +++ b/cfg.mk @@ -101,3 +101,5 @@ export _gl_TS_dir = . export _gl_TS_unmarked_extern_vars = \ block_start d_buf inbuf outbuf prev read_buf strstart window \ match_start prev_length max_chain_length good_match nice_match + +_gl_TS_extern = (?:_Noreturn )?extern -- 2.39.0.132.g8a4e8f6a67 --=-=-=-- From unknown Fri Aug 15 20:50:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Meyering Subject: bug#60382: closed (Re: bug#60382: Acknowledgement (FYI: two syntax-check nits, preparing for a snapshot)) Message-ID: References: X-Gnu-PR-Message: they-closed 60382 X-Gnu-PR-Package: gzip Reply-To: 60382@debbugs.gnu.org Date: Wed, 28 Dec 2022 20:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1672258082-16969-1" This is a multi-part message in MIME format... ------------=_1672258082-16969-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60382: FYI: two syntax-check nits, preparing for a snapshot which was filed against the gzip package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60382@debbugs.gnu.org. --=20 60382: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60382 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1672258082-16969-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60382-done) by debbugs.gnu.org; 28 Dec 2022 20:07:07 +0000 Received: from localhost ([127.0.0.1]:58776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAchf-0004Np-E5 for submit@debbugs.gnu.org; Wed, 28 Dec 2022 15:07:07 -0500 Received: from mail-lf1-f45.google.com ([209.85.167.45]:41694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAchc-0004NC-2Q for 60382-done@debbugs.gnu.org; Wed, 28 Dec 2022 15:07:05 -0500 Received: by mail-lf1-f45.google.com with SMTP id z26so24966135lfu.8 for <60382-done@debbugs.gnu.org>; Wed, 28 Dec 2022 12:07:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=Ib5RIWR6BmGhfG75FKSQL8+C07euMiaSEDyrLhPDvMFjPMGG6KPkDSxDENSa38ENdf 8Cqk0OqhiUa9yb+QbfPvGCz4LpXVCEenbiUkc7oTKnGZ8wHnuGkDFqpLxntYHak9s9Rk ikoKJEyX11YuQmumJixhMNdjO0gBWoPnRBL2vlKUetBk68y6vTgf5Z9xyv6MC+acpHuc xf7wapHjeBSzOewOfGqDz32fZaBvOvK9wBFS/9oro39VGhMhP0sSIaxgS8WkRrRas3s+ aH3sF5AQKA6md6hBYLJznkrpd4yuZfsj2Ce9NHjv1uhdNhUoUaTA2AE13F5N9a/uMfv3 AosQ== X-Gm-Message-State: AFqh2krUjawPgnnM5XABkTrqQ+HqMC0XU4btfyd1Pf/9nKASGnWofVnR 9WDF6KsUZwM2kb+deFlXbHHnkT0eZUqHp2DRXVlD182m X-Google-Smtp-Source: AMrXdXtLH1+qVOMhsKoBvdeXdkwPnyhm/UCk7xgbr9ylpkDnT/pVL/y1l745w95TTqt4eJhe6XAGiKc13giNH1q4vps= X-Received: by 2002:ac2:42d3:0:b0:4a2:4b43:9aad with SMTP id n19-20020ac242d3000000b004a24b439aadmr2002933lfl.213.1672258017695; Wed, 28 Dec 2022 12:06:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jim Meyering Date: Wed, 28 Dec 2022 12:06:45 -0800 Message-ID: Subject: Re: bug#60382: Acknowledgement (FYI: two syntax-check nits, preparing for a snapshot) To: 60382-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 60382-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) ------------=_1672258082-16969-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Dec 2022 17:04:53 +0000 Received: from localhost ([127.0.0.1]:58507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAZrI-0000HM-Ng for submit@debbugs.gnu.org; Wed, 28 Dec 2022 12:04:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:57426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAZrG-0000HB-Tl for submit@debbugs.gnu.org; Wed, 28 Dec 2022 12:04:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAZrG-0005EC-6l for bug-gzip@gnu.org; Wed, 28 Dec 2022 12:04:50 -0500 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAZrE-00070A-BN for bug-gzip@gnu.org; Wed, 28 Dec 2022 12:04:49 -0500 Received: by mail-pj1-x1030.google.com with SMTP id o1-20020a17090a678100b00219cf69e5f0so20569259pjj.2 for ; Wed, 28 Dec 2022 09:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=QygY9wvGQdYVAl4RhpuDdkDTzZ94bVAVz4aEV0AXhqk=; b=aqsfPIH/aVFrU3w+Nmq2mbUz+aGeaW3rEktyrcYV0GsrthKnVaZZcAFI8ai12LzdmF fPwSZAaCNol/gbRk2ipnSCLbHkERGT/DCz/xIfwgIyQNL8apHqh6+/ycay+Oqzrchy9y Ee52PCaE49PdXRK2PIBka0ksdsvJPkhuWevALTpmpkiUh2ZP5dBv7ZC95gh6v0EcAH7A lEBJNy/OyDBARj5qCUT4+hDlJPZRkxQkNHL4usg8xUDL5SgT2izUtGsKjl5AR+KUFYue wjFVIrsYEPckRwhvd5RNROc4WK6YyCIRuHr7OTP8Tle5QII9LQ9tql8Hr+Ds+rXgGA2Z JSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QygY9wvGQdYVAl4RhpuDdkDTzZ94bVAVz4aEV0AXhqk=; b=l6gtq/3p5y1qneB0C4VdmmCKKsSrKdcVwPkp08WOdcmK04tQSmrLROcg/xifFQUSGz IMjIZPzj+wSpPDrj286cxh3BqTV/+udX6CEOuu2uHLPk8JpEwhkiaHwCSO6t39aHX1rX m5ucA5N3l9iIrOFM3gNmUY7vSnI6Js6BIcadluaNnZMUET1bCZudn+6LlnTi9Mjv4YMY jNiDyKEQwB2FrgWWBKr90meGnOVfO+6UpTEucvDkkk0fjjQvpwvtwPAeNWOVjlOscpmg 65akMcCGnuI6cXuw513wUKkWk7ob40DqIAK+DiTEpBhDZKp1zMUr51uE+WBqaZGbGHlU k36A== X-Gm-Message-State: AFqh2kqfkU+h/EuEQKbxlVDcabdCQX3W950+jy33b2F6QviEIAHRBl1A 2I8aefY+yfL6FlYuWUVBE11bgXsLRPE= X-Google-Smtp-Source: AMrXdXvh1eoWZCNagRwS3OOO/FUKtLyZfSYLjLzaNRftN/By0wmUv/bCWSt4PeKhe5pXM5hUXw24GQ== X-Received: by 2002:a17:90a:9709:b0:219:756c:e09 with SMTP id x9-20020a17090a970900b00219756c0e09mr28134705pjo.29.1672247085381; Wed, 28 Dec 2022 09:04:45 -0800 (PST) Received: from meyering-mbp ([2620:10d:c090:400::5:5330]) by smtp.gmail.com with ESMTPSA id v2-20020a17090a00c200b0021900ba8eeesm12472354pjd.2.2022.12.28.09.04.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 09:04:44 -0800 (PST) From: Jim Meyering To: bug-gzip@gnu.org Subject: FYI: two syntax-check nits, preparing for a snapshot Date: Wed, 28 Dec 2022 09:04:36 -0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=meyering@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain FYI: I've just pushed these: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gzip-nits.diff >From 00f4ade0914a1d27897db3686d0cbe7284f6bea9 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 28 Dec 2022 08:36:27 -0800 Subject: [PATCH 1/2] maint: SPC-indent inflate.c * inflate.c: Indent with spaces, not TABs. --- inflate.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/inflate.c b/inflate.c index 083d286..91fa3d8 100644 --- a/inflate.c +++ b/inflate.c @@ -314,13 +314,13 @@ int *m /* maximum lookup bits, returns actual */ #ifdef DEBUG if (1 < verbose && *p) { - if (' ' <= n - i && n - i <= '~') - { - char ch = n - i; - fprintf (stderr, "%c %u\n", ch, *p); - } - else - fprintf (stderr, "0x%x %u\n", n - i, *p); + if (' ' <= n - i && n - i <= '~') + { + char ch = n - i; + fprintf (stderr, "%c %u\n", ch, *p); + } + else + fprintf (stderr, "0x%x %u\n", n - i, *p); } #endif c[*p]++; /* assume all entries <= BMAX */ @@ -584,7 +584,7 @@ inflate_codes(struct huft *tl, struct huft *td, int bl, int bd) d = w - t->v.n - ((unsigned)b & mask_bits[e]); DUMPBITS(e) if (fresh && w <= d) - return 1; + return 1; Tracevv ((stderr, "\\[%u,%u]", w - d, n)); /* do the copy */ -- 2.39.0.132.g8a4e8f6a67 >From 7553200068763f99b148572c338bbbd46201fa45 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 28 Dec 2022 08:48:01 -0800 Subject: [PATCH 2/2] maint: avoid new sc_tight_scope syntax-check failure * cfg.mk (_gl_TS_extern): Allow a leading '_Noreturn ' on declarations like that of abort_gzip. --- cfg.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cfg.mk b/cfg.mk index 2f00e77..3676661 100644 --- a/cfg.mk +++ b/cfg.mk @@ -101,3 +101,5 @@ export _gl_TS_dir = . export _gl_TS_unmarked_extern_vars = \ block_start d_buf inbuf outbuf prev read_buf strstart window \ match_start prev_length max_chain_length good_match nice_match + +_gl_TS_extern = (?:_Noreturn )?extern -- 2.39.0.132.g8a4e8f6a67 --=-=-=-- ------------=_1672258082-16969-1--