GNU bug report logs - #60380
[PATCH] gnu: Add emacs-eat.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60380 in the body.
You can then email your comments to 60380 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: guix-patches <at> gnu.org
Cc: Zhu Zihao <all_but_last <at> 163.com>
Subject: [PATCH] gnu: Add emacs-eat.
Date: Wed, 28 Dec 2022 23:17:28 +0800

* gnu/packages/emacs-xyz.scm (emacs-eat): New variable.
---
 gnu/packages/emacs-xyz.scm | 48 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8b0bb58275..9765ca2bbf 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,7 +81,7 @@
 ;;; Copyright © 2020, 2021, 2022 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98 <at> protonmail.com>
 ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
-;;; Copyright © 2020, 2021 Zhu Zihao <all_but_last <at> 163.com>
+;;; Copyright © 2020, 2021, 2022 Zhu Zihao <all_but_last <at> 163.com>
 ;;; Copyright © 2020 Adam Kandur <rndd <at> tuta.io>
 ;;; Copyright © 2020 Tim Howes <timhowes <at> lavabit.com>
 ;;; Copyright © 2020 Noah Landis <noahlandis <at> posteo.net>
@@ -26592,6 +26592,52 @@ (define-public emacs-navigel
 tabulated-lists).")
     (license license:gpl3+)))
 
+(define-public emacs-eat
+  (package
+    (name "emacs-eat")
+    (version "0.3.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://codeberg.org/akib/emacs-eat")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1ha9qc8ll41bc187vzpnnwb06jywvfzh7kxy4rfcdj6dc21wvb87"))
+       (modules '((guix build utils)))
+       (snippet
+        #~(begin
+            ;; Remove generated terminfo database.
+            (delete-file-recursively "terminfo")
+            #t))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:tests? #t
+      #:include #~(cons* "^term/"
+                         "^terminfo/"
+                         "^integration/"
+                         "\\.ti$"
+                         %default-include)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install 'build-info
+            (lambda _
+              (invoke "make" "info")))
+          (add-before 'install 'build-terminfo-database
+            (lambda _
+              (invoke "make" "terminfo"))))))
+    (native-inputs
+     (list ncurses texinfo))
+    (home-page "https://codeberg.org/akib/emacs-eat")
+    (synopsis "Terminal emulator in Emacs")
+    (description
+     "This package provides a terminal emulator in Emacs, written in pure
+Elisp.  It has features like complete mouse support and shell integration.")
+    (license license:gpl3+)))
+
 (define-public emacs-vterm
   (let ((version "0.0.1")
         (revision "1")
-- 
2.38.1

Message #8 received at 60380 <at> debbugs.gnu.org (full text, mbox):

From: Akib Azmain Turja <akib <at> disroot.org>
To: 60380 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-eat.
Date: Wed, 28 Dec 2022 23:04:46 +0600

[Message part 1 (text/plain, inline)]

Thanks for submitting this.

> * gnu/packages/emacs-xyz.scm (emacs-eat): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 48 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 47 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 8b0bb58275..9765ca2bbf 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -81,7 +81,7 @@
>  ;;; Copyright © 2020, 2021, 2022 Niklas Eklund <niklas.eklund <at> posteo.net>
>  ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98 <at> protonmail.com>
>  ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
> -;;; Copyright © 2020, 2021 Zhu Zihao <all_but_last <at> 163.com>
> +;;; Copyright © 2020, 2021, 2022 Zhu Zihao <all_but_last <at> 163.com>
>  ;;; Copyright © 2020 Adam Kandur <rndd <at> tuta.io>
>  ;;; Copyright © 2020 Tim Howes <timhowes <at> lavabit.com>
>  ;;; Copyright © 2020 Noah Landis <noahlandis <at> posteo.net>
> @@ -26592,6 +26592,52 @@ (define-public emacs-navigel
>  tabulated-lists).")
>      (license license:gpl3+)))
>  
> +(define-public emacs-eat
> +  (package
> +    (name "emacs-eat")
> +    (version "0.3.1")

Version 0.4, maybe?  (Just released now.  ;))

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://codeberg.org/akib/emacs-eat")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1ha9qc8ll41bc187vzpnnwb06jywvfzh7kxy4rfcdj6dc21wvb87"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        #~(begin
> +            ;; Remove generated terminfo database.
> +            (delete-file-recursively "terminfo")
> +            #t))))

To build these files with Guix, I guess?

> +    (build-system emacs-build-system)
> +    (arguments
> +     (list
> +      #:tests? #t
> +      #:include #~(cons* "^term/"
> +                         "^terminfo/"
> +                         "^integration/"
> +                         "\\.ti$"
> +                         %default-include)
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-before 'install 'build-info
> +            (lambda _
> +              (invoke "make" "info")))
> +          (add-before 'install 'build-terminfo-database
> +            (lambda _
> +              (invoke "make" "terminfo"))))))
> +    (native-inputs
> +     (list ncurses texinfo))
> +    (home-page "https://codeberg.org/akib/emacs-eat")
> +    (synopsis "Terminal emulator in Emacs")

I guess it'd be better to use the string "Emulate A Terminal in Emacs"
as the synopsis.

> +    (description
> +     "This package provides a terminal emulator in Emacs, written in pure
> +Elisp.  It has features like complete mouse support and shell integration.")
> +    (license license:gpl3+)))
> +

Great description in a few words.

>  (define-public emacs-vterm
>    (let ((version "0.0.1")
>          (revision "1")
> -- 
> 2.38.1

-- 
Akib Azmain Turja, GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5
Fediverse: akib <at> hostux.social
Codeberg: akib
emailselfdefense.fsf.org | "Nothing can be secure without encryption."

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 60380-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 60380-done <at> debbugs.gnu.org
Subject: Re: [bug#60380] [PATCH] gnu: Add emacs-eat.
Date: Fri, 30 Dec 2022 11:33:44 +0100

Hello,

Zhu Zihao <all_but_last <at> 163.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-eat): New variable.

I updated the package to 0.4 and applied your patch. Thank you.

> +       (snippet
> +        #~(begin
> +            ;; Remove generated terminfo database.
> +            (delete-file-recursively "terminfo")
> +            #t))))

This trailing #t is not necessary. I removed it.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.