GNU bug report logs - #60376
29.0.60; Standardize csharp-ts-mode's font-lock features

Previous Next

Full log

View this message in rfc822 format

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Yuan Fu <casouri <at> gmail.com>, Theodor Thornhill <theo <at> thornhill.no>
Cc: 60376 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features
Date: Thu, 5 Jan 2023 22:27:28 +0100

On 03.01.2023 06:43, Jostein Kjønigsen wrote:
> Yuan: did you forget applying this last patch? :)
>
> —
> Jostein Kjønigsen
> https://jostein.kjønigsen.net
>
>> On 2 Jan 2023, at 10:59, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
>> Great! Thanks!
>>
>> Please note: The previous patch removed a very wide (generic_name (identifier)) selector, which incorrectly caused generic functions to be highlighted as a types.
>>
>> This has lead to having to add in more specific (xxx (generic_name (identifier)) selectors around the codebase to compensate, and the previous patch evidently didn't have "all" the ones we need.
>>
>> Attached is a very small patch which should make support for highlighting generic types more complete. I won't promise it has 100% coverage, but with this in place, I can't see any obvious places in code where I'm missing out.
>>
>> With this in place, the only thing I'd like to improve now (if any) is indentation for object-creation/initialization expressions. I've made a few attempts and can't get those to behave properly.
>>
>> Is this anything you could take a look at, Theo? :)
>>
>> --
>> Jostein
>> <patch.txt>

Given the feature-freeze on emacs-29 now, could someone please get the 
above patch installed?

That would at least make me feel more comfortable :)

--
Jostein

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.