From unknown Fri Jun 20 07:13:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60376 <60376@debbugs.gnu.org> To: bug#60376 <60376@debbugs.gnu.org> Subject: Status: 29.0.60; Standardize csharp-ts-mode's font-lock features Reply-To: bug#60376 <60376@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:13:48 +0000 retitle 60376 29.0.60; Standardize csharp-ts-mode's font-lock features reassign 60376 emacs submitter 60376 Yuan Fu severity 60376 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 28 03:25:33 2022 Received: (at submit) by debbugs.gnu.org; 28 Dec 2022 08:25:33 +0000 Received: from localhost ([127.0.0.1]:57044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pARkj-0008Tl-9Y for submit@debbugs.gnu.org; Wed, 28 Dec 2022 03:25:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:51860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pARkg-0008Tc-Ni for submit@debbugs.gnu.org; Wed, 28 Dec 2022 03:25:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pARkg-0005yY-FO for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 03:25:30 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pARke-0002GS-Ba for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 03:25:30 -0500 Received: by mail-pl1-x633.google.com with SMTP id jl4so9170747plb.8 for ; Wed, 28 Dec 2022 00:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=MnG+A1lvxxmlkLqHibLw7v1DSOt+6PDaiq0ta3RAKvs=; b=fnZJPQ6VMeCNEfGsV+h4Rnl8q6nT3t+kCswdCGYOiqF6yuQjMzSPcvOfzNdqRtaK2Y nFGnkmuv2IWKj0zQZoScHpbU6eSU1iuILHPdiEfjZo55j6OpBxGssPZOEjA5oJQPSVgl d+g83BahiQj5FYSycQQYOsASAqcr3mVE1zU0ZAA3D6dj6ea/42OA/w+M8D71PuTzWRZT md8DZSREMgr5jZwESujQibu939k+oaKqEFMCIGjvxeX6rWlz0bRamIUefhtQAOZRTrUy 3vo4A0PYR+Cnyx8fxaLrNUgEcYRcsCweyLanDUWkqX4zaKIVWa6OjJgcYhbDYtl/5QO7 zYBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MnG+A1lvxxmlkLqHibLw7v1DSOt+6PDaiq0ta3RAKvs=; b=3o/q5SuO0dhN8kIxa58RV7CFcl6XHtTH94WJ4L1dk7/SiUFRKJJMXE7IIn7ySt9obC hEM6Qf7JV7FCwyKRvXW19YPxeQOfXyYTq59jS9tcFRFh3HxghLeJ++0274ZP2CGYTbu8 Oi2D6Qq57RCP16dgKzF9mK+eJiuMNITwBNR2w4twoiK7LsncTFt5G93gJ4Oi7QESkVTf yWAnxh/WsnDtBQo+lf1N6+ttcm/1dOMKbGyNHUp6SBUewW7XkgIntQ+CjxHvtd0iLwlX GPV7/hAOCAVzyoe56BC4RhyoZGB8FT+9HthfcnbPmIqbacD6H6Pc//9BuMDpBkLjjc5R LuHg== X-Gm-Message-State: AFqh2kpadu2G6RoXHhJdzTTPnY7NlUmp6LvFpy3h2muhurZyda+OsSBA YBGLpw3uY7oD9bYZtqAafscAq546Vhs= X-Google-Smtp-Source: AMrXdXtZFWSVYmOSFQ8nhR8k/tjB7OaEuhLXMJqhsGe9IWl7LuQcAIlFnVZszjIjoS5DxQUntIaVRw== X-Received: by 2002:a17:902:9a0b:b0:189:d3dc:a9c4 with SMTP id v11-20020a1709029a0b00b00189d3dca9c4mr23385440plp.36.1672215925981; Wed, 28 Dec 2022 00:25:25 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id im22-20020a170902bb1600b00192944e3650sm1190041plb.268.2022.12.28.00.25.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Dec 2022 00:25:25 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: 29.0.60; Standardize csharp-ts-mode's font-lock features Message-Id: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> Date: Wed, 28 Dec 2022 00:25:24 -0800 To: Bug Report Emacs X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=casouri@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hey Theo and Jostein, As the complete feature freeze approaching, I think it=E2=80=99s a good = time to standardize the font-lock features. Below is the change I would make to csharp-ts-mode: - take string_interpolation out of string - add function, variable feature - change attribute to property - expression is not in the list, no harm to keep it around, of course - maybe add assignment feature Feel free to correct me if I misunderstood anything. TIA! Below is the list of standard features, for your reference: Basic tokens: delimiter ,.; (delimit things) operator =3D=3D !=3D || (produces a value) bracket []{}() misc-punctuation anything else constant true, false, null number keyword comment (includes doc-comments) string (includes chars and docstrings) string-interpolation f"text {variable}" escape-sequence "\n\t\\" function every function identifier variable every variable identifier type every type identifier property a.b <--- highlight b key { a: b, c: d } <--- highlight a, c error highlight parse error Abstract features: assignment: the LHS of an assignment (thing being assigned to), eg: a =3D b <--- highlight a a.b =3D c <--- highlight b a[1] =3D d <--- highlight a definition: the thing being defined, eg: int a(int b) { <--- highlight a return 0 } int a; <-- highlight a struct a { <--- highlight a int b; <--- highlight b } From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 14:55:24 2022 Received: (at 60376) by debbugs.gnu.org; 29 Dec 2022 19:55:24 +0000 Received: from localhost ([127.0.0.1]:32969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAyzs-0006hE-9v for submit@debbugs.gnu.org; Thu, 29 Dec 2022 14:55:24 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:35559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAyzq-0006h1-OF for 60376@debbugs.gnu.org; Thu, 29 Dec 2022 14:55:23 -0500 Received: by mail-pl1-f178.google.com with SMTP id y19so832029plb.2 for <60376@debbugs.gnu.org>; Thu, 29 Dec 2022 11:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=aoM1SQhhX9JwiL0Cbi+raUF14wap0ZiUEn8xCqlnH1M=; b=BfsSCc/hkQtgxNAUAsy+o711+zFZKt3TaX3ene3dtGyh98N4fxm+A38NsjvIjkMMy1 RQHqppnkUlBIg9+wq87hgXG7Jq7W5NF3J2GHdF3movyTvT7BmXJGnidfCs+FvEh6SFOG QYoU4W8Aqc8YYnhlLpvr8ejFSAu96Am0IGYR3C35qdeon6fPh6E6IZk9+qbTKPQ6SQJJ kgyNIgYE81tOID//rRf1ruRVMFj27sTSIOuEXAVhU93gE6IfIFV7eMoi9jZjl2QPlMit DAZ9/4FEVLCw7efL/mhQHshFzFckh/9zpE6omMSQQp0gDI3rIKGJoHBtkU5yye2bIX5b ABag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aoM1SQhhX9JwiL0Cbi+raUF14wap0ZiUEn8xCqlnH1M=; b=J/W1m1ZN92aesysBt3lhP3ef5RILhLTOqB0o93Yr22xYwthPGh7MOBOCNrNr51qb9s sSJXMkU61ljJPwjBHen2O9fy7kolZ43tkGlV4h7bWulSE7CGJnClYMkAQQ9pm8H92AzM iV7E4lZvbGN45Lc63VKz2uDITERe8774RHg5wTGQOW5Zl6HJJ2w54y7BJEJTRQekOhEL Yw2Ha2FaN63acWX8lE6DiTYHdt2MWnfx4fWwNp3MPjcEBDmgdH1sgtWi7mhtqLwbSHIr mPA8dBeycljZIFeSLE3RG4eC9J63sjM4b1+cbMwQp50WvW5dxAnC5DZ37WMUNeJBr5Q/ tS4w== X-Gm-Message-State: AFqh2kqWAHIRj+WdPt5RYyT5700ZGnOHc5xm1t3JWgoVDyCO61YFy4Ex KE3PeJcwGEavfcddA02W19i/ng9WNwT2vw== X-Google-Smtp-Source: AMrXdXs/eZWV9HiM3ADqssziSPgI9c5fbdwvAzGyJtrWRJXpdj7sTr2Kq4loHTLJYCaKO1tkGQUYIQ== X-Received: by 2002:a17:902:7488:b0:189:f708:9b67 with SMTP id h8-20020a170902748800b00189f7089b67mr32875274pll.46.1672343716825; Thu, 29 Dec 2022 11:55:16 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 13-20020a170902e9cd00b00188fdae6e0esm13407934plk.44.2022.12.29.11.55.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Dec 2022 11:55:16 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Message-Id: Date: Thu, 29 Dec 2022 11:55:15 -0800 To: 60376@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= , Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I probably didn=E2=80=99t get the X-Debbugs-CC thing right, CC=E2=80=99ing= Theo and Jostein manually :-) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 16:03:21 2022 Received: (at 60376) by debbugs.gnu.org; 29 Dec 2022 21:03:22 +0000 Received: from localhost ([127.0.0.1]:33033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB03d-0008Sv-1s for submit@debbugs.gnu.org; Thu, 29 Dec 2022 16:03:21 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:57103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB03a-0008Sf-36 for 60376@debbugs.gnu.org; Thu, 29 Dec 2022 16:03:19 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EF97332005BC; Thu, 29 Dec 2022 16:03:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 29 Dec 2022 16:03:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm1; t= 1672347791; x=1672434191; bh=tmplBodXn2e0NhNb4N18W+pE66Yzz4eBrN8 IJphsWf4=; b=cP9Hs2kZlgej4nITlrzZ78D+Jh9MME39IJgvkX4Q/1Og3WOzFOy 8iAiSsB1T3OJLibMTJAUD2FzIVSHShMXNsfHvC9hBiwndf/pDn3pqMNxMpRpeVK1 gNrjw5vLU1q3FTz8j9S8U0YCNudxbbONPmuprCImcjpAvSK53QkmkGFNhBE2xpPx GogXLJ0lwu1uL9Q+0ZlyJCR8sdkilQW3agdShOfN+ZbGmFwGw/rpTHOCoYTRht1t tyQvSvPxnW6EVoUjB0WQfSxigfCWcfVVTtQ4q8Wg5CkkE/t6N+hWrae6hA0bkEGX lwO1RPDWf3hAU0nvJ3qXnP2iBA1OJ+q23Zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1672347791; x=1672434191; bh=tmplBodXn2e0N hNb4N18W+pE66Yzz4eBrN8IJphsWf4=; b=NU64WpVfvpQNXVdjZNKHUxm/NI96S DlP60AYOkaLEjan98UOaV/DiiymDWzVbHAIdjMvDIl6Jy8/0PFGSmJVLBSB5yMZ/ TvyNk8+j4H7JHLefp/thN2IDPL3XoaTQw0vFakG+x88IiT/1Z51OnXbrYPj7+ctr pup3dCWruM0nIGtHWoZJ/L1CXSUAbY1CXEu/nLub+0PycsnPuMfKrM/V0OdsCJoV 6mR181dMwDn/pRi55sMiSqtHgH3x2vaVyXgkvL0YwCCndo3PYLfndd8pX3bH9raj pXTdbdEm4ivsPzNXbTtHj/C6e3aVsDD1c3qU+1UwBuysYrrh6IMKagvWw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieeggddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffvvehfhfgjsegrtderredtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeeiudejgedthfejieehteefvdfh ffejhfdvfeduteehtdevjeelhffgudehgfdvueenucffohhmrghinhepghhnuhdrohhrgh dpkhhjnhhighhsvghnrdhnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnh gvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Dec 2022 16:03:10 -0500 (EST) Content-Type: multipart/alternative; boundary="------------m3S8A8W0wNE023hgssGziAF7" Message-ID: Date: Thu, 29 Dec 2022 22:03:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features To: Yuan Fu , 60376@debbugs.gnu.org References: Content-Language: en-GB, nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 60376 Cc: Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) This is a multi-part message in MIME format. --------------m3S8A8W0wNE023hgssGziAF7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hey Yuan. Thanks for the heads up! To be quite honest, that's quite a lot of stuff in such a "little" bug, so if it's OK, I think we should start on the top and work our way down. So a "complete feature freeze" is approaching. That makes complete sense, and I respect that. Are there any exact deadlines or dates we'd like to stay ahead of, or is this more an abstract thing, until Emacs 29 is eventually deemed ready for release? While standardizing font-lock features is probably a good thing, at the end of the day, it does mean changing working code. In that regard, I'd like to ensure we don't change more than we need to, to not impose any unneeded risk near the feature freeze and eventual Emacs 29 release. Basically, whatever objections I may have, please assume them to be in good faith. As far as standardizing the features, which bar are we standardizing them against, or along with? Are other modes getting standardized as well? In case, which? To take a personal nitpick as an example... python-ts-mode does not even highlight function-invocations, despite me having sent in patches to fix that[1]? How does that play into this standardization? I can't say I've seen much response to my bug-report or patch so far, and I mean... We can't standardize features which are not yet even implemented, right? In which case, I feel some issues should take precedence over others. I'm not trying to be difficult or anything, but whenever I hear about standardization, I feel these are important questions to ask. Left unresolved they can often leads to disenfranchising people from their own works, if they are left feeling like they are forced to make changes they disagree with or dont see the benefits of. I really think this "small" part could definitely use a little more details. What's our grand plan? How many major-modes does it involve? And last how much time do we have? Basically: is the overall plan realistic within the timelines we have? So before moving into details about csharp-ts-mode specifically, I'd love to see at least some links to the discussion space where the overall standardization has been discussed. For the time being, or for now at least, I would be against any standardization-related changes taking place in csharp-ts-mode until I've seen such a discussion and been able to raise my voice about any concerns I may have there, if any. Does that make sense? Or does that seem unreasonable or entitled of me? [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59977 Kind regards *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 29.12.2022 20:55, Yuan Fu wrote: > I probably didn’t get the X-Debbugs-CC thing right, CC’ing Theo and > Jostein manually :-) Hey Theo and Jostein, As the complete feature freeze approaching, I think it’s a good time to standardize the font-lock features. Below is the change I would make to csharp-ts-mode: - take string_interpolation out of string - add function, variable feature - change attribute to property - expression is not in the list, no harm to keep it around, of course - maybe add assignment feature Feel free to correct me if I misunderstood anything. TIA! Below is the list of standard features, for your reference: Basic tokens: delimiter ,.; (delimit things) operator == != || (produces a value) bracket []{}() misc-punctuation anything else constant true, false, null number keyword comment (includes doc-comments) string (includes chars and docstrings) string-interpolation f"text {variable}" escape-sequence "\n\t\\" function every function identifier variable every variable identifier type every type identifier property a.b <--- highlight b key { a: b, c: d } <--- highlight a, c error highlight parse error Abstract features: assignment: the LHS of an assignment (thing being assigned to), eg: a = b <--- highlight a a.b = c <--- highlight b a[1] = d <--- highlight a definition: the thing being defined, eg: int a(int b) { <--- highlight a return 0 } int a; <-- highlight a struct a { <--- highlight a int b; <--- highlight b } --------------m3S8A8W0wNE023hgssGziAF7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hey Yuan.

Thanks for the heads up!

To be quite honest, that's quite a lot of stuff in such a "little" bug, so if it's OK, I think we should start on the top and work our way down.

So a "complete feature freeze" is approaching. That makes complete sense, and I respect that. Are there any exact deadlines or dates we'd like to stay ahead of, or is this more an abstract thing, until Emacs 29 is eventually deemed ready for release?

While standardizing font-lock features is probably a good thing, at the end of the day, it does mean changing working code. In that regard, I'd like to ensure we don't change more than we need to, to not impose any unneeded risk near the feature freeze and eventual Emacs 29 release. Basically, whatever objections I may have, please assume them to be in good faith.

As far as standardizing the features, which bar are we standardizing them against, or along with? Are other modes getting standardized as well? In case, which?

To take a personal nitpick as an example... python-ts-mode does not even highlight function-invocations, despite me having sent in patches to fix that[1]? How does that play into this standardization? I can't say I've seen much response to my bug-report or patch so far, and I mean... We can't standardize features which are not yet even implemented, right? In which case, I feel some issues should take precedence over others.

I'm not trying to be difficult or anything, but whenever I hear about standardization, I feel these are important questions to ask. Left unresolved they can often leads to disenfranchising people from their own works, if they are left feeling like they are forced to make changes they disagree with or dont see the benefits of.

I really think this "small" part could definitely use a little more details. What's our grand plan? How many major-modes does it involve? And last how much time do we have? Basically: is the overall plan realistic within the timelines we have?

So before moving into details about csharp-ts-mode specifically, I'd love to see at least some links to the discussion space where the overall standardization has been discussed.

For the time being, or for now at least, I would be against any standardization-related changes taking place in csharp-ts-mode until I've seen such a discussion and been able to raise my voice about any concerns I may have there, if any.

Does that make sense? Or does that seem unreasonable or entitled of me?


[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59977


Kind regards
 Jostein Kjønigsen
jostein@kjonigsen.net 🍵 jostein@gmail.com
 https://jostein.kjønigsen.no
On 29.12.2022 20:55, Yuan Fu wrote:
I probably didn’t get the X-Debbugs-CC thing right, CC’ing Theo and
Jostein manually :-)


Hey Theo and Jostein,

As the complete feature freeze approaching, I think it’s a good time to
standardize the font-lock features. Below is the change I would make to
csharp-ts-mode:

- take string_interpolation out of string
- add function, variable feature
- change attribute to property
- expression is not in the list, no harm to keep it
  around, of course
- maybe add assignment feature

Feel free to correct me if I misunderstood anything. TIA!

Below is the list of standard features, for your reference:

Basic tokens:

delimiter       ,.;      (delimit things)
operator        == != || (produces a value)
bracket         []{}()
misc-punctuation  anything else

constant        true, false, null
number
keyword
comment         (includes doc-comments)
string          (includes chars and docstrings)
string-interpolation    f"text {variable}"
escape-sequence         "\n\t\\"
function                every function identifier
variable                every variable identifier
type                    every type identifier
property                a.b  <--- highlight b
key                     { a: b, c: d } <--- highlight a, c
error                   highlight parse error

Abstract features:

assignment: the LHS of an assignment (thing being assigned to), eg:

a = b    <--- highlight a
a.b = c  <--- highlight b
a[1] = d <--- highlight a

definition: the thing being defined, eg:

int a(int b) { <--- highlight a
return 0
}

int a;  <-- highlight a

struct a { <--- highlight a
int b;   <--- highlight b
}
--------------m3S8A8W0wNE023hgssGziAF7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 17:16:25 2022 Received: (at 60376) by debbugs.gnu.org; 29 Dec 2022 22:16:25 +0000 Received: from localhost ([127.0.0.1]:33092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB1CK-0001qO-Eu for submit@debbugs.gnu.org; Thu, 29 Dec 2022 17:16:24 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:38772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB1CH-0001q9-Ep for 60376@debbugs.gnu.org; Thu, 29 Dec 2022 17:16:22 -0500 Received: by mail-qt1-f174.google.com with SMTP id z12so16019883qtv.5 for <60376@debbugs.gnu.org>; Thu, 29 Dec 2022 14:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=RZZJo+QR3qKVE/QQZfYpUsy+UbFV5wwvrykKKCgkap4=; b=cmOOs4MNvN5bUP9b9K9RGF+5gxQOl/79i4JE20s7bPHaWdF6pbTQ1/r4i0rKEZfAUo OYnCENqYkZSkX5o355sVj2LijUiGPK2InFNofvcxK5n4IF7s8HBGUt+JnkLx+z3JLm4e GOuFImq/IFUKZXkwR6glsJIb5yf8RTDACqvgOE3eTsAWdGyKtTytDXgOH0hPQBA2LU2o VBsgRMcebRmfhtXMaTyBY2VWsGFZWXc9bKp4QJfkBOrX/i5ecnMWweVnr08t4snWjnGN QEJP3NaI5ie5eLwt/LIywkL33SsdjiP9PPFOUyDky9U7muoP5ebBjcRsE+GsS29WhQ5A A4XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RZZJo+QR3qKVE/QQZfYpUsy+UbFV5wwvrykKKCgkap4=; b=pRq50d2Y4SpS1JlkVtJWC5l33xCewIPJSmZ/mIRP3N7InQ0xUQo82O/KmWwRX+V02Q wlw/l558XUxoiL2Q6/1xnD6biWNDGAWg7cwC+pcGb/56lteujUQH945y5EQ26pEVZ6jM GHhKcUVSBx3QI/izhY4KAp8IQ97ItaiCmspPEZL8GEdCJuiG+VlvMMKdcV5A8bwXZu+4 DZ+NMPPeBfbcspH1972/tDWy5Too8W6Z9t8ab8EhzeQKH9e+3on+nHolTCiVcJtTXe3r KS/yIitVvkHK9LsUy8qMEwIzEA21Tta3SrzUZx5ete+LWjSi/f43Kikte9sZjG3k0dnv EfhA== X-Gm-Message-State: AFqh2kpsdIPvYe7KKIYK33swnq/+vPJXwHZHAIFcZahu33JkyAlBOitS sjjTALpiosLopGAH5XFoEks6mw/a2z4iHQ== X-Google-Smtp-Source: AMrXdXu618nlrIjaanYqRinifydsUh8cMxfDWrGkk7RRgqB16XigryNJU1XVBkfD5vxm/EXuG9hu9g== X-Received: by 2002:a05:622a:5c1a:b0:3a6:c4eb:2e52 with SMTP id gd26-20020a05622a5c1a00b003a6c4eb2e52mr44305886qtb.43.1672352175735; Thu, 29 Dec 2022 14:16:15 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id bn35-20020a05620a2ae300b00702311aea78sm13706719qkb.82.2022.12.29.14.16.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Dec 2022 14:16:15 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Message-Id: Date: Thu, 29 Dec 2022 14:16:13 -0800 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Hey Yuan. > > Thanks for the heads up! > > To be quite honest, that's quite a lot of stuff in such a "little" = bug, so if it's OK, I think we should start on the top and work > our way down. > > So a "complete feature freeze" is approaching. That makes complete = sense, and I respect that. Are there any exact > deadlines or dates we'd like to stay ahead of, or is this more an = abstract thing, until Emacs 29 is eventually deemed ready > for release? I heard that it=E2=80=99s in a few days (from Eli). I believe the idea = is that no more new features could be added to emacs-29 branch, only bug fixes. This actually should=E2=80=99ve happened when emacs-29 was cut, but = tree-sitter features had an exemption because it was merged relatively late. > While standardizing font-lock features is probably a good thing, at = the end of the day, it does mean changing working > code. In that regard, I'd like to ensure we don't change more than we = need to, to not impose any unneeded risk near the > feature freeze and eventual Emacs 29 release. Basically, whatever = objections I may have, please assume them to be in > good faith. > > As far as standardizing the features, which bar are we standardizing = them against, or along with? Are other modes > getting standardized as well? In case, which? I=E2=80=99m working on python and javascript. Newer modes I think more = or less follows the "standard list" since they are created after the discussion of that list. > To take a personal nitpick as an example... python-ts-mode does not = even highlight function-invocations, despite me > having sent in patches to fix that[1]? How does that play into this = standardization? I can't say I've seen much response to > my bug-report or patch so far, and I mean... We can't standardize = features which are not yet even implemented, right? In > which case, I feel some issues should take precedence over others. I applied your patch, with some modification (so it aligns with the standard list). Looking at the bug report, I must=E2=80=99ve forgot to = reply to you after I made the change. That=E2=80=99s my fault. > I'm not trying to be difficult or anything, but whenever I hear about = standardization, I feel these are important questions > to ask. Left unresolved they can often leads to disenfranchising = people from their own works, if they are left feeling like > they are forced to make changes they disagree with or dont see the = benefits of. > > I really think this "small" part could definitely use a little more > details. What's our grand plan? To make features of each tree-sitter major mode more consistent. We wouldn=E2=80=99t want features that has the same name but different = meaning, or features of the same meaning but different name. > How many major-modes does it involve? Ideally all the built-in major modes. > And last how much time do we have? Basically: is the overall plan = realistic within the timelines we have? I=E2=80=99m merely suggesting potential improvements to csharp-ts-mode. = As the maintainer of it, whether it is possible or desirable to make the changes will be your call ;-) > So before moving into details about csharp-ts-mode specifically, I'd = love to see at least some links to the discussion space > where the overall standardization has been discussed. The initial discussion happened on here: https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg01544.html I just posted a general call to standardize major mode font-lock features, which stirred up a new discussion about the standard list (as discussion on mailing lists go :-), it started at here: https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01202.html Maybe I should CC people that would be interested in such discussion. > For the time being, or for now at least, I would be against any = standardization-related changes taking place in > csharp-ts-mode until I've seen such a discussion and been able to = raise my voice about any concerns I may have there, if > any. > > Does that make sense? Or does that seem unreasonable or entitled of = me? Your doubts are completely reasonable. As I said, you are the maintainer of csharp-mode.el, not me, so you can regard my words as a suggestion rather than request. (Or perhaps nice suggestive request ;-) Yuan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 03:19:54 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 08:19:54 +0000 Received: from localhost ([127.0.0.1]:33492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBAcM-00088R-Bk for submit@debbugs.gnu.org; Fri, 30 Dec 2022 03:19:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBAcK-00088E-5V for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 03:19:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBAcE-0007Hq-EY; Fri, 30 Dec 2022 03:19:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YNMocPkJyJHi15US7mR3t5o4Arr6U9y038oia7C32RE=; b=cpQWFkEqIL4IdRJ83UFQ yO6HXjfuy2PVpcFIpPi5AwB8xG717TkYvWnigwT15iygpsFVuwvM0zJXNhcxO83bvss8cY/JuGi6v uLYMleB6pRfdlPaPRI8pHwtSByabr6PYRQ5SEJF//X/gla+np5M+ILjtPlcZdAFc1PTwZt3J+2T3d NYoosMZ2NYZks4qXLc0hjkDpWK0Tc2t+dfGmbUhk2FBI0hDxVDKfs5Zfw7WP8ayv3LcCeIml/PODg 7pvEaGDq7jjWdCYiFbGueS9SUVlcz3kXuYjFDA1N+lMuYJzCdPX1e3WDu9h2h0cUSmOrabSMpg1ch rxpEOmz6EOiFXg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBAcA-0006Ig-Jy; Fri, 30 Dec 2022 03:19:45 -0500 Date: Fri, 30 Dec 2022 10:19:41 +0200 Message-Id: <83lemp717m.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Thu, 29 Dec 2022 14:16:13 -0800) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, jostein@secure.kjonigsen.net, jostein@kjonigsen.net, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no > From: Yuan Fu > Date: Thu, 29 Dec 2022 14:16:13 -0800 > > > So a "complete feature freeze" is approaching. That makes complete sense, and I respect that. Are there any exact > > deadlines or dates we'd like to stay ahead of, or is this more an abstract thing, until Emacs 29 is eventually deemed ready > > for release? > > I heard that it’s in a few days (from Eli). That was a few days ago ;-) So now it's "any day now". > I believe the idea is that no more new features could be added to > emacs-29 branch, only bug fixes. This actually should’ve happened > when emacs-29 was cut, but tree-sitter features had an exemption > because it was merged relatively late. Yes. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 03:21:35 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 08:21:35 +0000 Received: from localhost ([127.0.0.1]:33497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBAdy-0008Bk-RA for submit@debbugs.gnu.org; Fri, 30 Dec 2022 03:21:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBAdx-0008BV-5z for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 03:21:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBAdq-0007nk-6y; Fri, 30 Dec 2022 03:21:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=TyRk4/iTfKpXtmeEJNoQI8Njhw+wy6q8sL+OIY6wXXc=; b=mh6//cG6RwnDMn8s8Vw2 7T2I0QK3vU3sHayIy3mZPGe+2fqYpH/T8/Hf9NrGudr+YLtuvOyeCe9JNRFTnnJUjAbk8Cnfku4H5 NXMAFYTLSRV1JpBYOj/8klzNMxrsxbcl5sBCKgYATu1IdKagpSLJSeLkRbeFyfrkMRzyuElvicEe9 /EPc+FB4MnGS4yFofm1j/9M/i+KmyRic+hrVq9LBeCcUGPdZTYLDIscT7XeK9j8DxmqDX77gnuOsX 0a9vbFau9AwquTJZhNeV+L3bvICJdKSodLytpE2xVbScz7EJy8Nia3jdIxgaLuClWmb0LISX5Jk/x QU3i+XHKP80O3Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBAdp-0006aI-Ly; Fri, 30 Dec 2022 03:21:26 -0500 Date: Fri, 30 Dec 2022 10:21:24 +0200 Message-Id: <83k029714r.fsf@gnu.org> From: Eli Zaretskii To: jostein@kjonigsen.net In-Reply-To: (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Thu, 29 Dec 2022 22:03:06 +0100) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Theodor Thornhill > Date: Thu, 29 Dec 2022 22:03:06 +0100 > From: Jostein Kjønigsen > > While standardizing font-lock features is probably a good thing, at the end of the day, it does mean changing > working code. In that regard, I'd like to ensure we don't change more than we need to, to not impose any > unneeded risk near the feature freeze and eventual Emacs 29 release. Basically, whatever objections I may > have, please assume them to be in good faith. > > As far as standardizing the features, which bar are we standardizing them against, or along with? Are other > modes getting standardized as well? In case, which? > > To take a personal nitpick as an example... python-ts-mode does not even highlight function-invocations, > despite me having sent in patches to fix that[1]? How does that play into this standardization? I can't say I've > seen much response to my bug-report or patch so far, and I mean... We can't standardize features which > are not yet even implemented, right? In which case, I feel some issues should take precedence over others. > > I'm not trying to be difficult or anything, but whenever I hear about standardization, I feel these are important > questions to ask. Left unresolved they can often leads to disenfranchising people from their own works, if > they are left feeling like they are forced to make changes they disagree with or dont see the benefits of. This is eventually up to you. You can always go with what your gut feeling is about what's TRT, and correct that later if necessary, given the user feedback and maintenance experience we collect. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 08:35:57 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 13:35:57 +0000 Received: from localhost ([127.0.0.1]:33738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBFYC-0004jQ-Tu for submit@debbugs.gnu.org; Fri, 30 Dec 2022 08:35:57 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBFYA-0004jE-P7 for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 08:35:56 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id ABAF55C0035; Fri, 30 Dec 2022 08:35:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 30 Dec 2022 08:35:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1672407349; x=1672493749; bh=2o 48v13D04S6/Fk8NWneJLz61aaMce3hXSncBmq0EMM=; b=VuCKDufOa79whHWouo JbHoQCvZnFWZfWveD9a/aG+A2RdcyEYWemBWI+lYJhC03bNeEk979/DUCr0ZP0xW mgKXO1DfC/weT7Jakk7TYczED6ewogAEsoaPaqO87YJarg0LmZkwIMpoLTSgvrp/ oR7J8yZ26XevvzPEw6LAH9k+gOEDhi9ab6fTMtZ5OTCQKQ9K3WFgIBGQkqMo1PgL dtwojoAbFOQmpG+5Md4e0poo/GYyM6KzKRY/oYqlDjUR7+67zSzuLfL6Bi5ZA2pM CZU+6XBAz9yJdXs3F6maz56jMePSKIrxIwa3KrgSFPp9ypBKdC5UmSuq1ZVADOvn P8yA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672407349; x=1672493749; bh=2o48v13D04S6/Fk8NWneJLz61aaMce3hXSn cBmq0EMM=; b=w60JKwSzh0Sh+/cLQFkwYqrEWSFbjUTEPB2Pt0gxU0oiW5nLZZP zVGhXLdRe5VJ8SBHYoUxE66jdUnOvPaYvasrgYjtutC2H+u30+ExaFDG84AKKWhR BmsjCn6fwdp9wTIfCycASR0yWKN0V/SvRtC9bWy90p6ThjNV8JKiKyDvmhMJl6uK NtI4jwHmkOmltRJYwjZE4sFv+Ol3s3i+7VZL+8/CZNBdTCga67U0//FjZi2S1xUe 4XHm9vofj/5Mq8ZGcZ8fD3DdivUX9QMsdp3VjEz1bPN9/UzXkUDYty4rneS4gjp/ k6emPPGYbZwMcAMjFVWmURRMKgspUgqzxiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieeigdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpedtfedtkedtffeukedvvddvkeeu veduvdeitdfffffggfegledtkeehgfdtjeekveenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Dec 2022 08:35:48 -0500 (EST) Message-ID: <4bb171b5-71d8-d265-0bf6-d688b5146603@secure.kjonigsen.net> Date: Fri, 30 Dec 2022 14:35:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Content-Language: en-GB, nb-NO To: Eli Zaretskii , Yuan Fu References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> <83lemp717m.fsf@gnu.org> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <83lemp717m.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no >> From: Yuan Fu >> Date: Thu, 29 Dec 2022 14:16:13 -0800 >> >>> So a "complete feature freeze" is approaching. That makes complete sense, and I respect that. Are there any exact >>> deadlines or dates we'd like to stay ahead of, or is this more an abstract thing, until Emacs 29 is eventually deemed ready >>> for release? >> I heard that it’s in a few days (from Eli). > That was a few days ago ;-) So now it's "any day now". Ok. That's unfortunate timing. To be clear, I think it's absolutely realistic to get csharp-ts-mode to adhere to some of the guidelines outlined in the tree-sitter-standardization thread. But it's completely unrealistic (at least on my part) to get any well-crafted and well-tested changes into csharp-ts-mode until after new-years. Maybe Theo has time for this? -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 09:15:58 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 14:15:58 +0000 Received: from localhost ([127.0.0.1]:33774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGAw-0005l0-4w for submit@debbugs.gnu.org; Fri, 30 Dec 2022 09:15:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGAu-0005kk-QQ for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 09:15:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBGAo-0007xh-Vu; Fri, 30 Dec 2022 09:15:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=m5kiQbd6ZkqdPt7C+2P2hLUyIvX8Svhx132mcDzP8n8=; b=FPKVSLpo0byEdonkdZIW vJN1gPK+kuauXZ7vu+/zY0/pYnrfQQQVA+OX2AIIRG5COJ6qou+2oH6yVwRtmjicgEJmzBsCZCX3H bq8oG/g/4usauqyh+4ltF4/J/uHj2qdUZX5D557cyXudXJNbvj1NWnxuB6hAO8aLQoADSuiEkblPr 6G/6GS7F24FTcWdBkGnclhNI8VUgZML8lpp0ArjLkBWnKOzyc2bm75YiA1SCYiG/QfDpj3vkpW66B auIgN/gGrlVdnKMJagMLCroT7i+OoLYAe7pKAAfKuL0e4giFLrB4P28uoW4qF/8XnKBjPmbFnzqEk 3KUYlg6l8mYrNw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBGAo-0000BO-F0; Fri, 30 Dec 2022 09:15:50 -0500 Date: Fri, 30 Dec 2022 16:15:48 +0200 Message-Id: <838rip6kq3.fsf@gnu.org> From: Eli Zaretskii To: jostein@kjonigsen.net In-Reply-To: <4bb171b5-71d8-d265-0bf6-d688b5146603@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Fri, 30 Dec 2022 14:35:46 +0100) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> <83lemp717m.fsf@gnu.org> <4bb171b5-71d8-d265-0bf6-d688b5146603@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com, jostein@kjonigsen.net, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 30 Dec 2022 14:35:46 +0100 > Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no > From: Jostein Kjønigsen > > Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no > >> From: Yuan Fu > >> Date: Thu, 29 Dec 2022 14:16:13 -0800 > >> > >>> So a "complete feature freeze" is approaching. That makes complete sense, and I respect that. Are there any exact > >>> deadlines or dates we'd like to stay ahead of, or is this more an abstract thing, until Emacs 29 is eventually deemed ready > >>> for release? > >> I heard that it’s in a few days (from Eli). > > That was a few days ago ;-) So now it's "any day now". > > Ok. That's unfortunate timing. > > To be clear, I think it's absolutely realistic to get csharp-ts-mode to > adhere to some of the guidelines outlined in the > tree-sitter-standardization thread. > > But it's completely unrealistic (at least on my part) to get any > well-crafted and well-tested changes into csharp-ts-mode until after > new-years. If you can come up with a 85% correct code soon, and leave the rest for bug-fixing, that's also acceptable. Otherwise, please understand my POV: we do want to release Emacs 29 soon. The tree-sitter related features already got a full month of slack, whereby new features were acceptable on the release branch. If we keep delaying the freeze, we will not release Emacs 29 any time soon. You have all been here for the past month, and I announced the rules loud and clear, so if some modes are still not up to speed with the latest treesit.el changes, then it's too bad, but we will have to wait for Emacs 30 with those. I'm sorry, but we do need to draw the line in the sand at some point: people are waiting for Emacs 29, and we cannot disappoint them. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 09:39:32 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 14:39:32 +0000 Received: from localhost ([127.0.0.1]:33802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGXj-0006M8-SE for submit@debbugs.gnu.org; Fri, 30 Dec 2022 09:39:32 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGXh-0006Lq-9j for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 09:39:29 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CB9A05C00D6; Fri, 30 Dec 2022 09:39:23 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 30 Dec 2022 09:39:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1672411163; x=1672497563; bh=qb N2Rk2bYuvb/Q1u2IBQbWXdKqLUNoBl+AKJQK6HRRE=; b=T2QKnWVAeEUjI0sR0w FFT09qQfg+0LC0RuTwKmzQJIrazZv+S+2BnIgBlnDSesq5U7Vt4VXWOaD7zUqCRU aDnWDWm+fp0TMJ+FKi4Zr5v80m3cYVrzWEtR7PgUBAQbvyBLNgRjRXFKws4Q1flD jaIZ8vSs1W7GUwPcCcpgTCYqOJsgABl70bMTGiOqQ3CAEpl6n7zTpJtw32geW/CC /k+3EiMOqYDnxWTjxV1hXJryTGrct12hnLLTRR44VCBicLw/BRfNogYl3+Oq4POI 0ozLo3XH/J2vkLt7J9SOm8SHUDxOdE8YytQd/W1suVXr+9+ZossRdR6z2OvHQjWf l4vw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672411163; x=1672497563; bh=qbN2Rk2bYuvb/Q1u2IBQbWXdKqLUNoBl+AK JQK6HRRE=; b=StHa66ehdDlhhykFa06oK8bIoGF+mIRyMaz/MRUpsPhvB4IkOq9 VXAdDqZ/hi3HY83tMNapb7yvfcKsZLipCPg+YHOPaVJiP6BDVPsjwIHbsLcM5SFo PVtqKT1RbPERCgdFrtKbyS5utdeE1FmxGyOSyhmdIneIGOxYoHJJy3FYUkGWi+SP hl0S2zlKx1xReN+iEaNO+38/wLuHz7bsNlf1EoqavcFrfp02rpNxJXN8rj126h9q SS3HTbMjpog6htFbl7NaP7a2cshU0AAWQV4nEJqey/mFN9Nmgq+QKATUxRxhsqgQ IsP/O1QYznj0lUENMOL9LqbRJw9fzhiiilQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieeigdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefhgeevvefhfeeffedtvdfhvdei ieffheeiheegheegtddtkeevffelteetgedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Dec 2022 09:39:22 -0500 (EST) Message-ID: <785dab0b-1b9b-6479-9e17-25effdff2ba2@secure.kjonigsen.net> Date: Fri, 30 Dec 2022 15:39:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Content-Language: en-GB, nb-NO To: Eli Zaretskii , jostein@kjonigsen.net References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> <83lemp717m.fsf@gnu.org> <4bb171b5-71d8-d265-0bf6-d688b5146603@secure.kjonigsen.net> <838rip6kq3.fsf@gnu.org> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <838rip6kq3.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On 30.12.2022 15:15, Eli Zaretskii wrote: >> Ok. That's unfortunate timing. >> To be clear, I think it's absolutely realistic to get csharp-ts-mode to >> adhere to some of the guidelines outlined in the >> tree-sitter-standardization thread. >> >> But it's completely unrealistic (at least on my part) to get any >> well-crafted and well-tested changes into csharp-ts-mode until after >> new-years. > If you can come up with a 85% correct code soon, and leave the rest > for bug-fixing, that's also acceptable. > > Otherwise, please understand my POV: we do want to release Emacs 29 > soon. The tree-sitter related features already got a full month of > slack, whereby new features were acceptable on the release branch. If > we keep delaying the freeze, we will not release Emacs 29 any time > soon. You have all been here for the past month, and I announced the > rules loud and clear, so if some modes are still not up to speed with > the latest treesit.el changes, then it's too bad, but we will have to > wait for Emacs 30 with those. I'm sorry, but we do need to draw the > line in the sand at some point: people are waiting for Emacs 29, and > we cannot disappoint them. I completely understand. I've left some thoughts about the standardization-process -in general- in the Emacs-devel thread, on how we should "cope" with exactly that situation. To be clear: I think csharp-ts-mode works well beyond 85% (it's what I use as my daily driver), but the syntax-highlighting at level 3 may be more excessive than some people (like Stefan) prefer. If we instead for these "major" changes suggested by Yuan, instead aim for just moving some "smaller" implementation-detail (function-invocations and property-highlighting) to level 4, I think we she be able to get something which is mostly what Stefan would expect and prefer, and it would be a much smaller change. Then we can take a look at those bigger changes (standardized features, enabling/disabling them individually, as end-users, etc) for Emacs-30. I think that's a more realistic plan. Does that sound OK? -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 09:40:53 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 14:40:53 +0000 Received: from localhost ([127.0.0.1]:33807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGZ3-0006OR-Ax for submit@debbugs.gnu.org; Fri, 30 Dec 2022 09:40:53 -0500 Received: from out-223.mta0.migadu.com ([91.218.175.223]:47826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGZ1-0006OJ-8T for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 09:40:52 -0500 Date: Fri, 30 Dec 2022 15:40:49 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672411249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uV0l2NrLE2bmtjkq6+O9imH55SVzZtplqI3yeocgTlM=; b=pom0n2vFDEVuH5JTcAikJa+Mi80aXIjIHmZ8Nz73vA0OTiDe6+LHE5HVKhoDWVfGKP9Rtl ZiS0vwaAppSb4/pe+OQ4Uij431NtUdQI9QNYE5U51ie2k17dtNPJZ8wHIf3SDmk+hXtvaD evmnGrXR9yeHJUXniinydfGZIwbFCSWYZfxacb/u0pixiGsEtXY5d+iF5mY5JLTw43hWhW 879GNf2eK80ToggvnwiHKRLLTvVMhKMpA+cq4d5JS9oW73JzfmAk2A4bn6JGNGh2OqNHUy UbuscwrGgj/p1xYw24l9cKyBZsPx0VFl6Ms+spzMKXyVXpKxmIAlFbigLWBW6w== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: Eli Zaretskii , jostein@kjonigsen.net Subject: =?US-ASCII?Q?Re=3A_bug=2360376=3A_29=2E0=2E60=3B_Standardize?= =?US-ASCII?Q?_csharp-ts-mode=27s_font-lock_features?= In-Reply-To: <838rip6kq3.fsf@gnu.org> References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> <83lemp717m.fsf@gnu.org> <4bb171b5-71d8-d265-0bf6-d688b5146603@secure.kjonigsen.net> <838rip6kq3.fsf@gnu.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 30 December 2022 15:15:48 CET, Eli Zaretskii wrote: >> Date: Fri, 30 Dec 2022 14:35:46 +0100 >> Cc: 60376@debbugs=2Egnu=2Eorg, jostein@kjonigsen=2Enet, theo@thornhill= =2Eno >> From: Jostein Kj=C3=B8nigsen >>=20 >> Cc: 60376@debbugs=2Egnu=2Eorg, jostein@kjonigsen=2Enet, theo@thornhill= =2Eno >> >> From: Yuan Fu >> >> Date: Thu, 29 Dec 2022 14:16:13 -0800 >> >> >> >>> So a "complete feature freeze" is approaching=2E That makes complet= e sense, and I respect that=2E Are there any exact >> >>> deadlines or dates we'd like to stay ahead of, or is this more an a= bstract thing, until Emacs 29 is eventually deemed ready >> >>> for release? >> >> I heard that it=E2=80=99s in a few days (from Eli)=2E >> > That was a few days ago ;-) So now it's "any day now"=2E >>=20 >> Ok=2E That's unfortunate timing=2E >>=20 >> To be clear, I think it's absolutely realistic to get csharp-ts-mode to= =20 >> adhere to some of the guidelines outlined in the=20 >> tree-sitter-standardization thread=2E >>=20 >> But it's completely unrealistic (at least on my part) to get any=20 >> well-crafted and well-tested changes into csharp-ts-mode until after=20 >> new-years=2E > >If you can come up with a 85% correct code soon, and leave the rest >for bug-fixing, that's also acceptable=2E > >Otherwise, please understand my POV: we do want to release Emacs 29 >soon=2E The tree-sitter related features already got a full month of >slack, whereby new features were acceptable on the release branch=2E If >we keep delaying the freeze, we will not release Emacs 29 any time >soon=2E You have all been here for the past month, and I announced the >rules loud and clear, so if some modes are still not up to speed with >the latest treesit=2Eel changes, then it's too bad, but we will have to >wait for Emacs 30 with those=2E I'm sorry, but we do need to draw the >line in the sand at some point: people are waiting for Emacs 29, and >we cannot disappoint them=2E I agree, but I'll see what I can do this evening=2E=20 Jostein, if you can take the patch I concoct for a spin I'm sure we can re= ach that 85% mark ;) Theo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 10:04:56 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 15:04:56 +0000 Received: from localhost ([127.0.0.1]:35920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGwJ-0007Zi-Ma for submit@debbugs.gnu.org; Fri, 30 Dec 2022 10:04:56 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGwI-0007ZT-8a for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 10:04:54 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6AC4A5C00DA; Fri, 30 Dec 2022 10:04:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 30 Dec 2022 10:04:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1672412687; x=1672499087; bh=c13yoUMNq1 v/rx3F0N3/qphTkZX1easvmWf5rR++0g0=; b=Hr8zage1ZyonHypzVHtESos0HE Ms7mYw+dGHG4lbLj28tjUpPNDYLQXCMZKyWFWeD9W3p2gZTVc9kYlQgrrYgJI6tD qIZYT8In5dL9ZKcd4cnVtDmqP/StjLKUcwGHpO7QOsrelqq326hLlm0t7bYiumsN tg5nVAoKqL9YbcQ3manyZEgowF6npjnNTWJR6ZdghmNJE+a6r2mk2vk6g/UKy4iz CDHSxGWeVLg/0xx3c/7jGzjupwCtUh/PmeuFxlxgcRZiMYbApjgnFiYiT/pKlgz2 x+5QvJUSIrNRYobzUeEv7AO9ENlwAemLc8f21jrUtkxQsYj5OgDDzqktc40A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672412687; x= 1672499087; bh=c13yoUMNq1v/rx3F0N3/qphTkZX1easvmWf5rR++0g0=; b=i CGzXP1snCmtFJtg2fLHcoQOwuXUX3cyRjn9WbWHeIovf6T7pb6XvJkvfcdXPpd2S nGbrZZK827PMy9ppqRNZTAbbYGkhRJdtukGM0fOye01k0h8UceG/Cm8/5CaYE7nC 3C1ZWUfpd5uETDUctNrl5xohAIq/JPGvwgXW+RBSq4d50fYMBlfcKnP0wj3QAf5B r/dJ8VpBhTAv3TZPpM0lhGcELhALoeyvGQ7bP3KgDhs9PsMYtaj8ZCwbUlfYdRJ3 cJZX+OeRgQsnaa8yAnINXhiHpoeBBcNS7tCiCf06BqTAByUu6VFgrA+a8MkcZeRv CFmKWAv4XjKFdhPoyKUSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieeigdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdtjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdeitdefudetveeghfegfeffhfeu ledtteevheekkeduhfejiefhvefffedugedtnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Dec 2022 10:04:46 -0500 (EST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Mime-Version: 1.0 (1.0) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Fri, 30 Dec 2022 16:04:34 +0100 Message-Id: <02943B08-CAC7-4FFF-B86F-7FE131D7DFDA@secure.kjonigsen.net> References: In-Reply-To: To: Theodor Thornhill X-Mailer: iPhone Mail (20C65) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, Eli Zaretskii , casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 30 Dec 2022, at 15:42, Theodor Thornhill wrote: >=20 > =EF=BB=BF >=20 > On 30 December 2022 15:15:48 CET, Eli Zaretskii wrote: >>> Date: Fri, 30 Dec 2022 14:35:46 +0100 >>> Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no >>> From: Jostein Kj=C3=B8nigsen >>>=20 >>> Cc: 60376@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no >>>>> From: Yuan Fu >>>>> Date: Thu, 29 Dec 2022 14:16:13 -0800 >>>>>=20 >>>>>> So a "complete feature freeze" is approaching. That makes complete se= nse, and I respect that. Are there any exact >>>>>> deadlines or dates we'd like to stay ahead of, or is this more an abs= tract thing, until Emacs 29 is eventually deemed ready >>>>>> for release? >>>>> I heard that it=E2=80=99s in a few days (from Eli). >>>> That was a few days ago ;-) So now it's "any day now". >>>=20 >>> Ok. That's unfortunate timing. >>>=20 >>> To be clear, I think it's absolutely realistic to get csharp-ts-mode to=20= >>> adhere to some of the guidelines outlined in the=20 >>> tree-sitter-standardization thread. >>>=20 >>> But it's completely unrealistic (at least on my part) to get any=20 >>> well-crafted and well-tested changes into csharp-ts-mode until after=20 >>> new-years. >>=20 >> If you can come up with a 85% correct code soon, and leave the rest >> for bug-fixing, that's also acceptable. >>=20 >> Otherwise, please understand my POV: we do want to release Emacs 29 >> soon. The tree-sitter related features already got a full month of >> slack, whereby new features were acceptable on the release branch. If >> we keep delaying the freeze, we will not release Emacs 29 any time >> soon. You have all been here for the past month, and I announced the >> rules loud and clear, so if some modes are still not up to speed with >> the latest treesit.el changes, then it's too bad, but we will have to >> wait for Emacs 30 with those. I'm sorry, but we do need to draw the >> line in the sand at some point: people are waiting for Emacs 29, and >> we cannot disappoint them. >=20 > I agree, but I'll see what I can do this evening.=20 >=20 > Jostein, if you can take the patch I concoct for a spin I'm sure we can re= ach that 85% mark ;) >=20 > Theo Sounds good. Sure thing! =E2=80=94 Jostein From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 10:39:15 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 15:39:15 +0000 Received: from localhost ([127.0.0.1]:35943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBHTW-0008OR-OX for submit@debbugs.gnu.org; Fri, 30 Dec 2022 10:39:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBHTU-0008OF-Vf for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 10:39:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHTO-0000mx-DZ; Fri, 30 Dec 2022 10:39:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=h6KaOQysk6/TKLhpccNjhYmtvQbS7t+i83u7cBsZNIA=; b=G6mPMiyVjAS2w/uXdd0W skXtp+G0OvqKKMZmr1vUzSa6CgVPlUIli0J64OMx4pC+q3JsAWET1KxtNlxQGCrZPYYMWx2p9WAbe 3kav6s7rRGftCSm1g0qjFvbooicMuwQSuHau/EFDLBH1yU/3G6NzE82sPdXuAejfzN0TLXxcqo3lq AznlzY/WBGegaxjYERiNIKLFTOHbWVQBdUV9U+F2c6SzTMRI64P5BFlbq6H7pezbnxFN/BT2lw81L mLU+dCuXRQGfQoW0TjypMauAi5pqmexuEnyJQ6NbG/2sRUiAyq9rJxCOuO+KMBnbhL3IsCdC0inkR p1+PRN5YTbvIGQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHTN-0005zT-Ql; Fri, 30 Dec 2022 10:39:06 -0500 Date: Fri, 30 Dec 2022 17:39:04 +0200 Message-Id: <83v8ls6gvb.fsf@gnu.org> From: Eli Zaretskii To: jostein@kjonigsen.net In-Reply-To: <785dab0b-1b9b-6479-9e17-25effdff2ba2@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Fri, 30 Dec 2022 15:39:20 +0100) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> <83lemp717m.fsf@gnu.org> <4bb171b5-71d8-d265-0bf6-d688b5146603@secure.kjonigsen.net> <838rip6kq3.fsf@gnu.org> <785dab0b-1b9b-6479-9e17-25effdff2ba2@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 30 Dec 2022 15:39:20 +0100 > Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no > From: Jostein Kjønigsen > > To be clear: I think csharp-ts-mode works well beyond 85% (it's what I > use as my daily driver), but the syntax-highlighting at level 3 may be > more excessive than some people (like Stefan) prefer. > > If we instead for these "major" changes suggested by Yuan, instead aim > for just moving some "smaller" implementation-detail > (function-invocations and property-highlighting) to level 4, I think we > she be able to get something which is mostly what Stefan would expect > and prefer, and it would be a much smaller change. > > Then we can take a look at those bigger changes (standardized features, > enabling/disabling them individually, as end-users, etc) for Emacs-30. > > I think that's a more realistic plan. Does that sound OK? Yes, it does. And I urge you to submit patches to that effect. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 12:36:12 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 17:36:12 +0000 Received: from localhost ([127.0.0.1]:36071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJIh-0005mb-P6 for submit@debbugs.gnu.org; Fri, 30 Dec 2022 12:36:12 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJId-0005m3-9k for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 12:36:10 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DB3D45C00EC; Fri, 30 Dec 2022 12:36:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 30 Dec 2022 12:36:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1672421761; x=1672508161; bh=xjLFihdx2y 56pM16i5YZwO4JZ+ZhUfwVEqIs77QJ97o=; b=Wmp4e9qFvwZ5vR8ly2VXpN0YBm IiHd5k28o5gX9Zz7mZhsFqanq9vjXdclI0m2N6sCDrAqsgI90kOKaggzGkTE+aHC 447+GCktMQUbgDX05IfJkSvH8rfaJMwSX8vzJCv4nAsUVCX506epanGBQcaBT0Kn jNIYRCIIxNje3a0OemXni+Q/WIm0mawOaBnDQ8gzmR/OtNnMcD31m8CHWdIrSO7Y XB5Yc4dF5eH9RFXW9cGGMbftbA7Juv5tgZns/Vqe/G6fONk32nNPc0BXxraPu4CC P9HQEmuQG48yO8Z5VLfT+DI868Bjc1ddfqhC75cVAyvkxTmT2BcHFwSm+Z1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672421761; x= 1672508161; bh=xjLFihdx2y56pM16i5YZwO4JZ+ZhUfwVEqIs77QJ97o=; b=K OO86mE7emCvmqmCXyqIKhve/W/WuE7Hx5CtJM2Bhm9khEIz5GIcqFTcof+1t6Nob 1U+PzB9EUm6yZPeYOaW4sOdI6SRL0c3YlmyaltNTYUQukZOtpTMAq7x3ggm/rbtD txM8ig4ss70k/iVHZMnSflP9+zaTc3mariMHCIhkBTuoeaSdipT/V1ZMsnhBEsZN BojEbF5BdT2QVzkyeJ1XV+ql5lLMaxHTmUcX+Z3REQ9V0+leeeV142y/c7SMIPRf xy8dC1cj4pH9koh5cZq5GNl2s8u3bL44mVPa+RsHrNImjsutVB/tWcbqldt5WwoG hd/DPMPgN/itd+7aSPhTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieeigddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfghfggufffkfhfvegjvffosehtqhhmtdhhtdejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpedviedtfeduteevgefhgeeffffh ueeltdetveehkeekudfhjeeihfevffefudegtdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Dec 2022 12:36:01 -0500 (EST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Mime-Version: 1.0 (1.0) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Fri, 30 Dec 2022 18:35:48 +0100 Message-Id: <07332CE6-C6A9-469A-9C41-B47841D8798D@secure.kjonigsen.net> References: <83v8ls6gvb.fsf@gnu.org> In-Reply-To: <83v8ls6gvb.fsf@gnu.org> To: Eli Zaretskii X-Mailer: iPhone Mail (20C65) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >=20 > =EF=BB=BF >>=20 >> Date: Fri, 30 Dec 2022 15:39:20 +0100 >> Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no >> From: Jostein Kj=C3=B8nigsen >>=20 >> To be clear: I think csharp-ts-mode works well beyond 85% (it's what I=20= >> use as my daily driver), but the syntax-highlighting at level 3 may be=20= >> more excessive than some people (like Stefan) prefer. >>=20 >> If we instead for these "major" changes suggested by Yuan, instead aim=20= >> for just moving some "smaller" implementation-detail=20 >> (function-invocations and property-highlighting) to level 4, I think we=20= >> she be able to get something which is mostly what Stefan would expect=20 >> and prefer, and it would be a much smaller change. >>=20 >> Then we can take a look at those bigger changes (standardized features,=20= >> enabling/disabling them individually, as end-users, etc) for Emacs-30. >>=20 >> I think that's a more realistic plan. Does that sound OK? >=20 > Yes, it does. And I urge you to submit patches to that effect. >=20 > Thanks. Theo has offered to come up with some patches and I=E2=80=99ll do my best to= battle-test them.=20 Hopefully we can get this done quickly enough to suit your taste ;) =E2=80=94 Jostein= From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 14:30:50 2022 Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 19:30:50 +0000 Received: from localhost ([127.0.0.1]:36124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBL5d-0000RP-JD for submit@debbugs.gnu.org; Fri, 30 Dec 2022 14:30:50 -0500 Received: from out-65.mta0.migadu.com ([91.218.175.65]:53978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBL5a-0000RG-OI for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 14:30:48 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672428645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TFS3WOsx+qnb6BFVdSJNGfAgr9eFkSoH6Z4zcAVFVOk=; b=fmDIohNfoEfdC8pb4DRVG6KAAeQHOSkGzmZ96A8mJsGnIAUvs/kLUTVekhQgcwcL9CldtX WF+5Cjahd1XlvUo6ZZaY6kDtJxbguCnoJ+WYRouBKKrR3nq4mpLcIyER2r3J43aeCX9b5y W+WPxeqEuX1PbOec5C9KEXej/zuwktsAiq5r73/YgZKA4CNY2UDMzWZyla4VtlMqxwGq4I SsWf55mkABfszNHBFgkMw5Z1B9rz+XFsLIRwJbguCjACCbAql5BEfEGiYOv4gYMyYhtqMn VUQknQqRlmSm2ioZH+Ufd9h248tSdOIOdqvyA8tb7lvDEumOKg63T2XFYyHqQQ== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features In-Reply-To: <07332CE6-C6A9-469A-9C41-B47841D8798D@secure.kjonigsen.net> References: <83v8ls6gvb.fsf@gnu.org> <07332CE6-C6A9-469A-9C41-B47841D8798D@secure.kjonigsen.net> Date: Fri, 30 Dec 2022 20:30:43 +0100 Message-ID: <87r0wgpu3g.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jostein Kj=C3=B8nigsen writes: >> On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >>=20 >> =EF=BB=BF >>>=20 >>> Date: Fri, 30 Dec 2022 15:39:20 +0100 >>> Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no >>> From: Jostein Kj=C3=B8nigsen >>>=20 >>> To be clear: I think csharp-ts-mode works well beyond 85% (it's what I= =20 >>> use as my daily driver), but the syntax-highlighting at level 3 may be= =20 >>> more excessive than some people (like Stefan) prefer. >>>=20 >>> If we instead for these "major" changes suggested by Yuan, instead aim= =20 >>> for just moving some "smaller" implementation-detail=20 >>> (function-invocations and property-highlighting) to level 4, I think we= =20 >>> she be able to get something which is mostly what Stefan would expect=20 >>> and prefer, and it would be a much smaller change. >>>=20 >>> Then we can take a look at those bigger changes (standardized features,= =20 >>> enabling/disabling them individually, as end-users, etc) for Emacs-30. >>>=20 >>> I think that's a more realistic plan. Does that sound OK? >>=20 >> Yes, it does. And I urge you to submit patches to that effect. >>=20 >> Thanks. > > Theo has offered to come up with some patches and I=E2=80=99ll do my best= to battle-test them.=20 > > Hopefully we can get this done quickly enough to suit your taste ;) > Let's start here! If you're satisfied, Jostein, report back, then you install, Yuan? Then rinse repeat :-) Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Tweak-csharp-mode-font-lock-settings.patch >From 36ba718d0f4c528b7518da33d9c4e591f578ab10 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Fri, 30 Dec 2022 20:26:09 +0100 Subject: [PATCH] Tweak csharp-mode font-lock-settings * lisp/progmodes/csharp-mode.el (csharp-ts-mode--font-lock-settings): Rearrange features. (csharp-ts-mode): Rearrange features. --- lisp/progmodes/csharp-mode.el | 53 +++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 21 deletions(-) diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index 66e4a65184..bd0e023db1 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -692,25 +692,47 @@ csharp-ts-mode--keywords (defvar csharp-ts-mode--font-lock-settings (treesit-font-lock-rules + :language 'c-sharp + :feature 'expression + '((conditional_expression (identifier) @font-lock-variable-name-face) + (postfix_unary_expression (identifier)* @font-lock-variable-name-face) + (assignment_expression (identifier) @font-lock-variable-name-face)) + + :language 'c-sharp + :feature 'bracket + '((["(" ")" "[" "]" "{" "}"]) @font-lock-bracket-face) + + :language 'c-sharp + :feature 'delimiter + '((["," ":" ";"]) @font-lock-delimiter-face) + + :language 'c-sharp + :feature 'error + '((ERROR) @font-lock-warning-face) + :language 'c-sharp :override t :feature 'comment - '((comment) @font-lock-comment-face) + '((comment) @font-lock-comment-face) + :language 'c-sharp :override t :feature 'keyword `([,@csharp-ts-mode--keywords] @font-lock-keyword-face (modifier) @font-lock-keyword-face (this_expression) @font-lock-keyword-face) + :language 'c-sharp :override t - :feature 'attribute + :feature 'property `((attribute (identifier) @font-lock-property-face (attribute_argument_list)) (attribute (identifier) @font-lock-property-face)) + :language 'c-sharp :override t :feature 'escape-sequence '((escape_sequence) @font-lock-escape-face) + :language 'c-sharp :override t :feature 'literal @@ -718,6 +740,7 @@ csharp-ts-mode--font-lock-settings (real_literal) @font-lock-number-face (null_literal) @font-lock-constant-face (boolean_literal) @font-lock-constant-face) + :language 'c-sharp :override t :feature 'string @@ -730,6 +753,7 @@ csharp-ts-mode--font-lock-settings "$\"" "@$\"" "$@\""] @font-lock-string-face) + :language 'c-sharp :override t :feature 'type @@ -750,14 +774,14 @@ csharp-ts-mode--font-lock-settings target: (identifier) @font-lock-type-face) (type_of_expression (identifier) @font-lock-type-face) (object_creation_expression (identifier) @font-lock-type-face)) + :language 'c-sharp :feature 'definition :override t '((qualified_name (identifier) @font-lock-type-face) (using_directive (identifier) @font-lock-type-face) (using_directive (name_equals - (identifier) @font-lock-type-face - ["="] @default-face)) + (identifier) @font-lock-type-face)) (enum_declaration (identifier) @font-lock-type-face) (enum_member_declaration (identifier) @font-lock-variable-name-face) @@ -820,24 +844,11 @@ csharp-ts-mode--font-lock-settings (binary_expression (identifier) @font-lock-variable-name-face) (argument (identifier) @font-lock-variable-name-face)) - :language 'c-sharp - :feature 'expression - '((conditional_expression (identifier) @font-lock-variable-name-face) - (postfix_unary_expression (identifier)* @font-lock-variable-name-face) - (assignment_expression (identifier) @font-lock-variable-name-face)) - :language 'c-sharp - :feature 'bracket - '((["(" ")" "[" "]" "{" "}"]) @font-lock-bracket-face) - - :language 'c-sharp - :feature 'delimiter - '((["," ":" ";"]) @font-lock-delimiter-face) :language 'c-sharp :feature 'escape-sequence :override t - '((escape_sequence) @font-lock-escape-face - (ERROR) @font-lock-warning-face))) + '((escape_sequence) @font-lock-escape-face))) ;;;###autoload (add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-mode)) @@ -903,9 +914,9 @@ csharp-ts-mode (setq-local treesit-font-lock-settings csharp-ts-mode--font-lock-settings) (setq-local treesit-font-lock-feature-list '(( comment definition) - ( keyword string escape-sequence type) - ( attribute constant expression literal) - ( bracket delimiter))) + ( keyword string type) + ( constant escape-sequence expression literal property) + ( bracket delimiter error))) ;; Imenu. (setq-local treesit-simple-imenu-settings -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 04:54:09 2022 Received: (at 60376) by debbugs.gnu.org; 31 Dec 2022 09:54:09 +0000 Received: from localhost ([127.0.0.1]:36575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBYZ6-0006wZ-GV for submit@debbugs.gnu.org; Sat, 31 Dec 2022 04:54:08 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:54933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBYZ4-0006vv-Aj for 60376@debbugs.gnu.org; Sat, 31 Dec 2022 04:54:07 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 68BCB3200A79; Sat, 31 Dec 2022 04:54:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 31 Dec 2022 04:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1672480440; x=1672566840; bh=Q0 1GutfwAb6vd4bNpuW2sTDekh7JMz9z3CSn+a7tXXQ=; b=GHE+XWaEAAWk9eHVmP iouifrunNng8S75dkT0wZXSpxI/jH5iwkisiKXbBv4bxzCL87LHAoYVc0AwYDI0f Y2ol2NgnaoLJkym7dEMhfi58s+hmeQmew40hXtUyu8Anpcz6XRHPQNw0ofy8kYK8 31PZRrAzY4dBU9n4ccnYD1U4cPN9T3pGXGBuZHnduZnno5dgR461v/ZgFjJDHezv 0cb0pt/drlyBqmgFqPeK+X6gVP6F9B3VBmfDRSFraFdoolqkotoVmcfOdvd/svww UGZvXlmfD4xablwlhaPhM61tPtURp+O72mP86G+QwxskY538IyLxn2Kt7tspr0d0 WmKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672480440; x=1672566840; bh=Q01GutfwAb6vd4bNpuW2sTDekh7JMz9z3CS n+a7tXXQ=; b=XofByjmawS6PwFLQEL9UAqp3Nzs1R3Bw7SJ+zaSGbzhh9t19q4J YrmsWaEgORMWLwWIcCF5eiQU8fKbLHapzVOm3loKomi+UsKsnoPEvBX2A4olvDdI JAV4YDozMpVJeJoFEJ8wgoNpq6MOOgoi4TZAE2Mtut16oF7x8H5wja/K59baulAT EVBtOOHHyOK4BauIH4eTEXHJFViMCRDy2bBCpRL74BRG2QojJYjwDwpcM/07mQLv GdSTO8yfJ7jfJIzJlIdu9yhaHGkLAKTjMb6YPkutgl8Dbi+9EZMzhstTuw8SrFGQ 0EtjaAZ8dStf8ZiX/QNZEDNLnqGvwd8xQ6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieekgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpedtfedtkedtffeukedvvddvkeeu veduvdeitdfffffggfegledtkeehgfdtjeekveenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 31 Dec 2022 04:53:58 -0500 (EST) Message-ID: <7e522fe6-2e5a-5bca-10b1-5a19862dcea2@secure.kjonigsen.net> Date: Sat, 31 Dec 2022 10:53:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Content-Language: en-GB, nb-NO To: Theodor Thornhill , Eli Zaretskii References: <83v8ls6gvb.fsf@gnu.org> <07332CE6-C6A9-469A-9C41-B47841D8798D@secure.kjonigsen.net> <87r0wgpu3g.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87r0wgpu3g.fsf@thornhill.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On 30.12.2022 20:30, Theodor Thornhill wrote: > Jostein Kjønigsen writes: > >>> On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >>> >>>  >>>> Date: Fri, 30 Dec 2022 15:39:20 +0100 >>>> Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no >>>> From: Jostein Kjønigsen >>>> >>>> To be clear: I think csharp-ts-mode works well beyond 85% (it's what I >>>> use as my daily driver), but the syntax-highlighting at level 3 may be >>>> more excessive than some people (like Stefan) prefer. >>>> >>>> If we instead for these "major" changes suggested by Yuan, instead aim >>>> for just moving some "smaller" implementation-detail >>>> (function-invocations and property-highlighting) to level 4, I think we >>>> she be able to get something which is mostly what Stefan would expect >>>> and prefer, and it would be a much smaller change. >>>> >>>> Then we can take a look at those bigger changes (standardized features, >>>> enabling/disabling them individually, as end-users, etc) for Emacs-30. >>>> >>>> I think that's a more realistic plan. Does that sound OK? >>> Yes, it does. And I urge you to submit patches to that effect. >>> >>> Thanks. >> Theo has offered to come up with some patches and I’ll do my best to battle-test them. >> >> Hopefully we can get this done quickly enough to suit your taste ;) >> > Let's start here! > > If you're satisfied, Jostein, report back, then you install, Yuan? > > Then rinse repeat :-) > > Theo I've tested it, and I can't say I see any regressions. Two things though: - Method-invocations are still getting fontified on level 3. I believe Stefan wanted this to be on level 4? - I see we've missed fontification of method-invocations on self-methods (this.DoSomething()) entirely. If we fix the first thing, I guess the second one is also doable? :) -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 05:32:59 2022 Received: (at 60376) by debbugs.gnu.org; 31 Dec 2022 10:32:59 +0000 Received: from localhost ([127.0.0.1]:36601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBZAg-0008AB-Qd for submit@debbugs.gnu.org; Sat, 31 Dec 2022 05:32:59 -0500 Received: from out2.migadu.com ([188.165.223.204]:45694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBZAe-00089y-K7 for 60376@debbugs.gnu.org; Sat, 31 Dec 2022 05:32:57 -0500 Date: Sat, 31 Dec 2022 11:32:54 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672482774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bqM4fpcadK9gAbV8ZH/SDD8t9B1IMWO02SVDvGX6fw=; b=MsJu7BFW63bZQpCueVd0HWB231KMZ5bE50s1wcLlWQtaXEAMH3USp+oHiUqfLceMvETP8Q ANfROocVHJgqi7v0Pp8rzPmMB8g8jD3+jtiXo9Qzw6KNDPAbRw7CeOFhaj39s+dIEefbMY QStHKPfk5k/rcj8jHyV9yVbDLDu6J7DSpRXpojj7CdtcdEdNH4eUNKR3rHtAxaij+D/ghO 4nTv1aZwXwXik/5+Mk1FvFxZwAAxOP8D7oqxC/N44n1ONMOXJaVBGqW74/9MKBxQWwG7EO e0fG6aLunl/ZGNwCXvq73Yb/zD8dG6ioj1SXnBXInnNE4RgNUfOpHkvwg5bWaA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: jostein@kjonigsen.net, =?ISO-8859-1?Q?Jostein_Kj=F8nigsen?= , Eli Zaretskii Subject: =?US-ASCII?Q?Re=3A_bug=2360376=3A_29=2E0=2E60=3B_Standardize?= =?US-ASCII?Q?_csharp-ts-mode=27s_font-lock_features?= In-Reply-To: <7e522fe6-2e5a-5bca-10b1-5a19862dcea2@secure.kjonigsen.net> References: <83v8ls6gvb.fsf@gnu.org> <07332CE6-C6A9-469A-9C41-B47841D8798D@secure.kjonigsen.net> <87r0wgpu3g.fsf@thornhill.no> <7e522fe6-2e5a-5bca-10b1-5a19862dcea2@secure.kjonigsen.net> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, casouri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 31 December 2022 10:53:54 CET, "Jostein Kj=C3=B8nigsen" wrote: >On 30=2E12=2E2022 20:30, Theodor Thornhill wrote: >> Jostein Kj=C3=B8nigsen writes: >>=20 >>>> On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >>>>=20 >>>> =EF=BB=BF >>>>> Date: Fri, 30 Dec 2022 15:39:20 +0100 >>>>> Cc: casouri@gmail=2Ecom, 60376@debbugs=2Egnu=2Eorg, theo@thornhill= =2Eno >>>>> From: Jostein Kj=C3=B8nigsen >>>>>=20 >>>>> To be clear: I think csharp-ts-mode works well beyond 85% (it's what= I >>>>> use as my daily driver), but the syntax-highlighting at level 3 may = be >>>>> more excessive than some people (like Stefan) prefer=2E >>>>>=20 >>>>> If we instead for these "major" changes suggested by Yuan, instead a= im >>>>> for just moving some "smaller" implementation-detail >>>>> (function-invocations and property-highlighting) to level 4, I think= we >>>>> she be able to get something which is mostly what Stefan would expec= t >>>>> and prefer, and it would be a much smaller change=2E >>>>>=20 >>>>> Then we can take a look at those bigger changes (standardized featur= es, >>>>> enabling/disabling them individually, as end-users, etc) for Emacs-3= 0=2E >>>>>=20 >>>>> I think that's a more realistic plan=2E Does that sound OK? >>>> Yes, it does=2E And I urge you to submit patches to that effect=2E >>>>=20 >>>> Thanks=2E >>> Theo has offered to come up with some patches and I=E2=80=99ll do my b= est to battle-test them=2E >>>=20 >>> Hopefully we can get this done quickly enough to suit your taste ;) >>>=20 >> Let's start here! >>=20 >> If you're satisfied, Jostein, report back, then you install, Yuan? >>=20 >> Then rinse repeat :-) >>=20 >> Theo > >I've tested it, and I can't say I see any regressions=2E > >Two things though: > >- Method-invocations are still getting fontified on level 3=2E I believe = Stefan wanted this to be on level 4? > >- I see we've missed fontification of method-invocations on self-methods = (this=2EDoSomething()) entirely=2E > >If we fix the first thing, I guess the second one is also doable? :) > >-- >Jostein > Great! Yuan or Eli, will you install? I'll follow up with more stuff later= :) Theo From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 17:21:35 2022 Received: (at 60376) by debbugs.gnu.org; 31 Dec 2022 22:21:35 +0000 Received: from localhost ([127.0.0.1]:39990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkEQ-0001jn-KN for submit@debbugs.gnu.org; Sat, 31 Dec 2022 17:21:34 -0500 Received: from mail-pj1-f45.google.com ([209.85.216.45]:44629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkEO-0001jZ-1j for 60376@debbugs.gnu.org; Sat, 31 Dec 2022 17:21:32 -0500 Received: by mail-pj1-f45.google.com with SMTP id o31-20020a17090a0a2200b00223fedffb30so24802714pjo.3 for <60376@debbugs.gnu.org>; Sat, 31 Dec 2022 14:21:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=Evz/h9NlofHPnl1cXaHIIdgm4okkfDke611SaEt+eGs=; b=Rt2IFMowVr/YMsaQSzLnYVb4An0dQCX6u0tFB+Y+a2rU2lQhVHexvTNT+DkX5O6Whh 5XOoPX/1zuk3Nc3lS3+GfJwuI86/0v2xQFB3ZLcgzHv36frRIoBI1Vp3KLX8rFsPyiN3 CwDkUXqv26Q+EPmEOJLzaqwzgOi5qPwmcAa3+PXzCqlia2epJTSkiOeOvuPS7h10SGou 7Kw31ylh6XXwGaA+pFeQTE/j3NCCvG+YdJJSpXNst4NcPt08pWGAM7h1KV+Beb6elK65 xgBzP8u6RMAp5T6DYC/IPsj7K66TK95WnkNO2sADfvgPbPG6UpMa6eAMgXsakneJus65 NNFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Evz/h9NlofHPnl1cXaHIIdgm4okkfDke611SaEt+eGs=; b=h4gCvl2dRN2CbjNdaJ//cyBZcACsNJOkBqJPVyxBffGbXwNFMuuHZ3v596o4DYli9e laYjdYVUev024aVW3KEMMV0+whwPTNBn1R+4YiE/EVFR6r4SXU66QA8UBuO7EUGU8wnO R6LRJWB/7E/fNRKYch5+LhtrvIR+3n2fm7XO53spMDVVajkypyQ7sSi0NeoUUTcKUf1O YHwt1mKG1CqdYomRGg7w9dNIJSPN5sXfnZqfemuPMwiqfpyYqrAJLhe8rG8DZPnay1NV Jn1ltn1s/DfqH6WD9o/R9KFs/VHOdoHPlD2DMakqfWzQ4x9jz2j62BpEHHVwkC7qrs0/ moGA== X-Gm-Message-State: AFqh2ko//yN0/ESQPVlmt17QavFGELIMkBqD62+HSSPU7V0j1yNAuRti k7wGmFhhgOLMWIzpdl2/M1I= X-Google-Smtp-Source: AMrXdXukRD+aYsgPV7sDXdBxBt0hzTWjc+o9nXYqEpKbw0DcVJKRy64aHI6cN3h/Tqj6Gz07wqbVEQ== X-Received: by 2002:a17:902:7c8a:b0:192:835d:c861 with SMTP id y10-20020a1709027c8a00b00192835dc861mr18942295pll.68.1672525286193; Sat, 31 Dec 2022 14:21:26 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id e7-20020a17090301c700b00177f25f8ab3sm17295459plh.89.2022.12.31.14.21.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Dec 2022 14:21:25 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Message-Id: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> Date: Sat, 31 Dec 2022 14:21:24 -0800 To: Theodor Thornhill X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= , Eli Zaretskii , jostein@kjonigsen.net, 60376@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > On 31 December 2022 10:53:54 CET, "Jostein Kj=C3=B8nigsen" = wrote: >>On 30.12.2022 20:30, Theodor Thornhill wrote: >>> Jostein Kj=C3=B8nigsen writes: >>>=20 >>>>> On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >>>>>=20 >>>>> =EF=BB=BF >>>>>> Date: Fri, 30 Dec 2022 15:39:20 +0100 >>>>>> Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no >>>>>> From: Jostein Kj=C3=B8nigsen >>>>>>=20 >>>>>> To be clear: I think csharp-ts-mode works well beyond 85% (it's = what I >>>>>> use as my daily driver), but the syntax-highlighting at level 3 = may be >>>>>> more excessive than some people (like Stefan) prefer. >>>>>>=20 >>>>>> If we instead for these "major" changes suggested by Yuan, = instead aim >>>>>> for just moving some "smaller" implementation-detail >>>>>> (function-invocations and property-highlighting) to level 4, I = think we >>>>>> she be able to get something which is mostly what Stefan would = expect >>>>>> and prefer, and it would be a much smaller change. >>>>>>=20 >>>>>> Then we can take a look at those bigger changes (standardized = features, >>>>>> enabling/disabling them individually, as end-users, etc) for = Emacs-30. >>>>>>=20 >>>>>> I think that's a more realistic plan. Does that sound OK? >>>>> Yes, it does. And I urge you to submit patches to that effect. >>>>>=20 >>>>> Thanks. >>>> Theo has offered to come up with some patches and I=E2=80=99ll do = my best to battle-test them. >>>>=20 >>>> Hopefully we can get this done quickly enough to suit your taste ;) >>>>=20 >>> Let's start here! >>>=20 >>> If you're satisfied, Jostein, report back, then you install, Yuan? >>>=20 >>> Then rinse repeat :-) >>>=20 >>> Theo >> >>I've tested it, and I can't say I see any regressions. >> >>Two things though: >> >>- Method-invocations are still getting fontified on level 3. I believe = Stefan wanted this to be on level 4? >> >>- I see we've missed fontification of method-invocations on = self-methods (this.DoSomething()) entirely. >> >>If we fix the first thing, I guess the second one is also doable? :) >> >>-- >>Jostein >> > > Great! Yuan or Eli, will you install? I'll follow up with more stuff = later :) > > Theo I applied it, thanks! Yuan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 11:29:30 2023 Received: (at 60376) by debbugs.gnu.org; 1 Jan 2023 16:29:30 +0000 Received: from localhost ([127.0.0.1]:41556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC1DF-0002OG-LM for submit@debbugs.gnu.org; Sun, 01 Jan 2023 11:29:30 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC1DD-0002O0-4F for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 11:29:28 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C35B95C00B2; Sun, 1 Jan 2023 11:29:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 01 Jan 2023 11:29:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm1; t= 1672590561; x=1672676961; bh=mt6lSReCFUa0Mmw9bzMK+cS6S2rNAlkQYBa R3dgzw4s=; b=ZBPM0t8KRGgA6Bs/S5/7G90QFRdXGLiWUiQ3o9+DEXMiCIX6hT1 qhN9G0G5N93LkZqlNz//tzg8CAv/6ROrxjASGznXy4JkZaYCal00+YYhoCrxdMiR tsTBrKymzeRkevLbNjqNfYj3eBtJJoAFmZRS+VGQ6TkpqYTYH6cnOq8OgUHYosMa jIuSFIhfDQWKZwP2smACxd1fJ2GoE/bwDeyKwuFz+9+IOQ5SF+P17L1lNJ8f5kwc miqwgVQgOQY6dQ0Tpyc2/5nm6uFn7dUekjAnKeOC0k6jUTmaL27RAjFm5zpqmAnk RqTXi4+ERStGGR8qywMzJSHAQzYHLRTDM3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1672590561; x=1672676961; bh=mt6lSReCFUa0M mw9bzMK+cS6S2rNAlkQYBaR3dgzw4s=; b=XWToHMZcxyFk6Vxu2sodX+tc/J0cx u43MhV5IjmFad9IUDmb03EvGdyWGgQ4RQZTfCBGXgpw3GyZuro44sDO3wtdVpWba GV/7g3ppRYfwFAt12FvDXizfWiz9ST1ldKWczhyds6PDIw6Pk20oAQRnBa8Vdm8X tXn0Wt8AyITyz+acniAg5NkLh0ISEJn1yROK6JUuk+YjGvQ6FztTuxu2XJfF6i0j S+TLrCkmqkWUltXd3bXw5G6j8VsbMoFX9JtnkhNL5Tq9lE4rZ0DwW7QnLXs3ZTo6 752sNtgSfKkHh0xlw1Cl19PkUpLnWOR5DUM1hWta5+Ze2404Idh8DoTCA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedtgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepleeihefgveefffelkeelleffffdt feevleetheefgfdtgfdtfeeiveekgfevkedvnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 11:29:20 -0500 (EST) Content-Type: multipart/mixed; boundary="------------ucnFFWcR4ulBYmZ9svlaOh3B" Message-ID: <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> Date: Sun, 1 Jan 2023 17:29:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features To: Yuan Fu , Theodor Thornhill References: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> Content-Language: en-GB, nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) This is a multi-part message in MIME format. --------------ucnFFWcR4ulBYmZ9svlaOh3B Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.12.2022 23:21, Yuan Fu wrote: > I applied it, thanks! > > Yuan Following up this case, attached is a patch which from what I can tell movies function invocation fontification to level 4, without any other regressions. Theo: Care to take it for a spin? Does it look OK by you? -- Jostein --------------ucnFFWcR4ulBYmZ9svlaOh3B Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiZGI3MGJiYTM1YWExZmUzNmY1YmI2NmU4ODAyODljZmNmZTNiMzM5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCAxIEphbiAyMDIzIDE3 OjI3OjA2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1v ZGUuZWw6IGFkanVzdCBmdW5jdGlvbi1jYWxsCiBmb250aWZpY2F0aW9uCgotLS0KIGxpc3Av cHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsIHwgNDAgKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAxOSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9kZS5lbCBi L2xpc3AvcHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCmluZGV4IGRhNjRkYWY5ODQ4Li42OGVi OWRlYTdmMCAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwKKysr IGIvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwKQEAgLTgxMCw3ICs4MTAsMjUgQEAg Y3NoYXJwLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAobWV0aG9kX2RlY2xh cmF0aW9uIHR5cGU6IChfKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKICAgICAgKG1ldGhvZF9k ZWNsYXJhdGlvbiBuYW1lOiAoXykgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAK LSAgICAgKGludm9jYXRpb25fZXhwcmVzc2lvbgorICAgICAoY2F0Y2hfZGVjbGFyYXRpb24K KyAgICAgICgoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpKQorICAgICAoY2F0 Y2hfZGVjbGFyYXRpb24KKyAgICAgICgoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZh Y2UKKyAgICAgICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2Up KQorCisgICAgICh2YXJpYWJsZV9kZWNsYXJhdGlvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9j ay10eXBlLWZhY2UpCisgICAgICh2YXJpYWJsZV9kZWNsYXJhdG9yIChpZGVudGlmaWVyKSBA Zm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkKKworICAgICAocGFyYW1ldGVyIHR5cGU6 IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKKyAgICAgKHBhcmFtZXRlciBu YW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCisKKyAg ICAgKGJpbmFyeV9leHByZXNzaW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxl LW5hbWUtZmFjZSkKKyAgICAgKGFyZ3VtZW50IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh cmlhYmxlLW5hbWUtZmFjZSkpCisKKyAgIDpsYW5ndWFnZSAnYy1zaGFycAorICAgOmZlYXR1 cmUgJ2Z1bmN0aW9uCisgICA6b3ZlcnJpZGUgdAorICAgJygoaW52b2NhdGlvbl9leHByZXNz aW9uCiAgICAgICAobWVtYmVyX2FjY2Vzc19leHByZXNzaW9uCiAgICAgICAgKGdlbmVyaWNf bmFtZSAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpKSkKICAg ICAgKGludm9jYXRpb25fZXhwcmVzc2lvbgpAQCAtODI3LDIzICs4NDUsNyBAQCBjc2hhcnAt dHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAgICAgICAgICAgICAgIChnZW5lcmlj X25hbWUgKHR5cGVfYXJndW1lbnRfbGlzdAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBbIjwiXSBAZm9udC1sb2NrLWJyYWNrZXQtZmFjZQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgWyI+Il0gQGZvbnQtbG9jay1icmFja2V0LWZh Y2UpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKV0pCi0KLSAgICAgKGNhdGNo X2RlY2xhcmF0aW9uCi0gICAgICAoKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNl KSkKLSAgICAgKGNhdGNoX2RlY2xhcmF0aW9uCi0gICAgICAoKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdHlwZS1mYWNlCi0gICAgICAgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFi bGUtbmFtZS1mYWNlKSkKLQotICAgICAodmFyaWFibGVfZGVjbGFyYXRpb24gKGlkZW50aWZp ZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKQotICAgICAodmFyaWFibGVfZGVjbGFyYXRvciAo aWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCi0KLSAgICAgKHBh cmFtZXRlciB0eXBlOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpCi0gICAg IChwYXJhbWV0ZXIgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFt ZS1mYWNlKQotCi0gICAgIChiaW5hcnlfZXhwcmVzc2lvbiAoaWRlbnRpZmllcikgQGZvbnQt bG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCi0gICAgIChhcmd1bWVudCAoaWRlbnRpZmllcikg QGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBbIj4iXSBAZm9udC1sb2NrLWJyYWNrZXQtZmFjZSkpXSkpCiAKICAgIDps YW5ndWFnZSAnYy1zaGFycAogICAgOmZlYXR1cmUgJ2VzY2FwZS1zZXF1ZW5jZQpAQCAtOTE2 LDcgKzkxOCw3IEBAIGNzaGFycC10cy1tb2RlCiAgICAgICAgICAgICAgICcoKCBjb21tZW50 IGRlZmluaXRpb24pCiAgICAgICAgICAgICAgICAgKCBrZXl3b3JkIHN0cmluZyB0eXBlKQog ICAgICAgICAgICAgICAgICggY29uc3RhbnQgZXNjYXBlLXNlcXVlbmNlIGV4cHJlc3Npb24g bGl0ZXJhbCBwcm9wZXJ0eSkKLSAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVy IGVycm9yKSkpCisgICAgICAgICAgICAgICAgKCBmdW5jdGlvbiBicmFja2V0IGRlbGltaXRl ciBlcnJvcikpKQogCiAgIDs7IEltZW51LgogICAoc2V0cS1sb2NhbCB0cmVlc2l0LXNpbXBs ZS1pbWVudS1zZXR0aW5ncwotLSAKMi4zNy4yCgo= --------------ucnFFWcR4ulBYmZ9svlaOh3B-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 12:24:43 2023 Received: (at 60376) by debbugs.gnu.org; 1 Jan 2023 17:24:43 +0000 Received: from localhost ([127.0.0.1]:41630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC24h-0003rd-86 for submit@debbugs.gnu.org; Sun, 01 Jan 2023 12:24:43 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC24f-0003rO-AV for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 12:24:41 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 55EAD5C00C9; Sun, 1 Jan 2023 12:24:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 01 Jan 2023 12:24:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm1; t= 1672593875; x=1672680275; bh=kxMpB8UgnjTLqjdtQ2HbPNlQjWiY6xmJPxQ RlMDigWw=; b=slQWdCt7ds11gLuFTA+XTt4yJDs0MhnecjRtiSXf1CBK3FOxeXG wpbFZ7RpsUSWGs3FxHQLEQTH/2EZFtdKfdAnIvBxgSujv8jY+o3+k4aL+6cvvolZ plJI05AtcxlHQJnpBVmKJydkhMApw/oS/Y8kYwYefiLwhoj23ar6qawW0DkaKw8Z xSYvgQOPNdXhzyb0peh+nxAiNYD1LqFjxqb4o9wFPJ2dUsqBpCFYT3pTdTjiAwk6 PXsM89PWGpU897iEyiu1a/uKyP3aG+KrnkPI9Xz3TF6okofzkQYz2LpwSX3yZxqW eeuBmXiUdzh7XqJi4Bs76Py6wNc7XAZg+gQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1672593875; x=1672680275; bh=kxMpB8UgnjTLq jdtQ2HbPNlQjWiY6xmJPxQRlMDigWw=; b=gkwpSLVZzyxDLtV58ogftgo3CptUq Rtyz1IrbTdg1bOxKhyhxlhymWzyDjhZp66hD7LMhPqYsOyHghPeqCc6H6GLKacWi CdZgt32M+c/DRZ4hF/fNQPihLi8Zh4aTqnzAU0194U7dAgjseylC8iR4TfBxDcwQ FEfd19KSqMixUGLcO1SmYa4ZRPj2JOnsvKWke+r88kBxR7WVlBeYmK/AAepsnugO ctUC95V8jhUj/dwkt2ikAooiyRWDLITpsRMF3E2GQY1AbCZAH6wQ6NEldtbkQIpQ stx18eBD80ZJurZXjIYc++0C32hf/L2us6UXBJSIK713aiQTJ8P6302VQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedtgdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuhffvvehfjgesmhdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepueduffetfeeileffgfffveeihfej gfffvdehueekudehhfejieetvdfghfduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 12:24:34 -0500 (EST) Content-Type: multipart/mixed; boundary="------------JKscTIFRFGPPbRC6opEaS94u" Message-ID: <8538939b-5639-b8c0-82cc-113930a95ab1@secure.kjonigsen.net> Date: Sun, 1 Jan 2023 18:24:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Content-Language: en-GB, nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: Yuan Fu , Theodor Thornhill References: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> In-Reply-To: <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) This is a multi-part message in MIME format. --------------JKscTIFRFGPPbRC6opEaS94u Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01.01.2023 17:29, Jostein Kjønigsen wrote: > On 31.12.2022 23:21, Yuan Fu wrote: >> I applied it, thanks! >> >> Yuan > > Following up this case, attached is a patch which from what I can tell > movies function invocation fontification to level 4, without any other > regressions. > > Theo: Care to take it for a spin? Does it look OK by you? > > -- > Jostein Disregard previous patch. Consider instead please the patch attached to this email. It does 3 things all in one: * moves function-call fontification to level 4 only (in its own feature) * cleans up long-standing issues with "messy" rules for function-invocations. Removes the needs for "overrides". * also fixes issue with fonctification of self/this-method invocations. Theo: Can you try this patch and see what you think? -- Jostein --------------JKscTIFRFGPPbRC6opEaS94u Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYjNkZjdiNzczNTdhNTZkYTllMDUxNjNlZjBiZjBjYTllZmE5N2RiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCAxIEphbiAyMDIzIDE3 OjI3OjA2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1v ZGUuZWw6IGFkanVzdCBmdW5jdGlvbi1jYWxsCiBmb250aWZpY2F0aW9uCgotLS0KIGxpc3Av cHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsIHwgNDMgKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyMyBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9kZS5lbCBi L2xpc3AvcHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCmluZGV4IGRhNjRkYWY5ODQ4Li4wMmRh NzA1YjQ0NSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwKKysr IGIvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwKQEAgLTc2NCw4ICs3NjQsMTIgQEAg Y3NoYXJwLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAgKGlkZW50aWZpZXIp IEBmb250LWxvY2stdHlwZS1mYWNlKQogICAgICAodHlwZV9hcmd1bWVudF9saXN0CiAgICAg ICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpCi0gICAgIChnZW5lcmljX25h bWUKLSAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKKyAgICAgKHR5 cGVfYXJndW1lbnRfbGlzdAorICAgICAgKGdlbmVyaWNfbmFtZQorICAgICAgIChpZGVudGlm aWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCisgICAgIChiYXNlX2xpc3QKKyAgICAgIChn ZW5lcmljX25hbWUKKyAgICAgICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2Up KQogICAgICAoYXJyYXlfdHlwZQogICAgICAgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlw ZS1mYWNlKQogICAgICAoY2FzdF9leHByZXNzaW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LXR5cGUtZmFjZSkKQEAgLTgxMCwyNiArODE0LDYgQEAgY3NoYXJwLXRzLW1vZGUtLWZvbnQt bG9jay1zZXR0aW5ncwogICAgICAobWV0aG9kX2RlY2xhcmF0aW9uIHR5cGU6IChfKSBAZm9u dC1sb2NrLXR5cGUtZmFjZSkKICAgICAgKG1ldGhvZF9kZWNsYXJhdGlvbiBuYW1lOiAoXykg QGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAKLSAgICAgKGludm9jYXRpb25fZXhw cmVzc2lvbgotICAgICAgKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgotICAgICAgIChnZW5l cmljX25hbWUgKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKSkp Ci0gICAgIChpbnZvY2F0aW9uX2V4cHJlc3Npb24KLSAgICAgIChtZW1iZXJfYWNjZXNzX2V4 cHJlc3Npb24KLSAgICAgICAoKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFt ZS1mYWNlCi0gICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUt ZmFjZSkpKQotICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCi0gICAgICAoaWRlbnRpZmll cikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCi0gICAgIChpbnZvY2F0aW9uX2V4 cHJlc3Npb24KLSAgICAgIChtZW1iZXJfYWNjZXNzX2V4cHJlc3Npb24KLSAgICAgICBleHBy ZXNzaW9uOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQot ICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCi0gICAgICBmdW5jdGlvbjogWyhnZW5lcmlj X25hbWUgKGlkZW50aWZpZXIpKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZQotICAg ICAgICAgICAgICAgICAoZ2VuZXJpY19uYW1lICh0eXBlX2FyZ3VtZW50X2xpc3QKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgWyI8Il0gQGZvbnQtbG9jay1icmFja2V0LWZh Y2UKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdHlwZS1mYWNlCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFsiPiJd IEBmb250LWxvY2stYnJhY2tldC1mYWNlKQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICldKQotCiAgICAgIChjYXRjaF9kZWNsYXJhdGlvbgogICAgICAgKChpZGVudGlmaWVy KSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCiAgICAgIChjYXRjaF9kZWNsYXJhdGlvbgpAQCAt ODQ1LDYgKzgyOSwxOSBAQCBjc2hhcnAtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAg ICAgIChiaW5hcnlfZXhwcmVzc2lvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJs ZS1uYW1lLWZhY2UpCiAgICAgIChhcmd1bWVudCAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12 YXJpYWJsZS1uYW1lLWZhY2UpKQogCisgICA6bGFuZ3VhZ2UgJ2Mtc2hhcnAKKyAgIDpmZWF0 dXJlICdmdW5jdGlvbgorICAgJygoaW52b2NhdGlvbl9leHByZXNzaW9uCisgICAgICBmdW5j dGlvbjogKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgorICAgICAgICAgICAgICAgICBuYW1l OiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpKQorICAgICAo aW52b2NhdGlvbl9leHByZXNzaW9uCisgICAgICBmdW5jdGlvbjogKGlkZW50aWZpZXIpIEBm b250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQorICAgICAoaW52b2NhdGlvbl9leHByZXNz aW9uCisgICAgICBmdW5jdGlvbjogKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgorICAgICAg ICAgICAgICAgICBuYW1lOiAoZ2VuZXJpY19uYW1lIChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LWZ1bmN0aW9uLW5hbWUtZmFjZSkpKQorICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCisg ICAgICBmdW5jdGlvbjogKGdlbmVyaWNfbmFtZSAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1m dW5jdGlvbi1uYW1lLWZhY2UpKSkKKwogICAgOmxhbmd1YWdlICdjLXNoYXJwCiAgICA6ZmVh dHVyZSAnZXNjYXBlLXNlcXVlbmNlCiAgICA6b3ZlcnJpZGUgdApAQCAtOTE2LDcgKzkxMyw3 IEBAIGNzaGFycC10cy1tb2RlCiAgICAgICAgICAgICAgICcoKCBjb21tZW50IGRlZmluaXRp b24pCiAgICAgICAgICAgICAgICAgKCBrZXl3b3JkIHN0cmluZyB0eXBlKQogICAgICAgICAg ICAgICAgICggY29uc3RhbnQgZXNjYXBlLXNlcXVlbmNlIGV4cHJlc3Npb24gbGl0ZXJhbCBw cm9wZXJ0eSkKLSAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVyIGVycm9yKSkp CisgICAgICAgICAgICAgICAgKCBmdW5jdGlvbiBicmFja2V0IGRlbGltaXRlciBlcnJvcikp KQogCiAgIDs7IEltZW51LgogICAoc2V0cS1sb2NhbCB0cmVlc2l0LXNpbXBsZS1pbWVudS1z ZXR0aW5ncwotLSAKMi4zNy4yCgo= --------------JKscTIFRFGPPbRC6opEaS94u-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 13:14:15 2023 Received: (at 60376) by debbugs.gnu.org; 1 Jan 2023 18:14:15 +0000 Received: from localhost ([127.0.0.1]:41709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2qc-0005HJ-D9 for submit@debbugs.gnu.org; Sun, 01 Jan 2023 13:14:15 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:59647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2qa-0005H7-4m for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 13:14:13 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 398A132002E8; Sun, 1 Jan 2023 13:14:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 01 Jan 2023 13:14:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm1; t= 1672596845; x=1672683245; bh=dzpfpSCSwI33PW64H+vwaOROU4ZFjPrd06o aFGcMlAA=; b=CXMAGYQSJzu02v7sbEBAB2WlHoI/y+OOHLZ4GfWa3CTxoHTmNBK LxpVfnCQwvSxE9dOsYFowAmiPCjcf/xzqfOmE+RhrlqS2t/ivIXLF4ybhVLd5t16 L+FsRs3OcK31CsICUTe14dv3KRRAEtBrpZvtezwrYtG+26NsiEx2wG/otwEEXjOY QqIxGbe1lNG7KwCNWwS1psiIYEINB63iYtygr3Plgw7JUzpYQ4aEO2xX0SwKqRwT ncxeT1taoB63+niLBM5YCHN2nIaykAxn8zJVCDdPs73VWvTWAlxYfjjwUSnDBHb3 T9V0yX+MMUWWBqepr/O+7eTkB/scISeDf4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1672596845; x=1672683245; bh=dzpfpSCSwI33P W64H+vwaOROU4ZFjPrd06oaFGcMlAA=; b=FVoTLwQE9teCghxYIeQDFJJmGH1Ox RBL20gkI1wxtQwbstzFPK9XsgItCRv1oSK2NnhcKaVzBP8+h1bawcokpo33YJK/Q Lu0/Ohg82yJV6izimekUf23h5nnaURLKw98doEQEKXcIAIb8bupMIt7+iHjRio88 s2QqkDP4B5A5FhpNWU6LqHiMleJhNlc7UVTstjDDscQCtU3ioMwgvv1g4hQA2FGB gM9uoY4Y/i/6pmGyf4cbv91Zg6UWzadomcxQH//n9gBkHM8p8cgz7b1kapuipJyo R2vhcVEFSonU5JI2p7btv4aNIrzSOJB5bhJz8cwbnA4/qWsPlF019qh4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedtgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffhvfevfhgjsehmtderredtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeeuudffteefieelfffgffeviefh jefgffdvheeukeduhefhjeeitedvgffhudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 13:14:04 -0500 (EST) Content-Type: multipart/mixed; boundary="------------TcsAXaMx1zZ5Tkqd6cnXbIF0" Message-ID: <32bfc790-73fa-27b1-5fd8-50181e66015d@secure.kjonigsen.net> Date: Sun, 1 Jan 2023 19:14:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Content-Language: en-GB, nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: Yuan Fu , Theodor Thornhill References: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> <8538939b-5639-b8c0-82cc-113930a95ab1@secure.kjonigsen.net> In-Reply-To: <8538939b-5639-b8c0-82cc-113930a95ab1@secure.kjonigsen.net> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------TcsAXaMx1zZ5Tkqd6cnXbIF0 Content-Type: multipart/alternative; boundary="------------yVI3CU6PNXoM2MqpZMmZPtPO" --------------yVI3CU6PNXoM2MqpZMmZPtPO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01.01.2023 18:24, Jostein Kjønigsen wrote: > Disregard previous patch. > > Consider instead please the patch attached to this email. > > It does 3 things all in one: > > * moves function-call fontification to level 4 only (in its own feature) > > * cleans up long-standing issues with "messy" rules for > function-invocations. Removes the needs for "overrides". > > * also fixes issue with fonctification of self/this-method invocations. > > Theo: Can you try this patch and see what you think? > > -- > > Jostein Disregard again (and sorry for the noise!) I've now gone through several files, done quite a bit of testing myself, and found another few issues needing to be solved: * Inconsistent variable-name fontification (sometimes when used, sometimes when declared, sometimes not when used, sometimes not when declared) * Variable declaration with explicit generic types * new() expression fontification for generic types. * Bleeding type-face into brackets for generic return-types in method definitions * Types when casting through as-expressions are not fontified at all. * And more? I've solved those and combined all this into this latest patch, which also moves function-invocation into its own (level 4) feature. This patch should be well beyond the "85%" which Eli has requested for Emacs-29 :) *Theo:* Could you give this a test-spin, and I promise to call it a day? :) -- Jostein --------------yVI3CU6PNXoM2MqpZMmZPtPO Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit On 01.01.2023 18:24, Jostein Kjønigsen wrote:
Disregard previous patch.

Consider instead please the patch attached to this email.

It does 3 things all in one:

* moves function-call fontification to level 4 only (in its own feature)

* cleans up long-standing issues with "messy" rules for function-invocations. Removes the needs for "overrides".

* also fixes issue with fonctification of self/this-method invocations.

Theo: Can you try this patch and see what you think?

--

Jostein

Disregard again (and sorry for the noise!)

I've now gone through several files, done quite a bit of testing myself, and found another few issues needing to be solved:

  • Inconsistent variable-name fontification (sometimes when used, sometimes when declared, sometimes not when used, sometimes not when declared)
  • Variable declaration with explicit generic types
  • new() expression fontification for generic types.
  • Bleeding type-face into brackets for generic return-types in method definitions
  • Types when casting through as-expressions are not fontified at all.
  • And more?

I've solved those and combined all this into this latest patch, which also moves function-invocation into its own (level 4) feature.

This patch should be well beyond the "85%" which Eli has requested for Emacs-29 :)

Theo: Could you give this a test-spin, and I promise to call it a day? :)

--
Jostein

--------------yVI3CU6PNXoM2MqpZMmZPtPO-- --------------TcsAXaMx1zZ5Tkqd6cnXbIF0 Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-csharp-mode.el-adjust-function-call-f.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzMzM2MDJmZjM0MWI4YThhZGQxNWZmOTYwNTRjZmM1Y2VhMDExNmNkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCAxIEphbiAyMDIzIDE3 OjI3OjA2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1v ZGUuZWw6IGFkanVzdCBmdW5jdGlvbi1jYWxsCiBmb250aWZpY2F0aW9uCgotIGVuc3VyZSBt ZXRob2QtaW52b2NhdGlvbnMgYXJlIGhpZ2hsaWdodGVkIG9ubHkgb24gbGV2ZWwgNAotIGVu c3VyZSBjb25zaXN0ZW50IGZvbnRpZmljYXRpb24gb2YgdmFyaWFibGUgZGVjbGFyYXRpb25z CiAgKGRvbid0IGhpZ2hsaWdodCB1c2FnZSBvZiBhbGwgdmFyaWFibGVzKQotIGZpeCBpc3N1 ZXMgd2l0aCBoaWdobGlnaHRpbmcgdHlwZXMgaW4gbmV3KCkgZXhwcmVzc2lvbnMuCi0gZml4 IGlzc3VlcyB3aXRoIGdlbmVyaWMgdHlwZXMgaW4gdmFyaWFibGUtZGVjbGFyYXRpb25zIG5v dCB1c2luZyAidmFyIi4KLSB1c2UgZmV3ZXIsIG1vcmUgZ2VuZXJhbCBxdWVyaWVzIGZvciBm dW5jdGlvbi1pbnZvY2F0aW9ucy4gc2ltcGxpZnkgY29kZS4KLS0tCiBsaXNwL3Byb2dtb2Rl cy9jc2hhcnAtbW9kZS5lbCB8IDY0ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwgYi9saXNwL3By b2dtb2Rlcy9jc2hhcnAtbW9kZS5lbAppbmRleCBkYTY0ZGFmOTg0OC4uNDczZThmNDlmZDMg MTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCisrKyBiL2xpc3Av cHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCkBAIC02OTYsNyArNjk2LDcgQEAgY3NoYXJwLXRz LW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogICAgOmZlYXR1cmUgJ2V4cHJlc3Npb24KICAg ICcoKGNvbmRpdGlvbmFsX2V4cHJlc3Npb24gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFy aWFibGUtbmFtZS1mYWNlKQogICAgICAocG9zdGZpeF91bmFyeV9leHByZXNzaW9uIChpZGVu dGlmaWVyKSogQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCi0gICAgIChhc3NpZ25t ZW50X2V4cHJlc3Npb24gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1m YWNlKSkKKyAgICAgKGluaXRpYWxpemVyX2V4cHJlc3Npb24gKGFzc2lnbm1lbnRfZXhwcmVz c2lvbiBsZWZ0OiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2Up KSkKIAogICAgOmxhbmd1YWdlICdjLXNoYXJwCiAgICA6ZmVhdHVyZSAnYnJhY2tldApAQCAt NzY0LDggKzc2NCwxMiBAQCBjc2hhcnAtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAg ICAgICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpCiAgICAgICh0eXBlX2Fy Z3VtZW50X2xpc3QKICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkK LSAgICAgKGdlbmVyaWNfbmFtZQotICAgICAgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlw ZS1mYWNlKQorICAgICAodHlwZV9hcmd1bWVudF9saXN0CisgICAgICAoZ2VuZXJpY19uYW1l CisgICAgICAgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkKKyAgICAgKGJh c2VfbGlzdAorICAgICAgKGdlbmVyaWNfbmFtZQorICAgICAgIChpZGVudGlmaWVyKSBAZm9u dC1sb2NrLXR5cGUtZmFjZSkpCiAgICAgIChhcnJheV90eXBlCiAgICAgICAoaWRlbnRpZmll cikgQGZvbnQtbG9jay10eXBlLWZhY2UpCiAgICAgIChjYXN0X2V4cHJlc3Npb24gKGlkZW50 aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKQpAQCAtNzczLDcgKzc3NywxMiBAQCBjc2hh cnAtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAgICh0eXBlX3BhcmFtZXRlcl9j b25zdHJhaW50c19jbGF1c2UKICAgICAgIHRhcmdldDogKGlkZW50aWZpZXIpIEBmb250LWxv Y2stdHlwZS1mYWNlKQogICAgICAodHlwZV9vZl9leHByZXNzaW9uIChpZGVudGlmaWVyKSBA Zm9udC1sb2NrLXR5cGUtZmFjZSkKLSAgICAgKG9iamVjdF9jcmVhdGlvbl9leHByZXNzaW9u IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCisgICAgIChvYmplY3RfY3Jl YXRpb25fZXhwcmVzc2lvbgorICAgICAgdHlwZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2st dHlwZS1mYWNlKQorICAgICAob2JqZWN0X2NyZWF0aW9uX2V4cHJlc3Npb24KKyAgICAgIHR5 cGU6IChnZW5lcmljX25hbWUgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkK KyAgICAgKGFzX2V4cHJlc3Npb24gcmlnaHQ6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5 cGUtZmFjZSkKKyAgICAgKGFzX2V4cHJlc3Npb24gcmlnaHQ6IChnZW5lcmljX25hbWUgKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkpCiAKICAgIDpsYW5ndWFnZSAnYy1z aGFycAogICAgOmZlYXR1cmUgJ2RlZmluaXRpb24KQEAgLTc5Myw3ICs4MDIsNiBAQCBjc2hh cnAtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAgIChyZWNvcmRfZGVjbGFyYXRp b24gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKQogICAgICAobmFtZXNwYWNl X2RlY2xhcmF0aW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKICAgICAg KGJhc2VfbGlzdCAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpCi0gICAgIChw cm9wZXJ0eV9kZWNsYXJhdGlvbiAoZ2VuZXJpY19uYW1lKSkKICAgICAgKHByb3BlcnR5X2Rl Y2xhcmF0aW9uCiAgICAgICB0eXBlOiAobnVsbGFibGVfdHlwZSkgQGZvbnQtbG9jay10eXBl LWZhY2UKICAgICAgIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5h bWUtZmFjZSkKQEAgLTgwNywyOSArODE1LDEwIEBAIGNzaGFycC10cy1tb2RlLS1mb250LWxv Y2stc2V0dGluZ3MKIAogICAgICAoY29uc3RydWN0b3JfZGVjbGFyYXRpb24gbmFtZTogKF8p IEBmb250LWxvY2stdHlwZS1mYWNlKQogCi0gICAgIChtZXRob2RfZGVjbGFyYXRpb24gdHlw ZTogKF8pIEBmb250LWxvY2stdHlwZS1mYWNlKQorICAgICAobWV0aG9kX2RlY2xhcmF0aW9u IHR5cGU6IFsoaWRlbnRpZmllcikgKHZvaWRfa2V5d29yZCldIEBmb250LWxvY2stdHlwZS1m YWNlKQorICAgICAobWV0aG9kX2RlY2xhcmF0aW9uIHR5cGU6IChnZW5lcmljX25hbWUgKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkKICAgICAgKG1ldGhvZF9kZWNsYXJh dGlvbiBuYW1lOiAoXykgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAKLSAgICAg KGludm9jYXRpb25fZXhwcmVzc2lvbgotICAgICAgKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lv bgotICAgICAgIChnZW5lcmljX25hbWUgKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rp b24tbmFtZS1mYWNlKSkpCi0gICAgIChpbnZvY2F0aW9uX2V4cHJlc3Npb24KLSAgICAgICht ZW1iZXJfYWNjZXNzX2V4cHJlc3Npb24KLSAgICAgICAoKGlkZW50aWZpZXIpIEBmb250LWxv Y2stdmFyaWFibGUtbmFtZS1mYWNlCi0gICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LWZ1bmN0aW9uLW5hbWUtZmFjZSkpKQotICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCi0g ICAgICAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCi0gICAg IChpbnZvY2F0aW9uX2V4cHJlc3Npb24KLSAgICAgIChtZW1iZXJfYWNjZXNzX2V4cHJlc3Np b24KLSAgICAgICBleHByZXNzaW9uOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJs ZS1uYW1lLWZhY2UpKQotICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCi0gICAgICBmdW5j dGlvbjogWyhnZW5lcmljX25hbWUgKGlkZW50aWZpZXIpKSBAZm9udC1sb2NrLWZ1bmN0aW9u LW5hbWUtZmFjZQotICAgICAgICAgICAgICAgICAoZ2VuZXJpY19uYW1lICh0eXBlX2FyZ3Vt ZW50X2xpc3QKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWyI8Il0gQGZvbnQt bG9jay1icmFja2V0LWZhY2UKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFsiPiJdIEBmb250LWxvY2stYnJhY2tldC1mYWNlKQotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICldKQotCiAgICAgIChjYXRjaF9kZWNsYXJhdGlvbgogICAg ICAgKChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCiAgICAgIChjYXRjaF9k ZWNsYXJhdGlvbgpAQCAtODM3LDEzICs4MjYsMzAgQEAgY3NoYXJwLXRzLW1vZGUtLWZvbnQt bG9jay1zZXR0aW5ncwogICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxl LW5hbWUtZmFjZSkpCiAKICAgICAgKHZhcmlhYmxlX2RlY2xhcmF0aW9uIChpZGVudGlmaWVy KSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKKyAgICAgKHZhcmlhYmxlX2RlY2xhcmF0aW9uIChn ZW5lcmljX25hbWUgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkKICAgICAg KHZhcmlhYmxlX2RlY2xhcmF0b3IgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUt bmFtZS1mYWNlKQogCiAgICAgIChwYXJhbWV0ZXIgdHlwZTogKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdHlwZS1mYWNlKQorICAgICAocGFyYW1ldGVyIHR5cGU6IChnZW5lcmljX25hbWUg KGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkKICAgICAgKHBhcmFtZXRlciBu YW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCiAKLSAg ICAgKGJpbmFyeV9leHByZXNzaW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxl LW5hbWUtZmFjZSkKLSAgICAgKGFyZ3VtZW50IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh cmlhYmxlLW5hbWUtZmFjZSkpCisgICAgIChsYW1iZGFfZXhwcmVzc2lvbiAoaWRlbnRpZmll cikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCisKKyAgICAgKGRlY2xhcmF0aW9u X2V4cHJlc3Npb24gdHlwZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKQor ICAgICAoZGVjbGFyYXRpb25fZXhwcmVzc2lvbiBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQt bG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQorCisgICA6bGFuZ3VhZ2UgJ2Mtc2hhcnAKKyAg IDpmZWF0dXJlICdmdW5jdGlvbgorICAgJygoaW52b2NhdGlvbl9leHByZXNzaW9uCisgICAg ICBmdW5jdGlvbjogKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgorICAgICAgICAgICAgICAg ICBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpKQor ICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCisgICAgICBmdW5jdGlvbjogKGlkZW50aWZp ZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQorICAgICAoaW52b2NhdGlvbl9l eHByZXNzaW9uCisgICAgICBmdW5jdGlvbjogKG1lbWJlcl9hY2Nlc3NfZXhwcmVzc2lvbgor ICAgICAgICAgICAgICAgICBuYW1lOiAoZ2VuZXJpY19uYW1lIChpZGVudGlmaWVyKSBAZm9u dC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkpKQorICAgICAoaW52b2NhdGlvbl9leHByZXNz aW9uCisgICAgICBmdW5jdGlvbjogKGdlbmVyaWNfbmFtZSAoaWRlbnRpZmllcikgQGZvbnQt bG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpKSkKIAogICAgOmxhbmd1YWdlICdjLXNoYXJwCiAg ICA6ZmVhdHVyZSAnZXNjYXBlLXNlcXVlbmNlCkBAIC05MTYsNyArOTIyLDcgQEAgY3NoYXJw LXRzLW1vZGUKICAgICAgICAgICAgICAgJygoIGNvbW1lbnQgZGVmaW5pdGlvbikKICAgICAg ICAgICAgICAgICAoIGtleXdvcmQgc3RyaW5nIHR5cGUpCiAgICAgICAgICAgICAgICAgKCBj b25zdGFudCBlc2NhcGUtc2VxdWVuY2UgZXhwcmVzc2lvbiBsaXRlcmFsIHByb3BlcnR5KQot ICAgICAgICAgICAgICAgICggYnJhY2tldCBkZWxpbWl0ZXIgZXJyb3IpKSkKKyAgICAgICAg ICAgICAgICAoIGZ1bmN0aW9uIGJyYWNrZXQgZGVsaW1pdGVyIGVycm9yKSkpCiAKICAgOzsg SW1lbnUuCiAgIChzZXRxLWxvY2FsIHRyZWVzaXQtc2ltcGxlLWltZW51LXNldHRpbmdzCi0t IAoyLjM3LjIKCg== --------------TcsAXaMx1zZ5Tkqd6cnXbIF0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 13:41:39 2023 Received: (at 60376) by debbugs.gnu.org; 1 Jan 2023 18:41:39 +0000 Received: from localhost ([127.0.0.1]:41755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC3H8-0005z8-KN for submit@debbugs.gnu.org; Sun, 01 Jan 2023 13:41:38 -0500 Received: from out2.migadu.com ([188.165.223.204]:24353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC3H6-0005z0-Qj for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 13:41:37 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672598495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEsFkPOFIe5eHdw9SGrMCxQdqO3P7luwhgq+aUTcdyM=; b=cQnnTFqlYb0ZqNd0TNW0WoPLs4bytXudzDeKsNtF6JusLd194fCex2SGVBc7i9HXwjPqpZ t3OgqhJJKiLqBuw+FoU+RGtmGsaJWOQhj9liOK/xXbq12P3NxcHNOU9R4MM+C/37Pm7bEA bbHpuZk4ecDXVA2zCzLjaORzzbq+F0bBntRMlwWW9jgYm113am8mvyFOA3Vqk4RsZ2y7Ct m1PBeAftUJ84KTw6+e/YugXaTdYyP2Urate7EwxJ+xHO364HaH9axjJ2zgtUPH5AkDZxVJ roeyfZluwzGRboenBZ2tqaAk8BBQoODof9LMedpZOs1G7Pdc52W4Em7DPixTUA== From: Theodor Thornhill To: jostein@kjonigsen.net, Yuan Fu Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features In-Reply-To: <32bfc790-73fa-27b1-5fd8-50181e66015d@secure.kjonigsen.net> References: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> <8538939b-5639-b8c0-82cc-113930a95ab1@secure.kjonigsen.net> <32bfc790-73fa-27b1-5fd8-50181e66015d@secure.kjonigsen.net> Date: Sun, 01 Jan 2023 19:41:33 +0100 Message-ID: <87a6329jxe.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > On 01.01.2023 18:24, Jostein Kj=C3=B8nigsen wrote: >> Disregard previous patch. >> >> Consider instead please the patch attached to this email. >> >> It does 3 things all in one: >> >> * moves function-call fontification to level 4 only (in its own feature) >> >> * cleans up long-standing issues with "messy" rules for=20 >> function-invocations. Removes the needs for "overrides". >> >> * also fixes issue with fonctification of self/this-method invocations. >> >> Theo: Can you try this patch and see what you think? >> >> --=20 >> >> Jostein > > Disregard again (and sorry for the noise!) > > I've now gone through several files, done quite a bit of testing myself,= =20 > and found another few issues needing to be solved: > > * Inconsistent variable-name fontification (sometimes when used, > sometimes when declared, sometimes not when used, sometimes not when > declared) > * Variable declaration with explicit generic types > * new() expression fontification for generic types. > * Bleeding type-face into brackets for generic return-types in method > definitions > * Types when casting through as-expressions are not fontified at all. > * And more? > > I've solved those and combined all this into this latest patch, which=20 > also moves function-invocation into its own (level 4) feature. > > This patch should be well beyond the "85%" which Eli has requested for=20 > Emacs-29 :) > > *Theo:* Could you give this a test-spin, and I promise to call it a day? = :) > Hi! No worries at all, I'm just glad you found some inspiration :-) This looks good to me. I think we are are all set - there are at least no more features needed. I guess we can still add some tweaks to the highlighting itself before the release? Yuan - you're next ;) Theo From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 01 19:12:35 2023 Received: (at 60376) by debbugs.gnu.org; 2 Jan 2023 00:12:35 +0000 Received: from localhost ([127.0.0.1]:42009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8RO-0006K1-Qi for submit@debbugs.gnu.org; Sun, 01 Jan 2023 19:12:35 -0500 Received: from mail-pg1-f180.google.com ([209.85.215.180]:41689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8RM-0006Jp-Pq for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 19:12:33 -0500 Received: by mail-pg1-f180.google.com with SMTP id 78so17475592pgb.8 for <60376@debbugs.gnu.org>; Sun, 01 Jan 2023 16:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=2Y7DQ2vZvext6PYMIYcAHubH7yMS55aV7uBoy4fBF4w=; b=HfaT9UrOjW2jXObc8KgnXYgfTlppkfV/LrIZh67qb5vqC025L056z18a3jCa/EMbYL eEv+oqX1nkJUGosd3RDhaU/w0dkBGSU8taa7BkZp0aFMVv+zPfqEx8lzd2I1E6ovU7VR cPCF/aPxywbSrnmaJJU9NvyM3fXSBwQezyQTaeJct/6qkpgaHbMCr7rz8O5dE2utOp1D iYq+70QjcGxWI7eBigNY9naRmN09FRr/LqS5YbZ03Civ+O7fV3UaO+NbkGomUlGqgxYI Rt7sq0QKzDSILpMAf3GcyAvCPwjgaYwU4w7QtBAgfRRGJezv5ua1Jdre1EPF0N5q+mDp aV/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Y7DQ2vZvext6PYMIYcAHubH7yMS55aV7uBoy4fBF4w=; b=Ce68qAjkyBk1QD0GLDAobc0wcDkrXIwdJNRLAdpWVXTepv2pY8qogIjzuysMcQ2T8c 8YJUMR5t9RDfT9GsZjEZQg/Hqjdu4jme0+s5biwYnmwgGo7nqCL9BVloiHSfiZVmDm2+ I3OypgymXJyimZzu/3r+6I95JpOOlghm6OOukcAQBgiIc8E9HBHt+oyQsbEdUi+u4vRZ o1c/gqhoU4uRc6xODmV9yeluYBp1yYPXNDz0i1hUVTb9gXjTXA/8cEiOKHiCBwNrI+mH 9wlKnIfbZfaQpkCr/1XdrrCIqwac85P/Wdm1/8Cnw6kEyHq4KGJ0Z3rg8HuLa1vXJI/s M4rQ== X-Gm-Message-State: AFqh2kpsTWZIfNz2nRg/wAVAKU0NAsS7DYfGGNJAwrbkI/6/+zHcTAOE rlRZlnPFlhN2VFktKAL34xk= X-Google-Smtp-Source: AMrXdXuUMRonEhMJdjT1+WxCvPdYsgOHUfKv/8Sq5Iw1I7MBNy1pEnkmc7zH5slE+8AneH0ZE7UHGg== X-Received: by 2002:aa7:8a43:0:b0:576:f334:6740 with SMTP id n3-20020aa78a43000000b00576f3346740mr46783311pfa.23.1672618346787; Sun, 01 Jan 2023 16:12:26 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 127-20020a620485000000b00574b86040a4sm17129408pfe.3.2023.01.01.16.12.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jan 2023 16:12:26 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Message-Id: <0D5F2396-277A-4017-AE0B-371F591BD141@gmail.com> Date: Sun, 1 Jan 2023 16:12:24 -0800 To: Theodor Thornhill X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, eliz@gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Jostein Kj=C3=B8nigsen writes: > >> On 01.01.2023 18:24, Jostein Kj=C3=B8nigsen wrote: >>> Disregard previous patch. >>> >>> Consider instead please the patch attached to this email. >>> >>> It does 3 things all in one: >>> >>> * moves function-call fontification to level 4 only (in its own = feature) >>> >>> * cleans up long-standing issues with "messy" rules for=20 >>> function-invocations. Removes the needs for "overrides". >>> >>> * also fixes issue with fonctification of self/this-method = invocations. >>> >>> Theo: Can you try this patch and see what you think? >>> >>> --=20 >>> >>> Jostein >> >> Disregard again (and sorry for the noise!) >> >> I've now gone through several files, done quite a bit of testing = myself,=20 >> and found another few issues needing to be solved: >> >> * Inconsistent variable-name fontification (sometimes when used, >> sometimes when declared, sometimes not when used, sometimes not = when >> declared) >> * Variable declaration with explicit generic types >> * new() expression fontification for generic types. >> * Bleeding type-face into brackets for generic return-types in = method >> definitions >> * Types when casting through as-expressions are not fontified at = all. >> * And more? >> >> I've solved those and combined all this into this latest patch, which=20= >> also moves function-invocation into its own (level 4) feature. >> >> This patch should be well beyond the "85%" which Eli has requested = for=20 >> Emacs-29 :) >> >> *Theo:* Could you give this a test-spin, and I promise to call it a = day? :) >> > > Hi! > > No worries at all, I'm just glad you found some inspiration :-) > > This looks good to me. I think we are are all set - there are at = least > no more features needed. I guess we can still add some tweaks to the > highlighting itself before the release? > > Yuan - you're next ;) > > Theo Fantastic! I applied the patch, thanks! Yuan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 04:59:53 2023 Received: (at 60376) by debbugs.gnu.org; 2 Jan 2023 09:59:53 +0000 Received: from localhost ([127.0.0.1]:42509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCHbk-00015q-Nr for submit@debbugs.gnu.org; Mon, 02 Jan 2023 04:59:53 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:38195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCHbj-00015d-6e for 60376@debbugs.gnu.org; Mon, 02 Jan 2023 04:59:51 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 80B8C3200930; Mon, 2 Jan 2023 04:59:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 02 Jan 2023 04:59:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1672653584; x= 1672739984; bh=ce0pirZTi+rvUuA9yxMx9IVwEappowPWnFDU2aK1v/4=; b=M dq8YEx94jt8w68KG1csNXBj7pYZNv0ortU1dqlJ3kOITKuIzEiR7Kjg4jEQs+kF6 y6FaiS/cjkipuclqMKao3Lumg0bC6n4txqySKno9h8W+AXQ66N+96O4u7WlryMEO J/RNUmeHmCISSUSEzbEtqRBsSpVwVsdA3vudn2+/y36QOXpHrRKjgIwew4d0U+nm 5KHlso7+Yl514ijIAfV/wtPSXq/K5iS9QmQ5/knn7buJrNrREuZFRZ2e4x/47UJG p6Cf7DSB0EM2qCHh6Oir2urPeaj1URmXMgowL5yWvQtrBsdslC7rDD+1MektVSmZ YeYgAR54y0gY0VOfnxFgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672653584; x=1672739984; bh=ce0pirZTi+rvUuA9yxMx9IVwEapp owPWnFDU2aK1v/4=; b=maoRBkR1W84/ssW+eQppwsMXzcwcmJ6YSyBSzZrjYFC4 4OIushd/18C+w5O0c+6NEXRwtIApe0y8jVtY8KEPT8LC2Z3a4HXpPJeitaekwkFo 9bCOsoIAxgIRSPmeDC+gmPV7VGhIk+T6b9R59+hcIwDP60y7sa/0WIMoyCMSUn5f G4EQuEMsqPdXjFkb5dyJG4FChDSBfaMScNmqu8Ug15wlUPmNGEzCtnRYacT1nVGY 9MqHeHLHNkBCFguvyB7X8BT9OQIWbGKWAZM48mW0iqurowO1OC6CVgoXu8FVwPkR mDpzEJIOGHPFTZuBjB/L2AQs5cyEqMqS53BQNi+RZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfuffvvehfhfgjsehmtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeehudeigeegheehhfeujeefvdehjeei ffejvdeuvefhieegleeghefhjeevgfekteenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhg shgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Jan 2023 04:59:43 -0500 (EST) Content-Type: multipart/mixed; boundary="------------RIJRrmW16hTp0kN0GVkUmFCV" Message-ID: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> Date: Mon, 2 Jan 2023 10:59:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Content-Language: en-US To: Yuan Fu , Theodor Thornhill References: <0D5F2396-277A-4017-AE0B-371F591BD141@gmail.com> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <0D5F2396-277A-4017-AE0B-371F591BD141@gmail.com> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------RIJRrmW16hTp0kN0GVkUmFCV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.01.2023 01:12, Yuan Fu wrote: > Fantastic! I applied the patch, thanks! > > Yuan Great! Thanks! Please note: The previous patch removed a very wide (generic_name (identifier)) selector, which incorrectly caused generic functions to be highlighted as a types. This has lead to having to add in more specific (xxx (generic_name (identifier)) selectors around the codebase to compensate, and the previous patch evidently didn't have "all" the ones we need. Attached is a very small patch which should make support for highlighting generic types more complete. I won't promise it has 100% coverage, but with this in place, I can't see any obvious places in code where I'm missing out. With this in place, the only thing I'd like to improve now (if any) is indentation for object-creation/initialization expressions. I've made a few attempts and can't get those to behave properly. Is this anything you could take a look at, Theo? :) -- Jostein --------------RIJRrmW16hTp0kN0GVkUmFCV Content-Type: text/plain; charset=UTF-8; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 RnJvbSA3NzMyNTQ0MmRlMmIzZDJkNmQ0ZmZjNDIyM2UwMGMwYTk1NmNmMjU2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCAxIEphbiAyMDIzIDIw OjQ2OjAyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRnVydGhlciBnZW5lcmljLXJlbGF0ZWQg aW1wcm92ZW1lbnRzLgoKLS0tCiBsaXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9kZS5lbCB8IDMg KysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlz cC9wcm9nbW9kZXMvY3NoYXJwLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9k ZS5lbAppbmRleCA0NzNlOGY0OWZkMy4uNzlhZmQ3ZjkxZGMgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2NzaGFycC1t b2RlLmVsCkBAIC03NzMsOSArNzczLDEyIEBAIGNzaGFycC10cy1tb2RlLS1mb250LWxvY2st c2V0dGluZ3MKICAgICAgKGFycmF5X3R5cGUKICAgICAgIChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXR5cGUtZmFjZSkKICAgICAgKGNhc3RfZXhwcmVzc2lvbiAoaWRlbnRpZmllcikgQGZv bnQtbG9jay10eXBlLWZhY2UpCisgICAgIChjYXN0X2V4cHJlc3Npb24gKGdlbmVyaWNfbmFt ZSAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpKQogICAgICBbIm9wZXJhdG9y Il0gQGZvbnQtbG9jay10eXBlLWZhY2UKICAgICAgKHR5cGVfcGFyYW1ldGVyX2NvbnN0cmFp bnRzX2NsYXVzZQogICAgICAgdGFyZ2V0OiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBl LWZhY2UpCisgICAgICh0eXBlX2NvbnN0cmFpbnQgdHlwZTogKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdHlwZS1mYWNlKQorICAgICAodHlwZV9jb25zdHJhaW50IHR5cGU6IChnZW5lcmlj X25hbWUgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKSkKICAgICAgKHR5cGVf b2ZfZXhwcmVzc2lvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpCiAgICAg IChvYmplY3RfY3JlYXRpb25fZXhwcmVzc2lvbgogICAgICAgdHlwZTogKGlkZW50aWZpZXIp IEBmb250LWxvY2stdHlwZS1mYWNlKQotLSAKMi4zNy4yCg== --------------RIJRrmW16hTp0kN0GVkUmFCV-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 00:43:44 2023 Received: (at 60376) by debbugs.gnu.org; 3 Jan 2023 05:43:44 +0000 Received: from localhost ([127.0.0.1]:44532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCa5Q-000309-GB for submit@debbugs.gnu.org; Tue, 03 Jan 2023 00:43:44 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCa5N-0002zu-5a for 60376@debbugs.gnu.org; Tue, 03 Jan 2023 00:43:43 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B142A5C054E; Tue, 3 Jan 2023 00:43:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 03 Jan 2023 00:43:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1672724615; x=1672811015; bh=2Drch5Tvyx iZlLdm4A5JpQlkRssvtoY7fECUGYM4mAU=; b=LvV24pVvfG9oy6QxFHRqGHPzVS tV7+J3egxu7SjY/z45p2kDWy65vaG5UV27+ImJKs5AzMIkzJLwOLwda8455vPKkS TTDUQhhRUsR5iXVftXNo/w/NBGmTtWtEfTdRSnyhcTJs2nI1D47nMVxoZzP8Ou/c yiA9e3QfousppvR2ZuKE7gf3rl0NyERCqgZNCpDJ/6gqzBGwV168Z3pa3RoHMfHB 973ZqhnlITTbFkGAinfgJJ0veSQabbGZLakvi2K69OHoc/hfHR1FHjTjoc8rmIK2 r6luJNXfoF1o+6gwshXNbJfHKCd26yz4Zpc/JUY6LiTXisAE4zc4e8tqW8YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672724615; x= 1672811015; bh=2Drch5TvyxiZlLdm4A5JpQlkRssvtoY7fECUGYM4mAU=; b=d DuRA2iKpmt98MWvmAhJJToWKlHpU7SRTylz7pqJwSnjsgZEttZ6wpK3Pjp9HrK08 yNQtHwxDJ4mvCpnVYRnEblcjxZY9giCujmmzDJvTrpkpSMjV+8VzprZ9lOPjuFzt wELTwepMi2mZVRtaASUBDjb4/WcMRJXWiVrxfQmCZzWy73DgD4WEV8i+k0X64Vur WACXUOrqoe3h/6jrfho5lWnq2TTmE5jF6bJyH48jF66TTNQOfscPY61l5ml2dBpE 17FBMj/ylDPIN0GMc4HrVgktBpU9KcuzpnPndusyPwncoMdFH9/DTbWOSFiylR1b KB3SCC3Gk1avCaULH7ebw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeefgdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdtjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeegudevffeifeegveduieetfedt gfetgfffgeeffeeghffgfefhffeggeduvddunecuffhomhgrihhnpehkjhhnihhgshgvnh drnhgvthenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Jan 2023 00:43:35 -0500 (EST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Mime-Version: 1.0 (1.0) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Tue, 3 Jan 2023 06:43:23 +0100 Message-Id: <92941757-2E9A-4883-A3F1-2DCA2E4E8767@secure.kjonigsen.net> References: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> In-Reply-To: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> To: Yuan Fu , Theodor Thornhill X-Mailer: iPhone Mail (20C65) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Yuan: did you forget applying this last patch? :) =E2=80=94 Jostein Kj=C3=B8nigsen https://jostein.kj=C3=B8nigsen.net > On 2 Jan 2023, at 10:59, Jostein Kj=C3=B8nigsen wrote: >=20 > =EF=BB=BF >> On 02.01.2023 01:12, Yuan Fu wrote: >> Fantastic! I applied the patch, thanks! >>=20 >> Yuan >=20 > Great! Thanks! >=20 > Please note: The previous patch removed a very wide (generic_name (identif= ier)) selector, which incorrectly caused generic functions to be highlighted= as a types. >=20 > This has lead to having to add in more specific (xxx (generic_name (identi= fier)) selectors around the codebase to compensate, and the previous patch e= vidently didn't have "all" the ones we need. >=20 > Attached is a very small patch which should make support for highlighting g= eneric types more complete. I won't promise it has 100% coverage, but with t= his in place, I can't see any obvious places in code where I'm missing out. >=20 > With this in place, the only thing I'd like to improve now (if any) is ind= entation for object-creation/initialization expressions. I've made a few att= empts and can't get those to behave properly. >=20 > Is this anything you could take a look at, Theo? :) >=20 > -- > Jostein > From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 01:52:12 2023 Received: (at 60376) by debbugs.gnu.org; 3 Jan 2023 06:52:12 +0000 Received: from localhost ([127.0.0.1]:44554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCb9c-0004zY-FH for submit@debbugs.gnu.org; Tue, 03 Jan 2023 01:52:12 -0500 Received: from mail-pf1-f171.google.com ([209.85.210.171]:41720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCb9X-0004z1-0p for 60376@debbugs.gnu.org; Tue, 03 Jan 2023 01:52:06 -0500 Received: by mail-pf1-f171.google.com with SMTP id k137so15119741pfd.8 for <60376@debbugs.gnu.org>; Mon, 02 Jan 2023 22:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=geY+2OaHXBRKobf/gD8Swdq/6gqLH6trGAAf9ukoLT4=; b=m7y9XEGB33RzJj7lt1TddhkBjB6/Y7+tb+f4vY5TiTRrPAy9ZQjQ+AnMy5Gmdz2lCl o0uChFCl37XcHf/xG7ktHFXZBX6smkm6ahqAauORLlrBgdjqRsLvUkmPdCep8VdVlqbU cM1te38I2fKx+9YdHCO/I8crK+kJtMAsjgH2CihueYYwCtyNTSBGIhQmlDrtzbeNRBBL fbWOPHwhlk9P+rTpanxJ7kPkCUcyrLlTb26A1fjXuwTnkr8MBNQr3KDSIyWIDNaPl4Cb chAFc+B2wQYVpHm563XY2vlJI7Tc2dyZhcefcJhxgrSmEBMzwTaaB7YrpxjDZs5AYsyN 7exQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=geY+2OaHXBRKobf/gD8Swdq/6gqLH6trGAAf9ukoLT4=; b=UYcsnmjQQBSskXnSf92sKeGYmMgl5H+1vifseR9Sz3NeSmW41r4xWKX5A1KIUaDqAm a6Bz6m5hV1HoNDAhlPp/yfsLCKn4sdMXA3xZbdvEm7PKNPhumdVb6+g7/ZA7xDsyElZ/ nUe3Kp+j/sn+jSt6h4MLCSy/zSZMl48RLqXR4xwO9vi67WW7mr9qB5QMcmAUqRsZ0N3g pv24VjYwJ0aFmZ+tDVJtWhFjC9085bPqjqCJh/4sJVoMKba4DtsY6n37QHRU0YJxsdXx zc0hpgzenyCOEFHqdnHjuSppbwpQJopRMY7oqWKwxlUM0UvmEXV6Ly+vxM9Gn86dM8bm g8TQ== X-Gm-Message-State: AFqh2kriKotL9P0aIsHtkR+/XOZewQ2xJeouwWayElOx/HA/Gxg7c/FO A2iVtqqzfWkHn6nrRDxQSHg= X-Google-Smtp-Source: AMrXdXsqLDl7qAlT1DSpcu4yUxrHYfcdiOGalRFWArJsFnp3fGozm5Gzo+oyfPABWyNUlWzhneQGPg== X-Received: by 2002:a05:6a00:4403:b0:581:dacb:1e6f with SMTP id br3-20020a056a00440300b00581dacb1e6fmr15322319pfb.0.1672728717056; Mon, 02 Jan 2023 22:51:57 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j123-20020a625581000000b00574e84ed847sm19699172pfb.24.2023.01.02.22.51.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2023 22:51:56 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Message-Id: <17709903-EEE4-4C03-A715-3A397F1C5279@gmail.com> Date: Mon, 2 Jan 2023 22:51:55 -0800 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, eliz@gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Yuan: did you forget applying this last patch? :) Don=E2=80=99t worry, I didn=E2=80=99t ;-) Since you asked Theo for = confirmation I thought I=E2=80=99d wait for his reply. Yuan From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 02:20:51 2023 Received: (at 60376) by debbugs.gnu.org; 3 Jan 2023 07:20:51 +0000 Received: from localhost ([127.0.0.1]:44576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCbbP-0005gb-AX for submit@debbugs.gnu.org; Tue, 03 Jan 2023 02:20:51 -0500 Received: from out-210.mta0.migadu.com ([91.218.175.210]:35567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCbbM-0005gS-LM for 60376@debbugs.gnu.org; Tue, 03 Jan 2023 02:20:49 -0500 Date: Tue, 03 Jan 2023 08:20:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672730446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P7Ui3CcvLTgW49cT/2+VfAeZSFNULcrpIXUluxrRF+Q=; b=s8XKrLBwvHfYRDRe2y3ywTzCM+fxU3fLotWSzG9/4vYoo7mP6xZdGQpMt5qAv8bP9dxHUJ U5PC5QXwNkoN07NHHJc1N8DRVvqSq0SejTOGirhmKVj0xxGqGHyAFkvWWA0aUXC6bdrDor 06S7kxK1bNw66cIZP5BZKmnnG0c6f7M87yb0FCF2AjtOLrLoxN6T5gLv5sfeAB9qYbwD1S W0Kx933i6UbWMFOwAs8wdlBYvqDwbD/urH5M+oWvldU4inUH4l6C3KijKNwC8eLh6rvKgh LuRDU+Q6pKwOUieMj0XcX13AJdpudU4msJL7+oP0uaR9W0jICxJbfvmwPCxhqA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: Yuan Fu , =?ISO-8859-1?Q?Jostein_Kj=F8nigsen?= Subject: =?US-ASCII?Q?Re=3A_bug=2360376=3A_29=2E0=2E60=3B_Standardize_?= =?US-ASCII?Q?csharp-ts-mode=27s_font-lock__features?= In-Reply-To: <17709903-EEE4-4C03-A715-3A397F1C5279@gmail.com> References: <17709903-EEE4-4C03-A715-3A397F1C5279@gmail.com> Message-ID: <958C81E7-7A18-42BB-BDD4-983D3BAA7FD8@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3 January 2023 07:51:55 CET, Yuan Fu wrote: > >Jostein Kj=C3=B8nigsen writes: > >> Yuan: did you forget applying this last patch? :) > >Don=E2=80=99t worry, I didn=E2=80=99t ;-) Since you asked Theo for confir= mation I >thought I=E2=80=99d wait for his reply=2E > >Yuan I think he meant the indentation fix in a separate patch=2E I'll look at it today, Jostein :) Theo=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 16:27:37 2023 Received: (at 60376) by debbugs.gnu.org; 5 Jan 2023 21:27:37 +0000 Received: from localhost ([127.0.0.1]:53139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXlw-0007to-S3 for submit@debbugs.gnu.org; Thu, 05 Jan 2023 16:27:37 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDXlv-0007tb-Fy for 60376@debbugs.gnu.org; Thu, 05 Jan 2023 16:27:36 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6C9475C00FC; Thu, 5 Jan 2023 16:27:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 05 Jan 2023 16:27:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1672954050; x=1673040450; bh=xSZYsX6p3K 7jjgnXZNMX1LEJiEda8Z98pIgBSjczLI4=; b=YThoNm0rl47PgpNHp8GTtNbVZx 25/XrN4uYK2YoqH0xe/tl3YeMzlljLyNxXxPJf96Kq0siU1V2ThUNcqofuCkPAU6 t1aVCjhMzBnD7wpTxnIwazpg1ZQsk5QVKbWCZNGr841mu1ezAfPaaNVUUQJp1iXj dEWUtXW/RpXN0QIcPQvGO2xyrBZqzIt55KJEBQFch9526OYHAvgr0KPjpKw8mRs3 jZUD5MxvvGSzW7OgHjwo8rhu3keXmXcwBTegscsrfhwA9LmZ7uyCfV8MhKSn505E y46EIutyfgFmhBi5M9HGGNP/J1dyO1Eqfa1at3iOd1t9+vG+G/Y0yvQ7ezUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672954050; x= 1673040450; bh=xSZYsX6p3K7jjgnXZNMX1LEJiEda8Z98pIgBSjczLI4=; b=s kuDRfg0gzjWpDoG/W3n1r68myo5ma9JGgdgoGHw4VZo8PP9eKTt97VcNrzzVjDfD f88QYZu+4fShln2AA26mI3wXxscgoevk/p2jfBryryVZvYScwHjMkjGWTwHZVucm 4SdiCAqoWt6AgK1AcbFrhzDzOGB99azZZ8ARFX8W0t1J2MOEqVhNE7d6IWbxL5lk hEm4fvLRr42DBnlIBETezZ1Itd/rjSUXcIC5UXtsb3UQiFidze5+b4QfaOYJuwfP +QRLWs1Va27tAktZmLg28p2XXfV6niBdB0sNc/0ai0XixVNfvxCg5gIM2R/2nbAQ 0Wa+o0w+92+cZhkrShF4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeekgdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffhvfevfhgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeeifedvjedvueeggfelgedvudek veeitdetkeekhfeuvdefhfffieeuleegteeffeenucffohhmrghinhepkhhjnhhighhsvg hnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Jan 2023 16:27:29 -0500 (EST) Message-ID: <8a49efd8-178d-076c-f28f-e3d913040e26@secure.kjonigsen.net> Date: Thu, 5 Jan 2023 22:27:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Content-Language: en-GB, nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: Yuan Fu , Theodor Thornhill References: <83118080-231f-cadf-a903-58e609a82751@secure.kjonigsen.net> <92941757-2E9A-4883-A3F1-2DCA2E4E8767@secure.kjonigsen.net> In-Reply-To: <92941757-2E9A-4883-A3F1-2DCA2E4E8767@secure.kjonigsen.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 03.01.2023 06:43, Jostein Kjønigsen wrote: > Yuan: did you forget applying this last patch? :) > > — > Jostein Kjønigsen > https://jostein.kjønigsen.net > >> On 2 Jan 2023, at 10:59, Jostein Kjønigsen wrote: >> Great! Thanks! >> >> Please note: The previous patch removed a very wide (generic_name (identifier)) selector, which incorrectly caused generic functions to be highlighted as a types. >> >> This has lead to having to add in more specific (xxx (generic_name (identifier)) selectors around the codebase to compensate, and the previous patch evidently didn't have "all" the ones we need. >> >> Attached is a very small patch which should make support for highlighting generic types more complete. I won't promise it has 100% coverage, but with this in place, I can't see any obvious places in code where I'm missing out. >> >> With this in place, the only thing I'd like to improve now (if any) is indentation for object-creation/initialization expressions. I've made a few attempts and can't get those to behave properly. >> >> Is this anything you could take a look at, Theo? :) >> >> -- >> Jostein >> Given the feature-freeze on emacs-29 now, could someone please get the above patch installed? That would at least make me feel more comfortable :) -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 00:55:49 2023 Received: (at 60376) by debbugs.gnu.org; 6 Jan 2023 05:55:49 +0000 Received: from localhost ([127.0.0.1]:53522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDfhk-0000qr-Kh for submit@debbugs.gnu.org; Fri, 06 Jan 2023 00:55:48 -0500 Received: from mail-pj1-f49.google.com ([209.85.216.49]:33655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDfhj-0000qb-8j; Fri, 06 Jan 2023 00:55:47 -0500 Received: by mail-pj1-f49.google.com with SMTP id fz16-20020a17090b025000b002269d6c2d83so5170162pjb.0; Thu, 05 Jan 2023 21:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=8FVqL3hTjzuM2HccqDdqVGuKTMQaMsFV5L46DnhvrVQ=; b=jbJOIb0KDDWpIBzePM49NJQoPqfelWl/CbvcDmu1Vxe6FRCBwYa3Mqi7IbT/qy0+Zr 3+R1ZXwtp8E6q1cz3pSciKujzv16WgY+dk3Ce6JiEpLrKkutIovr9fEAurt4/lYURo9O 6R8Rt6Keo0D2gcPWQAoN2zUo1+TqIBFJxPBSmLGB2mVN4vjN3/Ba0tU6Hri9HbTqlUUz co0PpwlGwLVSRrwMWvi4UeGgob9fdY4NezRyEhWkK0UrFyqGjUAub8/MRDJ4sjSjgat5 OUBVLnK7aGSL1RhAwSHOC05n6WuOouoD95lAv+Sw3mG+pKVACMPlgUj7owMGYtUHeX5Y ymRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8FVqL3hTjzuM2HccqDdqVGuKTMQaMsFV5L46DnhvrVQ=; b=uxhJcRqaW9y28AyL+cXfRGXuZPl5RnNqMcMa38AtBYYcOf8BUFnU4l+XoRfoFqi0f5 6PMVb3hC8lf/dWhWkNvoFLLmO76meSx5px+kr+ZUsb77Q1/lW9i8zdzInX3TNw8wmHhm obfM1t3n4Y+6lgCoqjFQgybk4MIWaxnlHlSUUxETMPHRXQNKuQV3SAh6rXMBNVuyFDvt rLnzI4t7OJhO3joer0C9Sb7/cuBuCZpibM5bqAtjVkUSYj4OOrbeh29ezihpksQ3Sb/N z8AB3mfHgOXX6xuHOu3ceLIC2lgJGqcsjPwHSlPeJMo7XI0415J5u95+qfB8MDQ6YWk0 HWxg== X-Gm-Message-State: AFqh2krf27tDFY5u9GCNn7pz3RERKo9UKxy8iEs1FJC38cBByILYSEBi Q21dZ7IcNNNbtIEuWjgWt97uGClyHuE= X-Google-Smtp-Source: AMrXdXv24iEorjsJP0hB5qxS6nANu4L8d+lmdGJ0SWVV2r4rp1s7C0CJaW/2WpG3s9Hsy+Z6dGoW2w== X-Received: by 2002:a17:903:40c8:b0:189:ab82:53f5 with SMTP id t8-20020a17090340c800b00189ab8253f5mr43479847pld.40.1672984541355; Thu, 05 Jan 2023 21:55:41 -0800 (PST) Received: from smtpclient.apple (ip68-3-33-122.ph.ph.cox.net. [68.3.33.122]) by smtp.gmail.com with ESMTPSA id u7-20020a170903124700b00189a50d2a3esm26874314plh.241.2023.01.05.21.55.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2023 21:55:41 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Message-Id: Date: Thu, 5 Jan 2023 22:55:39 -0700 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60376 Cc: 60376@debbugs.gnu.org, Eli Zaretskii , 60376-done@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > On 03.01.2023 06:43, Jostein Kj=C3=B8nigsen wrote: >> Yuan: did you forget applying this last patch? :) >> >> =E2=80=94 >> Jostein Kj=C3=B8nigsen >> https://jostein.kj=C3=B8nigsen.net >> >>> On 2 Jan 2023, at 10:59, Jostein Kj=C3=B8nigsen = wrote: >>> Great! Thanks! >>> >>> Please note: The previous patch removed a very wide (generic_name >>> (identifier)) selector, which incorrectly caused generic functions >>> to be highlighted as a types. >>> >>> This has lead to having to add in more specific (xxx (generic_name >>> (identifier)) selectors around the codebase to compensate, and the >>> previous patch evidently didn't have "all" the ones we need. >>> >>> Attached is a very small patch which should make support for >>> highlighting generic types more complete. I won't promise it has >>> 100% coverage, but with this in place, I can't see any obvious >>> places in code where I'm missing out. >>> >>> With this in place, the only thing I'd like to improve now (if any) >>> is indentation for object-creation/initialization expressions. I've >>> made a few attempts and can't get those to behave properly. >>> >>> Is this anything you could take a look at, Theo? :) >>> >>> -- >>> Jostein >>> > > Given the feature-freeze on emacs-29 now, could someone please get the > above patch installed? > > That would at least make me feel more comfortable :) Theo hasn=E2=80=99t get back yet but I=E2=80=99m sure the patch is good, = so I just applied it :-) Yuan From unknown Fri Jun 20 07:13:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Feb 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator