From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 12:10:57 2022 Received: (at submit) by debbugs.gnu.org; 27 Dec 2022 17:10:57 +0000 Received: from localhost ([127.0.0.1]:56391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pADTc-0007KG-Iq for submit@debbugs.gnu.org; Tue, 27 Dec 2022 12:10:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:54018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pADTZ-0007K6-Mi for submit@debbugs.gnu.org; Tue, 27 Dec 2022 12:10:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pADTZ-0005UB-Ck for bug-gnu-emacs@gnu.org; Tue, 27 Dec 2022 12:10:53 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pADTV-0004JA-F7 for bug-gnu-emacs@gnu.org; Tue, 27 Dec 2022 12:10:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0212724028B for ; Tue, 27 Dec 2022 18:10:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672161047; bh=rKZp9pkz8YJ7NSMGxwTuvBssyUGKE1Kvu06DUbrbYZU=; h=From:To:Subject:Date:From; b=dQzDax+Tgy1FZxUzPdcAc2eQBrrs+zZwhkYsERvle7066Dhrt6/zyWeur5VeckOcw pQjMybD4xtlQbngL3tBJNU4ZyNq9fEzY6Cr3cwlL3QX0KnNebw7xcDDxJc4OmAOoke 2ygTnmyEERjbpnAeoapTKqm/TW75X8/KXORUKLk4DMHz56MZm3uzhx36yqdWIi65xT hu1CaMiMVjIqlLoa28nnOlBsjj1neb2dxoWkwQkqxIIvYX1klWDLJwoyjZBP+VnmL+ WEtjqyaf0PePnvYA+Om/bCi7T6u8nhazn7RaVZwy802sDl6GbOhPfCfMg1hHC41ppU lTqZQUABb+XoQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NhLlB49Fjz9rxB for ; Tue, 27 Dec 2022 18:10:46 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: 29.0.60; completion-auto-select set to t skips first argument when completing files Date: Tue, 27 Dec 2022 17:10:52 +0000 Message-ID: <87sfh0ydpf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) If the user option 'completion-auto-select' is set to t, then pressing tab should pop up the completions buffer and select the first option. This works well, unless a file name is being completed. In that case, tab doesn't jump to completion buffer. In fact it appears not to even open it by default. A second press opens the buffer, but only jumps if you don't do anything else for about half a second. A third press of the tab key jumps to the second option. So if you press tab three times, without waiting, you always skip the first completion suggestion. The issue can be reproduced with emacs -Q, by evaluating (setq completion-auto-select t) and then opening a file using C-x C-f, in presumably any directory. In GNU Emacs 29.0.60 (build 9, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.16.0) of 2022-12-25 built on quetzal Repository revision: 940ab2423ca7c7a12aef069804435559d11f68e8 Repository branch: emacs-29 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --with-pgtk --with-imagemagick' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER XIM GTK3 ZLIB Important settings: value of $EMACSLOADPATH: value of $LC_MONETARY: en_US.UTF-8 value of $LC_NUMERIC: en_US.UTF-8 value of $LC_TIME: en_US.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: TeX-PDF-mode: t rcirc-color-mode: t rcirc-track-minor-mode: t bug-reference-prog-mode: t global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t server-mode: t shell-dirtrack-mode: t outline-minor-mode: t flymake-mode: t yas-minor-mode: t editorconfig-mode: t flyspell-mode: t repeat-mode: t display-battery-mode: t display-time-mode: t diff-hl-flydiff-mode: t diff-hl-mode: t winner-mode: t windmove-mode: t corfu-history-mode: t corfu-mode: t vertico-multiform-mode: t electric-pair-mode: t recentf-mode: t save-place-mode: t savehist-mode: t pixel-scroll-precision-mode: t pixel-scroll-mode: t xterm-mouse-mode: t which-function-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/philip/.config/emacs/elpa/transient-0.3.7/transient hides /home/philip/Source/emacs/lisp/transient Features: (shadow emacsbug reposition printing ps-print ps-print-loaddefs lpr edebug aggressive-completion consult-icomplete icomplete aggressive-completion-autoloads tex-info tex texmathp texinfo texinfo-loaddefs goto-addr org-element org-persist org-id org-refile avl-tree oc-basic ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-version org-compat org-macs vertico-buffer consult-imenu loaddefs-gen tar-mode arc-mode archive-mode package-vc inline url-cache url-http url-auth url-gw display-line-numbers quail cl-print modus-vivendi-theme package-x magit-extras jka-compr whitespace sh-script smie treesit executable markdown-mode eglot external-completion array jsonrpc ert debug backtrace solar cal-dst holidays holiday-loaddefs cal-move cal-menu calendar cal-loaddefs mailalias smtpmail ecomplete find-func avy nroff-mode dictionary dictionary-connection emacs-news-mode char-fold misearch multi-isearch rcirc-color rcirc qp flow-fill shortdoc help-fns radix-tree mm-archive sort smiley gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-bcklg dired-aux gnus-dired mule-util bug-reference pulse color sql view grep face-remap magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode git-commit log-edit add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor server magit-mode transient edmacro magit-git magit-section magit-utils crm dash cap-words superword subword go-mode find-file ffap etags fileloop generator xref find-dired vertico-directory orderless vertico-flat buffer-env vc-svn vc-git tramp-cache tramp-sh tramp tramp-loaddefs trampver tramp-integration cus-start files-x tramp-compat shell pcomplete ls-lisp consult-register consult-vertico consult compat-28 compat compat-macs kmacro bookmark vc-backup copyright time-stamp gnus-async gnus-ml disp-table nndraft nnmh utf-7 nnfolder epa-file network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig nntp gnus-cache gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range message yank-media puny dired-x dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win noutline outline checkdoc lisp-mnt flymake-proc flymake yasnippet-snippets warnings yasnippet editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch flyspell ispell init repeat project format-spec battery dbus xml shell-command+ thingatpt rx time sendmail rfc2047 rfc2045 ietf-drums gnus nnheader gnus-util time-date mail-utils range mm-util mail-prsvr compile text-property-search diff-hl-flydiff diff diff-hl log-view pcvs-util vc-dir ewoc vc vc-dispatcher diff-mode derived easy-mmode hippie-exp comint ansi-osc winner windmove corfu-history corfu vertico-multiform vertico cl-extra help-mode elec-pair recentf tree-widget saveplace savehist pixel-scroll cua-base ring xt-mouse modus-operandi-theme modus-themes pcase ansi-color which-func imenu cus-edit pp cus-load icons wid-edit setup finder-inf package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib info shell-command+-autoloads consult-autoloads flymake-proselint-autoloads corfu-autoloads diff-hl-autoloads focus-autoloads haskell-mode-autoloads buffer-env-autoloads avy-autoloads yasnippet-snippets-autoloads magit-autoloads geiser-mit-autoloads inspector-autoloads vc-backup-autoloads bash-completion-autoloads setup-autoloads auctex-autoloads tex-site git-commit-autoloads with-editor-autoloads geiser-guile-autoloads geiser-autoloads transient-autoloads magit-section-autoloads 0x0-autoloads sp-tutor-autoloads debbugs-autoloads package-lint-autoloads compat-autoloads editorconfig-autoloads rcirc-color-autoloads orderless-autoloads vertico-autoloads yasnippet-autoloads markdown-mode-autoloads slime-autoloads macrostep-autoloads writegood-mode-autoloads standard-themes-autoloads go-mode-autoloads dash-autoloads rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 1202524 189548) (symbols 48 49426 399) (strings 32 221461 19471) (string-bytes 1 6254926) (vectors 16 123799) (vector-slots 8 2325456 126251) (floats 8 1449 694) (intervals 56 63711 8599) (buffers 984 101)) From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 18:48:55 2022 Received: (at 60359) by debbugs.gnu.org; 27 Dec 2022 23:48:55 +0000 Received: from localhost ([127.0.0.1]:56757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAJgk-00030T-Mz for submit@debbugs.gnu.org; Tue, 27 Dec 2022 18:48:55 -0500 Received: from heytings.org ([95.142.160.155]:48036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAJgj-00030K-5n for 60359@debbugs.gnu.org; Tue, 27 Dec 2022 18:48:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672184930; bh=Eez665eDjcZLCnykzzG9yBxQhuLjMyeDc04ZavWoIq4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=J2BF0/M5d0lPB06Vy6O+97OgiSWcgDiLzrIseISdv6Gw/0ccAz/iGrEUQAED4QYiC 0PMMnRR7eWb8VgsqFEOKmoNKbyo9Ndio0XadWVKWaafQcpVjbQj1Im2/Q+PTCIlXJF iPy4ZW4NkozzRTsF+O2N/mm8EGRWqpSB4F1gL8OOygY/+S/sfDQPzrbqU6DGJPT1cx BVtDQ7dbNxUim595WJu0Brqui7zZPBlgFJwdkEgCg64/Ji+gvmDEs7MnqqVd6gr70z /In9/V8vgM/x8hIzwQEnCZSfC1pZ9cjxZq9zsV7tyb2ppvqCPMcr+NAhhPSnMSS+0o DyUg/bYMNiEvg== Date: Tue, 27 Dec 2022 23:48:49 +0000 From: Gregory Heytings To: Philip Kaludercic Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <87sfh0ydpf.fsf@posteo.net> Message-ID: <314db4a90e78b4a7714d@heytings.org> References: <87sfh0ydpf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Lw2EtJ7XhK" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Lw2EtJ7XhK Content-Type: text/plain; charset=us-ascii; format=flowed > > If the user option 'completion-auto-select' is set to t, then pressing > tab should pop up the completions buffer and select the first option. > This works well, unless a file name is being completed. In that case, > tab doesn't jump to completion buffer. In fact it appears not to even > open it by default. A second press opens the buffer, but only jumps if > you don't do anything else for about half a second. A third press of > the tab key jumps to the second option. So if you press tab three > times, without waiting, you always skip the first completion suggestion. > > The issue can be reproduced with emacs -Q, by evaluating (setq > completion-auto-select t) and then opening a file using C-x C-f, in > presumably any directory. > Thanks for your bug report. If I set completion-auto-select in emacs -Q, C-x C-f C TAB (or TAB TAB, depending on the value of completion-auto-select) in the Emacs repository behaves as expected. However, C-x C-f src/ TAB does not. Is the latter case what you have in mind, or do I misunderstand what you mean? If not, the attached patch should fix that bug. --Lw2EtJ7XhK Content-Type: text/x-diff; name=Fix-completion-when-completion-auto-select-is-set.patch Content-Transfer-Encoding: base64 Content-ID: <314db4a90ee9c41acebf@heytings.org> Content-Disposition: attachment; filename=Fix-completion-when-completion-auto-select-is-set.patch RnJvbSBjNTQzMGM0MDNiMDUwMDhjZDY3Zjg3ODY1NzFhMmZkNjM0MDIyMzFm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUdWUsIDI3IERl YyAyMDIyIDIzOjQwOjI1ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEZpeCBj b21wbGV0aW9uIHdoZW4gY29tcGxldGlvbi1hdXRvLXNlbGVjdCBpcyBzZXQN Cg0KKiBsaXNwL21pbmlidWZmZXIuZWwgKGNvbXBsZXRpb24tLWRvLWNvbXBs ZXRpb24pOiBEbyBub3QgZGlzcGxheQ0KIkNvbXBsZXRlLCBidXQgbm90IHVu aXF1ZSIgbWVzc2FnZXMgd2hlbiBjb21wbGV0aW9uLWF1dG8tc2VsZWN0IGlz DQpzZXQuICBGaXhlcyBidWcjNjAzNTkuDQotLS0NCiBsaXNwL21pbmlidWZm ZXIuZWwgfCAzICsrLQ0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvbWluaWJ1 ZmZlci5lbCBiL2xpc3AvbWluaWJ1ZmZlci5lbA0KaW5kZXggNmU0MjI5NmU3 YmEuLjUwNzdlNmM3ZTk2IDEwMDY0NA0KLS0tIGEvbGlzcC9taW5pYnVmZmVy LmVsDQorKysgYi9saXNwL21pbmlidWZmZXIuZWwNCkBAIC0xNDc0LDcgKzE0 NzQsOCBAQCBjb21wbGV0aW9uLS1kby1jb21wbGV0aW9uDQogICAgICAgICAg ICAgICAoaWYgKGFuZCAoZXEgdGhpcy1jb21tYW5kIGxhc3QtY29tbWFuZCkg Y29tcGxldGlvbi1hdXRvLWhlbHApDQogICAgICAgICAgICAgICAgICAgKG1p bmlidWZmZXItY29tcGxldGlvbi1oZWxwIGJlZyBlbmQpKQ0KICAgICAgICAg ICAgICAgKGNvbXBsZXRpb24tLWRvbmUgY29tcGxldGlvbiAnZXhhY3QNCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh1bmxlc3MgZXhwZWN0 LWV4YWN0DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodW5s ZXNzIChvciBleHBlY3QtZXhhY3QNCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNvbXBsZXRpb24tYXV0by1zZWxlY3Qp DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJDb21wbGV0 ZSwgYnV0IG5vdCB1bmlxdWUiKSkpKQ0KIA0KICAgICAgICAgICAgIChtaW5p YnVmZmVyLS1iaXRzZXQgY29tcGxldGVkIHQgZXhhY3QpKSkpKSkpKQ0KLS0g DQoyLjM1LjENCg0K --Lw2EtJ7XhK-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 11:25:49 2022 Received: (at 60359) by debbugs.gnu.org; 29 Dec 2022 16:25:49 +0000 Received: from localhost ([127.0.0.1]:60942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAvj3-0002Ce-0R for submit@debbugs.gnu.org; Thu, 29 Dec 2022 11:25:49 -0500 Received: from mout01.posteo.de ([185.67.36.65]:60513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAviz-0002CH-Vp for 60359@debbugs.gnu.org; Thu, 29 Dec 2022 11:25:46 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C2F01240060 for <60359@debbugs.gnu.org>; Thu, 29 Dec 2022 17:25:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672331139; bh=KqV4FaWp1zgK0IeOJQab5yWtG60fT416Y2KSv9qqK3g=; h=From:To:Cc:Subject:Date:From; b=PwKuAVaUiNgkSRpRxt9vtNmXNUiJKzXWCcgGAxgZF+4NeeI39UZq9xH6e/9V9R9H7 6brMyGWSKbesGGEQhOxPatVdUeTlnLmt53qSacaZkUm3oWQRqLsqraRDccznagcfoK ZHmKJ2YWbE0XjOnI5z58TzcMQCVqqOA8BWiZ1jfqFVX8JPgINOQrxtwKR6RapODFMV hobG5wkelr7Zot9IrfYhSGT8C3l1W8KmPNQLKDPrt7bgco6tQEI+HyR0+JcHL6XIn3 MMcRnn4K2EhjvqWlXegc5Sblj/emVsjTvN4EyXogCyQ9yeV3t7ojN7a8AbpclBB8Fk rHEZjbyP6Th4Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NjYfB0c2Fz9rxD; Thu, 29 Dec 2022 17:25:37 +0100 (CET) From: Philip Kaludercic To: Gregory Heytings Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <314db4a90e78b4a7714d@heytings.org> (Gregory Heytings's message of "Tue, 27 Dec 2022 23:48:49 +0000") References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> Date: Thu, 29 Dec 2022 16:25:43 +0000 Message-ID: <87o7rmgos8.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gregory Heytings writes: >> >> If the user option 'completion-auto-select' is set to t, then >> pressing tab should pop up the completions buffer and select the >> first option. This works well, unless a file name is being >> completed. In that case, tab doesn't jump to completion buffer. In >> fact it appears not to even open it by default. A second press >> opens the buffer, but only jumps if you don't do anything else for >> about half a second. A third press of the tab key jumps to the >> second option. So if you press tab three times, without waiting, >> you always skip the first completion suggestion. >> >> The issue can be reproduced with emacs -Q, by evaluating (setq >> completion-auto-select t) and then opening a file using C-x C-f, in >> presumably any directory. >> > > Thanks for your bug report. If I set completion-auto-select in emacs > -Q, C-x C-f C TAB (or TAB TAB, depending on the value of > completion-auto-select) in the Emacs repository behaves as > expected. However, C-x C-f src/ TAB does not. Is the latter case what > you have in mind, or do I misunderstand what you mean? If not, the > attached patch should fix that bug. Yes, that is what I meant and the that fixed the bug. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 12:36:29 2022 Received: (at 60359) by debbugs.gnu.org; 29 Dec 2022 17:36:29 +0000 Received: from localhost ([127.0.0.1]:60981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwpQ-00045q-Qa for submit@debbugs.gnu.org; Thu, 29 Dec 2022 12:36:29 -0500 Received: from heytings.org ([95.142.160.155]:50370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwpO-00045h-Py for 60359@debbugs.gnu.org; Thu, 29 Dec 2022 12:36:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672335385; bh=5LEYeH/P8lnaO5GiGBWNHNTrnFITeb+nr7H290nJKgo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Lv9CuUsO3FY/YbBA71TlweN6JSpCDEpcS/dvCFQmgCaGZgFNRYzUeto4S6NrdR5hn vD/+PbNBdB8WxhfeIg9SYGroipQnN/ZHlJbyfeiLpdR4TiZt4D1T3krv9vAfaSE6Js zDFaJvkWyapjvUgTZkVIkeaCmk+3T3Pt5njb/wr3Nl4CCqCd/u60Aq0Esvt/xa1uYa TSvjG74xG2sTpNvw101qQkQMc0MKtFNuNcxUnDNSeAefQJG6NBHvpEBNAlms3sUDfx wt1nK8N1uuqBgH2YE1hjsLk6ImstOBkOzTXMPcZQ5ENQL/xunR6htJpP0JtqIWfkRG Hjp/QgOA33bVA== Date: Thu, 29 Dec 2022 17:36:25 +0000 From: Gregory Heytings To: Philip Kaludercic , Stefan Monnier , Eli Zaretskii Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <87o7rmgos8.fsf@posteo.net> Message-ID: <86ce08480379b63f235f@heytings.org> References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> <87o7rmgos8.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="owgxso7CIK" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --owgxso7CIK Content-Type: text/plain; format=flowed; charset=us-ascii > > Yes, that is what I meant and the that fixed the bug. > Thanks. Stefan, Eli, any comments on/objections to this patch before I install it? --owgxso7CIK Content-Type: text/x-diff; name=Fix-completion-when-completion-auto-select-is-set.patch Content-Transfer-Encoding: base64 Content-ID: <86ce084803bbcc6eeb5a@heytings.org> Content-Disposition: attachment; filename=Fix-completion-when-completion-auto-select-is-set.patch RnJvbSBjNTQzMGM0MDNiMDUwMDhjZDY3Zjg3ODY1NzFhMmZkNjM0MDIyMzFm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUdWUsIDI3IERl YyAyMDIyIDIzOjQwOjI1ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEZpeCBj b21wbGV0aW9uIHdoZW4gY29tcGxldGlvbi1hdXRvLXNlbGVjdCBpcyBzZXQN Cg0KKiBsaXNwL21pbmlidWZmZXIuZWwgKGNvbXBsZXRpb24tLWRvLWNvbXBs ZXRpb24pOiBEbyBub3QgZGlzcGxheQ0KIkNvbXBsZXRlLCBidXQgbm90IHVu aXF1ZSIgbWVzc2FnZXMgd2hlbiBjb21wbGV0aW9uLWF1dG8tc2VsZWN0IGlz DQpzZXQuICBGaXhlcyBidWcjNjAzNTkuDQotLS0NCiBsaXNwL21pbmlidWZm ZXIuZWwgfCAzICsrLQ0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvbWluaWJ1 ZmZlci5lbCBiL2xpc3AvbWluaWJ1ZmZlci5lbA0KaW5kZXggNmU0MjI5NmU3 YmEuLjUwNzdlNmM3ZTk2IDEwMDY0NA0KLS0tIGEvbGlzcC9taW5pYnVmZmVy LmVsDQorKysgYi9saXNwL21pbmlidWZmZXIuZWwNCkBAIC0xNDc0LDcgKzE0 NzQsOCBAQCBjb21wbGV0aW9uLS1kby1jb21wbGV0aW9uDQogICAgICAgICAg ICAgICAoaWYgKGFuZCAoZXEgdGhpcy1jb21tYW5kIGxhc3QtY29tbWFuZCkg Y29tcGxldGlvbi1hdXRvLWhlbHApDQogICAgICAgICAgICAgICAgICAgKG1p bmlidWZmZXItY29tcGxldGlvbi1oZWxwIGJlZyBlbmQpKQ0KICAgICAgICAg ICAgICAgKGNvbXBsZXRpb24tLWRvbmUgY29tcGxldGlvbiAnZXhhY3QNCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh1bmxlc3MgZXhwZWN0 LWV4YWN0DQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodW5s ZXNzIChvciBleHBlY3QtZXhhY3QNCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNvbXBsZXRpb24tYXV0by1zZWxlY3Qp DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJDb21wbGV0 ZSwgYnV0IG5vdCB1bmlxdWUiKSkpKQ0KIA0KICAgICAgICAgICAgIChtaW5p YnVmZmVyLS1iaXRzZXQgY29tcGxldGVkIHQgZXhhY3QpKSkpKSkpKQ0KLS0g DQoyLjM1LjENCg0K --owgxso7CIK-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 12:45:57 2022 Received: (at 60359) by debbugs.gnu.org; 29 Dec 2022 17:45:57 +0000 Received: from localhost ([127.0.0.1]:60991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwyb-0004Kj-4x for submit@debbugs.gnu.org; Thu, 29 Dec 2022 12:45:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwyZ-0004KX-Lc for 60359@debbugs.gnu.org; Thu, 29 Dec 2022 12:45:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAwyU-0002VX-3e; Thu, 29 Dec 2022 12:45:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KTB/xd5rf/L7dVt2igXiS/xf0BHoYDdkYzXIf77kUIY=; b=A0nNWxMGC1TL zH67yVNi6US8PX9f0+V1c6Z3YuenCU0Xe0Y5mIeyy34xe4nQcmifqVajCcaY8v1TNVMWtBdIkL7Z+ RpDl74ztnadouUhk9EWhZKSKkDyUGFTo7FOwSoSy+nTIeX87mMLWAehc6mQ1+pncCvQEmxYyLxkkl vNFKiUBO+YLrMIcFtssUHzqlFRP4QTdkEy3eSJac8vOPC1rW0uAkAJwlYJRM946FWM4PH+g1k0Igh SVV6RkcEbO5sw8ZANkHP+1wj1EpT3cNSgLcAokT2UyxvVPsEkyGt9fmQZuz5dyKEZYRaaqQL4b9CQ K3BuVdOJdq2howzsFQl/UA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAwyT-0001J4-KQ; Thu, 29 Dec 2022 12:45:49 -0500 Date: Thu, 29 Dec 2022 19:46:02 +0200 Message-Id: <83zgb66r39.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: <86ce08480379b63f235f@heytings.org> (message from Gregory Heytings on Thu, 29 Dec 2022 17:36:25 +0000) Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> <87o7rmgos8.fsf@posteo.net> <86ce08480379b63f235f@heytings.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org, philipk@posteo.net, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 29 Dec 2022 17:36:25 +0000 > From: Gregory Heytings > cc: 60359@debbugs.gnu.org > > > Yes, that is what I meant and the that fixed the bug. > > > > Thanks. > > Stefan, Eli, any comments on/objections to this patch before I install it? No objections from me. Unless Stefan has comments, please install on the release branch, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 13:08:43 2022 Received: (at 60359) by debbugs.gnu.org; 29 Dec 2022 18:08:43 +0000 Received: from localhost ([127.0.0.1]:32788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxKd-0007FX-EH for submit@debbugs.gnu.org; Thu, 29 Dec 2022 13:08:43 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:41357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxKa-0007FF-LE for 60359@debbugs.gnu.org; Thu, 29 Dec 2022 13:08:41 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id AAFDB100006; Thu, 29 Dec 2022 18:08:32 +0000 (UTC) From: Juri Linkov To: Gregory Heytings Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <314db4a90e78b4a7714d@heytings.org> (Gregory Heytings's message of "Tue, 27 Dec 2022 23:48:49 +0000") Organization: LINKOV.NET References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> Date: Thu, 29 Dec 2022 20:06:21 +0200 Message-ID: <86bknmdqzm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks for your bug report. If I set completion-auto-select in emacs -Q, > C-x C-f C TAB (or TAB TAB, depending on the value of > completion-auto-select) in the Emacs repository behaves as > expected. However, C-x C-f src/ TAB does not. Is the latter case what you > have in mind, or do I misunderstand what you mean? If not, the attached > patch should fix that bug. Please omit the message only in case when the completions buffer is shown, then the user will see there are more completions. But after typing e.g. `M-x man TAB` that otherwise does nothing the user should see the message. IOW, in case of `completion-auto-help` please use the same condition `(and (eq this-command last-command) completion-auto-help)` as used to pop up the completions. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 13:18:25 2022 Received: (at 60359) by debbugs.gnu.org; 29 Dec 2022 18:18:25 +0000 Received: from localhost ([127.0.0.1]:32828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxU0-0007X0-Na for submit@debbugs.gnu.org; Thu, 29 Dec 2022 13:18:24 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxTy-0007Wn-Sb for 60359@debbugs.gnu.org; Thu, 29 Dec 2022 13:18:23 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 43C7180181; Thu, 29 Dec 2022 13:18:17 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AA23B80485; Thu, 29 Dec 2022 13:18:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672337895; bh=sltE9DWzitFzu3d+9/yaBjdoHWqlp1S7HanqEAZ4f7w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aj8xhnSh/xdDFA/SNBMYI0GK9lEVL4uPKU2hSiLVpn411FezWv0XusUNYTh+AAWOn QM1kuvQ3Yhfo6Ev9i3gJ62g852cPEndLM7WUgcRPeKpg+SXi2gaTwTdlGGed/8vHsL j9nRZdjIVxAYAEdAzaH8iy1brNttbnYlXJGN07Jab9ccZZ2L4yEpp6X8J5vcT7mnNb X6cDHWpMnrF6V7rI0KWlxh9d6dN4rkv2DFnLQHx7jhVy/p4Gi19ummGeeOyQxj46vb JlviNMZKmmfGLKsibLGlPX6A14zxlpuSQT0Cie9duPEEucDJ51iTXQYvXEbK3PduNn PV3pxuVwKVHYw== Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5EB47120974; Thu, 29 Dec 2022 13:18:15 -0500 (EST) From: Stefan Monnier To: Gregory Heytings Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <86ce08480379b63f235f@heytings.org> (Gregory Heytings's message of "Thu, 29 Dec 2022 17:36:25 +0000") Message-ID: References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> <87o7rmgos8.fsf@posteo.net> <86ce08480379b63f235f@heytings.org> Date: Thu, 29 Dec 2022 13:18:13 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.330 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org, Philip Kaludercic , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gregory Heytings [2022-12-29 17:36:25] wrote: > Stefan, Eli, any comments on/objections to this patch before I install it? Looks fine to me, thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 13:37:58 2022 Received: (at 60359) by debbugs.gnu.org; 29 Dec 2022 18:37:58 +0000 Received: from localhost ([127.0.0.1]:32848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxmw-00080X-Dy for submit@debbugs.gnu.org; Thu, 29 Dec 2022 13:37:58 -0500 Received: from heytings.org ([95.142.160.155]:50456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxmu-00080P-IQ for 60359@debbugs.gnu.org; Thu, 29 Dec 2022 13:37:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672339075; bh=rfuvU9fE2BcfFBYQqHs88wsH4CFF4x3kQtZnVFkzP3M=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=TyG5DzgPybKGn9jspw+T31YZ3tPQA54vxdG6yHMb/oDYAcoO0aQwAYeE+N9YgRiMg rgrPbICDy9FxJU7trbKsLPttm0tOWOozAevjCObNW1Ln7gs4zIlsFJ3JHwEsZ706ya Nks0gfNSKthJDPf/glhLCKloh6xrEI5Ite+McUqaHYvRTQ41SDn+DI4BCNdxKQz3PI 3lYybY2JIMq8cwVHgcltPHQmclUDCgvN+jjE9JsJ0vg9+8yCvb1iWUtL5EOTEsa9Vh Sh0Bv7yPtTaFu8l/g0MIBYGpYOlFpvGfDYaPDvGNJq2HTQ55qxLMDJJT9odf7JA0pj 3uCqEntBiT2dQ== Date: Thu, 29 Dec 2022 18:37:54 +0000 From: Gregory Heytings To: Juri Linkov Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <86bknmdqzm.fsf@mail.linkov.net> Message-ID: <86ce0848031a81ca4ddb@heytings.org> References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> <86bknmdqzm.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Thanks for your bug report. If I set completion-auto-select in emacs >> -Q, C-x C-f C TAB (or TAB TAB, depending on the value of >> completion-auto-select) in the Emacs repository behaves as expected. >> However, C-x C-f src/ TAB does not. Is the latter case what you have >> in mind, or do I misunderstand what you mean? If not, the attached >> patch should fix that bug. > > Please omit the message only in case when the completions buffer is > shown, then the user will see there are more completions. But after > typing e.g. `M-x man TAB` that otherwise does nothing the user should > see the message. IOW, in case of `completion-auto-help` please use the > same condition `(and (eq this-command last-command) > completion-auto-help)` as used to pop up the completions. > You mean this, right? diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 6e42296e7ba..7a720cf2c0a 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1474,7 +1474,10 @@ completion--do-completion (if (and (eq this-command last-command) completion-auto-help) (minibuffer-completion-help beg end)) (completion--done completion 'exact - (unless expect-exact + (unless (or expect-exact + (and completion-auto-select + (eq this-command last-command) + completion-auto-help)) "Complete, but not unique")))) (minibuffer--bitset completed t exact)))))))) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 13:49:08 2022 Received: (at 60359) by debbugs.gnu.org; 29 Dec 2022 18:49:08 +0000 Received: from localhost ([127.0.0.1]:32864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxxk-0002CJ-I4 for submit@debbugs.gnu.org; Thu, 29 Dec 2022 13:49:08 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAxxi-0002Bl-FI for 60359@debbugs.gnu.org; Thu, 29 Dec 2022 13:49:07 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6EDF760002; Thu, 29 Dec 2022 18:48:57 +0000 (UTC) From: Juri Linkov To: Gregory Heytings Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <86ce0848031a81ca4ddb@heytings.org> (Gregory Heytings's message of "Thu, 29 Dec 2022 18:37:54 +0000") Organization: LINKOV.NET References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> <86bknmdqzm.fsf@mail.linkov.net> <86ce0848031a81ca4ddb@heytings.org> Date: Thu, 29 Dec 2022 20:48:35 +0200 Message-ID: <864jtedp18.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60359 Cc: 60359@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Please omit the message only in case when the completions buffer is >> shown, then the user will see there are more completions. But after >> typing e.g. `M-x man TAB` that otherwise does nothing the user should see >> the message. IOW, in case of `completion-auto-help` please use the same >> condition `(and (eq this-command last-command) completion-auto-help)` as >> used to pop up the completions. > > You mean this, right? > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index 6e42296e7ba..7a720cf2c0a 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1474,7 +1474,10 @@ completion--do-completion > (if (and (eq this-command last-command) > completion-auto-help) > (minibuffer-completion-help beg end)) > (completion--done completion 'exact > - (unless expect-exact > + (unless (or expect-exact > + (and completion-auto-select > + (eq this-command last-command) > + completion-auto-help)) > "Complete, but not unique")))) > > (minibuffer--bitset completed t exact)))))))) Yep, this looks like the right thing to do. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 16:54:48 2022 Received: (at 60359-done) by debbugs.gnu.org; 29 Dec 2022 21:54:48 +0000 Received: from localhost ([127.0.0.1]:33058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB0rQ-0001I0-91 for submit@debbugs.gnu.org; Thu, 29 Dec 2022 16:54:48 -0500 Received: from heytings.org ([95.142.160.155]:50664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pB0rN-0001Hp-Vx for 60359-done@debbugs.gnu.org; Thu, 29 Dec 2022 16:54:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672350883; bh=Tguiblcbu0GKHWeZ7v+tbIcbAd+oEK/sEjT+ao8o4AM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ddHXgiZW4SwsgYHoCInMdLJp4On5WoPuH4jhLW6Bv3jmj3z+UzSTXCTAJrQcxgxjV cPtZ1ibErI83iiP8dps0KAofMgtukXWwSXUSxfUlhJ2uGTPrvG6HR3dm5RxwrEhO4W h0Tn6VPbMq+JSyoeng/SSYZ8hookbAfbEAQRXFzhCyo/Vw8orQe23vk+bIyqz0jO6D 7IFuKM50qQ++6FE66CkTytmlQcdii8pehjV8hQYdtKG0jASiC2Wx214n2khRIZkxwS 7Wp5wreNQXzryPIfvyHjJFCt9NfQuUvLb4AUGp+3Jb+zBKY67J0o+cUpUBzyRBwMYS XNE4IWh5x82qg== Date: Thu, 29 Dec 2022 21:54:42 +0000 From: Gregory Heytings To: Philip Kaludercic , Juri Linkov , Stefan Monnier , Eli Zaretskii Subject: Re: bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files In-Reply-To: <864jtedp18.fsf@mail.linkov.net> Message-ID: <86ce0848038366b93cde@heytings.org> References: <87sfh0ydpf.fsf@posteo.net> <314db4a90e78b4a7714d@heytings.org> <86bknmdqzm.fsf@mail.linkov.net> <86ce0848031a81ca4ddb@heytings.org> <864jtedp18.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60359-done Cc: 60359-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Yep, this looks like the right thing to do. > Thanks! Pushed (beed746f94), and closing. From unknown Mon Jun 23 13:12:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Jan 2023 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator