GNU bug report logs - #60338
[PATCH] Add option to present server changes as diffs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Subject: bug#60338: closed (Re: bug#60338: [PATCH] Add option to present
 server changes as diffs)
Date: Sat, 02 Sep 2023 09:54:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#60338: [PATCH] Add option to present server changes as diffs

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 60338 <at> debbugs.gnu.org.

-- 
60338: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60338
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: João Távora <joaotavora <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: dmitry <at> gutov.dev, Philip Kaludercic <philipk <at> posteo.net>,
 Eli Zaretskii <eliz <at> gnu.org>, 60338-done <at> debbugs.gnu.org
Subject: Re: bug#60338: [PATCH] Add option to present server changes as diffs
Date: Sat, 02 Sep 2023 10:55:56 +0100

Eshel Yaron <me <at> eshelyaron.com> writes:

> João Távora <joaotavora <at> gmail.com> writes:
>
>> OK, Eshel
>>
>> I think I fixed all these issues in the latest
>> fdf6c164efd0bb467d0d46460161c146e955a48c which I just
>> pushed to master.  Please have a look.
>
> Looks good, and works well too, thank you!

I'm glad to hear that.  I must say that altough I like the new
functionality myself -- both the new user option and the diff view --
the current implementation of the latter leaves much to be desired.

I've pushed a further commit to simplify it, but it's complicated and
brittle.  A little change to diff.el would simplify some of it, but then
you can't easily publish those changes to Emacs < 29.

Anyway I invite everyone to have a look and try to improve it, perhaps
moving it out of Eglot into the shiny new "refactoring interface" if
those ever become a thing.

In the meantime, I'm going to close this.  Thanks everybody.

João

[Message part 3 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add option to present server changes as diffs
Date: Mon, 26 Dec 2022 13:42:04 +0000

[Message part 4 (text/plain, inline)]

X-CC-Debbugs: João Távora <joaotavora <at> gmail.com>

I'd like to propose adding an option that makes server modifications by
Eglot less invasive.  The current behaviour is to make the changes
directly in a buffer and open the remaining files to make the
modifications in those as well (?).  If `eglot-use-diffs' is enabled,
all confirmations are prepared as patches in a pop-up buffer that the
user can review and apply at will.  To my knowledge there is no general
`diff-apply-hunk' that will apply all the changes from a buffer, but
that is a separate issue that can be fixed in a separate patch.

(Note, I'm still testing emacs-29, so the patch was developed on that
branch.  But it should be applied to master)

[Message part 5 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.