GNU bug report logs - #60338
[PATCH] Add option to present server changes as diffs

Previous Next

Full log

Message #41 received at 60338 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 60338 <at> debbugs.gnu.org, joaotavora <at> gmail.com
Subject: Re: bug#60338: [PATCH] Add option to present server changes as diffs
Date: Mon, 12 Jun 2023 15:52:03 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: 60338 <at> debbugs.gnu.org,  joaotavora <at> gmail.com
> Date: Mon, 12 Jun 2023 12:35:09 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Isn't there a better way of presenting the edits in human-readable
> > form than apply them and then run Diff?  What format is used by the
> > server itself to send the edits?
> 
> The server sends a JSON message.  Here is an example from a little toy
> project of mine in C, where I intentionally uncommented a #include
> directive:

And we cannot generate the Diff format from this?

> > Besides, this assumes the 'diff' command is available, which is not
> > portable -- one more reason not to go that way, or at leas provide an
> > alternative.
> 
> I am personally fond of this approach, because I get a regular text
> buffer that I can store or send someone.  The fact that diff is not
> available everywhere (even though I would guess any system with a
> language server /should/ have diff installed), is an argument against
> enabling this behaviour by default, not against providing this interface.

What do we suggest to people who don't have Diff, though?  Nothing?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.