GNU bug report logs - #60338
[PATCH] Add option to present server changes as diffs

Previous Next

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: 60338 <at> debbugs.gnu.org, João Távora <joaotavora <at> gmail.com>
Subject: bug#60338: [PATCH] Add option to present server changes as diffs
Date: Sun, 11 Jun 2023 21:33:40 +0000

[Message part 1 (text/plain, inline)]

The previous patch couldn't be applied onto master anymore, so I have
adjusted it and merged the user option into 'eglot-confirm-server-initiated-edits'.

[0001-Allow-for-LSP-edits-to-be-generated-as-diffs.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

In addition to that, here is a cheap command that would allow for a
patch to be applied with a single command.  I've bound it to C-c C-x,
but perhaps there is a more intuitive key?

[0002-Add-command-to-apply-an-entire-diff-at-once.patch (text/x-diff, attachment)]

[Message part 5 (text/plain, inline)]

Philip Kaludercic <philipk <at> posteo.net> writes:

> X-CC-Debbugs: 
>
> I'd like to propose adding an option that makes server modifications by
> Eglot less invasive.  The current behaviour is to make the changes
> directly in a buffer and open the remaining files to make the
> modifications in those as well (?).  If `eglot-use-diffs' is enabled,
> all confirmations are prepared as patches in a pop-up buffer that the
> user can review and apply at will.  To my knowledge there is no general
> `diff-apply-hunk' that will apply all the changes from a buffer, but
> that is a separate issue that can be fixed in a separate patch.
>
> (Note, I'm still testing emacs-29, so the patch was developed on that
> branch.  But it should be applied to master)

-- 
Philip Kaludercic

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.