GNU bug report logs - #60331
29.0.60; ERC 5.4.1: ERC cannot join channels without the networks module

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60331 in the body.
You can then email your comments to 60331 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: bug-gnu-emacs <at> gnu.org
Cc: Lele Gaifax <lele <at> metapensiero.it>
Subject: 29.0.60; ERC 5.4.1: ERC cannot join channels without the networks
 module
Date: Sun, 25 Dec 2022 21:46:48 -0800

[Message part 1 (text/plain, inline)]

Tags: patch

This is in reference to

  https://lists.gnu.org/archive/html/help-gnu-emacs/2022-12/msg00651.html

which affects query buffers as well as channels in what will become ERC
5.5 (both Emacs 29 and HEAD). To reproduce from emacs -Q:

  (require 'erc)
  (setq erc-modules (remq 'networks erc-modules))
  (erc :server "127.0.0.1" :port 6667 :nick "tester")

The attached patch tries to address this in a hopefully agreeable
manner. Thanks.


In GNU Emacs 29.0.60 (build 2, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.17.6) of 2022-12-25 built on localhost
Repository revision: 6c00d126e7fe1f6e42a0c9454c2ab4a29dcd5989
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (Workstation Edition)

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config
gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils erc iso8601 time-date
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map thingatpt pp format-spec cl-loaddefs cl-lib erc-backend erc-goodies
erc-networks byte-opt gv bytecomp byte-compile erc-common erc-compat
erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process emacs)

Memory information:
((conses 16 64557 5365)
 (symbols 48 8608 0)
 (strings 32 23660 1450)
 (string-bytes 1 684415)
 (vectors 16 15218)
 (vector-slots 8 209308 10203)
 (floats 8 24 31)
 (intervals 56 222 0)
 (buffers 976 11))

[0001-Warn-of-absent-networks-module-in-ERC.patch (text/x-patch, attachment)]

Message #10 received at 60331-done <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 60331-done <at> debbugs.gnu.org
Cc: Lele Gaifax <lele <at> metapensiero.it>, emacs-erc <at> gnu.org
Subject: Re: bug#60331: 29.0.60; ERC 5.4.1: ERC cannot join channels without
 the networks module
Date: Wed, 28 Dec 2022 07:08:57 -0800

"J.P." <jp <at> neverwas.me> writes:

> Tags: patch
>
> This is in reference to
>
>   https://lists.gnu.org/archive/html/help-gnu-emacs/2022-12/msg00651.html
>
> which affects query buffers as well as channels in what will become ERC
> 5.5 (both Emacs 29 and HEAD). To reproduce from emacs -Q:
>
>   (require 'erc)
>   (setq erc-modules (remq 'networks erc-modules)) ; or delq even (ahem)
>   (erc :server "127.0.0.1" :port 6667 :nick "tester")
>
> The attached patch tries to address this in a hopefully agreeable
> manner. Thanks.

This has been addressed in a slightly more responsible manner than that
originally proposed. In a pinch, third-party code can opt out of the
scary message by locally removing it from an internal hook during mode
or local-module setup (while ideally also alerting us to the need for a
public analog). If anyone takes issue with this approach or has a better
one in mind, please say so relatively soon. In the meantime, I'm closing
this bug report. Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.