GNU bug report logs - #60319
[PATCH] services: certbot: Fix broken link.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60319 in the body.
You can then email your comments to 60319 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] services: certbot: Fix broken link.
Date: Sun, 25 Dec 2022 15:03:17 -0600

* gnu/services/certbot.scm (certbot-renewal-jobs): Fix broken link.
---
 gnu/services/certbot.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
index 7dfdad9874..cf3112a7dc 100644
--- a/gnu/services/certbot.scm
+++ b/gnu/services/certbot.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
 ;;; Copyright © 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -148,7 +149,7 @@ (define certbot-command
 (define (certbot-renewal-jobs config)
   (list
    ;; Attempt to renew the certificates twice per day, at a random minute
-   ;; within the hour.  See https://certbot.eff.org/all-instructions/.
+   ;; within the hour.  See https://eff-certbot.readthedocs.io/
    #~(job '(next-minute-from (next-hour '(0 12)) (list (random 60)))
           #$(certbot-command config))))
 
-- 
2.38.1

Message #10 received at 60319-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 60319-done <at> debbugs.gnu.org
Subject: Re: bug#60319: [PATCH] services: certbot: Fix broken link.
Date: Tue, 03 Jan 2023 16:36:09 -0500

Hi,

jgart <jgart <at> dismail.de> writes:

> * gnu/services/certbot.scm (certbot-renewal-jobs): Fix broken link.
> ---
>  gnu/services/certbot.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
> index 7dfdad9874..cf3112a7dc 100644
> --- a/gnu/services/certbot.scm
> +++ b/gnu/services/certbot.scm
> @@ -6,6 +6,7 @@
>  ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
>  ;;; Copyright © 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
>  ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
> +;;; Copyright © 2022 jgart <jgart <at> dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.

Changes of less than 10 lines of code are not substantial enough to be
protected by copyright, so I've dropped the above hunk.

> @@ -148,7 +149,7 @@ (define certbot-command
>  (define (certbot-renewal-jobs config)
>    (list
>     ;; Attempt to renew the certificates twice per day, at a random minute
> -   ;; within the hour.  See https://certbot.eff.org/all-instructions/.
> +   ;; within the hour.  See https://eff-certbot.readthedocs.io/
>     #~(job '(next-minute-from (next-hour '(0 12)) (list (random 60)))
>            #$(certbot-command config))))

I've re-added the trailing period and pushed!

-- 
Thanks,
Maxim

Message #13 received at 60319 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 60319 <at> debbugs.gnu.org
Subject: Re: bug#60319: closed (Re: bug#60319: [PATCH] services: certbot:
 Fix broken link.)
Date: Wed, 04 Jan 2023 01:23:34 +0000

Thanks for the review! Much appreciated. I'll keep that in mind for the next patches.

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.