GNU bug report logs - #60305
Help with hideshow

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60305 in the body.
You can then email your comments to 60305 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: Help with hideshow
Date: Sun, 25 Dec 2022 01:24:44 -0800

Is anyone familiar with hideshow? I tried to add tree-sitter support for it but didn’t quite make it. 

I just generalized some defun functions so that one can define a “thing” with a regexp that matches node types. So now it should be relatively straightforward for each major mode to define a “block” thing, like they do for defun, and a hideshow-treesitter bridge can use treesit-thing-at-point, treesit-beginning-of-thing, etc, to support hideshow.

It would be great if someone familiar with hideshow would like to give it a try, or educate me how to set hs-special-modes-alist.

On the separate note, I wonder if the hideshow support can go on the release branch.

Thanks,
Yuan

Message #8 received at 60305 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 60305 <at> debbugs.gnu.org
Subject: Re: bug#60305: Help with hideshow
Date: Sun, 25 Dec 2022 11:40:17 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sun, 25 Dec 2022 01:24:44 -0800
> 
> On the separate note, I wonder if the hideshow support can go on the release branch.

It depends on what it will look like.  If the addition of that doesn't
touch hideshow code used without tree-sitter, and if the tree-sitter
support is opt-in, I think we can have it on the release branch -- if
you manage to do this soon enough.  (I'm planning on a complete
feature freeze on the release branch in a week or so.)

Message #11 received at 60305 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60305-done <at> debbugs.gnu.org, 60305 <at> debbugs.gnu.org
Subject: Re: bug#60305: Help with hideshow
Date: Sun, 25 Dec 2022 09:58:48 -0800

Oops, this some how got sent to debbugs, I’ll resend to emacs-devel.

> On Dec 25, 2022, at 1:40 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Sun, 25 Dec 2022 01:24:44 -0800
>> 
>> On the separate note, I wonder if the hideshow support can go on the release branch.
> 
> It depends on what it will look like.  If the addition of that doesn't
> touch hideshow code used without tree-sitter, and if the tree-sitter
> support is opt-in, I think we can have it on the release branch -- if
> you manage to do this soon enough.  (I'm planning on a complete
> feature freeze on the release branch in a week or so.)

In that case, going on master is probably better. Hideshow isn’t that critical or game-changing.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.